[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 Marcel de Rooy changed: What|Removed |Added Attachment #82344|0 |1 is obsolete|| --- Comment #12 from Marcel de Rooy --- Created attachment 82352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82352=edit Bug 21567: Remove Koha_ExternalContent_RecordedBooks.t This patch removes this file. The included tests are similar to those in the db_dependent section, with the difference that this have some things mocked. But the tests still require name resolution and connecting to the RB servers. This situation breaks package building without any noticeable gain. The feature could be better tested by mocking WebService::ILS calls (so no external world contact), but it belongs to a separate bug report. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21840] Fix some typos in the templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21840 --- Comment #3 from Katrin Fischer --- (In reply to Katrin Fischer from comment #2) > Some possible issue here, as this showed up as a template variable to > translate and not as %s: > > intranet-tmpl/prog/en/modules/acqui/basket.tt:547 > Can't cancel order, ([% books_loo.holds_on_order | html %]) holds are linked > with this order cancel holds first Same here: parcel.tt Can't cancel order, ([% loop_order.holds_on_order | html %]) holds are linked with this order cancel holds first -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21840] Fix some typos in the templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21840 --- Comment #2 from Katrin Fischer --- Some possible issue here, as this showed up as a template variable to translate and not as %s: intranet-tmpl/prog/en/modules/acqui/basket.tt:547 Can't cancel order, ([% books_loo.holds_on_order | html %]) holds are linked with this order cancel holds first -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21840] Fix some typos in the templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21840 --- Comment #1 from Katrin Fischer --- intranet-tmpl/prog/en/modules/ill/ill-requests.tt:13 Bibliograpic record ID -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21840] New: Fix some typos in the templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21840 Bug ID: 21840 Summary: Fix some typos in the templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Found while translating: Are you sure you wish to remove this item from it's rota -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21839] Fix capitalization for "Print Label"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21839 --- Comment #3 from Katrin Fischer --- Thx Andreas! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21839] Fix capitalization for "Print Label"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21839 Andreas Roussos changed: What|Removed |Added Attachment #82349|0 |1 is obsolete|| --- Comment #2 from Andreas Roussos --- Created attachment 82351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82351=edit Bug 21839: Fix capitalization of "Print Label" link Fixed the spelling to follow Koha's capitalization rules to "Print label". To test: - Edit an item in the GUI - Look at the Actions pull down in the table above the item form Signed-off-by: Andreas Roussos -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21839] Fix capitalization for "Print Label"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21839 Andreas Roussos changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17151] Extended patron attributes not importing when using double quotes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17151 Carlos Lopez changed: What|Removed |Added CC||clo...@dml.vic.edu.au --- Comment #1 from Carlos Lopez --- We've found (version 1711) that if we do not double-quote or separately double-quote patron attributes only one will be loaded (example 1: ORG:PILGRIM,ROLE:UG) (example 2: "ORG:PILGRIM","ROLE:UG") but if we put double-quotes around the entire set of patron attributes they load properly (example 3: "ORG:PILGRIM,ROLE:UG") -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19306] Adding hooks to the plugin system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19306 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17084] Automatic debian/control updates (master)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 --- Comment #35 from Nightly Build Bot --- Created attachment 82350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82350=edit Bug 17084 - Automatic debian/control updates (unstable/master) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21777] Checkouts table in circulation is out of alignment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21777 Jonathan Druart changed: What|Removed |Added Summary|Checkouts table in |Checkouts table in |circulation is out of |circulation is out of |alignment (Bug 21562) |alignment -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 Jonathan Druart changed: What|Removed |Added CC||srd...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 Jonathan Druart changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 --- Comment #12 from Jonathan Druart --- I have tried just 2 (on Firefox): * http://pro.kohadev.org/cgi-bin/koha/members/memberentry.pl?op=modify=circ=5=PT => JS error - "TypeError: c is null" hc-sticky_18.0600060.js:11:4777 * http://pro.kohadev.org/cgi-bin/koha/acqui/supplier.pl?booksellerid=1=enter => The toolbar is *behind* the other divs (!) https://screenshots.firefox.com/iWOtec6wmNaOTsbG/pro.kohadev.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21839] Fix capitalization for "Print Label"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21839 --- Comment #1 from Katrin Fischer --- Created attachment 82349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82349=edit Bug 21839: Fix capitalization of "Print Label" link Fixed the spelling to follow Koha's capitalization rules to "Print label". To test: - Edit an item in the GUI - Look at the Actions pull down in the table above the item form -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21839] Fix capitalization for "Print Label"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21839 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21839] New: Fix capitalization for "Print Label"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21839 Bug ID: 21839 Summary: Fix capitalization for "Print Label" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: katrin.fisc...@bsz-bw.de Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21838] Wrong alignment of instructors in course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21838 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 82348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82348=edit Screenshot (Error) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21838] New: Wrong alignment of instructors in course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21838 Bug ID: 21838 Summary: Wrong alignment of instructors in course reserves Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org If you add more than one instructor, they are not aligned correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21836] Hold-found modal missing link to borrower account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21836 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20194] Display both biblioitems.itemtype and items.itype in circulation screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20194 --- Comment #12 from Katrin Fischer --- I am not sure about the terminology of using Record type - this is still an itemtype, just from a different level. I think it gives a wrong idea of the usage. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11113] Title of pages are not easy to translate in some languages, especially in french
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- I agree, the construction is bad and in German it doesn't work well either as online catalog would be one word. Just a little worried about having to retranslate them all too! :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 --- Comment #11 from Katrin Fischer --- On the advanced search, click more options. Make the browser window width about half of he screen width. Scroll down - the toolbar vanishes when reaching the bottom. Tested in Chrome. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #10 from Katrin Fischer --- - Authorities -> Create or edit an authority It all worked really well until this one. Not sure how to describe it! When scrolling down the form fields remain visible while scrolling through the floating toolbar? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #35 from Katrin Fischer --- Well done! Welcome to the Koha developers! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Katrin Fischer changed: What|Removed |Added Attachment #82337|0 |1 is obsolete|| --- Comment #34 from Katrin Fischer --- Created attachment 82347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82347=edit Bug 18584: Our legacy code contains trailing-spaces This patch removes trailing spaces from acquisitions-search.inc Mentored-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 Owen Leonard changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 --- Comment #9 from Owen Leonard --- Created attachment 82346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82346=edit Bug 21751: fixFloat toolbar not displaying properly in Chrome This patch replaces the fixFloat jQuery plugin with a new one: HC-sticky (https://github.com/somewebmedia/hc-sticky). This plugin provides the same functionality without the page-reflow problems fixFloat suffers from. To test, apply the patch and test the behavior of the floating toolbar on these pages: - Acquisitions -> Vendor -> Vendor details - Acquisitions -> Vendor -> View basket - On both these pages, test toolbar behavior before and after expanding the "Orders search" options at the top of the page. - Administration -> System preferences - Authorities -> Create or edit an authority - Catalog -> Advanced search - Search results - Catalog -> Item search - Cataloging -> Add or edit a record - Open the plugin window for the 008 field - Tools -> Label creator -> New label batch -> Add items -> Search -> Results - Patrons -> New patron - Test before and after expanding the patron search options at the top of the page - Tools -> Automatic item modifications by age -> Edit - Tools -> Notices & slips -> Edit - Lists -> View list Check that the About page has been updated with information about the plugin. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21837] Overdues report shoudln't set homebranchfilter as holdingbranchfilter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21837 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21837] Overdues report shoudln't set homebranchfilter as holdingbranchfilter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21837 --- Comment #1 from Nick Clemens --- Created attachment 82345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82345=edit Bug 21837: Don't set holdingbranch filter using selected homebranch filter To recreate: 1 - Open the overdues report (don't worry if you don't have results) 2 - Choose to filter by homebranch 3 - Note the holdingbranch filter is set to the selected homebranch 4 - Apply patch 5 - Clear filters 6 - repeat 7 - only homebranch is set -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21837] Overdues report shoudln't set homebranchfilter as holdingbranchfilter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21837 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21837] New: Overdues report shoudln't set homebranchfilter as holdingbranchfilter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21837 Bug ID: 21837 Summary: Overdues report shoudln't set homebranchfilter as holdingbranchfilter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org To recreate: 1 - Open the overdues report (don't worry if you don't have results) 2 - Choose to filter by homebranch 3 - Note the holdingbranch filter is set to the selected homebranch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19419] 008 Material type reverts Book
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19419 --- Comment #1 from John Sterbenz --- This is still a known issue on Master as of November 2018. I note this has been flagged as an "enhancement", but I believe it should be flagged with something higher ("minor" seems appropriate to me based on my exploration), since this an actual error in programming, not a convenience or a nicety. This is the singular reason why I do not let my staff work in the Advanced Editor despite the advantages it offers. It would seem appropriate for the programming to consider a combination of RecType and BibLevel (Leader bytes 6 and 7, respectively) when determining what "option" to choose for the 008 dropdown of any record when called into the Advanced Editor. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 Tomás Cohen Arazi changed: What|Removed |Added Attachment #80664|0 |1 is obsolete|| --- Comment #11 from Tomás Cohen Arazi --- Created attachment 82344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82344=edit Bug 21567: Remove Koha_ExternalContent_RecordedBooks.t This patch removes this file. The included tests are similar to those in the db_dependent section, with the difference that this have some things mocked. But the tests still require name resolution and connecting to the RB servers. This situation breaks package building without any noticeable gain. The feature could be better tested by mocking WebService::ILS calls (so no external world contact), but it belongs to a separate bug report. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 Tomás Cohen Arazi changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21836] Hold-found modal missing link to borrower account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21836 Lucas Gass changed: What|Removed |Added Summary|Hold-found modal missing|Hold-found modal missing |link to borrower|link to borrower account -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21836] New: Hold-found modal missing link to borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21836 Bug ID: 21836 Summary: Hold-found modal missing link to borrower Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com As of 18.05 the hold-found modal no longer includes a link to the borrower page at /cgi-bin/koha/members/moremember.pl?bowworernumber=xxx There is also no mailto: link to the borrowers email. To recreate: 1. place a hold on an item 2. check the item in 3. observe modal (no links) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19419] 008 Material type reverts Book
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19419 John Sterbenz changed: What|Removed |Added CC||jster...@umich.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21835] Request ID is displayed as NaN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21835 Owen Leonard changed: What|Removed |Added Attachment #82342|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 82343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82343=edit Bug 21835: Fix display of request ID We now populate the id_prefix property in the API response. It turns out that explicitly casting to a string wasn't necessary as JS does "the right thing" when concatenating a string and an integer Test plan: - Before applying the patch view the ILL requests table - TEST: Observe that the Request number column displays as NaN - Apply the patch - Refresh the page - TEST: Observe that the request number now displays correctly - Add the following block to your koha-conf.xml: **The code of a branch that has an ILL request attached to it** YAY - Refresh the page - TEST: Observe the request made on the branch that you specified in the config are now prefixed with "YAY-" Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21835] Request ID is displayed as NaN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21835 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19306] Adding hooks to the plugin system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19306 David Gustafsson changed: What|Removed |Added CC||glask...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #136 from David Gustafsson --- Hmm, no second thought this seems to have been done in Koha-master. So perhaps release-manager took care of this. I will fix this in my local branch then and RM will have to fix this manually again where regenerating the schema files for that in case it get merged. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21835] Request ID is displayed as NaN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21835 --- Comment #1 from Andrew Isherwood --- Created attachment 82342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82342=edit Bug 21835: Fix display of request ID We now populate the id_prefix property in the API response. It turns out that explicitly casting to a string wasn't necessary as JS does "the right thing" when concatenating a string and an integer Test plan: - Before applying the patch view the ILL requests table - TEST: Observe that the Request number column displays as NaN - Apply the patch - Refresh the page - TEST: Observe that the request number now displays correctly - Add the following block to your koha-conf.xml: **The code of a branch that has an ILL request attached to it** YAY - Refresh the page - TEST: Observe the request made on the branch that you specified in the config are now prefixed with "YAY-" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21835] Request ID is displayed as NaN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21835 Andrew Isherwood changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21835] Request ID is displayed as NaN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21835 Andrew Isherwood changed: What|Removed |Added CC||mag...@libriotech.no -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #135 from David Gustafsson --- Basing my current work on bug 20589 on this I think I discovered a regression. In "Bug 18316: Update Koha/Schema/Result/SearchField.pm" the many-to-many relationship (which has previously been manually added) was removed. This causes a crash when resetting or adding new mappings. I can supply a patch for this and will submit in this issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21835] Request ID is displayed as NaN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21835 Andrew Isherwood changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21835] Request ID is displayed as NaN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21835 Andrew Isherwood changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21835] New: Request ID is displayed as NaN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21835 Bug ID: 21835 Summary: Request ID is displayed as NaN Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherw...@ptfs-europe.com In the main ILL requests table, the request ID is displayed as NaN. There are two problems here. Firstly, we're not populating id_prefix in the API response, it got missing in the deprecation of TO_JSON in bug 20996. As such, by the time we get to the JS that populates the ILL table, there is no id_prefix property in the row object, so concatenating undefined with an integer returns NaN. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens changed: What|Removed |Added Text to go in the|Sponsored by San Diego Law |This enhancement to release notes||acquisitions allows |This enhancement to |libraries to record |acquisitions allows |adjustments to invoices. |libraries to record |These may be based on |adjustments to invoices.|feedback from a vendor, for |These may be based on |example, a credit for |feedback from a vendor, for |returned books or damaged |example, a credit for |books, or a debit for extra |returned books or damaged |service charges etc. |books, or a debit for extra | |service charges etc.| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21829] Date displays as a datetime in notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21829 --- Comment #5 from Arturo --- Thanks for submitting this patch, Jonathan! I misunderstood your message to the Koha mailing list and didn't realize this issue was fixed in 18.05. Regardless, I hoped to test this patch and get it signed off, but since the Koha sandboxes are limited and do not yet allow testing features that require a cronjob, which the MEMBERSHIP_EXPIRY notice requires, I'm not able to. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21805] Duplicate include file in search results template causes JS error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21805 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21805] Duplicate include file in search results template causes JS error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21805 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21805] Duplicate include file in search results template causes JS error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21805 Marcel de Rooy changed: What|Removed |Added Attachment #82202|0 |1 is obsolete|| --- Comment #3 from Marcel de Rooy --- Created attachment 82341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82341=edit Bug 21805: Duplicate include file in search results template causes JS error This patch removes a redundant include file, browser-strings.inc, from the top of the staff client search results template. The correctly-placed include is in the JavaScript block at the bottom of the template. The duplication causes a JavaScript error which can be seen in the browser console. To test, apply the patch and peform a catalog search in the staff client. Open the browser console and confirm that there are no errors. Signed-off-by: Pierre-Marc Thibault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21749] Importing MARC frameworks from pre-9701 fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21749 Marcel de Rooy changed: What|Removed |Added Keywords||rel_18_11_candidate QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21749] Importing MARC frameworks from pre-9701 fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21749 Marcel de Rooy changed: What|Removed |Added Attachment #82242|0 |1 is obsolete|| --- Comment #11 from Marcel de Rooy --- Created attachment 82340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82340=edit Bug 21749: (QA follow-up) Add more tests for ImportFramework This patch adds tests for: - Output of ImportFramework on fields removal and error conditions (file not found) - Different file format behaviour (csv, xml and ods are tested). To test: - Run $ kshell k$ prove t/db_dependent/ImportExportFramework.t => SUCCESS: All green :-D - Sign off :-D Note: the biblio_framework* files are based on the original one on the patchset, and exported in 17.11 with different formats. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21749] Importing MARC frameworks from pre-9701 fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21749 Marcel de Rooy changed: What|Removed |Added Attachment #82241|0 |1 is obsolete|| --- Comment #10 from Marcel de Rooy --- Created attachment 82339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82339=edit Bug 21749: Fix import of CSV biblio framework Bug 9701 added 2 new columns to the table marc_tag_structure which broke the import of biblio frameworks if the CSV file was generated with a previous version. Test plan: - Export a biblio framework from 17.11 - Import it into 18.05+ Signed-off-by: Tomas Cohen Arazi https://bugs.koha-community.org/show_bug.cgi?id=21740 Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21749] Importing MARC frameworks from pre-9701 fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21749 Marcel de Rooy changed: What|Removed |Added Attachment #82240|0 |1 is obsolete|| --- Comment #9 from Marcel de Rooy --- Created attachment 82338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82338=edit Bug 21749: Add tests for ImportFramework Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21749] Importing MARC frameworks from pre-9701 fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21749 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21467] Allow several receipts for a given subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Jonathan Druart changed: What|Removed |Added Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 Jonathan Druart changed: What|Removed |Added Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21467] Allow several receipts for a given subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Jonathan Druart changed: What|Removed |Added Keywords|rel_18_11_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21832] Restore is_expired in ILS-DI GetPatronInfo service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21832 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #2 from Jonathan Druart --- call Koha::Patron->is_expired instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Martin Renvoize changed: What|Removed |Added Attachment #79953|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Martin Renvoize changed: What|Removed |Added Attachment #81990|0 |1 is obsolete|| --- Comment #32 from Martin Renvoize --- Created attachment 82337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82337=edit Bug 18584: Our legacy code contains trailing-spaces This patch removes trailing spaces from acquisitions-search.inc Mentored-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com --- Comment #33 from Martin Renvoize --- Welcome aboard Thatcher, Signed Off. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21834] New: Display illrequests.orderid in the table of ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21834 Bug ID: 21834 Summary: Display illrequests.orderid in the table of ILL requests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: mag...@libriotech.no illrequests.orderid is used to store ILL requets IDs that originate outside of Koha. For some ILL systems, this ID is very important and often used to identify requests. It would be good if this was displayed in the main table of ILL requests, and if the column was sortable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21672] Switch templates to Bootstrap grid: Various
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21672 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 --- Comment #10 from Tomás Cohen Arazi --- There's a similar file in t/db_dependent. This tests shoudl just get removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16231] Correct permission handling in subscription edit menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16231 Owen Leonard changed: What|Removed |Added Attachment #79904|0 |1 is obsolete|| --- Comment #15 from Owen Leonard --- Created attachment 82336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82336=edit Bug 16231: Correct permission handling in subscription edit This patch corrects the way subscription edit menu items are displayed according to the user's permissions settings. To test, apply the patch and log in to the staff client as a user who has permission to create, edit, and delete subscriptions. - Locate an subscription and view the details for it. - Confirm that each "Edit" menu item works correctly. - Repeat the process when logged in as a user with varying combinations of create, edit, and delete permissions. - Test as a user limited by IndependentBranches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Owen Leonard changed: What|Removed |Added Attachment #78409|0 |1 is obsolete|| Attachment #78595|0 |1 is obsolete|| Attachment #78711|0 |1 is obsolete|| --- Comment #18 from Owen Leonard --- Created attachment 82333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82333=edit Bug 20809: Link patron image to patron image add/edit form This patch modifies an include file so that it is possible with edit a patron's image on any patron-related page which uses that include. To test you must have the patronimages system preference enabled. Apply the patch and open any patron record for viewing. - Hover the mouse over the patron image. - If the patron has a previously-defined patron image, should you see an "Edit" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. - If a patron has no patron image defined, you should see an "Add" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. This process should work from any page which shows the patron sidebar: Check out, Details, Fines, Routing lists, Circulation history, etc. Patch works as described. Signed-off-by: Dilan Johnpullé Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #19 from Owen Leonard --- Created attachment 82334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82334=edit Bug 20809: (follow-up) Corrections to CSS and JS This follow-up modifies JavaScript so that the confirmation dialog is triggered when deleting a patron image from the modal window. The CSS is modified to improve the alignment of patron image and edit button. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #20 from Owen Leonard --- Created attachment 82335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82335=edit Bug 20809: (follow-up) Add missing JS to view log page If the log viewer is being used to track patron-related data the patron-related JavaScript file should be included. To test, apply the patch and open a patron record. In the left-hand sidebar choose Modification Log. Test the patron image edit/replace process from the patron image in the sidebar and confirm that it works correctly. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18530] Remove event attributes from patron clubs templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18530 Owen Leonard changed: What|Removed |Added Attachment #82100|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 82332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82332=edit Bug 18530: Remove event attributes from patron clubs templates This patch removes event attributes like "onclick" from patron clubs templates in favor of putting these event handlers in the JavaScript. To test, apply the patch and go to Tools -> Patron clubs. - Test deletion of both club templates and clubs. Deletion confirmation dialogs should work as expected, both for OK and Cancel. - Test editing of a club template. Under "Club fields," the "Add new field" and "Delete field" links should work correctly. - Open a patron record for checkout. - Test enrolling and un-enrolling the patron. - Test the same process from the patron detail page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 Tomás Cohen Arazi changed: What|Removed |Added Keywords||rel_18_11_candidate CC||tomasco...@gmail.com Status|NEW |In Discussion Severity|normal |blocker --- Comment #9 from Tomás Cohen Arazi --- This tests should be moved into db_dependent if external world interaction is expected. This tests could remain in t/ if WebService::ILS behaviour was completely mocked. As-is, they block package building. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21833] Request type is not displayed on ILL request detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21833 --- Comment #1 from Magnus Enger --- Created attachment 82331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82331=edit Display illrequests.medium as Request type To test: - Make sure you have an ILL request with a value in illrequests.medium - View the request in Detail view and Edit view, "N/A" is displayed for the Request type - Apply the patch - View the request in Detail and Edit view again, the value from illrequests.medium is now displayed as the Request type This patch also brings the coding around illrequests.medium more in line with the coding of similar attributes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21833] Request type is not displayed on ILL request detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21833 Magnus Enger changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21833] New: Request type is not displayed on ILL request detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21833 Bug ID: 21833 Summary: Request type is not displayed on ILL request detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: mag...@libriotech.no Request type is saved as illrequests.medium in the databse. This is displayed in two places: 1. Detail ILL request view /cgi-bin/koha/ill/ill-requests.pl?method=illview_id=553 2. Edit request view /cgi-bin/koha/ill/ill-requests.pl?method=edit_action_id=553 But the value from illrequests.medium is never displayed, just N/A. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21317] Format long lists under Koha Team tab as columns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21317 Jonathan Druart changed: What|Removed |Added Text to go in the|Koha's team of developers |Koha's team of developers release notes|is always growing. This |is always growing ☺. This |patch changes the display |patch changes the display |from a long list to a |from a long list to a |nicely formatted four |nicely formatted four |column layout. |column layout. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21317] Format long lists under Koha Team tab as columns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21317 Jonathan Druart changed: What|Removed |Added Text to go in the|Koha's team of developers |Koha's team of developers release notes|is always growing ☺. This |is always growing. This |patch changes the display |patch changes the display |from a long list to a |from a long list to a |nicely formatted four |nicely formatted four |column layout. |column layout. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21829] Date displays as a datetime in notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21829 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17981 CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #4 from Jonathan Druart --- Since 18.05 it is fixed by commit a236b684fdae8e0da83ca7263b948da971dfc849 Bug 17981: Add a preview mode for notice templates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21829] Date displays as a datetime in notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21829 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21829 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21829] Date displays as a datetime in notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21829 --- Comment #2 from Jonathan Druart --- Created attachment 82329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82329=edit Bug 21829: Add tests for dateexpiry format in notices -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21829] Date displays as a datetime in notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21829 --- Comment #3 from Jonathan Druart --- Created attachment 82330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82330=edit Bug 21829: Correctly format dateexpiry in notices (date only) dateexpiry is a date, we should not display the time part in notice. Test plan: Create a notice with borrowers.dateexpiry, generate this notice. The value should be displayed without the time part -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21829] Date displays as a datetime in notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21829 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21150] Data inconsistencies - item types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21150 Nick Clemens changed: What|Removed |Added Component|Architecture, internals,|Command-line Utilities |and plumbing| CC||ro...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 --- Comment #46 from Ere Maijala --- Created attachment 82328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82328=edit Bug 19365: Clean up, fix and add new tests. Moved db_dependent tests to the proper directory in the hierarchy, fixed tests to check correct results now that the authority query builder works better and added several new tests to cover changed functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala changed: What|Removed |Added Attachment #82312|0 |1 is obsolete|| --- Comment #43 from Ere Maijala --- Created attachment 82325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82325=edit Bug 19365: Fix several issues with the Elasticsearch code Also optimize it so it's actually usable. Test plan: 1. To test it properly you need biblio and authority data. You might get away with enabling AutoCreateAuthorities and BiblioAddsAuthorities so that authorities are created in the process. Another option would be to import authorities first e.g. from LoC. 2. Make sure the authority index has been properly created with "misc/search_tools/rebuild_elastic_search.pl -a -d" 3. Run "misc/link_bibs_to_authorities.pl -v -l" twice and observe the results. Signed-off-by: Brendan Gallagher Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala changed: What|Removed |Added Attachment #82314|0 |1 is obsolete|| --- Comment #45 from Ere Maijala --- Created attachment 82327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82327=edit Bug 19365: Index authority fields as phrases Followup change to the mappings syntax from bug 19893. Indexing as phrases allows to properly search for matching headings comprised of multiple subfields (e.g. author name with year of birth). Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala changed: What|Removed |Added Attachment #82313|0 |1 is obsolete|| --- Comment #44 from Ere Maijala --- Created attachment 82326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82326=edit Bug 19365: Fix search for duplicate authorities with Elasticsearch Signed-off-by: Brendan Gallagher Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 --- Comment #41 from Nick Clemens --- (In reply to Martin Renvoize from comment #40) > In bug 21629 we corrected a similar case where we changed from callnumber to > cn_sort sorting, but we did not require a system preference to > enable/disable that change. > > I personally don't feel we should require the system preference here > either.. or at least we should be consistent elsewhere if we are going to > introduce such a preference... > > Can we push this back to the mailing list for comment? I think the concern was some migrations where the cn_sort may not be populated or not populated correctly. I am fine either way (would prefer without the switch, it would highlight data that should be fixed) I will email the lists. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21571] Translate notices fail on ACCTDETAILS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21571 Hugo Agud changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21571] Translate notices fail on ACCTDETAILS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21571 Hugo Agud changed: What|Removed |Added Attachment #80656|0 |1 is obsolete|| --- Comment #4 from Hugo Agud --- Created attachment 82324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82324=edit Bug 21571: Make ACCTDETAILS translatable This patch makes the notice "ACCTDETAILS" translatable. Test plan: 1. Switch on TranslateNotices and AutoEmailOpacUser 2. Define templates for different languages for ACCTDETAILS 3. Create a new patron, define an email address, userid and password. Also pick a different "preferred language" then the default value 4. You should receive the email with the correct, translated, email. Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/