[Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872

--- Comment #17 from Ere Maijala  ---
David, see my attached patch. The mechanism would work regardless of whether
it's an incremental indexing process, though there are currently no parameters
available to support incremental indexing since it shouldn't be needed.

I'd rather keep this simple. I don't see the need for e.g. IPC mechanisms that
tend to complicate things for little gain. Also keep in mind that rebuilding
the index is not a daily process or such.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #65 from David Cook  ---
What about a way of putting the biblionumber in the 001 as well as the 999$c
and 999$d? That way we keep backwards compatibility as well as something for
going forward?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872

--- Comment #16 from David Cook  ---
(In reply to Ere Maijala from comment #3)
> What I was referring to would be to just add a couple of parameters to the
> indexing that would control which records a single script would process.
> Then you'd be able to run multiple processes in parallel like this:
> 
> [...] --offset=0 --skip=3
> [...] --offset=1 --skip=3
> [...] --offset=2 --skip=3
> 
> The first one would process records 1, 4, 7...
> The second one would process records 2, 5, 8...
> The third one would process records 3, 6, 9...

That would be easier than building a new higher performance indexer...

How would you know the offsets in an automated way, or are you thinking about
this more for just manual use? 

Are you talking about a total rebuild or incremental indexing?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872

--- Comment #15 from David Cook  ---
(In reply to Joonas Kylmälä from comment #2)
> (In reply to David Cook from comment #1)
> > I'll just split hairs and mentioning that multithreading in Perl is not
> > recommended and never really done, but you could achieve the thing by
> > forking workers. 
> 
> Thanks for making the distinction.
> 
> > 
> > In #10662, I use the following modules to perform rapid event-driven
> > processing of job queues:
> > 
> > https://metacpan.org/pod/POE::Component::JobQueue
> > https://metacpan.org/pod/POE::Wheel::Run
> 
> The Parallel::ForkManager is also used already in Koha so it would be worth
> to take look if it could be used with the indexing code as it looks super
> simple!

Parallel::ForkManager is only used in the tests at the moment and it's marked
as a non-required dependency, but... it is marked as a dependency in Koha and I
do see it in the debian/control file as well, so I suppose a person could use
it. 

The nice thing about POE::Wheel::Run is that it uses bilateral communication
channels between the parent and children, so you can fork off X number of
workers and then continue to send data to the workers. Plus the event-driven
nature of POE means that things happen really quickly. You can have the parent
manage the queue, and have it fire off data to the children workers. 

There's even a POE::Component::* module for non-blocking HTTP requests,
although I haven't played with it myself yet, but that could also speed things
up with indexing ElasticSearch, but that would probably require not using
Catmandu (which I think is Ere's plan in the long-run anyway?).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3510] Allow staff to change checkin date and time

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3510

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
This feature is available in current versions of Koha.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21881] MARC 999 field appears at top of record in MARC Preview

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21881

paxed  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21708

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21708] Editing a record moves field 999 to first in the marcxml

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708

paxed  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21881

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21887] 856$u link problem in XSLT result lists and detail page

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21887

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #6 from David Cook  ---
I think you could use starts-with instead as well:

https://developer.mozilla.org/en-US/docs/Web/XPath/Functions/starts-with

Although I suppose leading whitespace could cause a problem

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21887] 856$u link problem in XSLT result lists and detail page

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21887

--- Comment #5 from David Cook  ---
Comment on attachment 82677
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82677
Bug 21887: (For OPAC) 856 link problem in XSLT result lists and detail page

Review of attachment 82677:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=21887=82677)
-

::: koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl
@@ +1078,5 @@
> name="href">/cgi-bin/koha/tracklinks.pl?uri= select="str:encode-uri(marc:subfield[@code='u'], 
> true())"/>biblionumber= select="$biblionumber"/>
>   
>   
> +
> + test="not(contains(marc:subfield[@code='u'],'://'))">

I could imagine malformed (yet functional) URLs could cause some problems here. 

Maybe you'd like to try out http://exslt.org/regexp/index.html to be more
precise?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14007] Item Types for items hidden by OpacHiddenItems turn up in facet results

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14007

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #4 from David Cook  ---
Because the "OpacHiddenItems" is handled after results are returned from the
search engine, it's really hard to do handle the logic well.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21892] Robin Sheat is not a typo

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18805] Add ability to use up account credits

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805

--- Comment #21 from Christopher Brannon  ---
Passes.  I just can't figure out how to get the sign off to work!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

--- Comment #8 from Christopher Brannon  ---
Sorry, I am struggling with the sign off process still.  :/  I hope I didn't
screw anything up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

Christopher Brannon  changed:

   What|Removed |Added

  Attachment #82692|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

--- Comment #7 from Christopher Brannon  ---
Created attachment 82692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82692=edit
Bug 21896: Add unit tests for Koha::Account::normalize_balance

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

Christopher Brannon  changed:

   What|Removed |Added

  Attachment #82691|Bug 21896: Add  |[SIGNED OFF]Bug 21896: Add
description|Koha::Account::normalize_ba |Koha::Account::normalize_ba
   |lance   |lance

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

Christopher Brannon  changed:

   What|Removed |Added

  Attachment #82685|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

--- Comment #6 from Christopher Brannon  ---
Created attachment 82691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82691=edit
Bug 21896: Add Koha::Account::normalize_balance

This patch adds the normalize_balance() method to Koha::Account. Its
purpose is to apply outstanding credits (i.e. manual ones ore remaining
amounts like in the case of refunds) to outstanding debts.

To test:
- Apply this patchset
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Account.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18805] Add ability to use up account credits

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805

Christopher Brannon  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #20 from Christopher Brannon  ---
Sorry, needed a restart.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21778] Sorting is inconsistent on patron search based on permissions

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21778

Nick Clemens  changed:

   What|Removed |Added

   Severity|enhancement |major

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

Christopher Brannon  changed:

   What|Removed |Added

  Attachment #82685|Bug 21896: Add  |[SIGNED OFF]Bug 21896: Add
description|Koha::Account::normalize_ba |Koha::Account::normalize_ba
   |lance   |lance
  Attachment #82685|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

Christopher Brannon  changed:

   What|Removed |Added

  Attachment #82688|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

Christopher Brannon  changed:

   What|Removed |Added

  Attachment #82688|Bug 21896: Add unit tests   |[SIGNED OFF]Bug 21896: Add
description|for |unit tests for
   |Koha::Account::normalize_ba |Koha::Account::normalize_ba
   |lance   |lance
  Attachment #82688|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

Christopher Brannon  changed:

   What|Removed |Added

  Attachment #82689|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18805] Add ability to use up account credits

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805

Christopher Brannon  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #19 from Christopher Brannon  ---
Can't locate object method "normalize_balance" via package "Koha::Account" at
/home/vagrant/kohaclone/members/pay.pl line 290

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

Christopher Brannon  changed:

   What|Removed |Added

  Attachment #82690|Bug 21896: Add unit tests   |[SIGNED OFF]Bug 21896: Add
description|for |unit tests for
   |Koha::Account::normalize_ba |Koha::Account::normalize_ba
   |lance   |lance

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

Christopher Brannon  changed:

   What|Removed |Added

  Attachment #82688|0   |1
is obsolete||

--- Comment #5 from Christopher Brannon  ---
Created attachment 82690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82690=edit
Bug 21896: Add unit tests for Koha::Account::normalize_balance

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org
  Attachment #82688|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

Christopher Brannon  changed:

   What|Removed |Added

  Attachment #82685|0   |1
is obsolete||
  Attachment #82688|0   |1
is obsolete||

--- Comment #4 from Christopher Brannon  ---
Created attachment 82689
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82689=edit
[SIGNED OFF]Bug 21896: Add unit tests for Koha::Account::normalize_balance

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

Christopher Brannon  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

Christopher Brannon  changed:

   What|Removed |Added

  Attachment #82684|0   |1
is obsolete||

--- Comment #3 from Christopher Brannon  ---
Created attachment 82688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82688=edit
Bug 21896: Add unit tests for Koha::Account::normalize_balance

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18805] Add ability to use up account credits

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #18 from Christopher Brannon  ---
(In reply to Tomás Cohen Arazi from comment #10)
> Right now, we are able to create credits (mancredit.pl) but there's no way
> to 'use' the existing credit against existing outstanding (debit) lines.
> This is odd in the interface and worth working on.
> 
> I don't think this should be implemented as an automatic feature in the
> first place. I would rather implement a way to assign remaining credits to
> specific lines, and THEN add the option to do it automatically, maybe
> syspref-controlled (better by payment type ;-))

I do hope an automatic setting is in the near future.  One would assume credit
would be used automatically.  I don't know of many places that don't
automatically use your credit.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

Julian Maurice  changed:

   What|Removed |Added

 Blocks||21895


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21895
[Bug 21895] translations fail on upgrade to 18.11.00 (package installation)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21895] translations fail on upgrade to 18.11.00 (package installation)

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21895

Julian Maurice  changed:

   What|Removed |Added

 Depends on||15395


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
[Bug 15395] Internationalization: plural forms, context, and more
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21895] translations fail on upgrade to 18.11.00 (package installation)

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21895

Julian Maurice  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |julian.maur...@biblibre.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21895] translations fail on upgrade to 18.11.00 (package installation)

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21895

--- Comment #2 from Julian Maurice  ---
Created attachment 82687
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82687=edit
Bug 21895: Fix translation for package install

The string extraction process was not taking into account the fact that
standard/package install have a completely different directory structure
than the dev install

This patch tries to keep the exact same behaviour for dev installs,
while making it work for standard install by using opachtdocs,
intrahtdocs, opacdir and intranetdir from $KOHA_CONF

Test plan:
1. Follow test plan in
https://gitlab.com/koha-community/Koha/commit/d708255c7a4d981c7c7bdd0644a75202ec43b297
2. Do a standard install and repeat step 1 on this new install
3. If you know how to build the Debian package, build it, install it and
verify that koha-translate works as expected
4. prove t/LangInstaller.t

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21686] Koha::Account->pay has no tests

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21686

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED
 CC||tomasco...@gmail.com

--- Comment #1 from Tomás Cohen Arazi  ---
I found several tests in t/db_dependent/Accounts.t
I haven't checked how much they cover, but look good. This should probably go
somewhere else, but looks correct anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18805] Add ability to use up account credits

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18805] Add ability to use up account credits

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805

--- Comment #17 from Tomás Cohen Arazi  ---
Created attachment 82686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82686=edit
Bug 18805: Add ability to use up account credits

This patch introduces a new button in the 'Pay fines' tab  on the
patron's account page. This button, labeled 'Normalize account' is only
displayed when outstanding credits are available, that could be used to
pay up existing debts.

When clicking the button, the Koha::Account::normalize_balance method
(bug 21896) is used for the purpose.

To test:
- Apply this patch (on top of 21896)
- On a patron's 'Fines' tab, create a 'manual invoice' (maybe more than
  one)
- Go to the 'Pay fines' tab
=> SUCCESS: No 'Normalize account' button is displayed.
- On the 'create manual credit' tab, create a couple credits.
- Go to the 'Pay fines'
=> SUCCESS: 'Normalize account' button is displayed
- Click on 'Normalize account'
=> SUCCESS: Outstanding credits have been used to pay up debts.
- Play with different options (credit excedes debts and vice-versa, they
match, etc)
=> SUCCESS: They all work as expected
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18805] Add ability to use up account credits

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #81609|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||18805


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805
[Bug 18805] Add ability to use up account credits
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18805] Add ability to use up account credits

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||21896
 Status|Signed Off  |ASSIGNED
   Patch complexity|Medium patch|Small patch
   Assignee|k...@bywatersolutions.com   |tomasco...@gmail.com

--- Comment #16 from Tomás Cohen Arazi  ---
I'm taking this one with Kyle's permission.

I rewrite and moved the Koha::Account::normalize_balance method to bug 21896.
It is fully covered by tests there.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896
[Bug 21896] Add Koha::Account::normalize_balance
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21778] Sorting is inconsistent on patron search based on permissions

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21778

Margaret  changed:

   What|Removed |Added

 CC||margaret@bywatersolutions.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21649] Add child button in the staff client is no longer automatically populating the parent address

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #9 from Christopher Brannon  ---
Will this be applied to 18.05?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 82685
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82685=edit
Bug 21896: Add Koha::Account::normalize_balance

This patch adds the normalize_balance() method to Koha::Account. Its
purpose is to apply outstanding credits (i.e. manual ones ore remaining
amounts like in the case of refunds) to outstanding debts.

To test:
- Apply this patchset
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Account.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 82684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82684=edit
Bug 21896: Add unit tests for Koha::Account::normalize_balance

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

Tomás Cohen Arazi  changed:

   What|Removed |Added

Summary|Add |Add
   |Koha::Account::normalize_ac |Koha::Account::normalize_ba
   |count   |lance
 CC||k...@bywatersolutions.com,
   ||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21896] New: Add Koha::Account::normalize_account

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

Bug ID: 21896
   Summary: Add Koha::Account::normalize_account
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

We need a method that automatically applies outstanding credits to outstanding
debits.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21895] translations fail on upgrade to 18.11.00 (package installation)

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21895

Nick Clemens  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21895] translations fail on upgrade to 18.11.00 (package installation)

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21895

Nick Clemens  changed:

   What|Removed |Added

   Severity|enhancement |blocker
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||julian.maur...@biblibre.com
   ||,
   ||k...@bywatersolutions.com,
   ||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21894] Upgrade to 18.11.00 fails because of translation problems

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21894

Mirko Tietgen  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Mirko Tietgen  ---


*** This bug has been marked as a duplicate of bug 21895 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21895] translations fail on upgrade to 18.11.00 (package installation)

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21895

--- Comment #1 from Mirko Tietgen  ---
*** Bug 21894 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21895] translations fail on upgrade to 18.11.00 (package installation)

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21895

Mirko Tietgen  changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net,
   ||n...@bywatersolutions.com,
   ||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21895] New: translations fail on upgrade to 18.11.00 (package installation)

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21895

Bug ID: 21895
   Summary: translations fail on upgrade to 18.11.00 (package
installation)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mi...@abunchofthings.net
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr

On upgrade of a package installation to 18.11.00, there are several errors
related to translations.


Use of uninitialized value $pref_name in concatenation (.) or string at
/usr/share/koha/misc/translator/LangInstaller.pm line 196.
Use of uninitialized value $pref_name in concatenation (.) or string at
/usr/share/koha/misc/translator/LangInstaller.pm line 238.
Can't stat /usr/share/koha/intranet/cgi-bin/koha-tmpl: No such file or
directory
 at /usr/share/koha/misc/translator/LangInstaller.pm line 633.
/usr/bin/msginit: error while opening "Koha.pot" for reading: No such file or
directory
/bin/sed: can't read /usr/share/koha/misc/translator/po/de-DE-messages.po: No
such file or directory
/usr/bin/msgfmt: error while opening
"/usr/share/koha/misc/translator/po/de-DE-messages.po" for reading: No such
file or directory
Updated the de-DE translations.
find: invalid expression; you have used a binary operator '-or' with nothing
before it.
W: APT had planned for dpkg to do more than it reported back (0 vs 4).
   Affected packages: koha-common:amd64


Bugs related are 15395 and 21823

/usr/share/koha/intranet/cgi-bin/koha-tmpl appears to be a dev path not working
for regular installations (/usr/share/koha/misc/translator/LangInstaller.pm
line 633.)

New files are not created (Koha.pot, de-DE-messages.po)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21894] New: Upgrade to 18.11.00 fails because of translation problems

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21894

Bug ID: 21894
   Summary: Upgrade to 18.11.00 fails because of translation
problems
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: blocker
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mi...@abunchofthings.net
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr

On upgrade of a package installation to 18.11.00, there are several errors
related to translations.


Use of uninitialized value $pref_name in concatenation (.) or string at
/usr/share/koha/misc/translator/LangInstaller.pm line 196.
Use of uninitialized value $pref_name in concatenation (.) or string at
/usr/share/koha/misc/translator/LangInstaller.pm line 238.
Can't stat /usr/share/koha/intranet/cgi-bin/koha-tmpl: No such file or
directory
 at /usr/share/koha/misc/translator/LangInstaller.pm line 633.
/usr/bin/msginit: error while opening "Koha.pot" for reading: No such file or
directory
/bin/sed: can't read /usr/share/koha/misc/translator/po/de-DE-messages.po: No
such file or directory
/usr/bin/msgfmt: error while opening
"/usr/share/koha/misc/translator/po/de-DE-messages.po" for reading: No such
file or directory
Updated the de-DE translations.
find: invalid expression; you have used a binary operator '-or' with nothing
before it.
W: APT had planned for dpkg to do more than it reported back (0 vs 4).
   Affected packages: koha-common:amd64


Bugs related are probably 15395 and 21823

/usr/share/koha/intranet/cgi-bin/koha-tmpl appears to be a dev path not working
for regular installations (/usr/share/koha/misc/translator/LangInstaller.pm
line 633.)

New files are not created (Koha.pot, de-DE-messages.po)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21892] Robin Sheat is not a typo

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892

Robin Sheat  changed:

   What|Removed |Added

 CC||ro...@kallisti.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14007] Item Types for items hidden by OpacHiddenItems turn up in facet results

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14007

Owen Leonard  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21399] Sort patron fines in OPAC by date descending as a default

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21399

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21399] Sort patron fines in OPAC by date descending as a default

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21399

--- Comment #1 from Owen Leonard  ---
Created attachment 82683
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82683=edit
Bug 21399: Sort patron fines in OPAC by date descending as a default

This patch modifies the DataTables configuration of the logged-in user's
"Fines and charges" table in the OPAC so that the table is sorted by
date, descending.

To test, apply the patch and log in to the OPAC as a user with multiple
fines. Go to the "your fines" page and confirm that the table is sorted
by default on the first column with the newest entries first.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21412] Opac upload file access

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21412

Owen Leonard  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13125] Total Holds does not tally holds

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13125

Barton Chittenden  changed:

   What|Removed |Added

 CC||bar...@bywatersolutions.com

--- Comment #3 from Barton Chittenden  ---
items.reserves shows on the koha-to-marc mapping, and is also documented in
https://wiki.koha-community.org/wiki/Holdings_data_fields_(9xx)

For the sake of supportability, I would like to see this either fully
implemented or removed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980
Bug 19980 depends on bug 20642, which changed state.

Bug 20642 Summary: Switch single-column templates to Bootstrap grid: Various, 
part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20642

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20650] Switch single-column templates to Bootstrap grid: Various, part 3

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20650

--- Comment #12 from Owen Leonard  ---
*** Bug 20642 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20642] Switch single-column templates to Bootstrap grid: Various, part 3

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20642

Owen Leonard  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|ASSIGNED|RESOLVED

--- Comment #1 from Owen Leonard  ---


*** This bug has been marked as a duplicate of bug 20650 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21760] could not get opac page

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21760

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #2 from Owen Leonard  ---
This sounds like a support request rather than a bug.

Questions about Koha should be asked on the Koha mailing list
(http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC
channel (http://koha-community.org/get-involved/irc/).

Hopefully you've already seen the Koha documentation:
http://koha-community.org/documentation/

You can also find options for paid support here:
https://koha-community.org/support/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21890] Patron Password Resets

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17006

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17006] Add route to change patron's password

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

Tomás Cohen Arazi  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21890

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17006] Add route to change patron's password

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21890] Patron Password Resets

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #5 from M. Tompsett  ---
(In reply to Katrin Fischer from comment #4)
> Hi Jesse, thx for the update! But I am not sure how this is different from
> the existing password reset and password strength features?

It's a level of granularity, not all patrons will be able to reset, just a
certain set of them, based on patron type.

As kidclamp clarified on IRC:
 this is to allow it for only certain categories - very useful in a
setting with shib or ldap backing
 some patrons should only have they SSO login, others may have a
local, they can change via koha
 and it adds some notification, so if password is reset we send an
email to notify user (in case of fraud!)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21890] Patron Password Resets

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890

--- Comment #4 from Katrin Fischer  ---
Hi Jesse, thx for the update! But I am not sure how this is different from the
existing password reset and password strength features?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21893] New: Batch Modify button in report with itemnumber only includes titles in first page of results

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21893

Bug ID: 21893
   Summary: Batch Modify button in report with itemnumber only
includes titles in first page of results
 Change sponsored?: ---
   Product: Koha
   Version: 18.05
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Reports
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Bug 19233 added the ability to push report results into item batch modification
when the report includes a column of itemnumbers. However, only items on the
first page of item results will be pushed to batch modification -- if the
report results include 1200 items and the report page is set to display 1000
rows per page, only the first 1000 items will be batch modified. Koha is clear
that it's only modifying those 1000 items, but it still creates extra work,
especially since the Rows Per Page dropdown on report results doesn't include
an option for All.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21892] Robin Sheat is not a typo

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892

M. Tompsett  changed:

   What|Removed |Added

   Assignee|jonathan.dru...@bugs.koha-c |mtomp...@hotmail.com
   |ommunity.org|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21892] Robin Sheat is not a typo

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892

--- Comment #3 from M. Tompsett  ---
Created attachment 82682
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82682=edit
Bug 21892: Ignore Sheat when checking spelling

1) without this patch applied to your qa-test-tools
   run the test plans for the first two patches
-- both should fail, with just 1 applied, and both applied
   to your kohaclone.
2) apply this patch to your qa-test-tools
3) rerun the test plans for the first two patches
-- just 1 applied should now pass, but both applied should
   still fail.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21892] Robin Sheat is not a typo

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892

M. Tompsett  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21890] Patron Password Resets

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890

--- Comment #3 from Jesse Maseto  ---

This enhancement will provide a secure method for a patron to change their Koha
password that does not require any staff mediation. This method would be
applicable only to selected patron types, controlled by the library with a
setting that the library can change without requesting special assistance.

Patrons would be provided with an appropriate link from the OPAC that would
lead to a password setting page/UI. Patrons would be required to enter their
old password which the system would check to identify and authenticate the
patron. New passwords would have to entered twice, would have to match, and
would be subject to guidelines for creating passwords (length, required
characters, etc.). 

Alternately, patrons who forget their passwords would be able to recover their
account and reset their passwords via email.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21892] Robin Sheat is not a typo

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892

--- Comment #1 from M. Tompsett  ---
Created attachment 82680
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82680=edit
Bug 21892: Robin Sheat is not a typo [DON'T PUSH]

This adds a a comment to Koha.pm which should:
1) apply this patch
2) run the qa test tools
-- it should fail, because it thinks Sheat is not
   spelled correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21892] Robin Sheat is not a typo

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892

--- Comment #2 from M. Tompsett  ---
Created attachment 82681
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82681=edit
Bug 21892: Purposeful typo [DO NOT PUSH]

This combined with the former patch gives an intentionally
set of words incorrectly spelled.

1) apply the first two patches
2) run qa test tools
-- Yes, it should find the bad spellings.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21884] Writeoff "amount" changed from positive values to negative values.

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21884

--- Comment #2 from Alex C  ---
Hi Tomas,

I think it's old vs new data prior/after an update, you can take a look at this
patron's account: 20165100573549, if you filter only "writeoff" numbers, you
can see that writeoff balances prior to 2017 were all positive values shown in
red (like fines), but after 2017 they were all negative values shown in green
like payments.

I believe if you pull a SQL report to show writeoff balances from any db it
might show the same thing, I don't think it's specifically our DB. I think you
can use the timestamps when 17.05 or 17.11 updates were done to see if the
values started to look differently prior/after the updates.

Hope my explanation made sense ... sorry I can't find the SQLs I wrote back
then when I first discovered this, we were doing library system-wide stats on
fines and accounts sent to collection, that's how I found some fines were
canceling each other out because of the pos/neg values.

Thanks.
Alex.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21892] New: Robin Sheat is not a typo

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892

Bug ID: 21892
   Summary: Robin Sheat is not a typo
 Change sponsored?: ---
   Product: Project Infrastructure
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: QA tools
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: mtomp...@hotmail.com

While testing a bug, I changed a file with "Robin Sheat" in the comments to a
.pl file, and the qa test tools flagged Sheat as a typo.

It is unlikely that Sheat as a typo will be used in general comments, so
the proposal is to ignore Sheat in the codespell call.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21890] Patron Password Resets

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Kyle, was this supposed to be here? General public has no access to RT :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21890] Patron Password Resets

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890

--- Comment #2 from Katrin Fischer  ---
Ah, sorry, assigned to Kyle, written by Jesse!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12561] Omnibus: Deprecate non-XSLT detail and result views

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561

Owen Leonard  changed:

   What|Removed |Added

 Depends on||21891


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21891
[Bug 21891] Remove non-XSLT detail view in the staff client
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21891] New: Remove non-XSLT detail view in the staff client

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21891

Bug ID: 21891
   Summary: Remove non-XSLT detail view in the staff client
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Blocks: 12561

There are no bugs blocking the removal of the non-XSLT detail view in the staff
client, so let's do it.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561
[Bug 12561] Omnibus: Deprecate non-XSLT detail and result views
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21890] New: Patron Password Resets

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890

Bug ID: 21890
   Summary: Patron Password Resets
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: k...@bywatersolutions.com
  Reporter: je...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Please see Statement of Work on ticket in RT!!

https://ticket.bywatersolutions.com/Ticket/Display.html?id=50926

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21888] I can not create Label Template

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21888

--- Comment #4 from sergeinik  ---
Created attachment 82679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82679=edit
I enter values

I enter values and get a blank page. Help me please!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21449] Switch two-column templates to Bootstrap grid: Circulation part 2

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21449

Owen Leonard  changed:

   What|Removed |Added

  Attachment #79602|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21889] New: Include Staff Client entered Purchase Suggestions with System Preference maxopensuggestions

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21889

Bug ID: 21889
   Summary: Include Staff Client entered Purchase Suggestions with
System Preference maxopensuggestions
 Change sponsored?: ---
   Product: Koha
   Version: 18.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Currently only Purchase Suggestions made by patrons through the OPAC are the
only suggestions counted in the system preference MaxOpenSuggestions.  It would
be nice if this system preference also connected to the staff client, so a
purchase suggestion done on the patrons account by staff alerted the staff that
the patron already had the maximum number of purchase suggestion allowed.  At
this time, even if a patron has maxed out the number of open purchase
suggestions on the OPAC, a staff member can still enter more purchase
suggestions for that patron through the staff client without knowledge of the
maxopensuggestions being reached.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21449] Switch two-column templates to Bootstrap grid: Circulation part 2

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21449

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21438] Switch two-column templates to Bootstrap grid: Patron card creator

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21438

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21438] Switch two-column templates to Bootstrap grid: Patron card creator

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21438

Owen Leonard  changed:

   What|Removed |Added

  Attachment #79527|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 82678
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82678=edit
Bug 21438: Update two-column templates with Bootstrap grid: Patron card creator

This patch modifies the patron card creator templates to use the
Bootstrap grid instead of YUI.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Tools -> patron card creator
   - Manage -> Card batches
 - Edit card batch
   - Manage -> Layouts
 - Edit layout
   - Manage -> Images
   - Manage -> Card templates
 - Edit template
   - Manage -> Printer profiles
 - Edit profile

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21887] 856$u link problem in XSLT result lists and detail page

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21887

--- Comment #4 from Devinim  ---
Created attachment 82677
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82677=edit
Bug 21887: (For OPAC) 856 link problem in XSLT result lists and detail page

Test plan (for OPAC);
1) Add web page link without http:// or ftp:// prefix in 856$u or use Sample
Marc record
2) Search record from OPAC web page and examine that link in online resources
section shows localhost.
3) Apply this patch
4) Search similar record and test link is working correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21438] Switch two-column templates to Bootstrap grid: Patron card creator

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21438

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21888] I can not create Label Template

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21888

--- Comment #3 from sergeinik  ---
All other profiles are added without problems, and Label Template is not added
or edited.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21888] I can not create Label Template

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21888

--- Comment #2 from sergeinik  ---
I read it all. Only when I click Save, I do not add anything.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21887] 856$u link problem in XSLT result lists and detail page

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21887

--- Comment #3 from Marcel de Rooy  ---
>From LOC:
$u - Uniform Resource Identifier
Uniform Resource Identifier (URI), which provides standard syntax for locating
an object using existing Internet protocols. Field 856 is structured to allow
for the creation of a URL from the concatenation of other separate 856
subfields. Subfield $u may be used instead of those separate subfields or in
addition to them.

I am not sure if we fully comply with that currently (probably not). This does
not either. But still looks good to me..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21888] I can not create Label Template

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21888

--- Comment #1 from Chris Nighswonger  ---
I'm afraid that without any further information, we will not be able to comment
on the particular reason that you cannot create a label template.

Have you read through the documentation on how to do this? It can be found
here:
https://koha-community.org/manual/18.05/en/html/tools.html#label-templates-label

Also, you may want to read up on how to construct a through bug report. This
information may be found here:
https://wiki.koha-community.org/wiki/Bug_Reporting_Guidelines

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21887] 856$u link problem in XSLT result lists and detail page

2018-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21887

Devinim  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >