[Koha-bugs] [Bug 21958] _check_valid_auth_link checks too many subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21958 --- Comment #1 from Ere Maijala --- Duplicate of bug 21826? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21958] _check_valid_auth_link checks too many subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21958 Ere Maijala changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21826 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21826] Automatic authority record generation improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21826 Ere Maijala changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21958 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Marcel de Rooy changed: What|Removed |Added Keywords|rel_18_11_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21911] Scoping OPACs by branch does not work with new library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21911] Scoping OPACs by branch does not work with new library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 Marcel de Rooy changed: What|Removed |Added Attachment #82767|0 |1 is obsolete|| --- Comment #7 from Marcel de Rooy --- Created attachment 82950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82950=edit Bug 21911: Regression test This tests usuall cases, but note, that administrator could make a branch with code "%%%" or so, which this test does not cover, and some functionalities will not work in that case: opac limit override, holdinbranch facet Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21911] Scoping OPACs by branch does not work with new library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21911] Scoping OPACs by branch does not work with new library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 Marcel de Rooy changed: What|Removed |Added Attachment #82754|0 |1 is obsolete|| --- Comment #6 from Marcel de Rooy --- Created attachment 82949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82949=edit Bug 21911: Fix OPAC scoping to work with new group system To test: 0 - Apply patch 1 - Create a library group enabled for opac search limits and add some libraries 2 - Check the DB (or advanced search dropdown) to get the id of the group (using 7 as example below) 3 - Add to apache configuration (OPAC virtualhost) SetEnv OPAC_SEARCH_LIMIT branch:multibranchlimit-7 SetEnv OPAC_LIMIT_OVERRIDE 1 RequestHeader add X-Koha-SetEnv "OPAC_SEARCH_LIMIT branch:multibranchlimit-7" RequestHeader add X-Koha-SetEnv "OPAC_LIMIT_OVERRIDE 1" 4 - Ensure OpacAddMastheadLibraryPulldown is disabled 5 - Restart all the things 6 - Visit the opac 7 - Perform a search, confirm it is scoped to the branches in the group Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21849] Offsets not stored correctly in _FixOverduesOnReturn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21849 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21849] Offsets not stored correctly in _FixOverduesOnReturn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21849
--- Comment #8 from Marcel de Rooy ---
Created attachment 82948
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82948=edit
Bug 21849: Two useless Koha::Account::Offset->new calls need attention
Came across those calls in bug 20598 in _FixOverduesOnReturn
Koha::Account::Offset->new(
{
debit_id => $accountline->id,
type => 'Forgiven',
amount => $amountoutstanding * -1,
}
);
This does nothing if you don't store data.
Test Plan:
1) Apply this patch
2) Set up 2 items with overdue fines
3) Return one with dropbox mode
4) Note the dropbox account offset is created
5) Return one with full fine forgiveness
6) Note the forgiven account offset is created
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21849] Offsets not stored correctly in _FixOverduesOnReturn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21849 Marcel de Rooy changed: What|Removed |Added Attachment #82919|0 |1 is obsolete|| Attachment #82920|0 |1 is obsolete|| --- Comment #7 from Marcel de Rooy --- Created attachment 82947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82947=edit Bug 21849: Add unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21849] Offsets not stored correctly in _FixOverduesOnReturn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21849 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21971] TestBuilder::gimme_an_item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #2 from Marcel de Rooy --- gimme ? See comment3 and 4 on bug 21798 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21675] Unable to add to a basket with ElasticSearch enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21675 Reza changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID |--- --- Comment #8 from Reza --- I contacted Catalyst to solve the issue for us. Our Koha is installed with a memcached and an elastic search cluster with two nodes. This is the finding: On line 92 of Koha::SearchEngine::Elasticsearch I removed cxn_pool => 'Sniff', This allowed us to connect to the Amazon Elastic cluster. I then dropped and recreated the Elasticsearch indexes I note that it errored if you tried to do the default 5000 records per commit, and that it still didn't like 1000, but it was happy at 100 So when you run koha-elasticsearch --rebuild apiit you want to also add -c 100 so it does 100 records at a time. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11492] Receiving a serial item causes routing list notes to be lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11492 Aleisha Amohia changed: What|Removed |Added Attachment #82945|0 |1 is obsolete|| --- Comment #3 from Aleisha Amohia --- Created attachment 82946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82946=edit Bug 11492: Keep routing notes when receiving next serial This patch ensures the routing notes are carried over when generating the next serial. To test: 1) Create a routing list for a subscription 2) Add a borrower and a note to the routing list 3) Generate the next serial (serials-collection.pl) 4) Edit the routing list to see the notes 5) Note that the notes have disappeared 6) Apply patch 7) Edit the routing list, add a note 8) Generate the next serial 9) Edit the routing list and confirm the note is still there 10) Confirm you are still able to edit serials (serials-edit.pl) and routing notes stay Sponsored-by: Plant and Food Research Limited -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11492] Receiving a serial item causes routing list notes to be lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11492 Aleisha Amohia changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11492] Receiving a serial item causes routing list notes to be lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11492 --- Comment #2 from Aleisha Amohia --- Created attachment 82945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82945=edit Bug 11492: Keep routing notes when receiving next serial This patch ensures the routing notes are carried over when generating the next serial. To test: 1) Create a routing list for a subscription 2) Add a borrower and a note to the routing list 3) Generate the next serial (serials-collection.pl) 4) Edit the routing list to see the notes 5) Note that the notes have disappeared 6) Apply patch 7) Edit the routing list, add a note 8) Generate the next serial 9) Edit the routing list and confirm the note is still there 10) Confirm you are still able to edit serials (serials-edit.pl) and routing notes stay Sponsored-by: Plant and Food Research Limited -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11492] Receiving a serial item causes routing list notes to be lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11492 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21926] Enhance OAI-PMH:archiveID system preference description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21926 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21922] Allow to decide if price is entered tax inlcuded or excluded on receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21922 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- Absolutely agree. This seems to bite people all the time. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21098] Add missing budget optgroups to parcels.tt and newemptyorder.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 --- Comment #5 from David Cook --- Thanks, Owen :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21817] Mock userenv should be a t::lib::Mocks method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21817 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21971] TestBuilder::gimme_an_item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 --- Comment #1 from Jonathan Druart --- Created attachment 82944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82944=edit Bug 21971: gimme_an_item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13680] Items list on edit items page separates add items form from header and sidebar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 --- Comment #19 from Christopher Brannon --- Can the tabs be included in a dropdown on the edit modal? Should they be? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21971] New: TestBuilder::gimme_an_item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 Bug ID: 21971 Summary: TestBuilder::gimme_an_item Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Blocks: 21816 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21816 [Bug 21816] [OMNIBUS] Ease the write of our tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21816] [OMNIBUS] Ease the write of our tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21816 Jonathan Druart changed: What|Removed |Added Depends on||21971 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 [Bug 21971] TestBuilder::gimme_an_item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13680] Items list on edit items page separates add items form from header and sidebar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 --- Comment #18 from Heather --- Ooh, Owen, I'm loving it!! And "MARC" vs. "Labeled MARC" is swet!!! This would make me a very happy cataloger! I'd like it now, please. --h2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #10 from Jonathan Druart --- Created attachment 82943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82943=edit Bug 21798: Replace 2 more occurrences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart changed: What|Removed |Added Attachment #72234|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart changed: What|Removed |Added Attachment #72231|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart changed: What|Removed |Added Attachment #72237|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart changed: What|Removed |Added Attachment #72235|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart changed: What|Removed |Added Attachment #72238|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart changed: What|Removed |Added Attachment #72236|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart changed: What|Removed |Added Attachment #72233|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart changed: What|Removed |Added Attachment #72230|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart changed: What|Removed |Added Status|BLOCKED |Needs Signoff --- Comment #30 from Jonathan Druart --- Remove branch rebased and updated. TODO: "notes for rule" is certainly broken (bug 12365) Kyle, I have now 1 line per category and item type on the circ rule admin page, is that expected? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21970] New: Scan and Go functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21970 Bug ID: 21970 Summary: Scan and Go functionality Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdo...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com A library has asked about using Scan and Go technology within Koha, much like you are seeing in commercial settings. The idea is to allow patrons to check out books using their phones, such as described in this article: https://digiday.com/marketing/7-eleven-testing-new-scan-go-technology-let-customers-pay-without-cashiers/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13680] Items list on edit items page separates add items form from header and sidebar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 --- Comment #17 from Owen Leonard --- Created attachment 82942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82942=edit Screenshot showing alternate view menu What about this version of the view menu? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21578] 'Pay fines' tab incorrectly describes the purpose
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21578 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21578] 'Pay fines' tab incorrectly describes the purpose
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21578 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 82941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82941=edit Bug 21578: Terminology changes in patron's account section (staff) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21578] 'Pay fines' tab incorrectly describes the purpose
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21578 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21969] Koha::Account->outstanding_* should look for debits/credits by checking 'amount'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21969 Tomás Cohen Arazi changed: What|Removed |Added Blocks||21915 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 [Bug 21915] Add a way to automatically reconcile balance for patrons -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21915] Add a way to automatically reconcile balance for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi changed: What|Removed |Added Depends on||21969 --- Comment #23 from Tomás Cohen Arazi --- I've added bug 21969 as dependency, because some pathological use cases considered debits as credits. Those cases are explained in bug 14591, and should be dealt with on a separate bug report. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21969 [Bug 21969] Koha::Account->outstanding_* should look for debits/credits by checking 'amount' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21969] Koha::Account->outstanding_* should look for debits/credits by checking 'amount'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21969 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21969] Koha::Account->outstanding_* should look for debits/credits by checking 'amount'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21969 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 82940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82940=edit Bug 21969: Fix Koha::Account->outstanding_* matching the opposite on pathological cases This patch makes outstanding_* methods be safe regarding pathological account lines that get converted into another type because of the value of amountoutstanding To test: - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => FAIL: Tests fail because pathological account lines are wrongly picked. - Apply this patch - Run: k$ prove t/db_dependent/Koha/Account.t =>SUCCESS: All green! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21969] Koha::Account->outstanding_* should look for debits/credits by checking 'amount'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21969 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 82939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82939=edit Bug 21969: Regression tests This patch introduces regression tests for Koha::Account::outstanding_* methods so they don't pick wrong lines when amountoutstanding matches what we are looking for (i.e. negative for credits and positive for debits). To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => FAIL: Tests fail because pathological account lines are wrongly picked. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #10 from Jonathan Druart --- Created attachment 82938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82938=edit Bug 18930: Do not insert '*' in circulation_rules We must insert NULL instead, otherwise the FK constraint will fail -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Jonathan Druart changed: What|Removed |Added Attachment #81101|0 |1 is obsolete|| Attachment #81148|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 82937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82937=edit Bug 18930: Move lost item refund rules to circulation_rules table This patch will move the list item refund rules from a dedicated table to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Verify lost item refund rules remain unchanged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #12 from Jonathan Druart --- Created attachment 82936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82936=edit Bug 18928: Add missing filters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart changed: What|Removed |Added Attachment #81096|0 |1 is obsolete|| Attachment #81097|0 |1 is obsolete|| Attachment #81098|0 |1 is obsolete|| Attachment #81099|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 82933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82933=edit Bug 18928: Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules Test Plan: 1) Apply dependancies 2) Apply this patch set 3) Run updatedatabase.pl 4) Ensure holdallowed and hold_fulfillment_policy rules behavior remains unchanged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #10 from Jonathan Druart --- Created attachment 82934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82934=edit Bug 18928: Add DB structure changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #11 from Jonathan Druart --- Created attachment 82935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82935=edit Bug 18928: Update schema files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Owen Leonard changed: What|Removed |Added Attachment #77486|0 |1 is obsolete|| --- Comment #15 from Owen Leonard --- Created attachment 82932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82932=edit Bug 11375: Improve patrons permissions display This patch updates the patron permissions interface in order to emphasize permission descriptions (which can be translated) over permission code (which cannot). The tree structure (and jQuery plugin) is removed, and permissions are displayed in a table-like way. Sub-permissions are shown or hidden with a link. A free-text filter is added to the top for narrowing the list by keyword. To test, apply the patch and clear your browser cache if necessary. - Open the "Set permissions" page for any patron. - Confirm that the filter works correctly to show only lines which match your entry - Note that the superlibrarian line stays visible all the time. This is to make it clearer that sub-permissions cannot be selected if superlibrarian is checked. - Check the superlibrarain "hint" text for clarity. - Test the show/hide controls. - Test that checking a "parent" permission displays the sub-permissions. - Test that changing and saving permissions works correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #55 from Jonathan Druart --- Created attachment 82931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82931=edit Bug 18925: Update schema files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #53 from Jonathan Druart --- Created attachment 82929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82929=edit Bug 18925: (follow-up) Fix null/empty behavior -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925
--- Comment #52 from Jonathan Druart
---
Created attachment 82928
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82928=edit
Bug 18925: (follow-up) Change name of rule to fix ambiguity
There was previously an ambiguity between the branch/category/itemtype
specific max{,onsite}issueqty and the total-per-patron max{,onsite}issueqty.
The latter has been renamed to patron_max{,onsite}issueqty.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #54 from Jonathan Druart --- Created attachment 82930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82930=edit Bug 18925: Replace logic in GetBranchBorrowerCircRule with get_effective_rule -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jonathan Druart changed: What|Removed |Added Attachment #81091|0 |1 is obsolete|| Attachment #81092|0 |1 is obsolete|| Attachment #81093|0 |1 is obsolete|| Attachment #81094|0 |1 is obsolete|| Attachment #81095|0 |1 is obsolete|| --- Comment #51 from Jonathan Druart --- Created attachment 82927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82927=edit Bug 18925: Move maxissueqty and maxonsiteissueqty to circulation_rules This patch set moves maxissueqty and maxonsiteissueqty to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) prove t/db_dependent/Circulation.t 4) prove t/db_dependent/Circulation/Branch.t 5) prove t/db_dependent/Circulation/GetHardDueDate.t 6) prove t/db_dependent/Circulation/Returns.t 7) prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t 8) prove t/db_dependent/Circulation/TooMany.t 9) prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t 10) prove t/db_dependent/Reserves.t 11) Note no changes in circulation behavior related to check out limis both on and off site -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21969 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21969] Koha::Account->outstanding_* should look for debits/credits by checking 'amount'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21969 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=14591 CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||k...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com Summary|Koha::Account->outstanding_ |Koha::Account->outstanding_ |* should look for |* should look for |debits/cerdits by checking |debits/credits by checking |'amount'|'amount' Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21969] New: Koha::Account->outstanding_* should look for debits/cerdits by checking 'amount'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21969 Bug ID: 21969 Summary: Koha::Account->outstanding_* should look for debits/cerdits by checking 'amount' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org The current implementation checks 'amountoutstanding' matches what's expected for debits (i.e. > 0) and credits (i.e. < 0). But there are pathological use cases in Koha (that we need to deal with), specially related to accruing fines and back dated returns (and so dropbox mode) that trigger false positives (specifically debits with amountoutstanding being negative, then meaning they are actually credits). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 --- Comment #23 from Jonathan Druart --- Maybe not: when editing a record, the selector .main seems to not be the best one -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 --- Comment #22 from Jonathan Druart --- (In reply to Owen Leonard from comment #19) > (In reply to Jonathan Druart from comment #16) > > Maybe not blocker but it has the same issue we fixed with our previous > > changes > > I think this updated patch solves this problem. Indeed, thanks! I amended the commit message of your patch to reflect what it actually does, I hope you are ok with it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 Jonathan Druart changed: What|Removed |Added Attachment #82924|0 |1 is obsolete|| --- Comment #20 from Jonathan Druart --- Created attachment 82925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82925=edit Bug 21751: Replace fixFloat with HC-sticky to fix Chrome display This patch replaces the fixFloat jQuery plugin with a new one: HC-sticky (https://github.com/somewebmedia/hc-sticky). This plugin provides the same functionality without the page-reflow problems fixFloat suffers from. To test, apply the patch and regenerate the staff client CSS. Test the behavior of the floating toolbar on these pages: - Acquisitions -> Vendor -> Vendor details - Acquisitions -> Vendor -> View basket - On both these pages, test toolbar behavior before and after expanding the "Orders search" options at the top of the page. - Administration -> System preferences - Authorities -> Create or edit an authority - Catalog -> Advanced search - Search results - Catalog -> Item search - Cataloging -> Add or edit a record - Open the plugin window for the 008 field - Tools -> Label creator -> New label batch -> Add items -> Search -> Results - Patrons -> New patron - Test before and after expanding the patron search options at the top of the page - Test editing a patron too - Tools -> Automatic item modifications by age -> Edit - Tools -> Notices & slips -> Edit - Lists -> View list Check that the About page has been updated with information about the plugin. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 --- Comment #21 from Jonathan Druart --- Created attachment 82926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82926=edit Bug 21751: Remove former fixFloat plugin Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21964] Switch two-column templates to Bootstrap grid: Patrons part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21964 Owen Leonard changed: What|Removed |Added Blocks||11375 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 [Bug 11375] Improve patrons permissions display -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 Owen Leonard changed: What|Removed |Added Blocks||11375 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 [Bug 11375] Improve patrons permissions display -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Owen Leonard changed: What|Removed |Added Depends on||21751, 21964 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 [Bug 21751] fixFloat toolbar not displaying properly in Chrome https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21964 [Bug 21964] Switch two-column templates to Bootstrap grid: Patrons part 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 --- Comment #19 from Owen Leonard --- (In reply to Jonathan Druart from comment #16) > Maybe not blocker but it has the same issue we fixed with our previous > changes I think this updated patch solves this problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 Owen Leonard changed: What|Removed |Added Attachment #82908|0 |1 is obsolete|| --- Comment #18 from Owen Leonard --- Created attachment 82924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82924=edit Bug 21751: fixFloat toolbar not displaying properly in Chrome This patch replaces the fixFloat jQuery plugin with a new one: HC-sticky (https://github.com/somewebmedia/hc-sticky). This plugin provides the same functionality without the page-reflow problems fixFloat suffers from. To test, apply the patch and regenerate the staff client CSS. Test the behavior of the floating toolbar on these pages: - Acquisitions -> Vendor -> Vendor details - Acquisitions -> Vendor -> View basket - On both these pages, test toolbar behavior before and after expanding the "Orders search" options at the top of the page. - Administration -> System preferences - Authorities -> Create or edit an authority - Catalog -> Advanced search - Search results - Catalog -> Item search - Cataloging -> Add or edit a record - Open the plugin window for the 008 field - Tools -> Label creator -> New label batch -> Add items -> Search -> Results - Patrons -> New patron - Test before and after expanding the patron search options at the top of the page - Test editing a patron too - Tools -> Automatic item modifications by age -> Edit - Tools -> Notices & slips -> Edit - Lists -> View list Check that the About page has been updated with information about the plugin. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21627] System preference for recipient emails of gather_print_notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21627 --- Comment #5 from Danielle Elder --- I would love to see the email address default to the branches.branchemail when the --split parameter is used.Otherwise I have to set up additional crons to send the individual notices to each branch e-mail. This gets very lengthy and can end up being dozens of crons for systems with multiple branches. I'd love to simplify this for multi-branch libraries. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21627] System preference for recipient emails of gather_print_notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21627 Danielle Elder changed: What|Removed |Added CC||danielle@bywatersolutions.c ||om --- Comment #4 from Danielle Elder --- I would love to see the email address default to the branches.branchemail when the --split parameter is used.Otherwise I have to set up additional crons to send the individual notices to each branch e-mail. This gets very lengthy and can end up being dozens of crons for systems with multiple branches. I'd love to simplify this for multi-branch libraries. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart changed: What|Removed |Added Status|REOPENED|NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #39 from Jonathan Druart --- Resetting to New. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21904] Patron search library dropdown should be limited by group if "Hide patron info" is enabled for group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21904 --- Comment #1 from Jonathan Druart --- Created attachment 82923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82923=edit Bug 21904: Hide libraries outside of the group in the header Fix typo To test: 1 - Create a library group with two libraries 2 - Enable hiding patron info for that group 3 - Find or create a patron at one of those libraries without view_borrower_infos_from_any_libraries permission (but with staff side permission) 4 - Sign in as that staff person 5 - Click 'Patrons' 6 - Click the [+] to expand search options 7 - Set the 'Library' dropdown to a library outside of the group 8 - Search -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21904] Patron search library dropdown should be limited by group if "Hide patron info" is enabled for group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21904 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14567] Browse interface for OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Jessie Zairo changed: What|Removed |Added CC||jza...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21947] Filtering order generates html in notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947 --- Comment #10 from Jonathan Druart --- Created attachment 82922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82922=edit Bug 21947: Address other misordered FILTER lines As per comment #3, this patch changes the order for all the filters found with the recommended git grep. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21947] Filtering order generates html in notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21947] Filtering order generates html in notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947 Jonathan Druart changed: What|Removed |Added Attachment #82861|0 |1 is obsolete|| Attachment #82862|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 82921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82921=edit Bug 21947: Swap the filter order TEST PLAN -- 1) start your kohadevbox 2) cd kohaclone 3) git checkout -b bug_21947 origin/master 4) git bz apply 21947 5) reset_all 6) log in to staff client and add a 500$a with lots of blank lines between strings with some HTML. 7) look at the opac record Title notes tab. -- does it have -mess? Should not. 8) repeat steps 5-7 on master, and you'll see a -mess. 9) run qa test tools Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What|Removed |Added Blocks||21947 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21947 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947 [Bug 21947] Filtering order generates html in notes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21947] Filtering order generates html in notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947 Jonathan Druart changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13618 | Depends on||13618 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Add additional template filter methods and a filter presence test to Koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21453] blinddetail-biblio-search.pl/.tt use hardcoded subfield values for MARC21
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21453
--- Comment #6 from M. Tompsett ---
Comment on attachment 80140
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80140
Bug 21453: blinddetail-biblio-search.pl/.tt use hardcoded subfield values for
MARC21
Review of attachment 80140:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=21453=80140)
-
::: authorities/blinddetail-biblio-search.pl
@@ +92,4 @@
> # Get all values for each distinct subfield and add to subfield loop
> my %done_subfields;
> for ( $field->subfields ) {
> +next if $_->[0] eq '3'; # $3 will be set with authid value (in
> UNIMARC authorities)
UNIMARC isn't checked. Bad expression?
@@ +129,3 @@
> $template->param(
> +source => $source,
> +marcflavour => $marcflavour,
There is no need to pass a systempreference.
:::
koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt
@@ +35,5 @@
> [%- FOREACH marc_value IN SUBFIELD_LOO.marc_values -%]
> [%- marc_value |replace("'", "\'") |replace('"',
> '\"') |replace('\n', '\\n') |replace('\r', '\\r') | html -%]
> [%- END -%]
> +[%- END -%][% IF ( marcflavour == 'UNIMARC' ) %]‡3[% authid
> %]";
> +[% ELSIF ( marcflavour == 'MARC21' ) || ( marcflavour ==
> 'NORMARC' ) %]‡9[% authid %]";
The filter is removed. QA Fail.
@@ +137,4 @@
> [% IF ( clear ) %]
> if (subfield){subfield.value="" ;}
> [% ELSE %]
> +[% IF ( marcflavour == 'UNIMARC' ) %]
Perhaps something like [% marcflavour = Koha.Preference('marcflavour') %] near
the top? To avoid passing this as a parameter?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21453] blinddetail-biblio-search.pl/.tt use hardcoded subfield values for MARC21
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21453 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21465] Cannot overlay patrons when matching by cardnumber if userid exists in file and in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21465 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21849] Offsets not stored correctly in _FixOverduesOnReturn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21849 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21849] Offsets not stored correctly in _FixOverduesOnReturn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21849 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 82919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82919=edit Bug 21849: Add unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21849] Offsets not stored correctly in _FixOverduesOnReturn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21849
--- Comment #6 from Tomás Cohen Arazi ---
Created attachment 82920
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82920=edit
Bug 21849: Two useless Koha::Account::Offset->new calls need attention
Came across those calls in bug 20598 in _FixOverduesOnReturn
Koha::Account::Offset->new(
{
debit_id => $accountline->id,
type => 'Forgiven',
amount => $amountoutstanding * -1,
}
);
This does nothing if you don't store data.
Test Plan:
1) Apply this patch
2) Set up 2 items with overdue fines
3) Return one with dropbox mode
4) Note the dropbox account offset is created
5) Return one with full fine forgiveness
6) Note the forgiven account offset is created
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21849] Offsets not stored correctly in _FixOverduesOnReturn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21849 Tomás Cohen Arazi changed: What|Removed |Added Attachment #82404|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21849] Offsets not stored correctly in _FixOverduesOnReturn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21849 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21849] Offsets not stored correctly in _FixOverduesOnReturn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21849 Tomás Cohen Arazi changed: What|Removed |Added Attachment #82397|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21849] Offsets not stored correctly in _FixOverduesOnReturn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21849 Tomás Cohen Arazi changed: What|Removed |Added Summary|Two useless |Offsets not stored |Koha::Account::Offset->new |correctly in |calls need attention|_FixOverduesOnReturn -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21849] Two useless Koha::Account::Offset->new calls need attention
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21849 Tomás Cohen Arazi changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
