[Koha-bugs] [Bug 17350] Add option to delete data stored in saved_reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17350 AspenCat Team changed: What|Removed |Added CC||aspencatt...@clicweb.org --- Comment #1 from AspenCat Team --- One should have the option to specify the number of results to keep (for example keep two on a report scheduled to run daily, as well as the option to delete saved results - perhaps with a "select all" when viewing saved results for a particular report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18747] Select All in Add Patron Option in Patron Lists only selects the first 20 entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 AspenCat Team changed: What|Removed |Added CC||aspencatt...@clicweb.org --- Comment #2 from AspenCat Team --- We have also noticed this behavior. It makes batch edits of patrons a clunky process of adding 20 at a time. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21754] If an item is marked as lost, any outstanding transfers upon it should be automatically cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 --- Comment #9 from Alex Buckley --- I am not sure if you need to re-test, if you do then confirming the patch applies cleanly and the t/db_dependent/Circulation.t passes after applying the patch would be the only necessary things to test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21754] If an item is marked as lost, any outstanding transfers upon it should be automatically cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754
--- Comment #8 from Alex Buckley ---
Created attachment 83061
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83061=edit
Bug 21754: Automatically clean up outstanding transfers on lost items
This is an alternative to bug 21732 as transfers are automatically cancelled on
marking an item lost, and the items holding rbanch is set to the transfers
source ('from') branch.
When an item is marked as lost, the routine should also clean up any
outstanding transfers.
Also added tests to t/db_dependent/Circulation.t which check:
* If transfer is automatically deleted when item is marked as lost
* If the items holdingbranch automatically changes when item with
transfers on it is marked as lost.
Test plan:
1. Find a item which is in transfer, i.e. find an item with the text in
the 'Status' field of the table in detail.pl that indicates it is in
transfer
2. Set the item to 'Lost' either by clicking on Edit->Edit items from
the detail.pl page
OR
clicking on the Items tab on the left side of the detail.pl page
3. Notice that the transfer is now cancelled for the item and the items
holdingbranch is the transfers source ('from') branch
4. Run t/db_dependent/Circulation.t
Sponsored-by: Brimbank Library, Australia
Signed-off-by: Andreas Hedström Mace
(fixed the introduction of a whitespace line and removed a double
declare warning from the new tests as part of QA)
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21754] If an item is marked as lost, any outstanding transfers upon it should be automatically cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 Alex Buckley changed: What|Removed |Added Attachment #82017|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21754] If an item is marked as lost, any outstanding transfers upon it should be automatically cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 --- Comment #7 from Alex Buckley --- As this is still waiting to be pushed and now conflicts upon being applied I am attaching a rebased patch with the only change being I have changed the number of tests in t/db_dependent/Circulation.pl from 120 to 123. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21098] Add missing budget optgroups to parcels.tt and newemptyorder.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 --- Comment #7 from David Cook --- (In reply to Jonathan Druart from comment #6) > The "Show inactive" does not seem to work on parcels.pl Thanks, Jonathan. I'll take a look at that when I have a moment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21969] Koha::Account->outstanding_* should look for debits/credits by checking 'amount'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21969 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21961] Typo in permission keeps Did you mean? config from showing up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21961 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21947] Filtering order generates html in notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #11 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21908] Add biblio_metadata to rebuild_zebra.pl tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21908 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #9 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21849] Offsets not stored correctly in _FixOverduesOnReturn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21849 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #9 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21934] Allow user to specify name for 'Shibboleth'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21934 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #6 from Katrin Fischer --- ... also: missing filters! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21759] Avoid manually setting amountoutstanding in _FixAccountForLostAndReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21759 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #15 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21934] Allow user to specify name for 'Shibboleth'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21934 --- Comment #5 from Katrin Fischer --- Yeah, but translating '%s login failed' is harder then translating "Shibboleth login failed". It also means that you can't deal with those terms using .po files anymore, some might maintain their own .po files to deal with things like that. It forces people to use jQuery in order to have them multi-lingual. It makes it easy for everyone using only one language in their OPAC, but everyone who offers more than one, will still have to use jQuery. Just explaining where I am coming from. In the case of Shibboleth which is already an odd term... I won't block this. Just thinking this should not turn into a standard way of dealing with terms people want to change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21955] Cache::Memory should not be used as L2 cache
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21955 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #9 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21911] Scoping OPACs by branch does not work with new library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21778] Sorting is inconsistent on patron search based on permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21778 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #34 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21465] Cannot overlay patrons when matching by cardnumber if userid exists in file and in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21465 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #12 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21405] Pagination in authorities search broken for Zebra and broken for 10000+ results in ES
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21405 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #23 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21984] Unable to load second page of results for reports with reused parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21984 Lucas Gass changed: What|Removed |Added Attachment #83057|0 |1 is obsolete|| --- Comment #3 from Lucas Gass --- Created attachment 83060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83060=edit Bug 21984: Pass param_name in ppagination URL To test: 1 - Create a report like: SELECT <>,<>,<> FROM items 2 - Run the report, enter 'CATS' and 'DOGS' 3 - Get results LIKE "CAT | DOG | CAT" 4 - Try to go to page 2 5 - FAIL! (last column is blank) 6 - Apply patch 7 - Run the repot, enter 'CATS' and 'DOGS' 8 - Verify first page looks right 9 - Go to page 2 10 - Results are correct! Signed-off-by: Kyle M Hall Signed-off-by: “Lucas Gass” -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21915] Add a way to automatically reconcile balance for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi changed: What|Removed |Added Attachment #82867|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21915] Add a way to automatically reconcile balance for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi changed: What|Removed |Added Attachment #82866|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21915] Add a way to automatically reconcile balance for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi changed: What|Removed |Added Attachment #82864|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21915] Add a way to automatically reconcile balance for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi changed: What|Removed |Added Attachment #82865|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21915] Add a way to automatically reconcile balance for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi changed: What|Removed |Added Attachment #82863|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21915] Add a way to automatically reconcile balance for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi changed: What|Removed |Added Attachment #83053|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21934] Allow user to specify name for 'Shibboleth'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21934 --- Comment #4 from Nick Clemens --- (In reply to Katrin Fischer from comment #2) > Patches like these are problematic, because they make the text mono-lingual > and harder to translate as we will be missing context. Won't the string showup in the PO as a string with a %s? So that the translation can be written in a sensible way, and the user should be aware of changing the text to fit the context? The other side is that we use a lot of jquery to change this and it is easy to miss - I suppose we could simply add a span whenever the word 'Shibboleth' is used if that is preferable? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21934] Allow user to specify name for 'Shibboleth'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21934 --- Comment #3 from Nick Clemens --- Created attachment 83059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83059=edit Bug 21934: Database update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 --- Comment #14 from Martin Renvoize --- Created attachment 83058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83058=edit Bug 21727: Add clarifications to the POD of adjust Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 --- Comment #13 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #12) > Also to note.. the only use case that exists so far for this method is the > adjustment of the non-definitive 'FU' type accountline which is a 'still > incrementing' charge. > > I think the majority of accounts should be handled by other methods adding > credit/debit pairs and only 'non-definitive/in-progress' incrementing fines > should utilise this method.. > > One such incrementing fine I could think of perhaps wishing to use this in > the future that might make sense would be the introduction of a more > granular lost item charging scheme that acted as a buffer to 'overdue' and > would charge at a different rate whilst the user either found the item or > the system decided it was well and truly lost. (in such a case I would > expect an LU accountype to get paired with the existing L type). I would add the fact that this fee is either a fixed about (by itemtype) or the one specified in the lost item itself. On the second case, that value can get easily outdated compared to real bookseller prices in a changing world, so having a way to adjust that value makes sense in a future. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 Mirko Tietgen changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #27 from Mirko Tietgen --- Also needed in 17.11, adding Fridolin. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 --- Comment #12 from Martin Renvoize --- Also to note.. the only use case that exists so far for this method is the adjustment of the non-definitive 'FU' type accountline which is a 'still incrementing' charge. I think the majority of accounts should be handled by other methods adding credit/debit pairs and only 'non-definitive/in-progress' incrementing fines should utilise this method.. One such incrementing fine I could think of perhaps wishing to use this in the future that might make sense would be the introduction of a more granular lost item charging scheme that acted as a buffer to 'overdue' and would charge at a different rate whilst the user either found the item or the system decided it was well and truly lost. (in such a case I would expect an LU accountype to get paired with the existing L type). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 --- Comment #11 from Martin Renvoize --- Awesome.. thanks for testing (and enhancing the test coverage) Tomas. For Josef's benefit I've also updated the dependancies.. splitting out the exception class additions into their own bug so we're not dependant on the larger and less related bug 21002 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 --- Comment #12 from Katrin Fischer --- :( But thx for the status update, Kyle. Maybe someone will be able to pick this up! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12551] Special due date not cleared after item added through fast cataloging is checked out.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12551 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 21093 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21093] Problem when using specify due date with fast add
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21093 Katrin Fischer changed: What|Removed |Added CC||bar...@bywatersolutions.com --- Comment #3 from Katrin Fischer --- *** Bug 12551 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17350] Add option to delete data stored in saved_reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17350 Jessie Zairo changed: What|Removed |Added CC||jza...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21981] Specify due date, remember for session and alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21981 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21093 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21093] Problem when using specify due date with fast add
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21093 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21981 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21981] Specify due date, remember for session and alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21981 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer --- There is another bug where the checkbox gets checked without being checked, might go in the same direction: Bug 21093 - Problem when using specify due date with fast add -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21098] Add missing budget optgroups to parcels.tt and newemptyorder.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #6 from Jonathan Druart --- The "Show inactive" does not seem to work on parcels.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21984] Unable to load second page of results for reports with reused parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21984 ByWater Sandboxes changed: What|Removed |Added Attachment #83051|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 83057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83057=edit Bug 21984: Pass param_name in ppagination URL To test: 1 - Create a report like: SELECT <>,<>,<> FROM items 2 - Run the report, enter 'CATS' and 'DOGS' 3 - Get results LIKE "CAT | DOG | CAT" 4 - Try to go to page 2 5 - FAIL! (last column is blank) 6 - Apply patch 7 - Run the repot, enter 'CATS' and 'DOGS' 8 - Verify first page looks right 9 - Go to page 2 10 - Results are correct! Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 83056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83056=edit Bug 21727: (QA follow-up) Test lastincrement changes 'adjust' changes the 'lastincrement column, and this behaviour should be tested. This patch just adds tests for that. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 Tomás Cohen Arazi changed: What|Removed |Added Attachment #82777|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 83054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83054=edit Bug 21727: Add tests for Koha::Account::Line->adjust Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 Tomás Cohen Arazi changed: What|Removed |Added Attachment #82778|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 83055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83055=edit Bug 21727: Add ->adjust to Koha::Account::Line This patch introduces a high-level method for updating existing debits, similar to Koha::Account::add_credit and Koha::Account::add_debit. It updates the Koha::Account::Line object, and adds an offset. It also logs if required. It whitelists the account types that are allowed to be adjusted, just in case some others require adjusting, having a single source for truth. To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/Koha/Account/Lines.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21915] Add a way to automatically reconcile balance for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21915] Add a way to automatically reconcile balance for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21915] Add a way to automatically reconcile balance for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Kyle M Hall changed: What|Removed |Added Attachment #82863|0 |1 is obsolete|| Attachment #82864|0 |1 is obsolete|| Attachment #82865|0 |1 is obsolete|| Attachment #82866|0 |1 is obsolete|| Attachment #82867|0 |1 is obsolete|| --- Comment #24 from Kyle M Hall --- Created attachment 83053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83053=edit Bug 21915: Add AccountAutoReconcile syspref This syspref will be used to call the reconcile_balance routing as needed. Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21817] Mock userenv should be a t::lib::Mocks method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21817 --- Comment #5 from Jonathan Druart --- Created attachment 83052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83052=edit Bug 21817: Fix 2 failing tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21817] Mock userenv should be a t::lib::Mocks method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21817 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21984] Unable to load second page of results for reports with reused parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21984 Nick Clemens changed: What|Removed |Added CC||claire_grav...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21981] Specify due date, remember for session and alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21981
--- Comment #3 from Jonathan Druart
---
And to fix the issue from comment 0 we certainly need to pass yet another value
to tell the script stickyduedate must be reset.
So far we are doing:
my $stickyduedate = $query->param('stickyduedate') ||
$session->param('stickyduedate');
which means we cannot tell "stickyduedate" must be turned off
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21984] Unable to load second page of results for reports with reused parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21984 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21984] Unable to load second page of results for reports with reused parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21984 --- Comment #1 from Nick Clemens --- Created attachment 83051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83051=edit Bug 21984: Pass param_name in ppagination URL To test: 1 - Create a report like: SELECT <>,<>,<> FROM items 2 - Run the report, enter 'CATS' and 'DOGS' 3 - Get results LIKE "CAT | DOG | CAT" 4 - Try to go to page 2 5 - FAIL! (last column is blank) 6 - Apply patch 7 - Run the repot, enter 'CATS' and 'DOGS' 8 - Verify first page looks right 9 - Go to page 2 10 - Results are correct! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21981] Specify due date, remember for session and alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21981 --- Comment #2 from Jonathan Druart --- (In reply to Jonathan Druart from comment #1) > Confirmed on master. > > Also the date is not correctly formatted when "remember for session" is set > (always displayed as -MM-DD HH:MM). This problem may be fixed with: modified: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt @ circulation.tt:237 @ [% IF ( DEBT ) %][% END %] [% IF ( INVALID_DATE ) %] - + -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Nick Clemens changed: What|Removed |Added Blocks||21984 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21984 [Bug 21984] Unable to load second page of results for reports with reused parameters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21984] Unable to load second page of results for reports with reused parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21984 Nick Clemens changed: What|Removed |Added Depends on||9634 Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 [Bug 9634] Allow for parameters re-use on SQL reports -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21984] New: Unable to load second page of results for reports with reused parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21984 Bug ID: 21984 Summary: Unable to load second page of results for reports with reused parameters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org 1 - To recreate: Create a report like: SELECT <>,<>,<> FROM items 2 - Run the report, enter 'CATS' and 'DOGS' 3 - Get results LIKE "CAT | DOG | CAT" 4 - Try to go to page 2 5 - FAIL! (last column is blank) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20952] Automatic debian/control updates (oldoldstable/17.11.x)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20952 --- Comment #7 from Mirko Tietgen --- Hi Fridolin, please push for the next 17.11.x. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20952] Automatic debian/control updates (oldoldstable/17.11.x)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20952 Mirko Tietgen changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20952] Automatic debian/control updates (oldoldstable/17.11.x)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20952 Mirko Tietgen changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20952] Automatic debian/control updates (oldoldstable/17.11.x)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20952 Mirko Tietgen changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20952] Automatic debian/control updates (oldoldstable/17.11.x)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20952 Mirko Tietgen changed: What|Removed |Added Attachment #83049|0 |1 is obsolete|| --- Comment #6 from Mirko Tietgen --- Created attachment 83050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83050=edit Bug 20952 - Automatic debian/control updates (oldoldstable/17.11.x) Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20952] Automatic debian/control updates (oldoldstable/17.11.x)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20952 --- Comment #5 from Nightly Build Bot --- Created attachment 83049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83049=edit Bug 20952 - Automatic debian/control updates (oldoldstable/17.11.x) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21969] Koha::Account->outstanding_* should look for debits/credits by checking 'amount'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21969 --- Comment #7 from Kyle M Hall --- Created attachment 83048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83048=edit Bug 21969: Fix Koha::Account->outstanding_* matching the opposite on pathological cases This patch makes outstanding_* methods be safe regarding pathological account lines that get converted into another type because of the value of amountoutstanding To test: - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => FAIL: Tests fail because pathological account lines are wrongly picked. - Apply this patch - Run: k$ prove t/db_dependent/Koha/Account.t =>SUCCESS: All green! Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21969] Koha::Account->outstanding_* should look for debits/credits by checking 'amount'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21969 Kyle M Hall changed: What|Removed |Added Attachment #83011|0 |1 is obsolete|| Attachment #83012|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall --- Created attachment 83047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83047=edit Bug 21969: Regression tests This patch introduces regression tests for Koha::Account::outstanding_* methods so they don't pick wrong lines when amountoutstanding matches what we are looking for (i.e. negative for credits and positive for debits). To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => FAIL: Tests fail because pathological account lines are wrongly picked. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21969] Koha::Account->outstanding_* should look for debits/credits by checking 'amount'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21969 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/18.05.x)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 --- Comment #48 from Mirko Tietgen --- Hi Jesse & Lucas, this bug will have automatically generated updates for the Debian packages whenever a new dependency is pushed. Each supported branch of Koha has its own bug for it. It will not happen very often for 18.05. Please push the patch. The bug will not be closed afterwards but will go back to 'assigned' for the next update to come. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21980] Add some new Exceptions for Koha::Account methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21980 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #4 from Tomás Cohen Arazi --- This trivial enhancement can skip QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/18.05.x)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mirko Tietgen changed: What|Removed |Added CC|fridolin.som...@biblibre.co |je...@bywatersolutions.com, |m, mtomp...@hotmail.com |lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/18.05.x)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mirko Tietgen changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/18.05.x)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mirko Tietgen changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/18.05.x)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mirko Tietgen changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21980] Add some new Exceptions for Koha::Account methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21980 Tomás Cohen Arazi changed: What|Removed |Added Attachment #83008|0 |1 is obsolete|| --- Comment #3 from Tomás Cohen Arazi --- Created attachment 83046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83046=edit Bug 21980: Add new excpetions for Koha::Account He add two new exceptions here; One to be thrown when negative 'amount' is passed into verious account methods that always expect positive decimals and another to be thrown when a bad 'type' is passed into an account method. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21980] Add some new Exceptions for Koha::Account methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21980 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21980] Add some new Exceptions for Koha::Account methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21980 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/18.05.x)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mirko Tietgen changed: What|Removed |Added Attachment #83044|0 |1 is obsolete|| --- Comment #47 from Mirko Tietgen --- Created attachment 83045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83045=edit Bug 17111 - Automatic debian/control updates (oldstable/18.05.x) Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21981] Specify due date, remember for session and alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21981 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Version|18.05 |master --- Comment #1 from Jonathan Druart --- Confirmed on master. Also the date is not correctly formatted when "remember for session" is set (always displayed as -MM-DD HH:MM). It will be hard to fix it without being sure it will not introduce regressions, a whole rewrite covered by selenium tests is, in my opinion, the only way to fix issues related to "sticky due date" & friends. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21759] Avoid manually setting amountoutstanding in _FixAccountForLostAndReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21759 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #14 from Martin Renvoize --- Passing QA.. this works as expected and is a marked improvement for auditing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/18.05.x)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 --- Comment #46 from Nightly Build Bot --- Created attachment 83044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83044=edit Bug 17111 - Automatic debian/control updates (oldstable/18.05.x) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21759] Avoid manually setting amountoutstanding in _FixAccountForLostAndReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21759 Martin Renvoize changed: What|Removed |Added Attachment #83041|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize --- Created attachment 83043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83043=edit Bug 21759: Avoid manually setting amountoutstanding in _FixAccountForLostAndReturned This patch changes the behaviour in the _FixAccountForLostAndFound method. The method will now add the amountoutstanding value for the lost item fee to the CR credit to be generated. This means that: - If there's some remaining debt, the same amount will be added to the CR credit and used to cancel that debt. The final amountoutstanding will be the same as before, but an offset will be generated as required. - If the line was written off, the behaviour remains unchanged, so no offset. - If the line was payed and/or written off in full only the payments are refund, preserving the current behaviour. To test: - Apply the regression tests patch - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: Tests fail because the behaviour is not correct - Apply this patch - Run: k$ prove t/db_dependent/Circulation.t => SUCCESS: Tests now pass! - Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21759] Avoid manually setting amountoutstanding in _FixAccountForLostAndReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21759 Martin Renvoize changed: What|Removed |Added Attachment #83040|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 83042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83042=edit Bug 21759: Regression tests This patch tests for a new behaviour in the _FixAccountForLostAndFound method. The method will now add the amountoutstanding value for the lost item fee to the CR credit to be generated. This means that: - If there's some remaining debt, the same amount will be added to the CR credit and used to cancel that debt. The final amountoutstanding will be the same as before, but an offset will be generated as required. - If the line was written off, the behaviour remains unchanged, so no offset. - If the line was payed and/or written off in full only the payments are refund, preserving the current behaviour. Only changes to the 'remaining debt' use cases on this tests are expected. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: Tests fail because the behaviour is not correct. Note: some tests order changes are introduced to avoid calling discard_changes twice Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21817] Mock userenv should be a t::lib::Mocks method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21817 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #4 from Tomás Cohen Arazi --- All looks good! But some new warnings are generated and some tests fail. To reproduce: $ kshell k$ git diff HEAD~ --name-only | grep -e '\.t$' | xargs prove => FAIL: Tests fail: ... t/db_dependent/Acquisition/NewOrder.t 1/8 # Failed test 'Koha::Acquisition::Order->store set created_by to logged in user if not given' # at t/db_dependent/Acquisition/NewOrder.t line 92. # got: '51' # expected: '42' # Looks like you failed 1 test of 8. t/db_dependent/Acquisition/NewOrder.t Dubious, test returned 1 (wstat 256, 0x100) Failed 1/8 subtests t/db_dependent/ArticleRequests.t . ok t/db_dependent/Bookseller.t .. 28/86 # Failed test 'ordinary user can see only their library's subscriptions with IndependentBranches on' # at t/db_dependent/Bookseller.t line 667. # got: '0' # expected: '1' # Looks like you failed 1 test of 86. t/db_dependent/Bookseller.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/86 subtests ... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21759] Avoid manually setting amountoutstanding in _FixAccountForLostAndReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21759 Martin Renvoize changed: What|Removed |Added Attachment #83039|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 83041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83041=edit Bug 21759: Avoid manually setting amountoutstanding in _FixAccountForLostAndReturned This patch changes the behaviour in the _FixAccountForLostAndFound method. The method will now add the amountoutstanding value for the lost item fee to the CR credit to be generated. This means that: - If there's some remaining debt, the same amount will be added to the CR credit and used to cancel that debt. The final amountoutstanding will be the same as before, but an offset will be generated as required. - If the line was written off, the behaviour remains unchanged, so no offset. - If the line was payed and/or written off in full only the payments are refund, preserving the current behaviour. To test: - Apply the regression tests patch - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: Tests fail because the behaviour is not correct - Apply this patch - Run: k$ prove t/db_dependent/Circulation.t => SUCCESS: Tests now pass! - Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21759] Avoid manually setting amountoutstanding in _FixAccountForLostAndReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21759 Martin Renvoize changed: What|Removed |Added Attachment #83038|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 83040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83040=edit Bug 21759: Regression tests This patch tests for a new behaviour in the _FixAccountForLostAndFound method. The method will now add the amountoutstanding value for the lost item fee to the CR credit to be generated. This means that: - If there's some remaining debt, the same amount will be added to the CR credit and used to cancel that debt. The final amountoutstanding will be the same as before, but an offset will be generated as required. - If the line was written off, the behaviour remains unchanged, so no offset. - If the line was payed and/or written off in full only the payments are refund, preserving the current behaviour. Only changes to the 'remaining debt' use cases on this tests are expected. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: Tests fail because the behaviour is not correct. Note: some tests order changes are introduced to avoid calling discard_changes twice Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21759] Avoid manually setting amountoutstanding in _FixAccountForLostAndReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21759 --- Comment #9 from Kyle M Hall --- Created attachment 83039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83039=edit Bug 21759: Avoid manually setting amountoutstanding in _FixAccountForLostAndReturned This patch changes the behaviour in the _FixAccountForLostAndFound method. The method will now add the amountoutstanding value for the lost item fee to the CR credit to be generated. This means that: - If there's some remaining debt, the same amount will be added to the CR credit and used to cancel that debt. The final amountoutstanding will be the same as before, but an offset will be generated as required. - If the line was written off, the behaviour remains unchanged, so no offset. - If the line was payed and/or written off in full only the payments are refund, preserving the current behaviour. To test: - Apply the regression tests patch - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: Tests fail because the behaviour is not correct - Apply this patch - Run: k$ prove t/db_dependent/Circulation.t => SUCCESS: Tests now pass! - Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21759] Avoid manually setting amountoutstanding in _FixAccountForLostAndReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21759 Kyle M Hall changed: What|Removed |Added Attachment #83029|0 |1 is obsolete|| Attachment #83030|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall --- Created attachment 83038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83038=edit Bug 21759: Regression tests This patch tests for a new behaviour in the _FixAccountForLostAndFound method. The method will now add the amountoutstanding value for the lost item fee to the CR credit to be generated. This means that: - If there's some remaining debt, the same amount will be added to the CR credit and used to cancel that debt. The final amountoutstanding will be the same as before, but an offset will be generated as required. - If the line was written off, the behaviour remains unchanged, so no offset. - If the line was payed and/or written off in full only the payments are refund, preserving the current behaviour. Only changes to the 'remaining debt' use cases on this tests are expected. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: Tests fail because the behaviour is not correct. Note: some tests order changes are introduced to avoid calling discard_changes twice Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21759] Avoid manually setting amountoutstanding in _FixAccountForLostAndReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21759 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Holger Meißner changed: What|Removed |Added CC||h.meissner...@web.de --- Comment #17 from Holger Meißner --- (In reply to David Cook from comment #15) > I think the proper solution might be to refactor > C4::Circulation::CanBookBeRenewed and then maybe make a separate function > C4::Circulation::CanBookBeAutoRenewed and make that configurable, since it > seems that different libraries have different needs/wants for autorenewal. That's also the first idea I had. Yet, there would be duplicate code and we shouldn't do that unless we have to. Second idea: Don't prioritize errors in CanBookBeRenewed. We already combine different errors in $error, e.g. if both "too_soon" and "auto_renew" apply, then it's "auto_too_soon". Take this one step further and return a complete list of basic errors instead. That list could be evaluated as needed, e.g. the cronjob could decide not to send a notice, because it's too soon and at the same time opac could decide to display a hold. I don't know whether the loss in performance would be noticable. Third idea: Tell CanBookBeRenewed the context we're in. Give CanBookBeRenewed an additional parameter, so it can return different errors depending on that parameter, e.g. CanBookBeRenewed(123,123,0,X) where X might be something like "auto", "staff" or "opac". Similar to the first idea, but the code stays in one function. Any other ideas? Maybe I'll find time to code in 2019, but I can't promise yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21817] Mock userenv should be a t::lib::Mocks method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21817 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21907] Error from mainpage when Article requests enabled and either IndependentBranches or IndependentBranchesPatronModifications is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21907 --- Comment #2 from Jonathan Druart --- Created attachment 83037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83037=edit Bug 21907: Fix article requests count for non-superlibrarians The query generates "Column 'branchcode' in where clause is ambiguous" Test plan: 1 - Enable 'IndependentBranchesPatronModifications' and article requests 2 - Sign in as non-superlibrarian 3 - View plack log 4 - Refresh mainpage, see error in logs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21907] Error from mainpage when Article requests enabled and either IndependentBranches or IndependentBranchesPatronModifications is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21907 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21907] Error from mainpage when Article requests enabled and either IndependentBranches or IndependentBranchesPatronModifications is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21907 Jonathan Druart changed: What|Removed |Added Depends on||18403 Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- Caused by commit 710175fbe6721583028083d498f1df4a44bb1784 Bug 18403: Article requests Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
