[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #113 from Aleisha Amohia --- Created attachment 84563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84563=edit Bug 15516: (follow-up) Fix pod in C4::Reserves Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What|Removed |Added Attachment #81463|0 |1 is obsolete|| --- Comment #114 from Aleisha Amohia --- Created attachment 84564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84564=edit Bug 15516: (follow-up) Fix template filters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What|Removed |Added Attachment #81457|0 |1 is obsolete|| --- Comment #108 from Aleisha Amohia --- Created attachment 84558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84558=edit Bug 15516: Reword 'reserve group' to 'hold group' Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What|Removed |Added Attachment #81458|0 |1 is obsolete|| --- Comment #109 from Aleisha Amohia --- Created attachment 84559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84559=edit Bug 15516: Fix translation issues - Use " inside _() - Merge two strings (PART_OF_A, HOLD_GROUP) Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What|Removed |Added Attachment #81460|0 |1 is obsolete|| --- Comment #111 from Aleisha Amohia --- Created attachment 84561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84561=edit Bug 15516: (follow-up) Fix reserve -> hold change Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What|Removed |Added Attachment #81461|0 |1 is obsolete|| --- Comment #112 from Aleisha Amohia --- Created attachment 84562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84562=edit Bug 15516: (follow-up) Fix modal for hold group Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What|Removed |Added Attachment #81459|0 |1 is obsolete|| --- Comment #110 from Aleisha Amohia --- Created attachment 84560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84560=edit Bug 15516: (follow-up) Fix kohastructure.sql Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What|Removed |Added Attachment #81454|0 |1 is obsolete|| --- Comment #105 from Aleisha Amohia --- Created attachment 84555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84555=edit Bug 15516: Holding first available item from x biblios only count 1 reserve Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What|Removed |Added Attachment #81455|0 |1 is obsolete|| --- Comment #106 from Aleisha Amohia --- Created attachment 84556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84556=edit Bug 15516: Update old_reserves (reserve_group_id) Without it, deletion of reserves will fail Signed-off-by: Benjamin Rokseth Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What|Removed |Added Attachment #81456|0 |1 is obsolete|| --- Comment #107 from Aleisha Amohia --- Created attachment 84557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84557=edit Bug 15516: Set reserve-group.pl to be executable Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What|Removed |Added Attachment #81453|0 |1 is obsolete|| --- Comment #104 from Aleisha Amohia --- Created attachment 84554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84554=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library have the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This patch is only for staff interface. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Enter a patron cardnumber and click Search 3. Check the box for 'Place a hold on the next available item' (it's usually hidden when placing a hold on multiple biblios) 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a reserve group)' in Details column. 6. Click on the "reserve group" link. A modal window should appear with the content of the reserve group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "reserve group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz Attachment #81462|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #207 from Aleisha Amohia --- Created attachment 84553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84553=edit Bug 15565: (follow-up) fixing typo that breaks placing a hold -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #206 from Aleisha Amohia --- Patches have been rebased. Working on improving the code and including design/layout changes that were requested by Brimbank. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #83381|0 |1 is obsolete|| --- Comment #205 from Aleisha Amohia --- Created attachment 84552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84552=edit Bug 15565: (follow-up) Place multiple holds from opac-search.pl Previously before this patch if you selected multiple bibliographic results from opac-search.pl and selected 'Place hold' and confirmed the hold only 1 hold on the first of the selected biblios would be placed. This patch fixes this bug and enables users to be able to place holds on multiple bibliographic records in opac-search.pl, select 'Place hold', select if they want each of these holds to be on 'Next available', 'Next available from group', or 'A specific item' and place their holds and all the holds they placed will be placed correctly. Test plan: 1. Follow test plan on the last patch - (Don't apply this patch) 2. Try to select multiple bibliographic record checkboxes and select 'Place hold' 3. Confirm holds and notice you are re-directed to opac-user.pl and only the first hold has been placed 4. Apply this patch 5. Restart memcached and plack if running 6. Repeat steps 2 and 3 and notice all holds were placed 7. Repeat step 2 and then select a variety of 'A specific item' and 'Next available item' holds for each of the bibliographic holds and confirm they are all placed correctly 8. Confirm you can still place multiple holds correctly in opac-reserve accessing from a OPAC biblio detail page Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #83380|0 |1 is obsolete|| --- Comment #204 from Aleisha Amohia --- Created attachment 84551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84551=edit Bug 15565: (follow-up) Changes to maximum hold allowed logic Implemented changes to the logic to address Katrin Fischer's points in comment #175, also changed the modal box wording to use 'hold' not 'reserve' Also updated t/db_dependent/Reserves/MultiplePerRecord.t test to reflect moving function. Added the display of the JS modal box informing OPAC borrower that they have exceeded hold limit after they click 'A specific item' radiobutton on opac-reserve if holds per day, holds per record or maxreserves is 1 Test plan: 1. Apply patches 2. Restart memcached and plack 3. Run t/db_dependent/Reserves/MultiplePerRecord.t 4. Set your maxreserves syspref to 3, and a circ rules holds per record to 2 and holds per day to 1 5. In the OPAC visit the 'Place hold' interface of item. Select the 'A specific item' radiobutton and observe the first item checkbox is checked and other unchecked checkboxes are disabled. 6. Repeat step 4 this time setting holds per day to 5 7. Now reloading the OPAC 'Place hold' page notice after clicking 'A specific item' no modal displays 8. Select a second item checkbox and observe a modal saying you have reached the maximum number of holds for the record is loaded - notice the wording 'hold' not 'reserve' in use in the modal box 9. Click 'OK' on modal and observe all unchecked item checkboxes are automatically disabled to prevent additional holds being placed 10. Select 'Confirm hold' 11. On your holds summary page confirm both holds are placed 12. In the staff client set the 'AllowHoldPolicyOverride' syspref to "Don't allow" 13. Visit a biblio reservation interface in the staff client 14. Select 2 item checkboxes and observe the modal box explaining you have reached maximum holds for the record is displayed - notice the wording of 'hold' not 'reserve' is used in the modal box. 15. Select 'OK' on the modal and notice all un-checked item checkboxes are automatically disabled 16. Repeat steps 12-15 this time with the value of 'AllowHoldPolicyOverride' syspref set to 'Allow' and notice that once you have clicked on the second item checkbox although the modal still loads the item checkboxes do not disable - you are able to override and continue selecting checkboxes each time with modal warning loading. 17. In both the OPAC and staff client try placing a record level hold, selecting a value from the 'Holds to place (count)' dropdown. Notice that the maximum value of this is the lowest value out of the 'maximum number of holds per record', 'maximum number of holds per day' and the 'maxreserves' system preference so in this case it will be 2 18. Save and notice 2 holds are placed 19. Observe the allow_holds() function is in the Koha/Biblio.pm file and the GetAllowedHoldsForPatronToday() function has been removed from C4/Reserves.pm Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #83339|0 |1 is obsolete|| --- Comment #202 from Aleisha Amohia --- Created attachment 84549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84549=edit Bug 15565: (follow-up) Removed leftover debug code and added missing filters Sponsord-By: Brimbank Library, Australia Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #83340|0 |1 is obsolete|| --- Comment #203 from Aleisha Amohia --- Created attachment 84550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84550=edit Bug 15565: (QA follow-up) Fix some last filters Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #83338|0 |1 is obsolete|| --- Comment #201 from Aleisha Amohia --- Created attachment 84548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84548=edit Bug 15565: Allow up to (and including) maxreserves number of OPAC item levelholds This commit implements changes to opac-reserve.tt and opac-reserve.pl. 1. The change to opac-reserve.tt JS fixes the total_requested() function which returns an output which is always 2 digits higher than the actual number of selected item checkboxes. i.e. if the 'maxreserves' syspref (limit for the overall number of reserves allowed by a user) is 4 and a user has no previous holds and ticks 3 item checkboxes and submits the form. The 'Maximum number of reserve exceded.' popup message is displayed, however as they have selected 3 items for reservation this is less than the maxreserves value of 4. The popup is displayed because total_requested() JS function is returning 5 (i.e. 2 on top of the actual number of requested holds). This commit usbtracts 2 from the number of holds calculated by total_requested() so that the accurate number of requested holds is being used to determine whether or not to display the excess holds popup. 2. When the 'Holds per record (count)' (circulation rule) and 'maxreserves' syspref are the same value (e.g. 4) you can tick 4 item checkboxes in opac-reserve.pl and submit the form. The form will submit successfully and to the user everything looks to have worked however the holds will not be successfully created. This is because after the form is submitted to opac-reserve.pl a check is done: If 'number of submitted hold requests' + 'number of previous existing holds' greater than or equal to maxreserves syspref then set the variable '$canreserve' to 0. If the $canreserve variable is 0 the form will submit, no warning/error message is displayed to the user but the holds are not created. Users should be able to place 4 holds if the maxreserves syspref is 4 (just not more than 4 holds). This commit changes this check to: If 'number of submitted hold requests' + 'number of previous existing holds' greater than maxreserves syspref then set the variable '$canreserve' to 0.. i.e. notice we only check for greater than (not equal to). Which solves the bug of the form submitting and no holds being created when the maxreserves syspref and 'Holds per record (count)' (circulation rule) are the same. Test plan (in two parts to test fix #1 and #2 (above)): Test plan for fix #1: 1. Apply all patches on this bug report (15565) and follow and confirm the feature works as described in the test plan in the first commit 2. Set the 'maxreserves' syspref to 3 (and 'Holds per record (count)' (circulation rule) to 5) 3. Ensure your logged in patron account has no existing reserves 4. In the OPAC go to a biblio page with 3 or more items 5. In the reservation page (opac-reserve.pl) for that biblio select 2 item checkboes to place 2 item level holds and notice the 'Maximum number of reserve exceded.' popup message is displayed. As the maxreserves syspref value is 3 you should be able to place 2 holds without exceeding that value 6. Apply this patch 7. Repeat step 5 and notice the form submits without the exceeding popup message and the holds are successfully placed. Test plan for fix #2: 1. Apply all patches attached to this bug report (bug 15565) and perform the test plan in the first commit and verify it works. 2. Set your 'Holds per record (count)' (circulation rule) and 'maxreserves' syspref to the same value 3 3. Go to a biblio in the OPAC with 3 or more items 4. In the opac-reserve.pl reservation interface for that biblio tick 3 item checkboxes to place 3 item level holds and submit the form. 5. Notice the form submits and no warning/error message is displayed 6. In the opac user summary page that is displayed after the reserve form is submitted notice the holds are not displayed this is because they have not been placed 7. Apply this patch 8. Repeat step 4 and 5 and notice the holds have been successfully placed and are displayed in your opac user summary page. Sponsored-By: Brimbank Library Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #83334|0 |1 is obsolete|| --- Comment #197 from Aleisha Amohia --- Created attachment 84544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84544=edit Bug 15565: Alert librarian that maximum holds per record is reached Signed-off-by: Dani Elder Signed-off-by: Danielle Elder Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE Signed-off-by: Kyle M Hall Signed-off-by: Benjamin Rokseth Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #83335|0 |1 is obsolete|| --- Comment #198 from Aleisha Amohia --- Created attachment 84545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84545=edit Bug 15565: Remove use of GetBiblionumberFromItemnumber Signed-off-by: Benjamin Rokseth Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #83336|0 |1 is obsolete|| --- Comment #199 from Aleisha Amohia --- Created attachment 84546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84546=edit Bug 15565: Fixed issues preventing any item-level holds being placed in OPAC This commit fixes two bugs: 1. C4::Reserves->CanItemBeReserved() returns an output in a hash in the format: status => 'output' However opac-reserve.pl is not accessing th output of this function correctly consequently no item is ever reservable. And so after a patron submits the reservation form on opac-reserve.pl it looks like the item-level reservation has successfully been placed however it has not and no error message is displayed to them. This commit stores the output of the aforementioned function in a hash and then checks the value of the status key. As a result opac-reserve.pl now correctly accesses the value returned and item level holds are successfully placed from the OPAC. 2. If a biblio has previously been reserved then the opac-reserve.pl page shows the 'Next available item' and 'A specific item' radio buttons to be disabled to ensure patrons cannot place a reservation of a different type on the biblio. With both of these radio buttons being disabled it results in item level holds placed in the OPAC on a previously reserved item not being stored in the database. This is very confusing for users. I have implemented a conditional which checks what the forced_hold_type of the previous hold was. If it was 'item' then the $reqtype = 'Specific' and if it was 'record' then $reqtype is 'Any'. This means there will always be a value for $reqtype, and this variable is checked if it is equal to 'Specific' and if it is then an item level hold is placed. Test plan: 1. Ensure in your circulation rules that 'Item level holds' is enabled 2. Apply all patches on this bug report except this commit 3. In the OPAC try placing a item level hold (and notice you can submit the opac-reserve.pl page and no error messages are displayed. However the hold(s) are not being placed. 4. Place an item level hold(s) on the biblio from staff client interface and then return to the opac-reserve.pl page for the biblio in the OPAC and notice both the 'Next available' and 'A specific item' radio buttons are disabled. 5. Again try placing an item level hold in the OPAC and notice dispite no error/warning message being displayed the hold is not being placed. 6. Apply this patch 7. Restart memcached, and plack 8. In the staff client remove the reservation you placed from the staff client. 9. Repeat step 3 and notice when you go to your opac summary (opac-user.pl) page the holds are displayed. .i.e. You can now successfully place item level holds in the OPAC. 10. Return to the opac-reserve.pl page for the biblio and notice that because you have already placed a hold on this biblio the 'Next available item' and 'A specific item' radiobuttons are disabled. 11. Select several of the items checkboxes to place more item level holds and press the 'Confirm hold' button. 12. Go to your opac summary (opac-user.pl) page again and notice the holds you placed in step 11 are shown there. i.e. you can place item level holds from the OPAC on biblios which have previously had reserves placed on them. Sponsored-By: Brimbank Library Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #8|0 |1 is obsolete|| --- Comment #196 from Aleisha Amohia --- Created attachment 84543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84543=edit Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off Signed-off-by: Danielle Elder Signed-off-by: Séverine QUEUNE Signed-off-by: Kyle M Hall Signed-off-by: Benjamin Rokseth Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #83332|0 |1 is obsolete|| --- Comment #195 from Aleisha Amohia --- Created attachment 84542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84542=edit Bug 15565: Use item's biblionumber only on item-level request Signed-off-by: Séverine QUEUNE Signed-off-by: Kyle M Hall Signed-off-by: Benjamin Rokseth Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #83337|0 |1 is obsolete|| --- Comment #200 from Aleisha Amohia --- Created attachment 84547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84547=edit Bug 15565: Changed the retrieval of selected hold pickup branch in opac-reserve.pl Previously the selected branch dropdown value was not being successfully retrieved in opac-reserve.pl, this resulted in opac holds being placed with no pickup branch being set. Consequently as no branch was associated with the hold an Ajax error was thrown when viewing the holds-table in the patron page in the staff client. This commit successfully retrieves the selected branch value and so fixing the Ajax error. Test plan: 1. Apply all patches on bug report 15565 except this commit 2. Place a hold(s) from opac-reserve.pl. 3. Go to your opac patron summary page (opac-user.pl) and notice although the holds are successfully displayed they have no 'Pickup location' value 4. Go to the patron page in the staff client and click on the 'Hold(s)' tab and notice a popup explaining the datatable Ajax error is loaded 5. Apply this patch 6. Repeat step 3 noticing this time in the opac-user.pl a 'Pickup location' is displayed for the hold you just created. 6. Repeat step 4 and notice the hold datatable is successfully loaded and populated without an Ajax error popup being loaded. Sponsored-By: Brimbank Library Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #83331|0 |1 is obsolete|| --- Comment #194 from Aleisha Amohia --- Created attachment 84541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84541=edit Bug 15565: Place multiple holds at once for the same record on staff and OPAC. Test plan: 1. Create an circulation rule to use for testing the patches on this bug report. Ensure it has a value greater than 1 for 'Holds allowed', 'Holds per record (count)', and 'Item level holds' is enabled. 2. Also ensure the 'RequestOnOpac' syspref is set to 'Allow'. 3. Go to the reservation page (request.pl) of a biblio in the staff client with more than one item. 4. Notice beside each item a radio button is displayed preventing you from being able to select multiple items to place a hold on. 5. Go to the reservation page (opac-reserve.pl) of the same biblio in the OPAC also notice a radio button is displayed beside every item. 6. Apply patches 7. Repeat step 3 and 5 and notice in both the staff client and OPAC checkboxes rather than radio buttons are displayed beside each item so you can select multiple items for reservation at a time. 8. From staff interface, place several item-level holds for the same user on the same record at once: - check that you are warned if you exceed "Holds per record (count)" (circulation rules) for this record. - check also maxReserves system preference. 9. From opac, place several item-level and record level holds for the same user on the same record at once: - check that can't exceed "Holds per record (count)" for this record. This is enforced by all unticked item checkboxes being disabled after the number of ticked checkboxes equals the 'Holds per record (count)' (circulation rules) value. - check also maxReserves system preference. Do the same in OPAC and staff by selecting several record (multi-hold). Signed-off-by: Séverine QUEUNE Signed-off-by: Kyle M Hall Signed-off-by: Benjamin Rokseth Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22232] Advanced Cataloguing Editor (Rancor) to edit authority records?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22232 --- Comment #2 from Carlos Lopez --- (In reply to Katrin Fischer from comment #1) > Hi Carlos, not a lot of people read the bug email - maybe ask the mailing > list in parallel. Thanks Katrin I'll do that. c. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22098] Update stocknumberAV cataloguing plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22193] Mana - share comments about reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com --- Comment #3 from Michal Denar --- Hi Alex, last two lines on test plan don't work for me More than one comments https://screenshots.firefox.com/bUEQMVj2BDVcwhpJ/localhost After reload: back "New" https://screenshots.firefox.com/f65JRGJd5rayY6ll/localhost Mike -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22237] Subscriptions are not linked to Mana upon edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22241] Duplicate records.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22241 Estel Porras changed: What|Removed |Added CC||or...@yahoo.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22241] New: Duplicate records.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22241 Bug ID: 22241 Summary: Duplicate records. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: or...@yahoo.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Target Milestone: --- Within the last two days, when adding new items to the catalog, I get a "barcode must be original" message. I know this is a new barcode. I then discovered that the item I just added was showing up twice, with one of the records showing no items. I have just been going in and removing these, but this is trouble, if I don't catch it...which may have already happened. I cleared my cache, in case there was an update I wasn't aware of, but it is still happening, that is why I am submitting this ticket. Estel Porras, Orland Free Library, or...@yahoo.com (530)865-1640 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9069] Make it possible to import MARC21 authorities from VIAF into Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9069 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22239] JavaScript error on subscription detail page when there are no orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22239 --- Comment #1 from Owen Leonard --- Created attachment 84540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84540=edit Bug 22239: JavaScript error on subscription detail page when there are no orders This page modifies the subscription detail page so that a JavaScript error isn't triggered when a subscription has no acquisition details. To test, apply the patch and go to Serials. - Locate a subscription which isn't tied to acquisitions. In the browser console there should be no errors. - Locate a subscription which is part of an order. There should be an 'Acquisitions details' tab and the order information on that tab should be displayed as a collapsible tree. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22239] JavaScript error on subscription detail page when there are no orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22239 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22240] Add possibility to specify a category of patron in calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22240 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Patrick, I am always interested in the use cases. The calendar mostly affects the holds queue, fines and due dates. Can you explain how you'd use the feature? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22240] New: Add possibility to specify a category of patron in calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22240 Bug ID: 22240 Summary: Add possibility to specify a category of patron in calendar Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: patrick.robitai...@collecto.ca QA Contact: testo...@bugs.koha-community.org Target Milestone: --- Hi, Currently when we add a closing day in the calendar we can not specify a particular patron category. Which means, this day of closure affects all types of patrons of the library and at the same time the circulation rules. It would be nice if when we add a closing day, to have the possibility to specify a category of patrons that would be subject to this closing day. Like that, the rest of the patrons catgory are not concerned by this limitation. It could be an additional option in the page to choose the type of closing day where you would have access to the list of types of users in the library. Thanks, Patrick. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22239] New: JavaScript error on subscription detail page when there are no orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22239 Bug ID: 22239 Summary: JavaScript error on subscription detail page when there are no orders Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Serials Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com Depends on: 21467 Target Milestone: --- I get a JavaScript error in the console when I view the details of a subscription (serials/subscription-detail.pl): TypeError: this.data(...) is undefined[Learn More] jquery.treetable_18.1200010.js:481:7 I assume this is because I don't have any orders associated with my subscription? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 [Bug 21467] Allow several receipts for a given subscription -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21467] Allow several receipts for a given subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Owen Leonard changed: What|Removed |Added Blocks||22239 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22239 [Bug 22239] JavaScript error on subscription detail page when there are no orders -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22230] Make SearchWithISBNVariations search in index keyword
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22230 --- Comment #4 from Katrin Fischer --- If we do it, we could have multiple options for the pref maybe to determine behaviour in different spots. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22230] Make SearchWithISBNVariations search in index keyword
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22230 --- Comment #3 from Katrin Fischer --- I assume the problem why this was not done before is that you'd have to look at each and every search entered and try to verify if it contains something that looks like an ISBN. I am not sure if this kind of processing could impact performance? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22227] Make GET /cities staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7
Jon Knight changed:
What|Removed |Added
CC||j.p.kni...@lboro.ac.uk
--- Comment #2 from Jon Knight ---
Do we need to do anything other than what is in the test plan on a kohadevbox?
For example have some particular data loaded in our database? I've just tried
to apply the patch with the following result:
vagrant@kohadevbox:kohaclone(master)$ git checkout -b bug7
Switched to a new branch 'bug7'
vagrant@kohadevbox:kohaclone(bug7)$ git bz apply 7
Bug 7 - Make GET /cities staff only
84507 - Bug 7: Make GET /cities staff only
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 7: Make GET /cities staff only
vagrant@kohadevbox:kohaclone(bug7)$ kshell
kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove
t/db_dependent/api/v1/cities.t
t/db_dependent/api/v1/cities.t ..
# Failed test '200 OK'
# at t/db_dependent/api/v1/cities.t line 87.
# got: '400'
# expected: '200'
# Failed test 'exact match for JSON Pointer ""'
# at t/db_dependent/api/v1/cities.t line 87.
# Structures begin differing at:
# $got->[0]{state} = Does not exist
# $expected->[0]{state} =
'O5v1BdpdGC68BA87LFM5W_sSkKGJLmnkPL4rz_34K8hlXzvLUtZsoeuJ8x6tv8zKdJ'
# Failed test '200 OK'
# at t/db_dependent/api/v1/cities.t line 96.
# got: '400'
# expected: '200'
# Failed test 'exact match for JSON Pointer ""'
# at t/db_dependent/api/v1/cities.t line 96.
# Structures begin differing at:
# $got->[0]{city_id} = Does not exist
# $expected->[0]{city_id} = '12'
# Looks like you failed 4 tests of 18.
t/db_dependent/api/v1/cities.t .. 1/5
# Failed test 'list() tests'
# at t/db_dependent/api/v1/cities.t line 109.
# Failed test '403 Forbidden'
# at t/db_dependent/api/v1/cities.t line 162.
# got: '200'
# expected: '403'
# Looks like you failed 1 test of 17.
# Failed test 'add() tests'
# at t/db_dependent/api/v1/cities.t line 226.
# Failed test '403 Forbidden'
# at t/db_dependent/api/v1/cities.t line 246.
# got: '400'
# expected: '403'
# Looks like you failed 1 test of 15.
# Failed test 'update() tests'
# at t/db_dependent/api/v1/cities.t line 324.
# Failed test '403 Forbidden'
# at t/db_dependent/api/v1/cities.t line 343.
# got: '200'
# expected: '403'
# Failed test '200 OK'
# at t/db_dependent/api/v1/cities.t line 349.
# got: '404'
# expected: '200'
# Failed test 'exact match for content'
# at t/db_dependent/api/v1/cities.t line 349.
# got: '{"error":"Object not found"}'
# expected: '""'
# Looks like you failed 3 tests of 7.
# Failed test 'delete() tests'
# at t/db_dependent/api/v1/cities.t line 360.
# Looks like you failed 4 tests of 5.
t/db_dependent/api/v1/cities.t .. Dubious, test returned 4 (wstat 1024, 0x400)
Failed 4/5 subtests
Test Summary Report
---
t/db_dependent/api/v1/cities.t (Wstat: 1024 Tests: 5 Failed: 4)
Failed tests: 1, 3-5
Non-zero exit status: 4
Files=1, Tests=5, 3 wallclock secs ( 0.02 usr 0.00 sys + 2.37 cusr 0.24
csys = 2.63 CPU)
Result: FAIL
kohadev-koha@kohadevbox:/home/vagrant/kohaclone$
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132 --- Comment #24 from Tomás Cohen Arazi --- Created attachment 84538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84538=edit Bug 22132: (QA follow-up) Tests - use Mojo builtin for auth Mojolicious has built in handling for encoding/decoding of of basic auth paramenters. We should use it to simplify our test here. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 84539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84539=edit Bug 22132: (QA follow-up) set_password now expects a hashref Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 84536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84536=edit Bug 22132: Unit tests Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132 --- Comment #23 from Tomás Cohen Arazi --- Created attachment 84537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84537=edit Bug 22132: Add Basic authentication to the API This patch implements Basic authentication for the API to aid testers and developers with tools like Postman. To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/api/v1/auth_basic.t => SUCCESS: Tests pass! - Open Postman or your favourite tool - In Authorization, choose Basic auth. - Enter the username and password of a known privileged user. - Hit an endpoint with Postman, for example: ] GET http://kohadev-intra.myDNSname.org:8081/api/v1/patrons => SUCCESS: Basic authentication is great! - Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132 --- Comment #21 from Tomás Cohen Arazi --- Created attachment 84535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84535=edit Bug 22132: Add RESTBasicAuth syspref Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132 Tomás Cohen Arazi changed: What|Removed |Added Attachment #84363|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132 Tomás Cohen Arazi changed: What|Removed |Added Attachment #84371|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132 Tomás Cohen Arazi changed: What|Removed |Added Attachment #84364|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132 Tomás Cohen Arazi changed: What|Removed |Added Attachment #84362|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22230] Make SearchWithISBNVariations search in index keyword
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22230 --- Comment #2 from Patrick Robitaille --- Hello Katrin, When scanning a document with the barcode, we would like to avoid having to choose the ISBN index to get a search that also shows the variantions of this ISBN. That ISBNs in 7xx and 8xx come out with this research on ISBN variations does not seem a problem for us, on the contrary. Most of the time we have the ISBNs of the other versions of the documents. So if these documents are retrieved by research, that's what we want. For us, it would allow us to see that we have the same document but in another format. thanks, Patrick. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22238] Remove koha-*-sip scripts in favor of koha-sip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22238 Tomás Cohen Arazi changed: What|Removed |Added Text to go in the||The new koha-sip release notes||maintenance script replaces ||the old koha-start-sip, ||koha-stop-sip and ||koha-enable-sip scripts. ||This patch removes them, ||while keeping backwards ||compatibility (i.e. you can ||still run them until you ||get used to the new ||syntax). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22238] Remove koha-*-sip scripts in favor of koha-sip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22238 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 84534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84534=edit Bug 22238: Remove koha-*-sip scripts in favor of koha-sip This patch removes traces from the (deprecated) koha-*-sip scripts. To test: - Apply the patch - Verify no traces of koha-*-sip remain on the codebase (besides Release Notes, koha-common.links and the koha-sip script): $ cd kohaclone $ git grep koha-start-sip $ git grep koha-stop-sip $ git grep koha-enable-sip => SUCCESS: No traces! - Create the following symlinks: $ sudo ln -s /usr/sbin/koha-sip /usr/sbin/koha-start-sip $ sudo ln -s /usr/sbin/koha-sip /usr/sbin/koha-stop-sip $ sudo ln -s /usr/sbin/koha-sip /usr/sbin/koha-enable-sip - Try the koha-*-zebra commands: $ sudo koha-stop-sip kohadev $ sudo koha-start-sip kohadev $ sudo koha-restart-sip kohadev => SUCCESS: They all work as expected! - Sign off :-D! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22238] Remove koha-*-sip scripts in favor of koha-sip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22238 Tomás Cohen Arazi changed: What|Removed |Added Target Milestone|--- |19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22238] Remove koha-*-sip scripts in favor of koha-sip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22238 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22235] Make maintenance scripts use koha-sip instead of koha-*-sip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22235 Tomás Cohen Arazi changed: What|Removed |Added Blocks||22238 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22238 [Bug 22238] Remove koha-*-sip scripts in favor of koha-sip -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22238] Remove koha-*-sip scripts in favor of koha-sip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22238 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Depends on||22235 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22235 [Bug 22235] Make maintenance scripts use koha-sip instead of koha-*-sip -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22238] New: Remove koha-*-sip scripts in favor of koha-sip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22238 Bug ID: 22238 Summary: Remove koha-*-sip scripts in favor of koha-sip Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz Target Milestone: --- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22235] Make maintenance scripts use koha-sip instead of koha-*-sip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22235 --- Comment #4 from Tomás Cohen Arazi --- (In reply to Kyle M Hall from comment #3) > Getting this error at step 1: > > root@48864c0cb6e1:kohadevbox$ perl misc4dev/cp_debian_files.pl > Cannnot open file No such file or directory at misc4dev/cp_debian_files.pl > line 35. The instructions were for kohadevbox, that's why they don't work :-/ In koha-testing-docker you need to run like this: root@b2cf8a1790c7:kohadevbox$ cd misc4dev root@b2cf8a1790c7:misc4dev(master)$ perl cp_debian_files.pl --koha_dir /kohadevbox/koha --instance kohadev --gitify_dir /kohadevbox/gitify Thanks for your interest! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |jonathan.dru...@bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::reconcile_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 --- Comment #35 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #34) > We had a question on the mailing list and another in a bug report about this > one for 18.05. Not sure how hard backporting would bea (lots of missing > dependencies)? I don't think it is that bad, and we could have a 18.05 version of this if required. It was the RMaint call not to backport it. Maybe the new RMaints change their mindS? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22234] User Login Problem.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22234 --- Comment #2 from Katrin Fischer --- Also note: In this version the database user login won't work for login. You will need to use the staff user's login you created through the web installer. Alternatively you can create a user using the command line script. See here for instructions: http://kohageek.blogspot.com/2018/07/create-super-librarian-by-command-line.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22234] User Login Problem.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22234 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Katrin Fischer --- Hi Tapu, this is more likely to be an installation/support question. Questions about Koha should be asked on the Koha mailing list (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC channel (http://koha-community.org/get-involved/irc/). Please make sure to include information about the version you installed, how you installed it and which instructions you followed. You can also find options for paid support here: https://koha-community.org/support/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::reconcile_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #34 from Katrin Fischer --- We had a question on the mailing list and another in a bug report about this one for 18.05. Not sure how hard backporting would bea (lots of missing dependencies)? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::reconcile_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Katrin Fischer changed: What|Removed |Added CC||mustaqeem...@gmail.com --- Comment #33 from Katrin Fischer --- *** Bug 22233 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22233] Fines forgiven
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22233 Katrin Fischer changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi mustqueem, credits won't be "used up" in this version of Koha. Please see the discussion on the mailing list https://lists.katipo.co.nz/pipermail/koha/2019-January/052148.html and bug 21896 (I am marking this one as duplicate). *** This bug has been marked as a duplicate of bug 21896 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22232] Advanced Cataloguing Editor (Rancor) to edit authority records?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22232 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Carlos, not a lot of people read the bug email - maybe ask the mailing list in parallel. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20208] Development - Peddie School - Custom file upload paths
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20208 --- Comment #5 from Katrin Fischer --- Hi Kyle/Devinim, can you please make the bug title more general? (Think release notes :) ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19585] Inventory: Allow additional separators in a barcode file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585 --- Comment #14 from Katrin Fischer --- But we should move this to a new bug as this has already been pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22011] Typo in Item Batch Modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22011 --- Comment #9 from Katrin Fischer --- (In reply to Fridolin SOMERS from comment #8) > I prefer not to push to 17.11.x to minimize translation work Not even fixing a typo? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21866] Rephrase "Warning: This *report* was written for an older version of Koha" to refer to plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21866 Katrin Fischer changed: What|Removed |Added Summary|Rephraase "Warning: This|Rephrase "Warning: This |*report* was written for an |*report* was written for an |older version of Koha" to |older version of Koha" to |refer to plugins|refer to plugins -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21866] Rephraase "Warning: This *report* was written for an older version of Koha" to refer to plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21866 Katrin Fischer changed: What|Removed |Added Summary|Warning: This *report* was |Rephraase "Warning: This |written for an older|*report* was written for an |version of Koha. Run at |older version of Koha" to |your own risk. |refer to plugins CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19585] Inventory: Allow additional separators in a barcode file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585 --- Comment #13 from Katrin Fischer --- I agree, especially since hyphen and other characters are not as unlikey as one might think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22237] Subscriptions are not linked to Mana upon edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22237] Subscriptions are not linked to Mana upon edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 --- Comment #1 from Owen Leonard --- Created attachment 84533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84533=edit Bug 22237: Subscriptions are not linked to Mana upon edit This patch modifies C4/Serials.pm so that during the process of editing a subscription a link to Mana can be created. To test, apply the patch and go to Serials. - Locate a subscription which was not created using Mana data but which can be found in Mana. - Edit the subscription, skipping to the second page. - View the results returned by Mana and select one. - Save the subscription. - Upon being redirected to the subscription detail page you should see a "Report mistake" button. This shows that the subscription has been linked to Mana successfully. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22237] New: Subscriptions are not linked to Mana upon edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 Bug ID: 22237 Summary: Subscriptions are not linked to Mana upon edit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Web services Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Depends on: 17047 Target Milestone: --- When a new subscription is created using data from Mana, a mana_id value is added to the subscription table. In Serials.pm ModSubscription was not modified to include mana_id, so subscription edits do not correctly link to Mana. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 [Bug 17047] Mana Knowledge Base : share data -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Owen Leonard changed: What|Removed |Added Blocks||22237 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 [Bug 22237] Subscriptions are not linked to Mana upon edit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22204] Leading spaces in barcode should not allowed in cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22204 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22236] Translation should generate tags with consistent attribute order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22236 Marcel de Rooy changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22236] Translation should generate tags with consistent attribute order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22236 --- Comment #1 from Marcel de Rooy --- Created attachment 84532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84532=edit Bug 22236: Translation should generate tags with consistent attribute order When running misc/translator/translate, the order of attributes in the translated templates is not consistent and may vary. This is caused by the random order of hash keys in perl. This causes things like this in run 1: And this in run 2: As you can see, there is actually no difference apart from the order. When comparing the result of various translation runs, I would rather get rid of such noise and only see the real changes. The needed change is not trivial to find, but only requires a simple addition to a sort operation in tmpl_process3.pl. The current sort only makes sure that the '/' comes at the end. We should sort the names of the keys too when this value is 0 (just meaning: no end tag symbol). Test plan: [1] Run a translation without this patch and set a few templates aside. [2] Run a translation with this patch. [3] Run a compare (diff) on the templates copied in step 1. Verify that the only changes are found in the sort order of attributes in html tags. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22236] Translation should generate tags with consistent attribute order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22236 Marcel de Rooy changed: What|Removed |Added Assignee|oleon...@myacpl.org |m.de.r...@rijksmuseum.nl Patch complexity|--- |Small patch Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22236] New: Translation should generate tags with consistent attribute order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22236 Bug ID: 22236 Summary: Translation should generate tags with consistent attribute order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org Target Milestone: --- When running misc/translator/translate, the order of attributes in the translated templates is not consistent and may vary. This is caused by the random order of hash keys in perl. This causes things like this in run 1: And this in run 2: As you can see, there is actually no difference apart from the order. When comparing the result of various translation runs, I would rather get rid of such noise and only see the real changes. The needed change is not trivial to find, but only requires a simple addition to a sort operation in tmpl_process3.pl. The current sort only makes sure that the '/' comes at the end. We should sort the names of the keys too when this value is 0 (just meaning: no end tag symbol). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20635] Write authentication tests with Test::Mojo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20635 --- Comment #2 from Josef Moravec --- Just tried, but without any success, not sure what's wrong here: 1..2 # Subtest: intranet 1..10 Reference is already weak at /usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68. Reference is already weak at /usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68. Reference is already weak at /usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68. Reference is already weak at /usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68. Reference is already weak at /usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68. Reference is already weak at /usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68. Reference is already weak at /usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68. Reference is already weak at /usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68. Reference is already weak at /usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68. Reference is already weak at /usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68. Reference is already weak at /usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68. Reference is already weak at /usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68. Reference is already weak at /usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68. Reference is already weak at /usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68. Reference is already weak at /usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68. Reference is already weak at /usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68. Reference is already weak at /usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68. A context appears to have been destroyed without first calling release(). Based on $@ it does not look like an exception was thrown (this is not always a reliable test) This is a problem because the global error variables ($!, $@, and $?) will not be restored. In addition some release callbacks will not work properly from inside a DESTROY method. Here are the context creation details, just in case a tool forgot to call release(): File: t/integration/auth/password.t Line: 58 Tool: Test::More::subtest Cleaning up the CONTEXT stack... # Test ended with extra hubs on the stack! # No tests run! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20630] An attempt at multitenancy with Mojolicious
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20630
--- Comment #6 from Josef Moravec ---
Comment on attachment 74671
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74671
Bug 20630: An attempt at multitenancy with Mojolicious
Review of attachment 74671:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=20630=74671)
-
::: Koha/App/Koha.pm
@@ +73,5 @@
> +my $caches = $Koha::Caches::singleton_caches;
> +if ($caches) {
> +foreach my $key (keys %$caches) {
> +my $cache = $caches->{$key};
> +if (ref $cache->{cache} eq 'Cache::Memory') {
This should not be needed, as of Cache::Memory was removed by bug 21955
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20630] An attempt at multitenancy with Mojolicious
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20630
--- Comment #6 from Josef Moravec ---
Comment on attachment 74671
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74671
Bug 20630: An attempt at multitenancy with Mojolicious
Review of attachment 74671:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=20630=74671)
-
::: Koha/App/Koha.pm
@@ +73,5 @@
> +my $caches = $Koha::Caches::singleton_caches;
> +if ($caches) {
> +foreach my $key (keys %$caches) {
> +my $cache = $caches->{$key};
> +if (ref $cache->{cache} eq 'Cache::Memory') {
This should not be needed, as of Cache::Memory was removed by bug 21955
--- Comment #7 from Josef Moravec ---
Comment on attachment 74671
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74671
Bug 20630: An attempt at multitenancy with Mojolicious
Review of attachment 74671:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=20630=74671)
-
::: Koha/App/Koha.pm
@@ +73,5 @@
> +my $caches = $Koha::Caches::singleton_caches;
> +if ($caches) {
> +foreach my $key (keys %$caches) {
> +my $cache = $caches->{$key};
> +if (ref $cache->{cache} eq 'Cache::Memory') {
This should not be needed, as of Cache::Memory was removed by bug 21955
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 Josef Moravec changed: What|Removed |Added CC||mi...@abunchofthings.net --- Comment #42 from Josef Moravec --- Signed off as it works as advertised and it would be great to see it moving ;) Just one note: we need to add Mojolicious::Plugin::TemplateToolkit to dependencies and make a debian package (adding Mirko to CC) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 --- Comment #41 from Josef Moravec --- Created attachment 84531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84531=edit Bug 20582: Handle multipart content-type Mojo::Message::Request's body attribute does not contain anything when the content-type is multipart/* We have to rebuild the multipart body for CGI scripts Test plan: 1. Go to Tools » Upload and try to upload a file Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 --- Comment #38 from Josef Moravec --- Created attachment 84528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84528=edit Bug 20582: Enable SetEnv middleware in bin/koha.psgi and make sure the psgi env is passed to CGI scripts Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 --- Comment #40 from Josef Moravec --- Created attachment 84530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84530=edit Bug 20582: Fix memory cache flush Cache flush should be in around_action hook instead of before_dispatch Otherwise it is flushed before every request (even static files requests) Also, make sure the Cache::Memory cache is really flushed (not only L1 cache) Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 --- Comment #37 from Josef Moravec --- Created attachment 84527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84527=edit Bug 20582: Add routes for some svc/ scripts svc/club/enroll, svc/club/cancel_enrollment and svc/report are available in different versions: one for the OPAC, one for the intranet This patch creates new routes that override the CGI scripts and that work for both OPAC and intranet Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 --- Comment #39 from Josef Moravec --- Created attachment 84529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84529=edit Bug 20582: Flush memory caches before every request Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 Josef Moravec changed: What|Removed |Added Attachment #74517|0 |1 is obsolete|| Attachment #74518|0 |1 is obsolete|| Attachment #74519|0 |1 is obsolete|| Attachment #74520|0 |1 is obsolete|| Attachment #79648|0 |1 is obsolete|| Attachment #82423|0 |1 is obsolete|| --- Comment #36 from Josef Moravec --- Created attachment 84526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84526=edit Bug 20582: Turn Koha into a Mojolicious application This patch is a proof-of-concept of Koha as a Mojolicious application This has several benefits: - Run `morbo bin/koha` and you're set : fully functional Koha without apache2/nginx (URL rewrites and static files are handled by the app) - apache2/nginx configuration is much simpler (an example of nginx configuration is included in the patch) - starman and plack middlewares can still be used for debug or gzip compression for instance (see bin/koha.psgi) - All that is needed to run koha is in the source code and not hidden in an obscure directory (I'm looking at you, debian/templates/plack.psgi) - Using Test::Mojo we can test the whole application, as we do with the REST API (which is a Mojolicious application too) - It's another step in the direction of dropping CGI support - It also opens a way for converting CGI scripts into Mojolicious controllers and actions (even if that's not possible at the moment because of the authentication code) - It requires zero changes to existing files, so it should apply nicely forever (no rebase needed \o/) A few downsides too: - It is not complete : some things from debian/templates/plack.psgi are missing, like the L1 cache flush or Koha::Middleware::SetEnv. But that shouldn't be too hard to add. - Already mentioned above, but the actual state of get_template_and_user and checkauth completely forbids the use of Mojolicious controllers. We really need to rewrite C4::Auth - Not sure if it's a downside or not, but as OPAC and Intranet are on the same host:port, if you authenticate on OPAC you will be authenticated on Intranet too. This can probably be changed if it's really a problem. - ... see FIXME in the code Other remarks: - It uses the same mechanism as Plack::App::CGIBin to deal with CGI scripts, so it should be equivalent in terms of performance How to test ? - Run `morbo bin/koha`, then go to: - http://localhost:3000/ - Redirects to OPAC main page - Then navigate in the OPAC, searching for bugs - http://localhost:3000/intranet - Redirects to intranet main page - Then navigate in the Intranet, still searching for bugs - http://localhost:3000/api/v1/... - The REST API - Test the web installer - Read the code (and the comments), it's not very long Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20208] Development - Peddie School - Custom file upload paths
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20208 Devinim changed: What|Removed |Added Assignee|je...@bywatersolutions.com |kohadevi...@devinim.com.tr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22235] Make maintenance scripts use koha-sip instead of koha-*-sip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22235 --- Comment #3 from Kyle M Hall --- Getting this error at step 1: root@48864c0cb6e1:kohadevbox$ perl misc4dev/cp_debian_files.pl Cannnot open file No such file or directory at misc4dev/cp_debian_files.pl line 35. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20208] Development - Peddie School - Custom file upload paths
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20208 --- Comment #4 from Devinim --- Created attachment 84525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84525=edit Bug 20208: Development - Peddie School - Custom file upload paths Test plan: 1) Upload two files with and without checksum 2) UPLOAD add new options to authorized values 3) Upload two files with and without checksum by selecting from the pulldown category options 4) UPLOAD_PATH add new options to authorized values 5) Try uploads by selecting from the pulldown upload path options and other options 6) Check the files in the /var/lib/koha/kohadev/uploads -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20208] Development - Peddie School - Custom file upload paths
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20208 Devinim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 Andrew Isherwood changed: What|Removed |Added Change sponsored?|--- |Sponsored Assignee|koha-b...@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com Status|NEW |ASSIGNED CC||andrew.isherwood@ptfs-europ ||e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
