[Koha-bugs] [Bug 22293] Sticky toolbar making vendor form uneditable

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22293

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||21751
 CC||katrin.fisc...@bsz-bw.de,
   ||oleon...@myacpl.org

--- Comment #1 from Katrin Fischer  ---
Confirmed :(


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751
[Bug 21751] fixFloat toolbar not displaying properly in Chrome
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||22293


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22293
[Bug 22293] Sticky toolbar making vendor form uneditable
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

AspenCat Team  changed:

   What|Removed |Added

 CC||aspencatt...@clicweb.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22018] Add an option to 'AllowEarlyRenewal' to enable users to renew before the autorenew date

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22018

AspenCat Team  changed:

   What|Removed |Added

 CC||aspencatt...@clicweb.org

--- Comment #2 from AspenCat Team  ---
This would also allow staff to renew as even staff cannot override the
autorenew to renew early

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz

--- Comment #54 from Aleisha Amohia  ---
This toolbar breaks /cgi-bin/koha/acqui/supplier.pl - I can't click anywhere on
the form. I've made Bug 22293 for fixing this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22293] New: Sticky toolbar making vendor form uneditable

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22293

Bug ID: 22293
   Summary: Sticky toolbar making vendor form uneditable
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alei...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

The HC-sticky toolbar from Bug 21751 does not work on
/cgi-bin/koha/acqui/supplier.pl

When I go to add a new vendor or edit an existing one, I can't click anywhere
on the form.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22293] Sticky toolbar making vendor form uneditable

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22293

Aleisha Amohia  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21751

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

Aleisha Amohia  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22293

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22289] Sitemap.pl needs maintenance due to C4::Biblio moved Koha::Biblio

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22289

Arthur Suzuki  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from Arthur Suzuki  ---
Not a bug, C4::Biblio and Koha::Biblio are two different things.
Error were due to a permission issue (sry for that...).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21538] Show ilbrary on account page

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21538

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19174] No Credits Please

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19174

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #55 from Lucas Gass  ---
cant cleanly apply this patch set. if needed in 18.05.x please rebase. thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22132] Add Basic authentication to the REST API

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #29 from Lucas Gass  ---
pushed to 18.05.x for 18.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22291] 'Batch modify' button on itemnumber causes internal server error if itemnumbers do not correspond to real items.

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22291

Margaret  changed:

   What|Removed |Added

 CC||margaret@bywatersolutions.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266

Aleisha Amohia  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
 CC||alei...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266

--- Comment #3 from Aleisha Amohia  ---
Created attachment 84860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84860=edit
Bug 21266: (follow-up) Removing duplicate lines and moving code around

Removing duplicates lines from sco-main.tt that are already in
doc-head-close.inc.

Also moving JS code into the jsinclude block and moving CSS code into
the cssinclude block.

Same fixes applied to sco/help.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367

--- Comment #20 from Aleisha Amohia  ---
Created attachment 84859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84859=edit
Bug 14367: (follow-up) Rebasing to make patch work on master

Run through test plan and confirm everything still works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367

Aleisha Amohia  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22292] Search result items are not displayed properly

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22292

--- Comment #5 from chrs.mark...@gmail.com ---
(In reply to Owen Leonard from comment #4)
> The good news is you have working search results. The bad news is that
> something might be wrong with the .xsl files on your system. "default"
> should work correctly. If it's not, something else is wrong.

I 've never used .xsl files so I cannot give you more insight. Of course
something might went wrong during the fresh installation. 

For now, I'm ok with this!

Thank you again!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22292] Search result items are not displayed properly

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22292

--- Comment #4 from Owen Leonard  ---
The good news is you have working search results. The bad news is that
something might be wrong with the .xsl files on your system. "default" should
work correctly. If it's not, something else is wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22292] Search result items are not displayed properly

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22292

--- Comment #3 from chrs.mark...@gmail.com ---
(In reply to Owen Leonard from comment #2)
> Have you enabled some custom XSLT on your system? I see this kind of problem
> when XSLT is broken or not working.

Owen that was the problem! 

OPACXSLTDetailsDisplay, OPACXSLTListsDisplay and OPACXSLTResultsDisplay were
set by default to "default", so removing this and leaving them empty the
problem was fixed.

Thank you so much for your quick answer!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22278] Newly created report group is not selected after saving an SQL report

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22278

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #84855|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 84858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84858=edit
Bug 22278: Clear cache when creating new report groups or subgroups

When a user adds a new group we create it, then fetch the groups from the
cache. However, we aren't clearing the cache on creation. This patch fixes that

To test:
 0) Start a new report
 1) Pick create for the group
 2) Enter code and value
 3) Save
 4) You remain on the page and value and code are now empty (ok)
 5) BUT: The pull down for the group remains "None" instead of reflecting
the new group
 6) Open a new tab and browse to reports - note the group exists and the report
is in it
 7) On original tab save report again, the group was not selected so is lost
 8) Apply patch
 9) Retest with a new report
10) Group is created, saved, and selected upon save
11) Subsequent edits include the new group
12) Test with subgroups as well

Signed-off-by: Liz Rea 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22278] Newly created report group is not selected after saving an SQL report

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22278

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22278] Newly created report group is not selected after saving an SQL report

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22278

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22292] Search result items are not displayed properly

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22292

--- Comment #2 from Owen Leonard  ---
Have you enabled some custom XSLT on your system? I see this kind of problem
when XSLT is broken or not working.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22292] Search result items are not displayed properly

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22292

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi, are you using UNIMARC? Which version are you using?

You might be seeing bug 22058 which will be fixed in 18.11.03.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22292] New: Search result items are not displayed properly

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22292

Bug ID: 22292
   Summary: Search result items are not displayed properly
 Change sponsored?: ---
   Product: Koha
   Version: 18.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: chrs.mark...@gmail.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

Created attachment 84857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84857=edit
Search Result List

Hello,

I'm facing an issue while trying to search for a book tittle with a pattern.

The result list that is displayed does not contain any usefull information
about the books-items. I have to add them to the "cart" and then use the cart
pop-up in order to see their info.

This is quite blocking, since users cannot easily search within the catalog
with a normal user experience.

Is this a bug, or something is missing from my settings. Note that in previous
versions of Koha we didn't have this issue.

I'm attaching a screenshot of waht I'm seeing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22261] Revise style of DataTables menus

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22261

Liz Rea  changed:

   What|Removed |Added

  Attachment #84750|0   |1
is obsolete||

--- Comment #2 from Liz Rea  ---
Created attachment 84856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84856=edit
Bug 22261: Revise style of DataTables menus

This patch revises our custom DataTables CSS to give a more colorful
style to the columns configuration and export menus. The primary goal of
this change is to make it easier to tell which columns are visible and
which are hidden.

To test, apply the patch and clear your browser cache if necessary.

View a table with columns configuration and export options, e.e. Tools
-> Notices & slip. Test the DataTables menus and confirm that they work
as expected.

Signed-off-by: Liz Rea 
This is a nice update to the styles.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22278] Newly created report group is not selected after saving an SQL report

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22278

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22278] Newly created report group is not selected after saving an SQL report

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22278

Liz Rea  changed:

   What|Removed |Added

  Attachment #84813|0   |1
is obsolete||

--- Comment #4 from Liz Rea  ---
Created attachment 84855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84855=edit
Bug 22278: Clear cache when creating new report groups or subgroups

When a user adds a new group we create it, then fetch the groups from the
cache. However, we aren't clearing the cache on creation. This patch fixes that

To test:
 0) Start a new report
 1) Pick create for the group
 2) Enter code and value
 3) Save
 4) You remain on the page and value and code are now empty (ok)
 5) BUT: The pull down for the group remains "None" instead of reflecting
the new group
 6) Open a new tab and browse to reports - note the group exists and the report
is in it
 7) On original tab save report again, the group was not selected so is lost
 8) Apply patch
 9) Retest with a new report
10) Group is created, saved, and selected upon save
11) Subsequent edits include the new group
12) Test with subgroups as well

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22282] Internal software error when exporting basket group as PDF

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22282

Liz Rea  changed:

   What|Removed |Added

  Attachment #84829|0   |1
is obsolete||

--- Comment #3 from Liz Rea  ---
Created attachment 84854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84854=edit
Bug 22282 - Fix PDF issue when exporting PDF in French format.

Fixing up QA comments, keeping 1st instance and removing the 2nd.
Original test plan by Christophe Croullebois.

To test :
Without the patch :

1° select in Acquisitions preferences/OrderPdfFormat French 3-page
2° restart plack if needed
3° In acqui/basketgroup.pl select closed tab
4° Click on "Export as PDF" button
5° You should see a blank page saying "Internal Server Error"

With the patch :

Do the same

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18618] Mana - Add reading suggestions (crontab and scripts for Koha)

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618

Arthur Suzuki  changed:

   What|Removed |Added

 CC||arthur.suz...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5739] Check out waiting holds directly from "hold waiting" alerts on circulation screen

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5739

Liz Rea  changed:

   What|Removed |Added

   Assignee|wizzy...@gmail.com  |koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22291] 'Batch modify' button on itemnumber causes internal server error if itemnumbers do not correspond to real items.

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22291

--- Comment #1 from Barton Chittenden  ---
Note that even though the query that I used to illustrate this problem won't
ever occur in production, this was triggered by a real report, that looked
something like this:

SELECT
aqbasket.basketname,
aqbasket.closedate,
aqorders.biblionumber,
aqorders_items.itemnumber,
items.itemnumber AS 'items.itemnumber',
biblio.title,
items.barcode 
FROM
aqbasket
LEFT JOIN aqorders USING (basketno)
LEFT JOIN aqorders_items on (aqorders.ordernumber =
aqorders_items.ordernumber)
LEFT JOIN biblio on (aqorders.biblionumber = biblio.biblionumber)
LEFT JOIN items on (aqorders_items.itemnumber = items.itemnumber)
WHERE
aqbasket.basketname='XX'
GROUP BY
aqorders_items.itemnumber

The 'Batch Modify' button was attached to the 'aqorders_items.itemnumber'
column, and there were instances where that was populated, even when
'items.itemnumber' was NULL.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11601] Bootstrap theme has CSS files that do not have LESS counterparts

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com
 Status|ASSIGNED|RESOLVED
 Resolution|--- |WONTFIX

--- Comment #13 from Liz Rea  ---
I think this one is long fixed now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11411] Bootstrap theme (enhancement) for (right to left).

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411
Bug 11411 depends on bug 11601, which changed state.

Bug 11601 Summary: Bootstrap theme has CSS files that do not have LESS 
counterparts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11896] add tools for compiling LESS files

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11896
Bug 11896 depends on bug 11601, which changed state.

Bug 11601 Summary: Bootstrap theme has CSS files that do not have LESS 
counterparts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22291] New: 'Batch modify' button on itemnumber causes internal server error if itemnumbers do not correspond to real items.

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22291

Bug ID: 22291
   Summary: 'Batch modify' button on itemnumber causes internal
server error if itemnumbers do not correspond to real
items.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

To re-create:

Create a new report from SQL using the following query:

select
title,
itemnumber + 1 as itemnumber
from biblio inner join items using (biblionumber)
order by itemnumber desc
LIMIT 1

The value in the itemnumber column will *not* correspond to any item in the
items table.

Run the report and click the 'Batch modify' button.

This causes an internal server error with the following error message:

Can't call method "title" on an undefined value at
/usr/share/koha/intranet/cgi-bin/tools/batchMod.pl line 583.

The problem is that 'my $biblio = Koha::Biblios->find(
$itemdata->{biblionumber}' at line 577 *can't* be guaranteed to return a valid
biblio record, so we *must* check whether it's defined before we access its
members.

  575 # grab title, author, and ISBN to identify bib that the item
  576 # belongs to in the display  
  577 my $biblio = Koha::Biblios->find( $itemdata->{biblionumber}
);
>>578 $this_row{title}= $biblio->title;
  579 $this_row{author}   = $biblio->author;
  580 $this_row{isbn} = $biblio->biblioitem->isbn;
  581 $this_row{biblionumber} = $biblio->biblionumber;

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22291] 'Batch modify' button on itemnumber causes internal server error if itemnumbers do not correspond to real items.

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22291

Barton Chittenden  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16333] Google Calendar integration don't work

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16333

Liz Rea  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||wizzy...@gmail.com
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16347] many news articles are tagged excessively or not tagged at all

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16347

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com
 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Liz Rea  ---
I've had a chat with the people who do these, I hope they are  putting a little
more thought into how they categorise things.

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21212] Syndetics image size should be configurable

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21212

--- Comment #1 from Cab Vinton  ---
Just to clarify, I believe this is to provide a configuration option for cover
images on the staff side. The OPAC already has a couple of related system
preferences (SyndeticsCoverImages & SyndeticsCoverImageSize).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16349] Indicate what branches of Koha are supported

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16349

Liz Rea  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff
 CC||wizzy...@gmail.com

--- Comment #3 from Liz Rea  ---
Hi Mirko,

I think this information is kept here:
https://koha-community.org/about/release-schedule/ and also there are some
words about it here (first paragraph):
https://koha-community.org/download-koha/

Surely on that first noted page, it could be more explicitly stated that two to
three stable versions are supported with bug fixes, I've added some words to
that effect.

Needs signoff only because I'd like you to look at what I've done before
marking it finished - this bug doesn't need the full QA treatment as it is for
the website.

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22282] Internal software error when exporting basket group as PDF

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22282

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #2 from Fridolin SOMERS  ---
Package is usually the first line of file.
You should keep it and remove second line.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21738] [ILS-DI] Error placing a hold on a title without item

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738

--- Comment #17 from Alex Arnaud  ---
Set it back to Passed QA. An other QAer for checking unit tests ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21738] [ILS-DI] Error placing a hold on a title without item

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738

Alex Arnaud  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21738] [ILS-DI] Error placing a hold on a title without item

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738

--- Comment #16 from Alex Arnaud  ---
Created attachment 84853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84853=edit
Bug 21738: unit tests for HoldTitle

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

--- Comment #96 from Kyle M Hall  ---
Created attachment 84852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84852=edit
Bug 7534: (QA Follow-up) Fix the return value for the new format, it should be
a hashref, not a string

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3534] Patron quick add form

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #84851|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3534] Patron quick add form

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #66 from Kyle M Hall  ---
Created attachment 84851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84851=edit
Bug 3534: (QA Follow-up) Fix the return value for the new format, it should be
a hashref, not a string

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6685] circ rules by groups of items

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6685

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #14 from Caroline Cyr La Rose  ---
I've also had a request for this.

My case is pretty much the same as what the others said. This particular
library has several itemtypes that need to be limited as a group, but the rest
of the parameters change. 

For example, they have adult DVD fiction, adult DVD non-fiction, children's DVD
fiction and children's DVD non-fiction. Users can borrow 5 DVDs total. Fiction
DVDs go out for 3 days and non-fiction DVDs go out for 21 days. Adult can
borrow both adult and children's DVDs whereas children can only borrow
children's DVDs.

Right now, there is no easy way to enter these rules and limit the loans
correctly. Either I group fiction DVDs together and non-fiction DVDs together,
but then I have to have another subterfuge for limiting children from borrowing
adult DVDs plus there is no way of limiting the total number of loans to 5. Or
I group children's DVDs together and adult DVDs together, but then I have no
way of varying the loan period and no way to limit to 5 total loaned DVDs.

Anyway, it's a brain wrangling puzzle, no matter how you look at it.

Chris' idea of using itemtypecat is good. The other idea I had was to use
something similar to Default checkout limit by patron category, but for
itemtype categories.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Andrew Isherwood  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #28 from Andrew Isherwood  ---
(In reply to Katrin Fischer from comment #24)

> 4) I'd also have expected the renewal to be locked initially and the
> checkbox to unlock it. Reasoning: Renewing an item with a hold should always
> be an exception. The way it's now a "renew all" checked on top will also
> check the "on hold" ones which might be easily missed. We could relabel the
> checkbox and use it for both: Allow override of renewal restrictions?

Hi Katrin

I've just attached a patch that addresses this. The on hold items now behave in
the same way as items that have reached their renewal limit, they are not
selectable until the checkbox is checked. Speaking of which, I've re-labelled
the checkbox from "Override renewal limit" to "Override renewal restrictions"
as per you suggestion. So now, "Select all" and "Renew all" will not act upon
the on hold items unless the override is checked.

I'm not familiar with the process when a UI label is changed, is there any
maintenance work that needs to happen so translations don't break?

>3) I don't understand the new entry form for the hold due date. My feeling is 
>that we should use the one existing already for entering the new due date for 
>any override. Having 2 forms seems confusing.

We discussed this internally at great length when speccing out the development.
It was felt by both our customers and us that having two date selection boxes
made most sense since it's conceivable that the user may wish to have different
due dates for on hold items and non-on hold items. The fact that the "On hold
due date" date input doesn't appear until an on hold item is checked for
renewal (if you're not seeing this behaviour, rebuild your CSS) reinforces it's
purpose.

I'm going to set this back to Signed off as I believe it's ready for another QA
run :) Thanks for your feedback!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #27 from Andrew Isherwood  ---
Created attachment 84850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84850=edit
Bug 7088: (follow-up) Default hold checkbox display

As per item 4 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24

Now, the checkbox for renewing on hold items behaves the same way as the
checkbox for renewing items that have reached their renew limit. It is
necessary to check the re-labelled "Override renewal restrictions"
checkbox before it is possible to select on-hold items for renewal.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16840] URLs for old releases are broken with every new release

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16840

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com
   Assignee|wizzy...@gmail.com  |ch...@bigballofwax.co.nz
 Status|NEW |ASSIGNED

--- Comment #2 from Liz Rea  ---
I think Chris manages this part of the website, and the release tools likely do
the shuffling.

The tech for this isn't very, and has never been, sophisticated. Thank you for
introducing a new use case that is a reasonable reason to update the
functionality.

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17723] Using MySQL on external server - lack of documentation giving example

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17723

Liz Rea  changed:

   What|Removed |Added

 QA Contact||testo...@bugs.koha-communit
   ||y.org
Product|Project Infrastructure  |Koha
 CC||wizzy...@gmail.com
  Component|Project website |Installation and upgrade
   ||(command-line installer)
   Assignee|wizzy...@gmail.com  |koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22177] Update years for meetings.koha-community.org

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22177

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com
 Status|NEW |In Discussion

--- Comment #1 from Liz Rea  ---
I have made inquiries as to who can fix this page up, thanks for reporting it!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22290] New: Next pages results for cyrillic symbols shows decoded text in URL in anchor tag

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22290

Bug ID: 22290
   Summary: Next pages results for cyrillic symbols shows decoded
text in URL in anchor tag
 Change sponsored?: ---
   Product: Koha
   Version: 18.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: b.paster...@gmail.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

Created attachment 84849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84849=edit
Search encoding

This bug is reproduced on OPAC, intranet works fine.
Whenether i enter cyrillic symbols in search, first page results are fine, but
the generated HTML page has wrong value in pagination.

Something like this is inside each li>a href element in pagination
/cgi-bin/koha/opac-search.pl?idx=kw=%25D1%2588%25D0%25B5%25D0%25B2%25D1%2587%25D0%25B5%25D0%25BD%25D0%25BA%25D0%25BE=20_by=relevance_dsc


If i click search on this link i am redirected to page that shows broken
characters as you can see in attachment.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #84498|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #84825|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #84826|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #84827|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #84824|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #84195|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #84203|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #84823|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #84497|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #84266|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #84194|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22214] New authority RDA indexes

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22214

Viliam  changed:

   What|Removed |Added

   Priority|P5 - low|P3

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #84193|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22289] New: Sitemap.pl needs maintenance due to C4::Biblio moved Koha::Biblio

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22289

Bug ID: 22289
   Summary: Sitemap.pl needs maintenance due to C4::Biblio moved
Koha::Biblio
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: arthur.suz...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz
  Target Milestone: ---

Due to C4::Biblio moved to Koha::Biblio this script doesn't work anymore.

Compilation failed in require at /home/vagrant/kohaclone/C4/Koha.pm line 26.
BEGIN failed--compilation aborted at /home/vagrant/kohaclone/C4/Koha.pm line
26.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22288] Barcode file does not work in modifying items in batch

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22288

--- Comment #2 from Federico Paiz  ---
Created attachment 84848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84848=edit
txt


it looks like this

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22288] Barcode file does not work in modifying items in batch

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22288

Katrin Fischer  changed:

   What|Removed |Added

Summary|does not work in modifying  |Barcode file does not work
   |items in batch  |in modifying items in batch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22288] does not work in modifying items in batch

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22288

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
What did your .txt file look like? Where there any empty lines or 0 in lines?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22288] New: does not work in modifying items in batch

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22288

Bug ID: 22288
   Summary: does not work in modifying items in batch
 Change sponsored?: ---
   Product: Koha
   Version: 18.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: federicoantoniop...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl
  Target Milestone: ---

Created attachment 84847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84847=edit
screen

in going through txt the inventory ( Home › Tools › Batch item modification ), 
it gives me as a result :  



Can't use string ("0") as an ARRAY ref while "strict refs" in use at
/usr/share/koha/intranet/cgi-bin/tools/batchMod.pl line 251, <$fh> line 69.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21263] Pickup library not set correctly when using Default holds policy by item type

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21263

Maryse Simard  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |maryse.sim...@inlibro.com
   |ity.org |
 CC||maryse.sim...@inlibro.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21263] Pickup library not set correctly when using Default holds policy by item type

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21263

--- Comment #1 from Maryse Simard  ---
Created attachment 84846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84846=edit
Bug 21263: Pickup library not set correctly when using Default holds policy

In the case of a specific item hold, it can only be fulfilled if the pickup
library
matches the hold fulfillment policy. Therefore, if OPACAllowUserToChooseBranch
is
set to don't allow, the pickup library should correspond to the policy.

In case of hold that does not specify an item, the homebranch or holdingbranch
can't be determined at this time, so the pickup library still defaults to the
homebranch of the borrower. Same if there is no policy or it states 'any'.

To test:
- Make sure OPACAllowUserToChooseBranch is set to don't allow
- Make sure you have two branches A and B
- Have one item whose homebranch is B
- Have one user whose homebranch is A
- Make sure the circulation rules allow the user to reserve the item's item
type

1. Go to Administration > Circulation and fines rules
2. Create a Default holds policy by item type for that item type
- Item type = item's item type
- Hold policy = From any library
- Hold pickup library match = item's home library
- Return policy = item returns home
3. Go to the OPAC and log in with the user's credentials
4. Search for the item
5. Click on "Place hold"
6. Select a specific item and confirm hold
7. In the user's file on the OPAC and check the reservation's pickup library.
It should be the item's homebranch

You can then repeat the steps for 'item's holding library' or 'any library' as
the Hold pickup library match. It should also work the same way if there is no
'Default holds policy by item type' for this item type but a 'Default checkout,
hold and return policy' set.

Finally, check that placing a hold without selecting a specific item still
defaults the pickup library to the borrower's homebranch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21263] Pickup library not set correctly when using Default holds policy by item type

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21263

Maryse Simard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21534] ElasticSearch - Dash is considered like a boolean operator

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21534

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22287] Correct new charts CSS

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22287

--- Comment #1 from Owen Leonard  ---
Created attachment 84845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84845=edit
Bug 22287: Correct new charts CSS

This patch reverts some changes to reports CSS from Bug 22168 which were
unnecessary and which adversely affected the report add/edit form
styling.

To test, apply the patch and clear your browser cache if necessary.

Go to Reports -> Saved reports and repeat the test plan for Bug 22168:

- Run a report which returns more than one column.
- On the report results page, click the "Create chart" button. The chart
  settings form should appear in a modal window.
- Click the "Draw" button. The modal should disappear and the chart
  should be shown.

Then test the process for adding or editing an SQL report. The form
should be styled in a way consistent with other forms in the staff
client.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22287] Correct new charts CSS

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22287

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22287] New: Correct new charts CSS

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22287

Bug ID: 22287
   Summary: Correct new charts CSS
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: minor
  Priority: P5 - low
 Component: Reports
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 22168
  Target Milestone: ---

Bug 22168 introduced a change to reports CSS which had an unintended effect on
the SQL reports edit form.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22168
[Bug 22168] Improve styling of new chart settings for reports
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22168] Improve styling of new chart settings for reports

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22168

Owen Leonard  changed:

   What|Removed |Added

 Blocks||22287


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22287
[Bug 22287] Correct new charts CSS
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18319] Elasticsearch Advanced search breadcrumbs broken

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18319

Nick Clemens  changed:

   What|Removed |Added

 CC||ere.maij...@helsinki.fi,
   ||nicolas.legr...@bulac.fr
   Severity|normal  |major

--- Comment #1 from Nick Clemens  ---
It seems the query_desc and query_cgi calculations are wrong in the
QueryBuilder

This also affects faceting on advanced searches and pagination

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22286] New: ILL, OpacHiddenItems and 404

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22286

Bug ID: 22286
   Summary: ILL, OpacHiddenItems and 404
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: ILL
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mag...@libriotech.no
  Target Milestone: ---

For some kinds of ILL you need to create records and items for materials the
library receives through ILL, so they ca be lent to patrons in the regular way.
Normally, you do not want these records to display or be searchable in the
OPAC, because they are not part of the collection of the library. My guess is
most libraries will solve this by creating an itemtype called something like
ILL, and use OpacHiddenItems to hide these records from browsing and searching
in the OPAC. 

When such an item is on loan to the patron it does show up in "my summary" in
the OPAC, but the link from the title leads to a 404, which is not ideal. 

A couple of different solutions come to mind:

1. Detect that the item on loan is hidden and don't display the link

2. Detect that the item on loan is hidden and display the record in some other
way than through a link to the regular OPAC detail view, for example in a
pop-up. 

Thoughts?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22280] The ILL module assumes every status needs a next/previous status

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280

Andrew Isherwood  changed:

   What|Removed |Added

 CC||andrew.isherwood@ptfs-europ
   ||e.com

--- Comment #1 from Andrew Isherwood  ---
Hi Magnuse

That's a very interesting point. It feels to me like an oversight, we should be
allowing for the case where an status is isolated and doesn't come from
anywhere or go anywhere.

Your solution seems like a reasonable way to address the problem.

My biggest concern at the moment would be where to place this bug fix in the
ILL dependency tree. Illrequest.pm is pretty heavily modified in many of the
bugs in the tree and, even though your proposed fixes are small, I'm not sure
if they'd conflict. In which case, I'd be inclined to make it dependent on
18589. We already have at least one bug fix that is dependent on that bug,
which is at the top of the current QA tree.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

Andrew Isherwood  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #169 from Andrew Isherwood  ---
(In reply to Katrin Fischer from comment #165)
> When I edit one of the ILL requests I set to "Internal processing" and
> change it back to "New request" it doesn't take on saving. I stays at the
> custom status and I can't change it.

This is now fixed. The hackery I had to introduce into Illrequest.pm requires a
special casing for when we want to nullify status_alias, I had forgotten to
introduce that here.

> If I confirm the request, setting "Requested" seems to work ok, But in the
> datbase I see -1 for alias_status.

See above

> Not sure if this is related to the patch, but noting just in case: I can't
> confirm the request either, but get an error instead. This is a BLDSS
> request - might just be related to that as my FreeForm one behaves nicely.

This is unrelated, it does actually appear that the BLDSS API is suddenly
returning an error for the confirm call :( I'll investigate...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293

Arthur Suzuki  changed:

   What|Removed |Added

 CC||arthur.suz...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11055] Add 'minutes' as a load period unit

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11055

Arthur Suzuki  changed:

   What|Removed |Added

 CC||arthur.suz...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

--- Comment #168 from Andrew Isherwood  ---
Created attachment 84844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84844=edit
Bug 20581: (follow-up) Passed value to status_alias

Now we have overloaded status_alias, we can no longer pass it undef (as
it uses that to determine if it's being used as a getter or setter). So
we now pass it -1 to indicate it should actually be setting undef (a
hack, I know, but what are you going to do...)

This patch makes sure ill-request.pl conforms to that. It also fixes the
testing of the passed parameter, which was wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22099] "List requests" button displays when listing requests

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

--- Comment #1 from Magnus Enger  ---
I find that button quite handy as a way to refresh the page. :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293

Koha Team Lyon 3  changed:

   What|Removed |Added

 CC||k...@univ-lyon3.fr
 Status|In Discussion   |Failed QA

--- Comment #5 from Koha Team Lyon 3  ---
The present path doesn't apply anymore :

t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t
CONFLICT (content): Merge conflict in
t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t
Auto-merging C4/Circulation.pm
CONFLICT (content): Merge conflict in C4/Circulation.pm
error: Failed to merge in the changes.

To give a feedback to Kyle'question :
> I suppose the question is, should hourly loans suspend in days the number of 
> hours overdue? If an hourly loan is 3 hours late, should the patron be 
> suspended for 3 days? If so, changes are needed.

In our library, we don't want hours late to be change in days suspension. 
If "Suspension in days (day)" = 1, we want that 2h or 2mn late calculate 1 day
of suspension.
If there more than 24h, then it will be 2 days of suspension.

I hope that this bug could be correct easily.

Sonia

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22285] New: OPAC shows too much info about ILL requests

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22285

Bug ID: 22285
   Summary: OPAC shows too much info about ILL requests
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: ILL
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mag...@libriotech.no
  Target Milestone: ---

When ILL is enabled, patrons get an extra "tab" in "my summary" in the OPAC,
called "your interlibrary loan requests". This page shows a table of basic info
about ILL requests for that patron, along with a button that says "View".
Clicking on this button shows a lot of information about a single request. 

The first part of the page has a heading of "Details from library" and contains
the same fields as the table on the previous page, along with a field for
notes. (It looks like this field can be edited both by the patron and by
librarians, which seems kind of odd, but that is better left for another bug.)

The second part is labeled "Details from ", and this is the
problematic bit. It is identical to the information displayed to librarians in
the backend, so it might contain notes that are not meant for the patron to
see. 

The data in this section comes from Koha::Illbackends::Libris::Base:metadata().
Could it be possible to give this sub a parameter so that it would "know" if it
is serving data for the OPAC or the intranet, and choose which data to display
based on that?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

--- Comment #167 from Andrew Isherwood  ---
Hi Katrin

Thanks very much for the info. A bit of context might be in order.

An ILL request has, at any given time, a single "status". The workflow the
request passes through is dictated by those statuses. The ILL module has the
idea of a "status graph", which essentially says "if you're at this status, you
can have come from this/these status(es) and you can go to this/these
status(es)." This is how we can determine what actions the user can take on any
given request.

This bug adds the concept of status aliases, which are user defined as
authorised values. These have no bearing on any of the above, the request's
status is still used in the same way. The status alias is purely used for
display. The display logic says "if a request has a status alias, display that,
otherwise display the request's status". This enables the user to select one of
their user defined status aliases, which will be displayed in favour of the
request's "actual" status. This allows the user to assign a more locally
meaningful status to a request, rather than rely on those provided by ILL.

I mentioned above that the status alias has no bearing on the actual status.
The request's status is still there, and still determines, say, which action
buttons are displayed for a request, but it is not displayed if an alias is
also assigned to that request. However, if a request that has a status alias is
moved forward through the workflow by clicking one of the action buttons (e.g.
Confirm request), we assume that the status alias is no longer applicable and
nullify it in the request, causing the request's actual status to now display,
until such a time as the user selects a new status alias.

So, to address what you're seeing above with -1 being assigned. In the "Edit
request" screen, the status dropdown contains all of the status aliases PLUS an
option for the request's actual status, which effectively allows the user to
nullify the request's status alias and revert the request to the actual status.
You said you selected "New request", which will have been the request's actual
status. But it sounds like, rather than nullifying the status alias, it set it
to -1. Which is odd.

I'll investigate and get back to you. Thanks again for your ongoing efforts on
getting this one through!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13342] not logged in user can place a review/comment as a deleted patron

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13342

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Severity|trivial |minor

--- Comment #1 from Katrin Fischer  ---
This problem caused us some headache as it happened quite often in one of the
libraries we support. I just confirmed that the problem still exists in 18.11
and therefore possibly master as well. 

Thx, Olli, for reporting!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3514] Returning items through patron Details tab doesn't activate all circulation functions

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3514

--- Comment #15 from Ray Delahunty  ---
Assisted by our support company we have been able to make improvements. We have
hidden the Return functionality on the Patron Detail screen using the
Administration > Configure columns feature. Under Circulation in the
id=issues-table, we ticked the Hide checkbox for "checkin", and under User in
the id=issues-table we ticked the Hide checkbox for "checkin". However I don’t
see a way of using this columns configuration functionality to hide the ability
to cancel a reservation on the Patron Detail page. I guess what I am looking
for is a id=holds table under Users (there is currently one under Circulation).
If there were that table with the Column name being Delete we could hide the
functionality that is causing the problem. (We are on 17.05 and I checked 18.05
and while there is an additional table / view under Users it doesn’t offer what
I need). Our support company has used css to hide the “actions” options
(including the Cancel marked holds and Suspend all holds), which works- it does
leave the Delete? column with the tickbox, but applying the actions is not
possible.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Hiding libraries outside group for holds

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Summary|hiding libraries outside|Hiding libraries outside
   |group for holds dev |group for holds

--- Comment #1 from Katrin Fischer  ---
I know you probably just wanted the bug number, but to avoid duplicates and
because I am curious... can we get a bit more description? :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22284] New: hiding libraries outside group for holds dev

2019-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

Bug ID: 22284
   Summary: hiding libraries outside group for holds dev
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: n...@bywatersolutions.com
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

hiding libraries outside group for holds dev

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >