[Koha-bugs] [Bug 19489] Detailed description of charges on Accounting tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
--- Comment #36 from Josef Moravec ---
Comment on attachment 85236
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85236
Bug 19489: (Rebased) Koha::Account::Line->issue method and Unit test
Review of attachment 85236:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19489&attachment=85236)
-
::: Koha/Account/Line.pm
@@ +55,5 @@
> }
>
> +=head3 issue
> +
> +Return the item linked to this account line if exists
item?
@@ +59,5 @@
> +Return the item linked to this account line if exists
> +
> +=cut
> +
> +sub issue {
According to Koha terminology, this should be named "checkout"
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 --- Comment #55 from Ere Maijala --- This should provide a nice performance improvement also for exports for indexing. MySQL is quick to prepare statements, that's why we can get away with it. Other databases may have different behavior, and there are certainly slower ones in that regard. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #36 from Ere Maijala --- I'm ok with disabling regexp altogether for the time being. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Detailed description of charges on Accounting tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Devinim changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #35 from Devinim --- Hi Katrin, As you suggested I changed the Signed Off. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22334] Missing modules on perldoc.k-c.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22334 --- Comment #2 from Josef Moravec --- (In reply to Galen Charlton from comment #1) > I've identified and fixed an issue with the automatic updating of the > perldoc and am rebuilding it now; it will take a few hours to finish. Great news, thanks Galen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 --- Comment #54 from David Cook --- Does this affect the export of biblios/items for Zebra indexing? I'm watching a rebuild_zebra.pl crawling along exporting the bib records, and thinking how surely it should be able to be faster than this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22324] Might be nice to list forks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22324 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- Sounds interesting. I always figured OPALS was a different system but http://help.opalsinfo.net/about/opals-source-code/ sure makes it sound like a Koha fork. The demo OPAC looks like something from the '90s but the OPAC is the smallest part of Koha anyway. They probably leverage the existing admin side... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3820] More detailed patron record changes log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22365] Warn on Log Viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22365 --- Comment #1 from Aleisha Amohia --- Created attachment 85262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85262&action=edit Bug 22365: Removing warn when accessing Log Viewer To test: Go to Tools -> Log Viewer and confirm the warn no longer shows after applying the patch. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22365] Warn on Log Viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22365 Aleisha Amohia changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22365] New: Warn on Log Viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22365 Bug ID: 22365 Summary: Warn on Log Viewer Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org Target Milestone: --- Just going to Tools -> Log viewer generates this warn: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_tools_viewlog_2epl line 96, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22365] Warn on Log Viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22365 Aleisha Amohia changed: What|Removed |Added Change sponsored?|--- |Sponsored Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 --- Comment #53 from David Cook --- (In reply to Ere Maijala from comment #52) > Caching during a batch operation would be useful, but it's harder to do > without messing the architecture. And there's still a chance that something > hickups during a batch process and automatic reconnection doesn't kick in > for the cached statement. In any case the performance benefit from caching > the statements, while measurable and significant, isn't dramatic. Yeah, it would certainly require messing with the existing architecture, and I can understand not doing that. If something did hiccup during a batch process and automatic reconnection didn't kick in, then we'd trap and report the error, which doesn't seem like the end of the world to me. But no worries. That's interesting that it's not dramatic. I've seen dramatic performance benefits on other projects, although perhaps that was for more complex queries and higher volumes of data where fractions of seconds can add up dramatically. In any case, you don't have to justify it to me. I'm just curious. Thanks for explaining your thought process to me :). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22333] Replace duplicated code in CanBookBeRenewed with GetSoonestRenewDate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22333 --- Comment #4 from David Cook --- (In reply to Josef Moravec from comment #3) > (In reply to David Cook from comment #2) > > I don't have a formal test plan yet, since it's a fiddly bit of code and I > > have other things to do, but I wanted to share the change anyway. > > I think run test t/db_dependent/Circulation.t could be fine test plan here ;) I'm happy to go with that if you are! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22334] Missing modules on perldoc.k-c.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22334 Galen Charlton changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|wizzy...@gmail.com |gmcha...@gmail.com CC||gmcha...@gmail.com --- Comment #1 from Galen Charlton --- I've identified and fixed an issue with the automatic updating of the perldoc and am rebuilding it now; it will take a few hours to finish. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22363] Move C4::Logs::GetLogs to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363 Josef Moravec changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22363] Move C4::Logs::GetLogs to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363 --- Comment #6 from Josef Moravec --- Created attachment 85261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85261&action=edit Bug 22363: Update Circulation.t to use Koha::ActionLogs instead of GetLogs Test plan: prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22364] Please add 18.11 schema to the Koha Community Database page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22364 Chris Cormack changed: What|Removed |Added Status|NEW |RESOLVED Severity|major |minor Resolution|--- |FIXED --- Comment #1 from Chris Cormack --- Done -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3820] More detailed patron record changes log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 Josef Moravec changed: What|Removed |Added Summary|Members in Log Viewer |More detailed patron record |Showing ?? in UPDATE|changes log -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 --- Comment #30 from Josef Moravec --- Created attachment 85258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85258&action=edit Bug 3820: DB Update to make old cardnumber logs match the new format Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 --- Comment #29 from Josef Moravec --- Created attachment 85257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85257&action=edit Bug 3820: (follow-up) Clean up warnings Signed-off-by: Owen Leonard Signed-off-by: Charles Farmer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 --- Comment #32 from Josef Moravec --- Created attachment 85260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85260&action=edit Bug 3820: (QA follow-up) Change REGEXP_REPLACE to REPLACE for wider compatibility Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 --- Comment #31 from Josef Moravec --- Created attachment 85259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85259&action=edit Bug 3820: Update tests to reflect the change of behaviour Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820
Josef Moravec changed:
What|Removed |Added
Attachment #85243|0 |1
is obsolete||
Attachment #85244|0 |1
is obsolete||
Attachment #85245|0 |1
is obsolete||
Attachment #85246|0 |1
is obsolete||
--- Comment #28 from Josef Moravec ---
Created attachment 85256
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85256&action=edit
Bug 3820: Add changes to MEMBERS MODIFY logaction
This patch attemps to add a more refined and detailed info structure
detailing what fields were changed and what they were changed from and
to.
Test Plan: Enable BorrowersLog in the system preferences and undertake a
series of borrower detail changes. Go to view the actionlogs and note
that MEMBER MODIFY logs now detail what fields you have changed using
the following form:
{ FIELD1: { before: BEFORE_VALUE, after: AFTER_VALUE } }
Signed-off-by: Owen Leonard
Signed-off-by: Charles Farmer
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22353] ReturnBeforeExpiry date supplanted by SpecifyDueDate preference date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22353 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 Arthur Suzuki changed: What|Removed |Added Attachment #85211|0 |1 is obsolete|| --- Comment #13 from Arthur Suzuki --- Created attachment 85255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85255&action=edit Bug 14293: Add more tests and improve get_chargeable_units Not sure at all about this change, especially because it could modify CalcFine Signed-off-by: Arthur Suzuki -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 Arthur Suzuki changed: What|Removed |Added Status|Signed Off |In Discussion --- Comment #12 from Arthur Suzuki --- Meh, guess I broke up something while trying to sign the patches, only one of them is signed and I cannot apply the patches anymore using git-bz... I wonder what I screwed up here :/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17746] koha-reset-passwd should use Koha::Patron->set_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 Tomás Cohen Arazi changed: What|Removed |Added Blocks||21976 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21976 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21976 [Bug 21976] koha-reset-passwd does not deal with password restrictions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21976] koha-reset-passwd does not deal with password restrictions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21976 Tomás Cohen Arazi changed: What|Removed |Added Depends on||17746 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17746 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 [Bug 17746] koha-reset-passwd should use Koha::Patron->set_password -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22363] Move C4::Logs::GetLogs to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363 Josef Moravec changed: What|Removed |Added Attachment #85253|0 |1 is obsolete|| --- Comment #5 from Josef Moravec --- Created attachment 85254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85254&action=edit Bug 22363: Use Koha::ActionLogs->search instead of GetLogs in log viewer Test plan: 1) Use log viewer, try different parameters 2) Try screen and file export 3) prove t/db_dependent/Koha/ActionLogs.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22363] Move C4::Logs::GetLogs to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363 Josef Moravec changed: What|Removed |Added Attachment #85250|0 |1 is obsolete|| --- Comment #4 from Josef Moravec --- Created attachment 85253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85253&action=edit Bug 22363: Use Koha::ActionLogs->search instead of GetLogs in log viewer Test plan: 1) Use log viewer, try different parameters 2) Try screen and file export 3) prove t/db_dependent/Koha/ActionLogs.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8000] Test mode for notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #163 from Katrin Fischer --- (In reply to Victor Grousset/tuxayo from comment #162) > From the test plan, I don't get how «test mode for notices so a library can > see what all of the notices will look like before go live» (from the > description) > > Can we trigger emails without the queue being consumed? > > i.e. What would be the workflow to use this feature to go back and forth > between tuning the notices and seeing the result. They are still send the same way (via the queue if they normally are), but to another email address that you specified. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8000] Test mode for notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Victor Grousset/tuxayo changed: What|Removed |Added CC||victor.grous...@biblibre.co ||m --- Comment #162 from Victor Grousset/tuxayo --- From the test plan, I don't get how «test mode for notices so a library can see what all of the notices will look like before go live» (from the description) Can we trigger emails without the queue being consumed? i.e. What would be the workflow to use this feature to go back and forth between tuning the notices and seeing the result. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 Arthur Suzuki changed: What|Removed |Added Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293
Arthur Suzuki changed:
What|Removed |Added
Attachment #85251|0 |1
is obsolete||
--- Comment #11 from Arthur Suzuki ---
Created attachment 85252
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85252&action=edit
Bug 14293: The suspension should be calculated in days
There was a mismatch between bug 13909 and bug 5549.
The get_chargeable_units call from _debar_user_on_return should specify
that we want a suspension in days.
However I don't understand the comment let by the author of bug 5549
f61a9617184ec4b24100c1d99150bfd4ebf13336
1/
> finedays is in days, so hourly loans must multiply by 24
Yes but the suspension is in days, so no need to * 24
2/ And we should have a look on this one too:
> grace period is measured in the same units as the loan
But the grace period is always in days. On the circ rules the column is
"Fine grace period (day)".
I think we should replace
DateTime::Duration->new( $unit => $issuingrule->{firstremind} );
with
DateTime::Duration->new( days => $issuingrule->{firstremind} );
Anyway, we definitelly need more tests in this area!
Test plan:
1/ Define an issuing rule with a unit=hour
2/ Set a suspension in days
3/ Check an item out and specify a past due date.
4/ Check the item in
5/ The patron should be debarred correctly
Signed-off-by: Nick Clemens
Signed-off-by: Arthur Suzuki
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293
Arthur Suzuki changed:
What|Removed |Added
Attachment #85210|0 |1
is obsolete||
--- Comment #10 from Arthur Suzuki ---
Created attachment 85251
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85251&action=edit
Bug 14293: The suspension should be calculated in days
There was a mismatch between bug 13909 and bug 5549.
The get_chargeable_units call from _debar_user_on_return should specify
that we want a suspension in days.
However I don't understand the comment let by the author of bug 5549
f61a9617184ec4b24100c1d99150bfd4ebf13336
1/
> finedays is in days, so hourly loans must multiply by 24
Yes but the suspension is in days, so no need to * 24
2/ And we should have a look on this one too:
> grace period is measured in the same units as the loan
But the grace period is always in days. On the circ rules the column is
"Fine grace period (day)".
I think we should replace
DateTime::Duration->new( $unit => $issuingrule->{firstremind} );
with
DateTime::Duration->new( days => $issuingrule->{firstremind} );
Anyway, we definitelly need more tests in this area!
Test plan:
1/ Define an issuing rule with a unit=hour
2/ Set a suspension in days
3/ Check an item out and specify a past due date.
4/ Check the item in
5/ The patron should be debarred correctly
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 --- Comment #9 from Arthur Suzuki --- This new patch do suspend the user until next day from the first minute overdue up until 24h late (non-inclusive). Then suspends for one more day for each period of 24h overdue. IMHO it is quite fair that one who is overdue for the night and brings back yesterday's hourly loans on the next morning may not borrow new books on the same day. If someone take a hourly loan and only brings back the book on the next morning then one might not get suspended for let say 10 days if one is 10 periods of 1h overdue. This behaviour is same whatever the hourly loan period is (tried with 1h and 6h), which I guess is the expected/desired behaviour. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 Josef Moravec changed: What|Removed |Added Depends on||22363 --- Comment #78 from Josef Moravec --- (In reply to Andrew Isherwood from comment #77) > Hi Josef > > Thanks for that. Sorry, I'm a bit lost. Are you suggesting I rewrite C4::Log > as a Koha object? If so, that seems a bit out of scope just to get this bug > through QA. Apologies if I'm misunderstanding! You do not need to rewrite whole C4::Log to Koha object, you just need to add Koha::ActionLog[s] objects and use them. Patch from Bug 22363 is enough for you ;) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363 [Bug 22363] Move C4::Logs::GetLogs to Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22363] Move C4::Logs::GetLogs to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363 Josef Moravec changed: What|Removed |Added Blocks||20750 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 [Bug 20750] Allow timestamped auditing of ILL request events -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22363] Move C4::Logs::GetLogs to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363 Josef Moravec changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |josef.mora...@gmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22363] Move C4::Logs::GetLogs to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363 --- Comment #1 from Josef Moravec --- Created attachment 85248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85248&action=edit Bug 22363: Add Koha::ActionLog[s] objects -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22363] Move C4::Logs::GetLogs to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363 --- Comment #2 from Josef Moravec --- Created attachment 85249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85249&action=edit Bug 22363: Add tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22363] Move C4::Logs::GetLogs to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363 --- Comment #3 from Josef Moravec --- Created attachment 85250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85250&action=edit Bug 22363: Use Koha::ActionLogs->search instead of GetLogs in log viewer Test plan: 1) Use log viewer, try different parameters 2) Try screen and file export 3) prove t/db_dependent/Koha/ActionLogs.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19524] Share patron lists between staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 --- Comment #17 from Katrin Fischer --- (In reply to Katrin Fischer from comment #15) > This reads like quite a behavior chance - moving things from being private > to be shared. Would be good to have some text for the release notes. I have since tested this. As "Shared" is an opt-in on any list, this works well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22364] Please add 18.11 schema to the Koha Community Database page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22364 Katrin Fischer changed: What|Removed |Added CC||ch...@bigballofwax.co.nz, ||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 --- Comment #14 from Katrin Fischer --- (In reply to Victor Grousset/tuxayo from comment #12) > Are there cases where a serial wouldn't always have a vendor? From a > librarian POV. Some don't use the claim feature or acq... and then the vendor might be left empty. Also maybe if you are tracking your own publications or loose leaf things? I am not sure, but I have been asked if the field can be left empty. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21560] Optimize ODS exports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560 --- Comment #17 from Fridolin SOMERS --- I'm on a subroutine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22290] Next pages results for cyrillic symbols shows decoded text in URL in anchor tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22290
George Veranis changed:
What|Removed |Added
CC||gvera...@gmail.com
--- Comment #1 from George Veranis ---
Based on https://www.perlmonks.org/bare/?node_id=495747
and that answer
"
Won't that escape data twice? Without actually running it, it looks like
"\x{1234}"
would be transformed by uri_escape_utf8 into
"%C8%B4"
which would be transformed by POST into
"%25C8%25B4"
while the right answer would be
"%C8%B4"
"
I add the line $query_cgi = Encode::decode_utf8(uri_unescape($query_cgi));
at 587 of opac-search.pl and it works
I will try later to do a patch for that.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #35 from David Gustafsson --- Yes, that change would perhaps be pretty trivial. Still not completely obvious how to try to "autocorrect" the regexps though. The regexps in lucene are always anchored according to https://stackoverflow.com/questions/34312196/elastic-search-query-string-regex That might be the reason why I got strange results when trying out regexps on the format "foo/bar/", which produced no results, while /foobar/ did. I also assume that the regexp is run on the tokenized values in ElasticSearch, with possible stemming, n-grams etc applied (even though I don't think we do any of these at the moment), so it's not very obvious for the user what values are actually matched against. Regexp against a ".raw" subfield behaves more like you would expect, matching against the exact value of the mapped data. I's because of theses issue I think it might be better to disable regexps altogether, possibly with a an option for enabling a less accessible syntax for expert users who know what they are doing. Slashes embedded in word characters are also interpreted as regexp by Elastic since the string "foo/bar" also results in an error. So I also believe it to be a real problem that librarians will input such strings with matching and/or not matching delimiters and get unexpected results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Julian Maurice changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 --- Comment #13 from Julian Maurice --- (In reply to Katrin Fischer from comment #11) > (In reply to Victor Grousset/tuxayo from comment #10) > > So now aqbookseller is mandatory in the form right? > > I'd like to avoid this if possible. Right now there is only a warning and I > think assigning a 'fake' vendor in some cases is not as nice as the current > behaviour. Bookseller is still optional, but now subscription.aqbooksellerid would be NULL instead of 0 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22364] New: Please add 18.11 schema to the Koha Community Database page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22364 Bug ID: 22364 Summary: Please add 18.11 schema to the Koha Community Database page Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Websites, Mailing Lists, etc Assignee: wizzy...@gmail.com Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- Hi, Can a new version of Koha schema be added to the Koha Community Database page? With Koha version 18.11, there is a few new tables added- such as Stock Rotation! Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 --- Comment #12 from Victor Grousset/tuxayo --- Are there cases where a serial wouldn't always have a vendor? From a librarian POV. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22353] ReturnBeforeExpiry date supplanted by SpecifyDueDate preference date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22353 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21691] Koha::Account->non_issues_charges has no tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21691 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |RESOLVED Resolution|--- |WORKSFORME --- Comment #4 from Tomás Cohen Arazi --- Hi, I've jut spotted that t/db_dependent/Accounts.t has a broad coverage of this method. Unfortunately it wasn't on the place we would've expected (t/db_dependent/Koha/Account.t). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 --- Comment #11 from Katrin Fischer --- (In reply to Victor Grousset/tuxayo from comment #10) > So now aqbookseller is mandatory in the form right? I'd like to avoid this if possible. Right now there is only a warning and I think assigning a 'fake' vendor in some cases is not as nice as the current behaviour. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 --- Comment #91 from David Gustafsson --- Created attachment 85247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85247&action=edit Bug 19575: Don't lower case fields in db and use update script instead of raw SQL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22363] New: Move C4::Logs::GetLogs to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363 Bug ID: 22363 Summary: Move C4::Logs::GetLogs to Koha namespace Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: josef.mora...@gmail.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22362] New: Make item column in cart sortable in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22362 Bug ID: 22362 Summary: Make item column in cart sortable in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Target Milestone: --- While the items column in the staff client is sortable, the same is not true for the cart view in the OPAC. I know that the most we could do is sort on the first callnumber available in the list, but I think this would still be helpful in some setups. For example for libraries with only one branch it would be really helpful if the column was sortable as it would help to generate a list that can be used at the library to efficiently get the books from the shelves. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 --- Comment #10 from Victor Grousset/tuxayo --- So now aqbookseller is mandatory in the form right? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 --- Comment #90 from David Gustafsson --- Yes, the lowercase update statement is pretty pointless since the mixed case field names will be restored on reset. Field names are lower-cased in _foreach_mapping, so the case of field names in mappings.yaml (or database) does not really matter. If lower casing all field names the corresponding field names in mappings.yaml should also be lower cased. The field name renaming is probably still a good idea, so that a reset is not required. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21691] Koha::Account->non_issues_charges has no tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21691 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 --- Comment #27 from Martin Renvoize --- Back to signed off now I've added the required update to the tests (and also added a db update to make old cardnumber logs match the new format.. although we can't retrospectively populate the logs for other actions the update should make writing future reports backwards compatible without adding effort. Let me know if you'd like any further additions to the tests or anything. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820
Martin Renvoize changed:
What|Removed |Added
Attachment #85196|0 |1
is obsolete||
--- Comment #23 from Martin Renvoize ---
Created attachment 85243
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85243&action=edit
Bug 3820: Add changes to MEMBERS MODIFY logaction
This patch attemps to add a more refined and detailed info structure
detailing what fields were changed and what they were changed from and
to.
Test Plan: Enable BorrowersLog in the system preferences and undertake a
series of borrower detail changes. Go to view the actionlogs and note
that MEMBER MODIFY logs now detail what fields you have changed using
the following form:
{ FIELD1: { before: BEFORE_VALUE, after: AFTER_VALUE } }
Signed-off-by: Owen Leonard
Signed-off-by: Charles Farmer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 --- Comment #26 from Martin Renvoize --- Created attachment 85246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85246&action=edit Bug 3820: Update tests to reflect the change of behaviour -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 --- Comment #25 from Martin Renvoize --- Created attachment 85245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85245&action=edit Bug 3820: DB Update to make old cardnumber logs match the new format -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 Martin Renvoize changed: What|Removed |Added Attachment #85197|0 |1 is obsolete|| --- Comment #24 from Martin Renvoize --- Created attachment 85244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85244&action=edit Bug 3820: (follow-up) Clean up warnings Signed-off-by: Owen Leonard Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 --- Comment #8 from Julian Maurice --- Created attachment 85241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85241&action=edit Bug 18745: kohastructure.sql: Move aqbooksellers above serial Otherwise we can't define a foreign key in serial that references aqbooksellers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 --- Comment #9 from Julian Maurice --- Created attachment 85242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85242&action=edit Bug 18745: Add foreign key constraint on subscription.aqbooksellerid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 --- Comment #7 from Julian Maurice --- Created attachment 85240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85240&action=edit Bug 18745: Serial claims: save supplier info on serial-level This allows to change the subscription's supplier while keeping the info of supplier for previous serials, which allows to claim late/missing serials to the right supplier Test plan: 1. Create 2 suppliers, S1 and S2 2. Create a new subscription with S1 3. Generate some late/missing serials 4. Change supplier to S2 5. Generate some more late/missing serials 6. Go to /cgi-bin/koha/serials/claims.pl and see you have late/missing issues for both suppliers 7. Check that you have the expected issues for each supplier 8. prove t/db_dependent/Serials/Claims.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20485] Don't account for items timestamps when combining "dont_export_items=1" and "date" in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20485 David Gustafsson changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #7 from David Gustafsson --- Seams like I got the condition wrong, and it skipped items timestamps when items where included and not the other way around. Should now be fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20485] Don't account for items timestamps when combining "dont_export_items=1" and "date" in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20485 David Gustafsson changed: What|Removed |Added Attachment #75112|0 |1 is obsolete|| --- Comment #6 from David Gustafsson --- Created attachment 85239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85239&action=edit Bug 20485: Don't account for items timestamps when items not included If combining "--dont_export_items" and "--date" options in export_records.pl, don't include items modification/deletion timestamp in biblio query conditions. How to test: 1) Delete or modify a biblio item. 2) Run export_records.pl with "--dont_export_items" and "--date" options with a date value before item was deleted or modified, but after the biblio was modified. 3) The biblio for which an item was changed should not be included in the export. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 --- Comment #77 from Andrew Isherwood --- Hi Josef Thanks for that. Sorry, I'm a bit lost. Are you suggesting I rewrite C4::Log as a Koha object? If so, that seems a bit out of scope just to get this bug through QA. Apologies if I'm misunderstanding! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 --- Comment #76 from Josef Moravec --- (In reply to Andrew Isherwood from comment #74) > (In reply to Josef Moravec from comment #72) > > > I don't think the time formatting should be done here in the logger... it is > > helper method working with date and time... this way we could end up with > > one time formatter per class... > > Thanks for the feedback! > > OK. The obvious solution here in that case would be for me to add an > additional parameter to C4::Log::GetLogs that allows you to specify if the > logs should be returned sorted by date. Do you agree this would address your > concerns? Maybe it would be better to create Koha::ActionLog[s] classes based on Koha::Object, it would be much better then adding new parameter to GetLogs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 --- Comment #75 from Andrew Isherwood --- Created attachment 85238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85238&action=edit Bug 20750: (follow-up) Set logging default off As per comment #72 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750#c72 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22331] Lost items that are written off gives credit when returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22331 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22337] Make it clearer that language preferences can be re-ordered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22337 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22310] Show items as On Order in search results without allowing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22310 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 --- Comment #7 from Josef Moravec --- Comment on attachment 85067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85067 Bug 22330: Transfer limits should be respected for placing holds in staff interface and APIs Review of attachment 85067: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22330&attachment=85067) - ::: C4/Reserves.pm @@ +34,3 @@ > use C4::Letters; > use C4::Log; > +use C4::Members qw(); C4::Members is just few lines above with full import... @@ +48,4 @@ > use Koha::ItemTypes; > +use Koha::Items; > +use Koha::Libraries; > +use Koha::Libraries; The same use line twice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 --- Comment #74 from Andrew Isherwood --- (In reply to Josef Moravec from comment #72) > I don't think the time formatting should be done here in the logger... it is > helper method working with date and time... this way we could end up with > one time formatter per class... Thanks for the feedback! OK. The obvious solution here in that case would be for me to add an additional parameter to C4::Log::GetLogs that allows you to specify if the logs should be returned sorted by date. Do you agree this would address your concerns? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 --- Comment #73 from Katrin Fischer --- (In reply to Josef Moravec from comment #72) > (In reply to Andrew Isherwood from comment #69) > > (In reply to Katrin Fischer from comment #64) > > > > > 1) QA script: > > > > Fixed > > > > > 2) I am wondering a bit about the date operations in the Logger module, > > > get_epoch especially. > > > > What's concerning you about this? All it does is get the epoch value for > > dates returned so we can sort them for display. It doesn't modify them in > > any way > > I don't think the time formatting should be done here in the logger... it is > helper method working with date and time... this way we could end up with > one time formatter per class... > > > > 3) This doesn't need to be part of the installer outside the sysprefs.sql > > > file. > > > Files ill_logging_pref.txt and ill_logging_pref.sql can be removed. > > > > Done > > > > > 4) I wonder if we should set the logger to off by default for updated > > > installations and allow people to turn it on themselves. > > > > I don't know really. I guess we need to be consistent with what other > > logging modules do. Do they default to off or on? > > Default logs: > AuthoritiesLog IS ON > BorrowersLog IS ON > CataloguingLog IS ON > FinesLog is ON > IssueLog is ON > LetterLog is ON > ReturnLog is ON > SubscriptionLog IS ON > > CronjobLog is OFF > HoldsLog is OFF > RenewalLog is OFF > ReportsLog is OFF > > so 8 are ON and 4 are OFF, but I prefer to this log off by default too > > > > > > 5) For translations it's always nice to be specific. > > > > Done > > > > > 6) In the log viewer, could we make the visibility of the ILL parts > > > depend on the system preference? > > > > I agree. This is a great idea. However, looking at the log viewer code and > > template, there's currently no way of setting the visibility of a logging > > module based on a syspref. Presumably, the need has never arisen before. I'm > > not sure this bug is the place to add that, since it's a more generic > > mechanism in the log viewer, rather than just special casing ILL. As I say, > > it's a great idea, I'm just not sure it should be done here. Happy to do it > > if you disagree however. > > > > > 7) Just using this for a teaching moment > > > > Mmmm, good point. That will have been a typo, the space should never have > > been inside the tag. Fixed > > > > > 8) Tests are failing for me: > > > > Fixed > > > > Thanks very much for the feedback, much appreciated! Thx Joseph! I agree with default OFF, especially since the ILL module is optional. And I see a pattern there, all the default off were added after 3.2. So there is a pattern for adding new logs. Thx! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22361] Not able to create Vendor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22361 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22356] Warnings when running fines.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22356 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22352] Items location not shown correctly in email sent lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22352 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22346] Populate items.booksellerid when creating items in serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22346 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22347] Translatability of ILSDI results for getavaibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22347 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22341] batch patron modification tool does not strip trailing tab characters from barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22341 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22332] Limit to currently available items in home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22332 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22327] Circulation Rules simplification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22327 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22324] Might be nice to list forks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22324 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22333] Replace duplicated code in CanBookBeRenewed with GetSoonestRenewDate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22333 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com --- Comment #3 from Josef Moravec --- (In reply to David Cook from comment #2) > I don't have a formal test plan yet, since it's a fiddly bit of code and I > have other things to do, but I wanted to share the change anyway. I think run test t/db_dependent/Circulation.t could be fine test plan here ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com Status|Signed Off |Failed QA QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | --- Comment #22 from Josef Moravec --- This is great addition and I like it, but as it changes the behaviour, the test should be adjusted too: t/db_dependent/Koha/Patrons.t .. 29/33 # Failed test 'Got correct new cardnumber' # at t/db_dependent/Koha/Patrons.t line 1414. # got: undef # expected: 'TESTCARDNUMBER' # Failed test 'Got correct old cardnumber' # at t/db_dependent/Koha/Patrons.t line 1415. # got: undef # expected: 'jY44Hy2e7OojC2Zx7vMo43gzub' # Failed test 'With BorrowerLogs, Change in cardnumber should be logged, as well as general alert of patron mod.' # at t/db_dependent/Koha/Patrons.t line 1416. # got: '1' # expected: '2' # Looks like you failed 3 tests of 3. # Failed test 'Log cardnumber change' # at t/db_dependent/Koha/Patrons.t line 1417. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 --- Comment #72 from Josef Moravec --- (In reply to Andrew Isherwood from comment #69) > (In reply to Katrin Fischer from comment #64) > > > 1) QA script: > > Fixed > > > 2) I am wondering a bit about the date operations in the Logger module, > > get_epoch especially. > > What's concerning you about this? All it does is get the epoch value for > dates returned so we can sort them for display. It doesn't modify them in > any way I don't think the time formatting should be done here in the logger... it is helper method working with date and time... this way we could end up with one time formatter per class... > > 3) This doesn't need to be part of the installer outside the sysprefs.sql > > file. > > Files ill_logging_pref.txt and ill_logging_pref.sql can be removed. > > Done > > > 4) I wonder if we should set the logger to off by default for updated > > installations and allow people to turn it on themselves. > > I don't know really. I guess we need to be consistent with what other > logging modules do. Do they default to off or on? Default logs: AuthoritiesLog IS ON BorrowersLog IS ON CataloguingLog IS ON FinesLog is ON IssueLog is ON LetterLog is ON ReturnLog is ON SubscriptionLog IS ON CronjobLog is OFF HoldsLog is OFF RenewalLog is OFF ReportsLog is OFF so 8 are ON and 4 are OFF, but I prefer to this log off by default too > > > 5) For translations it's always nice to be specific. > > Done > > > 6) In the log viewer, could we make the visibility of the ILL parts depend > > on the system preference? > > I agree. This is a great idea. However, looking at the log viewer code and > template, there's currently no way of setting the visibility of a logging > module based on a syspref. Presumably, the need has never arisen before. I'm > not sure this bug is the place to add that, since it's a more generic > mechanism in the log viewer, rather than just special casing ILL. As I say, > it's a great idea, I'm just not sure it should be done here. Happy to do it > if you disagree however. > > > 7) Just using this for a teaching moment > > Mmmm, good point. That will have been a typo, the space should never have > been inside the tag. Fixed > > > 8) Tests are failing for me: > > Fixed > > Thanks very much for the feedback, much appreciated! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Detailed description of charges on Accounting tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #34 from Katrin Fischer --- Depending on how difficult the rebase was, it's ok to set back to "Signed off" after rebasing. If you feel it should be tested from scratch (hard rebase), setting to "Needs Signoff" is of course better. We usually keep the sign-off lines on the patches - it shows that someone spent time on it already. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 --- Comment #30 from Josef Moravec --- (In reply to Jonathan Druart from comment #29) > - prove -Mt::lib::Bootstrap t/db_dependent/selenium/authentication.t # Will > drop, create and use "database_test" to run the tests. it will drop, create and try to use "database_test", but this db is empty and the test then fail... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Detailed description of charges on Accounting tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #33 from Devinim --- Created attachment 85237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85237&action=edit Bug 19489: (Rebased) Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab Test plan: 1) Apply this patch 2) Choose a patron with overdue items applied fines 3) Click Fines from left menu 4) Test the values in barcode, due date and return date in Pay fines and Account tabs 5) Also test Column visibility, Print and Details buttons for functioning -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
