[Koha-bugs] [Bug 18235] Elastic search - Configurable facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec changed: What|Removed |Added Status|Signed Off |Failed QA CC||josef.mora...@gmail.com, ||oleon...@myacpl.org --- Comment #52 from Josef Moravec --- Hi Jonathan, great job, I have just some small questions (see above) I also adding Owen if he can advice us how to do the UI better, it is not obvious that the facet order could be changed, also the facet table is at the end of page and easy to oversee... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18235] Elastic search - Configurable facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235
--- Comment #51 from Josef Moravec ---
Comment on attachment 85212
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85212
Bug 18235: ES - Facets configurable
Review of attachment 85212:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18235=85212)
-
::: Koha/SearchEngine/Elasticsearch.pm
@@ +971,5 @@
> +my @faceted_fields = Koha::SearchFields->search(
> +{ name => { -in => \@search_field_names }, facet_order => { '!=' =>
> undef } }, { order_by => ['facet_order'] }
> +);
> +my @not_faceted_fields = Koha::SearchFields->search(
> +{ name => { -in => \@search_field_names }, facet_order => undef }, {
> order_by => ['facet_order'] }
Why do you retrieve fields from database in 2 queries, you always use them all.
::: admin/searchengine/elasticsearch/mappings.pl
@@ +215,4 @@
> push @all_search_fields, $search_field_unblessed;
> }
>
> +my @facetable_fields =
> Koha::SearchEngine::Elasticsearch->get_facetable_fields();
get_facetable_fields is called 3 or 4 times every run of mappings.pl.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18235] Elastic search - Configurable facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235
--- Comment #50 from Josef Moravec ---
Comment on attachment 85214
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85214
Bug 18235: DB changes
Review of attachment 85214:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18235=85214)
-
:::
installer/data/mysql/atomicupdate/bug_18235-add-search_field-facet_order.sql
@@ +1,1 @@
> +ALTER TABLE search_field ADD COLUMN facet_order TINYINT(4) DEFAULT '0' AFTER
> weight;
Here is default 0
::: installer/data/mysql/kohastructure.sql
@@ +1493,4 @@
>`label` varchar(255) NOT NULL COMMENT 'the human readable name of the
> field, for display',
>`type` ENUM('', 'string', 'date', 'number', 'boolean', 'sum', 'isbn',
> 'stdno') NOT NULL COMMENT 'what type of data this holds, relevant when
> storing it in the search engine',
>`weight` decimal(5,2) DEFAULT NULL,
> + `facet_order` TINYINT(4) DEFAULT NULL COMMENT 'the order place of the
> field in facet list if faceted',
And here NULL
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18235] Elastic search - Configurable facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #48 from Josef Moravec --- Created attachment 85885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85885=edit Bug 18235: (QA follow-up) Fix POD -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18235] Elastic search - Configurable facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #49 from Josef Moravec --- Created attachment 85886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85886=edit Bug 18235: (QA follow-up) Add missing filters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 --- Comment #26 from Katrin Fischer --- (In reply to Jonathan Druart from comment #25) > (In reply to Koha Team Lyon 3 from comment #24) > > In my opinion, if suspension_chargeperiod = 2, we should not charge on the > > first day... but, I'm not sure of the behaviour in the current version of > > Koha. > > Did not test neither remember. But my feeling is that: if you are late, you > pay. If you do not want this behavior you could use the grace. > > Before continuing on this maybe we should ask on the list? I think we could use the "when to charge" parameter for this as it's the same problem as with fines. It allows to charge at the beginning of the interval (charge first day) or at the end (charge after 2 days). This way the behavior would be configurable and we even have the option already. What do you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21401] Account offsets should save the transacting library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21401 Josef Moravec changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |WONTFIX --- Comment #28 from Josef Moravec --- (In reply to Martin Renvoize from comment #27) > Was there any further work you wanted to undertake here Josef.. or did it > all end up folded into bug 19066? For me, it is covered by bug 19066, so I am not going to continue on this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21538] Show ilbrary on account page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21538 Bug 21538 depends on bug 21401, which changed state. Bug 21401 Summary: Account offsets should save the transacting library https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21401 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22437] Subsequent authority merges in cron cause biblios to lose authority information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22437 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- I don't have time to look at this, but I applaud you on your efforts! If you have any issues with https://wiki.koha-community.org/wiki/Git_bz_configuration, visit #koha on the OFTC IRC network, or email koha-de...@lists.koha-community.org. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Delegate background jobs execution
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #16 from David Cook --- (In reply to Tomás Cohen Arazi from comment #12) > My only doubt is if we should really model the task queue with a message > queue. I tried the same Jonathan tried but using AnyEvent::Task and the > results where similar, and it only required a unix socket to communicate > client and server processes. My suggestion was to use zeromq. But lets see > how this goes. Specially in the integration step. Yeah, for #10662, I used POE::Component::JobQueue and a Unix socket. It was very effective, although my bespoke implementation had a number of limitations. I figured allowing TCP sockets also might be a good idea just to allow for more distributed architectures. When I was working on #10662, I was considering both RabbitMQ and ZeroMQ, but ended up doing my own job queue. I'm not necessarily sold on RabbitMQ yet, but I figure if Jonathan is willing to do it, I'm happy to see how this goes too. I'm not willing to put in the time to make it happen :/. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Delegate background jobs execution
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417
--- Comment #15 from David Cook ---
(In reply to Jonathan Druart from comment #13)
> (In reply to Tomás Cohen Arazi from comment #12)
> > I agree with David that this of course would require a single RabbitMQ
> > server so questions: Is there a concept of namespaces? can any Koha instance
> > access other instance's messages?
>
> I really would like you guys to apply, read and try the patches, read the
> code, then discuss :)
> There are a lot of FIXME and TODO.
>
> This one answers your question:
>
> 16 sub connect {
> 17 my ( $self );
> 18 my $conn = Net::RabbitFoot->new()->load_xml_spec()->connect(
> 19 host => 'localhost', # TODO Move this to KOHA_CONF
> 20 port => 5672,
> 21 user => 'guest',
> 22 pass => 'guest',
> 23 vhost => '/',
> 24 );
> 25
> 26 return $conn;
> 27 }
>
> So different vhost, user and pass can be used.
I haven't tried the patches but I have read your code, and that's why I've
voiced my concerns about multi-tenancy. There wasn't enough information there
to understand, so that's why I asked the questions.
Your reply almost answers the question, but not quite, so now I'm just reading
about RabbitMQ.
If I understand correctly, each Koha instance would get its own RabbitMQ
"vhost", and within each "vhost" there would be named queues (which at the
moment are hard-coded but could be configurable I suppose).
Cool. That removes my concerns about multi-tenancy. Thanks for that, Jonathan.
(Maybe in your example you could use something like "vhost => '/kohademo'" or
maybe include some code comments just so it's more obvious how it works.)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20364] Show languages from MARC21 field 041 in intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 ar...@stlukes.nsw.edu.au changed: What|Removed |Added CC||ar...@stlukes.nsw.edu.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 ar...@stlukes.nsw.edu.au changed: What|Removed |Added CC||ar...@stlukes.nsw.edu.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Bob Birchall changed: What|Removed |Added CC||b...@calyx.net.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3298] Independent item "Status Check" functionality needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3298 Daniel Gaghan changed: What|Removed |Added CC||daniel.gaghan@pueblolibrary ||.org --- Comment #2 from Daniel Gaghan --- As of 18.05 this is still not a feature and is requested by PCCLD staff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #37 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #20) > 1. Maybe we should display the WARNING during the updatedb process only if > really needed? > > 2. How do I test the maintenance script? To test: - Enable tags and disable moderation (or plan to moderate and accept tags) - Tag 3 records: a - with b - with c - with - Note the weight on each says '3' - Click the tag to search, you get back all the records - Apply the previous patches from this bug report - Run: $ updatedatabase to upgrade the schema $ kshell k$ perl misc/maintenance/fix_tags_weight.pl => SUCCESS: the weights make sense -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22043] SIP Checkin Response alert flag set to often set to Y incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22043 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22043] SIP Checkin Response alert flag set to often set to Y incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22043 --- Comment #7 from Kyle M Hall --- Created attachment 85884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85884=edit Bug 22043: (QA Follow-up) Add paramter to control behavior -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22043] SIP Checkin Response alert flag set to often set to Y incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22043 --- Comment #6 from Kyle M Hall --- In that case, I'll add a SIP config parameter to make this configurable. (In reply to Colin Campbell from comment #5) > No it doesnt violate the standard, the link between there being a message > and the alert is a convention that the original code adopted. Similarly the > assumption that CV must be present, CV was not part of the original spec, > and will be ignored by some clients. Unfortunately its become more complex > as since then we've added/suppressed various messages in the circ routines, > and informational messages have been added. That said I suspect nowhere is > reliant on the alert flag's current behaviour. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Arthur Suzuki changed: What|Removed |Added Attachment #85118|0 |1 is obsolete|| --- Comment #30 from Arthur Suzuki --- Created attachment 85883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85883=edit Bug 17229: Check if patron is expired in CanItemBeReserved This way, calls to ILS-DI HoldTitle and HoldItem do this check too Added test plan to commit message : -Set Syspref BlockExpiredPatronOpacActions to "ON", -Set a patron's category variable "Block expired patrons" to "Follow SysPref" or -"Block" (ideally test both). -Get the id of a patron from this category (ie : 1234). -Set this patron's expiration date to a date earlier than today. -Get a biblionumber which can be reserved (ie : 5678). Put the following string in your webbrowser (replacing OpacBaseUrl, 1234 and 5678 by your own values) : http://[OpacBaseUrl]/cgi-bin/koha/ilsdi.pl?service=HoldTitle_id=1234_id=5678_location='127.0.0.1' Should not create a new hold for the patron and report an error. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21986] Quotation marks are wrongly escaped in several places
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21986 --- Comment #19 from Lucas Gass --- reverted in 18.05.x and will be removed in 18.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22395] Data in 245 field (subfield a or b) will be deleted if it has Quotation Marks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22395 --- Comment #8 from Lucas Gass --- 21986 has been reverted from 18.05.x -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22437] Subsequent authority merges in cron cause biblios to lose authority information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22437 --- Comment #1 from Pedro Amorim --- I've added the following fix: https://github.com/GovernoRegionalAcores/Koha/pull/1/commits/eebddb09c95ba857df8df516d00b4bb96808e59e Tested it, works and resolves the problem. If anyone would be so kind to confirm this while I go through the process of learning and attempting to submit a patch through this method https://wiki.koha-community.org/wiki/Git_bz_configuration Thank you very much, Pedro Amorim -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19460] Limit total number of checkouts allowed per patron by patron category code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19460 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Resolution|--- |WONTFIX Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Joy Nelson changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||j...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22437] New: Subsequent authority merges in cron cause biblios to lose authority information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22437 Bug ID: 22437 Summary: Subsequent authority merges in cron cause biblios to lose authority information Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs@lists.koha-community.org Reporter: pjamori...@gmail.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- Here's how to reproduce the problem: AuthorityMergeLimit syspref is default 50. Here's an example list of 3 authorities (A, B and C) that should be merged together - resulting in 1 authority - and the total count of biblios linked to each respective authority (similar to the interface you get when searching authorities): A 100 B 60 C 2 The good scenario: If you merge the authorities like this: First: C -> A Second: B -> A All is good, after the first merge (C -> A), A has 102 biblios. After second merge (B -> A), B no longer exists and A still has 102 - as expected, because the merge is scheduled to the cron. After forcing the cron koha-foreach --chdir --enabled /usr/share/koha/bin/cronjobs/merge_authorities.pl -b -v authority A now has 162 biblios, as expected. The bad scenario: The problem occurs if authorities are merged like this: First: C -> B Second: B -> A After the first merge (C -> B), B has 62 biblios. After the second merge (B -> A), B no longer exists and A still has 100 - as expected, because the merge is scheduled to the cron. However, after forcing the cron koha-foreach --chdir --enabled /usr/share/koha/bin/cronjobs/merge_authorities.pl -b -v authority A still has 100 biblios, and the 62 biblios that were previously linked to B have effectively lost the authority information they previously had. After some testing, I noticed that Koha will schedule an authority merge for the same authority (on itself), even when the biblios count doesn't surpass AuthorityMergeLimit, I'll explain: For the C -> B merge, the 2 biblios from C will be updated immediately in the application (because 2 < 50), but simultaneously Koha will schedule the cron merge B -> B. I think this happens because the merge.pl script first modifies the reference authority using ModAuthority (that calls the merge function), and then calls the merge function, can be seen here: https://github.com/Koha-Community/Koha/blob/18.11.x/authorities/merge.pl#L79 Which means that Koha will run the merge function, twice, for each authority merge made in the application. I think this is by design, because if B gets modified, Koha will have to update 60 biblios with the new authority information, updated subfields information etc, and this should be indeed postponed to the cron, hence the merge on itself B -> B caused by ModAuthority. However, because B -> A happened (deleting B) after C -> B and before the cron had the chance to run, by the time the cron has to run B -> B, B has already been deleted, cleaning the authority information from the 60 (or 62) biblio records. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22303] Wrong bottom in virtualshelves/addbybiblionumber.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22303 Fridolin SOMERS changed: What|Removed |Added Attachment #84981|0 |1 is obsolete|| --- Comment #5 from Fridolin SOMERS --- Created attachment 85882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85882=edit Bug 22303: Correct bottom in virtualshelves/addbybiblionumber.tt In virtualshelves/addbybiblionumber.tt the include intranet-bottom.inc which closes the HTML last tag is not the last line of the template. This patch moved bottom include to last line and uses popup-bottom.inc. Test plan : 1) Permission OK : 1.1) Login in staff interface with user 'Bob' 1.2) Create a new list 'Readme' : category public and allow changes to contents from anyone 1.3) Perform a search 1.4) Check some results 1.5) Click 'Add to list' and on the list 'Readme' 1.6) A popup window opens 1.7) Check its HTML is OK, ending with 2) Permission KO : 2.1) Open a new window (Firefox private session) and login in staff interface with user 'Bill' 2.2) Perform a search 2.3) Check some results 2.4) On session of 'Bob', edit list 'Readme' 2.5) Change : category private and allow changes to contents from owner only 2.6) On session of 'Bill' 2.7) Click 'Add to list' and on the list 'Readme' 2.8) A popup window opens saying 'Sorry, you do not have permission to add items to this list' 2.9) Check its HTML is OK, ending with -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22303] Wrong bottom in virtualshelves/addbybiblionumber.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22303 --- Comment #4 from Fridolin SOMERS --- (In reply to Fridolin SOMERS from comment #3) > (In reply to Owen Leonard from comment #2) > > It looks to me like the problem is that the template only includes > > intranet-bottom.inc if the user is authorized to add to the list. I think > > the correct solution is to move these lines: > > > > [% SET popup_window = 1 %] > > [% INCLUDE 'intranet-bottom.inc' %] > > > > ...to the end of the template, after the last [% END %] > > But it is a popup, why not using popup-bottom.inc ? OK not important ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22303] Wrong bottom in virtualshelves/addbybiblionumber.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22303 Fridolin SOMERS changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22283] Translation file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22283 --- Comment #9 from Katrin Fischer --- (In reply to Alex Arnaud from comment #8) > (In reply to Katrin Fischer from comment #7) > > Hi Alex, > > > > do you have time to look into this more? > > > > - Is this a pootle issue or are our translation tools in Koha broken? > > - Are we sure it's not an old problem? The "" are not in the original > > string, only added by the translation. I know that we were to avoid single > > quotes around translatable strings to avoid issues with translation (French > > containing single quotes), so I think this could actually be an old problem > > instead of a regression, just coming to light here because of the > > translation. I'd change the translation as a first step. > > IMHO we juste need to write in the po: > "Changer les préférences de notifications à \\\"Par défaut\\\" pour cette " > instead of: > "Changer les préférences de notifications à \"Par défaut\" pour cette " > > With the first one, we keep the double quotes escaped in templates. And it > works. Would it not be easier to avoid the quotes overall? I think translators won't be able to tell when they are translating Javascript strings and when they are working on normal text, where this trick won't work. But glad you found a fix! Will you change on pootle? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22245] MARC modification templates does not allow move or copy control fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22245 --- Comment #7 from Fridolin SOMERS --- 22436(In reply to Katrin Fischer from comment #5) > > > 2) > > > This does not allow copy/move of a control field in the subfield of a > > > regular field, ie 005 => 998$d. > > > This should be allowed ? > > A very common use case would be 001 > 035$a + Adding a prefix in MARC21. So > it would be nice if that worked. > > > > What is surely not allowed is : 005 => 998 > > I agree, in this case the 998 should have a subfield. Not sure the standard > has a say about this, but a lot of code I think assumed only <10 have no > subfields. I have opened Bug 22436 for that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22245] MARC modification templates does not allow move or copy control fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22245 Fridolin SOMERS changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22436 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22436] add move or copy control field from or to subfield in MARC modification templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22436 Fridolin SOMERS changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22245 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22436] add move or copy control field from or to subfield in MARC modification templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22436 --- Comment #1 from Fridolin SOMERS --- I think the form checks could look like that : # Check destination is filled if to_field undefined then "The destination should be filled." # Control field does not need a subfield if from_field is < 10 and from_subfield undefined or to_field is < 10 and to_subfield undefined then "If the field is a control field, the subfield should be empty" # Case source field is a control field if from_field is < 10 then if to_field is >= 10 and to_subfield undefined then "If source field is a control field and destination is a regular field, destination subfield must be filled." # Case source field is a regular field if from_field is >= 10 then if to_field is < 10 and from_subfield undefined then "If source field is a regular field and destination is a control field, source subfield must be filled." if to_field is >= 10 and ( from_subfield defined and to_subfield undefined or from_subfield undefined and to_subfield defined ) then "If source and destination fields are regular fields, both subfield values should be filled or empty." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22436] New: add move or copy control field from or to subfield in MARC modification templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22436 Bug ID: 22436 Summary: add move or copy control field from or to subfield in MARC modification templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- MARC modification templates does not allow to mix control field and the subfield of a regular field, we should allow that. But of course not the mix of an entire regular field and the subfield of a regular field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22245] MARC modification templates does not allow move or copy control fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22245 --- Comment #6 from Fridolin SOMERS --- Ah OK, actually control field can not be used with the subfield of a regular field. I see is not implemented in Koha::SimpleMARC : https://gitlab.com/koha-community/Koha/blob/f355788b340b19912891fd41c3168bac9c951aff/Koha/SimpleMARC.pm#L130 So this patch is good. Just a problem : When using 2 control fields, looks like move or copy with RexExp does not work. I think its from : https://gitlab.com/koha-community/Koha/blob/f355788b340b19912891fd41c3168bac9c951aff/Koha/SimpleMARC.pm#L570 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What|Removed |Added Depends on||14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21401] Account offsets should save the transacting library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21401 --- Comment #27 from Martin Renvoize --- Was there any further work you wanted to undertake here Josef.. or did it all end up folded into bug 19066? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What|Removed |Added Blocks||22435 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 [Bug 22435] account_offset types should be codes not descriptions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] New: account_offset types should be codes not descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Bug ID: 22435 Summary: account_offset types should be codes not descriptions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- Currently, account_offset.types are all descriptive strings.. they should really be 'codes' to distinguish them from user-facing data and discourage developers from adding more untranslatable strings at the database level. I also don't think the current strings make a great deal of sense as they're often not describing an 'offset' action but the account action itself which is already better defined within the accountline.accounttype fields. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10300] Allow transferring of items to be have separate IndependentBranches syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 --- Comment #9 from Fridolin SOMERS --- Created attachment 85881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85881=edit Bug 10300: (follow-up) add controls on transfers page This patch moves the check of IndependentBranchesTransfers pref to templates and adds permission test inside branchtransfers.pl. It also corrects the libraries combobox in branchtransfers.tt, this list can contain all libraries, it is the access to the page that may be protected. Additions to test plan : 1) 1.1) Enable CircSidebar 1.2) In circulation home page check the effect of IndependentBranchesTransfers on "Transfer" link 1.3) Go to return page and check then effect of IndependentBranchesTransfers on "Transfer" link 2) 2.1) In circ/branchtransfers.pl, with and without IndependentBranches you see all libraries are in combobox 3) 3.1) Set IndependentBranchesTransfers to no and go to circ/branchtransfers.pl 3.2) You are redirected to page 403 unless you are superlibarian -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10300] Allow transferring of items to be have separate IndependentBranches syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 Fridolin SOMERS changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10300] Allow transferring of items to be have separate IndependentBranches syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 Fridolin SOMERS changed: What|Removed |Added Attachment #54939|0 |1 is obsolete|| --- Comment #8 from Fridolin SOMERS --- Created attachment 85880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85880=edit Bug 10300: Allow transferring of items to be have separate IndependentBranches syspref Some libraries want to have IndependentBranches enabled, but still be able to transfer items between themselves. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndpendentBranches and IndependentBranchesTransfers 4) Log in as a super librarian 5) Note you can transfer items 6) Log in as a non-super librarian 7) Note you cannot transfer items 8) Disable IndependentBranchesTransfers 9) Note you can now transfer items Signed-off-by: Maribeth Shafer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22283] Translation file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22283 --- Comment #8 from Alex Arnaud --- (In reply to Katrin Fischer from comment #7) > Hi Alex, > > do you have time to look into this more? > > - Is this a pootle issue or are our translation tools in Koha broken? > - Are we sure it's not an old problem? The "" are not in the original > string, only added by the translation. I know that we were to avoid single > quotes around translatable strings to avoid issues with translation (French > containing single quotes), so I think this could actually be an old problem > instead of a regression, just coming to light here because of the > translation. I'd change the translation as a first step. IMHO we juste need to write in the po: "Changer les préférences de notifications à \\\"Par défaut\\\" pour cette " instead of: "Changer les préférences de notifications à \"Par défaut\" pour cette " With the first one, we keep the double quotes escaped in templates. And it works. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22283] Translation file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22283 --- Comment #7 from Katrin Fischer --- Hi Alex, do you have time to look into this more? - Is this a pootle issue or are our translation tools in Koha broken? - Are we sure it's not an old problem? The "" are not in the original string, only added by the translation. I know that we were to avoid single quotes around translatable strings to avoid issues with translation (French containing single quotes), so I think this could actually be an old problem instead of a regression, just coming to light here because of the translation. I'd change the translation as a first step. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22283] Translation file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22283 Alex Arnaud changed: What|Removed |Added CC||alex.arn...@biblibre.com --- Comment #6 from Alex Arnaud --- (In reply to Katrin Fischer from comment #5) > Hi, > > overall this sounds more like a support request (issue with > setup/installation), rather than a bug right now. > > Especially your questions from comment#4 are much better suited for the > mailing list (http://koha-community.org/support/koha-mailing-lists/), where > there will be a lot more people reading your questions. Another option is > the #koha IRC channel (http://koha-community.org/get-involved/irc/). > > You can try fix the translation by getting an account for > translate.koha-community.org. > > Also: You might want to try updating to the latest 18.11 - sometimes there > are errors in po files that are fixed by translators between bugfix I don't know how to treat this but it is sure that the french translation in po/fr-FR-staff-prog.po+17764 has double quotes escaped and this raise javascript errors when editing a patron. I'm pretty sure we lost a feature (didn't test more). This has been introduced by commit 6a815c8fdb0f9b6f2004aecea2af753cb2f1f539 (Translation updates for Koha 18.11.00) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21522] Labels incorrectly inheriting some default Bootstrap style properties
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21522 Victor Grousset/tuxayo changed: What|Removed |Added Status|ASSIGNED|In Discussion --- Comment #4 from Victor Grousset/tuxayo --- @Oleonard: Is the visual result okay for you? (attached screenshot) If so, I can try to add that in Koha's CSS to submit a patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Blocks|17702 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Depends on|20912 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 [Bug 20912] Rental fees based on time period -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Blocks||17702 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Depends on||20912 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 [Bug 20912] Rental fees based on time period -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22434] correct item callnumber search link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 --- Comment #1 from Fridolin SOMERS --- Created attachment 85879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85879=edit Bug 22434: correct item callnumber search link Many places show item callnumber as a link to a search on this callnumber. The correct way is : (opac-)search.pl?q=callnum:%22[% callnumber | uri %]%22 I propose an include that creates think search link. Patch does not create an include for OPAC since callnumber search link is only in display without XSLT which will be obsolete. It juste corrects the filtering with uri instead of url. Test plan : 1) Create an item with callnumber : AAA&1(2)3 2) Check callnumber display and search link ar OK in : 3) Intranet : perform a search in catalog search that displays this item 4) Intranet : perform a search in cataloguing serach that displays this item 5) Intranet : Create a list that displays this item 6) OPAC without XSLT : perform a search in catalog search that displays this item 7) OPAC without XSLT : perform a group search in catalog search that displays this item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22434] correct item callnumber search link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 Fridolin SOMERS changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22422] improve item location display with class "shelvingloc"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22422 Fridolin SOMERS changed: What|Removed |Added Assignee|oleon...@myacpl.org |fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22434] correct item callnumber search link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 Fridolin SOMERS changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|oleon...@myacpl.org |fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22434] New: correct item callnumber search link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 Bug ID: 22434 Summary: correct item callnumber search link Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: fridolin.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- Many places show item callnumber as a link to a search on this callnumber. The correct way is : (opac-)search.pl?q=callnum:%22[% callnumber | uri %]%22 I propose an include that creates think search link. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 --- Comment #37 from Jonathan Druart --- It seems that the code in Koha::Patrons->update_category_to must be the same as what is done in members/update-child.pl and so moved to Koha::Patron. Do not you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 --- Comment #36 from Nick Clemens --- (In reply to Martin Renvoize from comment #29) > Also... I don't like that we're very nearly duplicating the > /misc/cronjobs/j2a.pl script.. could this not be merged into that one, act > as an update to that one.? This is intended to replace that one wholesale, i added a patch to remove and we can highlight largely in the release notes > Also, many of these sorts of scripts are entirely undocumented past the > perldoc within the script.. could we have a corresponding koha-manual patch > just very quickly summarising that it's there and what it's for? I added some documentation to the release notes, this should help for updating the manual once we get this in -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Nick Clemens changed: What|Removed |Added Text to go in the||These patches introduce a release notes||new script to replace the ||j2a.pl script with a more ||flexible set of options. || ||misc/cronjobs/update_patron ||s_category.pl ||Can now be ||used to update patrons who ||are older or younger than ||theri patron categories to ||a category chosen by the ||user. || ||Additionally this ||script allows users to ||specify a fine total to ||update patrons, to use any ||specified borrowers field, ||and to run by category ||and/or branch. || ||The ||intention here is to assist ||in automating updating ||patrons for schools or ||libraries where patrons are ||regularly changed - patrons ||with fine can be moved to ||'probational statuses' or ||patrons without fines can ||be moved to 'privileged' ||statuses. || ||The flexibility ||should allow for various ||workflows to be automated ||via cronjob Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 --- Comment #35 from Nick Clemens --- Created attachment 85878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85878=edit Bug 17168: Remove j2a.pl script -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19865] Side scroll bar in z39.50 MARC view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22433] New: SIP/Transaction.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22433 Bug ID: 22433 Summary: SIP/Transaction.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Target Milestone: --- On Master_D9: koha_1 | # Failed test 'Bib has 1 holds remaining' koha_1 | # at t/db_dependent/SIP/Transaction.t line 90. koha_1 | # got: '2' koha_1 | # expected: '1' koha_1 | # Looks like you failed 1 test of 5. koha_1 | koha_1 | # Failed test 'fill_holds_at_checkout' koha_1 | # at t/db_dependent/SIP/Transaction.t line 93. koha_1 | # Looks like you failed 1 test of 4. koha_1 | [21:17:57] t/db_dependent/SIP/Transaction.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Attachment #57858|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 85876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85876=edit Bug 17702: Account types configuration - Admin page Test plan: 1) Go to admin home, note there is new Account types page in Patrons and circulation section 2) Go to any other admin page and confirm there is link to Account types in admin menu as welll 3) Go to Account types page 4) You should see two datatables, one for debit types and one for credit types, ensure the datatables are working corectly 5) Try to create, edit and delete some debit types, note, that some of them can't be deleted - they are neede for Koha internally 6) Do the same with credit types 7) Try to add some default amount to internal debits - like Acccount management fee, New card, ... 8) Go to Patron fines page and play with account type select, when you change thy account type, the description and amount should change as you set it on the admin page 9) Try to add some fees and ensure they are inserted corectly 10) Pay the inserted fees 11) Try to add manual credit and ensure it is added corectly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Attachment #58066|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 85877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85877=edit Bug 17702: Add tests Test plan: prove t/db_dependent/Koha/AccountTypes.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Attachment #57857|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize --- Created attachment 85875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85875=edit Bug 17702: Account types configuration - Manual invoice and credit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22275] 18.06.00.060 DB update fails (incomplete/incorrect defaults)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22275 --- Comment #13 from Oliver Behnke --- FYI, I'm going to sign-off via a sandbox as well, as soon as I got one set up to test this patch for real... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Attachment #57856|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 85874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85874=edit Bug 17702: Account types configuration - db changes Test plan: 1) Read the diff and confirm that it does make sense 2) Comment what does not make sense ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 --- Comment #34 from Nick Clemens --- Created attachment 85873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85873=edit Bug 17168: (follow-up) Address QA concerns and update for strict mode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 --- Comment #33 from Nick Clemens --- Created attachment 85872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85872=edit Bug 17168: (follow-up) Clean up QA errors Cleanup variable names Remove Dumper -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 --- Comment #32 from Nick Clemens --- Created attachment 85871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85871=edit Bug 17168: (follow-up) Tidy, clean params/options, use date tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Nick Clemens changed: What|Removed |Added Attachment #76974|0 |1 is obsolete|| Attachment #76975|0 |1 is obsolete|| Attachment #76976|0 |1 is obsolete|| --- Comment #31 from Nick Clemens --- Created attachment 85870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85870=edit Bug 17168: Add a command line script for updating patron category based on status This patch adds a new script update_patrons_category.pl which allows for updating patron categories in a batch upon meeting provided criteria. This script additionally can replace j2a.pl. To test: 1 - perl update_patrons_category.pl -h 2 - Ensure help text makes sense and covers all options 3 - Test converting patrons supplying only fromcat and tocat perl update_patrons_category.pl -f PT -t J -v --confirm perl update_patrons_category.pl -f J -t PT -v --confirm 4 - All patrons should have been switched to and from Juveniles 5 - Try without --confirm switch perl update_patrons_category.pl -f PT -t J -v 6 - Should list all patrons but not update 7 - Set the age for juvenile patrons to be outside the range provided in categories (or set the upper age limit for juveniles to '2') 8 - Test with verbosity and with without --confirm perl update_patrons_category.pl -f J -a -t PT -v perl update_patrons_category.pl -f J -a -t PT -v --confirm 9 - Repeat above and verify linked/unlinked guarantors are removed in above scenario 10 - Test various fine and registration limits 11 - Test matching on specific fields i.e. --field surname=acosta 12 - Sign off Sponsored by: Round Rock Public Library (https://www.roundrocktexas.gov/departments/library/) Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18589] Show ILLs as part of patron profile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood changed: What|Removed |Added Blocks||21460 Depends on|21460 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460 [Bug 21460] Filtering ILL requests on borrowernumber does not work -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21460] Filtering ILL requests on borrowernumber does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460 Andrew Isherwood changed: What|Removed |Added Depends on||18589 Blocks|18589 | --- Comment #23 from Andrew Isherwood --- I actually think this bug should depend on 18589 rather than 18589 depend on it. 18589 is at the top of the current QA tree and it makes sense for anything ILL related to be based on it since there are still some significant changes in the pending QA queue that will conflict badly with anything that touches ill-requests.tt. I'll change the dependency accordingly and we can revisit this once 18589 is PQA Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 [Bug 18589] Show ILLs as part of patron profile -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21213] Circulation.t needs diagnostics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21213
--- Comment #8 from Jonathan Druart
---
It failed on last run!
koha_1 | # Failed test 'AddReturn must have debarred the patron'
koha_1 | # at t/db_dependent/Circulation.t line 2976.
koha_1 | # got: ''
koha_1 | # expected: '1'
koha_1 | # AddReturn returned message $VAR1 = {
koha_1 | # 'WasReturned' => 1
koha_1 | # };
koha_1 |
koha_1 | # Failed test 'Test at line 1845'
koha_1 | # at t/db_dependent/Circulation.t line 2980.
koha_1 | # got: '0'
koha_1 | # expected: '1'
koha_1 |
koha_1 | # Failed test 'Test at line 1845'
koha_1 | # at t/db_dependent/Circulation.t line 2983.
koha_1 | # got: undef
koha_1 | # expected: '2019-03-13'
koha_1 | # Looks like you failed 3 tests of 21.
koha_1 |
koha_1 | # Failed test 'AddReturn + suspension_chargeperiod'
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18583] Add the ability to merge multiple authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18583 --- Comment #1 from Marjorie Barry-Vila --- +1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 --- Comment #25 from Jonathan Druart --- (In reply to Koha Team Lyon 3 from comment #24) > In my opinion, if suspension_chargeperiod = 2, we should not charge on the > first day... but, I'm not sure of the behaviour in the current version of > Koha. Did not test neither remember. But my feeling is that: if you are late, you pay. If you do not want this behavior you could use the grace. Before continuing on this maybe we should ask on the list? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 Andrew Isherwood changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #35 from Andrew Isherwood --- (In reply to Josef Moravec from comment #33) > Created attachment 85855 [details] > Ill request list > > The table has some minor rendering issues. These should now be fixed > Also, why to have three columns for patron identity? We had different customers asking for different fields (for sorting and filtering), so it was easiest just to include all three, then they can be turned on or off as needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #34 from Andrew Isherwood --- Created attachment 85869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85869=edit Bug 21063: (follow-up) Fix rebase problems A couple of minor rebase problems resolved -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19865] Side scroll bar in z39.50 MARC view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 --- Comment #1 from Marjorie Barry-Vila --- +1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Delegate background jobs execution
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #14 from Jonathan Druart --- There is also: "Going further: 2. Provide a koha-worker script to consume the jobs" So one worker per instance. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Delegate background jobs execution
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417
--- Comment #13 from Jonathan Druart
---
(In reply to Tomás Cohen Arazi from comment #12)
> I agree with David that this of course would require a single RabbitMQ
> server so questions: Is there a concept of namespaces? can any Koha instance
> access other instance's messages?
I really would like you guys to apply, read and try the patches, read the code,
then discuss :)
There are a lot of FIXME and TODO.
This one answers your question:
16 sub connect {
17 my ( $self );
18 my $conn = Net::RabbitFoot->new()->load_xml_spec()->connect(
19 host => 'localhost', # TODO Move this to KOHA_CONF
20 port => 5672,
21 user => 'guest',
22 pass => 'guest',
23 vhost => '/',
24 );
25
26 return $conn;
27 }
So different vhost, user and pass can be used.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 --- Comment #30 from Owen Leonard --- > File not found : lib/jquery/plugins/jquery.rating.js at > /home/vagrant/kohaclone/Koha/Template/Plugin/Asset.pm line 83. I have submitted Bug 22432 for this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 Owen Leonard changed: What|Removed |Added Blocks||22432 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22432 [Bug 22432] Star ratings plugin replacement missing from a couple pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22432] New: Star ratings plugin replacement missing from a couple pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22432 Bug ID: 22432 Summary: Star ratings plugin replacement missing from a couple pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: bibli...@gmail.com, di...@calyx.net.au, jonathan.dru...@bugs.koha-community.org, katrin.fisc...@bsz-bw.de, martin.renvo...@ptfs-europe.com, m...@kohaaloha.com, n...@bywatersolutions.com, pierre-marc.thiba...@inlibro.com, testo...@bugs.koha-community.org Depends on: 10659 Target Milestone: --- The upgrade of the star ratings plugin missed a couple of pages: Overdrive search results and Recorded Books search results. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 [Bug 10659] Upgrade jQuery star ratings plugin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22206] Add route to handle holds suspensions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 --- Comment #19 from Josef Moravec --- More testing is always fine, and I even forget to add my sign-off line last time, fixed now ;) Thanks for quick follow-up Tomas -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22206] Add route to handle holds suspensions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Josef Moravec changed: What|Removed |Added Attachment #85471|0 |1 is obsolete|| --- Comment #17 from Josef Moravec --- Created attachment 85867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85867=edit Bug 22206: (QA follow-up) Fix tests for hold suspension api Test plan: prove t/db_dependent/api/v1/holds.t Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22206] Add route to handle holds suspensions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Josef Moravec changed: What|Removed |Added Attachment #85468|0 |1 is obsolete|| --- Comment #14 from Josef Moravec --- Created attachment 85864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85864=edit Bug 22206: OpenAPI spec Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22206] Add route to handle holds suspensions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206
Josef Moravec changed:
What|Removed |Added
Attachment #85470|0 |1
is obsolete||
--- Comment #16 from Josef Moravec ---
Created attachment 85866
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85866=edit
Bug 22206: Add routes to suspend/resume holds
This patch introduces:
- POST /holds/{hold_id}/suspension { "expiration_date": "2019-01-30" }
- DELETE /holds/{hold_id}/suspension
to suspend a hold or resume a suspended hold, respectively.
To test:
- Apply this patches
- Run:
$ kshell
k$ prove t/db_dependent/api/v1/holds.t
=> SUCCESS: Tests pass!
- Sign off :-D
Signed-off-by: Martin Renvoize
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22206] Add route to handle holds suspensions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Josef Moravec changed: What|Removed |Added Attachment #85862|0 |1 is obsolete|| --- Comment #18 from Josef Moravec --- Created attachment 85868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85868=edit Bug 22206: (follow-up) Voted RFC changes This patch changes expiration_date for end_date as voted when the RFC was approved. It also adds a test for the Location header being added correctly when suspending a hold (SWAGGER3.4.1) Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22206] Add route to handle holds suspensions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Josef Moravec changed: What|Removed |Added Attachment #85469|0 |1 is obsolete|| --- Comment #15 from Josef Moravec --- Created attachment 85865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85865=edit Bug 22206: Unit tests Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22246] Elasticsearch indexing needs a maximum length for __sort fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22246 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA CC||josef.mora...@gmail.com QA Contact||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22246] Elasticsearch indexing needs a maximum length for __sort fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22246 Josef Moravec changed: What|Removed |Added Attachment #84626|0 |1 is obsolete|| --- Comment #4 from Josef Moravec --- Created attachment 85863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85863=edit Bug 22246: Fix indexing of large fields with Elasticsearch Deduplicate multivalued fields and make sure sort fields are not excessively long. Also updates default mappings so that sort fields are not created for item fields where it doesn't make sense. Test plan: 1. Reset ES mappings in administration 2. Check that sort is '0' for local-classification in biblio mappings. 3. Change sort back to '1' for local-classification for the next steps. 4. Create a record with 20 items, each with a 100 character long call number 5. Check that when indexed, the record in ES does not have duplicates in any of the item fields and local-classification__sort is truncated to 255 characters. Signed-off-by: Nick Clemens Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13897] Use XML files for installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 --- Comment #26 from Tomás Cohen Arazi --- I've just rebased it to current master (conflict in parameters.json after /libraries got pushed). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22206] Add route to handle holds suspensions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Tomás Cohen Arazi changed: What|Removed |Added Status|BLOCKED |Passed QA CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22206] Add route to handle holds suspensions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 --- Comment #13 from Tomás Cohen Arazi --- Created attachment 85862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85862=edit Bug 22206: (follow-up) Voted RFC changes This patch changes expiration_date for end_date as voted when the RFC was approved. It also adds a test for the Location header being added correctly when suspending a hold (SWAGGER3.4.1) Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
