[Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule

2019-03-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489

Hayley Mapley  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |hayleymap...@catalyst.net.n
   |ity.org |z

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22489] New: Onboarding tool fails due to inserting maxissueqty into IssuingRule

2019-03-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489

Bug ID: 22489
   Summary: Onboarding tool fails due to inserting maxissueqty
into IssuingRule
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Installation and upgrade (web-based installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: hayleymap...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
  Target Milestone: ---

When going through the onboarding process, the  tool fails on submit of Step 5
- creating an issuing rule. This is due to the maxissueqty column having been
removed from the IssuingRules table and added to the CirculationRules table but
redundant code still exists in onboarding.pl. As you can see below the
maxissueqty variable is being added to the params hash which is used to make
the new issuing rule.

if ( $step == 5 ) {

if ( $op eq 'add_validate_circ_rule' ) {

#If no libraries exist then set the $branch value to *
my $branch = $input->param('branch') || '*';

my $type= $input->param('type');
my $branchcode  = $input->param('branch');
my $categorycode= $input->param('categorycode');
my $itemtype= $input->param('itemtype');
my $maxissueqty = $input->param('maxissueqty');
my $issuelength = $input->param('issuelength');
my $lengthunit  = $input->param('lengthunit');
my $renewalsallowed = $input->param('renewalsallowed');
my $renewalperiod   = $input->param('renewalperiod');
my $onshelfholds= $input->param('onshelfholds') || 0;
$maxissueqty =~ s/\s//g;
$maxissueqty = undef if $maxissueqty !~ /^\d+/;
$issuelength = $issuelength eq q{} ? undef : $issuelength;

my $params = {
branchcode  => $branchcode,
categorycode=> $categorycode,
itemtype=> $itemtype,
 maxissueqty => $maxissueqty,
renewalsallowed => $renewalsallowed,
renewalperiod   => $renewalperiod,
issuelength => $issuelength,
lengthunit  => $lengthunit,
onshelfholds=> $onshelfholds,
};

my $issuingrule = Koha::IssuingRule->new($params);
eval { $issuingrule->store; };

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch

2019-03-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985

--- Comment #6 from Hayley Mapley  ---
(In reply to Hayley Mapley from comment #5)
> Before applying the patch, I get this error when trying to prove those tests:
> 
> t/db_dependent/Circulation.t .. 61/126 DBD::mysql::st execute failed:
> Duplicate entry '10' for key 'PRIMARY' [for Statement "INSERT INTO
> `old_issues` ( `auto_renew`, `auto_renew_error`, `borrowernumber`,
> `branchcode`, `date_due`, `issue_id`, `issuedate`, `itemnumber`,
> `lastreneweddate`, `note`, `notedate`, `noteseen`, `onsite_checkout`,
> `renewals`, `returndate`, `timestamp`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?,
> ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0=0, 1=undef, 2=54, 3='bWmeAOZip',
> 4='2019-03-25 23:59:00', 5=10, 6='2019-03-11 03:36:44', 7=991, 8=undef,
> 9=undef, 10=undef, 11=undef, 12=0, 13=undef, 14='2019-03-11 03:36:47',
> 15='2019-03-11 03:36:47'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line
> 1836.
> {UNKNOWN}: Can't locate object method "rethrow" via package "DBD::mysql::st
> execute failed: Duplicate entry '10' for key 'PRIMARY' [for Statement
> "INSERT INTO `old_issues` ( `auto_renew`, `auto_renew_error`,
> `borrowernumber`, `branchcode`, `date_due`, `issue_id`, `issuedate`,
> `itemnumber`, `lastreneweddate`, `note`, `notedate`, `noteseen`,
> `onsite_checkout`, `renewals`, `returndate`, `timestamp`) VALUES ( ?, ?, ?,
> ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0=0, 1=undef,
> 2=54, 3='bWmeAOZip', 4='2019-03-25 23:59:00', 5=10, 6='2019-03-11 03:36:44',
> 7=991, 8=undef, 9=undef, 10=undef, 11=undef, 12=0, 13=undef, 14='2019-03-11
> 03:36:47', 15='2019-03-11 03:36:47'] at
> /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.
> " (perhaps you forgot to load "DBD::mysql::st execute failed: Duplicate
> entry '10' for key 'PRIMARY' [for Statement "INSERT INTO `old_issues` (
> `auto_renew`, `auto_renew_error`, `borrowernumber`, `branchcode`,
> `date_due`, `issue_id`, `issuedate`, `itemnumber`, `lastreneweddate`,
> `note`, `notedate`, `noteseen`, `onsite_checkout`, `renewals`, `returndate`,
> `timestamp`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with
> ParamValues: 0=0, 1=undef, 2=54, 3='bWmeAOZip', 4='2019-03-25 23:59:00',
> 5=10, 6='2019-03-11 03:36:44', 7=991, 8=undef, 9=undef, 10=undef, 11=undef,
> 12=0, 13=undef, 14='2019-03-11 03:36:47', 15='2019-03-11 03:36:47'] at
> /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.
> "?) at /home/vagrant/kohaclone/Koha/Object.pm line 185. at
> /home/vagrant/kohaclone/C4/Circulation.pm line 2206
> # Looks like your test exited with 255 just after 71.
> t/db_dependent/Circulation.t .. Dubious, test returned 255 (wstat 65280,
> 0xff00)
> Failed 55/126 subtests 
> 
> Test Summary Report
> ---
> t/db_dependent/Circulation.t (Wstat: 65280 Tests: 71 Failed: 0)
>   Non-zero exit status: 255
>   Parse errors: Bad plan.  You planned 126 tests but ran 71.
> Files=1, Tests=71,  7 wallclock secs ( 0.03 usr  0.01 sys +  3.42 cusr  0.38
> csys =  3.84 CPU)
> Result: FAIL
> 
> And the patch does not apply:
> Applying: Bug 21985: Fix Circulation tests when ES it set, by using
> build_sample_item
> error: sha1 information is lacking or useless (t/db_dependent/Circulation.t).
> error: could not build fake ancestor
> Patch failed at 0001 Bug 21985: Fix Circulation tests when ES it set, by
> using build_sample_item

Actually reading this error, I see that it's an issue with the DB, which I will
fix and then try again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch

2019-03-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985

Hayley Mapley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #5 from Hayley Mapley  ---
Before applying the patch, I get this error when trying to prove those tests:

t/db_dependent/Circulation.t .. 61/126 DBD::mysql::st execute failed: Duplicate
entry '10' for key 'PRIMARY' [for Statement "INSERT INTO `old_issues` (
`auto_renew`, `auto_renew_error`, `borrowernumber`, `branchcode`, `date_due`,
`issue_id`, `issuedate`, `itemnumber`, `lastreneweddate`, `note`, `notedate`,
`noteseen`, `onsite_checkout`, `renewals`, `returndate`, `timestamp`) VALUES (
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0=0,
1=undef, 2=54, 3='bWmeAOZip', 4='2019-03-25 23:59:00', 5=10, 6='2019-03-11
03:36:44', 7=991, 8=undef, 9=undef, 10=undef, 11=undef, 12=0, 13=undef,
14='2019-03-11 03:36:47', 15='2019-03-11 03:36:47'] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.
{UNKNOWN}: Can't locate object method "rethrow" via package "DBD::mysql::st
execute failed: Duplicate entry '10' for key 'PRIMARY' [for Statement "INSERT
INTO `old_issues` ( `auto_renew`, `auto_renew_error`, `borrowernumber`,
`branchcode`, `date_due`, `issue_id`, `issuedate`, `itemnumber`,
`lastreneweddate`, `note`, `notedate`, `noteseen`, `onsite_checkout`,
`renewals`, `returndate`, `timestamp`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?,
?, ?, ?, ?, ?, ? )" with ParamValues: 0=0, 1=undef, 2=54, 3='bWmeAOZip',
4='2019-03-25 23:59:00', 5=10, 6='2019-03-11 03:36:44', 7=991, 8=undef,
9=undef, 10=undef, 11=undef, 12=0, 13=undef, 14='2019-03-11 03:36:47',
15='2019-03-11 03:36:47'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line
1836.
" (perhaps you forgot to load "DBD::mysql::st execute failed: Duplicate entry
'10' for key 'PRIMARY' [for Statement "INSERT INTO `old_issues` ( `auto_renew`,
`auto_renew_error`, `borrowernumber`, `branchcode`, `date_due`, `issue_id`,
`issuedate`, `itemnumber`, `lastreneweddate`, `note`, `notedate`, `noteseen`,
`onsite_checkout`, `renewals`, `returndate`, `timestamp`) VALUES ( ?, ?, ?, ?,
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0=0, 1=undef, 2=54,
3='bWmeAOZip', 4='2019-03-25 23:59:00', 5=10, 6='2019-03-11 03:36:44', 7=991,
8=undef, 9=undef, 10=undef, 11=undef, 12=0, 13=undef, 14='2019-03-11 03:36:47',
15='2019-03-11 03:36:47'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line
1836.
"?) at /home/vagrant/kohaclone/Koha/Object.pm line 185. at
/home/vagrant/kohaclone/C4/Circulation.pm line 2206
# Looks like your test exited with 255 just after 71.
t/db_dependent/Circulation.t .. Dubious, test returned 255 (wstat 65280,
0xff00)
Failed 55/126 subtests 

Test Summary Report
---
t/db_dependent/Circulation.t (Wstat: 65280 Tests: 71 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 126 tests but ran 71.
Files=1, Tests=71,  7 wallclock secs ( 0.03 usr  0.01 sys +  3.42 cusr  0.38
csys =  3.84 CPU)
Result: FAIL

And the patch does not apply:
Applying: Bug 21985: Fix Circulation tests when ES it set, by using
build_sample_item
error: sha1 information is lacking or useless (t/db_dependent/Circulation.t).
error: could not build fake ancestor
Patch failed at 0001 Bug 21985: Fix Circulation tests when ES it set, by using
build_sample_item

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21130] Detail XSLT produces translatable HTML class

2019-03-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21130

Hayley Mapley  changed:

   What|Removed |Added

  Attachment #79110|0   |1
is obsolete||

--- Comment #9 from Hayley Mapley  ---
Created attachment 86421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86421=edit
Bug 21130: (Follow up OPAC Results) Prevent HTML class from being translated

This fixes the same issue where "title" is being translated (in fr-CA at least)
and thus
break the javascript impacting the result display in the OPAC

Signed-off-by: Hayley Mapley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21130] Detail XSLT produces translatable HTML class

2019-03-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21130

Hayley Mapley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch

2019-03-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985

--- Comment #4 from Hayley Mapley  ---
(In reply to Katrin Fischer from comment #3)
> Hi Hayley, there is a system preference SearchEngine you can switch between
> Zebra and Elasticsearch. Depending on what you use for testing there might
> be more steps needed, in a kohadevbox you should be ok with switching the
> pref and doing a reindex. The script for reindexing Elasticsearch can be run
> using koha-shell and is in misc.

Thank you Katrin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update

2019-03-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645

--- Comment #19 from Aleisha Amohia  ---
Fixed merge conflicts, now looking at Comment 17

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update

2019-03-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #69471|0   |1
is obsolete||

--- Comment #18 from Aleisha Amohia  ---
Created attachment 86420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86420=edit
Bug 18645: Koha feature release change tool

This tool is displayed at the end of the update process to display all
the new system preferences added during the update so that the
administrator can view and modify their default values if neccessary

The administrator also has the ability to skip the feature release tool on the
update
process and it will be displayed to the next superlibrarian user that
logs in. Because librarian staff are likely to be more familiar with the
system preference settings that a library would want to set than an IT
support administrator

Test plan:
1. Go to Administrator->global system preferences->Local use

2. Set the version number to 16.120033 (Note: only 1 decimal place) and
save

3. Go through the update process and notice that after submitting the
'Update database structure' page you are prompted to login and the main
page appears if you logged in with the correct credentials

4. Apply patch

5. Repeat steps 1 and 2

6. Notice the button text on the 'Update database structure' page has
changed and now it says 'Continue to feature release tool'

7. Notice there is also a skip button. Click the skip button and notice
you are redirected to the staff intranet login page.

8. Login with the Koha db administrator credentials and notice that the
Koha main page is displayed

9. Logout and enter superlibrarian user credentials and submit the login
form

10. Notice you are redirected to the Koha web installer login page

11. Login with the Koha db administrator credentials

12. Notice the feature release change tool is displayed

13. Alter the NumSavedReports and the
TalkingTechItivaPhoneNotification values and select the 'Save all
preferences' button

14. Query the values of these two sysprefs in the systempreferences
database table and notice they have been changed to what you submitted

15. Click the 'Log into Koha staff intranet' button

16. Notice the intranet login page appears

17. Login and the main page will be displayed

18. Repeat steps 1,2 and click the 'Continue to feature release tool'
button

19. Notice the feature release tool is displayed and repeat steps 13 and
14

20. Click the 'Log into Koha staff intranet' button, login as either
Koha db administrator or as a superlibrarian (it doesn't matter which
you log in as) and the Koha staff intranet mainpage will be displayed

21. Log out and then log back in again and notice the staff intranet is
still displayed. Note you are not redirected to the Koha web installer
login page to go through the feature release change tool because you
have already gone through it

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update

2019-03-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz
 Status|Failed QA   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22481] Koha::Uploader does not work under Plack

2019-03-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22481

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22188] Use publication date as numbering pattern

2019-03-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch

2019-03-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
Hi Hayley, there is a system preference SearchEngine you can switch between
Zebra and Elasticsearch. Depending on what you use for testing there might be
more steps needed, in a kohadevbox you should be ok with switching the pref and
doing a reindex. The script for reindexing Elasticsearch can be run using
koha-shell and is in misc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22188] Use publication date as numbering pattern

2019-03-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188

--- Comment #10 from Aleisha Amohia  ---
(In reply to Séverine Queune from comment #5)
> > 9) You should now be on the subscription detail page for your new
> > subscription. Go to the Planning tab and confirm that it says 'uses
> > publication date' under Number pattern and that there is now table
> > saying 'Starting with' and 'Rollover'
> 
> Ok for 'Number pattern: Uses publication date', but I don't see the table.
> 

Sorry I forgot to fix my test plan - this table does not show if using
publication date pattern. It will show for all other number patterns.

This should be ready to test again now!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22188] Use publication date as numbering pattern

2019-03-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188

--- Comment #9 from Aleisha Amohia  ---
Created attachment 86419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86419=edit
Bug 22188: (follow-up) Introducing dateformat field and other fixes

To test with this patch, please update the database and update the
schema.

With this patch, you can now choose the dateformat of the date pattern
by editing the subscription. This information is now saved in the DB
subscription table.

This patch also fixes previous problems with receiving and generating
the next serial.

Sponsored-by: Brimbank Libraries Australia

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22188] Use publication date as numbering pattern

2019-03-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21658] Renew requests fail if a fee attached

2019-03-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21658

Hayley Mapley  changed:

   What|Removed |Added

 CC||hayleymap...@catalyst.net.n
   ||z

--- Comment #7 from Hayley Mapley  ---
Hi, is there a test plan for this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch

2019-03-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985

Hayley Mapley  changed:

   What|Removed |Added

 CC||hayleymap...@catalyst.net.n
   ||z

--- Comment #2 from Hayley Mapley  ---
(In reply to Jonathan Druart from comment #1)
> Created attachment 83254 [details] [review]
> Bug 21985: Fix Circulation tests when ES it set, by using build_sample_item
> 
> We should use build_sample item (from bug 21971) to create items,
> otherwise we may not have a valid biblioitem and/or MARC record.
> 
> Test plan:
> Set SearchEngine to ES
> prove that the tests in Circulation.t now pass

Hi, could you please provide a more detailed description for the test step 'set
SearchEngine to ES'?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22479] Unnecessary translation occurs when adding a new serial subscription

2019-03-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22479

Hayley Mapley  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #2 from Hayley Mapley  ---
(In reply to Katrin Fischer from comment #1)
> Hi Hayley, I think these come from your database. Check serials > Manage
> frequencies.

Thanks Katrin, they are indeed coming from my database.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21953] Term "Lost item" untranslatable

2019-03-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953

Hayley Mapley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21953] Term "Lost item" untranslatable

2019-03-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953

Hayley Mapley  changed:

   What|Removed |Added

  Attachment #86406|0   |1
is obsolete||

--- Comment #13 from Hayley Mapley  ---
Created attachment 86418
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86418=edit
Bug 21953: Update existing rows in DB

Signed-off-by: Hayley Mapley 
Test plan passes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22487] Add Mana and Bugzilla components on bugzilla

2019-03-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22487

--- Comment #2 from Katrin Fischer  ---
Hi Jonathan,

yes, Project infrastructure > Bugzilla

For Mana I was thinking of the code outside of Koha. Not sure how to handle
that best. I wanted to report 'improve the email sent by Mana' (bug 22488)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22487] Add Mana and Bugzilla components on bugzilla

2019-03-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22487

--- Comment #1 from Jonathan Druart  
---
About Bugzilla: "Project infrastructure > Bugzilla" ?

About Mana: "Koha > Mana" (i.e. Mana code integreated to Koha) or you are
talking about the server code?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/