[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985

--- Comment #2 from Arthur Suzuki  ---
Created attachment 86874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86874&action=edit
Bug 20985 : Add OnShelfHoldsAllowed checks to CanItemBeReserved

Test plan :
1 / Check that default circulation have OnShelfHoldsAllowed to Yes
2 / Place a hold on a book with a single item, item being available for loan,
verify that hold can be placed.
3 / Set OnShelfHoldsAllowed to any other value, verify that hold cannot be
placed for reason "onShelfHoldsNotAllowed" (shown in the item table).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985

Arthur Suzuki  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |arthur.suz...@biblibre.com
   |ity.org |
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #40 from Björn Nylén  ---
Hi!

We also tested the patch and can't remove the search field according to your
instructions. If I save the mappings first it works ok. Tested in FF and Chrome

After a quick look it seems the newly created mappings is missing the onclick
event to enable the delete button on the search field-tab.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #33 from Marcel de Rooy  ---
QA: Looking here now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22533] Cannot create manual invoices

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533

--- Comment #7 from Martin Renvoize  ---
Thanks Marcel, I just didn't get a chance to do the final qa on this yesterday
with meetings.. nice to come to it this morning and see you've stepped into the
breach.. Go Team! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #84389|0   |1
is obsolete||

--- Comment #34 from Marcel de Rooy  ---
Created attachment 86875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86875&action=edit
Bug 17385: Add custom export XSLT

Patch was corrected and rebased after QA feedback. Previous patches where
combined into this one.

- Empty READMEs have been deleted
- Whitespaces changes to unrelated code have been undone
* CustomXSLTExportList now uses LibXML to figure out the title and output
* The custom export XSLT's title should be an attribute to the root node,
otherwise it will default to filename
- Duplicate $xslFile param was removed from XSLTParse4Display
* Improvment to code structure in XSLTParse4Display
* Some fixes to calls to AddBiblio()

Test case:
  - Apply patch
  - Visit an item's detail page in the OPAC or the staff interface
  - Click save and you found Simple Export.
  - Click Simple Export and you have a file.html, it contain informations
returned by the xslt file.
  - It work correctly in basket and lists.

The patch comes with sample XSLT files
  for Intranet the xsl file is :
koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport/MARC21_simple_export.xsl
  for opac the xsl file is :
koha-tmpl/opac-tmpl/bootstrap/en/xslt/biblioexport/MARC21_simple_export.xsl

Followed test plan, patch works as described. Also ran QA test tools and
modified files pass

Signed-off-by: Alex Buckley 
Signed-off-by: Cori Lynn Arnold 
https://bugs.koha-community.org/show_bug.cgi?id=17835

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

--- Comment #36 from Marcel de Rooy  ---
Created attachment 86877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86877&action=edit
Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder

Performance: We need to return an empty list if OpacExportOptions does not
contain Custom.  No need to scan the directory for custom files, if we are not
using them at all.

Test plan:
Run t/db_dependent/XSLT.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

--- Comment #37 from Marcel de Rooy  ---
Created attachment 86878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86878&action=edit
Bug 17385: (QA follow-up) Add caching

Performance: We should add caching in CustomXSLTExportList.

Test plan:
Run t/db_dependent/XSLT.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #84390|0   |1
is obsolete||

--- Comment #35 from Marcel de Rooy  ---
Created attachment 86876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86876&action=edit
Bug 17385: Add tests for CustomXSLTExportList

+ Added tests for CustomXSLTExportList to C4::XSLT
+ Added an eval block in CustomXSLTExportList to handle invalid XML.

* Removed Opac parameter, but now handle "OPACXSLTCustomExport" as equivalent

+ Added "Custom" option to OPACExportOptions preference.

Tested with invalid XML (not originally on purpose, but...) and then
added a new field to add to the simple export.

Walked through the testing steps.

Question: should this also apply to the cataloging page as an export
option? It doesn't now.

Signed-off-by: Cori Lynn Arnold 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |Passed QA

--- Comment #38 from Marcel de Rooy  ---
QA Comment:
Thanks for your perseverance, guys. This took quite some time.
Since the Custom option is not checked by default, I do not see a problem
pushing this in its current form. 

[1] We need to return an empty list if OpacExportOptions does not contain
Custom.  No need to scan the directory for custom files, if we are not using
them at all.
=> See follow-up.
[2] We should add caching in CustomXSLTExportList.
=> See second follow-up.
[3] The example xslt perhaps should be renamed (as mentioned before earlier).
If you would only check for the .xsl extension, we could add a README and
rename the extension of the simple export sample. Since it is pref controlled
now, this may be done later imo. No blocker for me.
[4] t/XSLT.t depends on a pref, so on the database. Should imo be moved to
dependent. Removing Test::DBIx::Class :) No blocker, maybe later ?
[5] I personally do not like using LibXML to parse the filename and format from
the xsl file. And was just thinking about adding a small json or yaml file to
do the same? No blocker, maybe later..

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Passed QA   |BLOCKED

--- Comment #39 from Marcel de Rooy  ---
Hmm. One small thing still..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #86877|0   |1
is obsolete||

--- Comment #40 from Marcel de Rooy  ---
Created attachment 86879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86879&action=edit
Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder

Performance: We need to return an empty list if OpacExportOptions does not
contain Custom.  No need to scan the directory for custom files, if we are not
using them at all.

Note: The test only pertains to OPAC now, since the pref should not control
intranet behavior. We have no intranet counterpart. See further next follow-up.

Test plan:
Run t/db_dependent/XSLT.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #86878|0   |1
is obsolete||

--- Comment #41 from Marcel de Rooy  ---
Created attachment 86880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86880&action=edit
Bug 17385: (QA follow-up) Add caching

Performance: We should add caching in CustomXSLTExportList.

Note: This resolves the lack of an intranet test in the former patch too.

Test plan:
Run t/db_dependent/XSLT.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |Passed QA

--- Comment #42 from Marcel de Rooy  ---
Obviously, we needed two cache keys.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13735] Item form in serials module doesn't respect max length set in the frameworks

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735

Marcel de Rooy  changed:

   What|Removed |Added

Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13735] Item form in serials module doesn't respect max length set in the frameworks

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13735] Item form in serials module doesn't respect max length set in the frameworks

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #7 from Marcel de Rooy  ---
(In reply to Martin Renvoize from comment #6)
> With my QA hat on.. I don't think we should require a test here.. the code
> is hideously integrated and a test would end up being more complicated than
> the fix itself..  When it comes to refactoring this into Koha:: we will need
> lots of tests to cover these routines, spreading from integrations ui tests
> down to module unit tests.
> 
> Just my opinion for the next QAer to come along.

Yeah, no problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13735] Item form in serials module doesn't respect max length set in the frameworks

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13735] Item form in serials module doesn't respect max length set in the frameworks

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #85019|0   |1
is obsolete||

--- Comment #8 from Marcel de Rooy  ---
Created attachment 86881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86881&action=edit
Bug 13735: Update PrepareItemrecordDisplay to use maxlength

The PrepareItemrecordDisplay method used to generate the item
display on receiving serials was using a hardcoded maxlength
of 255 on input fields. This patch updates it to use the
maxlength defined in the frameworks instead as the normal
item form does.

To test:
- Create or reuse an existing subscription
- Make note of the framework the record uses
- Add an item on receive
- Check the maxlength on the various fields is set to 255
  (check source code or use developer tools)
- You can also verify that by adding a long note to
  one of the note fields
- Apply patch
- Repeat tests, the maxlength should now be 
- In your framework settings, change the length of one
  of the subfields to another value
- Verify that the item form reflects the change

Signed-off-by: Martin Renvoize 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #86168|0   |1
is obsolete||

--- Comment #40 from Marcel de Rooy  ---
Comment on attachment 86168
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86168
Bug 12159: (QA follow-up) Silencing POD warn from qa tools

No longer needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22461] Regression in #20287: LDAP user replication broken with mapped extended patron attributes

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461

Oliver Behnke  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #8 from Oliver Behnke  ---
Almost:

"Global symbol "%data" requires explicit package name (did you forget to
declare "my %data"?) at /usr/share/koha/lib/C4/Auth_with_ldap.pm line 228"

The original indeed declares that at [5] and adding that line right above "my
@columns" does work for me. But I'm no perl expert, so I have to leave the fix
to you.

That aside, it seems the patch isn't yet complete as I get the following error
when replicating a new user from LDAP:

"{UNKNOWN}: DBIC result _type  isn't of the _type Category at
/usr/share/perl5/DBIx/Class/Storage/BlockRunner.pm line 130. at
/usr/share/koha/lib/Koha/Patron.pm line 288"

Cheers


FWIW, I propose to remove line 449 at [6] (or replace it with a more suitable
comment) as we now know that, yes, that check is indeed vital :-)

[5]
https://github.com/Koha-Community/Koha/blob/1b13c453e20e47c5e25bd946b50dd3838e29c3ce/C4/Members.pm#L396

[6]
https://github.com/Koha-Community/Koha/blob/1b13c453e20e47c5e25bd946b50dd3838e29c3ce/C4/Members.pm#L449

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19588] There is no ILL requests history

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19588

C Hofstede  changed:

   What|Removed |Added

 CC||chloe.hofst...@educampus.ie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #41 from Marcel de Rooy  ---
QA Comment:
Saw this warning once:
Argument "" isn't numeric in numeric gt (>) at
/usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc
line 84.

False warning from qa tools:
Koha/Patron/Attribute.pm
critic/forbidden patterns: forbidden pattern: Warning: The 'sub type' may be
wrong is declared in a Koha::* package (see bug 15446) (line 127)

A dumb question:
+ return Koha::Patron::Attributes->search({
+borrowernumber => $self->borrowernumber,
+branchcode => $self->branchcode,
+});
=> Is the branchcode needed?

Koha/Patron/Attribute.pm L114
return $av->next->lib if $av->count
Amended: adding a semicolon for future ease.

Koha/Schema/Result/BorrowerAttribute.pm 
=> Please do not add DBIx schema files in a regular patch. I removed it now.
Btw it seems no longer necessary if we rename the relation in the Koha object.
See follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #86167|0   |1
is obsolete||

--- Comment #43 from Marcel de Rooy  ---
Created attachment 86883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86883&action=edit
Bug 12159: Add tests

Test plan:
prove t/db_dependent/Koha/Patron/Attributes.t t/db_dependent/Koha/Patrons.t

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #45 from Marcel de Rooy  ---
Created attachment 86885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86885&action=edit
Bug 12159: (QA follow-up) Remove double use module

Speaks for itself.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #86166|0   |1
is obsolete||

--- Comment #42 from Marcel de Rooy  ---
Created attachment 86882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86882&action=edit
Bug 12159: Fix getting extended patron attributes for circ-menu

Changes:
- Replace getting preference ExtendedPatronAttributes by Koha.Preference
in templates
- Add Koha::Patron->attributes for getting patrons extended attributes
- Use this method in circ-menu.inc
- Remove getting attributes from members perl scripts

Test plan:
0) Apply the patch
1) Add some patron attributes type - with free text, authorised value,
limited by libraries...
2) Add some values to this attributes for some patrons
3) Go through as many patron pages as you can and confirm that
attributes are shown at side panel when they shoul and are not shown
when they should not be shown

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Marcel de Rooy 
[EDIT] Removed Koha/Schema/Result/BorrowerAttribute.pm
[EDIT] Added missing semicolon on L114 in Koha/Patron/Attribute.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #44 from Marcel de Rooy  ---
Created attachment 86884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86884&action=edit
Bug 12159: (QA follow-up) Rename relation in Patron::Attributes

It seems that we do not need the extra belongs_to in the schema result
files if we rename the relation to code.

Test plan:
Run t/db_dependent/Koha/Patrons.t
Run t/db_dependent/Koha/Patron/Attributes.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21130] Detail XSLT produces translatable HTML class

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21130

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #86421|0   |1
is obsolete||

--- Comment #11 from Marcel de Rooy  ---
Created attachment 86887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86887&action=edit
Bug 21130: (Follow up OPAC Results) Prevent HTML class from being translated

This fixes the same issue where "title" is being translated (in fr-CA at least)
and thus
break the javascript impacting the result display in the OPAC

Signed-off-by: Hayley Mapley 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21130] Detail XSLT produces translatable HTML class

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21130

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21130] Detail XSLT produces translatable HTML class

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21130

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #77321|0   |1
is obsolete||

--- Comment #10 from Marcel de Rooy  ---
Created attachment 86886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86886&action=edit
Bug 21130: Prevent HTML class from being translated

Adds a xsl:value-of tag to prevent the value from being translated.

TEST PLAN
0) Apply patch
1) Translate
2) In the opac, div.record has not changed

NOTE:
I don't know if this bug affects all translations, I noticed it when
translating to fr-CA.
The fix will work for all languages.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21130] Detail XSLT produces translatable HTML class

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21130

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22516] accountlines.lastincrement can be removed

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #86713|0   |1
is obsolete||

--- Comment #9 from Marcel de Rooy  ---
Created attachment 86889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86889&action=edit
Bug 22516: Database update

Signed-off-by: Martin Renvoize 

Signed-off-by: Kyle M Hall 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22516] accountlines.lastincrement can be removed

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #86712|0   |1
is obsolete||

--- Comment #8 from Marcel de Rooy  ---
Created attachment 86888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86888&action=edit
Bug 22516: Remove remaining calls to lastincrement

A few places still set lastincrement and the tests still checked for
correct values. But nowhere in the code still uses lastincrement for
anything meaningful.

Signed-off-by: Martin Renvoize 

Signed-off-by: Kyle M Hall 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22516] accountlines.lastincrement can be removed

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22516] accountlines.lastincrement can be removed

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|Trivial patch   |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22516] accountlines.lastincrement can be removed

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516

--- Comment #10 from Marcel de Rooy  ---
@RM: DBIx update !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

--- Comment #4 from Martin Renvoize  ---
Created attachment 86891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86891&action=edit
Bug 22521: Update UI to use accountlines.status

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #86808|0   |1
is obsolete||

--- Comment #3 from Martin Renvoize  ---
Created attachment 86890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86890&action=edit
Bug 22521: Update fines handling to use accountline.status

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||22521


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521
[Bug 22521] Convert fines handling to use 'status' instead of two accounttypes
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||22511


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511
[Bug 22511] Koha::Account::Line->void loses the original type of the credit
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #86890|0   |1
is obsolete||

--- Comment #6 from Martin Renvoize  ---
Created attachment 86893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86893&action=edit
Bug 22521: Update fines handling to use accountline.status

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

--- Comment #5 from Martin Renvoize  ---
Created attachment 86892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86892&action=edit
Bug 22521: Increase varchar size for accounttype

accountlines.accounttype is currently a short varchar(5) field for to
store accounttype codes. Koha is moving towards more descriptive codes
which require a larger capacity varchar(16).

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #86891|0   |1
is obsolete||

--- Comment #7 from Martin Renvoize  ---
Created attachment 86894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86894&action=edit
Bug 22521: Update UI to use accountlines.status

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #86894|0   |1
is obsolete||

--- Comment #10 from Martin Renvoize  ---
Created attachment 86897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86897&action=edit
Bug 22521: Update UI to use accountlines.status

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #86893|0   |1
is obsolete||

--- Comment #9 from Martin Renvoize  ---
Created attachment 86896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86896&action=edit
Bug 22521: Update fines handling to use accountline.status

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #86892|0   |1
is obsolete||

--- Comment #8 from Martin Renvoize  ---
Created attachment 86895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86895&action=edit
Bug 22521: Increase varchar size for accounttype

accountlines.accounttype is currently a short varchar(5) field for to
store accounttype codes. Koha is moving towards more descriptive codes
which require a larger capacity varchar(16).

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

--- Comment #11 from Martin Renvoize  ---
Created attachment 86898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86898&action=edit
Bug 22521: Update existing accounttypes

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

--- Comment #12 from Martin Renvoize  ---
Test Plan

1) Apply patch and ensure updated tests still pass
2) Run DB updates and ensure the display of status's makes sense on all pages
that display accountline details (account summary, print and payment pages on
staff and the user account fines page on the opac)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com,
   ||k...@bywatersolutions.com,
   ||martin.renvoize@ptfs-europe
   ||.com, tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #86895|0   |1
is obsolete||

--- Comment #13 from Martin Renvoize  ---
Created attachment 86899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86899&action=edit
Bug 22521: Increase varchar size for accounttype

accountlines.accounttype is currently a short varchar(5) field for to
store accounttype codes. Koha is moving towards more descriptive codes
which require a larger capacity varchar(16).

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #86897|0   |1
is obsolete||

--- Comment #15 from Martin Renvoize  ---
Created attachment 86901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86901&action=edit
Bug 22521: Update UI to use accountlines.status

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #86896|0   |1
is obsolete||

--- Comment #14 from Martin Renvoize  ---
Created attachment 86900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86900&action=edit
Bug 22521: Update fines handling to use accountline.status

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #86898|0   |1
is obsolete||

--- Comment #16 from Martin Renvoize  ---
Created attachment 86902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86902&action=edit
Bug 22521: Update existing accounttypes

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511

--- Comment #14 from Martin Renvoize  ---
Created attachment 86905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86905&action=edit
Bug 22511: Update UI to use accountlines.status

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #86674|0   |1
is obsolete||

--- Comment #13 from Martin Renvoize  ---
Created attachment 86904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86904&action=edit
Bug 22511: Update void method to use status

We added a 'status' field to 'accountlines' in bug 22512 to allow for
more fined grained control over 'types' and 'states'.

This patch updates the void method to utilise this new field so we may
keep the original credit type for later auditing should it be required.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #86675|0   |1
is obsolete||

--- Comment #12 from Martin Renvoize  ---
Created attachment 86903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86903&action=edit
Bug 22511: Update tests

Updated tests to check for 'status' change and fixed 'accounttype' and
moved from t/db_dependent/Accounts.t to the more appropriate
t/db_dependent/Koha/Account/Lines.t

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511

Martin Renvoize  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||22519


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22519
[Bug 22519] We have two accounttypes for "forgiven", 'FOR' and 'FFOR'
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type'

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|22519   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22519
[Bug 22519] We have two accounttypes for "forgiven", 'FOR' and 'FFOR'
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22519] We have two accounttypes for "forgiven", 'FOR' and 'FFOR'

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22519

Martin Renvoize  changed:

   What|Removed |Added

 Resolution|--- |MOVED
 Status|NEW |RESOLVED

--- Comment #1 from Martin Renvoize  ---
This is cleaned up by bug 22521

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22519] We have two accounttypes for "forgiven", 'FOR' and 'FFOR'

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22519

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||22521
 Blocks|22512   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512
[Bug 22512] accountlines.accountype mixes 'state' and 'type'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521
[Bug 22521] Convert fines handling to use 'status' instead of two accounttypes
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|22512   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512
[Bug 22512] accountlines.accountype mixes 'state' and 'type'
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type'

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|22511   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511
[Bug 22511] Koha::Account::Line->void loses the original type of the credit
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|17702   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702
[Bug 17702] Create configuration for account types
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17702] Create configuration for account types

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|22521   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521
[Bug 22521] Convert fines handling to use 'status' instead of two accounttypes
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22562] New: Add ItemHoldingLibrary to ReservesControlBranch

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562

Bug ID: 22562
   Summary: Add ItemHoldingLibrary to ReservesControlBranch
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: julian.maur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
  Target Milestone: ---

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22562] Add option ItemHoldingLibrary to ReservesControlBranch

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562

Julian Maurice  changed:

   What|Removed |Added

Summary|Add ItemHoldingLibrary to   |Add option
   |ReservesControlBranch   |ItemHoldingLibrary to
   ||ReservesControlBranch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22562] Add ItemHoldingLibrary to ReservesControlBranch

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562

--- Comment #1 from Julian Maurice  ---
Created attachment 86906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86906&action=edit
Bug 22562: Add option ItemHoldingLibrary to ReservesControlBranch

Test plan:
1. Apply patch
2. Run updatedatabase
3. Set syspref ReservesControlBranch to "item's holding library"
4. Create biblios, items, patrons on different libraries and define
circulation (hold) rules for them
5. Verify that these rules are taken into account and that they use the
holding library
6. Verify that the behaviour for other values of ReservesControlBranch
still work as expected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22562] Add option ItemHoldingLibrary to ReservesControlBranch

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562

Julian Maurice  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22561] Forgotten password "password requirements" box doesn't list all of the rules that are in effect for new passwords

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20457] Overdue and pre-overdue cronjobs not skipping phone notices

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20457

Danielle Elder  changed:

   What|Removed |Added

 CC||danielle@bywatersolutions.c
   ||om

--- Comment #3 from Danielle Elder  ---
This is still an issue, and it confusing to many library staff to see these
notices in the message queue.  It also makes support for the Talking Tech
integration with Koha a bit more complicated to sort through. 

I volunteer as tribute to test/sign off on any patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22561] Forgotten password requirements hint doesn't list all rules for new passwords

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561

Owen Leonard  changed:

   What|Removed |Added

Summary|Forgotten password  |Forgotten password
   |"password requirements" box |requirements hint doesn't
   |doesn't list all of the |list all rules for new
   |rules that are in effect|passwords
   |for new passwords   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22561] Forgotten password requirements hint doesn't list all rules for new passwords

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22561] Forgotten password requirements hint doesn't list all rules for new passwords

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561

--- Comment #1 from Owen Leonard  ---
Created attachment 86907
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86907&action=edit
Bug 22561: Forgotten password requirements hint doesn't list all rules for new
passwords

This patch modifies a few templates in the OPAC so that all available
information on password requirements is displayed for each case where
the patron is setting a password:

 - If the RequireStrongPassword system preference is set, a message
   should appear listing strong password requirements and minimum
   password length.
 - If RequireStrongPassword is not set, the message should only ask for
   a minimum password length.

To test, apply the patch and enable the PatronSelfRegistration and
OpacResetPassword preferences.

On the following pages, test with RequireStrongPassword both on and
off. The correct messages should appear.

 - OPAC -> Forgot password. Follow the process to reset your password
   until you reach the step where you are entering the new password.
 - OPAC -> Register here. Check the password section of the registration
   form.
 - OPAC -> Log in -> Change your password.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22560] Forgotten password "token expired" page still shows boxes to reset password

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560

Owen Leonard  changed:

   What|Removed |Added

 Depends on||22561
 Status|NEW |ASSIGNED


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561
[Bug 22561] Forgotten password requirements hint doesn't list all rules for new
passwords
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22561] Forgotten password requirements hint doesn't list all rules for new passwords

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561

Owen Leonard  changed:

   What|Removed |Added

 Blocks||22560


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560
[Bug 22560] Forgotten password "token expired" page still shows boxes to reset
password
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22520] Be Elastic compliant 7.x and 8.x (_doc)

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22520] Be Elastic compliant 7.x and 8.x (_doc)

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520

--- Comment #2 from Owen Leonard  ---
Created attachment 86908
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86908&action=edit
Bug 22560: Forgotten password "token expired" page still shows boxes to reset
password

This patch modifies the OPAC password recovery template so that the new
password entry form doesn't appear if the patron has followed an invalid
or expired link.

This patch also corrects the markup in the page title.

To test, apply the patch and follow the process for resetting a
forgotten password. When you follow the password recovery link, modify
the URL so that the "uniqueKey" parameter is different.

The page should show an error message. The password entry form should
not appear.

Check the page title in the browser's title bar. It should look correct.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22560] Forgotten password "token expired" page still shows boxes to reset password

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22520] Be Elastic compliant 7.x and 8.x (_doc)

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

--- Comment #3 from Owen Leonard  ---
(In reply to Owen Leonard from comment #2)
> Created attachment 86908 [details] [review]

Sorry, wrong bug number!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22560] Forgotten password "token expired" page still shows boxes to reset password

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560

--- Comment #1 from Owen Leonard  ---
Created attachment 86909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86909&action=edit
Bug 22560: Forgotten password "token expired" page still shows boxes to reset
password

This patch modifies the OPAC password recovery template so that the new
password entry form doesn't appear if the patron has followed an invalid
or expired link.

This patch also corrects the markup in the page title.

To test, apply the patch and follow the process for resetting a
forgotten password. When you follow the password recovery link, modify
the URL so that the "uniqueKey" parameter is different.

The page should show an error message. The password entry form should
not appear.

Check the page title in the browser's title bar. It should look correct.

https://bugs.koha-community.org/show_bug.cgi?id=22520

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22520] Be Elastic compliant 7.x and 8.x (_doc)

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520

Owen Leonard  changed:

   What|Removed |Added

  Attachment #86908|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22520] Be Elastic compliant 7.x and 8.x (_doc)

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22545] C4::Matcher::get_matches aggressive isbn and issn search don't give any results with ES

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545

Ere Maijala  changed:

   What|Removed |Added

 CC||ere.maij...@helsinki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22560] Forgotten password "token expired" page still shows boxes to reset password

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14546] Make staff client templates responsive

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546
Bug 14546 depends on bug 19980, which changed state.

Bug 19980 Summary: Omnibus: Update single-column templates to use Bootstrap grid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21735] Update Sys Pref : MarkLostItemsAsReturned

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21735

Kelly McElligott  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type'

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type'

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #86684|0   |1
is obsolete||

--- Comment #5 from Tomás Cohen Arazi  ---
Created attachment 86910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86910&action=edit
Bug 22512: Add status field to accountlines

Signed-off-by: Martin Renvoize 
Signed-off-by: Kyle M Hall 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type'

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21890] Patron password reset by category

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890

--- Comment #39 from Tomás Cohen Arazi  ---
Created attachment 86911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86911&action=edit
Bug 21890: Wrap message in span

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13735] Item form in serials module doesn't respect max length set in the frameworks

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735

--- Comment #9 from Katrin Fischer  ---
Ultimately... we should use the same code for generating the form here that we
use in catalouging as there are other issues (missing select2 functionality is
an example) - but that will go way beyond this bug fix :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13735] Item form in serials module doesn't respect max length set in the frameworks

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735

--- Comment #10 from Katrin Fischer  ---
Thx for QA!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of two accounttypes

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >