[Koha-bugs] [Bug 22555] Serials page doesn't show subscriptions on page load

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22555

--- Comment #3 from Katrin Fischer  ---
Maybe we need to get some more opinions on this. The page is already paginated,
although I think not server side, but client side (might be mistaken).

It hasn't come up in training as an issue. The most common workflow in serials
I think is receiving an issue. I think libraries would still use the search in
this case, as it's unlikely that the subscription would be on the first page. 

But I am not working daily with the module - training and explaining is
different. Getting a few more views would not hurt.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21560] Optimize ODS exports

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560

--- Comment #35 from Fridolin SOMERS  ---
Pushed to 17.11.x for 17.11.17

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22386] Importing using attributes as matchpoint broken

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22386

--- Comment #13 from Fridolin SOMERS  ---
Depends on Bug 19936 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22360] On order information missing in OPAC normal display

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22360

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 CC||fridolin.som...@biblibre.co
   ||m
 Resolution|--- |FIXED

--- Comment #16 from Fridolin SOMERS  ---
Depends on Bug 21205 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22429] Infinite loop in patron card printing

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #18 from Fridolin SOMERS  ---
Pushed to 17.11.x for 17.11.17

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22476] MarkLostItemsAsReturned has wrong defaults for new installs

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22476

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 CC||fridolin.som...@biblibre.co
   ||m
 Resolution|--- |FIXED

--- Comment #8 from Fridolin SOMERS  ---
Depends on Bug 19287 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16251] Material type is not correctly set for Rancor 008 widget

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16251

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #8 from Fridolin SOMERS  ---
Pushed to 17.11.x for 17.11.17

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539

--- Comment #10 from Martin Renvoize  ---
This will need some tests before QA.. I'll try to get to those today as we seem
to be happy with this path.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #86986|0   |1
is obsolete||

--- Comment #9 from Martin Renvoize  ---
Created attachment 86999
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86999&action=edit
Bug 22539: Always recalculate fines when a return date is specified

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #86985|0   |1
is obsolete||

--- Comment #8 from Martin Renvoize  ---
Created attachment 86998
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86998&action=edit
Bug 22539: Reset fines for backdated returns

Fixed fines should be 'unfixed' for backdated returns that specify a
return date prior to the lastreneweddate.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539

Martin Renvoize  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22555] Serials page doesn't show subscriptions on page load

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22555

Hayley Mapley  changed:

   What|Removed |Added

 Status|ASSIGNED|In Discussion

--- Comment #2 from Hayley Mapley  ---
(In reply to Katrin Fischer from comment #1)
> There are libraries with tons of subscriptions so it makes a lot of sense to
> me to start with a search as showing them all might potentially slow down
> the page quite a bit. If you look at other places in Koha (invoices,
> baskets) it would be quite unusual too.

I see. It struck me as something that isn't particularly first-time-user
friendly. Clicking on the subscriptions page, I would expect to see my
subscriptions. 

I'm wondering if you think it would be a good idea to implement a paginator to
control the amount of entries on the page, or even easier, add a message that
indicates that there are subscriptions and how to see them, or that there are
not yet any subscriptions.

Adding a friendly message could be done to the other places that you mentioned
also. Let me know what you think!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22570] csrf auth token failure in displaying patron image in SCO

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22570

--- Comment #1 from T. Jogi Raju  ---
Patron image is not been displayed when the web-based self checkout system is
configured to automatically login with this staff login. When a real staff user
login credentials are used to initiate the SCO it is working correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22414] Discrepancy in serials-edit.pl url when receiving serial subscription issues

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22414

Hayley Mapley  changed:

   What|Removed |Added

 CC||hayleymap...@catalyst.net.n
   ||z
 Status|NEW |In Discussion

--- Comment #1 from Hayley Mapley  ---
I've traced this back to 2009 where these statuses were first added to the code
base. It looks like these numbers can affect the status of the subscriptions on
the receive page, but it also looks like these numbers could be done without.
I'd be keen to get a second opinion on this though!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22579] Add syspref to toggle expanding Actions dropdown menu in Z39.50 search to decrease clicks

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579

Hayley Mapley  changed:

   What|Removed |Added

 CC||alexbuck...@catalyst.net.nz
   ||,
   ||hayleymap...@catalyst.net.n
   ||z

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22579] Add syspref to toggle expanding Actions dropdown menu in Z39.50 search to decrease clicks

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579

Hayley Mapley  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22579] Add syspref to toggle expanding Actions dropdown menu in Z39.50 search to decrease clicks

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579

--- Comment #1 from Hayley Mapley  ---
Created attachment 86997
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86997&action=edit
Bug 22579: Add syspref to toggle dropdown/links in Z39.50 search results

This patch reduces the number of clicks to use 'Card preview' functionality
without removing the work done to condense the three links into a menu
in Bug 19939 which is displayed by default (and when the syspref is
disabled).

Test plan:
1) Apply the patch
2) In Cataloging click the New from Z39.50/SRU button and search for a
term that will produce results
3) In the results window, note that the actions column contains a
dropdown for each row which contains three links.
4) Change the Replacez3950CatalogingActionMenuWithLinks to 'Do'
5) Complete step 2 again, and instead note that the actions column now
contains three links, Card preview, MARC preview, Import
6) Verify that each of the links work as expected
7) Sign off!

Sponsored-by: Horowhenua Library Trust

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22579] Add syspref to toggle expanding Actions dropdown menu in Z39.50 search to decrease clicks

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579

Hayley Mapley  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |hayleymap...@catalyst.net.n
   |ity.org |z
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22579] New: Add syspref to toggle expanding Actions dropdown menu in Z39.50 search to decrease clicks

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579

Bug ID: 22579
   Summary: Add syspref to toggle expanding Actions dropdown menu
in Z39.50 search to decrease clicks
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: hayleymap...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl
  Target Milestone: ---

An enhancement included in master from Bug 15952 moved the Actions in the
Cataloging Z39.50 search results into a dropdown. We have a library who uses
the Card preview and MARC preview from this search to quickly ascertain whether
a record is the one they were looking for, and would like to decrease the
number of clicks it takes to execute this option from 2 to 1. 

We propose to allow the user to switch these options from a dropdown to
expanded links within the action column, toggleable via a system preference.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

--- Comment #29 from David Cook  ---
(In reply to Joy Nelson from comment #27)
> It seems logical that the autorenewal process should only be looking at
> issues at the time specified for autorenewal.  i.e. Only try to renew items
> on the 'No renewals before" duedate value.

I agree. I think it's both logical and it seems to be the way that other
library systems do it as well, which suggests to me that is what patrons would
expect as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

--- Comment #28 from David Cook  ---
(In reply to Andrew from comment #26)
> Apologies for pushing for greater complexity on this, but I'm not sure about
> this approach. If we make auto-renew notices only send on the day the item
> is renewed or on the day it's due, we've not solved the problem so much as
> inverted it -- some libraries will like it, some libraries will be
> ambivalent, and some libraries will feel strongly that we're sending notices
> too late.
> 
> I'd like to see this either as a switch (Send notice on status change / Send
> notice at due date & renewal) or as a configurable preference like a No
> Notice Before value.

Andrew, I don't understand what you're trying to say here. The auto-renew
notices will be queued up when the renewal is processed. I don't see any other
logical way of handling the notices. Are you meaning you want to change the
timing of the renewals (and thus the notices associated with them)? 

If so, my patch allows you to use the "No Renewal Before" rule in Circulation
and Fines Rules to specify that no renewal can happen until N days before the
due date. 

My local public library (which doesn't use Koha) seems to have set "4 days
before the due date", which means that if there are no restrictions on the
item, it will autorenew 4 days before the due date and it will promptly send me
an email notification to indicate this.

I can't really see any other logical way of it working?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21716] Item Search hangs when \ exists in MARC fields

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21716

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #11 from Liz Rea  ---
Hi,

I've just checked this patch, and it seems that the hang doesn't occur on
current master, but it is broken again without the patch (infinite processing).

Is this still needed? It appears to me that it isn't.

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21976] koha-reset-passwd does not deal with password restrictions

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21976

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #6 from Liz Rea  ---
Hi,

This patch fails to apply with 

Auto-merging misc/admin/set_password.pl
Auto-merging debian/scripts/koha-reset-passwd
CONFLICT (content): Merge conflict in debian/scripts/koha-reset-passwd

Sorry :(

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17661] Differences in field ending (whitespace, punctuation) cause duplicate facets

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661

Tami Wilkerson  changed:

   What|Removed |Added

 CC||twilker...@critfc.org

--- Comment #5 from Tami Wilkerson  ---
(In reply to Sarah Cornell from comment #4)
> Correcting this display problem would really improve user experience. 
> 
> Currently users need to discover by trial and error that the two entries
> "Brunkus, Denise," and Brunkus, Denise." run the same search.  Our
> librarians assume they run different searches, and it makes them distrust
> the catalog.  
> 
> This affects all facets that come from MARC: authors, series, places, topics.

I completely agree with Sarah. The duplication pushes other authors, series,
places, topics, etc. further down the list and users have to click "Show Me
More" to see them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22358] Add POD to Koha::SharedContent

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22358

Liz Rea  changed:

   What|Removed |Added

  Attachment #86571|0   |1
is obsolete||

--- Comment #3 from Liz Rea  ---
Created attachment 86996
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86996&action=edit
Bug 22358: Add POD to Koha::SharedContent

Signed-off-by: Liz Rea 
QA tool checks out, perldoc Koha/SharedContent.pm looks ok to me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22358] Add POD to Koha::SharedContent

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22358

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22410] Software error while adding order on a MARC file record without an author

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22410

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com

--- Comment #4 from Liz Rea  ---
Hi Pierre,

Are you cataloguing in UNIMARC? Could you provide some UNIMARC import files for
us to test with, if so?

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577

Nick Clemens  changed:

   What|Removed |Added

   Severity|enhancement |blocker

--- Comment #5 from Nick Clemens  ---
raising severity as some crons are currently broken by this (longoverdue for
example)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #4 from Nick Clemens  ---
t/lib/Mocks.pm:sub mock_userenv should probably be set to default to 0 instead
of 51 - or create it's own user?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22453] TestBuilder should generate now() using the current timezone

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453

--- Comment #7 from Liz Rea  ---
That must be it - I just did a "vagrant reload" on my debian 9, and without the
patch I got: 

kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove
t/db_dependent/Koha/Patrons.t 
t/db_dependent/Koha/Patrons.t .. ok 
All tests successful.
Files=1, Tests=33, 46 wallclock secs ( 0.09 usr  0.01 sys + 33.53 cusr  8.94
csys = 42.57 CPU)
Result: PASS


Maybe we don't need to patch it at all?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22453] TestBuilder should generate now() using the current timezone

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com

--- Comment #6 from Liz Rea  ---
Hi, 

I'm wondering if this manifests when the datetime of your virtualbox is out of
sync with the current date, such as what could happen on a laptop if you sleep
the box while devbox is running?

This was debian 9, ftr: 

kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove
t/db_dependent/Koha/Patrons.t 
t/db_dependent/Koha/Patrons.t .. 26/33 
#   Failed test 'With BorrowerLogs and TrackLastPatronActivity we should
not spam the logs'
#   at t/db_dependent/Koha/Patrons.t line 1421.
#  got: '2'
# expected: '1'
# Looks like you failed 1 test of 4.
t/db_dependent/Koha/Patrons.t .. 30/33 
#   Failed test 'BorrowersLog tests'
#   at t/db_dependent/Koha/Patrons.t line 1422.
t/db_dependent/Koha/Patrons.t .. 32/33 # Looks like you failed 1 test of 33.
t/db_dependent/Koha/Patrons.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/33 subtests 

Test Summary Report
---
t/db_dependent/Koha/Patrons.t (Wstat: 256 Tests: 33 Failed: 1)
  Failed test:  30
  Non-zero exit status: 1
Files=1, Tests=33, 47 wallclock secs ( 0.10 usr  0.00 sys + 36.20 cusr  8.52
csys = 44.82 CPU)
Result: FAIL
kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ date
Thu Mar 21 19:54:59 GMT 2019 

^^ that is very much not today's date.

A Vagrant reload might fix the tests when they're failing? Maybe your ubuntu
box has a bad date and your debian one didn't?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Nick Clemens  changed:

   What|Removed |Added

  Attachment #86994|0   |1
is obsolete||

--- Comment #39 from Nick Clemens  ---
Created attachment 86995
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86995&action=edit
Bug 22008: Fix failing tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

--- Comment #38 from Nick Clemens  ---
Created attachment 86994
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86994&action=edit
Bug 22008: Fix failing tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15544] Zebra facets must be managed from the intranet

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15544

Sarah Cornell  changed:

   What|Removed |Added

 CC|sbcornell@cityofportsmouth. |
   |com |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15544] Zebra facets must be managed from the intranet

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15544

Sarah Cornell  changed:

   What|Removed |Added

 CC||sbcornell@cityofportsmouth.
   ||com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17661] Differences in field ending (whitespace, punctuation) cause duplicate facets

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661

--- Comment #4 from Sarah Cornell  ---
Correcting this display problem would really improve user experience. 

Currently users need to discover by trial and error that the two entries
"Brunkus, Denise," and Brunkus, Denise." run the same search.  Our librarians
assume they run different searches, and it makes them distrust the catalog.  

This affects all facets that come from MARC: authors, series, places, topics.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577

--- Comment #1 from Martin Renvoize  ---
Created attachment 86991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86991&action=edit
Bug 22577: Prevent deletion of system users

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577

--- Comment #3 from Martin Renvoize  ---
Created attachment 86993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86993&action=edit
Bug 22577: Set 'cron' user for fines job

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577

--- Comment #2 from Martin Renvoize  ---
Created attachment 86992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86992&action=edit
Bug 22577: Add 'cron' system user

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22008

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22577] New: Cronjobs (and other scripts) should be attributed to a 'real' user

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577

Bug ID: 22577
   Summary: Cronjobs (and other scripts) should be attributed to a
'real' user
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

Currently the userenv for cronjobs is set to '0' for the userid. This user does
not exist and breaks/prevents foreign key constraints from working as expected.

We should really add a hard coded default user to identify such actions.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22578] New: calendar options for every other week closings

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22578

Bug ID: 22578
   Summary: calendar options for every other week closings
 Change sponsored?: ---
   Product: Koha
   Version: 18.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bwsdo...@gmail.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

There are libraries that are closed one day every other week (such as every
other Saturday) and currently each closed day has to entered manually.  It
would be helpful to have the option to set a holiday that occurs biweekly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||22577


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577
[Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22577

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||22008


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008
[Bug 22008] accountlines.manager_id is missing a foreign key constraint
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||wizzy...@gmail.com

--- Comment #4 from Liz Rea  ---
Hi Nick, 

Terribly sorry, the patches don't seem to apply:

CONFLICT (content): Merge conflict in t/db_dependent/Holds.t
error: Failed to merge in the changes.
- This was a conflict on number of tests, easy to resolve so I did that,
HOWEVER have also got...

Applying: Bug 20837: Use ReservesControlBranch to determine holdability of
items
error: sha1 information is lacking or useless (C4/Reserves.pm).
error: could not build fake ancestor

A new patch set would be nice. :)

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20457] Overdue and pre-overdue cronjobs not skipping phone notices

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20457

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20457] Overdue and pre-overdue cronjobs not skipping phone notices

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20457

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #73141|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall  ---
Created attachment 86990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86990&action=edit
Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices

The overdue and pre-overdue cron scripts are not skipping the generation of
phone notices. This causes many phone notices to be created that will always be
left at 'pending' as the Talking Tech outbound script creates its own phone
notices and puts them in the message queue.

Test Plan:
1) Enable Talking Tech
2) Enable predue and overdue notice phone transports for a patron
3) Generate overdues and predues, notice phone notices are generated
4) Apply the patch
5) Repeat steps 2-3
6) Note phone notices are not generated

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18344] Allow overdue fines cap at replacement price, and cap by amount to work together

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18344

--- Comment #8 from Kyle M Hall  ---
Created attachment 86989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86989&action=edit
Bug 18344 - Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18344] Allow overdue fines cap at replacement price, and cap by amount to work together

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18344

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18344] Allow overdue fines cap at replacement price, and cap by amount to work together

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18344

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #65493|0   |1
is obsolete||

--- Comment #7 from Kyle M Hall  ---
Created attachment 86988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86988&action=edit
Bug 18344 - Allow overdue fines cap at replacement price, and cap by amount to
work together

There is no reason that a library shouldn't be able to use the monetary
fines cap and the replacement price cap at the same time. The code is
written in such a way that they already work harmoniously. We have
librarians who wish to use both so they can set a high cap of $10.00 but
also use the replacement price cap so that a $20.00 book would only get
a fine of $10.00, but a $5.00 paperback will only get a fine of $5.00

Test Plan:
1) Apply this patch
2) Create a rule with a fines cap of $10, *and* a cap at replacement price, and
a daily fine of $1
3) Create two items, one with a replacement price of $5 and one with a
   replacement price of $15
4) Check out these items to a patron, backdate the checkouts so they are
   already overdue by a couple months
5) Check the items in ( make sure calc fine at checkin is enabled for
you )
6) Note the one item has a fine of $5 and the other has a fine of $10!

Signed-off-by: David Kuhn 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22576] OPAC password change text changes

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22576

--- Comment #1 from Liz Rea  ---
Created attachment 86987
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86987&action=edit
Bug 22576: OPAC password text refresh

To test:

Create a patron with a username and password
Make sure that password resets on OPAC are allowed in your system
preferences (OpacPasswordChange -> Allow)
Log into the OPAC with this patron
Click the "Change password" tab
Change the password - notice that the button to submit the changes says
"Submit Changes" and also that the success page says "Return to my
record"
Apply this patch
Reset the password again, noticing that the button to submit the new
password says "Change password" and the success page says "Return to my
account"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22576] OPAC password change text changes

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22576

Liz Rea  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837

Nick Clemens  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22576] New: OPAC password change text changes

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22576

Bug ID: 22576
   Summary: OPAC password change text changes
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: wizzy...@gmail.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

A borrower changing their password from the logged in password change
functionality might see some awkward text messages, specifically: 

- "Return to your record" after changing the password, I propose "Return to my
account" (since that's what the borrower probably wants to do).
- "Submit changes" to change the password should be "Change password" just to
be really clear about what is going to happen when the button is clicked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539

--- Comment #7 from Kyle M Hall  ---
Created attachment 86986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86986&action=edit
Bug 22539: Always recalculate fines when a return date is specified

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #86975|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall  ---
Created attachment 86985
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86985&action=edit
Bug 22539: Reset fines for backdated returns

Fixed fines should be 'unfixed' for backdated returns that specify a
return date prior to the lastreneweddate.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22246] Elasticsearch indexing needs a maximum length for `__sort` fields

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22246

Martin Renvoize  changed:

   What|Removed |Added

Summary|Elasticsearch indexing  |Elasticsearch indexing
   |needs a maximum length for  |needs a maximum length for
   |__sort fields   |`__sort` fields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the||This patch introduces to
  release notes||new system preference to
   ||govern how rounding is
   ||applied to values in
   ||acquisitions. It defaults
   ||to the american practice of
   ||rounding to the nearest
   ||'cent' but future options
   ||should become available as
   ||we start to understand how
   ||other nations round for
   ||accounting purposes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22575] New: Item type administration uses invalid error class for dialog

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22575

Bug ID: 22575
   Summary: Item type administration uses invalid error class for
dialog
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: System Administration
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
  Target Milestone: ---

If you try to delete an item type which is in use, the error message you get is
displayed in a white dialog with red text. This happens because the message
"type" passed from the script is "error," a CSS class which is undefined. The
script should send "alert" instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11674] Configuration for MARC field doc URLs

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674

Josef Moravec  changed:

   What|Removed |Added

 Blocks||22574


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22574
[Bug 22574] MarcFieldDocURL: paramether for biblio and authority fields
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22574] MarcFieldDocURL: paramether for biblio and authority fields

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22574

Josef Moravec  changed:

   What|Removed |Added

 Depends on||11674


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674
[Bug 11674] Configuration for MARC field doc URLs
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20436] Add ability to specify itemtypes for longoverdue.pl

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20436

--- Comment #12 from Liz Rea  ---
Fixed commit headlines on original patch, and addressed the reference and typo
concerns. I leave the last one 

"+=item B<--list-itemtypes>
+
+List itemtypes available for use by B<--itemtype> or
+B<--skip-itemtype>, and exit.

I am not a fan of such options. There are better ways to list them. One is
already in and I would rather remove it."

for Kyle.

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20436] Add ability to specify itemtypes for longoverdue.pl

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20436

--- Comment #11 from Liz Rea  ---
Created attachment 86984
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86984&action=edit
Bug 20436: (QA follow up) - reference and typo fixes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20436] Add ability to specify itemtypes for longoverdue.pl

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20436

Liz Rea  changed:

   What|Removed |Added

  Attachment #81024|0   |1
is obsolete||

--- Comment #10 from Liz Rea  ---
Created attachment 86983
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86983&action=edit
Bug 20436: Add ability to specify itemtypes for longoverdue.pl

It would be nice if we could filter long overdues based on itemtype the same
way we can already filter based on borrower category code.

Test Plan:
1) Set up a number of overdues of various itemtypes
2) Run longoverdue.pl with --list-itemtypes to show itemtypes
3) Run longoverdue.pl with --itemtype to verify it only operates on that
itemtype
4) Run longoverdue.pl with multiple --itemtype switches, verify it only
operates on those itemtypes
5) Run longoverdue.pl with --skip-itemtype to verify it does not operate on
that itemtype
6) Run longoverdue.pl with multiple --skip-itemtype switches, verify that it
does not operate on those itemtypes

Signed-off-by: Jesse Maseto 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20436] Add ability to specify itemtypes for longoverdue.pl

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20436

Liz Rea  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22515] OPACViewOthersSuggestions if set to Show will only show when patron has made a suggestion

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22515

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
Version|18.05   |master
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Joy Nelson  changed:

   What|Removed |Added

 CC||j...@bywatersolutions.com

--- Comment #27 from Joy Nelson  ---
It seems logical that the autorenewal process should only be looking at issues
at the time specified for autorenewal.  i.e. Only try to renew items on the 'No
renewals before" duedate value.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20436] Add ability to specify itemtypes for longoverdue.pl

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20436

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com

--- Comment #9 from Liz Rea  ---
Just noting that this still applies and only needs attention to QA concerns.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Benjamin Daeuber  changed:

   What|Removed |Added

 CC||bdaeu...@cityoffargo.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

--- Comment #19 from Josef Moravec  ---
In ISSUESLIP ans ISSUEQSLIP is possible to do this:


[% USE Price %]

# your normal issue slip content

[% SET balance = borrower.account.balance %]
[% IF balance > 0 %]
Patron has debit of [% balance | $Price %].
[% END %]
[% IF balance < 0 %]
Patron has credit of [% balance | $Price %].
[% END %]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969

Liz Rea  changed:

   What|Removed |Added

 Status|Failed QA   |Patch doesn't apply
 CC||wizzy...@gmail.com

--- Comment #38 from Liz Rea  ---
Patch does not apply anymore sorry :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Nick Clemens  changed:

   What|Removed |Added

   Keywords||additional_work_needed

--- Comment #37 from Nick Clemens  ---
There is an issue here.  Currently we use 0 to indicate an action performed by
command line scripts (userenv is undef, default to 0)

With this patch we must have a real borrowernumber.

If we simply default to 'NULL' we will no longer be able to differentiate fines
from command line from those of deleted users

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18344] Allow overdue fines cap at replacement price, and cap by amount to work together

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18344

Liz Rea  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #6 from Liz Rea  ---
*sadface* doesn't apply anymore

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18344] Allow overdue fines cap at replacement price, and cap by amount to work together

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18344

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com
 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21646] Clean up Overdrive template

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21646

Liz Rea  changed:

   What|Removed |Added

  Attachment #86976|0   |1
is obsolete||

--- Comment #3 from Liz Rea  ---
Created attachment 86982
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86982&action=edit
Bug 21646: Clean up Overdrive template

This patch modifies the OverDrive administration page to correct some
markup issues:

 - Switch to Bootstrap grid
 - Add missing header search box
 - Add missing DataTable configuration
 - Remove unnecessary fieldset

To test you do not need to have OverDrive credentials. Apply the patch
and go to System preferences -> Enhanced content -> OverDrive. In the
description of the "OverDriveAuthName" preference, follow the link to
manage "individual branch authnames."

 - Confirm that the page looks correct, including the header search
   box, page title, and breadcrumbs
 - Confirm that the page adjusts well to various browser window sizes.
 - Confirm that the DataTable works correctly.

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21646] Clean up Overdrive template

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21646

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21130] Detail XSLT produces translatable HTML class

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21130

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #13 from Martin Renvoize  ---
Pushed to 18.11.x for 18.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22572] Garbled content of MARC control fields in MARC view

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22572

--- Comment #1 from Owen Leonard  ---
I'm thinking we could do something like this in the template:

[% subfiel.marc_value | replace(' ', ' ') | $raw %]

...which would convert spaces to   for ALL output of MARC data, on the
assumption that it doesn't hurt to do so with fields which don't rely on
character position.

I don't think there's a good way to change the style of the output of just
those fields, since there's nothing in the framework which specifies that those
tags are  "positionally defined."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22565] Partially receiving order and adding internal note on invoice updates note on every order on the system

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22565

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #11 from Martin Renvoize  ---
Pushed to 18.11.x for 18.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13735] Item form in serials module doesn't respect max length set in the frameworks

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #12 from Martin Renvoize  ---
Pushed to 18.11.x for 18.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22561] Forgotten password requirements hint doesn't list all rules for new passwords

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22560] Forgotten password "token expired" page still shows boxes to reset password

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22560] Forgotten password "token expired" page still shows boxes to reset password

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #86979|0   |1
is obsolete||

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 86981
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86981&action=edit
Bug 22560: Forgotten password "token expired" page still shows boxes to reset
password

This patch modifies the OPAC password recovery template so that the new
password entry form doesn't appear if the patron has followed an invalid
or expired link.

This patch also corrects the markup in the page title.

To test, apply the patch and follow the process for resetting a
forgotten password. When you follow the password recovery link, modify
the URL so that the "uniqueKey" parameter is different.

The page should show an error message. The password entry form should
not appear.

Check the page title in the browser's title bar. It should look correct.

https://bugs.koha-community.org/show_bug.cgi?id=22520

Signed-off-by: Liz Rea 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22560] Forgotten password "token expired" page still shows boxes to reset password

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #86979|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22561] Forgotten password requirements hint doesn't list all rules for new passwords

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 86980
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86980&action=edit
Bug 22561: Forgotten password requirements hint doesn't list all rules for new
passwords

This patch modifies a few templates in the OPAC so that all available
information on password requirements is displayed for each case where
the patron is setting a password:

 - If the RequireStrongPassword system preference is set, a message
   should appear listing strong password requirements and minimum
   password length.
 - If RequireStrongPassword is not set, the message should only ask for
   a minimum password length.

To test, apply the patch and enable the PatronSelfRegistration and
OpacResetPassword preferences.

On the following pages, test with RequireStrongPassword both on and
off. The correct messages should appear.

 - OPAC -> Forgot password. Follow the process to reset your password
   until you reach the step where you are entering the new password.
 - OPAC -> Register here. Check the password section of the registration
   form.
 - OPAC -> Log in -> Change your password.

Signed-off-by: Liz Rea 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22560] Forgotten password "token expired" page still shows boxes to reset password

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22560] Forgotten password "token expired" page still shows boxes to reset password

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #86979|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22561] Forgotten password requirements hint doesn't list all rules for new passwords

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22561] Forgotten password requirements hint doesn't list all rules for new passwords

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #86978|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||22539


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539
[Bug 22539] Fines charged on back-dated checkin when item has been renewed
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||14591


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591
[Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue
fines
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||22533


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533
[Bug 22533] Cannot create manual invoices
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22533] Cannot create manual invoices

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Martin Renvoize  ---
Causation bug not in 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22533] Cannot create manual invoices

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||14591


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591
[Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue
fines
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22560] Forgotten password "token expired" page still shows boxes to reset password

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >