[Koha-bugs] [Bug 22579] Add syspref to toggle expanding Actions dropdown menu in Z39.50 search to decrease clicks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 --- Comment #5 from Hayley Mapley --- (In reply to Katrin Fischer from comment #4) > Could we use a split button with import being the default? (like receive in > the subscription search list) > > I also share the feeling that a pref might be a little overkill here when it > seems more like a usability issue. A split button could work, but the library are wanting Card Preview to be the easiest to access. Would it be acceptable to have Card Preview as the main option, and MARC preview and import be in the dropdown part? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16357] Plack error logs are not time stamped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #33 from Mason James --- (In reply to Mason James from comment #31) > I tested this and had a similar error.. > Log4perl: Seems like no initialization happened. Forgot to call init()? > > It seems there is some subtle permission problem with the log file. I > experimented with permissions but had no success > > Przemek or David, can you provide an example of working permission for the > log files? this seems to be an example of the default permissions... root@server1:/var/log/koha/abc# ls -l *log -rw-r--r-- 1 abc-koha abc-koha 774 Mar 28 05:40 indexer-error.log -rw-r--r-- 1 abc-koha abc-koha0 Mar 28 05:27 indexer-output.log -rw-r--r-- 1 root root 411998 Mar 28 09:24 intranet-error.log -rw-r--r-- 1 root root69039 Mar 28 04:28 opac-error.log -rw-r--r-- 1 abc-koha abc-koha 16347161 Mar 28 12:38 plack-error.log -rw-r--r-- 1 abc-koha abc-koha 4288611 Mar 28 12:38 plack.log -rw-r--r-- 1 abc-koha abc-koha0 Mar 27 05:22 zebra-error.log -rw-r--r-- 1 abc-koha abc-koha0 Mar 15 04:25 zebra-output.log -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16357] Plack error logs are not time stamped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #32 from Mason James --- (In reply to Mason James from comment #31) > I tested this and had a similar error.. > Log4perl: Seems like no initialization happened. Forgot to call init()? > > It seems there is some subtle permission problem with the log file. I > experimented with permissions but had no success > > Przemek or David, can you provide an example of working permission for the > log files? My hunch is that the original patch works OK, because it uses L4P's 'easy mode', which does some extra permisssion magic?, (just a theory ATM) https://metacpan.org/pod/Log::Log4perl#Easy-Mode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16357] Plack error logs are not time stamped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #31 from Mason James --- I tested this and had a similar error.. Log4perl: Seems like no initialization happened. Forgot to call init()? It seems there is some subtle permission problem with the log file. I experimented with permissions but had no success Przemek or David, can you provide an example of working permission for the log files? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 Hayley Mapley changed: What|Removed |Added Blocks||1 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1 [Bug 1] Include the definition of currency in onboarding tool -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1 Hayley Mapley changed: What|Removed |Added Depends on||18308 --- Comment #10 from Hayley Mapley --- This bug should depend on Bug 18308 as it is part of the onboarding tool. I will fix it to reflect this. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 [Bug 18308] Default value of minPasswordLength should be increased -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 Hayley Mapley changed: What|Removed |Added Blocks||21265 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21265 [Bug 21265] Additional step at end of onboarder to enable HEA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21265] Additional step at end of onboarder to enable HEA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21265 Hayley Mapley changed: What|Removed |Added Depends on||18308 --- Comment #2 from Hayley Mapley --- This bug should depend on 18308 as it is part of the onboarding tool. I will fix it to reflect this. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 [Bug 18308] Default value of minPasswordLength should be increased -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22599] New: Items attached to a course reserve but checkout can not be removed from course
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22599 Bug ID: 22599 Summary: Items attached to a course reserve but checkout can not be removed from course Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- Since items that are connected to a course reserve, cannot be removed from that course reserve if it is currently checked out. It would be helpful to show an information bubble when the user is hovering over the greyed out "remove" button. This would let the user know that due to the fact this item is checked out, the item can not be removed and therefore the "remove" button is not available. Add Items to an Existing Course Check out one of those items to a patron Go back to Course and see that the Item's ability to be removed is greyed out. Edit is still an available option, but remove is not. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 Hayley Mapley changed: What|Removed |Added Attachment #87125|0 |1 is obsolete|| Attachment #87126|0 |1 is obsolete|| Attachment #87128|0 |1 is obsolete|| --- Comment #28 from Hayley Mapley --- Created attachment 87129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87129=edit Bug 18308: Fixed whitespace and added filters for qa tools Note: This will still fail qa tool due to 'forbidden' javascript fullpath and not use of Asset plugin. Asset plugin cannot be used for onboarding currently. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 --- Comment #27 from Hayley Mapley --- Created attachment 87128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87128=edit Bug 18308: Added another filter Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22501] OPAC course reserves notes should allow html links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 --- Comment #1 from Lucas Gass --- Created attachment 87127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87127=edit Attachment to Bug 22501 - OPAC course reserves notes should allow html links Bug 22501: OPAC course reserves notes should allow html links Test Plan: 1. Add a new course a put '' in the public not field. 2. Go to the course in the OPAC. 3. Notice that the HTML displays literally 4. Apply patch and reload page 5. The tag should render as HTML -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22501] OPAC course reserves notes should allow html links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 --- Comment #26 from Hayley Mapley --- Created attachment 87126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87126=edit Bug 18308: Added missing filters Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 --- Comment #25 from Hayley Mapley --- Created attachment 87125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87125=edit Bug 18308: Fixed whitespace for qa tool Note: This will still fail qa tool due to 'forbidden' javascript fullpath and not use of Asset plugin. Asset plugin cannot be used for onboarding currently. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 Hayley Mapley changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 --- Comment #24 from Hayley Mapley --- Created attachment 87124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87124=edit Bug 18308: (follow up) Changed order of onboarding steps This patch cleans up the previous patches according to comment 23, fixes various typos, and changes the order of steps in the onboarding so that the setting of minPasswordLength occurs before the admin password is set. Test plan: 1) Drop and recreate your database, and restart_all 2) Go through installation and onboarding 3) Note that the order of steps is: 1 Create a library 2 Create a ptron category 3 Create Koha administrator patron 4 Create a new item type 5 Create a new circulation rule 6 Set minPasswordLength syspref/Complete 4) Repeat steps 1 & 2 5) Note that the order of steps is now: 1 Create a library 2 Create a patron category 3 Set minPasswordLength syspref 4 Create Koha administrator patron 5 Create a new item type 6 Create a new circulation rule/Complete 6) Verify that the minPasswordLength syspref is set to the value from onboarding 7) Verify that the patron, item type, and circulation rule made in the onboarding exist in the administration 8) Sign off! Sponsored-by Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22596] html TT filter is breaking items search with custom field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22596 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22596] html TT filter is breaking items search with custom field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22596 Liz Rea changed: What|Removed |Added Attachment #87071|0 |1 is obsolete|| --- Comment #2 from Liz Rea --- Created attachment 87123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87123=edit Bug 22596: use raw TT filter in items search with custom field When items search is with a custom field using authorised values, html TT filter is breaking the JS, it should use raw. Test plan : 1) Go to Administration > Item search fields 2) Define a search field with an authorised values category 3) Go to items search 4) Use the "New field" link 5) Check use of custom field is OK Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22594] Validate SMS messaging numbers using the E.164 format
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22594 Liz Rea changed: What|Removed |Added Attachment #87073|0 |1 is obsolete|| --- Comment #5 from Liz Rea --- Created attachment 87122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87122=edit Bug 22594: Validate SMS messaging numbers using the E.164 format Many SMS messaging services reject numbers that do not conform to the E.164 international public telecommunication numbering plan. We already tell patrons on the OPAC "Please enter numbers only. (123) 456-7890 would be entered as 1234567890." but we do not enforce this. We should be validating the patron's SMS number on both the staff side and the patron self-service for updating the SMS number. Test plan: 1) Apply this patch 2) Enable SMS message ( you can set to Email to enable ) 3) Test entering and updating SMS numbers on the OPAC and staff interfaces. 4) Note you can only enter a 1 to 14 digit number with an optional + sign at the beginning ( used to indicate the number includes a country calling code ) Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22594] Validate SMS messaging numbers using the E.164 format
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22594 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21014] Availability of hidden items showing in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21014 --- Comment #3 from Marjorie Barry-Vila --- Hi, I repeat this problem with the system preference hidelostitems on 18.05, you too? Marjorie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21014] Availability of hidden items showing in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21014 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18062] Damaged Status shows unavailable in results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18062 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 --- Comment #33 from Martin Renvoize --- (In reply to Katrin Fischer from comment #30) > > It just appears to me like thsi approach will open anoher can of worms. > > - Which homelibrary to use for those users? > - Which patron category? > - How to keep people from deleting or changing them? > - How to prevent that they change statistics in an unwanted way? (if they > have a branch and a patron category) No homelibrary, see patches No categorycode, see patches We can't if they're doing so directly in the db or a home grown script. But the patch does attemp to prevent it if they're using Koha object as they should. We also prevent these users from being searched at a pretty low level in code, see patches. As I saw, this is all now proof of concept code open for opinion and discussion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 --- Comment #12 from Tomás Cohen Arazi --- (In reply to Liz Rea from comment #11) > Created attachment 87121 [details] [review] > Bug 10796: (QA Follow-up) Changing password recovery verbiage for users who > are disallowed online password resets Thank you!!! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 --- Comment #32 from Martin Renvoize --- Well, I've de-escalated this one by resolving the constraint problem a simpler way in bug 22593. So, this now serves as proof of concept code which could let us further constrain some things in the database and allow for other uses of system type users (anonymous user seems a good case, splitting up Cron, command line scripts). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 --- Comment #8 from Liz Rea --- Created attachment 87118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87118=edit Bug 10796: Add Koha::Patron::Category->effective_change_password method This method checks whether the local $self->change_password is set to override the OpacPasswordChange syspref (i.e. if it is set to a bool) or undef, in which case it falls back to the value of the syspref To test: - Apply this patches - Make sure the DB is updated: $ updatedatabase - Update the schema files: $ dbic - Run: $ kshell k$ prove t/db_dependent/Koha/Patron/Category.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 --- Comment #10 from Liz Rea --- Created attachment 87120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87120=edit Bug 10796: Use $category->effective_change_password in the OPAC This patch makes the OPAC pages that rely on OpacPasswordChange use the current patron's category to make the decision to allow password change or not. It does so by making sure all the places in which OpacPasswordChange was used, use $logged_in_user->category->effective_change_password instead. Special attention is required on the case of opac-registration-verify.pl in which the use of an unblessed Koha::Patron object is changed in favour of the blessed object, so we can actually use the new method to make a decision on the text to display. To test: - Go through the OPAC pages, check that the password change strings and links are displayed only whne appropriate. - Sign off :-D Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 Liz Rea changed: What|Removed |Added Attachment #85389|0 |1 is obsolete|| Attachment #85390|0 |1 is obsolete|| Attachment #85391|0 |1 is obsolete|| Attachment #85392|0 |1 is obsolete|| --- Comment #7 from Liz Rea --- Created attachment 87117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87117=edit Bug 10796: DB update Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 --- Comment #11 from Liz Rea --- Created attachment 87121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87121=edit Bug 10796: (QA Follow-up) Changing password recovery verbiage for users who are disallowed online password resets -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 --- Comment #9 from Liz Rea --- Created attachment 87119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87119=edit Bug 10796: Handle can_change_password on the staff interface This patch makes the staff interface handle the new flag when editing the categories. I didn't add the flag to the list of categories table because it makes it too big, but can be easily added if required by users or QA. To test: - Along with other patches from this bug, edit patron categories => SUCCESS: Notice the changes are correctly stored - Sign off :-D Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22586] IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 ByWater Sandboxes changed: What|Removed |Added Attachment #87096|0 |1 is obsolete|| --- Comment #3 from ByWater Sandboxes --- Created attachment 87116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87116=edit Bug 22586: IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl As of 18.11 the IntranetReportsHomeHTML syspref no longer renders HTML on report-home.pl. I think this is being filtered wrong in the template. Test Plan: 1) Edit IntranetReportsHomeHTML, set to "Test" 2) View a report, note that you see the html p tags are displayed litterly 3) Apply this patch 4) Reload the page 5) Note the p tags are rendered as html Signed-off-by: George Williams -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #35 from Martin Renvoize --- (In reply to Josef Moravec from comment #21) > Comment on attachment 86919 [details] [review] > Bug 22521: Update fines handling to use accountline.status > > Review of attachment 86919 [details] [review]: > - > > ::: Koha/Account.pm > @@ +471,4 @@ > > itemnumber=> $item_id, > > issue_id => $issue_id, > > branchcode=> $library_id, > > +( $type eq 'overdue' ? ( lastincrement => $amount ) : > > ()), > > Does it make sense to you to make this dependent also on 22516, which > removes lastincrement column? Thanks for the quick testing and signoff. Can't believe I let those tests slip through in that state. As for the dependency on bug 22516.. Isort of agree but didn't want to make the tree look too complicated.. hopefully it'll be pushed imminently and it should be a trivial rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22588] Simplify getting account information in opac and self checkout module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22588
Tomás Cohen Arazi changed:
What|Removed |Added
CC||tomasco...@gmail.com
--- Comment #4 from Tomás Cohen Arazi ---
I like the idea in general but:
- shouldn't we be using line.{is_debit|is_credit} instead of comparing
line.amount > 0? Keep in mind that we found pathological cases in the wild
where the amountoutstanding got flipped. We better rely on the methods we have.
- The fact that we aren't using $account->outstanding_debits and
$account->outstanding_credits but instead keep searching for all accountlines
makes some noise to me. I guess it is not straightforward as we want to display
all outstanding debits and credits ordered by date. Just something to think
about a bit. Maybe we should add amountountstanding => { '!=' => 0 } to the
search line.
- We could replace the search with
my $account = $patron->account;
my $total = $account->balance;
my $lines = $account->lines;
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 --- Comment #23 from Agustín Moyano --- (In reply to Owen Leonard from comment #20) > I hope you don't mind the minor follow-up. I can submit on a separate bug if > that's better. Looks great, thanks :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #81 from Tomás Cohen Arazi --- Created attachment 87114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87114=edit Bug 13895: Fix test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #82 from Tomás Cohen Arazi --- Created attachment 87115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87115=edit Bug 13895: (QA follow-up) Make the class plural Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #79 from Tomás Cohen Arazi --- Created attachment 87112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87112=edit Bug 13895: (follow-up) Fix POST response Test plan: prove t/db_dependent/api/v1/chcekouts.t Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #80 from Tomás Cohen Arazi --- Created attachment 87113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87113=edit Bug 13895: Adapt naming according to voted RFC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895
--- Comment #78 from Tomás Cohen Arazi ---
Created attachment 87111
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87111=edit
Bug 13895: Change renewal endpoint
Instead of PUT on /checkout/{checkout_id} endpoint, you should now call
POST on /checkouts/{checkout_id}/renewal
Test plan:
prove t/db_dependent/api/v1/checkouts.t
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895
--- Comment #72 from Tomás Cohen Arazi ---
Created attachment 87105
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87105=edit
Bug 13895: Add API routes for checkouts retrieval and renewal
GET /checkouts?borrowernumber={borrowernumber}
GET /checkouts/{checkout_id}
PUT /checkouts/{checkout_id}
+ unit tests in t/db_dependent/api/v1/checkouts.t
Test plan:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
cookie). You should have permission circulate_remaining_permissions.
2. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace
XXX with a borrowernumber that has checkouts) and check you receive
correct data
3. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an
existing checkout id) and check you receive correct data
4. Send PUT requests to http://yourlibrary/api/v1/checkouts/YYY until
the maximum number of renewals is reached (you should have a 403
error)
5. Run unit tests in t/db_dependent/api/v1/checkouts.t
Depends on bugs 16699 and 14868
Signed-off-by: Benjamin Rokseth
Signed-off-by: Lari Taskula
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #75 from Tomás Cohen Arazi --- Created attachment 87108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87108=edit Bug 13895: Remove the opac checks in privileged endpoint Test plan: prove t/db_dependent/api/v1/checkouts.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #77 from Tomás Cohen Arazi --- Created attachment 87110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87110=edit Bug 13895: Refactor test using REST Basic auth Test plan: prove t/db_dependent/api/v1/checkouts.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #76 from Tomás Cohen Arazi --- Created attachment 87109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87109=edit Bug 13895: Remove create_item and create_biblio subs from test Test plan: prove t/db_dependent/api/v1/checkouts.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #73 from Tomás Cohen Arazi --- Created attachment 87106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87106=edit Bug 13895: (QA follow-up) Adjust OpenAPI definitions for checkouts Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #74 from Tomás Cohen Arazi --- Created attachment 87107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87107=edit Bug 13895: (follow-up) Adapt checkout endpoint to openapi, update terminology -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Tomás Cohen Arazi changed: What|Removed |Added Attachment #86120|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Tomás Cohen Arazi changed: What|Removed |Added Attachment #85462|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Tomás Cohen Arazi changed: What|Removed |Added Attachment #85461|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Tomás Cohen Arazi changed: What|Removed |Added Attachment #85464|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Tomás Cohen Arazi changed: What|Removed |Added Attachment #86579|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Tomás Cohen Arazi changed: What|Removed |Added Attachment #85459|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Tomás Cohen Arazi changed: What|Removed |Added Attachment #85463|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Tomás Cohen Arazi changed: What|Removed |Added Attachment #86580|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Tomás Cohen Arazi changed: What|Removed |Added Attachment #85460|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Tomás Cohen Arazi changed: What|Removed |Added Attachment #85458|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Julian Maurice changed: What|Removed |Added Attachment #85242|0 |1 is obsolete|| --- Comment #17 from Julian Maurice --- Created attachment 87104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87104=edit Bug 18745: Add foreign key constraint on subscription.aqbooksellerid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Julian Maurice changed: What|Removed |Added Attachment #85241|0 |1 is obsolete|| --- Comment #16 from Julian Maurice --- Created attachment 87103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87103=edit Bug 18745: kohastructure.sql: Move aqbooksellers above serial Otherwise we can't define a foreign key in serial that references aqbooksellers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Julian Maurice changed: What|Removed |Added Attachment #85240|0 |1 is obsolete|| --- Comment #15 from Julian Maurice --- Created attachment 87102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87102=edit Bug 18745: Serial claims: save supplier info on serial-level This allows to change the subscription's supplier while keeping the info of supplier for previous serials, which allows to claim late/missing serials to the right supplier Test plan: 1. Create 2 suppliers, S1 and S2 2. Create a new subscription with S1 3. Generate some late/missing serials 4. Change supplier to S2 5. Generate some more late/missing serials 6. Go to /cgi-bin/koha/serials/claims.pl and see you have late/missing issues for both suppliers 7. Check that you have the expected issues for each supplier 8. prove t/db_dependent/Serials/Claims.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #64083|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #65791|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #34 from Josef Moravec --- Created attachment 87101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87101=edit Bug 22521: (QA follow-up) Corrections to tests Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #33 from Josef Moravec --- Created attachment 87100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87100=edit Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #31 from Josef Moravec --- Created attachment 87098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87098=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #32 from Josef Moravec --- Created attachment 87099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87099=edit Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Josef Moravec changed: What|Removed |Added Attachment #87083|0 |1 is obsolete|| Attachment #87084|0 |1 is obsolete|| Attachment #87085|0 |1 is obsolete|| Attachment #87086|0 |1 is obsolete|| Attachment #87087|0 |1 is obsolete|| --- Comment #30 from Josef Moravec --- Created attachment 87097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87097=edit Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22586] IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22586] IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 Lucas Gass changed: What|Removed |Added Attachment #87095|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 87096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87096=edit Bug 22586: IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl As of 18.11 the IntranetReportsHomeHTML syspref no longer renders HTML on report-home.pl. I think this is being filtered wrong in the template. Test Plan: 1) Edit IntranetReportsHomeHTML, set to "Test" 2) View a report, note that you see the html p tags are displayed litterly 3) Apply this patch 4) Reload the page 5) Note the p tags are rendered as html -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22586] IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 --- Comment #1 from Lucas Gass --- Created attachment 87095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87095=edit Bug 22586: fix IntranetReportsHomeHTML filter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22598] New: Add support for EDI Claims for Serials (OSTENQ)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22598 Bug ID: 22598 Summary: Add support for EDI Claims for Serials (OSTENQ) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.fi...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com Target Milestone: --- EBSCO (and potentially other serials vendors) support the receipt of EDIFACT Claims using the OSTENQ format (Order Status Enquiry). https://www.editeur.org/files/EDIfact%20eancom%20pdfs/EDIfact%20Serials/S4%20OSTENQ%20v1.3%20(serials).pdf They require the EBSCO Vendor Order Number in the RFF+SNA segment as the match point to identify the customer order in their system. Volume and Issue details for the items being claimed would also be required. Development to add KOHA as an ILS Vendor for claims would be required on the EBSCO end as well before we could do any testing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 --- Comment #5 from Martin Renvoize --- Created attachment 87094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87094=edit Bug 22563: (follow-up) Corrections for tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize changed: What|Removed |Added Attachment #86914|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 87093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87093=edit Bug 22563: Update lost handling to use accountline.status Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #21 from Martin Renvoize --- Created attachment 87091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87091=edit Bug 22511: (follow-up) Fix test plans Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize changed: What|Removed |Added Attachment #86913|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 87092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87092=edit Bug 22563: Be more descriptive with accountypes Convert 'L' to 'LOST' to become more descriptive in it's use. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize changed: What|Removed |Added Attachment #86917|0 |1 is obsolete|| --- Comment #20 from Martin Renvoize --- Created attachment 87090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87090=edit Bug 22511: Update UI to use accountlines.status Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize changed: What|Removed |Added Attachment #86915|0 |1 is obsolete|| --- Comment #18 from Martin Renvoize --- Created attachment 87088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87088=edit Bug 22511: Update tests Updated tests to check for 'status' change and fixed 'accounttype' and moved from t/db_dependent/Accounts.t to the more appropriate t/db_dependent/Koha/Account/Lines.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize changed: What|Removed |Added Attachment #86916|0 |1 is obsolete|| --- Comment #19 from Martin Renvoize --- Created attachment 87089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87089=edit Bug 22511: Update void method to use status We added a 'status' field to 'accountlines' in bug 22512 to allow for more fined grained control over 'types' and 'states'. This patch updates the void method to utilise this new field so we may keep the original credit type for later auditing should it be required. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize changed: What|Removed |Added Attachment #86920|0 |1 is obsolete|| --- Comment #27 from Martin Renvoize --- Created attachment 87085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87085=edit Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize changed: What|Removed |Added Attachment #86921|0 |1 is obsolete|| --- Comment #28 from Martin Renvoize --- Created attachment 87086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87086=edit Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize changed: What|Removed |Added Attachment #86919|0 |1 is obsolete|| --- Comment #26 from Martin Renvoize --- Created attachment 87084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87084=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize changed: What|Removed |Added Attachment #87063|0 |1 is obsolete|| --- Comment #29 from Martin Renvoize --- Created attachment 87087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87087=edit Bug 22521: (QA follow-up) Corrections to tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize changed: What|Removed |Added Attachment #86918|0 |1 is obsolete|| --- Comment #25 from Martin Renvoize --- Created attachment 87083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87083=edit Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 Alex Arnaud changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com QA Contact||josef.mora...@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 --- Comment #14 from Josef Moravec --- Created attachment 87082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87082=edit Bug 10577: (QA follow-up) Remove tab chars Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Josef Moravec changed: What|Removed |Added Attachment #87010|0 |1 is obsolete|| --- Comment #13 from Josef Moravec --- Created attachment 87081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87081=edit Bug 10577: (QA follow-up) Remove bad call signature Whilst working through this patch for signoff I found a case where the calling signature of GetBudgetPeriod was incorrect. I removed the superflous passed parameter in this followup Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Josef Moravec changed: What|Removed |Added Attachment #87009|0 |1 is obsolete|| --- Comment #12 from Josef Moravec --- Created attachment 87080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87080=edit Bug 10577: Improve semantics of GetBudgetPeriod() Remove the option to pass zero to this function in order to get "the" active budget. This was a problem in three ways: - Koha doesn't require that there be only one active budget at a time, so the concept of "the" active budget doesn't make sense. - Having the single parameter be either an ID or a flag based on its value is poor function design. - No callers of GetBudgetPeriod() were actually using this modality. This patch also improves the DB-dependent tests for budgets by - wrapping the test in a transaction - counting budgets correctly To test: [1] Apply the patch. [2] Verify that prove -v t/db_dependent/Budgets.t passes [3] Verify in the staff interface that: - the budget hierarchy displays correctly - you can add and modify a budget Signed-off-by: Galen Charlton Rescued-by: Martin Renvoize Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What|Removed |Added Depends on|22008 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 [Bug 22008] accountlines.manager_id is missing a foreign key constraint -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What|Removed |Added Blocks|22421 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 [Bug 22421] accountlines.issue_id is missing a foreign key constraint -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22518] accounttype 'O' is still referred to but is never set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 Martin Renvoize changed: What|Removed |Added Depends on||22593 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22547] C4::Overdues - UpdateFine is barely tested
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 Martin Renvoize changed: What|Removed |Added Depends on||22593 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Martin Renvoize changed: What|Removed |Added Depends on||22593 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What|Removed |Added Depends on|22593 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 Martin Renvoize changed: What|Removed |Added Blocks|14825 |22518, 22512, 22547 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 [Bug 22518] accounttype 'O' is still referred to but is never set https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 [Bug 22547] C4::Overdues - UpdateFine is barely tested -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22501] OPAC course reserves notes should allow html links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Lucas Gass changed: What|Removed |Added Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
