[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #266 from Josef Moravec  ---
(In reply to David Cook from comment #265)
> (In reply to Josef Moravec from comment #264)
> > I tested again. I have to say it is looking good. So there  is the only last
> > thing, but big one: the tests...
> 
> Awesome! I am very busy at the moment, but I'll get to the tests when I have
> some time.

David, do you think it is possible for you to write test as soon as it could
get into 19.05 release? It would be great to have it in 19.05...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22333] Replace duplicated code in CanBookBeRenewed with GetSoonestRenewDate

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22333

--- Comment #9 from David Cook  ---
(In reply to Liz Rea from comment #8)
> Hi David,
> 
> I got test failures too, as follows, have a look?
> 
> Liz
> 

Ahhh thanks for that output. I'll take a look when I have a moment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22625] Improvements to the onboarding tool

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22625

--- Comment #1 from Hayley Mapley  ---
(In reply to Hayley Mapley from comment #0)
> There are many bug reports which are dedicated to certain inclusions into
> the onboarding tool. To prevent merge conflicts and fussing with
> dependencies, I have decided to group them all into one bug report, here. 
> 
> The aspects to be included in this patch are from the following bugs:
> - Bug 18002: Aquisitions onboarding tool - to help users set up acquisitions
> the first time/Bug 1 - Include the definition of currency in onboarding
> tool
> - Bug 18308 - Default value of minPasswordLength should be increased
> - Bug 21265 - Additional step at end of onboarder to enable HEA

Actually, Bug 18002 should not be included here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22625] New: Improvements to the onboarding tool

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22625

Bug ID: 22625
   Summary: Improvements to the onboarding tool
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Installation and upgrade (web-based installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: hayleymap...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
  Target Milestone: ---

There are many bug reports which are dedicated to certain inclusions into the
onboarding tool. To prevent merge conflicts and fussing with dependencies, I
have decided to group them all into one bug report, here. 

The aspects to be included in this patch are from the following bugs:
- Bug 18002: Aquisitions onboarding tool - to help users set up acquisitions
the first time/Bug 1 - Include the definition of currency in onboarding
tool
- Bug 18308 - Default value of minPasswordLength should be increased
- Bug 21265 - Additional step at end of onboarder to enable HEA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22625] Improvements to the onboarding tool

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22625

Hayley Mapley  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |hayleymap...@catalyst.net.n
   |ity.org |z
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Hayley Mapley  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Hayley Mapley  changed:

   What|Removed |Added

  Attachment #69462|0   |1
is obsolete||
  Attachment #87124|0   |1
is obsolete||
  Attachment #87129|0   |1
is obsolete||

--- Comment #30 from Hayley Mapley  ---
Created attachment 87340
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87340=edit
Bug 18308 - Added warning and dialog alert

Works great if you apply bug 19514 before

If an institution has a minPasswordLength which is < 8 characters then a
warning
will be set (which is visible in the intranet-error.log) and a dialog
alert div will display the warning to the user in the memberentry.pl
page in the intranet.

Test plan:
1. Ensure that your minPasswordLength is set to less than 8 characters.
This replicates the use case that a Koha instance is existing (i.e. not
a new Koha instance) and not gone through the password length step of
the onboarding tool (previous patch on this bug report) or that the
institituion is new but set a password length of less than 8 in the
onboarding tool

2. Go to the memberentry.pl page and notice that there is no warning
at the top of the page informing you that your minPasswordLength is less
than 8

3. Apply this patch

4. Refresh the memberentry.pl page and notice that there is a yellow
warning at the top of the page informing you that your minPasswordLength
syspref is less than 8

Sponsored-By: Catalyst IT
Signed-off-by: Dominic Pichette 

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Hayley Mapley  changed:

   What|Removed |Added

  Attachment #69461|0   |1
is obsolete||

--- Comment #29 from Hayley Mapley  ---
Created attachment 87339
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87339=edit
Bug 18308 - Added step to onboarding tool to set minPasswordLength

This patch increases the default minPasswordLength syspref value to 8
characters, for new installations.

The final (6th step) of the onboarding tool is now a password length
page where the default value of 8 can be altered. There is a security warning
in red recommending to the user they
keep the minimum length of the password at 8 characters or more.

This patch also removes the atomicupdate .sql file to be run in an update to
alter the default
minPasswordLength value for existing Koha installations, based on tester
feedback.

Test plan:
1. Create a patron with a password less than 3 characters in length and
notice that a red message is displayed by the input telling you that the
password must be 3 characters minimum length

2. Query the database "select value from systempreferences where
variable="minPasswordLength"; and notice the value is 3

3. Drop and recreate your database and restart memcached

4. Go through the web installer and onboarding tool. Noticing the last
step of the onboarding tool is to create a circulation rule

5. Apply patch

6. Repeat step 3

7. Go through the web installer and onboarding tool. Noticing the last
step of the onboarding tool is to set the minimum password length, the
numerical input element has a default value of 8 and notice that it will
go below 3

8. Repeat step 2 and notice the value is 8

9. In the onboarding tool change the minimum password length value to 7
and submit the form

10. Notice the completed page of the onboarding tool is displayed with
the message that the minimum password length has been set.

11. Repeat step 2 and notice the value is now 7.

12. Try to create a patron in Intranet and OPAC with a password less
than 7 characters and notice that a red message is displayed by the
input telling you that the password must be 7 characters minimum length

Sponsored-By: Catalyst IT

Signed-off-by: David Bourgault 

https://bugs.koha-community.org/show_bug.cgi?id=6473

Hayley Mapley: Fixed merge conflicts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

--- Comment #34 from Hayley Mapley  ---
Created attachment 87338
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87338=edit
Bug 18450: (follow up) Fixed forbidden patterns for qa tool

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

Hayley Mapley  changed:

   What|Removed |Added

  Attachment #86590|0   |1
is obsolete||
  Attachment #86591|0   |1
is obsolete||

--- Comment #33 from Hayley Mapley  ---
Created attachment 87337
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87337=edit
Bug 18450: Only allow Override for renewals according to relevant sysprefs

This patch adds a conditional which refers to the system preferences
AllowRenewalIfOtherItemsAvailable and AllowRenewalLimitOverride to
control the display of the 'Override and renew' button, in addition to
the 'Continue without renewing', when renewing an item that has been
placed on hold.

Test plan:

--NOTE-- The following renewals must be completedd in Circulation->Renew

1) Apply the patch, and ensure the following steps work as described

2) In More->Administration->Global system preferences ensure that both
the AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvailable
preferences are both set to 'Don't allow'

3) Item levelOnly one available item:
Try to renew an item (with item level hold on it) which belongs to a
biblio with only one item. Note the only button in the yellow alert
box displayed is 'Continue without renewing'

4) Record level/Only one available item:
Try to renew an item (this time with a 'Next Available' hold on the
record) which belongs to a biblio with only one item. Note the only
button in the yellow alert box displayed is 'Continue without
renewing'

5) Item level/Multiple available items:
Try to renew an item (with item level hold on it) which belongs to a
biblio with multiple available items of it in the catalogue. Note
only the 'Continue without renewing' button is displayed

6) Record level/Multiple available items:
Try to renew an item (with item level hold on it) which belongs to a
biblio with multiple available items of it in the catalogue. Note
only the 'Continue without renewing' button is displayed

7) Set both AllowRenewalLimitOverride and
AllowRenewalIfOtherItemsAvailable system preferences to 'Allow'

8) Repeat step 3, and note only the 'Continue without renewing' button
is displayed in the yellow alert box

9) Repeat step 4, and note the only button in the yellow alert box
displayed is 'Continue without renewing'

10) Repeat step 5, not only the 'Continue without renewing' button is
displayed (because the hold is for that specific item)

11) Repeat step 6, note the item is immediately renewed and the yellow
alert box is not displayed

12) Set the AllowRenewalIfOtherItemsAvailable to 'Don't Allow' and
repeat steps 3-6, and note that only the 'Continue without renewing'
button is displayed

13) Set the AllowRenewalIfOtherItemsAvailable system preference back to
'Allow' and AllowRenewalLimitOverride syspref to 'Don't Allow', and
repeat steps 3-5 and note only the 'Continue without renewal' button is
displayed.

14) Repeat step 6 and note that the item is immediately renewed with no
yellow warning box.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

Hayley Mapley  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22618] Tests in t/Acquisition.t are actually database dependent

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22618

Michal Denar  changed:

   What|Removed |Added

  Attachment #87328|0   |1
is obsolete||

--- Comment #2 from Michal Denar  ---
Created attachment 87336
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87336=edit
Bug 22618: Move tests to t/db_dependent/Acquisition.t

prove -v t/db_dependent/Acquisition.t

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22618] Tests in t/Acquisition.t are actually database dependent

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22618

Michal Denar  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

--- Comment #119 from Michal Denar  ---
Hi Ere,
tests passed, but I'm not able to import attached files:

kohadev-koha@kohadevbox:/home/vagrant/kohaclone$
misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m
MARCXML

0 MARC bibliographic records and 0 holdings records done in 0.012 seconds

Any ideas?

Thank you.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22541] Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22541

Michal Denar  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22541] Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22541

--- Comment #7 from Michal Denar  ---
Created attachment 87335
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87335=edit
Bug 22541: Use invoicenumber and link to invoice on spent and ordered pages

To test:
 1 - Find a vendor in acquisitions
 2 - Click 'receive shipment'
 3 - Create an invoice
 4 - Click 'Finish receiving'
 5 - Add an adjustment that encumbers while open and update adjustments
 6 - Go to acqui-home and click on the ordered total for the fund with the
adjustment
 7 - Note the invoice adjustment shows the invoice id and does not link
 8 - Add another invoice and another adjustment, but close the invoice this
time
 9 - Go to acqui-home and click on the spent total for the fund with the
adjustment
10 - Note the invoice adjustment shows the invoice id and does not link
11 - Apply patch
12 - Visit the spent and ordered pages and note the adjustments show
invoicenumber and are links
13 - prove -v t/db_dependent/Koha/Acquisition/Invoice/Adjustments.t

Signed-off-by: Liz Rea 
Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22541] Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22541

Michal Denar  changed:

   What|Removed |Added

  Attachment #86871|0   |1
is obsolete||
  Attachment #86972|0   |1
is obsolete||

--- Comment #6 from Michal Denar  ---
Created attachment 87334
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87334=edit
Bug 19380: Use Koha::Item::get_transfer instead of GetTransfers

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

Signed-off-by: Michal Denar 

https://bugs.koha-community.org/show_bug.cgi?id=22541

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

--- Comment #32 from Hayley Mapley  ---
(In reply to Martin Renvoize from comment #31)
> Did this get fixed somewhere else already.. looks like both patches are
> applied but I can't seen any reference to them in the git logs.

This has not yet been fixed in the master, which I have verified by following
the test plan on a branch off the master this morning. I will fix the patch so
it applies now so it can be tested. This patch builds off Alex's previous
commits, so maybe they're further back in the git log? Unsure.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

Hayley Mapley  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #25 from Hayley Mapley  ---
(In reply to Liz Rea from comment #24)
> I'm a little confused - one of Alex's patches builds on bug 14576, but
> Hayley's seems to want us to test the 2 sysprefs? It looks like it might
> just be a commit message problem - i.e. we need alex's test plan, and this
> most recently rebased patch to be put together.
> 
> Have a look? I'm happy to test this once I know all the bits are in the
> right order. :)
> 
> Liz

Hi Liz,

I think what happened here is I squashed the commits for simplicity, but used
the first patch to squash them into rather than the follow up patch which
builds on 14576. The behaviour should be the same, and testing should follow
Comment 11. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22611] Typo introduced into Koha::EDI by bug 15685

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22611] Typo introduced into Koha::EDI by bug 15685

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #87327|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer  ---
Created attachment 87333
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87333=edit
Bug 22611: Correction for call to get create_item in EDI.pm

There was a typo in the addition of a call to
effective_create_items causing processing to abort after adding
a single copy.

This patch reverts to using the C4::Context call as used for the
first copy created, the intended call to effective_create_items
is a wrapper around that as the field in the basket is guaranteed
to be null (its not set when we call AddBasket). Being consistent
and explicit in what we call should guard against future changes
in dependencies exposing the logic flaw

Added some comments to make logical flow of code clearer

Signed-off-by: Liz Rea 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22624] Show OPAC description for authorised values in OPAC

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22624

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22620] OPAC description for collection in opac-reserve.tt

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22620

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22624

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22624] Show OPAC description for authorised values in OPAC

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22624

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22620

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22624] Show OPAC description for authorised values in OPAC

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22624

--- Comment #1 from Katrin Fischer  ---
Created attachment 87332
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87332=edit
Bug 22624: Show OPAC description for authorised values in OPAC

Patch adds the IS_OPAC parameter to a few GetByCode calls in
OPAC files.

To test:
- Add different OPAC and intranet descriptions to some authorised
  value categories:
  - TERM
  - DEPARTMENT
  - LOC
  - CCODE
- Create a new course using the values and adding items to it
- Check the course reserves overview and detail pages in OPAC
- Verify Department, term, location, and collection show
  the OPAC description if existing
- Create a subscription, make sure a default location is selected
- Check the OPAC detail page, subscription tab for this subsription
  in the OPAC
- Verify the location of the subscription displays correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22624] Show OPAC description for authorised values in OPAC

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22624

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22624] Show OPAC description for authorised values in OPAC

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22624

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22333] Replace duplicated code in CanBookBeRenewed with GetSoonestRenewDate

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22333

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #8 from Liz Rea  ---
Hi David,

I got test failures too, as follows, have a look?

Liz

#   Failed test 'Bug 14101: Cannot renew, renewal is automatic (returned code
is auto_renew)'
#   at t/db_dependent/Circulation.t line 601.
#  got: 'auto_too_soon'
# expected: 'auto_renew'

#   Failed test 'Cannot renew, renew is automatic'
#   at t/db_dependent/Circulation.t line 643.
#  got: 'auto_too_soon'
# expected: 'auto_renew'

#   Failed test 'Cannot renew, renew is automatic'
#   at t/db_dependent/Circulation.t line 661.
#  got: 'auto_too_soon'
# expected: 'auto_renew'
# Looks like you failed 2 tests of 14.

#   Failed test 'too_late_renewal / no_auto_renewal_after'
#   at t/db_dependent/Circulation.t line 662.

#   Failed test 'Can auto renew, OPACFineNoRenewals=10, patron has 5'
#   at t/db_dependent/Circulation.t line 695.
#  got: 'auto_too_soon'
# expected: 'auto_renew'

#   Failed test 'Can auto renew, OPACFineNoRenewals=10, patron has 10'
#   at t/db_dependent/Circulation.t line 708.
#  got: 'auto_too_soon'
# expected: 'auto_renew'
# Looks like you failed 2 tests of 6.
t/db_dependent/Circulation.t .. 60/125 
#   Failed test 'auto_too_much_oweing | OPACFineNoRenewalsBlockAutoRenew'
#   at t/db_dependent/Circulation.t line 724.

#   Failed test 'Can auto renew, patron is expired but
BlockExpiredPatronOpacActions=0'
#   at t/db_dependent/Circulation.t line 750.
#  got: 'auto_too_soon'
# expected: 'auto_renew'

#   Failed test 'Can auto renew, BlockExpiredPatronOpacActions=1 but patron
is not expired'
#   at t/db_dependent/Circulation.t line 774.
#  got: 'auto_too_soon'
# expected: 'auto_renew'
# Looks like you failed 2 tests of 6.

#   Failed test 'auto_account_expired | BlockExpiredPatronOpacActions'
#   at t/db_dependent/Circulation.t line 776.
t/db_dependent/Circulation.t .. 125/125 # Looks like you failed 4 tests of 125.
t/db_dependent/Circulation.t .. Dubious, test returned 4 (wstat 1024, 0x400)
Failed 4/125 subtests 

Test Summary Report
---
t/db_dependent/Circulation.t (Wstat: 1024 Tests: 125 Failed: 4)
  Failed tests:  58-61
  Non-zero exit status: 4
Files=1, Tests=125, 36 wallclock secs ( 0.11 usr  0.01 sys + 25.60 cusr  4.60
csys = 30.32 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22624] New: Show OPAC description for authorised values in OPAC

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22624

Bug ID: 22624
   Summary: Show OPAC description for authorised values in OPAC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

Bug 22620 fixed an occurrence where the AuthorisedValues TT plugin was used
without the 1 parameter for OPAC interface. There are some more to fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22619] Adding a new circ rule with unlimited checkouts is broken

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619

Liz Rea  changed:

   What|Removed |Added

  Attachment #87305|0   |1
is obsolete||

--- Comment #3 from Liz Rea  ---
Created attachment 87331
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87331=edit
Bug 22619: Fix null empty behaviour for new rules

To test:
 1 - Go to Admin->Circulation and fines rules
 2 - Set All/All rules ot have a limit for Current checkouts allowed (and
onsite checkouts allowed)
 3 - Select an itemtype to add a new rule
 4 - Save without entering any values
 5 - Note that new rule displays with the same numebr as the all/all rule
 6 - Check the DB, not no lines were added to circulation_rules table
 7 - Delete the rule from the staff client
 8 - Apply patch
 9 - Repeat, note the new rule is unlimited
10 - Run selenium tests
11 - They pass!
12 - Check no rules/itemtypes are added to your system by the tests

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22619] Adding a new circ rule with unlimited checkouts is broken

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22620] OPAC description for collection in opac-reserve.tt

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22620

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #87322|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 87330
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87330=edit
Bug 22620: OPAC description for CCODE in opac-reserve.tt

Bug 20450 added CCODE to opac-reserve.tt using AuthorisedValues TT plugin.

This patch changes the plugin call so that it requests OPAC description.

Test plan :
1) Define a CCODE with staff and OPAC descriptions
2) Apply this collection on an item
3) At OPAC, place an hold on this item
4) Verify the collection display correctly OPAC description and not staff
description

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22620] OPAC description for collection in opac-reserve.tt

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22620

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22501] OPAC course reserves notes should allow html links

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501

Liz Rea  changed:

   What|Removed |Added

  Attachment #87127|0   |1
is obsolete||

--- Comment #2 from Liz Rea  ---
Created attachment 87329
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87329=edit
Bug 22501: OPAC course reserves notes should allow html links

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22501] OPAC course reserves notes should allow html links

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22620] OPAC description for collection in opac-reserve.tt

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22620

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Summary|OPAC description for CCODE  |OPAC description for
   |in opac-reserve.tt  |collection in
   ||opac-reserve.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21890] Allow forgotten password functionality to be limited by patron category

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890

Liz Rea  changed:

   What|Removed |Added

Summary|Patron password reset by|Allow forgotten password
   |category|functionality to be limited
   ||by patron category

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10796] Allow password changes for logged in OPAC users by patron category

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796

Liz Rea  changed:

   What|Removed |Added

Summary|Allow OpacPasswordChange to |Allow password changes for
   |be set by category type |logged in OPAC users by
   ||patron category

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

Nick Clemens  changed:

   What|Removed |Added

 Blocks||22618


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22618
[Bug 22618] Tests in t/Acquisition.t are actually database dependent
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22618] Tests in t/Acquisition.t are actually database dependent

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22618

Nick Clemens  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22618] Tests in t/Acquisition.t are actually database dependent

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22618

Nick Clemens  changed:

   What|Removed |Added

 Depends on||18736


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736
[Bug 18736] Problems in order calculations (rounding errors)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22618] Tests in t/Acquisition.t are actually database dependent

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22618

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com,
   ||wizzy...@gmail.com
   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22618] Tests in t/Acquisition.t are actually database dependent

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22618

--- Comment #1 from Nick Clemens  ---
Created attachment 87328
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87328=edit
Bug 22618: Move tests to t/db_dependent/Acquisition.t

prove -v t/db_dependent/Acquisition.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22618] Tests in t/Acquisition.t are actually database dependent

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22618

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796

Liz Rea  changed:

   What|Removed |Added

  Text to go in the||Libraries can now specify
  release notes||which patrons are allowed
   ||to change their password
   ||when logged into the OPAC,
   ||per patron category. A
   ||common use case for this
   ||would be a system that
   ||combines LDAP (or other
   ||external authentication)
   ||patrons and local Koha
   ||patrons. This feature will
   ||allow libraries to present
   ||a better user experience
   ||for password management to
   ||all of their patrons, no
   ||matter how they are
   ||authenticated.
 CC||wizzy...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21890] Patron password reset by category

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890

Liz Rea  changed:

   What|Removed |Added

  Text to go in the||Libraries can now specify
  release notes||which patrons are allowed
   ||to change their password
   ||through the Forgotten
   ||Password functionality in
   ||the OPAC, per patron
   ||category. A common use case
   ||for this would be a system
   ||that combines LDAP (or
   ||other external
   ||authentication) patrons and
   ||local Koha patrons. This
   ||feature will allow
   ||libraries to present a
   ||better user experience for
   ||password management to all
   ||of their patrons, no matter
   ||how they are authenticated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19690] Smart rules: Term "If any unavailable" is confusing

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19690

--- Comment #9 from Katrin Fischer  ---
Hm, I am not sure about the code sample, but I am pretty sure that's the
behaviour of you have onshelfholds = 0 as this was the way it used to work
before 2 was introduced. Maybe the check is done somewhere else to determine
biblio-level-holdability?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #29 from David Gustafsson  ---
Just rebased this, but need to test some more and make sure tests are not
broken. Should have that done by tomorrow.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22623] New: Item location and status details missing from Your Cart display on OPAC if any attached item has a status of Withdrawn.

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22623

Bug ID: 22623
   Summary: Item location and status details missing from Your
Cart display on OPAC if any attached item has a status
of Withdrawn.
 Change sponsored?: ---
   Product: Koha
   Version: 18.11
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: lucy.vaux-har...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

In the Your Cart display at /cgi-bin/koha/opac-basket.pl the item details in
the Location (status) column do not always display.  This appears to happen
when any item record attached to the bibliographic record has the status
Withdrawn.  Instead of hiding only the Withdrawn items (if added to
OpacHiddenItems) all items attached to the bibliographic record are hidden.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22619] Adding a new circ rule with unlimited checkouts is broken

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com
   Severity|major   |critical

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22611] Typo introduced into Koha::EDI by bug 15685

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611

Liz Rea  changed:

   What|Removed |Added

  Attachment #87225|0   |1
is obsolete||

--- Comment #5 from Liz Rea  ---
Comment on attachment 87225
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87225
Bug 22611: Correction for typo in Koha::EDI

Sorry I'm making a lot of noise >.<

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22611] Typo introduced into Koha::EDI by bug 15685

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611

Liz Rea  changed:

   What|Removed |Added

  Attachment #87225|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22611] Typo introduced into Koha::EDI by bug 15685

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com
  Attachment #87326|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22611] Typo introduced into Koha::EDI by bug 15685

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611

Liz Rea  changed:

   What|Removed |Added

  Attachment #87271|0   |1
is obsolete||

--- Comment #3 from Liz Rea  ---
Created attachment 87326
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87326=edit
Bug 19380: Use Koha::Item::get_transfer instead of GetTransfers

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22611] Typo introduced into Koha::EDI by bug 15685

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611

--- Comment #4 from Liz Rea  ---
Created attachment 87327
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87327=edit
Bug 22611: Correction for call to get create_item in EDI.pm

There was a typo in the addition of a call to
effective_create_items causing processing to abort after adding
a single copy.

This patch reverts to using the C4::Context call as used for the
first copy created, the intended call to effective_create_items
is a wrapper around that as the field in the basket is guaranteed
to be null (its not set when we call AddBasket). Being consistent
and explicit in what we call should guard against future changes
in dependencies exposing the logic flaw

Added some comments to make logical flow of code clearer

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22611] Typo introduced into Koha::EDI by bug 15685

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664

--- Comment #90 from Martin Renvoize  ---
Caveat.. if you're wanting related (JOINed) data you'll wan't to call
'prefetch' in the actual search call too...

I'm not entirely sure how Koha::Objects plays games here as it just adds a
further layer of complexity on top of DBIx::Class.. but I've certainly seen
realy solid results when I've used ::HashRefInflator in other projects

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664

--- Comment #89 from Martin Renvoize  ---
I'd be interested to see exactly what Koha::Object search call you were making
for comparison...

I've always found the SQL::Abstract query compilation really pretty quick..
it's the result inflation into DBIx::Class (and then Koha::Object) objects that
takes time.. This can be entirely skipped with
DBIx::Class::ResultClass::HashRefInflator and friends.. that's the approach I
would take personally I think.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582

--- Comment #21 from Martin Renvoize  ---
Awesome job, thanks for picking it up Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959

--- Comment #14 from Alex Arnaud  ---
(In reply to Jonathan Druart from comment #10)
> 
> 5) why do you use eval for the regex? Same as before, I feel like you should
> mimick Koha::SimpleMARC::_modify_values

This is the only way i've found to make the regex work with modifiers in a
variable. But i don't need it anymore since i've limited modifiers to i and g
like in Koha::SimpleMARC::_modify_values

I re-used a part of the code in Koha::SimpleMARC::_modify_values. And i don't
like code duplicating so much. So i'm thinking about a code refactoring:

 - directly use _modify_values (and take into account specificities),
 - create a common apply_regex() sub with unit tests. But where ? In
Koha/Util/* ? and use it in _modify_values
 - other ?

Any thougths ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959

Alex Arnaud  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959

--- Comment #13 from Alex Arnaud  ---
Created attachment 87325
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87325=edit
Bug 21959: allow only i and g regex modifiers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959

--- Comment #12 from Alex Arnaud  ---
Created attachment 87324
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87324=edit
Bug 21959: use a link instead of a checkbox

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #83470|0   |1
is obsolete||

--- Comment #11 from Alex Arnaud  ---
Created attachment 87323
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87323=edit
Bug 21959: Batch item modification - ability to apply regular expression on
text fields

Test plan:
  - go to Tools > Batch item modification,
  - select items to modify,
  - for one or some text fields, check the second checkbox (Use regular
expression) and type your regex,
  - check the regex has been applied.

Signed-off-by: Pierre-Marc Thibault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22620] OPAC description for CCODE in opac-reserve.tt

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22620

Owen Leonard  changed:

   What|Removed |Added

  Attachment #87306|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 87322
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87322=edit
Bug 22620: OPAC description for CCODE in opac-reserve.tt

Bug 20450 added CCODE to opac-reserve.tt using AuthorisedValues TT plugin.

This patch changes the plugin call so that it requests OPAC description.

Test plan :
1) Define a CCODE with staff and OPAC descriptions
2) Apply this collection on an item
3) At OPAC, place an hold on this item
4) Verify the collection display correctly OPAC description and not staff
description

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22620] OPAC description for CCODE in opac-reserve.tt

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22620

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21280] Unify MARC editor in biblios and authorities

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21280

Michal Denar  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21280] Unify MARC editor in biblios and authorities

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21280

--- Comment #21 from Michal Denar  ---
Created attachment 87320
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87320=edit
Bug 21280: Unify field types

Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21280] Unify MARC editor in biblios and authorities

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21280

--- Comment #20 from Michal Denar  ---
Created attachment 87319
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87319=edit
Bug 21280: Move MARC editor tabs to an include file

Moves the tabs code from addbiblio.tt to marc_editor.inc and changes
authorities.tt to use it too. Minor changes in the tabs code were needed to
support both functions. Adds support for toggling docs and tags for authorities
and updates default documentation links.

Test plan:
1. Test adding and editing biblio records and authority records.
2. Make sure visibility of fields is correct initially and when values are
added.
3. Make sure settings for tags and documentation links work and stick across
edits, also for authorities.

Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21280] Unify MARC editor in biblios and authorities

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21280

--- Comment #22 from Michal Denar  ---
Created attachment 87321
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87321=edit
Bug 21280: Add pref for MARC authority documentation url

Makes the documentation url for authorities separately configurable.

Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21280] Unify MARC editor in biblios and authorities

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21280

Michal Denar  changed:

   What|Removed |Added

  Attachment #87311|0   |1
is obsolete||
  Attachment #87312|0   |1
is obsolete||
  Attachment #87313|0   |1
is obsolete||
  Attachment #87314|0   |1
is obsolete||

--- Comment #19 from Michal Denar  ---
Created attachment 87318
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87318=edit
Bug 21280: Move MARC editor code to a common class

Combines the MARC editor code from addbiblio.pl and authorities.pl to a common
class.

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22594] Validate SMS messaging numbers using the E.164 format

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22594

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #87122|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22622] Add Koha::Object method _new_from_hashref

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22622

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22622] Add Koha::Object method _new_from_hashref

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22622

--- Comment #1 from Kyle M Hall  ---
Created attachment 87317
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87317=edit
Bug 22622: Add Koha::Object method _new_from_hashref

It may be useful to be able to instantiate a Koha::Object from data already
fetched from the database. This might be used for compatibility with legacy
code, or perhaps for use with optimized queries.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22622] New: Add Koha::Object method _new_from_hashref

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22622

Bug ID: 22622
   Summary: Add Koha::Object method _new_from_hashref
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

It may be useful to be able to instantiate a Koha::Object from data already
fetched from the database. This might be used for compatibility with legacy
code, or perhaps for use with optimized queries.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22622] Add Koha::Object method _new_from_hashref

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22622

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5161] patron attributes clearing if duplicate warning

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5161

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19690] Smart rules: Term "If any unavailable" is confusing

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19690

--- Comment #8 from Magnus Enger  ---
(In reply to Katrin Fischer from comment #7)
> Not quite, because it doesn't transport that it will take effect if at least
> one is on loan.

Ah, but that is not how the code in
C4::Reserves::IsAvailableForItemLevelRequest() works, I think: 

1163 sub IsAvailableForItemLevelRequest {
1164 my $item = shift;
1165 my $borrower = shift;
1166 my $pickup_branchcode = shift;
...
1196 if ( $on_shelf_holds == 1 ) { # Yes
1197 return 1;
1198 } elsif ( $on_shelf_holds == 2 ) { # If all unavailable
1199 my @items =
1200   Koha::Items->search( { biblionumber => $item->{biblionumber} }
);
1201 
1202 my $any_available = 0;
1203 
1204 foreach my $i (@items) {
1205 
...
1221 return $any_available ? 0 : 1;
1222 } else { # on_shelf_holds == 0 "If any unavailable" (the description
is rather cryptic and could still be improved)
1223 return $item->{onloan} || IsItemOnHoldAndFound(
$item->{itemnumber} );
1224 }
1225 }

If on_shelf_holds == 1 it always returns 1, the item that was passed in can
always be be put a hold on.

If on_shelf_holds == 2 it loops over all the items attached to the biblio of
the item that was passed in, so it can check if they all are unavailable or
not, and if any are available it returns 0. (There is a bug in how this is done
when holdallowed = 0 that I will report and submit a patch for soon.)

If on_shelf_holds == 0 it only checks the item that was passed in, there is no
looping over all the items to tell if at least one is onloan. (There is a small
bug in how this is done too...) So what the code does is look at the item that
was passed in to IsAvailableForItemLevelRequest and if it is onloan (or
OnHoldAndFound) it says it is OK to place a hold on that item. That is why I
think "If on loan" might make sense. Now this might not be what was intended
for the "If any unavailable" setting, but then the code is wrong, IMHO.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||22377


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22377
[Bug 22377] Lost fines may not be refunded if another patron has a writeoff for
the same item
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22377] Lost fines may not be refunded if another patron has a writeoff for the same item

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22377

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||22563


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563
[Bug 22563] Convert lost handling to use 'status' instead of multiple
accounttypes
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22621] Filters on subscription result list search the wrong column

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22621

--- Comment #1 from Séverine Queune  ---
Created attachment 87316
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87316=edit
Sceenshot 1 - search succeed using the fliter of the column on the right

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22621] New: Filters on subscription result list search the wrong column

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22621

Bug ID: 22621
   Summary: Filters on subscription result list search the wrong
column
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: severine.que...@bulac.fr
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com
  Target Milestone: ---

Created attachment 87315
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87315=edit
Sceenshot 1 - search failed

On the serial subscription page result, the filters search the column on its
left. Could it be the first column with check box but without filter that
create the gap ?

See the 2 screenshots attached :
  - #1 : failed searching "notes" using the filter on "Notes" column
  - #2 : 1 result (as expected) searching "notes" using the filter on "Library"
column

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21280] Unify MARC editor in biblios and authorities

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21280

--- Comment #18 from Ere Maijala  ---
Rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21280] Unify MARC editor in biblios and authorities

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21280

Ere Maijala  changed:

   What|Removed |Added

  Attachment #85517|0   |1
is obsolete||

--- Comment #14 from Ere Maijala  ---
Created attachment 87311
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87311=edit
Bug 21280: Move MARC editor code to a common class

Combines the MARC editor code from addbiblio.pl and authorities.pl to a common
class.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21280] Unify MARC editor in biblios and authorities

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21280

Ere Maijala  changed:

   What|Removed |Added

  Attachment #85520|0   |1
is obsolete||

--- Comment #17 from Ere Maijala  ---
Created attachment 87314
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87314=edit
Bug 21280: Add pref for MARC authority documentation url

Makes the documentation url for authorities separately configurable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21280] Unify MARC editor in biblios and authorities

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21280

Ere Maijala  changed:

   What|Removed |Added

  Attachment #85519|0   |1
is obsolete||

--- Comment #16 from Ere Maijala  ---
Created attachment 87313
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87313=edit
Bug 21280: Unify field types

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22377] Lost fines may not be refunded if another patron has a writeoff for the same item

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22377

--- Comment #5 from Martin Renvoize  ---
I'm working on a test for this at the tip of my accounts branch over here:
https://github.com/PTFS-Europe/koha/compare/accounts_all...PTFS-Europe:bug_22377

Currently however I'm struggling to replicate the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21280] Unify MARC editor in biblios and authorities

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21280

Ere Maijala  changed:

   What|Removed |Added

  Attachment #85518|0   |1
is obsolete||

--- Comment #15 from Ere Maijala  ---
Created attachment 87312
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87312=edit
Bug 21280: Move MARC editor tabs to an include file

Moves the tabs code from addbiblio.tt to marc_editor.inc and changes
authorities.tt to use it too. Minor changes in the tabs code were needed to
support both functions. Adds support for toggling docs and tags for authorities
and updates default documentation links.

Test plan:
1. Test adding and editing biblio records and authority records.
2. Make sure visibility of fields is correct initially and when values are
added.
3. Make sure settings for tags and documentation links work and stick across
edits, also for authorities.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21280] Unify MARC editor in biblios and authorities

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21280

Ere Maijala  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22377] Lost fines may not be refunded if another patron has a writeoff for the same item

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22377

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|tomasco...@gmail.com|martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

--- Comment #118 from Ere Maijala  ---
Rebased, but the schema patch is likely to break again..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Ere Maijala  changed:

   What|Removed |Added

  Attachment #86089|0   |1
is obsolete||

--- Comment #115 from Ere Maijala  ---
Created attachment 87308
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87308=edit
Bug 20447: Add a batch rebuild script for holdings table.

This script can be used to update the columns in the holdings table from the
MARC record using the rules in the framework. In practice this will only be
required if the koha link field is changed in the framework.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Ere Maijala  changed:

   What|Removed |Added

  Attachment #86091|0   |1
is obsolete||

--- Comment #117 from Ere Maijala  ---
Created attachment 87310
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87310=edit
Bug 20447: DBIX schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Ere Maijala  changed:

   What|Removed |Added

  Attachment #86090|0   |1
is obsolete||

--- Comment #116 from Ere Maijala  ---
Created attachment 87309
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87309=edit
Bug 20447: Add import/export support for holdings

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Adds support for importing and exporting biblios with interleaved holdings.

Test plan:

1.) Import the MARCXML file attached to the bug with the -holdings parameter:
misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m
MARCXML

2.) Verify that the holdings records were imported.

3.) Export the same records with holdings:
misc/export_records.pl --record-type=bibs --starting_biblionumber 103
--ending_biblionumber 104 --filename=holdings_export.xml --format=xml
--holdings

4.) Verify that both bibliographic and holding records are exported.

5.) Verify that tests in t/db_dependent/Exporter/Record.t pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Ere Maijala  changed:

   What|Removed |Added

  Attachment #86088|0   |1
is obsolete||

--- Comment #114 from Ere Maijala  ---
Created attachment 87307
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87307=edit
Bug 20447: MARC Holdings support

Enable by setting "SummaryHoldings" option to "Use".

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22615] Add /ill_backends endpoint

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22615

--- Comment #3 from Andrew Isherwood  ---
Hi Josef

Looking good so far :)

Do you have any details of your intended use case(s) for this endpoint, as that
may help inform what the capabilities structure should be.

Is this intended to be functionally distinct from the 'capabilities' embed on
the GET /illrequests endpoint?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19690] Smart rules: Term "If any unavailable" is confusing

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19690

--- Comment #7 from Katrin Fischer  ---
(In reply to Magnus Enger from comment #6)
> Would "If on loan" make more sense? That seems to be what is actually
> checked by the code.

Not quite, because it doesn't transport that it will take effect if at least
one is on loan.

Maybe:

If at one or more are checked out ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13629] SingleBranchMode removes both library and availability search from advanced search

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13629

--- Comment #1 from Katrin Fischer  ---
Still valid.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22617] Checkout notes pending dashboard link - error received even though manage_checkout_notes permission set.

2019-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22617

Fiona Borthwick  changed:

   What|Removed |Added

 CC||fiona.borthwick@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >