[Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22121] Display 'Price paid' on ILL requests according to CurrencyFormat pref

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22121

--- Comment #12 from Andrew Isherwood  ---
No, on Martin's request, I just rebased it and made sure it was up to date with
the current state of master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22075] Encoding problem with RIS export

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22075

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87484|0   |1
is obsolete||

--- Comment #3 from Martin Renvoize  ---
Created attachment 87580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87580&action=edit
Bug 22075: Fix encoding problem with RIS export in OPAC

When exporting a record with diacritics in RIS
format from the detail page in OPAC the encoding
is not correct and the diacritics appear broken.

This patch fixes it.

To test:
- Find or create a record with some special
  chars in your OPAC
- Go to the detail page
- Save as > RIS
- Verify the diacritics are broken in an editor
- Apply patch
- Repeat and verify everything now displays correctly

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22075] Encoding problem with RIS export

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22075

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #5 from Martin Renvoize  ---
No regressions found and passes QA scripts.. lets go straight for PQA :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22075] Encoding problem with RIS export

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22075

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Needs Signoff   |Signed Off

--- Comment #4 from Martin Renvoize  ---
Works as expected, thanks Katrin. Signing off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22075] Encoding problem with RIS export

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22075

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20937] PrintNoticesMaxLines is not effective for overdue notices with a print type specified where a patron has an email

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20937

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #85790|0   |1
is obsolete||

--- Comment #7 from Martin Renvoize  ---
Created attachment 87581
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87581&action=edit
Bug 20937: Truncate items for print notices when user has an email

To test:
 1 - Set PrintNoticesMaxLines to 1
 2 - Checkout 2 (or more) items to a patron and make them overdue to trigger a
notice
 3 - Make sure the patron has an email
 4 - Make sure the notice you are sending is set to 'print' as the type
 5 - Run overdue_notices.pl without the 'nomail' option
 6 - Find the message and note all items have been added
 7 - Apply patch
 8 - Clear the message queue
 9 - Re-run overdue_notices.pl
10 - Confirm the message now has only 1 item.
11 - Set PrintNoticesMaxLines to 0
12 - Clear the message queue
13 - Re-run overdue_notices.pl
14 - Confirm the message has 2 items as expected

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20937] PrintNoticesMaxLines is not effective for overdue notices with a print type specified where a patron has an email

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20937

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #8 from Martin Renvoize  ---
Works as intended, signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21263] Pickup library not set correctly when using Default holds policy by item type

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21263

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Signed Off  |Passed QA

--- Comment #4 from Martin Renvoize  ---
I sort of wish this was within the Modules rather than at the controller/script
side and as such I could request tests.

We could test it via selenium integration tests to prevent regression but that
feels like a fairly big ask here.

As I can't find any regressions and it appears to work as expected I'm going to
PQA.. but I'd love to see a more thorough treatment and unit tests down the
line.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21263] Pickup library not set correctly when using Default holds policy by item type

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21263

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #86335|0   |1
is obsolete||

--- Comment #3 from Martin Renvoize  ---
Created attachment 87582
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87582&action=edit
Bug 21263: Pickup library not set correctly when using Default holds policy

In the case of a specific item hold, it can only be fulfilled if the pickup
library
matches the hold fulfillment policy. Therefore, if OPACAllowUserToChooseBranch
is
set to don't allow, the pickup library should correspond to the policy.

In case of hold that does not specify an item, the homebranch or holdingbranch
can't be determined at this time, so the pickup library still defaults to the
homebranch of the borrower. Same if there is no policy or it states 'any'.

To test:
- Make sure OPACAllowUserToChooseBranch is set to don't allow
- Make sure you have two branches A and B
- Have one item whose homebranch is B
- Have one user whose homebranch is A
- Make sure the circulation rules allow the user to reserve the item's item
type

1. Go to Administration > Circulation and fines rules
2. Create a Default holds policy by item type for that item type
- Item type = item's item type
- Hold policy = From any library
- Hold pickup library match = item's home library
- Return policy = item returns home
3. Go to the OPAC and log in with the user's credentials
4. Search for the item
5. Click on "Place hold"
6. Select a specific item and confirm hold
7. In the user's file on the OPAC and check the reservation's pickup library.
It should be the item's homebranch

You can then repeat the steps for 'item's holding library' or 'any library' as
the Hold pickup library match. It should also work the same way if there is no
'Default holds policy by item type' for this item type but a 'Default checkout,
hold and return policy' set.

Finally, check that placing a hold without selecting a specific item still
defaults the pickup library to the borrower's homebranch.

Signed-off-by: Hayley Mapley 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21263] Pickup library not set correctly when using Default holds policy by item type

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21263

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22444] currencies_manage permission doesn't provide link to manage currencies when selected alone

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22444

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22444] currencies_manage permission doesn't provide link to manage currencies when selected alone

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22444

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87404|0   |1
is obsolete||

--- Comment #6 from Martin Renvoize  ---
Created attachment 87583
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87583&action=edit
Bug 22444: currencies_manage permission doesn't provide link to manage
currencies when selected alone

This patch modifies the acquisitions sidebar menu so that it checks
properly for the currencies_manage permission.

This patch also removes the menu link directly to the administration
home page. Since we're removing the check on the general
"CAN_user_parameters" permission it doesn't make sense to assume the
page is accessible.

To test, apply the patch and modifiy a staff user so that they have no
"parameters" permissions but do have "currencies_manage" permission.

Go to the Acquisitions home page. There should be a link to currencies
management in the sidebar menu.

Perform the same test with a user who has "parameters" permissions but
not "currencies_manage" permission. There should be no link to
currencies in the acquisitions sidebar menu. The user should have access
to the administrative home page.

Signed-off-by: Katrin Fischer 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22444] currencies_manage permission doesn't provide link to manage currencies when selected alone

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22444

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #7 from Martin Renvoize  ---
No regressions found and the change makes sense to me... Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12166] Improve display of hold charges in patron account

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87520|0   |1
is obsolete||

--- Comment #17 from Martin Renvoize  ---
Created attachment 87585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87585&action=edit
Bug 12166: (follow-up) Remove 'Reserve Charge' from descriptions in
accountlines

With the prior 'Hold fee' will be displayed in OPAC and staff, so
the 'Reserve Charge' would just be an untranslatable double up
of information.

To test:
- Make sure you create some Reserve Charges prior to applying this
  patch set
- Verify they show in staff and OPAC account
- Apply patch
- Run database update
- Verfy the "Rental Charge - " is gone and old and new entries
  match now

Signed-off-by: Owen Leonard 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12166] Improve display of hold charges in patron account

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87472|0   |1
is obsolete||

--- Comment #16 from Martin Renvoize  ---
Created attachment 87584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87584&action=edit
Bug 12166: Improve display of Reserve charges in patron account

This patch makes changes to the way hold fees are recorded and displayed
in the OPAC and staff client:

 - No English strings should be stored in the accountline description.
 - The accounttype code should be used to display what kind of charge it
   is.

To test, apply the patch and go to the staff client:

 - Configure a patron category to have a hold fee.
 - Place one or more holds for a patron in that category.
 - On the patron's record, view Accounting -> Make a payment
   - There should be a separate column for "Account type" showing "Hold
 fee" for the hold charges.
   - There should be no "Res" or "Reserve Charge" text in the
 description column--just the title.
 - Switch to the "Transactions" tab. The display should be similar.
 - In the OPAC, log in as a patron who has hold fees on their account.
   - View the "your fines" page to confirm that the information is
 displayed correctly there as well.

 - Place a hold for a patron who incurs hold charges.
 - Log in to the self-checkout module as that patron and check out an
   item which will fulfill that hold.
 - The correct fine information should be saved to accountlines: A "Res"
   type with a description consisting only of the title.

Signed-off-by: Katrin Fischer 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12166] Improve display of hold charges in patron account

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87521|0   |1
is obsolete||

--- Comment #18 from Martin Renvoize  ---
Created attachment 87586
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87586&action=edit
Bug 12166: (follow-up) Fix sequence of columns in OPAC

Type and description column headings were switched.

To test:
- Check the table headings of the fines table in the
  OPAC fines table match the content

Signed-off-by: Owen Leonard 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12166] Improve display of hold charges in patron account

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166

--- Comment #19 from Martin Renvoize  ---
Created attachment 87587
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87587&action=edit
Bug 12166: (QA follow-up) Update test for description

Update the relevant test to check for 'description eq title' as aposed
to the old 'description eq "Reserve Charge - title"'.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12166] Improve display of hold charges in patron account

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #20 from Martin Renvoize  ---
Nice fix, no regressions and passes the QA scripts and I've added a followup
for you to correct the failing test.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12166] Improve display of hold charges in patron account

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166

--- Comment #21 from Martin Renvoize  ---
Dependencies seem a bit weird.. this patch happily applies without bug 11573.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22670] New: Prevent changing of barcode on checked out items

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22670

Bug ID: 22670
   Summary: Prevent changing of barcode on checked out items
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: stina.hal...@ub.lu.se
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl
  Target Milestone: ---

It is possible to change barcode on a checked out item. This will cause
problems when handling the item later. Suggestion is to add an option
(syspref?) for protecting certain fields in the edit item form. There might be
other fields that other libraries want to protect from altering on checked out
items. Normally we don't edit checked out items but when you have many items on
one bib, it's easy to make a mistake and end up on the wrong item.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22509] Add a script to generate MARC fields containing date formatted strings

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22509

Hugo Agud  changed:

   What|Removed |Added

  Attachment #86586|0   |1
is obsolete||

--- Comment #5 from Hugo Agud  ---
Created attachment 87588
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87588&action=edit
Bug 22509: Add new script to add MARC fields with date formatted stringsto bib
records

Say you want to add, into a new MARC fields, the following string:
  2/2019/Mar-03/13
Depending on today's date.

Test plan:
Use the script after with the different options (see --help option for the
list)

Sponsored-by: Orex Digital

Signed-off-by: Hugo Agud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22509] Add a script to generate MARC fields containing date formatted strings

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22509

Hugo Agud  changed:

   What|Removed |Added

  Attachment #87435|0   |1
is obsolete||

--- Comment #6 from Hugo Agud  ---
Created attachment 87589
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87589&action=edit
Bug 22509: Add the --unless-exists option to the script

It will avoid to create the fields several times if it is not needed.

Signed-off-by: Hugo Agud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19670] search_marc_map.marc_field should have COLLATE= utf8mb4_bin

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19670

--- Comment #11 from Katrin Fischer  ---
Thanks, Ere!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19670] search_marc_map.marc_field should have COLLATE= utf8mb4_bin

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19670

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19670] search_marc_map.marc_field should have COLLATE= utf8mb4_bin

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19670

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #87558|0   |1
is obsolete||

--- Comment #10 from Katrin Fischer  ---
Created attachment 87590
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87590&action=edit
Bug 19670: Change Collation of marc_field to allow mixed case mappings

Test plan:
1. Apply patch and update database
2. Verify that you can add a search field mapping for both 100a and 100A.
3. Verify that the above also works with a newly-created database.

Signed-off-by: Michal Denar 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21577] Enable Koha to act as Shibboleth identity provider

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21577

Mathieu Pelletier  changed:

   What|Removed |Added

 CC||mkpellet...@gmail.com

--- Comment #4 from Mathieu Pelletier  ---
Koha was never really written to function as a shibboleth IDP, so this seems to
fall outside the purpose of the project.  That said, you could use SimpleSAML
with the SQL Auth plugin to query Koha's borrowers table, effectively making
Koha your source for user data.  We have done something similar, but with
Moodle as the Idp.

For more information, consider looking here:
https://simplesamlphp.org/docs/stable/sqlauth:sql

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21953] Term "Lost item" is untranslatable

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953

Martin Renvoize  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

--- Comment #15 from Martin Renvoize  ---
*** Bug 11573 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11573] change description of rental charges in account fines

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Resolution|--- |DUPLICATE
 Status|Failed QA   |RESOLVED

--- Comment #32 from Martin Renvoize  ---


*** This bug has been marked as a duplicate of bug 21953 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12166] Improve display of hold charges in patron account

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166
Bug 12166 depends on bug 11573, which changed state.

Bug 11573 Summary: change description of rental charges in account fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

   What|Removed |Added

 Status|Failed QA   |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11573] change description of rental charges in account fines

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

--- Comment #33 from Martin Renvoize  ---
This one hasn't received any love for a while and there are new reports (and
patches) in it's place.. I'm going to look at the more recent efforts and see
fi those resolve it.

Marking as duplicate.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21975] Unnecessary substitutions in automatic item modification by age

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21975

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Signed Off  |Failed QA

--- Comment #8 from Katrin Fischer  ---
Fails QA script, can you please check? 

 FAIL   C4/Items.pm
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   FAIL   pod coverage
POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666
   OK spelling
   FAIL   valid
BEGIN failed--compilation aborted 
Compilation failed in require 
Global symbol "$item" requires explicit package name (did you
forget to declare "my $item"?) 

 FAIL   t/db_dependent/Items/AutomaticItemModificationByAge.t
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   OK spelling
   FAIL   valid
Global symbol "$item" requires explicit package name (did you
forget to declare "my $item"?) 
Compilation failed in require

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17413] Translatability: Rental fee, Renewal of Rental Item etc. are hard coded

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17413

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21953

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21953] Term "Lost item" is untranslatable

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17413

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373)

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

--- Comment #4 from Katrin Fischer  ---
Created attachment 87591
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87591&action=edit
Screenshot showing partial payment

There has been no reaction to this so far from the initial developers, I am
updating it to a bug as I think we will get negative feedback on it as it
stands now :( 

To show one of the issues I have added a screenshot.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373)

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

--- Comment #5 from Katrin Fischer  ---
To repeat steps from screenshot:

- Have an account with multiple fines & charges
- Click 'Pay amount'
- Enter the Amount paid

Suggestion:
Leave amount collected empty and only calculate 'change to give' if it's
entered.

I'd also love some visual separation to make the Amount paid stand out more and
show that the other 2 fields belong together.

Also:
Collect form patron > Collected from patron
Amount paid : > Amount paid:

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21953] Term "Lost item" is untranslatable

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||22512


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512
[Bug 22512] accountlines.accountype mixes 'state' and 'type'
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type'

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||21953


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953
[Bug 21953] Term "Lost item" is untranslatable
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373)

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

--- Comment #6 from Katrin Fischer  ---
I fail to trigger the described modal from comment#2 right now. Wonder if we
already changed something there?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21577] Enable Koha to act as Shibboleth identity provider

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21577

--- Comment #5 from Josef Moravec  ---
(In reply to Mathieu Pelletier from comment #4)
> Koha was never really written to function as a shibboleth IDP, so this seems
> to fall outside the purpose of the project.  That said, you could use
> SimpleSAML with the SQL Auth plugin to query Koha's borrowers table,
> effectively making Koha your source for user data.  We have done something
> similar, but with Moodle as the Idp.
> 
> For more information, consider looking here:
> https://simplesamlphp.org/docs/stable/sqlauth:sql

Hi Mathieu, thanks for your comment,

we are going to use SimpleSAML for IdP, we just wrote plugin for ILS-DI
authentication - it is not ideal, but it works...


https://gitlab.com/josef.moravec/simplesamlphp-koha-ils-di-authentication-module

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type'

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|21953   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953
[Bug 21953] Term "Lost item" is untranslatable
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21953] Term "Lost item" is untranslatable

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|22512   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512
[Bug 22512] accountlines.accountype mixes 'state' and 'type'
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373)

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

--- Comment #7 from Katrin Fischer  ---
Found the mmodal... it appears when you click confirm.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373)

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19132] String has to be retranslated with every po update

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19132

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 19632 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19632] String reappears as fuzzy with every translation update

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19632

--- Comment #1 from Katrin Fischer  ---
*** Bug 19132 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20937] PrintNoticesMaxLines is not effective for overdue notices with a print type specified where a patron has an email

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20937

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #87581|0   |1
is obsolete||

--- Comment #9 from Katrin Fischer  ---
Created attachment 87592
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87592&action=edit
Bug 20937: Truncate items for print notices when user has an email

To test:
 1 - Set PrintNoticesMaxLines to 1
 2 - Checkout 2 (or more) items to a patron and make them overdue to trigger a
notice
 3 - Make sure the patron has an email
 4 - Make sure the notice you are sending is set to 'print' as the type
 5 - Run overdue_notices.pl without the 'nomail' option
 6 - Find the message and note all items have been added
 7 - Apply patch
 8 - Clear the message queue
 9 - Re-run overdue_notices.pl
10 - Confirm the message now has only 1 item.
11 - Set PrintNoticesMaxLines to 0
12 - Clear the message queue
13 - Re-run overdue_notices.pl
14 - Confirm the message has 2 items as expected

Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20937] PrintNoticesMaxLines is not effective for overdue notices with a print type specified where a patron has an email

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20937

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22553] Unchecking a subpermission does not uncheck the top level permission

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22553

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Just ran into this as well - It's dangerous as it could go unnoticed easily and
having to uncheck the top permission means you have to set all sub-permissions
again, which is error-prone.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22553] Unchecking a subpermission does not uncheck the top level permission

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22553

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #37 from Katrin Fischer  ---
Hi Hayley, looking at the conditions I noticed the check on
AllowRenewalLimitOverride. I fear things are even a bit more complicated :(

AllowRenewalLimitOverride works only, if the patron also is superlibrarian or
has the override_renewals permission. Could you take a look?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373)

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

Jon Knight  changed:

   What|Removed |Added

 CC||j.p.kni...@lboro.ac.uk

--- Comment #8 from Jon Knight  ---
Talked to the chaps here (mostly techies who hang around libraries!) after
seeing some discussion about this on IRC this morning and we couldn't see what
the point of the "collected" option was?  If you collect 20 currency units in
order to pay 5 currency units off a 15 currency unit bill in order to leave 10
currency units due, does Koha really need to record the 20, rather than just
the 5 unit payment? Surely the person in the library handling this would be
able to do the 15 unit change themselves?  Or are people somehow linking Koha
payment records to EPOS transactions?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15067] Add additional languages to advanced search language search

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #14 from Katrin Fischer  ---
Hi Hayley, 

some unwanted changes have slipped into the last patch:

 Koha/Illbackends/BLDSS|  1 +
 Koha/Illbackends/koha-ill-freeform|  1 +
 .../mysql/atomicupdate/bug_15067-add_newlanguages.sql | 19 +++
 installer/data/mysql/mandatory/subtag_registry.sql| 15 +++
 koha-ill-freeform |  1 +
 5 files changed, 37 insertions(+)
 create mode 16 Koha/Illbackends/BLDSS
 create mode 16 Koha/Illbackends/koha-ill-freeform
 create mode 16 koha-ill-freeform

Can you please fix the patch and switch back to signed off?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373)

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

--- Comment #9 from Katrin Fischer  ---
I think the idea was to help calculate, but the GUI right now seems confusing
compared to the 'before' and would require extra input. Looking at the
screenshot I think what I did 'wrong' was:

I wanted to pay a partial amount of the amount outstanding. Use case: 
"But I only have 6.00 with me..."

So I said:
- Pay amount
- Amount paid: 6.00
- I didn't change the other input fields
- I shoudl have changed: Amount collect_ed_ to say 6.00
- Change would have been: 0.00

But having to enter 2 fields to have the display make sense seems not good to
me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21953] Term "Lost item" is untranslatable

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #86209|0   |1
is obsolete||

--- Comment #16 from Martin Renvoize  ---
Created attachment 87593
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87593&action=edit
Bug 21953: Term 'Lost item' untranslatable

This patch removes the hardcoded untranslatable string
'Lost item' from C4/Circulation.pm.

To test:
1) Make sure the system preference WhenLostChargeReplacementFee is set to
Charge
2) Optional: in Administration > Item types, add a default replacement cost to
the item type you plan to use
3) Loan an item out to a patron
(If there is no default replacement cost, make sure the item has a replacement
price)
4) In the patron's account > Details > Loans, click on the item's barcode
5) Set the lost status to Lost
6) Go back to the patron's account > Fines
7) Notice it is written 'Lost item , Lost item title barcode (title)'
8) If you have another language installed, switch to the other language
and notice the second Lost item is still in English
9) Apply the patch
10) Redo steps 3-6
11) Notice it is written 'Lost item, title barcode (title)'
12) Optional: switch to another language, notice there is no English string

Signed-off-by: Katrin Fischer 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21953] Term "Lost item" is untranslatable

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953

--- Comment #19 from Martin Renvoize  ---
Created attachment 87596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87596&action=edit
Bug 21953: (QA follow-up) Corrections to DB Update

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21953] Term "Lost item" is untranslatable

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #86405|0   |1
is obsolete||

--- Comment #17 from Martin Renvoize  ---
Created attachment 87594
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87594&action=edit
Bug 21953: Add tests

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21953] Term "Lost item" is untranslatable

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953

--- Comment #20 from Martin Renvoize  ---
Created attachment 87597
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87597&action=edit
Bug 21953: Clarify PF = Lost item processing fee

Currently PF is only ever used for lost item processing fees. This patch
alters the end user faceing description to clarify that.

Note: It may be nice to make the code more descriptive too at some
point, but that can happen in another bug in my opinion.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21953] Term "Lost item" is untranslatable

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #86418|0   |1
is obsolete||

--- Comment #18 from Martin Renvoize  ---
Created attachment 87595
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87595&action=edit
Bug 21953: Update existing rows in DB

Signed-off-by: Hayley Mapley 
Test plan passes.
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21953] Term "Lost item" is untranslatable

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953

Martin Renvoize  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |https://bugs.koha-community
   |.org/bugzilla3/show_bug.cgi |.org/bugzilla3/show_bug.cgi
   |?id=12156   |?id=12166

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21953] Term "Lost item" is untranslatable

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953

Martin Renvoize  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #21 from Martin Renvoize  ---
OK, I've added the required followups myself... back to SO in the hopes I can
get a quick QA from someone else on the team.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21953] Term "Lost item" is untranslatable

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=12156

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12156] Merging staged records with no 952c with records created in acquisitions loses data from both

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12156

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21953

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12166] Improve display of hold charges in patron account

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21953

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12156] Merging staged records with no 952c with records created in acquisitions loses data from both

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12156

Martin Renvoize  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=21953   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21953] Term "Lost item" is untranslatable

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|martin.renvoize@ptfs-europe |testo...@bugs.koha-communit
   |.com|y.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21953] Term "Lost item" is untranslatable

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953

Martin Renvoize  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22357] Every run of runreport.pl with --store-results creates a new row in saved reports

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22357

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22357] Every run of runreport.pl with --store-results creates a new row in saved reports

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22357

--- Comment #3 from Katrin Fischer  ---
Created attachment 87598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87598&action=edit
Bug 22357: Fix saved reports table when runreport.pl with --store-results is
used

At the moment every time you run runreport.pl with the --store-results
option another line will appear for your report in the saved
reports table. This is not a data, but a display problem as the
report is still only stored once.

1) Create a report and note the report number
2) Run from command line (replace X by report number) :
misc/cronjobs/runreport.pl X --format=csv --csv-header --store-results
3) Go to saved reports table
4) Look at the table, each run of the cronjob will create a new row
   in the table instead of just updating the saved results column.
5) Apply patch
6) Veriy the table displays correctly again and there are no regressions

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22357] Every run of runreport.pl with --store-results creates a new row in saved reports

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22357

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de
   |ity.org |

--- Comment #4 from Katrin Fischer  ---
I think I found a fix and couldn't find any regressions. But I have to admit I
am not sure why the line removed from the SQL was there in the first place...
please test thoroughly.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17535] Regression: Search for reports by keywords

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17535

Josef Moravec  changed:

   What|Removed |Added

 Blocks||22357


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22357
[Bug 22357] Every run of runreport.pl with --store-results creates a new row in
saved reports
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22357] Every run of runreport.pl with --store-results creates a new row in saved reports

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22357

Josef Moravec  changed:

   What|Removed |Added

 Depends on||17535
 CC||josef.mora...@gmail.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17535
[Bug 17535] Regression: Search for reports by keywords
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22357] Every run of runreport.pl with --store-results creates a new row in saved reports

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22357

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #5 from Katrin Fischer  ---
This patch breaks keyword searching again - as Josef pointed out the line I
removed was added by bug 17535.

It looks like we want to search on the stored results with the keyword search,
but in that case I am not sure how to fix the display issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22357] Every run of runreport.pl with --store-results creates a new row in saved reports

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22357

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|katrin.fisc...@bsz-bw.de|koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14567] Browse interface for OPAC

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567

--- Comment #53 from Katrin Fischer  ---
+# This is the temporary entrance point to the API. Once bug #13799 is settled,
+# it should be ported to using that.
+my $api = $query->param('api');

Should we file a separate bug for this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14567] Browse interface for OPAC

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18205] API interface to Koha::Logger

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205

--- Comment #25 from Martin Renvoize  ---
I'm totally confused.. the title for this bug is misleading.. we're not adding
an API interface to Koha::Logger here at all... (I read that as being able to
access the logs via the api).. rather we're setting up a logger within the Mojo
app allowing us to Log.

With that confusion laid to rest..  this patchset seems to try and do too many
things in my opinion.. and I'm not sure what it wins us.

Why use MojoX::Log::Log4Perl at all?
Why introduce an entirely new Logger subclass?

Why not simply do $app->log(Koha::Logger->get) and use the config and setup
afforded to us by the existing work within Koha::Logger..

Am I missing something here?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14567] Browse interface for OPAC

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|katrin.fisc...@bsz-bw.de|

--- Comment #54 from Katrin Fischer  ---
Sorry, can't continue here - having issus with getting Elasticsearch running: 
http://paste.koha-community.org/2623 (kohadevbox)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14567] Browse interface for OPAC

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567

--- Comment #55 from Katrin Fischer  ---
Ere, could you maybe have a look at this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22280] The ILL module assumes every status needs a next/previous status

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280

--- Comment #3 from Magnus Enger  ---
Now I can't reproduce this in master. Any chance it got solved as a side effect
of something else?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21953] Term "Lost item" is untranslatable

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87596|0   |1
is obsolete||

--- Comment #25 from Martin Renvoize  ---
Created attachment 87602
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87602&action=edit
Bug 21953: (QA follow-up) Corrections to DB Update

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21953] Term "Lost item" is untranslatable

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87593|0   |1
is obsolete||

--- Comment #22 from Martin Renvoize  ---
Created attachment 87599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87599&action=edit
Bug 21953: Term 'Lost item' untranslatable

This patch removes the hardcoded untranslatable string
'Lost item' from C4/Circulation.pm.

To test:
1) Make sure the system preference WhenLostChargeReplacementFee is set to
Charge
2) Optional: in Administration > Item types, add a default replacement cost to
the item type you plan to use
3) Loan an item out to a patron
(If there is no default replacement cost, make sure the item has a replacement
price)
4) In the patron's account > Details > Loans, click on the item's barcode
5) Set the lost status to Lost
6) Go back to the patron's account > Fines
7) Notice it is written 'Lost item , Lost item title barcode (title)'
8) If you have another language installed, switch to the other language
and notice the second Lost item is still in English
9) Apply the patch
10) Redo steps 3-6
11) Notice it is written 'Lost item, title barcode (title)'
12) Optional: switch to another language, notice there is no English string

Signed-off-by: Katrin Fischer 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21953] Term "Lost item" is untranslatable

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87594|0   |1
is obsolete||

--- Comment #23 from Martin Renvoize  ---
Created attachment 87600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87600&action=edit
Bug 21953: Add tests

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21953] Term "Lost item" is untranslatable

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87595|0   |1
is obsolete||

--- Comment #24 from Martin Renvoize  ---
Created attachment 87601
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87601&action=edit
Bug 21953: Update existing rows in DB

Signed-off-by: Hayley Mapley 
Test plan passes.
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21953] Term "Lost item" is untranslatable

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87597|0   |1
is obsolete||

--- Comment #26 from Martin Renvoize  ---
Created attachment 87603
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87603&action=edit
Bug 21953: Clarify PF = Lost item processing fee

Currently PF is only ever used for lost item processing fees. This patch
alters the end user faceing description to clarify that.

Note: It may be nice to make the code more descriptive too at some
point, but that can happen in another bug in my opinion.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22658] aqbasket.authorisedby is missing a foreign key constraint

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22658

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22671] New: Built-in offline circulation interface not working

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22671

Bug ID: 22671
   Summary: Built-in offline circulation interface not working
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: Linux
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: pierre-marc.thiba...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com,
philippe.audet-for...@inlibro.com
  Target Milestone: ---

I am not able to use the feature on master when I follow these steps :

1) I set AllowOfflineCirculation to Enable.
2) I go to Circulation > Built-in offline circulation interface > Synchronize.
3) I click on "Download records" and dates appear like this : "2019-04-08
16:39:16 GMT-0400 (Eastern Daylight Time)".
4) I disable my internet connection.
5) I go to "https://your-koha-staff-client-url/cgi-bin/koha/circ/offline.pl";.
6) I get a 404 page.

It's likely the technology is no longer supported as windows.applicationCache
is deprecated and cannot be used in a not secure context (http). I am not
really sure if the problem comes from my koha or that, so I am asking the
community if this feature still works.

I tested an updated master in https on Firefox 66.0.2.

Thank you for your feedbacks.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22628] FFOR and VOID show up as codes to end users in OPAC, SCO and staff

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22628

--- Comment #1 from Martin Renvoize  ---
Created attachment 87604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87604&action=edit
Bug 22628: Add VOID and FFOR to relevant templates

This patch adds the VOID and FFOR codes to the releveant templates for
display purposes

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22628] FFOR and VOID show up as codes to end users in OPAC, SCO and staff

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22628

Martin Renvoize  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22628] FFOR and VOID show up as codes to end users in OPAC, SCO and staff

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22628

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22377] Lost fines may not be refunded if another patron has a writeoff for the same item

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22377

--- Comment #6 from Martin Renvoize  ---
Created attachment 87605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87605&action=edit
Bug 22377: Add test case

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22377] Lost fines may not be refunded if another patron has a writeoff for the same item

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22377

--- Comment #7 from Martin Renvoize  ---
Attached my attempt to write a test for this.. anyone is welcome to take over
as I couldn't replicate the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22377] Lost fines may not be refunded if another patron has a writeoff for the same item

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22377

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|martin.renvoize@ptfs-europe |koha-b...@lists.koha-commun
   |.com|ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539

Martin Renvoize  changed:

   What|Removed |Added

   Priority|P5 - low|P3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||22512


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512
[Bug 22512] accountlines.accountype mixes 'state' and 'type'
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type'

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||8338


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338
[Bug 8338] fines not cleared with dropbox mode
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22553] Unchecking a subpermission does not uncheck the top level permission

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22553

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18205] API interface to Koha::Logger

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205

--- Comment #26 from Martin Renvoize  ---
OK, to clarify..

Lari, can you state exactly what it is about MojoX::Log::Log4Perl that you wish
to use within the Mojo layer of Koha?  My understanding of the module is that
it in effect makes the the logger object act much like (but not exactly like)
Mojo::Log which would actually differ from Koha::Logger in use elsewhere.  For
all the basics however they act the same.

Personally I've prefer more documentation adding to Koha::Logger to state to
end user how we're expecting them to use the Logger object and then for
Koha::Logger to be used throughout the application (whether is be the Mojo side
or otherwise).

$app->log basically just returned a Log object anyway, so it may as well be a
standard Koha::Logger rather than 'yet another implementation'
Koha::Logger::Mojo which acts in a subtly different way.

Thoughts?  Unless you have a justifiable reason for introducing this additional
dependency and abstraction I'm happy to submit an alternative using just
Koha::Logger directly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22553] Unchecking a subpermission does not uncheck the top level permission

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22553

--- Comment #2 from Owen Leonard  ---
Created attachment 87606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87606&action=edit
Bug 22553: Unchecking a subpermission does not uncheck the top level permission

This patch makes a minor change to the set permissions page's JavaScript
so that unchecking a subpermission will uncheck the top level
permission.

To test, apply the patch and open the "Set permissions" page for a
patron.

 - Expand a permission with multiple subpermissions.
 - Check the top level permission. All subpermissions should be checked.
 - Uncheck one of the subpermissions. The top level permission should
   now be unchecked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22553] Unchecking a subpermission does not uncheck the top level permission

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22553

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   4   >