[Koha-bugs] [Bug 22541] Invoice adjustments: show invoice number and include link on ordered.pl and spent.pl

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22541

Katrin Fischer  changed:

   What|Removed |Added

Summary|Invoice adjustments should  |Invoice adjustments: show
   |show invoice number and |invoice number and include
   |include link on ordered.pl  |link on ordered.pl and
   |and spent.pl|spent.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8000] Test mode for notices

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11373] Add "change calculation" feature to the fine payment forms

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Katrin Fischer  changed:

   What|Removed |Added

  Component|Circulation |Fines and fees

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21844] Add callnumber to fines descriptions

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21844

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
  Component|Circulation |Fines and fees

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21662] Missing developers from history

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #76 from Marcel de Rooy  ---
QA: Looking here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

--- Comment #36 from Marcel de Rooy  ---
(In reply to Martin Renvoize from comment #32)
> So, how about I add a page to koha-community.org something along the lines:
[...]
> And link to it from the koha about page as part of these enhancements.. I'm
> also tempted to add in the dates a cycle takes place on the about page so
> that we clearly show if the 'current' maintenance team is no longer current
> if a library isn't updating regularly.

If I would be using say 17.11.08, I would see the release team of 17.11 (which
is fine) and since .08 normally means that we are in the second maintenance
cycle, I might see the second RMaint and the release team of 18.11, right?
But since I did not upgrade, that info is already out of date. No sense in
contacting these individuals.

Imo showing two teams is confusing and hard to explain. If you are in say 18.11
QA team, you will be credited for that on a 18.11 about page, and not on the
older versions.

Should we use the phrase "Original release team"? Remove the maintainers from
that section and separately list all maintainers for that version (say 17.11).
System date could indeed tell you if the last maintainer is still in function
and if the version is even maintained (assuming three cycles).

I think we should postpone this to 19.11 btw.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22836] Tests catching XSS vulnerabilities in pagination are not correct

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22836

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #4 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #2)
> Created attachment 89265 [details] [review]
> Revert "Bug 22478: (QA follow-up) Handle category in opac-shelves like a
> boolean"
> 
> This reverts commit 375dd35d5354d46c4c16f534494b123ce370c3f4.

I don't see the sense of removing these lines.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22478] Cross-site scripting vulnerability in paginations

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22478

--- Comment #52 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #44)
> (In reply to Nick Clemens from comment #42)
> > Does everyone here agree with that?
> 
> No, we do not need Marcel's patch. Moreover the pagination is used at
> several other places. The original report is about opac-shelves, but other
> scripts are impacted.
> Do you need ceinture and bretelles??

I would just like to add the question: Do you need left or right hand?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22799] Batch item modification is case sensitive

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22799

--- Comment #10 from Katrin Fischer  ---
Yes, I am sorry. I think the patch should go in, it was just something I hadn't
thought about a lot before.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

--- Comment #35 from Marcel de Rooy  ---
(In reply to Caroline Cyr La Rose from comment #34)
> Marcel's name D or R? Ask for preference)
> 
> Caroline

Dutch people will sort by R and write de R; non-Dutch will often sort by D and
write De R..
I won't mind ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #276 from David Cook  ---
(In reply to Mirko Tietgen from comment #275)
> (In reply to David Cook from comment #273)
> 
> > It sounds like you've got the code dependencies but you'll need to set up
> > the harvester daemon and run it as per
> > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662#c198.
> 
> Thanks, that helped. Some comments:
> - The Koha user can't create a directory in "/var/spool/koha/$instance/". We
> have the DB backups there and the folder belongs to root. I think
> /var/spool/koha/$instance/OAI" belonging to the Koha user would work better

I think I've already taken that into account? When you do koha-create, it
should use root access to create the relevant directory in
/var/spool/koha/$instance/ and assign the permissions to the Koha user. I know
I've already looked at this but maybe I'll need to look again. I don't think
anyone else has had a problem with it?

> - I have a problem related to the schema change in bug 22155
> 
> >[2019-05-02 10:06:00][DEBUG] [download][pid 2866][STDERR] Creating child 
> >process to download and feed parent process parser. at 
> >Koha/OAI/Harvester/Downloader.pm line 287.
> >[2019-05-02 10:06:00][DEBUG] [download][pid 2866][STDERR] Creating parent 
> >process parser. at Koha/OAI/Harvester/Downloader.pm line 293.
> >[2019-05-02 10:06:01][DEBUG] Registering POE::Session=ARRAY(0x91f7df8) as 
> >import for cf4d071b-76a9-4fff-b13d-c5a8bd27ed4a
> >[2019-05-02 10:06:01][DEBUG] Child pid 3032 started as wheel 126
> >[2019-05-02 10:06:01][DEBUG] [import][pid 3032][STDERR] DBD::mysql::st 
> >execute failed: Unknown column 'me.marcflavour' in 'field list' [for 
> >Statement "SELECT `me`.`id`, `me`.`biblionumber`, `me`.`format`, 
> >`me`.`marcflavour`, `me`.`metadata`, `me`.`timestamp` FROM `biblio_metadata` 
> >`me` WHERE ( ( `me`.`biblionumber` = ? AND `me`.`format` = ? AND 
> >`me`.`marcflavour` = ? ) )" with ParamValues: 0='1271', 1='marcxml', 
> >2='MARC21'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832.
> >[2019-05-02 10:06:01][DEBUG] [import][pid 3032][STDERR] 
> >DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.marcflavour' 
> >in 'field list' at /usr/share/koha/lib/Koha/Objects.pm line 92
> >[2019-05-02 10:06:01][DEBUG] [import][pid 3032] closed all pipes
> >[2019-05-02 10:06:01][DEBUG] [import][pid 3032] exited with status 0

Ah, interesting. I'll keep that in mind for when I find some time to work on
this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22835] Serve static files from plugins through the API

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835

--- Comment #4 from Agustín Moyano  ---
Created attachment 89280
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89280&action=edit
Bug 22835: (follow-up) Remove unwanted warn

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21073] Improve plugin performance

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

--- Comment #32 from Agustín Moyano  ---
Created attachment 89279
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89279&action=edit
Bug 21073: Restore filtering by metadata

This patch restores filtering the plugins by metadata. That got lost on
rebase at some point. Regression tests are added on a prior patch.

To test:
- Have the 'regression tests for GetPlugins' patch applied
- Run:
  $ kshell
 k$ prove t/db_dependent/Plugins.t
=> FAIL: Tests fail!
- Apply this patch
- Run:
 k$ prove t/db_dependent/Plugins.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Agustin Moyano 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21073] Improve plugin performance

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

--- Comment #29 from Agustín Moyano  ---
Created attachment 89276
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89276&action=edit
Bug 21073: (QA follow-up) Restore check on template

Signed-off-by: Agustin Moyano 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21073] Improve plugin performance

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

--- Comment #31 from Agustín Moyano  ---
Created attachment 89278
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89278&action=edit
Bug 21073: Regression tests for GetPlugins

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Agustin Moyano 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21073] Improve plugin performance

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

--- Comment #28 from Agustín Moyano  ---
Created attachment 89275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89275&action=edit
Bug 21073: (QA follow-up) Atomic update shouldn't fail if plugins are disabled

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Agustin Moyano 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21073] Improve plugin performance

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

--- Comment #30 from Agustín Moyano  ---
Created attachment 89277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89277&action=edit
Bug 21073: (QA follow-up) Remove unused libraries

Signed-off-by: Agustin Moyano 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21073] Improve plugin performance

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

--- Comment #25 from Agustín Moyano  ---
Created attachment 89272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89272&action=edit
Bug 21073: Add new table, schema and classes

Signed-off-by: Agustin Moyano 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21073] Improve plugin performance

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

--- Comment #26 from Agustín Moyano  ---
Created attachment 89273
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89273&action=edit
Bug 21073: Improve plugin performance

Right now, to check if a plugin is functional and what methods it exposes we
load the module and test for a given method at run time. This is highly
inefficient. It makes far more sense to do this at install time and store the
data in the db. I believe we should store a table of methods that each plugin
exposes and check that instead. Then, at install time we can test that a) the
plugin can be loaded and b) add the available methods to the plugin_methods
table.

Test Plan:
1) Apply this patch
2) Restart all the things
3) Run updatedatabase.pl
4) Verify you can use existing plugins
5) Verify you can install new plugins

Signed-off-by: Agustin Moyano 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21073] Improve plugin performance

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

--- Comment #27 from Agustín Moyano  ---
Created attachment 89274
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89274&action=edit
Bug 21073: Upgrade the kitchen sink plugin to get rid of warnings

Signed-off-by: Agustin Moyano 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21073] Improve plugin performance

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

Agustín Moyano  changed:

   What|Removed |Added

  Attachment #89247|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21073] Improve plugin performance

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

Agustín Moyano  changed:

   What|Removed |Added

  Attachment #89256|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21073] Improve plugin performance

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

Agustín Moyano  changed:

   What|Removed |Added

  Attachment #89252|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21073] Improve plugin performance

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

Agustín Moyano  changed:

   What|Removed |Added

  Attachment #89251|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21073] Improve plugin performance

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

Agustín Moyano  changed:

   What|Removed |Added

  Attachment #88379|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21073] Improve plugin performance

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

Agustín Moyano  changed:

   What|Removed |Added

  Attachment #89255|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21073] Improve plugin performance

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

Agustín Moyano  changed:

   What|Removed |Added

  Attachment #88380|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21073] Improve plugin performance

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

Agustín Moyano  changed:

   What|Removed |Added

 CC||agustinmoy...@theke.io
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21073] Improve plugin performance

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

Agustín Moyano  changed:

   What|Removed |Added

  Attachment #88381|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22781] Fields on patron search results should be html/json filtered

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22781

--- Comment #5 from Jonathan Druart  
---
Created attachment 89270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89270&action=edit
Bug 22781: Does not double filter address

Ho, a bug!
Some fields in the address where double filtered.

Test plan:
Use the evil strings in the address field and do a search, you will see
double html encoded characters without this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22781] Fields on patron search results should be html/json filtered

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22781

--- Comment #4 from Jonathan Druart  
---
Created attachment 89269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89269&action=edit
Bug 22781: Test patron's info filtering

The patron's data was not correctly escaped actually.

Test plan:
This is a good value for the whole patchset: fir's"tname \123
❤
use it for a patron's firstname, then do a search

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22781] Fields on patron search results should be html/json filtered

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22781

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22781] Fields on patron search results should be html/json filtered

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22781

--- Comment #6 from Jonathan Druart  
---
Created attachment 89271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89271&action=edit
Bug 22781: Correctly filter the emails

Ho, another bug!

The email was not correctly filtered.

Test plan:
Use the evil string for an email, do a search.
=> Notice that without this patch the results never show up

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22781] Fields on patron search results should be html/json filtered

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22781

--- Comment #2 from Jonathan Druart  
---
Created attachment 89267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89267&action=edit
Bug 22781: Add tests

Test plan:
Apply only this patch
=> The tests will fail, the library's name is not correctly escaped.

Note:
This applies for the whole patchset, when the tests fail you will need
to remove the patrons added by the tests with the following SQL query:
  delete from borrowers where surname like "test_patron_%";
We are expecting END to be called even if something goes wrong, but
DESTROY must be used instead. This will be fixed separately, on its own
bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22781] Fields on patron search results should be html/json filtered

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22781

--- Comment #3 from Jonathan Druart  
---
Created attachment 89268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89268&action=edit
Bug 22781: Escape cardnumber, category's description, library's name and
dateexpiry

This will fix the previous failure. Note that other fields like
borrowernumber, Price escaped values, integers, etc. could be escaped
the same way but will be useless (save polar bears).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22836] Tests catching XSS vulnerabilities in pagination are not correct

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22836

--- Comment #2 from Jonathan Druart  
---
Created attachment 89265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89265&action=edit
Revert "Bug 22478: (QA follow-up) Handle category in opac-shelves like a
boolean"

This reverts commit 375dd35d5354d46c4c16f534494b123ce370c3f4.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22836] Tests catching XSS vulnerabilities in pagination are not correct

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22836

--- Comment #3 from Jonathan Druart  
---
Created attachment 89266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89266&action=edit
Bug 22836: (follow-up) Bug 22478: (QA follow-up) Make test consistent with
variable name

One occurrence was missing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22836] Tests catching XSS vulnerabilities in pagination are not correct

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22836

--- Comment #1 from Jonathan Druart  
---
Created attachment 89264
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89264&action=edit
Revert "Bug 22478: (QA follow-up) Update tests to check for any script tags"

This reverts commit d9b3b90849fd95d296b73b330c4e32ff018c81a5.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22836] Tests catching XSS vulnerabilities in pagination are not correct

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22836

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22836] New: Tests catching XSS vulnerabilities in pagination are not correct

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22836

Bug ID: 22836
   Summary: Tests catching XSS vulnerabilities in pagination are
not correct
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Test Suite
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

See bug 22478 comments 44 and 45.

The tests were added originally to catch XSS vulnerabilities when pagination
was used (shelves, reviews, authorities searches, etc.).

With one of the QA followup (Handle category in opac-shelves like a boolean) we
did not trust the escape by resetting the "category" if not set to 1 or 2. We
should rely on the correct filtering instead.

However, if one really wants to use this change, we should adapt the tests to
catch the correct filtered values (and so do not use unlike), in another area
(i.e. not shelves, where we are handling the invalid values differently).

I am suggestion to revert those patches, as it is the easiest solution.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22836] Tests catching XSS vulnerabilities in pagination are not correct

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22836

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||22478


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22478
[Bug 22478] Cross-site scripting vulnerability in paginations
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22478] Cross-site scripting vulnerability in paginations

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22478

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||22836

--- Comment #51 from Jonathan Druart  
---
Done, see bug 22836.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22836
[Bug 22836] Tests catching XSS vulnerabilities in pagination are not correct
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22835] Serve static files from plugins through the API

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835

--- Comment #3 from Agustín Moyano  ---
Created attachment 89263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89263&action=edit
Bug 22835: Serve plugin static files through API

This patch serves static files declared within plugins.

To declare static files the plugin must implement the method 'static_routes'
which retrieves the spec of static file routes to add to the API.

Once those routes are added to the API, the become available through the
/api/v1/contrib//static endpoint.

To test:
1) Install bug-22835-plugin.kpz
2) Point your browser to /api/v1/contrib/kitchensink/static/static_files/mm.gif
CHECK => No file is served
3) Apply this patch
4) restart_all
5) Repeat step 2.
SUCCESS => File is served!
6) Sign off

Sponsored-by: Theke

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22835] Serve static files from plugins through the API

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835

Agustín Moyano  changed:

   What|Removed |Added

 CC||agustinmoy...@theke.io

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22835] Serve static files from plugins through the API

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835

Agustín Moyano  changed:

   What|Removed |Added

  Attachment #89262|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22484] /svc/members/search has no tests

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22484

Jonathan Druart  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=22781   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22781] Fields on patron search results should be html/json filtered

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22781

Jonathan Druart  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=22484   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22781] Fields on patron search results should be html/json filtered

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22781

Jonathan Druart  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #1 from Jonathan Druart  
---
*** Bug 22484 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22484] /svc/members/search has no tests

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22484

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Jonathan Druart  
---
I am going to provide test on bug 22781.

*** This bug has been marked as a duplicate of bug 22781 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22781] Fields on patron search results should be html/json filtered

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22781

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22835] Serve static files from plugins through the API

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835

--- Comment #2 from Agustín Moyano  ---
> 1) Install bug-22835-plugin.kpz

KPZ available at 

https://github.com/agmoyano/koha-plugin-kitchen-sink/releases/download/bug-22835/bug-22835-plugin.kpz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22835] Serve static files from plugins through the API

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835

Agustín Moyano  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22835] Serve static files from plugins through the API

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835

--- Comment #1 from Agustín Moyano  ---
Created attachment 89262
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89262&action=edit
Bug 22835: Serve plugin static files through API

This patch serves static files declared within plugins.

To declare static files the plugin must implement the method 'static_routes'
which retrieves the spec of static file routes to add to the API.

Once those routes are added to the API, the become available through the
/api/v1/contrib//static endpoint.

To test:
1) Install bug-22835-plugin.kpz
2) Point your browser to /api/v1/contrib/kitchensink/static/static_files/mm.gif
CHECK => No file is served
3) Apply this patch
4) restart_all
5) Repeat step 2.
SUCCESS => File is served!
6) Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22799] Batch item modification is case sensitive

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22799

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #9 from Chris Cormack  ---
Yeah but if we change the behaviour here to be case sensitive, this will be the
only place in the whole of koha that barcodes are case sensitive.

In fact everything in the db is case insensitive, the only thing that isn't in
the whole of Koha is passwords, because we store a hash.

While I think a wider move to move everything to being case sensitive is worth
exploring that is massively out of scope of making this script consistent with
everything else in Koha.

Lets just do that first, and then open another bug to switch things to case
sensitive. Because that is a massive job, touching every part of Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22799] Batch item modification is case sensitive

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22799

Chris Cormack  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22835] Serve static files from plugins through the API

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835

Agustín Moyano  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22834] Add a method for plugins to return the absolute path for bundled files

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22834

--- Comment #4 from Tomás Cohen Arazi  ---
Created attachment 89261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89261&action=edit
Bug 22834: Add Koha::Plugins::Base->bundle_path

This patch adds a 'bundle_path' method that return the base path for
assets included in the plugin. The idea is that it will be used for
calculation of the absolute path in the filesystem for static content.

To test:
- Apply the unit tests patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Plugins.t
=> FAIL: The method is not implemented
- Apply this patch
- Run:
 k$ prove t/db_dependent/Plugins.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22834] Add a method for plugins to return the absolute path for bundled files

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22834

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 89260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89260&action=edit
Bug 22834: Add tests for Koha::Plugins::Base->bundle_path

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22834] Add a method for plugins to return the absolute path for bundled files

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22834

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #89258|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22834] Add a method for plugins to return the absolute path for bundled files

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22834

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #89259|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22717] Google OAuth auto registration error

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22717

--- Comment #11 from Maya Das  ---
Thank You All for this kind effort, the Bug was cause in 18.11.04
-Maya

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22834] Add a method for plugins to return the absolute path for bundled files

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22834

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||21073


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073
[Bug 21073] Improve plugin performance
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21073] Improve plugin performance

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||22834


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22834
[Bug 22834] Add a method for plugins to return the absolute path for bundled
files
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22834] Add a method for plugins to return the absolute path for bundled files

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22834

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 89259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89259&action=edit
Bug 22834: Add Koha::Plugins::Base->bundle_path

This patch adds a 'bundle_path' method that return the base path for
assets included in the plugin. The idea is that it will be used for
calculation of the absolute path in the filesystem for static content.

To test:
- Apply the unit tests patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Plugins.t
=> FAIL: The method is not implemented
- Apply this patch
- Run:
 k$ prove t/db_dependent/Plugins.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22834] Add a method for plugins to return the absolute path for bundled files

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22834

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22834] Add a method for plugins to return the absolute path for bundled files

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22834

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22835] Serve static files from plugins through the API

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22835] Serve static files from plugins through the API

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |agustinmoy...@theke.io
   |ity.org |
 Depends on||22834


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22834
[Bug 22834] Add a method for plugins to return the absolute path for bundled
files
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22834] Add a method for plugins to return the absolute path for bundled files

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22834

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||22835


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835
[Bug 22835] Serve static files from plugins through the API
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22835] New: Serve static files from plugins through the API

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835

Bug ID: 22835
   Summary: Serve static files from plugins through the API
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: new feature
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

The last step to avoid having to tweak (or even depend on) Apache for plugins
is having a way to serve static files through the OpenAPI spec.

The plugins serving static files would supply a static_files_routes (or
similar) method that should return the OpenAPI spec for a directory tree
bundled with the plugin itself. This could be done manually, but a way to
auto-generate this spec will be added to the KitchenSink plugin so it can be
automated through the use of gulp.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22834] Add a method for plugins to return the absolute path for bundled files

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22834

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 89258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89258&action=edit
Bug 22834: Add tests for Koha::Plugins::Base->bundle_path

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22787] Mapping missing for ů to u in word-phrase-utf-chr

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22787

Michal Denar  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22787] Mapping missing for ů to u in word-phrase-utf-chr

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22787

--- Comment #3 from Michal Denar  ---
Created attachment 89257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89257&action=edit
Bug 22787: Add mapping of letters "ů" and "Ů" to zebra definitions

Test plan:
0) Do not apply the patch
1) Add some word with character "ů" into metadata, for example author "Martinů,
Bohuslav"
2) Try to search it with "Martinu" and you'll see you can't find it
3) Apply the patch
4) Copy file etc/zebradb/etc/word-phrase-utf.chr to your /etc/koha directory
sudo cp etc/zebradb/etc/word-phrase-utf.chr /etc/koha/zebradb/etc/
5) koha-zebra --restart kohadev
6) koha-rebuild-zebra -f kohadev
6) try to search "Martinu" again - you should be able to find your record

Signed-off-by: Josef Moravec 
Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22789] Establish Non-Priority Holds

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

--- Comment #1 from Lisette Scheer  ---
This would be very helpful here. 
Lisette

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22822] Better Circulation Rules

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22822

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

--- Comment #1 from Lisette Scheer  ---
This would be very helpful for our consortium. 
Lisette

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22834] New: Add a method for plugins to return the absolute path for bundled files

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22834

Bug ID: 22834
   Summary: Add a method for plugins to return the absolute path
for bundled files
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

Koha::Plugins::Base inherits from Module::Bundled::Files, which is handy to
pack assets together and have a simple way to calculate the asset's path. It
would help developing new features to have a way to retrieve the absolute path.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22834] Add a method for plugins to return the absolute path for bundled files

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22834

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||agustinmoy...@theke.io
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21073] Improve plugin performance

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

--- Comment #24 from Tomás Cohen Arazi  ---
Created attachment 89256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89256&action=edit
Bug 21073: Restore filtering by metadata

This patch restores filtering the plugins by metadata. That got lost on
rebase at some point. Regression tests are added on a prior patch.

To test:
- Have the 'regression tests for GetPlugins' patch applied
- Run:
  $ kshell
 k$ prove t/db_dependent/Plugins.t
=> FAIL: Tests fail!
- Apply this patch
- Run:
 k$ prove t/db_dependent/Plugins.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21073] Improve plugin performance

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

--- Comment #23 from Tomás Cohen Arazi  ---
Created attachment 89255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89255&action=edit
Bug 21073: Regression tests for GetPlugins

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22833] New: Don't let users cancel holds connected with ILLs

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833

Bug ID: 22833
   Summary: Don't let users cancel holds connected with ILLs
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: ILL
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mag...@libriotech.no
  Target Milestone: ---

In the Swedish (Libris) ILL module, when a new ILL request is created, a record
and an item (with a specific ILL itemtype) are also created. And a hold is
created between the local patron that is waiting for the ILL and the local ILL
item. 

This means that the ILL shows up as a regular hold when the patron logs into
the OPAC. That in it self is OK, but the problematic thing is that patrons can
cancel the holds connected with the ILL (maybe thinking that they are then also
canceling the ILL request). Libraries would like to stop patrons from doing
this. 

A couple of options come to mind:

1. Add a syspref that can take a list of itemtypes that should not be
cancel'able by the patron in the OPAC

2. Add a boolean field like itetypes.let_patrons_cancel_holds_in_opac which
defaults to 1 for existing itemtypes, but can be set to 0 to achieve the
desired effect. 

1 is more unobtrusive, 2 is probably cleaner in the long run?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22804] OPAC Overdrive JavaScript contains untranslatable strings

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22804

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22804] OPAC Overdrive JavaScript contains untranslatable strings

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22804

--- Comment #1 from Owen Leonard  ---
Created attachment 89254
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89254&action=edit
Bug 22804: OPAC Overdrive JavaScript contains untranslatable strings

This patch moves untranslatable strings out of overdrive.js and into
opac-bottom.inc where other strings are defined for use in JavaScript
files.

To test you must have OverDrive integration set up, including
OverDriveCirculation. Test the various Overdrive integration features:

 - Placing holds
 - Cancelling holds
 - Checking out
 - Checking in

These features should work as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #34 from Caroline Cyr La Rose  ---
Feedback from IRC based on screenshot:

- capitalize Koha (koha -> Koha)
- uncapitalize Team and Manager (Documentation Team -> Documentation team ;
Documentation Manager -> Documentation manager)
- correct "maintenance" typo (maintainence -> maintenance)
- rephrase "the version of Koha you are currently running" -> of your currently
installed Koha version (suggestion from a non-native, feel free to write
whatever sounds best in English ;) )
- add translation manager to current team
- add dates to current maintenance team
- alphabetize teams within a role by last name (e.g. QA team : Alex Arnaud,
Tomás Cohen Arazi, Chris Cormack, Jonathan Druart, Kyle Hall, Julian Maurice,
Josef Moravec, Martin Renvoize, Marcel de Rooy) (not sure about Marcel's name D
or R? Ask for preference)

Caroline

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Arslan Farooq  changed:

   What|Removed |Added

 CC||arslan...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14546] Make staff client templates responsive

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546

Arslan Farooq  changed:

   What|Removed |Added

 CC||arslan...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

--- Comment #33 from Martin Renvoize  ---
Created attachment 89253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89253&action=edit
new_stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22832] Require plugins to specify the methods they implement

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22832

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||21073
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073
[Bug 21073] Improve plugin performance
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21073] Improve plugin performance

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||22832


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22832
[Bug 22832] Require plugins to specify the methods they implement
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22832] New: Require plugins to specify the methods they implement

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22832

Bug ID: 22832
   Summary: Require plugins to specify the methods they implement
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

With bug 21073, a simple plugin implementing (say) only the to_marc method
generates this on the DB:

mysql> SELECT * FROM plugin_methods;
+---+---+
| plugin_class  | plugin_method
|
+---+---+
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | _handle_control_field
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | _version_compare 
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | abs_path 
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | as_heavy 
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | canonpath
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | catdir   
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | catfile  
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | configure
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | curdir   
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | except   
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | export   
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | export_fail  
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | export_ok_tags   
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | export_tags  
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | export_to_level  
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | file_name_is_absolute
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | get_metadata 
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | get_plugin_http_path 
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | get_qualified_table_name 
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | get_template 
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | go_home  
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | import   
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | install  
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | max  
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | mbf_dir  
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | mbf_exists   
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | mbf_open 
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | mbf_path 
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | mbf_read 
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | mbf_validate 
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | new  
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | no_upwards   
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | only 
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | output   
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | output_html  
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | output_html_with_http_headers
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | output_with_http_headers 
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | path 
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | plugins  
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | require_version  
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | retrieve_data
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | rootdir  
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | search_path  
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | store_data   
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | to_marc  
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | uninstall
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | updir
|
+---+---+
47 rows in set (0.00 sec)

I think plugins should just expose what metho

[Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login attempts

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10339] Link to content in the manual that matches the MARC flavor of the installation

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10339

Owen Leonard  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org
  Component|Templates   |Documentation
Version|unspecified |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22420] Tag cloud feature broken

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9792] Layout problem with patron entry form when using Internet Explorer 11

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9792

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #3 from Owen Leonard  ---
I don't have access to Internet Explorer 11 anymore. It appears to be working
correctly with Microsoft Edge on Windows 10. I'm going to mark this WONTFIX,
but if someone with IE 11 wants to provide a fix we can reopen it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21073] Improve plugin performance

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

--- Comment #22 from Tomás Cohen Arazi  ---
Created attachment 89252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89252&action=edit
Bug 21073: (QA follow-up) Remove unused libraries

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21073] Improve plugin performance

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

--- Comment #21 from Tomás Cohen Arazi  ---
Created attachment 89251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89251&action=edit
Bug 21073: (QA follow-up) Restore check on template

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829

axel Amghar  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829

axel Amghar  changed:

   What|Removed |Added

  Attachment #89248|0   |1
is obsolete||

--- Comment #6 from axel Amghar  ---
Created attachment 89250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89250&action=edit
Bug 18829: Elasticsearch - Put a better display for the view of ES indexed
record

To test:
- apply the patch
- go to global sysPref
- make sure that SearchEngine have "ElsaticSearch" as value
- Search whatever you want in Search the catalog and select a notice
- Search the link (Ctrl f) : "Elasticsearch Record :" , click on the link
- make sure that the pop-up open and you should see the elasticsearch result in
JSON (the pop-up look the same as MARC preview)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829

axel Amghar  changed:

   What|Removed |Added

  Attachment #89007|0   |1
is obsolete||

--- Comment #5 from axel Amghar  ---
Created attachment 89249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89249&action=edit
Bug 18829: Elasticsearch - Add ability to view the ES indexed record

This is groundwork - we need to make the display prettier, but for now
it does at least dump the record into the template

We probably also need a swtich to enable/disable this - or just move it
into the left hand tabs?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829

axel Amghar  changed:

   What|Removed |Added

  Attachment #89007|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record

2019-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829

axel Amghar  changed:

   What|Removed |Added

 CC||axel.amg...@biblibre.com
  Attachment #89007|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >