[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #70 from axel Amghar  ---
(In reply to Liz Rea from comment #69)
> there were no entry boxes at the bottom of either tab, sorry.

If you realy are in search engine configuration. 

Remove the patch, so you should be in master.
- return to search engine configuration 
- go to bibliographic records or authorities
- at the bottom of the tab, you should see the add line because this patch just
add the line at the bottom of search field
- if you don't, there is a issue on your side

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610

--- Comment #10 from Martin Renvoize  ---
(In reply to Liz Rea from comment #8)
> I think libraries are going to miss these:
> 
> [% CASE 'Pay00' %]Payment (cash via SIP2)
> [% CASE 'Pay01' %]Payment (VISA via SIP2)
> [% CASE 'Pay02' %]Payment (credit card via SIP2)
> 

Will they really miss the above?  We've not gotten right of the data, only
moved it into the more appropriate field 'payment_type' as apposed to lumping
it in with 'accounttype'.  That field is pretty much always displayed next to
the accounttype column so I don't understand what they'll miss?

> Right now, *near as I can tell* we are only ever going to get "Cash via
> SIP2" in the interface with this patch, is that correct? I tried with the
> following sip emulator settings:

I'm looking into this now as well as writing the unit tests. 

Thanks for testing :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21648] Patron Merge needs more flexibility and transparency

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648

Bob Birchall  changed:

   What|Removed |Added

 CC||b...@calyx.net.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22872] New: payment_type handling is untested in Koha::Account->add_credit.

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22872

Bug ID: 22872
   Summary: payment_type handling is untested in
Koha::Account->add_credit.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

The payment_type functionality is sparsely tested and only for the ->pay method
and not the add_credit method.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22873] New: C4::SIP::ILS::Transation::FeePayment->pay $disallow_overpayment does nothing

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22873

Bug ID: 22873
   Summary: C4::SIP::ILS::Transation::FeePayment->pay
$disallow_overpayment does nothing
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: SIP2
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com
  Target Milestone: ---

The `disallow_overpayment` parameter that's expected to be passed to the pay
method of FeePayment does nothing.. it should either be removed or implimented.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22874] Limit to available items doesn't work with elasticsearch 6.x

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874

Alex Arnaud  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |alex.arn...@biblibre.com
   |ity.org |
 Blocks||20196


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20196
[Bug 20196] [Omnibus] Prepare Koha to ElasticSearch6 - ES6
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20196] [Omnibus] Prepare Koha to ElasticSearch6 - ES6

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20196

Alex Arnaud  changed:

   What|Removed |Added

 Depends on||22874


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874
[Bug 22874] Limit to available items doesn't work with elasticsearch 6.x
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22874] New: Limit to available items doesn't work with elasticsearch 6.x

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874

Bug ID: 22874
   Summary: Limit to available items doesn't work with
elasticsearch 6.x
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alex.arn...@biblibre.com
  Target Milestone: ---

Currently we send "onloan:0" to ES to get records with available items.
But ES 6 does not considers 0 as a valid boolean.

On ES 6.x:
onloan:0 => doesn't work
onloan:false => works

On ES 5.x:
onloan:0 => works
onloan:false => works

So it seems we can have compatibility for both ES 5 and ES 6 by using false
instead of 0.

Patch is coming.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22875] New: Documentation misleading for import_patrons command line script

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22875

Bug ID: 22875
   Summary: Documentation misleading for import_patrons command
line script
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: colin.campb...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz
  Target Milestone: ---

In the import_patrons.pl command line script the documentation for the
--verbose option merely states Be verbose it does not indicate that the option
is repeatable and that 2 repetitions are required to get a report of lines that
were rejected. This is also different from some previous versions which
reported failed lines on a single --verbose

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610

--- Comment #11 from Martin Renvoize  ---
Right, 

I've gotten to the bottom of this.. it's tester error :).. man SIP is 'fun' to
test.

So, I tested with:

perl misc/sip_cli_emulator.pl --sip_user=staff --sip_pass=staff --patron=dir
--fee-identifier=697 --fee-amount=0.50 --payment-type=02 -m fee_paid -a
127.0.0.1 -p 6001 -l MAIN

Note the 'payment-type' as apposed to 'fee-type' used in your version.. to be
entirely honest I have no idea what fee-type is used for here.. I would suggest
it's not for payment but for creation of new fee's only?

Anywho.. the code does appear to work as expected (defaulting to 'Cash' when no
payment-type is specified, but using the payment type if one is).

Just about to upload a Unit test now too.

Thanks again for testing Liz :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89460|0   |1
is obsolete||

--- Comment #12 from Martin Renvoize  ---
Created attachment 89492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89492&action=edit
Bug 22610: Update SIP payment accounttypes

This DB update updates the Pay00, Pay01 and Pay02 accounttypes to all
be 'Pay' and adds the corresponding payment_types into the
authorised_values

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610

--- Comment #16 from Martin Renvoize  ---
Created attachment 89496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89496&action=edit
Bug 22610: (QA follow-up) Add unit tests for FeePayment

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610

--- Comment #15 from Martin Renvoize  ---
Created attachment 89495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89495&action=edit
Bug 22610: (follow-up) Correction to accounts tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89471|0   |1
is obsolete||

--- Comment #14 from Martin Renvoize  ---
Created attachment 89494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89494&action=edit
Bug 22610: (follow-up) Catch non-standard SIP codes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89461|0   |1
is obsolete||

--- Comment #13 from Martin Renvoize  ---
Created attachment 89493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89493&action=edit
Bug 22610: Update SIP2 to use payment_type

The SIP2 interface has long used a set of accounttypes to denote payment
types. Now we have an authorised list of payment_types and a
payment_type field in accountlines this patch alters the logic to use
it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22875] Documentation misleading for import_patrons command line script

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22875

Colin Campbell  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |colin.campbell@ptfs-europe.
   |ity.org |com
 Status|NEW |Needs Signoff

--- Comment #1 from Colin Campbell  ---
Created attachment 89497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89497&action=edit
Document verbose option more fully

Trivial documentation change
Clarifies usage of verbose option

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #89492|0   |1
is obsolete||
  Attachment #89493|0   |1
is obsolete||
  Attachment #89494|0   |1
is obsolete||
  Attachment #89495|0   |1
is obsolete||
  Attachment #89496|0   |1
is obsolete||

--- Comment #17 from Kyle M Hall  ---
Created attachment 89498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89498&action=edit
Bug 22610: Update SIP payment accounttypes

This DB update updates the Pay00, Pay01 and Pay02 accounttypes to all
be 'Pay' and adds the corresponding payment_types into the
authorised_values

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610

--- Comment #19 from Kyle M Hall  ---
Created attachment 89500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89500&action=edit
Bug 22610: (follow-up) Catch non-standard SIP codes

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610

--- Comment #20 from Kyle M Hall  ---
Created attachment 89501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89501&action=edit
Bug 22610: (follow-up) Correction to accounts tests

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610

--- Comment #18 from Kyle M Hall  ---
Created attachment 89499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89499&action=edit
Bug 22610: Update SIP2 to use payment_type

The SIP2 interface has long used a set of accounttypes to denote payment
types. Now we have an authorised list of payment_types and a
payment_type field in accountlines this patch alters the logic to use
it.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610

--- Comment #21 from Kyle M Hall  ---
Created attachment 89502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89502&action=edit
Bug 22610: (QA follow-up) Add unit tests for FeePayment

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610

--- Comment #22 from Kyle M Hall  ---
Created attachment 89503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89503&action=edit
Bug 22610: (QA follow-up) Make upgrade query more accurate

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610

Martin Renvoize  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22876] New: Wording of Unlimited in Circulation and Fine Rule Matrix might be confusing

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22876

Bug ID: 22876
   Summary: Wording of Unlimited in Circulation and Fine Rule
Matrix might be confusing
 Change sponsored?: ---
   Product: Koha
   Version: 18.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
  Target Milestone: ---

With the introduction in 18.11 of the Holds Total per day column in the
circulation and fine rule matrix and the Holds total column by patron category
on the same page, the value is set at "Unlimited" .  Although it is understood
that this does not mean "Unlimited"- it could be confusing to users of Koha. 
Is it possible to add a Tip when hovering over this area in both places that
this means, "it is not unlimited but it is not a limit here due to other values
in this chart".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524

Nick Clemens  changed:

   What|Removed |Added

  Text to go in the||Sponsored by Northeast
  release notes||Kansas Library System,
   ||NEKLS (http://nekls.org/)
   ||
   ||This development adds the
   ||ability to set a maximum
   ||numbers of holds in the
   ||circulation rules that will
   ||limit the total number of
   ||holds a patron can have.
   ||This can be set as a
   ||default, or per library.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||rel_19_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22657] Remove JavaScript from OPAC suggestion validation of required fields

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22657

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22835] Serve static files from plugins through the API

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22657] Remove JavaScript from OPAC suggestion validation of required fields

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22657

Owen Leonard  changed:

   What|Removed |Added

  Attachment #87939|0   |1
is obsolete||

--- Comment #7 from Owen Leonard  ---
Created attachment 89504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89504&action=edit
Bug 22657: Remove JavaScript from OPAC suggestion validation of required fields

This patch modifies the OPAC suggestion form so that it doesn't require
JavaScript for form validation. This change doesn't alter the behavior
of the form for users but does fit with the general goal of progressive
enhancement for the OPAC.

The patch adds "required" labels to required fields to better identify
required fields.

To test, apply the patch and make sure there are required fields
specified in the OPACSuggestionMandatoryFields system preference.

 - Log in to the OPAC and go to Your purchase suggestions -> New
   purchase suggestion.
 - Verify that the fields specified in OPACSuggestionMandatoryFields are
   highlighted and marked "required."
 - Verify that you can't submit the form without filling out these
   fields.

Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22877] New: Returning a lost item not marked as returned can generate additional overdue fines

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Bug ID: 22877
   Summary: Returning a lost item not marked as returned can
generate additional overdue fines
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
  Target Milestone: ---

To recreate:
1 - Issue an item to a patron with a backdated due date
2 - Run fines.pl - note you generate a fine for the patron
3 - Run longoverdue.pl - make sure MarkLostItemsAsReturned is turned off and to
charge
4 - Confirm the patron has a lost fee and an overdue
5 - Return the item
6 - Patron now has 2 overdue fines and a lost fine?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

--- Comment #1 from Nick Clemens  ---
Created attachment 89505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89505&action=edit
Bug 22877: Unit test to highlight problem

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Nick Clemens  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||martin.renvoize@ptfs-europe
   ||.com, tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22874] Limit to available items doesn't work with elasticsearch 6.x

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874

--- Comment #1 from Alex Arnaud  ---
Created attachment 89506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89506&action=edit
Bug 22874 - use false instaed of 0 value for limiting on availability

Test plan

  - Set up a elasticsearch 6 instance to work with Koha,
  - you may need to make koha works with ES 6 (see bug 20589),
  - make a search and limit it to available items only,
  => no result

  - Apply this patch,
  - make a search and limit it to available items only,
  - you should get some results

  - Do the same with ES 5.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22874] Limit to available items doesn't work with elasticsearch 6.x

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874

Alex Arnaud  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22874] Limit to available items doesn't work with elasticsearch 6.x

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874

e.betemps  changed:

   What|Removed |Added

 CC||e.bete...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21245] Move 'Last patron' button inside of the 'breadcrumb' bar

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21245

--- Comment #7 from Martin Renvoize  ---
I mostly just don't like they way it currently feels detached and hovers above
the breadcrumb bar.. I'm happy to take suggestions as to better locations :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689

--- Comment #42 from Nick Clemens  ---
(In reply to Owen Leonard from comment #41)
> (In reply to Nick Clemens from comment #39)
> > The problem seems to be in ExtractValue:
> ...
> > This returns both 'A' and 'a' subfields
> 
> Should this be considered another bug, which this bug should be made
> dependent on?

I think it can be done here or on another bug - it should be sorted before this
is pushed though

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Paul Thornton  changed:

   What|Removed |Added

 CC||paul.thorn...@educampus.ie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22539

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22877

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610

--- Comment #23 from Liz Rea  ---
awesome, I'm happy if y'all are happy :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

--- Comment #2 from Martin Renvoize  ---
I presume 'CalculateFinesOnReturn' comes into play here too?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

--- Comment #3 from Martin Renvoize  ---
(In reply to Martin Renvoize from comment #2)
> I presume 'CalculateFinesOnReturn' comes into play here too?

Sorry.. it's right there in the test as enabled at the top.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22878] New: cannot add a patron card layout with mysql strict mode on

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22878

Bug ID: 22878
   Summary: cannot add a patron card layout with mysql strict mode
on
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Label/patron card printing
  Assignee: cnighswon...@foundations.edu
  Reporter: wizzy...@gmail.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

Attempting to create a patron card layout with mysql strict mode on gives the
following error:

DBD::mysql::st execute failed: Incorrect integer value: '' for column
'layout_id' at row 1 [for Statement "INSERT INTO creator_layouts (creator,
layout_id, units, layout_xml, layout_name) VALUES (?,?,?,?,?);" with
ParamValues: 0='Patroncards', 1="", 2="POINT", 3="

", 4="something"] at /kohadevbox/koha/C4/Creators/Layout.pm line 181.
Database returned the following error: Incorrect integer value: '' for column
'layout_id' at row 1 at /kohadevbox/koha/C4/Creators/Layout.pm line 183.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #102 from Liz Rea  ---
I've tried to test this a couple of times now but I just can't seem to get the
patches for 18936 to apply to even get these ones on. Hit me up in IRC if you'd
like to help me get all the patches applied so I can test - this is good
functionality and I hate to see it sit.

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

--- Comment #4 from Martin Renvoize  ---
Created attachment 89507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89507&action=edit
Bug 22877: Prevent double overdue processing for lost and returned

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89507|0   |1
is obsolete||

--- Comment #6 from Martin Renvoize  ---
Created attachment 89509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89509&action=edit
Bug 22877: Prevent double overdue processing for lost and returned

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

--- Comment #7 from Martin Renvoize  ---
Created attachment 89510
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89510&action=edit
Bug 22877: (follow-up) Fix test plan count

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89505|0   |1
is obsolete||

--- Comment #5 from Martin Renvoize  ---
Created attachment 89508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89508&action=edit
Bug 22877: Unit test to highlight problem

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||rel_19_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22879] New: Cannot reindex elastic

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22879

Bug ID: 22879
   Summary: Cannot reindex elastic
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: blocker
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
  Target Milestone: ---

kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ perl -MCarp::Always
misc/search_tools/rebuild_elastic_search.pl -d -a -b
No record passed at /home/vagrant/kohaclone/Koha/MetadataRecord.pm line 82.
Koha::MetadataRecord::new("Koha::BiblioUtils", HASH(0x55ee0f6a58f8))
called at /home/vagrant/kohaclone/Koha/BiblioUtils.pm line 62
Koha::BiblioUtils::new("Koha::BiblioUtils", undef, 647) called at
/home/vagrant/kohaclone/Koha/BiblioUtils.pm line 128
eval {...} called at /home/vagrant/kohaclone/Koha/BiblioUtils.pm line
127
Koha::BiblioUtils::__ANON__() called at
/home/vagrant/kohaclone/Koha/MetadataIterator.pm line 71
   
Koha::MetadataIterator::next(Koha::MetadataIterator=HASH(0x55ee0c8d4278))
called at misc/search_tools/rebuild_elastic_search.pl line 137
main::__ANON__() called at misc/search_tools/rebuild_elastic_search.pl
line 182
main::do_reindex(CODE(0x55ee0c8cc380), "biblios") called at
/home/vagrant/kohaclone/Koha/MetadataRecord.pm line 82.
Koha::MetadataRecord::new("Koha::BiblioUtils", HASH(0x55ee0f6a58f8))
called at /home/vagrant/kohaclone/Koha/BiblioUtils.pm line 62
Koha::BiblioUtils::new("Koha::BiblioUtils", undef, 647) called at
/home/vagrant/kohaclone/Koha/BiblioUtils.pm line 128
eval {...} called at /home/vagrant/kohaclone/Koha/BiblioUtils.pm line
127
Koha::BiblioUtils::__ANON__() called at
/home/vagrant/kohaclone/Koha/MetadataIterator.pm line 71
   
Koha::MetadataIterator::next(Koha::MetadataIterator=HASH(0x55ee0c8d4278))
called at misc/search_tools/rebuild_elastic_search.pl line 137
main::__ANON__() called at misc/search_tools/rebuild_elastic_search.pl
line 182
main::do_reindex(CODE(0x55ee0c8cc380), "biblios") called at
misc/search_tools/rebuild_elastic_search.pl line 140
Something went wrong reading record for biblio
Koha::Schema::Result::Biblio=HASH(0x55ee0f686228)->biblionumber: Can't bless
non-reference value at /home/vagrant/kohaclone/Koha/BiblioUtils.pm line 70.
Koha::BiblioUtils::new("Koha::BiblioUtils", undef, 647) called at
/home/vagrant/kohaclone/Koha/BiblioUtils.pm line 128
eval {...} called at /home/vagrant/kohaclone/Koha/BiblioUtils.pm line
127
Koha::BiblioUtils::__ANON__() called at
/home/vagrant/kohaclone/Koha/MetadataIterator.pm line 71
   
Koha::MetadataIterator::next(Koha::MetadataIterator=HASH(0x55ee0c8d4278))
called at misc/search_tools/rebuild_elastic_search.pl line 137
main::__ANON__() called at misc/search_tools/rebuild_elastic_search.pl
line 182
main::do_reindex(CODE(0x55ee0c8cc380), "biblios") called
 at /home/vagrant/kohaclone/Koha/BiblioUtils.pm line 131.
Koha::BiblioUtils::__ANON__() called at
/home/vagrant/kohaclone/Koha/MetadataIterator.pm line 71
   
Koha::MetadataIterator::next(Koha::MetadataIterator=HASH(0x55ee0c8d4278))
called at misc/search_tools/rebuild_elastic_search.pl line 137
main::__ANON__() called at misc/search_tools/rebuild_elastic_search.pl
line 182
main::do_reindex(CODE(0x55ee0c8cc380), "biblios") called at
misc/search_tools/rebuild_elastic_search.pl line 140

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22880] New: Convert opacheader system preference to news block

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880

Bug ID: 22880
   Summary: Convert opacheader system preference to news block
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 22318
  Target Milestone: ---

Building on 22318, the opacheader system preference should be converted to a
Koha news block.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318
[Bug 22318] Extend Koha news feature to include other content areas
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318

Owen Leonard  changed:

   What|Removed |Added

 Blocks||22880


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880
[Bug 22880] Convert opacheader system preference to news block
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #71 from Jonathan Druart  
---
The new "add" line appears for me, but the "Type" dropdown does not contain the
same values as above. Please double check.

In case of misunderstanding it's always good to share a screenshot, so here it
is:
https://snag.gy/2XiGEd.jpg # Scroll down!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #72 from Jonathan Druart  
---
Also, if you add a field that already exists, it is ignored (no warning, no
updated).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89508|0   |1
is obsolete||

--- Comment #8 from Martin Renvoize  ---
Created attachment 89511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89511&action=edit
Bug 22877: Unit test to highlight problem

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22657] Remove JavaScript from OPAC suggestion validation of required fields

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22657

--- Comment #8 from Jonathan Druart  
---
A good reason for that change:
-@mandatoryfields = sort split(/\s*\,\s*/, $fldsreq_sp);
+@mandatoryfields = split( ",", $fldsreq_sp );

?

I think the regex must be kept as it, just in case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89510|0   |1
is obsolete||

--- Comment #10 from Martin Renvoize  ---
Created attachment 89513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89513&action=edit
Bug 22877: (follow-up) Fix test plan count

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89509|0   |1
is obsolete||

--- Comment #9 from Martin Renvoize  ---
Created attachment 89512
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89512&action=edit
Bug 22877: Prevent double overdue processing for lost and returned

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

--- Comment #11 from Martin Renvoize  ---
Created attachment 89514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89514&action=edit
Bug 22877: (QA follow-up) Clarify intent of tests and remove one.

The intent of these tests as a set were not entirely clear. This patch
clarifies the intent for future developers and removes a superflous one.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

--- Comment #12 from Martin Renvoize  ---
Test plan.. 
1. Recreate the issue as in the first comment
2. Apply the first patch and watch the test fail
3. Apply patches 2 and 3 and watch the test pass
4. Fail to recreate the issue as in the first comment
5. Apply the last patch and re-run the tests and watch them still pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22879] Cannot reindex elastic

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22879

Jonathan Druart  changed:

   What|Removed |Added

   Severity|blocker |major

--- Comment #1 from Jonathan Druart  
---
Lowering severity as I do not recreate on a fresh install.

It seems that the biblio 647 was a leftover from a test, and did not contain
the biblioitems or biblio_metadata

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22879] Cannot reindex elastic

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22879

--- Comment #2 from Jonathan Druart  
---
Created attachment 89515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89515&action=edit
Bug 22879: Add a test-like

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20307] Language overlay for authorized values

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
 Status|NEW |Needs Signoff

--- Comment #16 from Jonathan Druart  
---
Updating the status to Needs Signoff (to get more love).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

--- Comment #13 from Jonathan Druart  
---
(In reply to Martin Renvoize from comment #11)
> Created attachment 89514 [details] [review]
> Bug 22877: (QA follow-up) Clarify intent of tests and remove one.
> 
> The intent of these tests as a set were not entirely clear. This patch
> clarifies the intent for future developers and removes a superflous one.

Can you explain a bit more?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89514|0   |1
is obsolete||

--- Comment #14 from Martin Renvoize  ---
Created attachment 89516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89516&action=edit
Bug 22877: (QA follow-up) Clarify intent of tests and remove one.

The intent of these tests as a set were not entirely clear. This patch
clarifies the intent for future developers and removes a superflous one.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22880] Convert opacheader system preference to news block

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22880] Convert opacheader system preference to news block

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880

--- Comment #1 from Owen Leonard  ---
Created attachment 89517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89517&action=edit
Bug 22880: Convert opacheader system preference to news block

This patch builds on Bug 22318 to move the opacheader system preference
into the Koha news system, making it possible to have language- and
library-specific content.

It extends the original patch by adding an option to the template plugin
specifying whether the content title should be shown (probably should be
a flag in opac_news). It also adds a wrapper div with the content
location as the ID (e.g. 'opacheader'). This will make it slightly more
backwards-compatible with CSS customizations.

To test you should have some content in the opacheader system
preference. Apply the patch and run the database update process.

 - Go to the OPAC and confirm that the content which was previously in
   the opacheader system preference now displays correctly where it was
   before.
 - In the staff client, go to Tools -> News and verify that the content
   from opacheader is now stored in a news item with the location
   'opacheader_en.'
 - Go to Administration -> System preferences and confirm that the
   opacheader preference has been removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22880] Convert opacheader system preference to news block

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880

--- Comment #2 from Owen Leonard  ---
The QA tool is giving me a couple of errors which I could use some help
understanding:

Argument "" isn't numeric in numeric gt (>) at
/home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc
line 23.

...and...

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
   OK filters
   OK forbidden patterns
   OK git manipulation
   OK js_in_body
   OK spelling
   OK tt_valid
   FAIL   valid_template
koha_news_block: not found

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

--- Comment #15 from Jonathan Druart  
---
Wrong calls in test were caused by (just for ref):
  commit 004609e46814791fac540e1c8bfb21f647758143
  Bug 14591: Update unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #24 from Jonathan Druart  
---
Is it really useful to check for the others PayXX (in the updatedatabase
entry)?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610

--- Comment #25 from Jonathan Druart  
---
Why not switch the sip_type (00, 01, 02) to something meaningful?

Also, we are loosing the translation...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21364] Allow closing basket from vendor search/view

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364

--- Comment #30 from Jonathan Druart  
---
Please, we need the "Add to basket" link accessible in one click!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21588] Add "Collapse/Expand" options on subscription-detail page

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21588

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21588] Add "Collapse/Expand" options on subscription-detail page

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21588

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21588] Add "Collapse/Expand" options on subscription-detail page

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21588

--- Comment #1 from Jonathan Druart  
---
Created attachment 89518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89518&action=edit
Bug 21588: Add expand/collapse all links to the "Acquisition details"
subscriptions

In order to make the view cleaner, a librarian may need to expand or
collapse all the orders at once.

Test plan:
- Create a subscription
- Create several orders from this subscription (quantity > 1)
- Receive partially the orders
- Go to the subscription detail page, "Acquisition details" tab
=> Notice the 2 new links "Expand all" and "Collapse all"
Make sure they work as expected.

Also note that a bug has been fixed, when the page is loaded the tree is
now expanded.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21588] Add "Collapse/Expand" options on subscription-detail page

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21588

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21588] Add "Collapse/Expand" options on subscription-detail page

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21588

Liz Rea  changed:

   What|Removed |Added

  Attachment #89518|0   |1
is obsolete||

--- Comment #2 from Liz Rea  ---
Created attachment 89519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89519&action=edit
Bug 21588: Add expand/collapse all links to the "Acquisition details"
subscriptions

In order to make the view cleaner, a librarian may need to expand or
collapse all the orders at once.

Test plan:
- Create a subscription
- Create several orders from this subscription (quantity > 1)
- Receive partially the orders
- Go to the subscription detail page, "Acquisition details" tab
=> Notice the 2 new links "Expand all" and "Collapse all"
Make sure they work as expected.

Also note that a bug has been fixed, when the page is loaded the tree is
now expanded.

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22657] Remove JavaScript from OPAC suggestion validation of required fields

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22657

--- Comment #9 from Owen Leonard  ---
Created attachment 89520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89520&action=edit
Bug 22657: (QA follow-up) Restore previous version of regex

This patch restores the previous version of the regular expression which
parses the OPACSuggestionMandatoryFields system preference value.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22433] SIP/Transaction.t is failing randomly

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22433

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|NEW |ASSIGNED

--- Comment #1 from Jonathan Druart  
---
We got this failure a lot the last months.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22433] SIP/Transaction.t is failing randomly

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22433

--- Comment #2 from Jonathan Druart  
---
Created attachment 89521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89521&action=edit
Bug 22433: Add debug statement to Transaction.t

Hard to know what's going on here without more info. Adding this output
may help to investigate more.

Test plan:
Make sure the tests still pass

If it fails, please paste the output!!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22433] SIP/Transaction.t is failing randomly

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22433

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22862] Normalize SMS messaging numbers before validating them

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22862

--- Comment #4 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #3)
> A couple of things:
> 1. regexs are different

I'll get that fixed. They are functionally identical, but it would be good to
have them patch.

> 2. There is the 'pattern' attribute that should deal with that
> (opac-messaging.tt), can you explain why we need the JS code as well?

The pattern attribute is for data validation, not data normalization.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22862] Normalize SMS messaging numbers before validating them

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22862

--- Comment #5 from Kyle M Hall  ---
Created attachment 89522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89522&action=edit
Bug 22862: (QA follow-up) Make regexes match

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #85 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22847] Specific circ rule by patron category is displaying the default (or not displaying)

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22847

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #5 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22790] The system preference itemBarcodeInputFilter is not applied for barcodes inputed via SIP2

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22790

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||n...@bywatersolutions.com

--- Comment #7 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4833] Show acquisition information when ordering from suggestion

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4833

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Signed Off
 CC||n...@bywatersolutions.com

--- Comment #8 from Nick Clemens  ---
(In reply to Katrin Fischer from comment #7)
> Thx for QA!

I am a little worried about the impact of this in a larger system - we are
calling GetBudget for every suggestion - that is a DB hit per suggestion - I
would rather see this info pulled in SearchSuggestion so that we maintain a
single call for all the suggestions

Can I get a second QA opinion here?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4833] Show acquisition information when ordering from suggestion

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4833

Nick Clemens  changed:

   What|Removed |Added

   Keywords||rel_19_05_candidate

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #103 from Liz Rea  ---
Alright, thanks Agustin for helping me get these patches to apply! Have gotten
through a bit of testing and I have some questions about the feature generally.

A note: 
I've attached the set of MARC records that I usually supplement my devbox with,
just so we are looking at the same things. Import them using the Stage MARC for
import tool. :)

my groups:
North: Centerville, Fairfield, Franklin
South: Springfield, Troy, Union

The other libraries are not in a group, they stand alone.

Test, opac:

Biblio: De Crasi Aristophea. Dissertatio - 3 items, Centerville, Fairview,
Midway
Patron: Nicole Schneider, Franklin
Pickup locations seen: Fairview, Centerville, Fairfield, Franklin
Seems OK? Except maybe Fairview, as it isn't in the patron's group.

Biblio: The Vixens, A novel. 1 item, Midway
Patron: Nicole Schneider, Franklin
Pickup locations seen: Midway
Hm. Why not the libraries in Nicole's group (Centerville, Fairfield, Franklin) 

Biblio: Gairm, 1 item, Centerville
Patron: Nicole Schneider, Franklin
Pickup locations seen: Centerville, Fairfield, Franklin
This seems right - pick up locations in the patron's group, but it is also the
item's group.

Biblio: De Crasi Aristophea. Dissertatio - 3 items, Centerville, Fairview,
Midway
Patron: Henry Acevedo, Midway
Pickup locations seen: Midway, Fairview, Centerville, Fairfield, Franklin
Logic (I think? can you confirm?):
Midway because it is the patron's home library. 
Fairview because there is an item from Fairview? 
Centerville, Fairfield, Franklin, in a hold group, however our patron is not in
this hold group? Is this right?

Biblio: The Vixens, A novel. 1 item, Midway
Patron: Henry Acevedo, Midway
Pickup locations seen: Midway
Thoughts: Midway is not in a group. It's like an individual branch is a group
unto itself? Is that correct behaviour?

Biblio: Gairm, 1 item, Centerville
Patron: Henry Acevedo, Midway
Pickup locations seen: Centerville, Fairfield, Franklin
Thoughts: The patron is not in this group, I don't understand why we are using
the item's group and not the patron's group?

The main question I have is, which is the location that defines which group the
reserve can be picked up in, the patron's branch (which is what I believe the
intent of the feature request was) or the item's homebranch?

If someone from VOKAL could comment on what they are expecting in the above
scenarios, I think that would be really helpful.

I'm going to stop here for now, as I think this question of which location is
canonical is quite core to this dev.

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #104 from Liz Rea  ---
Created attachment 89523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89523&action=edit
MARC records for testing, compatible with default branches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22053] Ability to disable some plugins

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #30 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21535] Anonymize function in Patron should not scramble email addresses

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21535

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #8 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22811] Add button to clear DataTables filtering

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||n...@bywatersolutions.com

--- Comment #5 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4833] Show acquisition information when ordering from suggestion

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4833

--- Comment #9 from Katrin Fischer  ---
(In reply to Nick Clemens from comment #8)
> (In reply to Katrin Fischer from comment #7)
> > Thx for QA!
> 
> I am a little worried about the impact of this in a larger system - we are
> calling GetBudget for every suggestion - that is a DB hit per suggestion - I
> would rather see this info pulled in SearchSuggestion so that we maintain a
> single call for all the suggestions
> 
> Can I get a second QA opinion here?

I am not sure how expensive it is, tbh, but I wouldn't expect a big number of
accepted suggestions even in a bigger system. Maybe I am mistaken there. Just
saying we only show a subset of data here. 

There are some other places where GetBudget is used:
http://git.koha-community.org/gitweb/?p=koha.git&a=search&h=HEAD&st=grep&s=GetBudget%28

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4833] Show acquisition information when ordering from suggestion

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4833

--- Comment #10 from Katrin Fischer  ---
Talked to Nick, it makes sense, but I won't be able to fix probably for this
release, sorry.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22373] Stock Rotation duration test

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22373

--- Comment #1 from Lisette Scheer  ---
It does appear to have reset when it arrived back at home branch. 
Placed an item in a rota 4/17/2019 (Duration 20 days)
Arrived at new home 4/18/2019 (Day 0)
Hold found and sent to another branch 4/24/2019 (Day 6)
Hold filled, checked out, returned to home branch 4/26/2019 (Day 8/Day 0)

5/8/2019 should have been Day 20. As of 5/9/2019 it has not moved forward. 
I will check again on 5/17/2019 to make sure it moves on.
Lisette

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >