[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #136 from Kyle M Hall --- (In reply to Jonathan Druart from comment #117) > - Are you sure we need the change to Koha::Object? Fixed in followup > - koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt > [% To.json(data) %] must have the html filter Fixed in followup > > - changes to opac-user.tt are wrong (not needed) Fixed in rebase. Please point out which lines you are referring to in the future. > - There are too many (unneeded) changes made to members/update-child.pl, it > will conflict with bug 20226 (not blocker) There are currently very few changes to this script. Maybe this was fixed in a previous rebase. > - misc/cronjobs/j2a.pl transaction must be done using > txn_begin/txn_commit/txn_rollback Fixed in followup > - C4::Installer::load_sql returned the following errors while attempting to > load /home/vagrant/kohaclone/installer/data/mysql/atomicupdate/bug_14570.sql: > > I do not know what the error is. ? > - Charset/collate: > relationship VARCHAR(100) COLLATE utf8_unicode_ci NOT NULL, > => this is wrong > > - same in the atomic update Fixed in followup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815 --- Comment #5 from Joy Nelson --- Hi Brian, We understand the urgency for your library. This bug is currently assigned and in development. When the feature is ready, tested and passed QA it will be pushed into a release of Koha. Thanks! joy (In reply to Brian from comment #4) > FY18 means Fiscal year 2018 > > Hi this bug is attached to our development New System Pref, “Don’t forgive > lost after(set date), modify checkin routine to check the value of the > itemlost_on field. > > My superiors want this bug pushed, thank you -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #134 from Kyle M Hall --- Created attachment 89891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89891=edit Bug 14570: (QA Follow-up) Misc changes based on QA feedback -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #135 from Kyle M Hall --- Created attachment 89892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89892=edit Bug 14570: Update schema files [Do Not Push] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall changed: What|Removed |Added Attachment #89889|0 |1 is obsolete|| --- Comment #133 from Kyle M Hall --- Created attachment 89890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89890=edit Bug 14570: Make it possible to add multiple guarantors to a record This patch adds the ability to set an unlimited number of guarantors for a given patron. As before, each guarantor may be linked to another Koha patron, and all the behavior that applies to a given guarantor remains the same. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Find some patrons with guarantors, verify the still have their guarantor 4) Test adding and removing guarantors on a patron record, both Koha users and not 5) Verify the "Add child" button works 6) Verify NoIssuesChargeGuarantees still works 7) Verify tools/cleanborrowers.pl will not delete a guarantor 8) Verify the guarantors are displayed on moremember.pl 9) Verify the guarantor is removed by members/update-child.pl 10) Verify the guarantor is removed by misc/cronjobs/j2a.pl 11) Verify import patrons converts guarantor_id, relationship, contactfirstname, and contactsurname into a guarantor 12) prove t/Patron.t 13) prove t/db_dependent/Circulation.t 14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 15) prove t/db_dependent/Items.t 16) prove t/db_dependent/Koha/Patrons.t 17) prove t/db_dependent/Members.t 18) prove t/db_dependent/Patron/Relationships.t Signed-off-by: Kim Peine Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall changed: What|Removed |Added Attachment #85411|0 |1 is obsolete|| Attachment #85412|0 |1 is obsolete|| Attachment #85431|0 |1 is obsolete|| --- Comment #132 from Kyle M Hall --- Created attachment 89889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89889=edit Bug 14570: Make it possible to add multiple guarantors to a record This patch adds the ability to set an unlimited number of guarantors for a given patron. As before, each guarantor may be linked to another Koha patron, and all the behavior that applies to a given guarantor remains the same. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Find some patrons with guarantors, verify the still have their guarantor 4) Test adding and removing guarantors on a patron record, both Koha users and not 5) Verify the "Add child" button works 6) Verify NoIssuesChargeGuarantees still works 7) Verify tools/cleanborrowers.pl will not delete a guarantor 8) Verify the guarantors are displayed on moremember.pl 9) Verify the guarantor is removed by members/update-child.pl 10) Verify the guarantor is removed by misc/cronjobs/j2a.pl 11) Verify import patrons converts guarantor_id, relationship, contactfirstname, and contactsurname into a guarantor 12) prove t/Patron.t 13) prove t/db_dependent/Circulation.t 14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 15) prove t/db_dependent/Items.t 16) prove t/db_dependent/Koha/Patrons.t 17) prove t/db_dependent/Members.t 18) prove t/db_dependent/Patron/Relationships.t Signed-off-by: Kim Peine Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22932] GetLatestSerials should not return formatted date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22932 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED Version|18.11 |master Component|OPAC|Templates Summary|Serial issues on|GetLatestSerials should not |opac-detail.pl sorts dates |return formatted date |alphabetically | --- Comment #1 from Owen Leonard --- I'm updating the bug title because the problem can't be solved without changing the way data comes out of GetLatestSerials. It shouldn't return a formatted date--we have $KohaDates for that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Nick Clemens changed: What|Removed |Added Keywords|rel_19_05_candidate | CC||n...@bywatersolutions.com --- Comment #158 from Nick Clemens --- Excited about this, but too late for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20384] Elastic rebuild script improvements - options for indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20384 axel Amghar changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20384] Elastic rebuild script improvements - options for indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20384 axel Amghar changed: What|Removed |Added Attachment #89886|0 |1 is obsolete|| --- Comment #11 from axel Amghar --- Created attachment 89888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89888=edit Bug 20384 - Elastic rebuild script improvements - options --offset, --length & --file This patch add the options --offset, --length & --file to the script: misc/search_tools/rebuild_elastic_search.pl To test : - apply the patch - verify that the script by default is working, launch : perl misc/search_tools/rebuild_elastic_search.pl -v -d -c 100 - launch with the option --offset - then with the option --length - launch with both options : perl misc/search_tools/rebuild_elastic_search.pl -v -d -c 100 --offset 1000 --length 200 - verify that the total records indexed is 200 launch perl misc/search_tools/rebuild_elastic_search.pl --man for help Option --file : To test: - after testing offset and length, apply this patch - launch perl misc/search_tools/rebuild_elastic_search.pl -v -d -c 100 --file your_file.csv your file need to contain a column of biblionumber from biblio or authid from auth_header (only one column) You can go in Koha -> reports -> Create from sql SELECT biblionumber FROM biblio ; and then download in csv to have your csv file. - You can test with others query like : select biblionumber from biblio WHERE author LIKE 'a%'; Total number of results (411); - verify that you have the rigth number of records indexed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22922] Allow to modify hold dates on reserve/request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Julian Maurice changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #4 from Julian Maurice --- Thanks for the feedback. I will write a followup soon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20384] Elastic rebuild script improvements - options for indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20384 axel Amghar changed: What|Removed |Added Attachment #89727|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20384] Elastic rebuild script improvements - options for indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20384 axel Amghar changed: What|Removed |Added Attachment #89559|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20384] Elastic rebuild script improvements - options for indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20384 --- Comment #9 from axel Amghar --- Created attachment 89886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89886=edit Bug 20384 - Elastic rebuild script improvements - options --offset, --length & --file This patch add the options --offset, --length & --file to the script: misc/search_tools/rebuild_elastic_search.pl To test : - apply the patch - verify that the script by default is working, launch : perl misc/search_tools/rebuild_elastic_search.pl -v -d -c 100 - launch with the option --offset - then with the option --length - launch with both options : perl misc/search_tools/rebuild_elastic_search.pl -v -d -c 100 --offset 1000 --length 200 - verify that the total records indexed is 200 launch perl misc/search_tools/rebuild_elastic_search.pl --man for help Option --file : To test: - after testing offset and length, apply this patch - launch perl misc/search_tools/rebuild_elastic_search.pl -v -d -c 100 --file your_file.csv your file need to contain a column of biblionumber from biblio or authid from auth_header (only one column) You can go in Koha -> reports -> Create from sql SELECT biblionumber FROM biblio ; and then download in csv to have your csv file. - You can test with others query like : select biblionumber from biblio WHERE author LIKE 'a%'; Total number of results (411); - verify that you have the rigth number of records indexed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20384] Elastic rebuild script improvements - options for indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20384 axel Amghar changed: What|Removed |Added Attachment #89560|0 |1 is obsolete|| --- Comment #10 from axel Amghar --- Created attachment 89887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89887=edit Bug 20384: unit test for get_all_biblios_iterator & get_all_authorities_iterator -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22922] Allow to modify hold dates on reserve/request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 --- Comment #3 from Owen Leonard --- (In reply to Katrin Fischer from comment #2) > What is the use case for changing the date the hold was placed? (allowing > them to be in the future? And should this not depend on the syspref then?) I'm not sure what the use case is if you're *not* changing a hold date to/from a future date, but I think that's good enough reason to have the ability. Tying the operation to AllowHoldDateInFuture sounds right to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 --- Comment #34 from Andrew Isherwood --- Created attachment 89885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89885=edit Bug 15260: (follow-up) Add missing POD As per comment #33 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 Andrew Isherwood changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22908] Modsuggestion will generate a notice even if the modification failed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22908 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- Works when you run prove on the test, but not with perl [other sql mode]? New test fails then. Shouldnt DBIx always raise a warning if you want to pollute a date field? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22905] Cannot upate the status of suggestions if the branchcode filter is set to all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #12 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #1) > All this code is awful, I have no idea how to fix it simply and without > introduce regressions. Yes, this definitely is horrible. I suggest a simpler fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22905] Cannot upate the status of suggestions if the branchcode filter is set to all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905 --- Comment #11 from Marcel de Rooy --- Created attachment 89884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89884=edit Bug 22905: Counterpatch removing just branchcode The suggested patches replace using $suggestion_only, making much more changes than needed. I would opt for removing the offending branchcode. In this case __ANY__. Apart from strict SQL mode, it is just wrong. This patch touches just one line. Same test plan. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22930] Make TestBuilder more strict about wrong arguments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22930 Marcel de Rooy changed: What|Removed |Added Summary|Make TestBuilder more |Make TestBuilder more |strict when called with too |strict about wrong |wrong arguments |arguments -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22930] Make TestBuilder more strict when called with too wrong arguments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22930 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | Status|Signed Off |Passed QA CC||m.de.r...@rijksmuseum.nl --- Comment #4 from Marcel de Rooy --- Simple patch. Passing QA rightaway. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22930] Make TestBuilder more strict when called with too wrong arguments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22930 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22930] Make TestBuilder more strict when called with too wrong arguments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22930 --- Comment #3 from Marcel de Rooy --- Created attachment 89883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89883=edit Bug 22930: (QA follow-up) Add two test descriptions No more than that ;) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22930] Make TestBuilder more strict when called with too wrong arguments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22930 Marcel de Rooy changed: What|Removed |Added Attachment #89864|0 |1 is obsolete|| --- Comment #2 from Marcel de Rooy --- Created attachment 89882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89882=edit Bug 22930: Make TestBuilder->build_object explodes if parameters are wrong This patch implements bug 15339 for build_object. We want it to warn if the call is wrong. Test plan: Make sure the tests are still returning green Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22929] Enabling the GDPR_Policy will affect libraries using the SCO module in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22929 Marcel de Rooy changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22929] Enabling the GDPR_Policy will affect libraries using the SCO module in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22929 --- Comment #1 from Marcel de Rooy --- Created attachment 89881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89881=edit Bug 22929: Allow SCI/SCO logins independent of GDPR_Policy This patch makes Auth skip the GDPR policy check when get_template_and_user is called for sci/sco (self checkin, checkout). I do not really like the change in this form but the nature of self checkin and checkout kind of dictate it (double hack). I wanted to add a test but since that asks for mocking CGI, checkauth, etc. the time needed for that is just too much for this simple change. Test plan: Enable GDPR_Policy and self checkin/checkout. Verify that using patrons without consent is not blocking sci/sco. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22903] Elasticsearch, dynamic display when you refine your search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22903 --- Comment #6 from axel Amghar --- Created attachment 89880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89880=edit Bug 22903: Unit test for sub getRecords in C4/Search.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22929] Enabling the GDPR_Policy will affect libraries using the SCO module in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22929 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED Version|18.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
