[Koha-bugs] [Bug 22644] Some tests in Upload.t are not testing the right thing

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22644

--- Comment #5 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #4)
> Marcel, what do you think? How could I provide tests for bug 22508 without
> having this being fixed? Any ideas?

Will have a look very soon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22627] Rephrase 'your fines' tab in OPAC

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22943] The in_ipset C4::Auth function name can be confusing.

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22943

Martin Renvoize  changed:

   What|Removed |Added

  Component|System Administration   |Architecture, internals,
   ||and plumbing

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22210] Allow organisations to sign up to Mana KB (don't only ask for firstname lastname)

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210

--- Comment #7 from Katrin Fischer  ---
(In reply to Michal Denar from comment #6)
> Hi Alex,
> patch works but if I follow ling filed Name, Last nname and e-mail are
> empty. I know it's on Mana server side ... Is it correct result?
> 
> Thank you

I've also got some problems with the sign-up process. In my koha-conf.xml I
have the mana test server, but when I register, the email I receive reads:
https://ui.mana-kb.koha-community.org/registration?id=aa1JLPnpz6vBshtSpm2f6yr4sKKmJZ26

And clicking on it it tells me my token is too old or doesn't exist?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22736] Search field on "New order > from suggestion" search for borrowernumber

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22736

--- Comment #6 from Fridolin SOMERS  ---
(In reply to Jonathan Druart from comment #5)
> Your* answer shows us it is a bug actually :)

Ok, but I don't know how it could be fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22923] Items search does not take care of independent branches

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22923

--- Comment #2 from Fridolin SOMERS  ---
(In reply to Katrin Fischer from comment #1)
> The edit buttons needs to be checked

Could we simply hide "Edit item" in IndependentBranches context ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20208] Custom file upload paths

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20208

Devinim  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20208] Custom file upload paths

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20208

Devinim  changed:

   What|Removed |Added

  Attachment #84524|0   |1
is obsolete||
  Attachment #84525|0   |1
is obsolete||

--- Comment #8 from Devinim  ---
Created attachment 89954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89954&action=edit
Bug 20208: Custom file upload paths

Test plan:
1) Apply the patch, run updatedatabase and update_dbix_class_files
2) Run prove t/db_dependent/Upload.t
3) Go to tools/update any file menu.
4) Upload two files with and without checksum using tools/upload
5) Add a new option to UPLOAD authorized value area.
6) Upload two files with and without checksum by selecting the option you
created in step 5.
7) Add a new option to UPLOAD_PATH authorized value area.
8) Try to upload new files by selecting pulldown menus or other options in the
upload page.
9) Test new feature nameley file tree whether files were uploaded.
10) Check the files in the /var/lib/koha/kohadev/uploads
11) By adding or changing a biblio, use 856u field and test also selecting file
from new file tree option. (upload should be choosen for 856u field. )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22835] Serve static files from plugins through the API

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835

--- Comment #11 from Fridolin SOMERS  ---
What do you say Tomás ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22736] Search field on "New order > from suggestion" search for borrowernumber

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22736

--- Comment #7 from Séverine Queune  ---
If it's too difficult too fix, maybe we could just display borrowernumber
between parenthesis ?
What bothered me was having some suggsstions displayed after a search without
knowing why, because none of the displayed values matched the search.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22961] Allow special characters in password complexity

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22961

Amit Gupta  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |amitddng...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22961] New: Allow special characters in password complexity

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22961

Bug ID: 22961
   Summary: Allow special characters in password complexity
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: amitddng...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
  Target Milestone: ---

Allow special characters in password complexity.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22961] Allow special characters in password complexity

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22961

Amit Gupta  changed:

   What|Removed |Added

 CC||amit.gupta@informaticsgloba
   ||l.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22960] Typo found in circulation.pref in UpdateItemLocationOnCheckin preference

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22835] Serve static files from plugins through the API

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835

--- Comment #12 from Tomás Cohen Arazi  ---
(In reply to Fridolin SOMERS from comment #11)
> What do you say Tomás ?

I haven't pondered the effort required to implement a whole new endpoint in our
current complex setup
- New Apache config
- New plack tweaks
- New mojo app and controller?

It all seems too much given the simplicity of this dev. I'd rather just allow
an array of openapi specs and leave to the plugin authors the decision of
making it a real API or not. The main dev here is the controller class for
static files and I think it is pretty cool :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22960] Typo found in circulation.pref in UpdateItemLocationOnCheckin preference

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960

--- Comment #1 from Owen Leonard  ---
Created attachment 89955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89955&action=edit
Bug 22960: Typo found in circulation.pref in UpdateItemLocationOnCheckin
preference

This patch corrects a typo in circulation.pref in the description of the
UpdateItemLocationOnCheckin preference.

To see the problem, go to Administration -> System preferences ->
Circulation and look at the description for the
UpdateItemLocationOnCheckin preference:

"The special term _BLANK_ may be used on either side of a value pair to
update or remove the location from items with no locaiton assigned."

Note the misspelling "locaiton."

To test, apply the patch and refresh the circulation preferences page.
The typo should be fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22960] Typo found in circulation.pref in UpdateItemLocationOnCheckin preference

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22644] Some tests in Upload.t are not testing the right thing

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22644

--- Comment #6 from Marcel de Rooy  ---
The test reflects the history of Upload to Uploader and UploadedFile(s) with
Koha::Object(s). 
I think we should put the Uploader stuff into its own test Uploader.t. And put
all Koha objects related tests to UploadedFile.t.
What UploadedFile::delete may need, is a return code: deleting the record may
have failed, but deleting the file as well.
The test could be improved by adding some temporary files.
And we need some decisions on 22508 as well. See my older comment there.
Especially, do we copy the file or keep just one and allow direct access to
selected subdirs of the clone upload folder?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13094] Make it easy to hide 'Cancel all' button on holds over report

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13094

Margaret  changed:

   What|Removed |Added

 CC||margaret@bywatersolutions.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21329] Purchase Suggestions Add Custom Fields

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21329

Kelly McElligott  changed:

   What|Removed |Added

 CC||ke...@bywatersolutions.com

--- Comment #1 from Kelly McElligott  ---
I agree with Lisette, I would love for the Purchase Suggestion form to work
like Self Registration or Adding patrons, where you could pick unwanted fields
in the Purchase Suggestion form.  A lot of libraries love this feature, but
would like to be able to customize easier than using jquery.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22962] New: Wrong punctuation in RisExportAdditionalFields system preference

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22962

Bug ID: 22962
   Summary: Wrong punctuation in RisExportAdditionalFields system
preference
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
  Target Milestone: ---

The system preference RisExportAdditionalFields reads

Include following fields when exporting RIS,

The comma at the end should probably be something else.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22962] Wrong punctuation in RisExportAdditionalFields system preference

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22962

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |ch...@bigballofwax.co.nz
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22962] Wrong punctuation in RisExportAdditionalFields system preference

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22962

Katrin Fischer  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22963] New: Wrong capitalization in RisExportAdditionalFields system preference

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22963

Bug ID: 22963
   Summary: Wrong capitalization in RisExportAdditionalFields
system preference
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
  Target Milestone: ---

The "Click to Edit" link breaks our capitalization guidlines.  It should be
"Click to edit"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22962] Wrong punctuation in RisExportAdditionalFields system preference

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22962

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22963] Wrong capitalization in RisExportAdditionalFields system preference

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22963

Martin Renvoize  changed:

   What|Removed |Added

   Patch complexity|--- |String patch
   Severity|enhancement |trivial

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22963] Wrong capitalization in RisExportAdditionalFields system preference

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22963

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22508] Add the ability to prefill 856$u with the direct URL of the file

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508

--- Comment #35 from Marcel de Rooy  ---
(In reply to Hugo Agud from comment #31)
> The original goal of this patch is to allow discoveries to access directly 
> the files located at koha repository for full text indexing, it is not
> really a matter of public and private files, the perhaps the checkbox public
> here is not appropiate... just direct access?
> 
> To be able to manage public and private files (just the file, not the
> records) is also a great functionality that koha could have that could be
> developed in another bug?

We might be misunderstanding each other here. But what we do here, is making a
change in a feature that already supports the distinction between private and
public.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22508] Add the ability to prefill 856$u with the direct URL of the file

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508

--- Comment #36 from Marcel de Rooy  ---
(In reply to Fridolin SOMERS from comment #32)
> I see there is Bug 22835.
> Should we serve also those uploaded file via API ?
> In another bug report I mean.

Looking at that bug, I think it serves another specific need apart from this
functionality request.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22962] Wrong punctuation in RisExportAdditionalFields system preference

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22962

Chris Cormack  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22962] Wrong punctuation in RisExportAdditionalFields system preference

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22962

--- Comment #1 from Chris Cormack  ---
Created attachment 89956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89956&action=edit
Bug 22962 : Punctuation error in RisExportAdditionalFields

To test
1/ Go to systempreferences search for RisExportAdditionalFields
2/ See the extra , on the first line
3/ Apply the patch
4/ See it is fixed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22760] catalogue search yields no results if queryparser is on

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22760

Margaret  changed:

   What|Removed |Added

 CC||margaret@bywatersolutions.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14669] Search orders by managing library

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14669

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #5 from Caroline Cyr La Rose  ---
Not sure if it's me or the patch, but when I try to apply, I get this message

Traceback (most recent call last):
  File "/usr/local/bin/git-bz", line 2671, in 
do_apply(*args)
  File "/usr/local/bin/git-bz", line 1734, in do_apply
attachmentdata=True)
  File "/usr/local/bin/git-bz", line 1472, in load
bug._load(bug_reference.id, attachmentdata)
  File "/usr/local/bin/git-bz", line 1228, in _load
response = self.server.send_request("GET", url)
  File "/usr/local/bin/git-bz", line 998, in send_request
cookies = self.get_cookie_string()
  File "/usr/local/bin/git-bz", line 991, in get_cookie_string
self.cookies = get_bugzilla_cookies(host)
NameError: global name 'host' is not defined

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22508] Add the ability to prefill 856$u with the direct URL of the file

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508

--- Comment #37 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #33)
> (In reply to Marcel de Rooy from comment #28)
> > > tools/upload-file.pl:
> > > 
> > > # FIXME The copy must be done in Koha::Uploader, but where?
> > > # I (Joubu) did not find a place where the file was completely written
> > 
> > Look at Uploader sub cgi when it calls sub _done. The file is written in
> > _hook. So you should be in _done.
> 
> I have tried _done, but it did not work. I cannot remember exactly why but
> IIRC it was not called when needed. I will have another look later.

I feel that we should not touch Uploader after all. Maybe we should just keep
one file and allow (by default) direct access to a *public* subdirectory of
uploads? Probably allowing subdirs as well there. Maybe pref controlled
(nothing better than adding yet another one)..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22962] Wrong punctuation in RisExportAdditionalFields system preference

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22962

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||joonas.kylm...@helsinki.fi

--- Comment #2 from Joonas Kylmälä  ---
I think it should be changed to a colon ":" since the there will be a list of
items following the sentence.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22508] Add the ability to prefill 856$u with the direct URL of the file

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508

--- Comment #38 from Hugo Agud  ---
the less complexity the better...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22964] New: Change "product" language on bugzilla bug report page

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22964

Bug ID: 22964
   Summary: Change "product" language on bugzilla bug report page
 Change sponsored?: ---
   Product: Project Infrastructure
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Bugzilla
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: do...@kattekrab.net
  Target Milestone: ---

Created attachment 89957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89957&action=edit
screenshot of the "select product" text on bugzilla

When filing a bug, we see these words:

First, you must pick a product on which to enter a bug:

Koha:   Koha - Free Software ILS
Koha security:  Security bugs for Koha. Please use this product ONLY if you are
reporting a security bug that should be held in confidence prior to the release
of a fix.
Project Infrastructure: For logging bugs related to the Koha project
infrastructure. Not Koha itself. You almost certainly don't want to log a bug
here, but under the Koha project.


I find "Pick a product" and "Use this product" to be a bit confusing in this
context.

Here's some alternative phrasing to consider.

First, you need to decide where to enter a bug:

Koha: Koha Free Software ILS (integrated library system) 
Koha security: Security bugs for Koha. Use this ONLY if you are reporting a
security big that should be held in confidence prior to the release of a fix. 
Project Infrastructure: Bugs related to the Koha project infrastructure (eg
bugzilla, gitlab, or the project website. Not for Koha itself. You almost
certainly don't want to log a bug here, but under the Koha project.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22964] Remove the word "product" from the bugzilla bug report page

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22964

Donna Benjamin  changed:

   What|Removed |Added

Summary|Change "product" language   |Remove the word "product"
   |on bugzilla bug report page |from the bugzilla bug
   ||report page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22963] Wrong capitalization in RisExportAdditionalFields system preference

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22963

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Martin Renvoize  ---
Resolved in master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22962] Wrong punctuation in RisExportAdditionalFields system preference

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22962

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #89956|0   |1
is obsolete||

--- Comment #3 from ByWater Sandboxes  ---
Created attachment 89958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89958&action=edit
Bug 22962 : Punctuation error in RisExportAdditionalFields

To test
1/ Go to systempreferences search for RisExportAdditionalFields
2/ See the extra , on the first line
3/ Apply the patch
4/ See it is fixed

Signed-off-by: Katrin fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22962] Wrong punctuation in RisExportAdditionalFields system preference

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22962

Katrin Fischer  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22760] catalogue search yields no results if queryparser is on

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22760

--- Comment #2 from Margaret  ---
Hello Mikaël,

Can you give me a little more context for this testing step: "Alternate between
the page results a few times. 1/2 times, the page will return no results." Does
this mean paginating through the results? Or clicking into results details,
then back to results, then in to details and back again? 

Thanks, Margaret

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899

Galen Charlton  changed:

   What|Removed |Added

 CC||gmcha...@gmail.com

--- Comment #17 from Galen Charlton  ---
As this is also a regression in 18.11.05, I request that this be backported to
18.11.x or that the patch for bug 15505 be reverted from 18.11.x.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899

Galen Charlton  changed:

   What|Removed |Added

   Keywords||regression

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22053] Ability to disable some plugins

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053

Nick Clemens  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |

--- Comment #35 from Nick Clemens  ---
(In reply to Tomás Cohen Arazi from comment #32)
> @RM, follow-up fixes the tests.

This has been pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #24 from Marcel de Rooy  ---
(In reply to Nick Clemens from comment #18)
> One note too: With this patch I cannot see the full value of the pref or
> copy the text of the pref out - it would be nice to have the helper and also
> be able to directly edit the field. Not a blocker

+1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #25 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #23)
> Or wait for a more complete and tested approach :)
> (I personally vote for the later)

+1 too

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21411] Advanced cataloging editor - rancor - Allow configuration of Keyboard shortcuts

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411

David Nind  changed:

   What|Removed |Added

  Text to go in the||This enhancement lets you
  release notes||globally redefine the
   ||keyboard shortcuts used in
   ||rancor.
 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22919] Authorities MARC Structure

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
   Keywords|additional_work_needed  |

--- Comment #1 from Nick Clemens  ---
I don't recreate this in 18.11 - can you check for any errors in the logs or
the JS console? It may be a framework issue or something else

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22965] New: Typo in Classification Sources description on Admin homepage (admin-home.tt)

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22965

Bug ID: 22965
   Summary: Typo in Classification Sources description on Admin
homepage (admin-home.tt)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bolsh...@parliament.uk
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
  Target Milestone: ---

The description for Classification Sources on the admin home page has an extra
comma. 

It reads "Define classification sources (i.e., call number schemes) used by
your collection."

It should probably read "(i.e. call number schemes)" instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22461] Regression in #20287: LDAP user replication broken with mapped extended patron attributes

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461

Nick Clemens  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22962] Wrong punctuation in RisExportAdditionalFields system preference

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22962

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #89958|0   |1
is obsolete||

--- Comment #4 from Marcel de Rooy  ---
Created attachment 89959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89959&action=edit
Bug 22962 : Punctuation error in RisExportAdditionalFields

To test
1/ Go to systempreferences search for RisExportAdditionalFields
2/ See the extra , on the first line
3/ Apply the patch
4/ See it is fixed

Signed-off-by: Katrin Fischer 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22962] Wrong punctuation in RisExportAdditionalFields system preference

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22962

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22962] Wrong punctuation in RisExportAdditionalFields system preference

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22962

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |String patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22934] Add missing use statement to Koha::AdditionalFieldValue

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22934

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #89919|0   |1
is obsolete||

--- Comment #4 from Marcel de Rooy  ---
Created attachment 89960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89960&action=edit
Bug 22934: Add missing use statement

Also fixes a typo

To test:
1 - Add a subscription to a record
2 - Add an additional field in the admin section
3 - Edit the subscription and define the additional field
4 - Ensure you can view the record in the staff client and opac
5 - Without patch ,in the subscription detail page,click the link of the record
title. => software error.
6 - Apply the patch. => no error anymore.

Signed-off-by: Owen Leonard 
Signed-off-by: Bin Wen 

Signed-off-by: Marcel de Rooy 

Fixed another typo on L21

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22934] Add missing use statement to Koha::AdditionalFieldValue

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22934

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21831] Marc modification templates move all action moves only one field

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21831

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |BLOCKED

--- Comment #9 from Marcel de Rooy  ---
QA: Looking here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #153 from David Gustafsson  ---
Created attachment 89961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89961&action=edit
Bug 14957: Fix categorycode module filter value and rename some presets

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20436] Add ability to specify itemtypes for longoverdue.pl

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20436

--- Comment #17 from Nick Clemens  ---
Created attachment 89962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89962&action=edit
Bug 20436: (RM follow-up) Use Koha objects instead of mysql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #154 from David Gustafsson  ---
Added some documentation here:
https://gitlab.com/gnucifer/koha-manual/commits/bug-14957-marc-merge-rules

I could create a pull request, but perhaps better to await some feedback before
doing that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s)

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496

Nick Clemens  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |
  Text to go in the||When transferring items
  release notes||from one record to another
   ||you are now presented with
   ||a button to delete the
   ||original host record if
   ||there are no more items
   ||remaining.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336

Nick Clemens  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22965] Typo in Classification Sources description on Admin homepage (admin-home.tt)

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22965

Henry Bolshaw  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |bolsh...@parliament.uk
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #192 from Nick Clemens  ---
Created attachment 89963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89963&action=edit
Bug 14385: (RM follow-up) Remove line from bad rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20114] Build better $query_cgi

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20114

Joonas Kylmälä  changed:

   What|Removed |Added

  Attachment #80410|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #193 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #190)
> Note: The routine C4::Biblio::get_biblio_authorised_values does not longer
> exist!

Can you confirm the supplied patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22501] OPAC course reserves notes should allow html links

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501

Nick Clemens  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373)

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
   Keywords|additional_work_needed  |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

--- Comment #74 from Nick Clemens  ---
Created attachment 89964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89964&action=edit
Bug 17698: (RM follow-up) Pass lang variable so letter can be translated

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

--- Comment #75 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #73)
> The call to GetPreparedLetter in opac/opac-issue-note.pl should pass "lang"
> in order to make CHECKOUT_NOTE translatable.

Can you test the provided follow-up?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21831] Marc modification templates move all action moves only one field

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21831

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|BLOCKED |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21831] Marc modification templates move all action moves only one field

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21831

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21831] Marc modification templates move all action moves only one field

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21831

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #89926|0   |1
is obsolete||

--- Comment #10 from Marcel de Rooy  ---
Created attachment 89965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89965&action=edit
Bug 21831: Allow move all fields even if destination field is different

Tests exist in t/SimpleMARC.t to prove that it works and it is possible.
I do not remember what I wrote this limitation.

Signed-off-by: Jon Knight 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22965] Typo in Classification Sources description on Admin homepage (admin-home.tt)

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22965

--- Comment #1 from Katrin Fischer  ---
Created attachment 89966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89966&action=edit
Bug 22965: fixes typo on classification sources description on admin homepage

Removed comma from description.

Test plan:
1. Go to Admin homepage
2. Check Classification Sources description
3. Verify that comma after i.e. has gone removed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22965] Typo in Classification Sources description on Admin homepage (admin-home.tt)

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22965

Katrin Fischer  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22966] New: Add Norwegian library and patron names for the web-based installer

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22966

Bug ID: 22966
   Summary: Add Norwegian library and patron names for the
web-based installer
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Installation and upgrade (web-based installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: pet...@libriotech.no
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
  Target Milestone: ---

The Norwegian Web-installer did not have Norwegian patron names and library
names. This bug fixes that.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20114] Build better $query_cgi

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20114

--- Comment #7 from David Gustafsson  ---
I have more or less given up on this one for the current being since the query
parsing for the search page CGI is so fubar and probably needs a larger
overhaul and refactoring than the approach in this patch. If I remember
correctly I tried fixing the current issues of the patch but each fix tended to
break other things.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924

Fridolin SOMERS  changed:

   What|Removed |Added

   Severity|enhancement |normal
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #2 from Fridolin SOMERS  ---
More a bug than enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22965] Typo in Classification Sources description on Admin homepage (admin-home.tt)

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22965

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22965] Typo in Classification Sources description on Admin homepage (admin-home.tt)

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22965

Liz Rea  changed:

   What|Removed |Added

  Attachment #89966|0   |1
is obsolete||

--- Comment #2 from Liz Rea  ---
Created attachment 89967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89967&action=edit
Bug 22965: fixes typo on classification sources description on admin homepage

Removed comma from description.

Test plan:
1. Go to Admin homepage
2. Check Classification Sources description
3. Verify that comma after i.e. has gone removed

Signed-off-by: Liz Rea 

https://bugs.koha-community.org/show_bug.cgi?id=22695

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22760] catalogue search yields no results if queryparser is on

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22760

Liz Rea  changed:

   What|Removed |Added

  Attachment #88536|0   |1
is obsolete||

--- Comment #3 from Liz Rea  ---
Created attachment 89968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89968&action=edit
Bug 22760: Correct parseQuery regex to match full words when QueryParser is on

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22760] catalogue search yields no results if queryparser is on

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22760

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13094] Make it easy to hide 'Cancel all' button on holds over report

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13094

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13094] Make it easy to hide 'Cancel all' button on holds over report

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13094

Liz Rea  changed:

   What|Removed |Added

  Attachment #89621|0   |1
is obsolete||

--- Comment #6 from Liz Rea  ---
Created attachment 89969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89969&action=edit
Bug 13094: Make it easy to hide 'Cancel all' button on holds over report

This patch makes some small modifications to the 'Holds awaiting pickup'
report:

- Fixes typo sypref
- Fixes 'Home branch' to 'Home library'
- Adds a span to easily hide the cancel all button with CSS

To test:
- Make sure you have a hold appearing on the awaiting pickup list
  second tab: Holds waiting over...
- Verify the 'cancel all' button on top shows
- Verify syspref and Home library changes mentioned above
- Add #holdsover-cancel-all { display:none; } to IntrentUserCSS
- Verify that the button and the text have vanished

Note: If the text doesn't display next to the button, try toggling
  the TransferWhenCancelAllWaitingHolds system preference.

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #147 from Liz Rea  ---
Koha can't be installed freshly with the sample patrons with this patch:


Optional data added

sample_patrons.sql

DBD::mysql::st execute failed: Unknown column 'guarantorid' in 'field list'
at /usr/share/perl5/DBIx/RunSQL.pm line 273.

So probably we need to update the sample patrons to not include that field, if
we are going to push this.

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15221] SIP server always sets the alert flag when item not returned

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15221] SIP server always sets the alert flag when item not returned

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221

Liz Rea  changed:

   What|Removed |Added

  Attachment #89928|0   |1
is obsolete||

--- Comment #8 from Liz Rea  ---
Created attachment 89970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89970&action=edit
Bug 15221:  SIP server always sets the alert flag when item not returned

The checked in response from the ACS always has the alert bit set to
true, even when using the checked_in_ok option.

This patch sets the alert bit to 0 when checked_in_ok is used and
the item is checked in without a preceding checkout.

To test:

0) Create patron in web interface with a cardnumber and userid of "staff" with
a password
that matches the account in SIPconfig.xml. Also set their branch to CPL
(also matching SIPconfig.xml).
1) Create an item with a barcode of 'test'
2) Choose a patron to check out to and record their borrowernumber

In one terminal:
3) cd to your git directory (e.g. /home/koha/koha)
4) perl ./C4/SIP/SIPServer.pm ~/koha-dev/etc/SIPconfig.xml

In another terminal:
5) cd to your git directory (e.g. /home/koha/koha)
6) perl ./misc/sip_cli_emulator.pl -l CPL -su staff -sp  --port=6001
--address=localhost --item test -m checkin --patron 
NOTE: You need to replace  with the borrowernumber from Step 2,
and  with the password from Step 0.

Before patch:

koha@9ec653ab82ce:~/koha$ perl ./misc/sip_cli_emulator.pl -l CPL -su staff -sp
 --port=6001 --address=localhost --item test -m checkin --patron

Attempting socket connection to localhost:6001...connected!
SEND: 9300CNstaff|COStaff1|CPCPL|
READ: 941

Trying 'checkin'
SEND: 09N2019052100310320190521   
003103APCPL|AOCPL|ABtest|AC|BIN|
READ: 101YNY20190521003106AOCPL|ABtest|AQCPL|AJTest|

After patch:
koha@9ec653ab82ce:~/koha$ perl ./misc/sip_cli_emulator.pl -l CPL -su staff -sp
 --port=6001 --address=localhost --item test -m checkin --patron

Attempting socket connection to localhost:6001...connected!
SEND: 9300CNstaff|CO|CPCPL|
READ: 941

Trying 'checkin'
SEND: 09N201905210120190521   
01APCPL|AOCPL|ABtest|AC|BIN|
READ: 101YNN20190521010004AOCPL|ABtest|AQCPL|AJTest|

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22746] Another typo found in mana-subscription-search-result.inc (Mana KB)

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22746

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |String patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22746] Another typo found in mana-subscription-search-result.inc (Mana KB)

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22746

Owen Leonard  changed:

   What|Removed |Added

  Attachment #88447|0   |1
is obsolete||

--- Comment #3 from Owen Leonard  ---
Created attachment 89971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89971&action=edit
Bug 22746: Fix typos in add mana comment modals again

Test plan:
1) Create subscription from Mana
2) On subscription detail page: report mistake > other a modal is shown
it should be exactly 'Please enter a new commment (max 35 characters)'
3) The same in mana search results and in reports

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445

Michal Denar  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #33 from Michal Denar  ---
Can you rebase this on master, please?

Thank you.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492

--- Comment #59 from Michal Denar  ---
Is possible to rebase this on master?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20208] Custom file upload paths

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20208

Marcel de Rooy  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22967] New: Adding the carousel to the advanced search

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22967

Bug ID: 22967
   Summary: Adding the carousel to the advanced search
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alexandre.bre...@ccsr.qc.ca
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

The carousel is a cool feature. But some libraries set Koha to make users
entering by the advanced search page (rather than OPAC home page). 

This page cannot offers the carousel because it doesn't have a space for html
code.

It would be useful for these libraries to display theirs new items.

Thanks,

Alexandre

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22968] New: Adding a column for collection editor name in search results

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22968

Bug ID: 22968
   Summary: Adding a column for collection editor name in search
results
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alexandre.bre...@ccsr.qc.ca
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl
  Target Milestone: ---

It would be useful to add a column to indicate the editor name for collection's
titles authorities. It will save some time to the librarian when cataloguing
because the only way to verify this is to go in the complete authority and
check the area 643.

The column could identify the editor or organism making the publication which
appears in the field 643, subfield $b in the authority record 130.

It could be useful to add this info for search results in bibliographics
records and for search results in Authorities module. This improvement could be
made as a system preference allowing us to choose which feilds we want to
display (it will be more practical for more people then).

Thanks,

Alexandre

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22966] Add Norwegian library and patron names for the web-based installer

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22966

--- Comment #1 from pvkrogh  ---
Created attachment 89972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89972&action=edit
Bug 22966: Add Norwegian library and patron names for installer

THe Norwegian installer had reused english smaple atrons and libraries,
 this patch fixes this.

 test plan:
 empty database
 install norwegian translation
 run the web-installer and choose norwegian language
 select sample libraries and patrons
 make sure there are no errors

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22966] Add Norwegian library and patron names for the web-based installer

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22966

pvkrogh  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22966] Add Norwegian library and patron names for the web-based installer

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22966

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22966] Add Norwegian library and patron names for the web-based installer

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22966

Magnus Enger  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |pet...@libriotech.no
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >