[Koha-bugs] [Bug 22910] Do not copy unique patron attributes to duplicated patron

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22910

Katrin Fischer  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #6 from Katrin Fischer  ---
I am not sure when I can retest - putting this back into the QA queue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22910] Do not copy unique patron attributes to duplicated patron

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22910

--- Comment #5 from paxed  ---
(In reply to Katrin Fischer from comment #3)
> Very oddly, but this doesn't work for me. Can you please recheck?
> 
> What I did:
> - Fresh database, created with reset_all
> - Created a new patron attribute ID = Identifier as unique
> - Edited my patron (42), setting it to uuu and SHOW_BARCODE to No
> - Saved
> - Duplicate patron 
> - uuu remains

Retried it again, and it (still) works for me. No idea what's different (other
than me not using kohadevbox and manually installing koha)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

--- Comment #24 from Jonathan Druart  
---
I do not know if there is a precedence, but here, adding a new suggestion from
the REST API and from the interface will not called the same method/subroutine

IMO we should not do that.
Before implementing this, we should move/update C4 code and controllers to use
Koha::Suggestion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

Arthur Suzuki  changed:

   What|Removed |Added

   Assignee|m...@jkozlovsky.cz  |arthur.suz...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

--- Comment #23 from Arthur Suzuki  ---
Created attachment 90172
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90172=edit
Bug 17314 : Migration from Swagger2 to OpenApi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

Arthur Suzuki  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

Arthur Suzuki  changed:

   What|Removed |Added

  Attachment #58101|0   |1
is obsolete||
  Attachment #58993|0   |1
is obsolete||
  Attachment #60133|0   |1
is obsolete||

--- Comment #22 from Arthur Suzuki  ---
Created attachment 90171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90171=edit
Implemented suggestions REST API

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21494] No checkin notice created for offline circulation checkins

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21494

--- Comment #4 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #3)
> Jonathan, do you think the fix would be to use AddReturn? 
> 
> I haven't checked yet, but I think the only issue I could imagine is that
> you need to manipulate the time of return. But we can do that in the GUI, so
> I assume it should be possible.

We should investigate the side effects, for instance AddReturn will test if the
item can be checked in, whereas MarkIssueReturned will (almost only) move the
entry from issues to old_issues.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23003] New: Accessibility improvements

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003

Bug ID: 23003
   Summary: Accessibility improvements
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

>From the french mailing list:
The Ministry of Culture published a study detailing the accessibility of
different OPAC in France.

There are some areas that we could improve.

Koha gets a quite good score, but a 'C' is given for:
1. the "skip links" - https://www.wikiwand.com/en/Skip_link
2. No search autocomplete
3. Button to place a hold on

Also they pointed out that Tanaguru gives Koha a score of 65%, we could
certainly improve it. https://www.tanaguru.com/en/open-source-tools-tanaguru/

Important note: The tests have been done using the following catalogue:
http://cat-bib.nimes.fr/ (Koha 17.11.13)


http://www.culture.gouv.fr/Thematiques/Livre-et-Lecture/Actualites/Barometre-de-l-accessibilite-numerique-en-lecture-publique-2019-publication-des-resultats-de-la-3e-edition

http://www.culture.gouv.fr/content/download/213998/224/version/2/file/Barom%C3%A8tre_accessibilit%C3%A9_num_DGMIC%202019_volet_2.pdf

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22919] Authorities MARC Structure

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919

--- Comment #6 from Jonathan Druart  
---
What is the exact version of Koha and MySQL/MariaDB are you using?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22919] Authorities MARC Structure

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919

--- Comment #5 from Jonathan Druart  
---
Did you set strict_sql_modes in your koha-conf.xml file?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22944] avoid AnonymousPatron in search_patrons_to_anonymise

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22944

--- Comment #8 from Jonathan Druart  
---
(In reply to Fridolin SOMERS from comment #7)
> (In reply to Jonathan Druart from comment #5)
> > I think this test must be removed as it is not testing anything useful: the
> > previous statement will explode if something went wrong.
> 
> Hi, you mean this test ?
> 
>   is( $rows_affected, 0, 'AnonymiseIssueHistory should not return any error
> if success' );

yes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907

--- Comment #16 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #12)
> I am having trouble understanding what you do here and why you do it:
[...]

Oops, sorry for catching that. It was indeed related to another bug. I have
amended the patch to remove those changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #89873|0   |1
is obsolete||
  Attachment #89874|0   |1
is obsolete||
  Attachment #89875|0   |1
is obsolete||

--- Comment #13 from Jonathan Druart  
---
Created attachment 90168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90168=edit
Bug 22907: Fix new suggestion with strict sql modes

With sql_strict_modes turned on, if you try to create a new suggestion
you will get:
Incorrect integer value: '' for column '$INT_COLUMN' at row 1

Test plan:
Turn on strict_sql_modes, create a new suggestion, then edit it.

Signed-off-by: Liz Rea 

JD: Edit after SO, remove unecessary changes (not related to this bug)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907

--- Comment #15 from Jonathan Druart  
---
Created attachment 90170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90170=edit
Bug 22907: Add missing use statement

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907

--- Comment #14 from Jonathan Druart  
---
Created attachment 90169
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90169=edit
Bug 22907: Remove previous code handling the same thing

See:
  commit a71b96295fb07084e4f87ac1a471e89355f3c5a4
  Bug 12627: Fix default values

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21477] Use of REMOTE_ADDR causes problems when Koha is behind a proxy

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21477

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16497] Add routes for library retrieval, update and deletion

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
  Text to go in the||This new feature adds APIs
  release notes||to list all or individual
   ||libraries, and to add,
   ||update or delete a library
   ||where appropriate
   ||permissions are held.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
  Text to go in the||This new feature adds APIs
  release notes||for checkouts and renewals.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21477] Use of REMOTE_ADDR causes problems when Koha is behind a proxy

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21477

Ed Veal  changed:

   What|Removed |Added

 CC||ev...@mckinneytexas.org

--- Comment #2 from Ed Veal  ---
I would also like to add that we would be interested in a solution to this
issue as well. It is preventing us from providing the best customer service we
can as a library. 

Ed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23002] OPAC doesn't hold search filters in results pages

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23002

--- Comment #1 from Alexandre  ---
Created attachment 90167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90167=edit
image 2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23002] New: OPAC doesn't hold search filters in results pages

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23002

Bug ID: 23002
   Summary: OPAC doesn't hold search filters in results pages
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: alexandre.bre...@ccsr.qc.ca
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

Created attachment 90166
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90166=edit
image 1

Hi,

We observed that if we place a link in OPAC leading to a search results (to see
monthly's new additions for exemple) and we add another filter on these results
(available to borrow for exemple, see image 1 with 76 results), when we are
consulting the results pages, the OPAC will not hold the 2nd filter and will
return to the maximum results for the 1st filter (new items in this this case,
see image 2 with 111 results). 

This is occurring at the moment we are changing page in results.

This bug is a little bit confusing for users.

Thanks for the help,

Alexandre

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22834] Add a method for plugins to return the absolute path for bundled files

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22834

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Pushed for QA   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22834] Add a method for plugins to return the absolute path for bundled files

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22834

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23001] New: When the whole authority record is searched, search always returns all records

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23001

Bug ID: 23001
   Summary: When the whole authority record is searched, search
always returns all records
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Searching - Zebra
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
  Target Milestone: ---

When the "search entire record" (staff) or "in the complete record" (OPAC)
search options are used, no matter what you search, Koha always returns all
authority records in the database.

Tested with a fresh reset_all database on master.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22951] Markup error in OPAC holds template

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22639] Elasticsearch ability export mappings and facets settings

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639

Michal Denar  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22639] Elasticsearch ability export mappings and facets settings

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639

Michal Denar  changed:

   What|Removed |Added

  Attachment #90151|0   |1
is obsolete||

--- Comment #24 from Michal Denar  ---
Created attachment 90165
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90165=edit
Bug 22639: Elasticsearch ability to export mappings and facets settings

With this patch you can download search fields , facets order, biblios and
authorities table in search engine configuration

Test plan:
- apply the patch
- make sure you have "elasticsearch" as value for the syspref "SearchEngine"
- go to search engine configuration in the admin page
- in the search fields part, you have a button "Download ... table"
- download in (.csv), (.tab), (.ods)
- verify that you have the same table in your file than in the search fields
table
- make the same test for
: biblios table
: facet order table
: authorities table
- Add some mappings, modify some fields, change the facets order
- Save your modifications
- Then dowload again
- Your new files must be modified

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23000] New: Running xsltproc for authority index definitions adds unwanted changes

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23000

Bug ID: 23000
   Summary: Running xsltproc for authority index definitions adds
unwanted changes
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching - Zebra
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
  Target Milestone: ---

When running the xsptproc process for generating the authority zebra index
configuration, there are unwanted changes added to the files:

xsltproc /etc/koha/zebradb/xsl/koha-indexdefs-to-zebra.xsl
authority-koha-indexdefs.xml > authority-zebra-indexdefs.xsl

Generates:

  

  
0

  

  


  

  

I think this is only meant for the bibliographic file.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22999] New: Switch two-column templates to Bootstrap grid: Circulation

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999

Bug ID: 22999
   Summary: Switch two-column templates to Bootstrap grid:
Circulation
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Blocks: 20654
  Target Milestone: ---

The circulation (check out) template should be updated to use the Bootstrap
grid.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654
[Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654

Owen Leonard  changed:

   What|Removed |Added

 Depends on||22999


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999
[Bug 22999] Switch two-column templates to Bootstrap grid: Circulation
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22948] Markup error in OPAC bibliographic detail template

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22992] When you merge records in a list there is no way to return to the list

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22992

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #2 from Owen Leonard  ---
I see one very small issue: This breadcrumb link:

Contents of [% shelf.name | uri %]

...that should use the "html" filter instead of "uri"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346

--- Comment #67 from Owen Leonard  ---
(In reply to Magnus Enger from comment #65)

> Could we make it optional if the popup message is a modal or not?

Agree 100%

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22998] Patrons Notifications for subscription batch edit

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22998

--- Comment #1 from Alexandre  ---
Created attachment 90164
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90164=edit
vendors notifications

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22998] New: Patrons Notifications for subscription batch edit

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22998

Bug ID: 22998
   Summary: Patrons Notifications for subscription batch edit
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alexandre.bre...@ccsr.qc.ca
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com
  Target Milestone: ---

Created attachment 90163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90163=edit
batch edit

Hi,

It will be useful to have an option sending notifications from the subcription
batch edit to advertise users on routing list about changes on subscriptions by
a notification system like the one for "Mofify subscritption" in "Serials".

Thanks,

Alexandre

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15221] SIP server always sets the alert flag when item not returned

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221

Nick Clemens  changed:

   What|Removed |Added

   Keywords||additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

--- Comment #52 from Owen Leonard  ---
Created attachment 90162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90162=edit
Bug 14242: (follow-up) Move English strings out of JavaScript

In order for English strings to be translatable they must be defined in
the template, not in the JS file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

--- Comment #50 from Owen Leonard  ---
Created attachment 90160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90160=edit
Bug 14242: (follow-up) Strip hyphen from ISBN for search purposes

To test, enter a valid ISBN complete with -
eg
978-1-78416-110-1

The search should still work

Signed-off-by: Marc 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

--- Comment #51 from Owen Leonard  ---
Created attachment 90161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90161=edit
Bug 14242: (follow-up) Translateable js strings, $raw filter

Sponsored-by: Region Halland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Owen Leonard  changed:

   What|Removed |Added

  Attachment #85031|0   |1
is obsolete||
  Attachment #85032|0   |1
is obsolete||
  Attachment #85033|0   |1
is obsolete||
  Attachment #85034|0   |1
is obsolete||
  Attachment #89643|0   |1
is obsolete||
  Attachment #89662|0   |1
is obsolete||

--- Comment #47 from Owen Leonard  ---
Created attachment 90157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90157=edit
Bug 14242: Use ISBN-field to automaticly fill out purchase suggestions

Add new jQuery plugin "autofill" which transforms selected element(s) into
search fields for Google Books API and automaticly fills requested fields with
search result.

Use in OPAC purchase suggestions to automaticly fill out fields when entering
ISBN-number.

Test plan:
1. Run updatedatabase.pl
2. Enable system precference "OPACAutoFill"
3. Log into OPAC and go to purchase suggetions page
4. Write a valid ISBN into the ISBN field and press the edit icon next to the
   field, or unfocus the field.
5. Title, Author, Publisher and Item Type fields should now be filled
   automaticly.
6. Press "undo" to undo - should restore all changed fields to original values

Tested all patches together, works as expected.
Signed-off-by: Marc 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

--- Comment #48 from Owen Leonard  ---
Created attachment 90158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90158=edit
Bug 14242: (follow up) renaming syspref

OPACAutoFill -> OPACSuggestionAutoFill

Signed-off-by: Marc 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

--- Comment #49 from Owen Leonard  ---
Created attachment 90159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90159=edit
Bug 14242: (follow-up) Change the icon to words

Fix a bug that meant it would search on empty ISBN

To test
1. Fill in a valid ISBN (Book data is correctly loaded)
2. Clear the ISBN from the field (Book data is correctly removed)
3. Tab away from the empty ISBN field: Data is loaded for a title
  "ISBN 0-9690745-2-2"
4. Apply patch
5. Repeat 1,2 and 3 notice a search is no longer done

Signed-off-by: Marc 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22996] Move barcode separators to a preference

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22996

--- Comment #1 from Marcel de Rooy  ---
Created attachment 90155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90155=edit
Bug 22996: Add new preference BarcodeSeparators

Test plan:
Run new install or upgrade.
Check pref value.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22996] Move barcode separators to a preference

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22996

--- Comment #2 from Marcel de Rooy  ---
Created attachment 90156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90156=edit
Bug 22996: Move barcode separators to a preference

This patch makes batchMod.pl and inventory.pl pick the barcode
separators from a new pref BarcodeSeparators (instead of hardcoding
these separators differently).
A few other code locations may be potential candidates for such a change
too.

Test plan:
Test inventory with a few variations of BarcodeSeparators.
Test Batch item modification similarly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21494] No checkin notice created for offline circulation checkins

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21494

--- Comment #3 from Katrin Fischer  ---
Jonathan, do you think the fix would be to use AddReturn? 

I haven't checked yet, but I think the only issue I could imagine is that you
need to manipulate the time of return. But we can do that in the GUI, so I
assume it should be possible.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #7 from Fridolin SOMERS  ---
Oups the ES connexion is hardcoded :

+$.getJSON("http://localhost:9200/koha_kohadev_biblios/data/;,
biblionumber, function( data ){

You must get server+port and index name from C4::Context.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

--- Comment #2 from Fridolin SOMERS  ---
Created attachment 90154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90154=edit
Bug 22997: Searching gives no results in auth_finder.pl

During cataloguing of an existing biblio, on an heading field,
the use of tag editor fills authorities finder with existing value :
  Search main heading ($a only)
  Search main heading
Default operator beeing 'contains'.

Actually with Elasticsearch those search give no results.

Example with heading :
200
  $a Casaubon
  $b Isaac
  $f 1559-1614

Call to Elasticsearch :
"query" : {
"bool" : {
   "must" : [
  {
 "query_string" : {
  "query" : "Casaubon*",
  "default_field" : "heading-main",
   }
  },
  {
 "query_string" : {
  "query" : "(Isaac*) AND (1559-1614*)",
  "default_field" : "heading"
   }
  }
]
 }
  },
"sort" : [
   {
  "heading__sort.phrase" : "asc"
   }
 ]
  }

Patch adds to "query_string" :
  analyze_wildcard : true.

Test plan :
1) Use Elasticsearch
2) Edit an existing biblio record
3) Use tag editor on a heading
4) Click search => You get correct results
5) Check also search in authorities-home.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22724] Staff without writeoff permissions have access to 'Write off selected' button on Pay Fines tab

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22724

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22724] Staff without writeoff permissions have access to 'Write off selected' button on Pay Fines tab

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22724

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #89878|0   |1
is obsolete||
  Attachment #89879|0   |1
is obsolete||

--- Comment #20 from Kyle M Hall  ---
Created attachment 90153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90153=edit
Bug 22724: Allow only users with correct permissions to 'Write off selected'

Due to the addition of a 'Write off selected' button in 18.11, users without
writeoff permissions could mistakenly view and action the 'Write off
selected' option for a patron in Accounting > Make a payment (Fines > Pay
fines).
The attached patch corrects this error.

Test plan:
1) Make sure that a staff user has '(writeoff) Write off fines and fees'
permission disabled
2) Bring up a patron with an unpaid fee, go to Accounting -> Make a
payment
3) Note that 'Write off selected' button is displayed.
4) Select a fee, click 'Write off selected'. Note that staff member has
access to 'Write off an amount toward selected fines'
5) Apply the patch
6) Repeat steps 1-2, and note that the button is no longer displayed
7) Bonus points, as a staff user with writeoff permissions enabled check
that all four buttons (Pay amount, Pay selected, Write off all, Write
off selected) are displayed

Sponsored-by: Catalyst IT

Signed-off-by: Liz Rea 

Signed-off-by: Katrin Fischer 

Signed-off-by: Liz Rea 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||alex.arn...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Fridolin SOMERS  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co
   |ity.org |m
 Status|NEW |ASSIGNED

--- Comment #1 from Fridolin SOMERS  ---
Looks like with a 'query_string' the wildcards are by default not detected.

See
https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-query-string-query.html

analyze_wildcard

By default, wildcards terms in a query string are not analyzed. By setting this
value to true, a best effort will be made to analyze those as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21084] Searching for authorities with 'contains' gives no results if search terms include punctuation

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21084

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||22997


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997
[Bug 22997] Searching gives no results in auth_finder.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Fridolin SOMERS  changed:

   What|Removed |Added

 Depends on||21084


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21084
[Bug 21084] Searching for authorities with 'contains' gives no results if
search terms include punctuation
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] New: Searching gives no results in auth_finder.pl

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Bug ID: 22997
   Summary: Searching gives no results in auth_finder.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolin.som...@biblibre.com
  Target Milestone: ---

During cataloguing of an existing biblio, on an heading field,
the use of tag editor fills authorities finder with existing value :
  Search main heading ($a only)
  Search main heading
Default operator beeing 'contains'.

Actually with Elasticsearch those search give no results.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22826] Allow indexing of individual authority records in Elasticsearch

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22826

Fridolin SOMERS  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20384
 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20384] Elasticsearch rebuild script improvements - options for indexing

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20384

Fridolin SOMERS  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22826

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20384] Elasticsearch rebuild script improvements - options for indexing

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20384

Fridolin SOMERS  changed:

   What|Removed |Added

Summary|Elastic rebuild script  |Elasticsearch rebuild
   |improvements - options for  |script improvements -
   |indexing|options for indexing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22996] New: Move barcode separators to a preference

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22996

Bug ID: 22996
   Summary: Move barcode separators to a preference
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22996] Move barcode separators to a preference

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22996

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22898] Selenium tests for placing holds from the staff interface

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||victor.grous...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

--- Comment #8 from Kyle M Hall  ---
Created attachment 90152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90152=edit
Bug 22982: (QA follow-up) Add behavior to Koha::Account::Line::apply and unit
test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22639] Elasticsearch ability export mappings and facets settings

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639

axel Amghar  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #23 from axel Amghar  ---
I added the dowload of facet order table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22639] Elasticsearch ability export mappings and facets settings

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639

axel Amghar  changed:

   What|Removed |Added

  Attachment #90052|0   |1
is obsolete||

--- Comment #22 from axel Amghar  ---
Created attachment 90151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90151=edit
Bug 22639: Elasticsearch ability to export mappings and facets settings

With this patch you can download search fields , facets order, biblios and
authorities table in search engine configuration

Test plan:
- apply the patch
- make sure you have "elasticsearch" as value for the syspref "SearchEngine"
- go to search engine configuration in the admin page
- in the search fields part, you have a button "Download ... table"
- download in (.csv), (.tab), (.ods)
- verify that you have the same table in your file than in the search fields
table
- make the same test for
: biblios table
: facet order table
: authorities table
- Add some mappings, modify some fields, change the facets order
- Save your modifications
- Then dowload again
- Your new files must be modified

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22835] Serve static files from plugins through the API

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835

--- Comment #18 from Kyle M Hall  ---
Created attachment 90150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90150=edit
Bug 22835: (follow-up) Remove comented code

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22835] Serve static files from plugins through the API

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835

--- Comment #17 from Kyle M Hall  ---
Created attachment 90149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90149=edit
Bug 22835: (follow-up) Remove unwanted warn

Signed-off-by: Arthur Suzuki 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21042] Pay amount does not mark lost items as returned when those accountlines are paid

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21042

Kyle M Hall  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||k...@bywatersolutions.com
 Status|Needs Signoff   |RESOLVED

--- Comment #6 from Kyle M Hall  ---


*** This bug has been marked as a duplicate of bug 22982 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Kyle M Hall  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #7 from Kyle M Hall  ---
*** Bug 21042 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22835] Serve static files from plugins through the API

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #89663|0   |1
is obsolete||
  Attachment #89664|0   |1
is obsolete||
  Attachment #89812|0   |1
is obsolete||

--- Comment #16 from Kyle M Hall  ---
Created attachment 90148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90148=edit
Bug 22835: Serve plugin static files through API

This patch serves static files declared within plugins.

To declare static files the plugin must implement the method 'static_routes'
which retrieves the spec of static file routes to add to the API.

Once those routes are added to the API, the become available through the
/api/v1/contrib//static endpoint.

To test:
1) Install bug-22835-plugin.kpz
2) Point your browser to /api/v1/contrib/kitchensink/static/static_files/mm.gif
CHECK => No file is served
3) Apply this patch
4) restart_all
5) Repeat step 2.
SUCCESS => File is served!
6) Sign off

Sponsored-by: Theke
Signed-off-by: Arthur Suzuki 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22835] Serve static files from plugins through the API

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22995] New: when importing from Z3950 format indicators

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22995

Bug ID: 22995
   Summary: when importing from Z3950 format indicators
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: christophe.croulleb...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl
  Target Milestone: ---

We should use sub format_indicator :

Translate indicator value for output form - specifically, map
indicator = ' ' to ''.  This is for the convenience of a cataloger
using a mouse to select an indicator input.

https://gitlab.com/koha-community/Koha/blob/604c7b818b63b93c66bb751ceb9d99bc1c109be9/cataloguing/addbiblio.pl#L456

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Katrin Fischer  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed for QA   |Failed QA

--- Comment #73 from Katrin Fischer  ---
"Pushed for QA" still doesn't mean what you think ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Arthur Suzuki  changed:

   What|Removed |Added

 Status|Failed QA   |Pushed for QA

--- Comment #72 from Arthur Suzuki  ---
(In reply to Magnus Enger from comment #66)
> attachment 88300 [details] [review] has merge markers () in it. Maybe
> the rebase was not complete?

Thanks for pointing that out :) did a re-rebase and re-upload, everything
applies fine now (still asking for QA though)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22992] When you merge records in a list there is no way to return to the list

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22992

--- Comment #1 from axel Amghar  ---
Created attachment 90145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90145=edit
Bug 22992: Ability to return to the list when you merge records of a list

Test plan:

Without the patch :
- Create 2 records
- Add them to the same list
- Go to the list and merge these two patrons
- In the nav bar you can't go back to the list

Apply the patch
- Now you should have a nav bar to return to the list
like that :https://snag.gy/cnWxa2.jpg
- Test every link of the nav bar, they should work
- Make all the merge process, and test the links on the 3 pages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Arthur Suzuki  changed:

   What|Removed |Added

  Attachment #88303|0   |1
is obsolete||

--- Comment #71 from Arthur Suzuki  ---
Created attachment 90147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90147=edit
Bug 11999: Remove the "biblio already reserved" check in CanItemBeReserved

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22992] When you merge records in a list there is no way to return to the list

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22992

axel Amghar  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19249] Date picker broken in "Quick add new patron" form

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|fridolin.som...@biblibre.co |koha-b...@lists.koha-commun
   |m   |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Arthur Suzuki  changed:

   What|Removed |Added

  Attachment #88302|0   |1
is obsolete||

--- Comment #70 from Arthur Suzuki  ---
Created attachment 90146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90146=edit
Bug 11999: Remove 'alreadyReserved' check in CanBookBeReserved

Since bug 14695 it is possible to reserve more than one item per biblio

Also fix bad use of $item

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Arthur Suzuki  changed:

   What|Removed |Added

  Attachment #90142|0   |1
is obsolete||

--- Comment #68 from Arthur Suzuki  ---
Created attachment 90143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90143=edit
Bug 11999: Add two checks in CanBookBeReserved and CanItemBeReserved

- Check if borrower already has reserved the same biblio (or item).
- Check if borrower has reached the maximum number of holds allowed
  (syspref maxreserves)

The goal of this patch is to do these checks also when using ILS-DI
services HoldTitle and HoldItem

Test plan:
--
Before patch:
1/ Set syspref maxreserves to 1
2/ Place some holds through ILS-DI and note that you can place more than
   1 hold for a borrower
3/ Try to hold the same biblio/item with the same borrower through
   ILS-DI and note that you can

Apply the patch
4/ Place some holds through ILS-DI, you shouldn't be able to place more
   than 1 hold for a borrower
5/ Try to hold the same biblio/item with the same borrower through
   ILS-DI. You shouldn't be able to do that.
6/ Try to place holds on staff interface and OPAC. The behaviour must be
   identical than before the patch.

Maxreserves and alreadyreserved works on ILSDI
Maxreserves works also on staff and opac
Already reserves works also on staff and opac
tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using
koha_ut db)

Signed-off-by: Alex Sassmannshausen 
Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Arthur Suzuki  changed:

   What|Removed |Added

  Attachment #88301|0   |1
is obsolete||

--- Comment #69 from Arthur Suzuki  ---
Created attachment 90144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90144=edit
Bug 11999: Check for age restriction in CanBookBeReserved

+ improve t/db_dependent/Reserves.t to make tests pass on UNIMARC
installation

Maxreserves and alreadyreserved works on ILSDI
Maxreserves works also on staff and opac
Already reserves works also on staff and opac
tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using
koha_ut db)

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Arthur Suzuki  changed:

   What|Removed |Added

  Attachment #88300|0   |1
is obsolete||

--- Comment #67 from Arthur Suzuki  ---
Created attachment 90142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90142=edit
Bug 11999: Add two checks in CanBookBeReserved and CanItemBeReserved

- Check if borrower already has reserved the same biblio (or item).
- Check if borrower has reached the maximum number of holds allowed
  (syspref maxreserves)

The goal of this patch is to do these checks also when using ILS-DI
services HoldTitle and HoldItem

Test plan:
--
Before patch:
1/ Set syspref maxreserves to 1
2/ Place some holds through ILS-DI and note that you can place more than
   1 hold for a borrower
3/ Try to hold the same biblio/item with the same borrower through
   ILS-DI and note that you can

Apply the patch
4/ Place some holds through ILS-DI, you shouldn't be able to place more
   than 1 hold for a borrower
5/ Try to hold the same biblio/item with the same borrower through
   ILS-DI. You shouldn't be able to do that.
6/ Try to place holds on staff interface and OPAC. The behaviour must be
   identical than before the patch.

Maxreserves and alreadyreserved works on ILSDI
Maxreserves works also on staff and opac
Already reserves works also on staff and opac
tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using
koha_ut db)

Signed-off-by: Alex Sassmannshausen 
Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22960] Typo found in circulation.pref in UpdateItemLocationOnCheckin preference

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960

--- Comment #8 from Katrin Fischer  ---
Thanks Josef!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22919] Authorities MARC Structure

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919

--- Comment #4 from Nabila  ---
(In reply to Katrin Fischer from comment #3)
> (In reply to Nabila from comment #2)
> > I created new instance with different port to run and see if there is any
> > error while installing Web Setup.
> > 
> > The following error was found while doing web setup under mandatory 
> > defaults:
> > 
> > authorities_normal_marc21.sql
> > 
> > [Tue May 28 09:52:16 2019] install.pl: DBD::mysql::st execute failed:
> > Incorrect integer value: '' for column 'linkid' at row 148 at
> > /usr/share/perl5/DBIx/RunSQL.pm line 273
> 
> Hi Nabila, thank you, this is very helpful. Did you pick English or another
> language? It might be related to your DBMS having a strict configuration:
> https://wiki.koha-community.org/wiki/DBMS_configuration
> 
> Updating severity - if this blocks installation, it's at least normal.

Selected Language is English.

Weird thing is, that I have till now 4 separate port running 4 separate Koha
setup. 1st one that I created is working properly for Authorities. Problem
started with the rest.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22932] GetLatestSerials should not return formatted date

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22932

Josef Moravec  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com
   |y.org   |
 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22932] GetLatestSerials should not return formatted date

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22932

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22932] GetLatestSerials should not return formatted date

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22932

Josef Moravec  changed:

   What|Removed |Added

  Attachment #90083|0   |1
is obsolete||

--- Comment #4 from Josef Moravec  ---
Created attachment 90141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90141=edit
Bug 22932: GetLatestSerials should not return formatted date

This patch updates GetLatestSerials in Serials.pm to remove date
formatting. Formatting of dates should be done in the template using
$KohaDates.

To test, apply the patch and locate a bibliographic record in the staff
client which has a subscription with issues.

 - On the bibliographic detail page for that record, view the
   "Subscriptions" tab. Dates in the table of recent issues should be
   formatted correctly.
 - View the details for the subscription in the Serials module. Create
   or edit a routing list for that serial. In the "Issue" dropdown the
   issue dates should be formatted correctly.
 - View the bibliographic detail page for the record in the OPAC. Open
   the "Subscriptions" tab. In the table of recent issues publication
   date and received date should be formatted correctly. The table
   should sort correctly on these dates.

Note: Although opac-ISBDdetail.pl calls GetLatestSerials, as far as I
can tell there is no serial-related output to update. The code appears
to be unused.

Signed-off-by: Maryse Simard 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22914] Add holds column to batch item delete to fix show/hide columns behaviour

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89869|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22914] Add holds column to batch item delete to fix show/hide columns behaviour

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914

--- Comment #19 from Katrin Fischer  ---
I decided to pass this after fixing up the bug title and commit message. Lucas,
please always include a description of the problem and the most current test
plan in your commit messages! Thx!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22960] Typo found in circulation.pref in UpdateItemLocationOnCheckin preference

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22914] Add holds column to batch item delete to fix show/hide columns behaviour

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914

--- Comment #18 from Katrin Fischer  ---
Created attachment 90139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90139=edit
Bug 22914: Add holds column to batch item delete to fix show/hide columns
behaviour

The changes on 19490 caused a bug, where the show/hide column feature hides the
wrong column on the items table. The two templates share a js file, and
the data passed is the same.

Adding the column to the template brings things back into alignment,
the data is already there, we just show it.

TEST PLAN:
1. Go to Tools > Batch item deletion and enter at least one barcode.
2. Try to hide a column that is showing
3. Notice it hides the wrong column
4. apply patch
5. repeat steps 1 and 2.
6. Notice the correct column is being hidden
7. Verify the new column for number of holds on the item works correctly
   for item and record level holds

Signed-off-by: Lisette Scheer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22914] Add holds column to batch item delete to fix show/hide columns behaviour

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914

Katrin Fischer  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22960] Typo found in circulation.pref in UpdateItemLocationOnCheckin preference

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960

Josef Moravec  changed:

   What|Removed |Added

  Attachment #90122|0   |1
is obsolete||

--- Comment #7 from Josef Moravec  ---
Created attachment 90140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90140=edit
Bug 22960: Fix the same typo on db level for existing and new installations

Seriously trying to kill the typo everywhere:
- Check your DB with a report:
  select * from systempreferences where variable =
'UpdateItemLocationOnCheckin';
- Verify the typo in the explanation column: locaiton
- Apply patch and run database update
- Verify the typo is fixed

Signed-off-by: Katrin Fischer 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22960] Typo found in circulation.pref in UpdateItemLocationOnCheckin preference

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960

Josef Moravec  changed:

   What|Removed |Added

  Attachment #90121|0   |1
is obsolete||

--- Comment #6 from Josef Moravec  ---
Created attachment 90138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90138=edit
Bug 22960: Typo found in circulation.pref in UpdateItemLocationOnCheckin
preference

This patch corrects a typo in circulation.pref in the description of the
UpdateItemLocationOnCheckin preference.

To see the problem, go to Administration -> System preferences ->
Circulation and look at the description for the
UpdateItemLocationOnCheckin preference:

"The special term _BLANK_ may be used on either side of a value pair to
update or remove the location from items with no locaiton assigned."

Note the misspelling "locaiton."

To test, apply the patch and refresh the circulation preferences page.
The typo should be fixed.

Signed-off-by: Bin Wen 

Signed-off-by: Katrin Fischer 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22914] Add holds column to batch item delete to fix show/hide columns behaviour

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914

Katrin Fischer  changed:

   What|Removed |Added

Summary|Batch Item Delete column|Add holds column to batch
   |misconfigured when using|item delete to fix
   |show/hide tool  |show/hide columns behaviour

--- Comment #17 from Katrin Fischer  ---
Hm, seeing the discussion now. I still feel this puts us in a little bit of a
hard place release notes wise :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22914] Batch Item Delete column misconfigured when using show/hide tool

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #16 from Katrin Fischer  ---
This is a hard one, because I really want to pass it, but I feel it's not quite
right yet. :(

As this is a bug report for a specific problem that also appears in 18.11, it
is suited for backporting. But as it adds a new column, this is also an
enhancement (with translation changes too), so it would not be backported.
Also: because this only advertises the bug fix, we would not alert the
libraries about the new feature in the release notes.

Lucas, would you be willing to please split this into 2 separate bugs? One for
the fix and one for the new feature? The heavy reindentation also makes it hard
to read, having that in a first patch and the actual fix in a second patch
would also make my life easier!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >