[Koha-bugs] [Bug 22457] OpacHiddenItemsExceptions should be moved to a category attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22457 --- Comment #4 from M. Tompsett --- This is a global override, this is not the branch-based override as envisioned in bug 10589. So, perhaps both overrides, outright and partial based on matching item homebranch and patron branch, should be fields in the patron category table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Hayley Mapley changed: What|Removed |Added Attachment #90391|0 |1 is obsolete|| --- Comment #88 from Hayley Mapley --- Created attachment 90472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90472=edit Bug 12446: (follow-up) Show all guarantees on the guarantor detail page Only one guarantee is shown on the guarantor detail page. The guarantees list should be passed to the template as a ref. Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Hayley Mapley changed: What|Removed |Added Attachment #90392|0 |1 is obsolete|| --- Comment #89 from Hayley Mapley --- Created attachment 90473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90473=edit Bug 12446: (QA follow-up) QA tests fixing, cleaning code This patch does 3 things : - Remove old code in C4/Utils/DataTables/Members.pm. - Fix the AdditionalGuarantorField dead link for the borrowers table schema. - Remove unused variables so QA tests pass. Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Hayley Mapley changed: What|Removed |Added Attachment #90389|0 |1 is obsolete|| --- Comment #86 from Hayley Mapley --- Created attachment 90470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90470=edit Bug 12446: Enable an adult to have a guarantor Concflicts has been fixed. Also attributes in system preference : AdditionalGuarantorField are now displayed correctly in all scenerios. I have rebased every patch. This includes all the features from the previous patches. Removed the dollar signs and stopped using C4::Category On the patron category page, there is a new field to specify whether patrons can be guarantee or not. The atomic update SQL script adds this new field and sets it to true for categories of type "C" and "P". 1) Apply the patch 2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. 3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional mostly to set it by default) 4) See below to test various scenarios - Enable an adult to have a guarantor: 0.0) Create or edit a patron category of type 'A'. 0.1) Set the "Can be guarantee" field to "Yes" and save. 1) Select an adult patron -> details tab; 2) Click edit button; 3) validate "guarantor information" fieldset; - Shows guarantees' fines in the guarantor's page: 4) Click Set to patron button and select a guarantor; 5) Generate a fine; 6) Select guarantor patron -> details tab; 7) Validate guarantee's fine information. - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while creating a new patron 0) Select an adult patron; 1) Insert all information; 2) Add a new adult patron; 3) Click "Set to patron" button; 4) Select the adult patron from 0); 5) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 2) Select an adult patron; 3) Insert all information; 4) Add a new adult patron; 5) Click "Set to patron" button; 6) Select the adult patron from 0); 7) Validade Garantor information/Main address/Contact fieldsets filled; 8) Validade Garantor additional alternate address/contact filled; - Transfer guarantor's alternate address/contact to the guarantee while adding a guarantiee: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 3) Select an adult patron; 4) Insert all information; 5) Click Add guarantiee bouton; 6) Validade Garantor information/Main address/Contact fieldsets filled; 7) Validade Garantor additional alternate address/contact filled; Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Hayley Mapley changed: What|Removed |Added Attachment #90390|0 |1 is obsolete|| --- Comment #87 from Hayley Mapley --- Created attachment 90471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90471=edit Bug 12446: (QA follow-up) Cleaning, and fixing, old code carried accidentally Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Hayley Mapley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #138 from Agustín Moyano --- Created attachment 90469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90469=edit Bug 22284: (follow-up) Fix typo in request.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23078] Use Koha.Preference in OPAC global header include
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 --- Comment #4 from M. Tompsett --- (In reply to M. Tompsett from comment #3) > Because extra lines got left behind. 18 [% IF ( bidi ) %] 19 [% ELSE %] 20 [% END %] Those ones. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23078] Use Koha.Preference in OPAC global header include
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com Status|Needs Signoff |Failed QA --- Comment #3 from M. Tompsett --- Because extra lines got left behind. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23078] Use Koha.Preference in OPAC global header include
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078
--- Comment #2 from M. Tompsett ---
Comment on attachment 90460
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90460
Bug 23078: Use Koha.Preference in OPAC global header include
Review of attachment 90460:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=23078=90460)
-
Fix the lines that should be removed, and I'll sign off. :)
::: koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc
@@ +9,4 @@
> [% IF ( bidi ) %]
> [% Asset.css("lib/bootstrap/css/bootstrap-rtl.min.css") | $raw %]
> +[% Asset.css("lib/jquery/jquery-ui-rtl.css") | $raw %]
> +[% Asset.css("css/right-to-left.css") | $raw %]
Nice clean up moves.
@@ +20,1 @@
> [% END %]
You probably could have deleted these three lines.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12537] editions tab showing on bibs with more than one ISBN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12537 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12537] editions tab showing on bibs with more than one ISBN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12537 M. Tompsett changed: What|Removed |Added Attachment #90464|0 |1 is obsolete|| --- Comment #4 from M. Tompsett --- Created attachment 90468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90468=edit Bug 12537: Don't retrieve XISBN results for the same biblionumber For a biblio with multiple ISBNS we sometimes get our own record back when check XISBN, we should test for this To test: 1 - Edit a record in the catalogue, add two isbns: 0521240670 0521284198 2 - Enable ThingISBN and FRBRizeEditions and OPACFRBRizeEditions 3 - View the record in staff and OPAC 4 - You should see editions tab pointing to the same record 5 - Apply patch 6 - Reload the record details, you should no longer see editions tab 7 - Add the second ISBN to another record 8 - Reload details for original record, you shoudl see editions linking to the record with second ISBN 9 - prove -v t/db_dependent/XISBN.t NOTE: Current tests don't work under elasticsearch, but the code does, tests should be rewritten on another bug Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #49 from M. Tompsett --- Doh! That doesn't quite work, because homebranch is on item. So, you want to pass patron to hidden_in_opac on items... Okay... Hmm... thinking -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589
--- Comment #48 from M. Tompsett ---
(In reply to Tomás Cohen Arazi from comment #47)
> Please take a look at bug 22454 and bug 22455. The rationale is that if you
> have the biblio object, you can know all that is needed regarding hiding in
> OPAC without fetching MARC data or complex calculations. And if we were to
> add parameters like category and library, I would rather pass the
> Koha::Patron object altogether.
> This check, with bug 22457 in mind could be written:
>
> my $should_hide = ( $patron->category->overrides_opac_hidding_policy or
> $patron->library->overrides_opac_hidding_policy )
> ? 0
> : 1;
>
> while ( my $biblio = $biblios->next ) {
> next if $biblio->hidden_in_opac and $should_hide;
> do_your_things();
> }
>
> This check should be written on the controller script.
Doesn't quite work.
The idea is:
if (! defined $patron) {
$globally_override = 0;
} elsif (! defined $patron->category) {
$globally_override = 0;
} else {
$globally_override = $patron->category->globally_overrides_opac_hiding;
}
while ( my $biblio = $bilbios->next ) {
if (! defined $patron) {
$locally_override = 0;
} else {
$locally_override = ($patron->branchcode ne $biblio->homebranch)
? 0
: $patron->category->overrides_opac_hiding_policy_locally;
}
$should_show = $globally_override || $locally_override;
$should_hide = ! $should_show;
next if $biblio->hidden_in_opac && $should_hide;
do_your_things();
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 Nadine Pierre changed: What|Removed |Added CC||nadine.pie...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23045] Advanced cataloging editor (rancor) throws a JS error when lines deleted by macros
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045 --- Comment #5 from Liz Rea --- Created attachment 90467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90467=edit Bug 23045: Return record along with errors We don't seem to directly handle the errors in most cases, let's always return the record To test: 1 - Add some blank lines to editor, previous patch is okay with this 2 - Add a line with just 'e' or some other incomplete field 3 - Try to save 4 - Note JS leader error 5 - Apply this patch 6 - No errors Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23045] Advanced cataloging editor (rancor) throws a JS error when lines deleted by macros
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23045] Advanced cataloging editor (rancor) throws a JS error when lines deleted by macros
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045 Liz Rea changed: What|Removed |Added Attachment #90405|0 |1 is obsolete|| Attachment #90411|0 |1 is obsolete|| --- Comment #4 from Liz Rea --- Created attachment 90466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90466=edit Bug 23045: TextMarc errors on blank lines Since bug 16251 we use TextMarc to get some record fields, however, it throws an error when processing blank lines. We should just pass on these rather then erroring To test: 1 - Define a new macro that delete more fields than it adds delete 245 2 - Run it 3 - Note an error in JS console, and helpers will not load 4 - Apply patch 5 - Reload, try again 6 - No error Signed-off-by: Claire Gravely Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22953] Markup warning in OPAC user summary template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22953 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #6 from Lucas Gass --- backported to 18.11.x for 18.11.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1887] Managing Suggestions - hold books for patron who requested
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1887 --- Comment #5 from Barbara Johnson --- That should have been bug #19358 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23065] 'New subscription' button in serials sometimes uses a blank form and sometimes defaults to current serial
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23065 Michal Denar changed: What|Removed |Added Attachment #90439|0 |1 is obsolete|| --- Comment #2 from Michal Denar --- Created attachment 90465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90465=edit Bug 23065: Rename "New subscription" button when default to current serial To make it explicite that the "New subscription" button will create a subscription based on the current serial it is now labeled "New subscription for this serial" Test plan: 1 - Go to Serials module in Koha 2 - Click 'New subscription' 3 - You get a blank form 4 - Fill it out, save it 5 - You are viewing the subscription you created => The button is now labeled "New subscription for this serial" Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23065] 'New subscription' button in serials sometimes uses a blank form and sometimes defaults to current serial
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23065 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22249] Error when submitting Mana comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com --- Comment #5 from Michal Denar --- Hi Alex, any test plan? Thank You. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15051] 245 Marc Field Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15051 Nick Clemens changed: What|Removed |Added Status|In Discussion |RESOLVED CC||n...@bywatersolutions.com Resolution|--- |FIXED --- Comment #8 from Nick Clemens --- In testing the fields appear in the order they are cataloged,we can adjust the order in both editors, closing this one now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16640] Move actions on acquisitions receipt summary page into menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16640 Nick Clemens changed: What|Removed |Added Status|In Discussion |ASSIGNED CC||n...@bywatersolutions.com --- Comment #7 from Nick Clemens --- Agreeing with both Katrin and Jonathan here - moving to Assigned for future work -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12537] editions tab showing on bibs with more than one ISBN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12537 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com, ||oleon...@myacpl.org Assignee|oleon...@myacpl.org |n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12537] editions tab showing on bibs with more than one ISBN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12537 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12537] editions tab showing on bibs with more than one ISBN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12537 --- Comment #3 from Nick Clemens --- Created attachment 90464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90464=edit Bug 12537: Don't retrieve XISBN results for the same biblionumber For a biblio with multiple ISBNS we sometimes get our own record back when check XISBN, we should test for this To test: 1 - Edit a record in the catalogue, add two isbns: 0521240670 0521284198 2 - Enable ThingISBN and FRBRizeEditions and OPACFRBRizeEditions 3 - View the record in staff and OPAC 4 - You should see editions tab pointing to the same record 5 - Apply patch 6 - Reload the record details, you should no longer see editions tab 7 - Add the second ISBN to another record 8 - Reload details for original record, you shoudl see editions linking to the record with second ISBN 9 - prove -v t/db_dependent/XISBN.t NOTE: Current tests don't work under elasticsearch, but the code does, tests should be rewritten on another bug -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23090] MySQL validate_password plugin breaks koha-create
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23090 --- Comment #2 from M. Tompsett --- TEST PLAN - $ sudo mysql -u root > CREATE USER 'bug23090_test1'@'localhost' IDENTIFIED BY 'badpassword'; [Magical MySQL Error] > CREATE USER 'bug23090_test1'@'localhost' IDENTIFIED BY 'GoodP@ssw0rd'; [Should be okay] > DROP USER 'bug23090_test1'@'localhost'; > QUIT $ sudo koha-create --create-db fail23090 [Magical MySQL Error] [Apply this patch and put it (debian/scripts/koha-create) into place in /usr/sbin/koha-create] $ sudo koha-create --create-db pass23090 Clean up of useless instances is left as an exercise to the reader. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23090] MySQL validate_password plugin breaks koha-create
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23090 M. Tompsett changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23090] MySQL validate_password plugin breaks koha-create
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23090 --- Comment #1 from M. Tompsett --- Created attachment 90463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90463=edit Bug 23090: Add some special characters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set when creating a child patron from the adult
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660 Donna changed: What|Removed |Added CC||bwsdo...@gmail.com --- Comment #3 from Donna --- Confirming Comment 1 - this is still an issue, and is causing confusion for staff as they have to look up what the defaults should be for the different categories of patrons that are being added to the parent card. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16750] Redirect from selectbranchprinter.pl to additem.pl causes software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16750 Nick Clemens changed: What|Removed |Added Status|In Discussion |Signed Off CC||n...@bywatersolutions.com --- Comment #16 from Nick Clemens --- Three years later, still a valid bug. In testing Kyle's patch solves the issue - Jonathan's leads to 404 I think we should open new bug for the more general fix and deal with those issues there and fix up at least this known error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16750] Redirect from selectbranchprinter.pl to additem.pl causes software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16750 Nick Clemens changed: What|Removed |Added Attachment #52462|0 |1 is obsolete|| --- Comment #15 from Nick Clemens --- Created attachment 90462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90462=edit Bug 16750 - Redirect from selectbranchprinter.pl to additem.pl causes software error How to reproduce: 1) Edit and save an item in the items editor 2) You should be redirected back to the items editor, note that the biblionumber is not passed in the url 3) Choose "set library" from the upper right hand pulldown on the page 4) Choose a different library, click submit 5) You should get the error message: Software error: Can't call method "fields" on an undefined value at /home/vagrant/kohaclone/cataloguing/additem.pl line 736. Test Plan: 1) Apply this patch 2) Follow plan above 3) No software error should occur at step 5 Signed-off-by: Marc Véron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23062] List of checked-in items disappared if there is transfer warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23062 Nick Clemens changed: What|Removed |Added Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED CC||n...@bywatersolutions.com --- Comment #2 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 22896 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22896] Item to be transferred at checkin clears overridden due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 Nick Clemens changed: What|Removed |Added CC||blac...@gmail.com --- Comment #13 from Nick Clemens --- *** Bug 23062 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Andrew changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 Andrew changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23091 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Andrew changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22877 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23091] New: Restore Forgiven Overdue Fines When Lost Item Returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Bug ID: 23091 Summary: Restore Forgiven Overdue Fines When Lost Item Returned Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- Bug 22877 is closing a loophole that several libraries have been happily using to achieve their desired fine behavior. These libraries want this behavior: - item accrues overdue fine up to maximum - when item is lost, overdue fine is forgiven and lost fee is applied - when item is returned, lost fee is forgiven and overdue fine is restored So, while many libraries will see bug 22877 as a fix, for some libraries it will be a very big disruption. My understanding of bug 22877 is that we're changing the fine calculation at checkin to not do anything with fines if the item is lost. Maybe we need to instead say don't add fines if the item is lost and the there is an existing fine for that issue where amountoutstanding!=0? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 --- Comment #37 from Andrew --- *** Bug 22727 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22727] Forgiven fines are recreated when lost item that was not marked returned is returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22727 Andrew changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Andrew --- *** This bug has been marked as a duplicate of bug 22877 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22851] Style navigation links in serials modules like same links in other modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22851 --- Comment #2 from Katrin Fischer --- Thx Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
--- Comment #9 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #8)
> Comment on attachment 90388 [details] [review]
> Bug 23057: Update do_checkin
>
> Review of attachment 90388 [details] [review]:
> -
>
> ::: C4/Circulation.pm
> @@ +1945,4 @@
> > }
> >
> > if ( $item->itemlost and
> > C4::Context->preference("BlockReturnOfLostItems") ) {
> > +$messages->{'ReturnOfLostItemBlocked'};
>
> Should we handle it from returns.pl as well?
It would make sense. I find it odd that that is the *only* doreturn block
without a message.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22851] Style navigation links in serials modules like same links in other modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22851 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22851] Style navigation links in serials modules like same links in other modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22851 --- Comment #1 from Owen Leonard --- Created attachment 90461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90461=edit Bug 22851: Style navigation links in serials modules like same links in other modules This patch makes minor markup changes to the serials sidebar menu include so that links are displayed in a style consistent with similar menus in other areas of the staff client. This patch contains whitespace changes, so please use the "-w" flag when viewing the diff. To test, apply the patch and go to the Serials module. The links in the sidebar menu should be displayed in the same style as the corresponding menu on the Acquisitions home page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22851] Style navigation links in serials modules like same links in other modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22851 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22986] Tag cloud displays same tag multiple times
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22986 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23002] OPAC doesn't retain search filters in results pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23002 Owen Leonard changed: What|Removed |Added Summary|OPAC doesn't hold search|OPAC doesn't retain search |filters in results pages|filters in results pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9699] Allow patrons to see notices sent to them in their OPAC account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9699 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23078] Use Koha.Preference in OPAC global header include
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23078] Use Koha.Preference in OPAC global header include
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 --- Comment #1 from Owen Leonard --- Created attachment 90460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90460=edit Bug 23078: Use Koha.Preference in OPAC global header include This patch updates the OPAC's doc-head-close.inc so that it uses 'Koha.Preference' syntax to output system preference data. The patch removes handling of two preferences from Auth.pm which which are covered by this template change. This patch also makes some minor changes to consolidate multiple template checks for "bidi" To test, apply the patch and test the affected OPAC system preferences: - OpacFavicon - opaclayoutstylesheet - OPACUserCSS - OPACBaseURL Confirm that changes made to these preferences are reflected in the OPAC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23090] MySQL validate_password plugin breaks koha-create
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23090 M. Tompsett changed: What|Removed |Added Priority|P5 - low|P1 - high Patch complexity|--- |Trivial patch Assignee|koha-b...@lists.koha-commun |mtomp...@hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23090] New: MySQL validate_password plugin breaks koha-create
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23090 Bug ID: 23090 Summary: MySQL validate_password plugin breaks koha-create Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs@lists.koha-community.org Reporter: mtomp...@hotmail.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- When attempting to run a simple: sudo koha-create --create-db NewInstance The password generated lacks special characters which causes newer versions of MySQL (5.7.26 on Bionic) to fail. This can be fixed either by lowering the: set GLOBAL validate_password_policy='LOW'; -- or Adding '-s -y' to all the pwgen calls in the koha-create script. The later is more secure, and thus will be the patch here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079
--- Comment #4 from Jonathan Druart
---
(In reply to Katrin Fischer from comment #3)
> (In reply to Jonathan Druart from comment #1)
> Can you explain the issue a bit?
On Nov 3rd 2019, Brazil will skip from 00:00 to 1:00
(http://www.currenttimeonline.com/dst/dst.do?tz=America/Sao_Paulo), DateTime
consider it as an invalid date.
It is a problem when we are playing with dates without the time part (always
00:00).
When we instantiate a DateTime (from dt_from_string) we are already handling
this issue, and use the floating timezone (since bug 12669).
The problem remains when we generate a DateTime then add or subtract a
duration, which will result in an invalid date:
DateTime->new(year => 2019, month => 12, day => 3, time_zone =>
'America/Sao_Paulo')->subtract(days => 30);
=> Nov 3rd 2019, kaboom.
I think we should replace all the occurrences of dt_from_string->subtract (or
->add) with dt_from_string(undef, undef, 'floating'), to use the floating
timezone and avoid the error.
Technical note: we must update the prototype of dt_from_string before, to send
a hashref instead: dt_from_string({ timezone => 'floating'});
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
CC||tomasco...@gmail.com
--- Comment #28 from Tomás Cohen Arazi ---
I have a few remarks:
- The method you are adding to Koha::Patron (->suggestions) needs tests, and it
should be actually relying on a relationship, and thus using _new_from_dbic so
it is prefetchable. This has been discussed recently so you couldn't know
beforehand.
- There's now a clear distinction between endpoints that target unprivileged
users (OPAC) and administrative ones (e.g. staff interface). If this bug only
targets the 'privileged' one, maybe make it explicit and make sure the
permissions are correct.
- The attribute names seem to come straight from the DB structure. This should
be fixed. Look at the RFCs page [1] and please follow naming conventions
discussed and voted there. For example, borrowernumber is not used on the API,
use patron_id instead.
- POD is missing on the controller
- Take a look at Koha::REST::V1::Cities and how it uses ->objects_search. It
will automagically add pagination to the list method, which is desierd on busy
sites (i.e. make the list manageable).
- objects_search requires you to pass the _to_api and _to_model methods you
will need to write to comply with the currently voted RFCs regarding
terminology.
- If you want the end user (session) to create purchase suggestions, then you
need an endpoint in /public. And if you need to list them on the patron's page,
maybe worth generating /public/patron/{patron_id}/purchase_suggestions (this is
very arguable, just a thought).
[1] https://wiki.koha-community.org/wiki/REST_api_RFCs
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22210] Allow organisations to sign up to Mana KB (don't only ask for firstname lastname)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 --- Comment #14 from Alex Arnaud --- Pull request: https://gitlab.com/koha-community/koha-mana/merge_requests/3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23087] Update DB system for Mana
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23087 --- Comment #2 from Alex Arnaud --- Pull request: https://gitlab.com/koha-community/koha-mana/merge_requests/2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22913] https://mana-kb.koha-community.org/ should not return a 404 error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913 --- Comment #7 from Alex Arnaud --- [Update] merge request is here: https://gitlab.com/koha-community/koha-mana/merge_requests/1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Jonathan Druart changed: What|Removed |Added Attachment #90440|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart --- Created attachment 90459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90459=edit Bug 23075: Better error handling in Mana config Currently, if you input an incorrect mana service URL in your config (http rather than https for example) the error message you are given is the direct output of a failed json parse. We should be able to catch such failures and display a more meaningful error to the end user. This patch makes it display a more friendly message. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22983] The Koha copy of NotoSans font (in the new OPAC) lacks glyphs for (some) Roman letters with diacritics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22983 --- Comment #9 from Janusz Kaczmarek --- (In reply to Jonathan Druart from comment #8) > Should we follow: > > https://google-webfonts-helper.herokuapp.com/fonts/noto-sans?subsets=latin, > greek-ext,devanagari,cyrillic,latin-ext,vietnamese,greek,cyrillic-ext > > Download and include them all? Entire WOFF2 set (Regular, Italic, Bold, BoldItalic) = 546 KB Entire WOFF set = 714 KB Now it is eight times less (71 KB, 89 KB, respectively). If it is OK (the browser would keep it normally in cache, wouldn't it? -- if so, then it would be downloaded only once, in general) -- let's do it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22954] Minor markup error in OPAC messaging template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22954 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Pushed to Master|Pushed to Stable Version(s)|19.11.00|19.11.00,19.05.01 released in|| --- Comment #6 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22952] Markup error in OPAC suggestions template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22952 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Version(s)|19.11.00|19.11.00,19.05.01 released in|| Status|Pushed to Master|Pushed to Stable --- Comment #9 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #7 from Alex Arnaud --- My explanation was not very clear, i admit :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #6 from Jonathan Druart --- Ha! my bad, got it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #5 from Jonathan Druart --- Are you sure Alex? This patch did not remove the line you are referring to, it moved it above. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22948] Markup error in OPAC bibliographic detail template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Pushed to Master|Pushed to Stable Version(s)|19.11.00|19.11.00,19.05.01 released in|| --- Comment #7 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22964] Remove the word "product" from the bugzilla bug report page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22964 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #2 from Nick Clemens --- If I recall this came from a discussionat Koha con to make it easier for users/newbies to file a bug maybe just a link on the mainpage to "File a Koha Bug" directly and avoid this choice screen all together? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22960] Typo found in circulation.pref in UpdateItemLocationOnCheckin preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Version(s)|19.11.00|19.11.00,19.05.01 released in|| Status|Pushed to Master|Pushed to Stable --- Comment #12 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22585] Fix remaining double-escaped CAS links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22585 Jonathan Druart changed: What|Removed |Added Summary|CAS login link for staff|Fix remaining |intranet is double-escaped |double-escaped CAS links Depends on||21973 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21973 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21973 [Bug 21973] CAS URL escaped twice, preventing login -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21973] CAS URL escaped twice, preventing login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21973 Jonathan Druart changed: What|Removed |Added Blocks||22585 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22585 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22585 [Bug 22585] Fix remaining double-escaped CAS links -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20114] Build better $query_cgi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20114 Nick Clemens changed: What|Removed |Added Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED --- Comment #9 from Nick Clemens --- I think David has some points, we could do more here in the future. As he has abandoned this code and 22413 seems to fix the issues caused by this bug I think we can close *** This bug has been marked as a duplicate of bug 22413 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22413] Elasticsearch - Search settings are lost after sorting, faceting or paging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 Nick Clemens changed: What|Removed |Added CC||glask...@gmail.com --- Comment #15 from Nick Clemens --- *** Bug 20114 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14794] Searching patron by birthday returns no results if format incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14794 --- Comment #12 from Jonathan Druart --- About the JS check, I actually thought we add a JS function to check the date formatting, and so it would have been easy to reuse it here. But we don't. We have a CheckDate function (in members.js) to make sure it matches DD/MM/. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23006] Can't use inventory tool with barcodes that contain regex relevant characters ($, ...)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23006 Fridolin SOMERS changed: What|Removed |Added Version(s)|19.11.00|19.11.00,19.05.01 released in|| Status|Pushed to Master|Pushed to Stable CC||fridolin.som...@biblibre.co ||m --- Comment #12 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075
Alex Arnaud changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #4 from Alex Arnaud ---
This makes we lost the response code ($result->{code} = $response->code;)
We need it in some place to test the response.
I.e: report search is broken
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22585] CAS login link for staff intranet is double-escaped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22585 --- Comment #7 from Nick Clemens --- (In reply to Jonathan Druart from comment #6) > This patch is for OPAC and so more a follow-up for bug 21973. But I am not > sure it would make sense to open a third report for it. Maybe just retitle this one as "Fix remaning CAS links"? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22585] CAS login link for staff intranet is double-escaped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22585 --- Comment #6 from Jonathan Druart --- This patch is for OPAC and so more a follow-up for bug 21973. But I am not sure it would make sense to open a third report for it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Fridolin SOMERS changed: What|Removed |Added Version(s)|19.11.00|19.11.00,19.05.01 released in|| Status|Pushed to Master|Pushed to Stable CC||fridolin.som...@biblibre.co ||m --- Comment #25 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11492] Receiving a serial item causes routing list notes to be lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11492 Fridolin SOMERS changed: What|Removed |Added Version(s)|19.11.00|19.11.00,19.05.01 released in|| Status|Pushed to Master|Pushed to Stable CC||fridolin.som...@biblibre.co ||m --- Comment #15 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Stock rotation: need transfer reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 Martin Renvoize changed: What|Removed |Added Blocks||22569 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 [Bug 22569] Stock rotation: need transfer reports -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11897] Stock Rotation for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What|Removed |Added Blocks|22569 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 [Bug 22569] Stock rotation: need transfer reports -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Stock rotation: need transfer reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Depends on|11897 |22566 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 [Bug 11897] Stock Rotation for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 [Bug 22566] Stock rotation cronjob reporting has issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Stock rotation: need transfer reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #2 from Martin Renvoize --- Created attachment 90458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90458=edit Bug 22569: Proof of concept This patch adds a proof of concept 'Transfers to send' report to the circulation page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Alex Arnaud changed: What|Removed |Added CC||alex.arn...@biblibre.com --- Comment #3 from Alex Arnaud --- (In reply to David Nind from comment #2) > I wanted to test this, but couldn't figure it out! Any hints or direction > would be appreciated. > > Is this talking about etc/koha-config.xml and the URL in there? For testing > is this the URL to configure in koha-config.xml? > https://mana-test.koha-community.org/ > > Or is it once you have it enabled and working, that is you have enabled and > added a token? David, just enter a non valid URL in mana_config and try to register via cgi-bin/koha/admin/share_content.pl (request a mana token). > > Up-to-date on master. > > I haven't been to get registration to work either, I get these two error > messages when on /cgi-bin/koha/admin/share_content.pl: > > - An error occurred, mana server returned: URL must be absolute > > - Mana configuration is currently empty. This feature will not work. Please > contact your site administrator. As said, mana_config is empty. enter the following in your koha-conf.xml: https://mana-test.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22099] "List requests" button displays when listing requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Version(s)|19.11.00|19.11.00,19.05.01 released in|| Status|Pushed to Master|Pushed to Stable --- Comment #7 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22955] Markup error in OPAC lists template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22955 Fridolin SOMERS changed: What|Removed |Added Version(s)|19.11.00|19.11.00,19.05.01 released in|| CC||fridolin.som...@biblibre.co ||m Status|Pushed to Master|Pushed to Stable --- Comment #5 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22947] Markup error in OPAC preferences file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22947 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||fridolin.som...@biblibre.co ||m Version(s)|19.11.00|19.11.00,19.05.01 released in|| --- Comment #5 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22950] Markup error in OPAC recent comment template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22950 Fridolin SOMERS changed: What|Removed |Added Version(s)|19.11.00|19.11.00,19.05.01 released in|| Status|Pushed to Master|Pushed to Stable CC||fridolin.som...@biblibre.co ||m --- Comment #5 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22906] Minor corrections to plugins home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22906 Fridolin SOMERS changed: What|Removed |Added Version(s)|19.11.00|19.11.00,19.05.01 released in|| Status|Pushed to Master|Pushed to Stable CC||fridolin.som...@biblibre.co ||m --- Comment #6 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23083] Course reserve item edit fails if one does not set all values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23083 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|RESOLVED|REOPENED Resolution|DUPLICATE |--- --- Comment #5 from Katrin Fischer --- (In reply to Jonathan Druart from comment #4) > Instead I think the patch should be moved here, bug 22630 is an enhancement > and will not be backported. I agree, not a real duplicate in this case, deduplicating, changing to a see also. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11642] Batch patron deletion/anonymization should not allow permanent destruction of patron data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11642 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11642] Batch patron deletion/anonymization should not allow permanent destruction of patron data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11642 --- Comment #9 from Owen Leonard --- Created attachment 90457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90457=edit Bug 11642: (follow-up) Batch patron deletion/anonymization should not allow permanent destruction of patron data This patch makes some template changes to try to make this interface more consistent with other areas of Koha and to make warnings more clear. I have also changed the phrase "deletion/anonymization" to "deletion and anonymization." To test, apply the patch and test the patron deletion and anonymization process and confirm that the interface is clear and works well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14794] Searching patron by birthday returns no results if format incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14794 --- Comment #11 from Nick Clemens --- (In reply to Jonathan Druart from comment #8) > Hi Nick, I do not understand what you are trying to fix. > > Do not we want to add a JS check to make sure the date is valid? > > Moreover if you want the tooltip to be displayed when the input has the > focus, maybe you should bind the on focus event? It is not so much a 'fix' but hopefully provides feedback to the user on what they must do there. I am not changing behvaiour, just trying to make current behaviour more clear. I think making that field a date entry/calendar would probably be helpful, but I think that can be a separate enhancement. The tooltip shows when the dropdown is changed, or on focus, so I think doing it on change makes sense - you select dateofbirth, you see what you must enter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22210] Allow organisations to sign up to Mana KB (don't only ask for firstname lastname)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 --- Comment #13 from Alex Arnaud --- Mana pull request: https://git.biblibre.com/biblibre/koha-mana/pulls/3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22913] https://mana-kb.koha-community.org/ should not return a 404 error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913 --- Comment #6 from Alex Arnaud --- Martin, Katrin, https://mana-* is an API and, IMO, is intended to return machine readable format only. This could be useful if we want koha to be able to check if the url is a valid mana instance. May be what you are expecting could be done on the user interface part: https://ui.mana-* -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22585] CAS login link for staff intranet is double-escaped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22585 --- Comment #5 from Nick Clemens --- Created attachment 90456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90456=edit Bug 22585: (follow-up) Fix additional occurences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23087] Update DB system for Mana
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23087 Alex Arnaud changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #1 from Alex Arnaud --- Pull request: https://git.biblibre.com/biblibre/koha-mana/pulls/2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
