[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819
--- Comment #81 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #80)
> Why do we have the following line:
>
> opac/opac-memberentry.pl:push @fields, 'gdpr_proc_consent' if
> C4::Context->preference('GDPR_Policy');
>
> It causes bug 23150.
See bug 23150. No bug, but design.
The field should be handled as mandatory. If you do not want to give consent,
you cannot register an account.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23150] GDPR breaks patron self modification on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #4 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #2) > Not sure about this fix, I'd like Marcel review :) At least for mode Enforced, we should treat it as mandatory. But I think for Permissive it should better be handled as mandatory too. But that is more arbitrary. This change actually breaks GDPR ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23150] GDPR breaks patron self modification on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 --- Comment #3 from Marcel de Rooy --- (In reply to Andrew from comment #0) > - Request is refused with message "You have not filled out all required > fields. Please fill in all missing fields and resubmit." I am not sure if I understand. You only need to tick the GDPR consent field, and you can save the record? Note that if you do not agree with the GDPR policy, we do not want you to proceed and create an account. So the title GDPR breaks self registration, is completely unclear to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16488] UNIMARC to MARC21 xslt to be used in z39.50 import sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16488 Wangthoi changed: What|Removed |Added CC||orangewangt...@gmail.com --- Comment #15 from Wangthoi --- Someone please help me I am well verse with computer coding and all. My data are not lost but i am unable to check in books. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #192 from Aleisha Amohia --- Created attachment 90844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90844&action=edit Bug 15516: Fixing missing curly bracket -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What|Removed |Added Attachment #90303|0 |1 is obsolete|| --- Comment #191 from Aleisha Amohia --- Created attachment 90843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90843&action=edit Bug 15516: (follow-up) Fixing atomic update to prevent errors This patch prevents errors when applying atomic update, particularly for those that have already tested this feature before. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What|Removed |Added Attachment #90298|0 |1 is obsolete|| --- Comment #186 from Aleisha Amohia --- Created attachment 90838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90838&action=edit Bug 15516: (follow-up) Fix pod in C4::Reserves Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What|Removed |Added Attachment #90299|0 |1 is obsolete|| --- Comment #187 from Aleisha Amohia --- Created attachment 90839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90839&action=edit Bug 15516: (follow-up) Fix template filters Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What|Removed |Added Attachment #90297|0 |1 is obsolete|| --- Comment #185 from Aleisha Amohia --- Created attachment 90837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90837&action=edit Bug 15516: (follow-up) Fix modal for hold group Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What|Removed |Added Attachment #90302|0 |1 is obsolete|| --- Comment #190 from Aleisha Amohia --- Created attachment 90842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90842&action=edit Bug 15516: (follow-up) Changing utf8 to utf8mb4 Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What|Removed |Added Attachment #90300|0 |1 is obsolete|| --- Comment #188 from Aleisha Amohia --- Created attachment 90840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90840&action=edit Bug 15516: (follow-up) Fixing modal view and more Fixing - modal view - missed changes from 'reserve group' to 'hold group' - updating atomic update to perl Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What|Removed |Added Attachment #90296|0 |1 is obsolete|| --- Comment #184 from Aleisha Amohia --- Created attachment 90836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90836&action=edit Bug 15516: (follow-up) Fix reserve -> hold change Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What|Removed |Added Attachment #90301|0 |1 is obsolete|| --- Comment #189 from Aleisha Amohia --- Created attachment 90841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90841&action=edit Bug 15516: (follow-up) Schema updates Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What|Removed |Added Attachment #90294|0 |1 is obsolete|| --- Comment #182 from Aleisha Amohia --- Created attachment 90834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90834&action=edit Bug 15516: Fix translation issues - Use " inside _() - Merge two strings (PART_OF_A, HOLD_GROUP) Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What|Removed |Added Attachment #90291|0 |1 is obsolete|| --- Comment #179 from Aleisha Amohia --- Created attachment 90831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90831&action=edit Bug 15516: Update old_reserves (reserve_group_id) Without it, deletion of reserves will fail Signed-off-by: Benjamin Rokseth Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What|Removed |Added Attachment #90295|0 |1 is obsolete|| --- Comment #183 from Aleisha Amohia --- Created attachment 90835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90835&action=edit Bug 15516: (follow-up) Fix kohastructure.sql Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What|Removed |Added Attachment #90290|0 |1 is obsolete|| --- Comment #178 from Aleisha Amohia --- Created attachment 90830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90830&action=edit Bug 15516: Holding first available item from x biblios only count 1 reserve Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What|Removed |Added Attachment #90293|0 |1 is obsolete|| --- Comment #181 from Aleisha Amohia --- Created attachment 90833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90833&action=edit Bug 15516: Reword 'reserve group' to 'hold group' Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What|Removed |Added Attachment #90292|0 |1 is obsolete|| --- Comment #180 from Aleisha Amohia --- Created attachment 90832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90832&action=edit Bug 15516: Set reserve-group.pl to be executable Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What|Removed |Added Attachment #90289|0 |1 is obsolete|| --- Comment #177 from Aleisha Amohia --- Created attachment 90829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90829&action=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library have the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This patch is only for staff interface. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Enter a patron cardnumber and click Search 3. Check the box for 'Place a hold on the next available item' (it's usually hidden when placing a hold on multiple biblios) 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a reserve group)' in Details column. 6. Click on the "reserve group" link. A modal window should appear with the content of the reserve group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "reserve group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15985] Include transacting library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #23 from Jonathan Druart --- 1. Changes are made in Koha/Schema/Result/OldIssue.pm, above the "DO NOT MODIFY THIS OR ANYTHING ABOVE!" line. Is it expected? Did you forget to attached the DB changes patch? If you wanted to add it after that line, why not adding the constraint at DB level? Why not for Issue.pm? 2. -use base qw(Koha::Object); +use base qw(Koha::Checkout); Is this really needed? Why? If so I think it must be moved to its own bug report, explaining why we need it and what it will bring. Also tests must be provided for such changes. Note that both t/db_dependent/Koha/Account/Lines.t and t/db_dependent/Koha/Checkouts.t are passing without that change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|In Discussion CC||martin.renvoize@ptfs-europe ||.com --- Comment #6 from Jonathan Druart --- Martin, any suggestions to make this even more readable? Maybe using filter_by? I will be waiting for a decision before applying the change to other *detail.pl scripts. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 --- Comment #4 from Jonathan Druart --- Created attachment 90827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90827&action=edit Bug 23166: Remove baskets_deletedorders code This is never used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 --- Comment #5 from Jonathan Druart --- Created attachment 90828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90828&action=edit Bug 23166: Replace the count of orders with Koha::Acq::Orders -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 Jonathan Druart changed: What|Removed |Added Attachment #90825|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 90826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90826&action=edit Bug 23166: Remove baskets_orders code This is never used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Jonathan Druart changed:
What|Removed |Added
Attachment #90824|0 |1
is obsolete||
--- Comment #2 from Jonathan Druart
---
Created attachment 90825
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90825&action=edit
Bug 23084: Replace grep {^$var$} with grep {$_ eq $var}
We certainly faced 3 similar bugs due to this syntax: bug 23006, bug
22941 and bug 17526.
To prevent other issues related to this syntax this patch suggests to
replace them all in one go.
Test plan:
Confirm that the 2 syntaxes are similar
Eyeball the patch and confirm that there is no typo!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 --- Comment #1 from Jonathan Druart --- Created attachment 90824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90824&action=edit Bug 23166: Replace the count of orders with Koha::Acq::Orders -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_}
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 Jonathan Druart changed: What|Removed |Added Blocks||23166 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 [Bug 23166] Simplify code related to orders in catalogue/*detail.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9780] Restrict the right to suppress a record used in some order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 Jonathan Druart changed: What|Removed |Added Blocks||23166 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 [Bug 23166] Simplify code related to orders in catalogue/*detail.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] New: Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
Bug ID: 23166
Summary: Simplify code related to orders in
catalogue/*detail.pl
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: ASSIGNED
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: jonathan.dru...@bugs.koha-community.org
Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 23084, 9780
Target Milestone: ---
Since bug 9780 we are the ability to alert the librarian when a record which
has been ordered will be deleted.
Then the code to handle the alert has been copied to other catalogue/*detail.pl
script, as the JS check is in the toolbar.
This code is really unnecessary complicated and sometime simply not necessary.
It could be replaced with Koha::Acquisition::Orders->search and make it more
readable.
(found it working on bug 23084, so writing it on top of it).
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780
[Bug 9780] Restrict the right to suppress a record used in some order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084
[Bug 23084] Replace grep {^$var$} with grep {$var eq $_}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_}
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084
Jonathan Druart changed:
What|Removed |Added
Attachment #90821|0 |1
is obsolete||
--- Comment #4 from Jonathan Druart
---
Created attachment 90823
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90823&action=edit
Bug 23084: Replace grep {^$var$} with grep {$_ eq $var}
We certainly faced 3 similar bugs due to this syntax: bug 23006, bug
22941 and bug 17526.
To prevent other issues related to this syntax this patch suggests to
replace them all in one go.
Test plan:
Confirm that the 2 syntaxes are similar
Eyeball the patch and confirm that there is no typo!
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23090] MySQL validate_password plugin breaks koha-create
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23090 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23090] MySQL validate_password plugin breaks koha-create
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23090 Chris Cormack changed: What|Removed |Added Attachment #90463|0 |1 is obsolete|| --- Comment #3 from Chris Cormack --- Created attachment 90822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90822&action=edit Bug 23090: Add some special characters TEST PLAN - $ sudo mysql -u root > CREATE USER 'bug23090_test1'@'localhost' IDENTIFIED BY 'badpassword'; [Magical MySQL Error] > CREATE USER 'bug23090_test1'@'localhost' IDENTIFIED BY 'GoodP@ssw0rd'; [Should be okay] > DROP USER 'bug23090_test1'@'localhost'; > QUIT $ sudo koha-create --create-db fail23090 [Magical MySQL Error] [Apply this patch and put it (debian/scripts/koha-create) into place in /usr/sbin/koha-create] $ sudo koha-create --create-db pass23090 (Clean up and databases made) Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_}
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084
Jonathan Druart changed:
What|Removed |Added
Attachment #90820|0 |1
is obsolete||
--- Comment #3 from Jonathan Druart
---
Created attachment 90821
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90821&action=edit
Bug 23084: Replace grep {^$var$} with grep {$_ eq $var}
We certainly faced 3 similar bugs due to this syntax: bug 23006, bug
22941 and bug 17526.
To prevent other issues related to this syntax this patch suggests to
replace them all in one go.
Test plan:
Confirm that the 2 syntaxes are similar
Eyeball the patch and confirm that there is no typo!
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_}
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084
--- Comment #2 from Jonathan Druart
---
Created attachment 90820
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90820&action=edit
Bug 23084: Replace grep {^$var$} with grep {$_ eq $var}
We certainly faced 3 similar bugs due to this syntax: bug 23006, bug
22941 and bug 17526.
To prevent other issues related to this syntax this patch suggests to
replace them all in one go.
Test plan:
Confirm that the 2 syntaxes are similar
Eyeball the patch and confirm that there is no typo!
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_}
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20307] Language overlay for authorized values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 --- Comment #22 from Jonathan Druart --- It's hard to provide a complete test plan, you will need to show imagination to find bugs :) The idea is to translate authorised values and confirm that they are displayed translated for translated templates. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 --- Comment #6 from Jonathan Druart --- About 23070, not sure I will manage to rephrase it :) ->store will check the default values (triggering Koha::Object->store), and also do some stuffs (like logging, etc.) But in some cases (like the one we have on 23070), we know that it won't be necessary. The +1 query will not need the default values check or anything else, we just want to increment a value in DB. That a good example to let people use ->update directly, even if it should considered as a not recommended method And QA will have to be careful about that -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be logged out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #2 from Jonathan Druart --- (In reply to Nick Clemens from comment #1) > Created attachment 90528 [details] [review] > Bug 23102 - 404 errors on page causes SCI user to be logged out > > To test: > 1 - Have something on the SCO page that won't load Can you be more specific? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20116] Cache language list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 --- Comment #41 from Jonathan Druart --- (In reply to M. Tompsett from comment #39) > In addition to the whole $KOHA_HOME path existing in live problem, perhaps > the flushing could be split to a separate patch, so that bug 20884 could > depend on that, and not this? Or we push this and bug 20884 will benefit from it? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20116] Cache language list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #40 from Jonathan Druart
---
(In reply to M. Tompsett from comment #38)
> Comment on attachment 88201 [details] [review]
> Bug 20116: Flush the caches
>
> Review of attachment 88201 [details] [review]:
> -
>
> ::: debian/scripts/koha-translate
> @@ +233,5 @@
> >
> > +flush_cache()
> > +{
> > +if [ "$dev" = "" ]; then
> > +koha-foreach --enabled "$KOHA_HOME/misc/bin/clear_cache.pl"
>
> Is $KOHA_HOME/misc/bin going to exist? And is clear_cache.pl going to get
> put there? Something is fishy for running this live.
How that? Did you `git grep KOHA_HOME`?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23083] Course reserve item edit fails if one does not set all values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23083 --- Comment #7 from Jonathan Druart --- Created attachment 90818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90818&action=edit Bug 23083: Add tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23083] Course reserve item edit fails if one does not set all values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23083 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23083] Course reserve item edit fails if one does not set all values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23083 --- Comment #8 from Jonathan Druart --- Created attachment 90819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90819&action=edit Bug 23083: Fix course reserve item editing if one of the value is set to UNCHANGED Test plan: 0: Do not apply the patches 1: Create an item with itype, ccode, location, and holding branch set 2: Create a course 3: Add item to course, changing the values for itype, ccode, and location 4: Click Edit for that item on course-details.pl 5: Assign new values for itype, ccode, and location but leave the holding library dropdown set to LEAVE UNCHANGED 6: Hit Save 7: Back on course-details.pl, observe that the item is still showing the values set in step 3 8: Apply this patch 9: Repeat 4 to 6 10: Back on course-details.pl, observe that the item is now showing the correct values 11: Edit the course reserve again, setting new values for itype, ccode, and location and setting the holding library dropdown to whatever the holding library for the item is currently 12: hit save 13: On course-details.pl, see that the change actually happened, the item is now showing the values set in step 9 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23083] Course reserve item edit fails if one does not set all values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23083 Jonathan Druart changed: What|Removed |Added Status|REOPENED|Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23108] staffaccess permission can be easily circumvented
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23108 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- (In reply to Andrew from comment #0) > BUT: A user without the staffaccess permission can simply change a Staff > user to a new non-staff patron category and then make changes to permissions > and/or password. Hi Andrew, are you aware of the pref ProtectSuperlibrarianPrivileges? With the pref turned on (default) what you describe should not be allowed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23139] Koha::SharedContent->get_sharing_url is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23139 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- It's also used in Koha::SharedContent::build_request 187 my $mana_url = get_sharing_url(); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12310] Decimal separators issues in patrons payments/fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23127 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23127] Using commas in shipping cost on invoices causes issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23127 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=12310 CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- Yes but, where does it work? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23124] trailing spaces in DefaultPatronSearchFields can break patron searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23124 Jonathan Druart changed: What|Removed |Added Depends on||22844 CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- I think we should fix it on top of bug 22844. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 [Bug 22844] Simplify the process of selecting database columns for system preferences -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Jonathan Druart changed: What|Removed |Added Blocks||23124 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23124 [Bug 23124] trailing spaces in DefaultPatronSearchFields can break patron searching -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23150] GDPR breaks patron self modification on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 --- Comment #1 from Jonathan Druart --- Created attachment 90817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90817&action=edit Bug 23150: Do not consider gdpr_proc_consent a mandatory field It introduced a regression in the patron's self modification feature. Patron's details are no longer modificable, the screen displays "You have not filled out all required fields. Please fill in all missing fields and resubmit." Test plan: - Set GDPR_Policy to either Enforced or Permissive - Set PatronSelfRegistrationBorrowerMandatoryField to empty - Set OPACPatronDetails to Allow - Log into the OPAC - Accept the GDPR screen - Go to opac-memberentry.pl, change something, submit modification request -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23150] GDPR breaks patron self modification on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23150] GDPR breaks patron self modification on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Jonathan Druart changed: What|Removed |Added Assignee|oleon...@myacpl.org |jonathan.dru...@bugs.koha-c ||ommunity.org Severity|normal |major CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||m.de.r...@rijksmuseum.nl Version|18.11 |master --- Comment #2 from Jonathan Druart --- Not sure about this fix, I'd like Marcel review :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819
Jonathan Druart changed:
What|Removed |Added
Blocks||23150
--- Comment #80 from Jonathan Druart
---
Why do we have the following line:
opac/opac-memberentry.pl:push @fields, 'gdpr_proc_consent' if
C4::Context->preference('GDPR_Policy');
It causes bug 23150.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150
[Bug 23150] GDPR breaks patron self modification on OPAC
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23150] GDPR breaks patron self modification on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Jonathan Druart changed: What|Removed |Added Depends on||20819 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23162] Cannot copy a notice if independent branches enabled and not a superlibrarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23162 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- What should we do? Remove the Copy button? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23082] Fatal error editing a restricted patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 --- Comment #4 from Jonathan Druart --- Federico, can you locate where you Koha code is (should be something like /usr/share/koha/lib) then copy the output of the following command: % grep -r remove_debarment -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18344] Overdue fines 'cap at replacement price' and 'cap by amount' should work together
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18344 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #14 from Lucas Gass --- backported to 18.11.x for 18.11.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23053] Local-Number cannot be used for authority matching due to non-existence of 'phrase' index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23053 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #11 from Lucas Gass --- backported to 18.11.x for 18.11.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23164] Add a way to unmock preferences and config entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23164 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21073] Improve plugin performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #94 from Tomás Cohen Arazi --- Created attachment 90816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90816&action=edit Bug 21073: (QA follow-up) Fix plugin-related tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23165] Renewals for Self Checkout (SCO) module do not record branchcode in statistics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23165 --- Comment #1 from Kyle M Hall --- Created attachment 90815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90815&action=edit Bug 23165: Renewals for Self Checkout (SCO) module do not record branchcode in statistics Koha considers SCO to be part of the OPAC, but the code related to OpacRenewalBranch is in opac-renew.pl. Because of this, the branchcode does not get set when a renewal takes place via the self check module. It would make more sense to move this logic into C4::Circulation::AddRenewal to centralize it and ensure that the statistics branch is set no matter where in the OPAC AddRenewal may be called. Test Plan: 1) Using the SCO module, renew an item 2) View the statistics table row for the renewal, note that branch is empty 3) Apply this patch 4) Restart all the things! 5) Renew the item again 6) View the stats table row for the new renewal, the branch code should be set as per the system preference OpacRenewalBranch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23165] Renewals for Self Checkout (SCO) module do not record branchcode in statistics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23165 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23165] New: Renewals for Self Checkout (SCO) module do not record branchcode in statistics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23165 Bug ID: 23165 Summary: Renewals for Self Checkout (SCO) module do not record branchcode in statistics Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- Koha considers SCO to be part of the OPAC, but the code related to OpacRenewalBranch is in opac-renew.pl. Because of this, the branchcode does not get set when a renewal takes place via the self check module. It would make more sense to move this logic into C4::Circulation::AddRenewal to centralize it and ensure that the statistics branch is set no matter where in the OPAC AddRenewal may be called. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23165] Renewals for Self Checkout (SCO) module do not record branchcode in statistics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23165 Kyle M Hall changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #20 from Jonathan Druart --- (In reply to M. Tompsett from comment #19) > It's in the first patch as a .perl, Jonathan. :) Sorry, I missed it. However the column need to be set for existing installations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20816] Add ability to send custom field(s) containing patron information in SIP patron responses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20816 --- Comment #1 from Nick Clemens --- Created attachment 90813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90813&action=edit Bug 20816: Add ability to define custom templated fields in SIP patron responses To test: 1 - You will need to enable SIP on your testing instance cp etc/SIPconfig.xml /etc/koha/sites/kohadev/ sudo koha-start-sip add a user listed in the SIPconfig to your system and give them permissions (superlibrarian works) 2 - If you copied the above file you should be set to get custom field DE with dateexpiry 3 - send a status test using the sip cli tester: perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su lpl-sc-beacock -sp xyzzy -l LPL --patron nick -m patron_status_request 4 - send an information test using the sip cli tester: perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su lpl-sc-beacock -sp xyzzy -l LPL --patron nick -m patron_information 5 - confirm you receive the DE field with a dateexpiry 6 - Add your own custom fields and confirm it works with several 7 - prove -v t/db_dependent/SIP/Patron.t 8 - prove -v t/db_dependent/SIP/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20816] Add ability to send custom field(s) containing patron information in SIP patron responses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20816 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22431 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22431] Incorrect group by in circ/pendingreserves.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22431 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=13640 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22431] Incorrect group by in circ/pendingreserves.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22431 --- Comment #3 from Jonathan Druart --- I have a "PFFF rewriting pendingreserves.pl" commit on a local branch, if anyone is willing to work on/continue it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Jonathan Druart changed: What|Removed |Added Depends on||22431 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22431 [Bug 22431] Incorrect group by in circ/pendingreserves.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23164] New: Add a way to unmock preferences and config entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23164 Bug ID: 23164 Summary: Add a way to unmock preferences and config entries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- There should be a way to unmock mocked things. In my opinion t::lib::Mocks should be object-oriented, and keep references to the context object that is used for mocking. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22431] Incorrect group by in circ/pendingreserves.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22431 Jonathan Druart changed: What|Removed |Added Blocks||17258 CC||jonathan.dru...@bugs.koha-c ||ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20816] Add ability to send custom field(s) containing patron information in SIP patron responses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20816 Nick Clemens changed: What|Removed |Added Summary|add user expiration date to |Add ability to send custom |SIP2 message|field(s) containing patron ||information in SIP patron ||responses -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19515] Refactor REST API session mocking to reduce code duplication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19515 Tomás Cohen Arazi changed: What|Removed |Added Resolution|--- |WORKSFORME Status|Failed QA |RESOLVED --- Comment #7 from Tomás Cohen Arazi --- We have implemented Basic authentication, and it got really simple to test the API without this much trouble. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 M. Tompsett changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #19 from M. Tompsett --- It's in the first patch as a .perl, Jonathan. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23156] Add pagination to checkouts in ILS-DI GetPatronInfo service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23156 --- Comment #3 from Arthur Suzuki --- Yipee, super great! I was looking for this since a couple months but unfortunately couldn't find the time nor the expertise to do it myself. Thanks Julian for the patch!!! Thanks Mark for signing off :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23116] Cannot place overridden holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23116 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #9 from Jonathan Druart --- Naive question reading the diff: should not we have that check in CanItemBeReserved? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23156] Add pagination to checkouts in ILS-DI GetPatronInfo service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23156 M. Tompsett changed: What|Removed |Added Attachment #90774|0 |1 is obsolete|| --- Comment #2 from M. Tompsett --- Created attachment 90812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90812&action=edit Bug 23156: Add pagination to checkouts in ILS-DI GetPatronInfo service When patrons have a lot of checkouts, GetPatronInfo can take a lot of time. This patch introduces two new parameters to allow pagination of this list of checkouts Also, fix a warning in C4::ILSDI::Services::GetPatronInfo Test plan: 1. Go to /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=X&show_loans=1 where X is a borrowernumber of a patron who has several checkouts Verify that all checkouts are listed 2. Add '&loans_per_page=1&loans_page=1' to the URL. Verify that you have now only one checkout listed, and that there is a new element which contain the total number of checkouts 3. Increase the page number in the URL until you have seen all checkouts 4. prove t/db_dependent/ILSDI_Services.t Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #18 from Jonathan Druart --- Mark, what about the update process? We need to have an atomic update file and update the existing rows in DB. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23156] Add pagination to checkouts in ILS-DI GetPatronInfo service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23156 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7890] Required fields in the MARC editor should be highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Owen Leonard changed: What|Removed |Added Depends on|22399 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 [Bug 22399] Improve responsive behavior of the basic marc editor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22399] Improve responsive behavior of the basic marc editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard changed: What|Removed |Added Blocks|7890| Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 [Bug 7890] Required fields in the MARC editor should be highlighted -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22768] Global search forms' keyboard navigation broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22768
--- Comment #1 from Owen Leonard ---
Created attachment 90810
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90810&action=edit
Bug 22768: Global search form keyboard navigation broken
Bug 22045 made changes to the global staff client JavaScript which
broken keyboard navigation for the most common forms in the resident
search form("Check out, Check in, Renew, Search). This patch
reimplements the tab selection code on the basic MARC editor page so
that the keyboard shortcut behavior can be restored.
To test, apply the patch go to Cataloging.
- Search for an existing record and edit it in the basic MARC editor.
- Test that the numbered tabs (0-9) at the top work correctly.
- Select a tab other than 0 and choose Save -> Save and continue
editing. When the page reloads you should be returned to the tab you
were on when you saved.
- Go to the Circulation home page. Test the keyboard shortcuts for
switching tabs in header area:
- Alt-u (Check out)
- Alt-r (Check in)
- Alt-w (Renew)
- Alt-q (Search)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22768] Global search forms' keyboard navigation broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22768 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22768] Global search forms' keyboard navigation broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22768 Owen Leonard changed: What|Removed |Added Summary|Basic MARC editor tab |Global search forms' |keyboard navigation broekn |keyboard navigation broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23163] New: HoldsSplitQueueNumbering requires "modify_holds_priority" permission to work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23163 Bug ID: 23163 Summary: HoldsSplitQueueNumbering requires "modify_holds_priority" permission to work Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: geo...@nekls.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Target Milestone: --- In Koha 18.11, if HoldsSplitQueueNumbering is set to "'virtual' priorities, where each group is numbered separately" the virtual holds queues are not renumbered separately unless the staff user has the "modify_holds_priority" set. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23147] changes made by bug 20044 to addbiblio.pl causing issues for some catalogers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23147
--- Comment #6 from Owen Leonard ---
(In reply to Kim Olson from comment #5)
> Applying the suggestion that Owen posted is beyond me.
To use my suggestion above you would go to Administration -> Global system
preferences, and search for "IntranetUserCSS." Click the "Click to edit" link
to expand the textarea.
Paste in the following text:
@media (min-width:613px){#addbibliotabs div.subfield_line
label{width:15em}#addbibliotabs .input_marceditor{width:20em}#addbibliotabs
.subfield{width:12em}}@media (min-width:768px){#addbibliotabs div.subfield_line
label{width:20em}#addbibliotabs .input_marceditor{width:30em}#addbibliotabs
.subfield{width:14em}}@media (min-width:1200px){#addbibliotabs
div.subfield_line label{width:25em}#addbibliotabs
.input_marceditor{width:50em}#addbibliotabs .subfield{width:16em}}
Save your changes.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #17 from M. Tompsett --- Sorry, I forgot to change the status before Lucas and Ed signed off. DOH! Feel free to try again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 M. Tompsett changed: What|Removed |Added CC||ev...@mckinneytexas.org, ||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 M. Tompsett changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #15 from M. Tompsett --- Created attachment 90808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90808&action=edit Bug 23151: Add tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #13 from M. Tompsett --- Created attachment 90806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90806&action=edit Bug 23151: Schema changes It is best to regenerate these from scratch. On a kohadevbox: $ misc/devel/update_dbix_class_files.pl --db_name=koha_kohadev --db_user=koha_kohadev --db_passwd=password -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #16 from M. Tompsett --- Created attachment 90809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90809&action=edit Bug 23151: (follow-up) tweaked tests This forces the tests to use the new changed_fields field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #14 from M. Tompsett --- Created attachment 90807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90807&action=edit Bug 23151: Tweak to use the new database structure This will use changed_fields to know whether a borrower field is actually modified. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 M. Tompsett changed: What|Removed |Added Attachment #90797|0 |1 is obsolete|| Attachment #90799|0 |1 is obsolete|| --- Comment #12 from M. Tompsett --- Created attachment 90805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90805&action=edit Bug 23151: Modifiy database structure This modifies a fresh install structure, and provides an atomic update. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23147] changes made by bug 20044 to addbiblio.pl causing issues for some catalogers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23147 Kim Olson changed: What|Removed |Added CC||lclib...@gmail.com --- Comment #5 from Kim Olson --- Since the newest update, all the beautiful formatting we used to enjoy while editing records is gone. This is slowing my work flow down so much, it's really not acceptable. Two factors are making life particularly difficult. First, the indenting is gone. Before, with subfields indented from fields, and open boxes indented from that, it was quick and easy to scan down a page. Now the more cluttered look of everything left-justified makes it difficult to focus on field numbers. Second, the longer field boxes (which are rarely even useful, as so much of the content is brief, and never necessary, since they all expand vertically to include content) are distracting. But the main difficulty is the fact that subfield headings, and the duplicate/delete buttons are no longer in line with the boxes, but above them. I keep having to correct myself, because I use the box above instead of below a subfield heading, just because it's not as immediately obvious. Also, there is the small up-pointing arrow to the left of the subfield number and label, which is there for rearranging subfields manually, but in the new alignment, it seems to be (incorrectly) connecting the label to the box above it. I have to really concentrate to remind my brain that it has a different purpose, and that never happened before. > Can we please have the old alignment and indents back? Applying the suggestion that Owen posted is beyond me. I just need it to work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23162] New: Cannot copy a notice if independent branches enabled and not a superlibrarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23162 Bug ID: 23162 Summary: Cannot copy a notice if independent branches enabled and not a superlibrarian Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- We forget to set the branch to current branch I guess To recreate: 1 - Be a superlibrarian (you all are anyways!) 2 - Go to Tools->notices and slips 3 - Note you see notices and can copy them to other branches to edit 4 - Now enabled independent branches 5 - It all still works 6 - Stop being a superlibrarian (i.e. create a patron with permissions for notices, but not superlibrarian) 7 - Go to Tools->notices and slips 8 - Note the 'copy' button doesn't have a drop down to select branch 9 - Click it, you can edit 10 - Try to save - Alert:A letter with the code 'ACCTDETAILS' already exists for 'undefined'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
