[Koha-bugs] [Bug 22721] Normalize GetMarcFromKohaField calls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22721 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #9 from Katrin Fischer --- Didn't spot any more occurrences. Does this warrant a check in the QA tools? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22721] Normalize GetMarcFromKohaField calls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22721 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22721] Normalize GetMarcFromKohaField calls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22721 Katrin Fischer changed: What|Removed |Added Attachment #91372|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 91397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91397=edit Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls Test plan: Run tests, at least: t/db_dependent/Biblio.t t/db_dependent/Biblio/TransformHtmlToMarc.t t/db_dependent/Charset.t t/db_dependent/Circulation/GetTopIssues.t t/db_dependent/Filter_MARC_ViewPolicy.t t/db_dependent/ImportBatch.t t/db_dependent/Items.t t/db_dependent/Items/AutomaticItemModificationByAge.t t/db_dependent/Items/GetItemsForInventory.t t/db_dependent/Koha/Filter/EmbedItemsAvailability.t t/db_dependent/Serials.t t/db_dependent/XISBN.t t/db_dependent/FrameworkPlugin.t Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Bouzid Fergani Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23218] Batch patron modification empty attribute causes improper handling of values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23218 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer --- value="poeut" ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18707] Background jobs post disabled inputs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18707
Katrin Fischer changed:
What|Removed |Added
Attachment #91065|0 |1
is obsolete||
--- Comment #8 from Katrin Fischer ---
Created attachment 91396
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91396=edit
Bug 18707: Background jobs post disabled inputs
For example, in Tools > Batch item modification input of deleted subfields are
disabled.
This form is posted using background job via JS code.
Looks like this JS code converts a POST form into a GET URL, including inputs
that are disabled :
koha-tmpl/intranet-tmpl/prog/js/background-job-progressbar.js
function submitBackgroundJob(f) {
...
$(':input', f).each(function() {
...
This patch add a :enabled to selector
Test plan :
Signed-off-by: Kyle M Hall
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18707] Background jobs post disabled inputs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18707 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18707] Background jobs post disabled inputs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18707 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #7 from Katrin Fischer --- Missing test plan... but I tested multiple batch operations and the change makes sense. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23219] Show a warning about cancelling their holds before a patron is deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23219 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer --- Hi Emmi, this works really well, but according to our coding guidelines any change to one of the C4 or Koha routines should be accompanied by a unit test testing the changed/new behaviour. Would you be able to provide a test? Let us know if we can help. With the test, you can switch back to Signed off straight away. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23219] Show a warning about cancelling their holds before a patron is deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23219 Katrin Fischer changed: What|Removed |Added Attachment #91351|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 91395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91395=edit Bug 23219: Cancel patrons holds when patron delete Currently deleting a patron deletes all their holds and leaves no record to the "old_reserves" table. Steps to reproduce: - Create a patron - Add holds for patron - Holds are recorded to "reserves" table - Delete patron - Confirm delete =>Patron and all holds are deleted and no record of holds is left in "old_reserves" table This patch displays alert text notifying user that deleting patron cancels all their holds. Holds are cancelled instead of deleting them. This patch also writes stringified datetime to holds cancel log instead of whole datetime object. To test: - Apply this patch - Create a patron - Add holds for patron - Holds are recorded to "reserves" table - Delete patron - Alert text of holds is displayed - Confirm patron delete => Patron is deleted, their holds are cancelled and moved to "old_reserves" table Signed-off-by: Owen Leonard Signed-off-by: Nadine Pierre Signed-off-by: Arthur Bousquet Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23219] Show a warning about cancelling their holds before a patron is deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23219 Katrin Fischer changed: What|Removed |Added Summary|Prevent patron delete if|Show a warning about |holds |cancelling their holds ||before a patron is deleted -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20364] Show languages from MARC21 field 041 in intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 --- Comment #10 from Katrin Fischer --- I am not totally fond of the ending . on the fields, but as there can be multiple labels on the same line, I can see why they were put there. Something to work later maybe. Also: There is no mention of the maintenance script in the commit message. Wondering how we can document this best. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20364] Show languages from MARC21 field 041 in intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20364] Show languages from MARC21 field 041 in intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 Katrin Fischer changed: What|Removed |Added Attachment #90845|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 91394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91394=edit Bug 20364: Show languages from MARC21 field 041 in intranet Show the language names coded in field 041, in intranet search results and in detail view. Test plan: 1) Apply patch 2) Do a search, and check the results look correct 3) Check some biblio detail pages that they look correct 4) Add some 041 subfields (a, b, d, h, j) in any combinations 5) Repeat 2 and 3 Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246
--- Comment #11 from Tomás Cohen Arazi ---
(In reply to Katrin Fischer from comment #9)
> Only... it doesn't work.
>
> I am looking at a detail page in staff and now the acq tab is preselected.
> Patches applied, restart_all and cache deleted.
The original implementation jumped to the fourth tab in the event of no
holdings.
The fourth tab is not the media one if HTML5MediaEnabled is disabled, and there
are conditions in which even in that case it is not the fourth.
The follow-up just adds an ID to the media tab, and jumps into is by using the
ID instead.
So, if it is not working, can you check on the page sources, and see if you
have the ID, and the line that says:
$('#bibliodetails').tabs("option", "active", $('#media_tab').index() );
If it is there, then it is not working, otherwise your templates have been
cached or similar.
I will retry myself. Thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12537] Editions tab showing on bibs with more than one ISBN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12537 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12537] Editions tab showing on bibs with more than one ISBN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12537 Katrin Fischer changed: What|Removed |Added Attachment #91125|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 91393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91393=edit Bug 12537: Don't retrieve XISBN results for the same biblionumber For a biblio with multiple ISBNS we sometimes get our own record back when check XISBN, we should test for this To test: 1 - Edit a record in the catalogue, add two isbns: 0521240670 0521284198 2 - Enable ThingISBN and FRBRizeEditions and OPACFRBRizeEditions 3 - View the record in staff and OPAC 4 - You should see editions tab pointing to the same record 5 - Apply patch 6 - Reload the record details, you should no longer see editions tab 7 - Add the second ISBN to another record 8 - Reload details for original record, you shoudl see editions linking to the record with second ISBN 9 - prove -v t/db_dependent/XISBN.t NOTE: Current tests don't work under elasticsearch, but the code does, tests should be rewritten on another bug Signed-off-by: Mark Tompsett Signed-off-by: Bouzid Fergani Signed-off-by: Arthur Bousquet Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23274] New: t/db_dependent/XISBN.t fails with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23274 Bug ID: 23274 Summary: t/db_dependent/XISBN.t fails with Elasticsearch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org What is says in the title: - Run t/db_dependent/XISBN.t - tests pass - Activate Elasticsearch - t/db_dependent/XISBN.t fails -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12537] Editions tab showing on bibs with more than one ISBN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12537 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23274 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12537] Editions tab showing on bibs with more than one ISBN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12537 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Summary|editions tab showing on |Editions tab showing on |bibs with more than one |bibs with more than one |ISBN|ISBN -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23192] Cancelling holds over returning to wrong tab on waitingreserves.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23192] Cancelling holds over returning to wrong tab on waitingreserves.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192 Katrin Fischer changed: What|Removed |Added Attachment #91359|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 91392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91392=edit Bug 23192: Correct tab input on waiting_holds.inc To test: 1 - Place 2 holds 2 - Confirm the holds 3 - In the db change the expiration date: UPDATE reserves SET expirationdate = '2019-01-01'; 4 - Go to Home->Circulation->Holds awaiting pickup 5 - View your holds on the 'Holds waiting over' tab 6 - Inspect the cancel button for one of the holds, note tab = "holdswaiting" 7 - Apply patch 8 - Refresh the page 9 - Inspect the buttton, note tab = "holdsover" 10 - Cancel the hold 11 - Note you return to the holds over tab Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23266] Add to cart fires twice on shelf page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23266 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23266] Add to cart fires twice on shelf page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23266 Katrin Fischer changed: What|Removed |Added Attachment #91321|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 91391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91391=edit Bug 23266: Add to cart fires twice on shelf page Remove some duplicate functionality between opac-bottom and opac-shelves. Test plan: [1] Before this patch, add to cart from a shelf page. Observe that the basket count is incremented with 2. [2] After this patch, it should be incremented with 1. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23194] Public notes items in the OPAC should allow for HTML tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23194] Public notes items in the OPAC should allow for HTML tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Katrin Fischer changed: What|Removed |Added Attachment #91371|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 91390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91390=edit Bug 23194: Fix other occurences Throughout staff client and course reserves we also show the field with HTML filter, maybe we shouldn't? The items lost report also included the note as a title element on title and barcode links, I removed this as the note displays in that table To test: 1 - Add a link to publicnotes for an item Cats! 2 - View opac details, confirm the note is a link 3 - Same for staff side 4 - Add item to a course reserve UseCourseReserves preference must be set to 'Use' From the course reserves module you will need to add a course (and possibly a department first) Adding should be intuitive 5 - Confirm note is a link in course details on staff and opac 6 - Perform a batch checkout, confirm the itemnote shows as a link You will need to enable the system preference: BatchCheckouts and add a patron category to: BatchCheckoutsValidCategories Then a link should be available from checkout for a patron in that category 7 - Mark the item as lost 8 - Go to Reports->Items lost 9 - Confirm the note is a URL and that title and barcode links don't show the note 10 - Click the barcode to go to moredetails for the item - in this case note should display as editable text, not a link Signed-off-by: Claire Gravely Signed-off-by: frederik chenier Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23194] Public notes items in the OPAC should allow for HTML tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Katrin Fischer changed: What|Removed |Added Attachment #91370|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 91389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91389=edit Bug 23194: Allow HTML in item public notes to be processed on OPAC details Signed-off-by: Claire Gravely Signed-off-by: frederik chenier Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23194] Public notes items in the OPAC should allow for HTML tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Katrin Fischer changed: What|Removed |Added Attachment #91015|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23194] Public notes items in the OPAC should allow for HTML tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Attachment #91014|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 --- Comment #10 from Katrin Fischer --- It appears to work for me without the follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer --- Only... it doesn't work. I am looking at a detail page in staff and now the acq tab is preselected. Patches applied, restart_all and cache deleted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #7 from Katrin Fischer --- I am really not sure what this is trying to fix - please include a description of the problem and how to reproduce it in the test plan. Should the media tab be preselected under certain conditions? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #8 from Katrin Fischer --- (In reply to Tomás Cohen Arazi from comment #0) > This is certainly related to bug 16507. The original implementation is > supposed to jump into the 'media tab' if there are no holdings, but it is > not checking HTML5MediaEnabled or HTML5MediaYouTube in order to jump to that > tab. > > Steps to reproduce: > - Have HTML5MediaYouTube and HTML5MediaEnabled disabled > - Create a record with no items > - Go to the detail page > => FAIL: the 'Images' tab is selected I think this was meant to say enabled? Because then this starts to make sense now :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23259] Remove reset-fonts-grids.css
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23259 Katrin Fischer changed: What|Removed |Added Attachment #91336|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 91388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91388=edit Bug 23259: Remove reset-fonts-grids.css This patch removes the CSS file reset-fonts-grids.css which was required when the staff client templates used YUI grids. Now that all staff client templates have been converted to Bootstrap grid markup the file can be deleted. Because the YUI CSS also did set some baseline properties for different tags the global SCSS file is modified in this patch in order to keep things looking consistent. Most of these updates change font-size declarations to preserve the previous appearance. Some styling has been added to (non Bootstrap-classed) and tags in order to keep button style consistent. Removed from staff-global.scss: YUI-specific CSS which has been made obsolete by the template conversions. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear your browser cache if necessary. Browse through various pages of thes staff client to confirm that the changes work well. Signed-off-by: Nadine Pierre Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23259] Remove reset-fonts-grids.css
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23259 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23227] Remove type attribute from script tags: Reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227 Katrin Fischer changed: What|Removed |Added Attachment #91353|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 91387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91387=edit Bug 23227: Remove type attribute from script tags: Reports This patch removes the "type" attribute from
[Koha-bugs] [Bug 23227] Remove type attribute from script tags: Reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23197] Add more batch operation options to SQL report results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23197 Katrin Fischer changed: What|Removed |Added Attachment #91376|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 91386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91386=edit Bug 23197: Add more batch operation options to SQL report results This patch extends the feature which allows the user to send item numbers from a page of report results to batch item modification. For biblionumbers: Batch record modification, batch record deletion, and add to list are now available. For item numbers: batch item deletion is added. A new menu button is added for these options at the top of report results, removing the button from the item number column header. Corresponding CSS has been removed. To test, apply the patch and create a report which includes both biblionumber and itemnumber columns in the results. - Run the report and confirm that a new "Batch operations" button appears at the top of the results. Test each option: - Batch record modification - Batch record deletion - Add to list - Batch item modification - Batch item deletion In each case the correct set of parameters should be passed to the batch operations. Test with reports which return only biblionumbers, only itemnumbers, and neither. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23197] Add more batch operation options to SQL report results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23197 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23094] Use Bootstrap-style pagination on staged MARC records page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23094 Katrin Fischer changed: What|Removed |Added Attachment #91375|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 91385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91385=edit Bug 23094: Use Bootstrap-style pagination on staged MARC records page This patch makes markup changes in order to make the pagination links on the staged MARC records page consistent with the links on the catalog search results page. To test properly you should have enough staged marc record batches that there are multiple pages to list. Go to Tools -> Manage staged MARC records. Test that the pagination links look consistent with the catalog search results page and that they work correctly. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23094] Use Bootstrap-style pagination on staged MARC records page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23094 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23221] Reindent tools/manage-marc-import.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23221 Katrin Fischer changed: What|Removed |Added Attachment #91298|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 91384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91384=edit Bug 23221: (follow-up) Add comments on markup structure This patch adds a few comments to the markup in order to highlight the structure of the page. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23221] Reindent tools/manage-marc-import.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23221 Katrin Fischer changed: What|Removed |Added Attachment #91297|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 91383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91383=edit Bug 23221: Reindent tools/manage-marc-import.tt This patch reformats the template for the Manage staged MARC records page. It makes only whitespace changes. It should have no effect on the behavior of the page. In addition to re-indentation, some lines have been broken up. These should be the only changes highlighted when using diff while ignoring whitespace. To test, apply the patch and view the Manage staged MARC records page. The page should look correct and work correctly: - Paging through results - Viewing batches - Cleaning batches - Deleting batches Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23221] Reindent tools/manage-marc-import.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23221 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23078] Use Koha.Preference in OPAC global header include
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #9 from Katrin Fischer ---
Hi Owen,
can you explain why those 2 lines in Auth.pm are still needed with patches
applied?
OpacAdditionalStylesheet =>
C4::Context->preference("OpacAdditionalStylesheet"),
opaclayoutstylesheet => C4::Context->preference("opaclayoutstylesheet"),
Also found these:
koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/help.tt:
koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/printslip.tt:
koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt:[% IF (
Koha.Preference('OpacFavicon') ) %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/help.tt:[% IF ( OPACUserCSS )
%][% OPACUserCSS | $raw %][% END %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt:[% IF (
Koha.Preference('OPACUserCSS') ) %][% Koha.Preference('OPACUserCSS') |
$raw %][% END %]
Can you please check?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22957] Remove type attribute from script tags: Staff client includes 1/2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22957] Remove type attribute from script tags: Staff client includes 1/2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957 Katrin Fischer changed: What|Removed |Added Attachment #91337|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 91382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91382=edit Bug 22957: Remove type attribute from script tags: Staff client includes 1/2 This patch removes the "type" attribute from
[Koha-bugs] [Bug 22951] Markup error in OPAC holds template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 Katrin Fischer changed: What|Removed |Added Attachment #91366|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 91381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91381=edit Bug 22951: (follow-up) Fix indentation This patch fixes indentation related to the markup corrections in the previous patch. It contains no textual changes. Signed-off-by: Mark Tompsett Signed-off-by: Nadine Pierre Signed-off-by: frederik chenier Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22951] Markup error in OPAC holds template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 Katrin Fischer changed: What|Removed |Added Attachment #91365|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 91380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91380=edit Bug 22951: Markup error in OPAC holds template This patch makes minor markup changes to the OPAC holds template in order to fix validation errors. To test, apply the patch and go through the process of placing a hold in the OPAC. Test various aspects of the process, including cases where the hold is blocked and an error message is displayed (for instance, when there are no items to be placed on hold). The page should work correctly and validating the source should return no relevant errors. Signed-off-by: Mark Tompsett Signed-off-by: frederik chenier Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22951] Markup error in OPAC holds template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23237] Plugin allow [% INCLUDE %] from template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |frede...@tamil.fr |ity.org | CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
