[Koha-bugs] [Bug 23402] Similar to #19706: Item search doesn't work with screen selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23402 Anke changed: What|Removed |Added Status|NEW |In Discussion Severity|major |minor --- Comment #8 from Anke --- Tried some demo installations from https://koha-community.org/demo/: - Español, Italian, French: Itemsearch works well - Swiss as well as "German" German: Itemsearch fails but returns a different error message from ours: "Internal Server Error" (see: http://koha.adminkuhn.ch:8080/). So the problem really seems to be only in the German interface. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23352] Set serial issue default values when creating a subscription in serials/subscription-add.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 --- Comment #8 from Alex Buckley --- Created attachment 91986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91986&action=edit Bug 23352: Default setting of item price, replacement price, ccode, dateaccesioned in serials-edit.pl This patch contains: * Database and DBIx changes * Setting 952g (items.price) and 952v (items.replacementprice) from Acquisitions module order unitprice and replacment cost respectively * Default setting of the 952d (items.dateaccessioned) on page load * New input in serials/subscription-add.pl for librarian to select default collection code for serial issues. * 2 new sysprefs: - DefaultToCreatingSerialIssuesOnReceival - Disabled by default. When enabled it sets the 'Create an item record when receiving this serial' to be ticked. - PopulateNewItemDateAccessionedOnPageLoad - Disabled by default. When enabled it populates the 952$d Date Acquired field in the item addition page without the cataloguer having to click in the field. Test plan: 1. Enter mysql terminal: sudo koha-mysql 2. Run the query: describe subscription; 3. Notice there is no 'ccode' column after the 'mana_id' column 4. In the staff client go to Serials > New subscription 5. Notice the 'Do not create an item record when receiving this serial' radiobutton is ticked by default. Click the 'Create an item record when receiving this serial' radiobutton 6. Fill out all the required serial fields, set the library branch to a branch different to the library branch you are currently logged in as and click 'Save subscription' 7. Now go to the Acquisitions module. Add a new basket to a vendor Add to the basket and select 'From a subscription' Search for the subscription you created in steps 5-6 Set a quantity, vendor price of 2 and replacement cost of 3 Save the order 8. Go back to Serials and recieve an item for the subscription and notice that the item creation form that is loaded when you change the status from 'Expected' to 'Arrived' does not set defaults for: 952$8 - Collection code 952$d - Date accessioned - You must click in the input box to load a default value for this 952$g - Cost 952$v - Replacement price Also note the 952$a and 952$b are set the library you set in the subscription and not the branch you are currently logged in as 9. Exit mysql terminal and apply patch 10. Navigate to the installer/data/mysql directory 11. Enter koha-shell: sudo koha-shell 12. Run: ./updatedatabase.pl 13. Notice 2 atomicupdates run without errors 14. Exit koha-shell and re-enter mysql terminal and confirm the 'ccode' column is in the subscription table now after mana_id column Exit the MySQL terminal. 15. In the Koha staff client > Administration > Global System Preferences and notice there is a new syspref in the 'Serials' system preferences named 'DefaultToCreatingSerialIssuesOnReceival' and there is a new syspref in the 'Cataloging' system preferences named - PopulateNewItemDateAccessionedOnPageLoad Notice both are disabled by default. 16. Repeat steps 4-8. Notice there is now a new input in the subscription-add.pl page 2: 'Serial issue Collection' which populates with the contents of the ccode authorised value Notice upon receiving the item the following fields do have a default value now: 952$8 - Collection code 952$g - Cost 952$v - Replacement price 17. Go back to Administration > Global System Preferences and set the 'DefaultToCreatingSerialIssuesOnReceival' and 'PopulateNewItemDateAccessionedOnPageLoad' syspref to 'Enabled' 18. Go back to Serials > New subscription and observe the 'Create an item record when receiving this serial' radiobutton is now checked by default 19. After creating the subscription repeat step 7 and now receive the serial and notice that the 952d Date Acquired is set automatically to todays date in the format: -MM-DD (i.e. you don't have to click in the field). 20. Try clicking in the 952d and notice no second date is appended 21. Sign off :) Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23352] Set serial issue default values when creating a subscription in serials/subscription-add.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23402] Similar to #19706: Item search doesn't work with screen selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23402 Anke changed: What|Removed |Added Severity|minor |normal --- Comment #9 from Anke --- Set severity to Normal as it's limited to one language, hope that's OK? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23352] Set serial issue default values when creating a subscription in serials/subscription-add.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 Alex Buckley changed: What|Removed |Added Change sponsored?|--- |Sponsored --- Comment #9 from Alex Buckley --- Hi Katrin, The above patch addresses your points as follows: 1. Already existing behaviour - 952h is set to the next appropriate serial numbering pattern value as you supposed When a branch is set in the subscription that is set as the 952a (Home branch) and 952b (holding branch) instead of the branch that the user is logged in on - this is existing behaviour in Koha What this patch does is: 1. Adds a 'Serial Issue Collection' input in the serials/subscription-add.pl where librarians can set a collection code to be set as default for all serial issues 952$8 Collection Code 2. Populating the item creation form with order cost data (set in the Acquisition module and stored in the aqorders table) * Automatic display of the aqorder.price in the 952g Item price * Automatic display of the aqorder.replacementprice in the 952v Replacement price 3. Added two new sysprefs: * DefaultToCreatingSerialIssuesOnReceival - Disabled by default. When enabled it sets 'Create an item record on receiving this serial' * PopulateNewItemDateAccessionedOnPageLoad - Disabled by default. When enabled it fills the 952d Date Acquired field on page load rather than the librarian having to click in the field. What this means is when an order exists and the PopulateNewItemDateAccessionedOnPageLoad syspref is enabled then the following fields are filled by default when receiving an order (as long as the 'Create an item record on receiving this serial' is enabled): 952$8 Collection Code 952a Home branch 952b Holding branch 952d Date Acquired 952$h Serial Enumeration 952$g Price 952v Replacement price So all that needs adding is barcode, this will make for a faster serial cataloguing process. Thanks very much, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9273] Add price and replacement price fields to subscriptions for auto-populating items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9273 Alex Buckley changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Alex Buckley --- Rather than adding two new fields price and replacement price to the subscription table we decided to auto-populate items from the aqorders.unitprice and aqorders.replacementprice defined when adding the subscription to a order. This further builds on Bug 5343 *** This bug has been marked as a duplicate of bug 23352 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23352] Set serial issue default values when creating a subscription in serials/subscription-add.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 Alex Buckley changed: What|Removed |Added CC||neng...@gmail.com --- Comment #10 from Alex Buckley --- *** Bug 9273 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5343] Subscription cost (Link serial and acqui modules)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Alex Buckley changed: What|Removed |Added Blocks||23352 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 [Bug 23352] Set serial issue default values when creating a subscription in serials/subscription-add.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23352] Set serial issue default values when creating a subscription in serials/subscription-add.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 Alex Buckley changed: What|Removed |Added Depends on||5343 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 [Bug 5343] Subscription cost (Link serial and acqui modules) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23243] Allow filtering out of historic subscription expirations in the check expiration of serials page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243 --- Comment #4 from Martin Renvoize --- Hmm, I just ran the QA scripts here and can't replicate the failures.. Will try to grab you on IRC later Katrin and see if we can replicate it together. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23352] Set serial issue default values when creating a subscription in serials/subscription-add.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 Alex Buckley changed: What|Removed |Added Attachment #91985|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Josef Moravec changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19008] More database cleanups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 --- Comment #37 from Fridolin SOMERS --- @Magnus Merci beaucoup ;) = Thanks a lot -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23425] Search explodes with "invalid data, cannot decode object"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23425 Rudolf Byker changed: What|Removed |Added CC||rudolfby...@gmail.com --- Comment #5 from Rudolf Byker --- Adding the Marc XML error is great, but there is still no way to fix the marc record from the web interface when this happens. I'm not advocating that the error be hidden (bad), but the "exploding" as you call it is worse. The correct way is to tell the user what went wrong, without breaking the UI, and giving them a way to fix the data in the UI. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23396] Rancor fails to load: insert_copyright is not defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23396 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21518] Material type "three-dimensional artifact" displays as "visual material"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21518 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10492] Translation problems with TT directives in po files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10492 --- Comment #9 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14549] Hold not removed when item is checked out to patron who is not next in priority list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14549 --- Comment #16 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23396] Rancor fails to load: insert_copyright is not defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23396 --- Comment #8 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21518] Material type "three-dimensional artifact" displays as "visual material"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21518 --- Comment #6 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14549] Hold not removed when item is checked out to patron who is not next in priority list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14549 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10492] Translation problems with TT directives in po files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10492 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23426] New: Empty AV field returned in Patron Info in addition to those requested
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23426 Bug ID: 23426 Summary: Empty AV field returned in Patron Info in addition to those requested Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: colin.campb...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com If fine items are requested in a patron info request, they are returned but an additional, always empty AV field is also returned. e.g. request is for fine items with start = 1 and stop = 1 instead of returning AVFirst items description| client receives AVFirst items description|AV| cause an off by one error in fine items - patch to follow -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #12 from Andrew Isherwood --- Created attachment 91990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91990&action=edit Bug 23112: Update request status on return This patch updates a request's status to RET upon return -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #13 from Andrew Isherwood --- Created attachment 91991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91991&action=edit Bug 23112: Add unit tests This patch adds unit test for the new Koha::Illrequest::check_out method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #11 from Andrew Isherwood --- Created attachment 91989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91989&action=edit Bug 23112: Add permission checks We only want the ILL circulation functionality to be available if the appropriate syspref and perm are available, this patch adds those checks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #9 from Andrew Isherwood --- Created attachment 91987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91987&action=edit Bug 23122: Add CirculateILL syspref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #10 from Andrew Isherwood --- Created attachment 91988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91988&action=edit Bug 23112: Add circulation to ILL requests This patch adds the ability to circulate ILL requests. Once a request has a suitable status, a "Check out" button is displayed on the "Manage request" toolbar. Clicking this will enable the user to check out the item either to the user who made the request or an in-house statistical user. A due date can be specified, but if not circ rules are used. Prior to the check out, an item is created which is attached to the biblio record that was created when the request was added -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23427] New: Better sorting of previous checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23427 Bug ID: 23427 Summary: Better sorting of previous checkouts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com In patron circulation or details page, previous checkouts are displayed sorted by due date. Actual sort order is not honoring system preference "previousIssuesDefaultSortOrder". Todays's checkouts is correct thanks to Bug 13908. Many checkouts may have same due date so it would be better to sort on timestamp as second sort criteria, like todays's checkouts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23427] Better sorting of previous checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23427 Fridolin SOMERS changed: What|Removed |Added Depends on||13908 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13908 [Bug 13908] Checkouts table sorting is not honoring default sort preferences -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #14 from Andrew Isherwood --- This development has been carried out according to the originally stated requirements of the customer that sponsored it, detailed here: https://wiki.koha-community.org/wiki/ILL_Circulation_RFC Test plan: 1. Ensure the FreeForm ILL backend is available 2. Enable the "CirculateILL" syspref 3. Ensure you have a statistical patron category defined (patron category type "Statistical") 4. Ensure you have at least one patron in your statistical patron category 5. Create a new FreeForm request (make a note of the library you select when creating it) 6. Mark the new request as confirmed by clicking the "Confirm request" button on the "Manage ILL request" page 7. TEST: Observe that a "Check out" button is now displayed in the request toolbar 8. Click the "Check out" button in the "Manage ILL request" page 9. In the "Issue requested item to..." screen: a. Do not select a statistical patron at this time b. You can at this point choose an item type, this will determine the type of the item that will be created for this request c. TEST: Observe that the default selected "Library" matches that that was defined when creating the request d. Do not select a due date at this time 10. Click "Submit" 11. TEST: Observe that the "Item checked out" screen displays, issued to the requesting patron with a due date corresponding to appropriate circ rules 12. Click "Return to request" 13. TEST: Observe that the request's status is now "Checked out" 14. Click the "Bibliographic record ID" link 15. TEST: Observe that the bibliographic record now has one item attached to it which is checked out 16. TEST: Observe that the item barcode is "ILL-" + the ILL request ID 17. Return to step 5., however, this time select a statistical patron and test that the item use is recorded and the item is not issued 18. Return to step 5., however, this time manually select a due date and test that the item's due date is set correctly on check out 19. Check in the item 20. TEST: Observe that the request's status is updated to "Returned to library" 21. Now implement a restriction on the patron (perhaps a fine) which would prevent them from checking out an item 22. Return to step 5. follow the instructions to step 10. 23. TEST: Observe that a banner is displayed at the top of the screen informing you that there was a problem checking the item out, containing a link to the patron's account page 24. Resolve the problem with the patron's account 25. Return to step 8. 26. TEST: Observe that the item is now successfully checked out 27. Disable the "CirculateILL" syspref 28. Return to step 5. at step 7. Observe that the "Check out" button is NOT displayed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23427] Better sorting of previous checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23427 Fridolin SOMERS changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13908] Checkouts table sorting is not honoring default sort preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13908 Fridolin SOMERS changed: What|Removed |Added Blocks||23427 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23427 [Bug 23427] Better sorting of previous checkouts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23425] Search explodes with "invalid data, cannot decode object"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23425 --- Comment #6 from Jonathan Druart --- (In reply to Rudolf Byker from comment #5) > Adding the Marc XML error is great, but there is still no way to fix the > marc record from the web interface when this happens. I'm not advocating > that the error be hidden (bad), but the "exploding" as you call it is worse. > The correct way is to tell the user what went wrong, without breaking the > UI, and giving them a way to fix the data in the UI. I wanted first to understand why the data was wrong (encoding, badly formatted, etc.) That's why I have attached a "debug patch". Then I will provide a more global fix. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23426] Empty AV field returned in Patron Info in addition to those requested
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23426 Colin Campbell changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell --- Created attachment 91992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91992&action=edit Patch correcting extraction of items Patch to convert start and end to zero based offsets consistently, and use end as terminus condition for the for loop using them. To test, unpatched an extra AV field is returned with the patch applied the correct number is returned (start and end are sequence numbers based on 1 and indicating the first and last item to be returned) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23427] Better sorting of previous checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23427 Fridolin SOMERS changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23427] Better sorting of previous checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23427 --- Comment #1 from Fridolin SOMERS --- Created attachment 91993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91993&action=edit Bug 23427: fix previous checkouts sort order In patron circulation or details page, previous checkouts are displayed sorted by due date. Actual sort order is not honoring system preference "previousIssuesDefaultSortOrder". Todays's checkouts is correct thanks to Bug 13908. Patch adds comments that refer to the text of system preferences "previousIssuesDefaultSortOrder" and "TodayIssuesDefaultSortOrder" : latest to earliest = asc earliest to latest = desc Test plan : 1) Create for a patron two old issues with a few days between them 2) Set preference previousIssuesDefaultSortOrder = "latest to earliest" 3) Go to patron circulation page and check sort order is OK 4) Go to patron details page and check sort order is OK 5) Set preference previousIssuesDefaultSortOrder = "earliest to latest" 6) Go to patron circulation page and check sort order is OK 7) Go to patron details page and check sort order is OK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23427] Better sorting of previous checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23427 --- Comment #2 from Fridolin SOMERS --- Created attachment 91994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91994&action=edit Bug 23427: Better sorting of previous checkouts In patron circulation or details page, previous checkouts are displayed sorted by due date. Many checkouts may have same due date so it would be better to sort on timestamp as second sort criteria, like todays's checkouts. Test plan : 1) Create for a patron two issues with same due date and a few seconds between them 2) Create another issue with a different due date 3) Come back a day later 4) Set preference previousIssuesDefaultSortOrder = "latest to earliest" 5) Go to patron circulation page and check sort order is OK : sorted by "Due date" then "Cheked out on" 6) Go to patron details page and check sort order is OK : sorted by "Due date" then "Cheked out on" 7) Set preference previousIssuesDefaultSortOrder = "earliest to latest" 8) Go to patron circulation page and check sort order is OK : sorted by "Due date" then "Cheked out on" 9) Go to patron details page and check sort order is OK : sorted by "Due date" then "Cheked out on" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Jonathan Druart changed: What|Removed |Added Blocks||23428 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23428 [Bug 23428] Self registration with a verification by email is broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23428] New: Self registration with a verification by email is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23428 Bug ID: 23428 Summary: Self registration with a verification by email is broken Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: OPAC Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Depends on: 23151 By bug 23151 DBIx::Class::Row::store_column(): No such column 'changed_fields' on Koha::Schema::Result::Borrower at /home/vagrant/kohaclone/Koha/Object.pm line 75 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 [Bug 23151] Patron self modification sends null dateofbirth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Martin Renvoize changed: What|Removed |Added Text to go in the|Sponsored by the National |Important Note: release notes|Library of Finland. |misc/batchRebuildBiblioTabl |Keywords to MARC mapping|es.pl should be run, after |functionality has been |this enhancement is |replaced with additional|applied, to populate the |Koha fields in the |fields in the database, and |bibliographic framework. |it will take some time for ||larger databases. |The keyword mapping only| |offered a single field, |Keywords |subtitle, and the |to MARC mapping |information was always |functionality has been |retrieved from the MARC |replaced with additional |record, which made it |Koha fields in the |relatively slow. The|bibliographic framework. |subtitle and other relevant | |fields are now available as |The keyword mapping only |normal Koha fields: |offered a single field, | |subtitle, and the |- |information was always |biblio.medium - Medium |retrieved from the MARC |information (MARC 21: 245h, |record, which made it |UNIMARC: 200b) |relatively slow. The |- |subtitle and other relevant |biblio.subtitle - Subtitle |fields are now available as |(MARC 21: 245b, UNIMARC:|normal Koha fields: |200e) | |- biblio.part_number|- |- Part number (MARC 21: |biblio.medium - Medium |245n, UNIMARC: 200h) |information (MARC 21: 245h, |- |UNIMARC: 200b) |biblio.part_name - Part |- |name (MARC 21: 245p,|biblio.subtitle - Subtitle |UNIMARC: 200i) |(MARC 21: 245b, UNIMARC: | |200e) |The |- biblio.part_number |subfields in the default|- Part number (MARC 21: |framework are automatically |245n, UNIMARC: 200h) |updated to include these|- |new fields unless they are |biblio.part_name - Part |already mapped to another |name (MARC 21: 245p, |Koha field. |UNIMARC: 200i) | | |Note that |The |misc/batchRebuildBiblioTabl |subfields in the default |es.pl needs to be run to|framework are automatically |populate the fields in the |updated to include these |database, and it will take |new fields unless they are |some time for larger|already mapped to another |databases. |Koha field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #234 from Martin Renvoize --- This is a great improvement and cleanup, thanks Ere and all who tested it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #235 from Martin Renvoize --- PS, I moved sponsorship attribution into the git commit message.. should appear in release notes nicely still (and also get recorded to go into the about page at a later date) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23428] Self registration with a verification by email is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23428 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23428] Self registration with a verification by email is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23428 --- Comment #1 from Jonathan Druart --- Created attachment 91995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91995&action=edit Bug 23428: (bug 23151 follow-up) Fix self registration with a verification email DBIx::Class::Row::store_column(): No such column 'changed_fields' on Koha::Schema::Result::Borrower at /home/vagrant/kohaclone/Koha/Object.pm line 75 Test plan: - Turn PatronSelfRegistrationVerifyByEmail on - Register a new account - Click on the link (see the message_queue table) => Without this patch you get the error => With this patch you will see the login form -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23099] OPAC Search result sorting "go" button flashes on page load
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23099 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Attachment #91723|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Ian Walls changed: What|Removed |Added CC||i...@bywatersolutions.com --- Comment #4 from Ian Walls --- I'm in the process of reviewing this patch. The unit tests pass without incident. Unfortunately, I'm getting a 400 error with the message "Expected object - got null." when POSTing to the endpoint. Not sure if it's my set up or not. Once this is conquered, it would be helpful to have more information about what behavior to expect from requests with the other specified parameters. Can they introduce other response codes in certain circumstances (such as 'cancel_reserve' = 'foo'), etc. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23099] OPAC Search result sorting "go" button flashes on page load
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23099 --- Comment #4 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23099] OPAC Search result sorting "go" button flashes on page load
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23099 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #236 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #35 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23386] Add language of original in advanced search - staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23386 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23386] Add language of original in advanced search - staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23386 --- Comment #4 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23253] OpacNavRight does not display if opacuserlogin disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 --- Comment #1 from Jonathan Druart --- Created attachment 91996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91996&action=edit Bug 23253: (bug 22318 follow-up) Fix OpacNavRight even if opacuserlogin is off There are other occurrences of OpavNavRight that bug 22318 forgot to adjust to use the news system instead of the syspref. Test plan: - turn off opacuserlogin - create a news for OpacNavRight - go to the opac main page => Confirm that the OpacNavRight content is displayed correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23253] OpacNavRight does not display if opacuserlogin disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 --- Comment #2 from Jonathan Druart --- Created attachment 91997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91997&action=edit Bug 23253: Fix OpacNavRight for self reg by email The code expects to display OpacNavRight content at the bottom of the login form when a user just registered. Test plan: - Turn PatronSelfRegistrationVerifyByEmail on - Register a patron - Confirm by clicking on the link you received by email (or see the message_queue table) => The OpacNavRight content should be displayed QA Note: This code smells, the code in the pl should not be needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23253] OpacNavRight does not display if opacuserlogin disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23253] OpacNavRight does not display if opacuserlogin disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 Jonathan Druart changed: What|Removed |Added Assignee|oleon...@myacpl.org |jonathan.dru...@bugs.koha-c ||ommunity.org CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23429] New: ilsdi.pl GetRecords documentation does not match output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23429 Bug ID: 23429 Summary: ilsdi.pl GetRecords documentation does not match output Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: j.p.kni...@lboro.ac.uk QA Contact: testo...@bugs.koha-community.org The ILS-DI GetRecords self generated documentation no longer matches up with the output that the script generates. It probably should. :-) For example, the documentation says that the element contains a element. This was the case back in 16.x versions of Koha, but on our production 18.11.04 we no longer get this field, but we do get an field in item instead (which luckily serves the same purpose as we need - we just need to know if each item is on loan or not). Here's the example format for the part of the record generated by http://ourserver/cgi-bin/koha/ilsdi.pl?service=Describe&verb=GetRecords 1 0 Bibliothèque Jean Prunier 0 2008-08-20 1 Secteur Adulte R ABE 0 2008-08-20 BIB Bibliothèque Jean Prunier 1 BIB 2008-08-20 17:15:51 0 R_ABE 2008-08-20 And here's what we get out for an actual search: 2019-10-01 MAINLIB MAIN 2019-07-18 526315 MAIN 2019-07-18 0 LONG 0 526315 847332 22.17 2016-09-13 10 Main Library MAINLIB 2019-07-18 17:03:03 005_550_SPS_BRA 0 28 040444587X 0 2018-02-01 005.55 SPS/BRA Main Library Note the in the example is missing from the real output, which has ... instead. I guess we need to decide if the documentation is just out of date with the code, or if the code should be generating things it isn't any more. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23210] login4tags should be a link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23210] login4tags should be a link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Owen Leonard changed: What|Removed |Added Attachment #91945|0 |1 is obsolete|| --- Comment #5 from Owen Leonard --- Created attachment 91998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91998&action=edit Bug 23210: login4tags should be a link and included in every search result TEST PLAN: 1. Make sure TagsEnabled and TagsInputOnList are set to allow. 2. Don't be logged into the OPAC. 3. Make a search and notice the 'Log in to add tags' text is not a link on the results page. 4. Apply patch 5. Refresh OPAC results page 6. 'Log in to add tags' takes you to the login page. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23210] login4tags should be a link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 --- Comment #6 from Owen Leonard --- Created attachment 91999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91999&action=edit Bug 23210: (follow-up) Log in for tags link should trigger modal This patch modifies the "Log in to add tags" link on the OPAC search results page, adding the class which is used elsewhere in the OPAC templates for triggering the login modal. Also: Removed an unnecessary period. To test, apply the patch and follow the original test plan. Clicking the "Log in to add tags" link should trigger the login modal. After logging in you should be returned to the page you were on. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #91987|0 |1 is obsolete|| --- Comment #15 from Andrew Isherwood --- Created attachment 92000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92000&action=edit Bug 23122: Add CirculateILL syspref Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #91989|0 |1 is obsolete|| --- Comment #17 from Andrew Isherwood --- Created attachment 92002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92002&action=edit Bug 23112: Add permission checks We only want the ILL circulation functionality to be available if the appropriate syspref and perm are available, this patch adds those checks. Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #91990|0 |1 is obsolete|| --- Comment #18 from Andrew Isherwood --- Created attachment 92003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92003&action=edit Bug 23112: Update request status on return This patch updates a request's status to RET upon return Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #91988|0 |1 is obsolete|| --- Comment #16 from Andrew Isherwood --- Created attachment 92001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92001&action=edit Bug 23112: Add circulation to ILL requests This patch adds the ability to circulate ILL requests. Once a request has a suitable status, a "Check out" button is displayed on the "Manage request" toolbar. Clicking this will enable the user to check out the item either to the user who made the request or an in-house statistical user. A due date can be specified, but if not circ rules are used. Prior to the check out, an item is created which is attached to the biblio record that was created when the request was added Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #91991|0 |1 is obsolete|| --- Comment #19 from Andrew Isherwood --- Created attachment 92004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92004&action=edit Bug 23112: Add unit tests This patch adds unit test for the new Koha::Illrequest::check_out method Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart changed: What|Removed |Added Attachment #90103|0 |1 is obsolete|| Attachment #90104|0 |1 is obsolete|| Attachment #90105|0 |1 is obsolete|| Attachment #90106|0 |1 is obsolete|| Attachment #90107|0 |1 is obsolete|| Attachment #90108|0 |1 is obsolete|| Attachment #90109|0 |1 is obsolete|| Attachment #90110|0 |1 is obsolete|| --- Comment #20 from Jonathan Druart --- Created attachment 92005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92005&action=edit Bug 22544: Move get_opac_new to Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #21 from Jonathan Druart --- Created attachment 92006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92006&action=edit Bug 22544: Move get_opac_news to Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #24 from Jonathan Druart --- Created attachment 92009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92009&action=edit Bug 22544: Move add_opac_item to Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #44 from Liz Rea --- It appears this patch isn't commpatible with hiding the date of birth using PatronSelfModificationBorrowerUnwantedField - if the field isn't on the screen, it's still going to blank the DOB. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #22 from Jonathan Druart --- Created attachment 92007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92007&action=edit Bug 22544: Move del_opac_new to Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #23 from Jonathan Druart --- Created attachment 92008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92008&action=edit Bug 22544: Move upd_opac_new to Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #25 from Jonathan Druart --- Created attachment 92010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92010&action=edit Bug 22544: Move GetNewsToDisplay to Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #26 from Jonathan Druart --- Created attachment 92011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92011&action=edit Bug 22544: Add tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #27 from Jonathan Druart --- Created attachment 92012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92012&action=edit Bug 22544: Refactor searching of news items Test plan: 1) Go to tools and define some news 2) Try different parameters, try to edit new items, and delete some 3) Go to all places where news are presented and ensure that there are the right ones shown: opac main page - based on language opac righ column (formerly syspref OpacNavRight) - based on language opac news rss feed circulation slip (not quick slip) intranet main page 4) run tests: prove t/db_dependent/Koha/News.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23430] New: News not inserted with SQL strict modes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23430 Bug ID: 23430 Summary: News not inserted with SQL strict modes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org DBD::mysql::st execute failed: Incorrect integer value: '' for column 'number' at row 1 [for Statement "INSERT INTO opac_news ( title,timestamp,lang,branchcode,content,borrowernumber,number,expirationdate ) VALU ES ( ?,?,?,?,?,?,?,? )" with ParamValues: 0="OpacNavRight", 1='2019-08-05', 2="OpacNavRight_en", 3=undef, 4="this is the opac nav right", 5="51", 6="", 7=undef] at /home/vagrant/kohaclone/C4/NewsChannels. pm line 68. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23430] News not inserted with SQL strict modes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23430 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22544 Blocks||17258 --- Comment #1 from Jonathan Druart --- Will be fixed by bug 22544. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23430 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Jonathan Druart changed: What|Removed |Added Depends on||23430 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23430 [Bug 23430] News not inserted with SQL strict modes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23328] Some check-in messages should be dismissable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23328 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23328] Some check-in messages should be dismissable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23328 --- Comment #4 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23237] Plugin allow [% INCLUDE %] from template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23237] Plugin allow [% INCLUDE %] from template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23328] Some check-in messages should be dismissable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23328 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Liz Rea changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23431 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23431] New: having Date of birth in PatronSelfModificationBorrowerUnwantedField causes DOB to be nullified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23431
Bug ID: 23431
Summary: having Date of birth in
PatronSelfModificationBorrowerUnwantedField causes DOB
to be nullified
Change sponsored?: ---
Product: Koha
Version: 18.11
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: OPAC
Assignee: oleon...@myacpl.org
Reporter: wizzy...@gmail.com
QA Contact: testo...@bugs.koha-community.org
Similar to bug 23151, if DOB is a field removed by
PatronSelfModificationBorrowerUnwantedField, the date of birth gets nullified
when the changes are submitted.
To replicate:
Turn on OPACPatronDetails
put dateofbirth in PatronSelfModificationBorrowerUnwantedField
Have a patron with a set date of birth
Attempt any modification on that patron through the OPAC
The date of birth will be one of the fields changed for that borrower when you
check it in the OPAC.
A work around is to remove dateofbirth from
PatronSelfModificationBorrowerUnwantedField
and hide the field from that form, if that is desired, with jquery; something
like
$("#opac-patron-update #memberentry_identity > ol:nth-child(2) >
li:nth-child(3)").hide();
Note that it is .hide() and not .remove(). .remove() will cause the same
behaviour as DOB being in PatronSelfModificationBorrowerUnwantedField.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23431] having Date of birth in PatronSelfModificationBorrowerUnwantedField causes DOB to be nullified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23431 Liz Rea changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23151 CC||wizzy...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23237] Plugin allow [% INCLUDE %] from template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Attachment #91374|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23237] Plugin allow [% INCLUDE %] from template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237 --- Comment #6 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 --- Comment #15 from Jonathan Druart --- Remote branch rebased against master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18712] make test is failing with an empty DB - t/Matcher.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712 Jonathan Druart changed: What|Removed |Added CC||olli-antti.kivila...@jns.fi --- Comment #17 from Jonathan Druart --- *** Bug 18224 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18224] Cleanup after Bug 14778
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18224 Jonathan Druart changed: What|Removed |Added Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Jonathan Druart --- Nope, the fixture has been removed by commit 2c69ff0b0dfb89480212703e82b06d6877d86c99 Bug 18712: Remove unecessary fixtures *** This bug has been marked as a duplicate of bug 18712 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23339] Reindent addbooks.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339 Owen Leonard changed: What|Removed |Added Attachment #91867|0 |1 is obsolete|| Attachment #91868|0 |1 is obsolete|| --- Comment #7 from Owen Leonard --- Created attachment 92013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92013&action=edit Bug 23339: Reindent addbooks.tt This patch reindents cataloguing/addbooks.tt to use four spaces, following coding guidelines. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but you should look into your own heart for the right solution. Go to Cataloging. Test that the initial page and search results view look correct and work correctly. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23339] Reindent addbooks.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339 --- Comment #8 from Owen Leonard --- Created attachment 92014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92014&action=edit Bug 23339: (follow-up) Markup comments and corrections This patch adds comments to the template to highlight the markup structure. It also removes the obsolete "type" attribute from the
[Koha-bugs] [Bug 23339] Reindent addbooks.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23339] Reindent addbooks.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339 --- Comment #9 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 SiobhanC changed: What|Removed |Added CC||siobhancot...@gmail.com --- Comment #3 from SiobhanC --- Having an Opening Hours element to the Calendar would be useful for us, we have a few lapsafe machines that show the date and time of return on the machine - it currently says that laptops are due back at 23:59 because the circ rules say that they are loaned for 0 days (i.e. same day return). This is misleading as the libraries are not open at that time. In our scenario, the item would have to be due back before the library closes, which is different from what Nicole mentions. This could work in a similar way to the hard due date in the circ rules, it would be a hard due time for a particular item type. Lapsafe are not able to alter the display, and I'm not aware of a way in which Koha can exclude a time element from the issue transaction. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
