[Koha-bugs] [Bug 23435] Add multiple copies of an item when receiving in serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23435 --- Comment #1 from Aleisha Amohia --- Created attachment 92100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92100=edit Bug 23435: Add multiple copies of an item when receiving in serials This feature allows you to add multiple item records when receiving a serial, if the subscription is set to 'create item record when receiving serials'. Please note this is not the same as multi-receiving, more like multi-adding! To test: 1) Create a subscription, ensure the 'Create an item record when receiving this serial' option is selected 2) Receive a serial 3) Expand the item form by selecting 'click to add item' 4) Fill in details, including a barcode. Leave 'number of copies' as 1 and Save. 5) Confirm the serial is received as expected. 6) In another tab, open the bibliographic record attached to this subscription 7) Confirm the item record was created upon receiving the serial 8) Go back to the serial collection and receive next serial 9) Expand the item form by selecting 'click to add item' 10) Fill in details again, this time change 'number of copies' to a different number e.g. 3, and Save 11) Confirm the serial is received as expected. 12) Check back at the biblio record that 3 item records were created and the barcode was incremented for each additional item. Sponsored-by: Brimbank City Council -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23435] Add multiple copies of an item when receiving in serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23435 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20270] SIP2 Connection Issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20270 malldinn changed: What|Removed |Added CC||kamall...@yahoo.com.sg --- Comment #1 from malldinn --- I am in koha 18.11 i got the same problem. once i am using the selfcheck the ezproxy that connect using SIP cannot login -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23066] Add foreign key for issues tables to branches table for branchcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23066 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #5 from David Cook --- This makes me so happy. I was just about to report this, so I'm glad to see the issue and a patch. I'm in a rush at the moment, but I'll make a note to come back to this to test and sign off. (I wish that there were an alternative to "SET NULL" for old_issues, but I don't think there is with our current architecture.) A library of ours got bitten by this. They moved their items to a new branch, deleted the old branch, but their issues are all for the old non-existent branch. I took a little look around and it seems like these might be the only relevant tables missing the foreign key relationship to the branches table. Once again, thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23388] Make system preferences links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23388 --- Comment #6 from Owen Leonard --- I've been working on an alternate patch which addresses one aspect of this bug: Linking easily to specific preferences. The proposed patch does two things I don't like: It breaks the previous behavior of the system preference names as . And the links don't make much sense unless you're looking at search results. In other circumstances clicking the link doesn't do anything. My proposal would be to show a link on hover: https://zivotdesign.com/p/view.php?p=15646746956636 Unfortunately my solution suffers from the same problem described by Nick: When the page jumps to the anchored link the pref is right at the top of the browser window, thus it's hidden by the floating toolbar. I worked to come up with a JavaScript solution but failed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23039] Hold found modal on checkin screen ( circulation.pl ) obscures Check in message info
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23039 --- Comment #7 from Owen Leonard --- Ed I'll double-check but the template markup is mostly just re-arranged so sounds should still work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1985] Email notification of new OPAC comments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #96 from Katrin Fischer --- 4) Method naming I believe we agreed on lower case using _ for dividing words for all methods in the new Koha namespace. SendReviewAlert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1985] Email notification of new OPAC comments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #95 from Katrin Fischer --- Thx for taking this up - also impressed with letters added for all translations :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1985] Email notification of new OPAC comments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #94 from Katrin Fischer ---
QA review:
1) Letter text
+We want to inform you that borrower <> has just created
a new comment on <>, which is biblionumber
<>.
Instead of telling the biblionumber in the text, why not add a link to the
record instead? To make this title more distinguishable we could also make use
of the new fields (subtitle, parts, number).
These seem a bit unusual and very developery for formatting:
+--- BEGIN COMMENT ---
+<>
+--- END COMMENT ---
I think using standard formatting or just - would work better here.
Signing a letter to the libray with 'the library' seems a little odd to me :)
2) Convert database update to .perl
The RM will be happier.
3) Capitalization
+('CommentModeratorsEmail','','','The email address where to send a
notification (template code COMMENT_CREATED) when a Borrower adds/modifies a
review/comment for a Biblio. Set to empty to disable sending email
notifications.','Textarea'),
Biblio and Borrower... Same for the description in the SQL statements.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23416] When a note to a specific issue upon receiving a serial, this note will appear in next issue received
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23416 Katrin Fischer changed: What|Removed |Added Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23416] When a note to a specific issue upon receiving a serial, this note will appear in next issue received
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23416 --- Comment #7 from Katrin Fischer --- I am ok with this fix, but I'd suggest to pick 'not prefill' for new installations. My feeling is that this will be the more common setting. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23416] When a note to a specific issue upon receiving a serial, this note will appear in next issue received
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23416 --- Comment #6 from Katrin Fischer --- Created attachment 92099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92099=edit Bug 23416: (QA follow-up) Add IGNORE to updatedatabase SQL statement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23416] When a note to a specific issue upon receiving a serial, this note will appear in next issue received
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23416 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23416] When a note to a specific issue upon receiving a serial, this note will appear in next issue received
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23416 Katrin Fischer changed: What|Removed |Added Attachment #91934|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 92098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92098=edit Bug 23416: Add PreserveSerialNotes system preference Bug 11492 intended to pass routinglists forward. It also passed forward serial notes. This may or not me desired behvaiour, to avoid changing functionality twice I add a syspref to control this behaviour. To test: 1 - Have or create a subscription in the serials module 2 - Recieve an issue, making sure ot ad a note 3 - Go to receive again, note the note from the last serial is set for the expected issue 4 - Apply patch 5 - Update database, restart all the things 6 - Receive the issue leaving the note in place 7 - Note the next expected issue has the note 8 - Find the syspref PreserveSerialNotes 9 - Confirm it defaulted to Do 10 - Set it to 'Do not' 11 - Receive the expected serial leavign the note 12 - Note the newly generated expected serial has no note 13 - prove -v t/db_dependent/Serials.t Signed-off-by: Nadine Pierre Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23416] When a note to a specific issue upon receiving a serial, this note will appear in next issue received
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23416 Katrin Fischer changed: What|Removed |Added Version|18.11 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11492] Receiving a serial item causes routing list notes to be lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11492 Katrin Fischer changed: What|Removed |Added Blocks||23416 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23416 [Bug 23416] When a note to a specific issue upon receiving a serial, this note will appear in next issue received -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23039] Hold found modal on checkin screen ( circulation.pl ) obscures Check in message info
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23039 --- Comment #6 from Ed Veal --- Owen, I am sure you have thought of this, (I have only watched your video) but we like to use custom sounds for different messages that the circ staff needs to know. To that end I am guessing you have added specific div or id so that we can use them to set up audio alerts. Ed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23416] When a note to a specific issue upon receiving a serial, this note will appear in next issue received
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23416 Katrin Fischer changed: What|Removed |Added Depends on||11492 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11492 [Bug 11492] Receiving a serial item causes routing list notes to be lost -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16349] Indicate what branches of Koha are supported
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16349 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #6 from Katrin Fischer --- 1) QA tools fail: FAIL Koha.pm FAIL critic # ControlStructures::ProhibitMutatingListFunctions: Got 1 violation(s). OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for 'current_versions' OK spelling OK valid 2) Also some wrong capitalization: Currently Supported Versions 3) In my master installation it only lists 19.05 and 18.11 - so only the ones we maintain packages for. But actually, we also maintain 18.05. Should we not list this as well? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19501] New list category to restrict specific lists to staff & hide from OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- There is a new shared flag for patron lists... maybe we could think of something similar for lists? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23390] Add placeholder syntax for column names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390 Katrin Fischer changed: What|Removed |Added Attachment #91918|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 92096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92096=edit Bug 23390: (QA follow-up) Don't redeclare variable Signed-off-by: George Williams Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23390] Add placeholder syntax for column names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390 Katrin Fischer changed: What|Removed |Added Attachment #91919|0 |1 is obsolete|| --- Comment #16 from Katrin Fischer --- Created attachment 92097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92097=edit Bug 23390: (follow-up) Quote aliases Signed-off-by: George Williams Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23390] Add placeholder syntax for column names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23390] Add placeholder syntax for column names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390 Katrin Fischer changed: What|Removed |Added Attachment #91917|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 92095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92095=edit Bug 23390: Introduce placeholder syntax for report column names This patch adds the ability to rename columns in MySQL reports using a syntax: [[column|alias]] To test: 1 - Write a report like: SELECT cardnumber FROM borrowers WHERE cardnumber LIKE '%9' 2 - Run report 3 - Note you can batch modify the patrons 4 - Update report: SELECT cardnumber AS library_barcode FROM borrowers WHERE cardnumber LIKE '%9' 5 - Run report 6 - Note batch options are no longer present 7 - Apply patch 8 - Run report, no change 9 - Update report like: SELECT [[cardnumber|library_barcode]] FROM borrowers WHERE cardnumber LIKE '%9' 10 - Run report 11 - Batch options work! 12 - Update report like: SELECT cardnumber FROM borrowers WHERE cardnumber LIKE '%9' 13 - Verify batch options still work 14 - Set report 'public' 15 - Verify report can be run via JSON URLs: http://kohadev.mydnsname.org:8080/cgi-bin/koha/svc/report?id=1 http://kohadev.mydnsname.org:8081/cgi-bin/koha/svc/report?id=1 Signed-off-by: George Williams Signed-off-by: George Williams Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19501] New list category to restrict specific lists to staff & hide from OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 robbi...@middlesex.mass.edu changed: What|Removed |Added CC||robbi...@middlesex.mass.edu --- Comment #2 from robbi...@middlesex.mass.edu --- The issue we have with the way lists are "shared" is that we cannot share it from within the staff client. We have to log in to the OPAC to share the lists with our colleagues. It would be nice to be able to have it shared as we create it - or, at least, shareable from within the staff client. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23390] Add placeholder syntax for column names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390 Katrin Fischer changed: What|Removed |Added Keywords||Manual --- Comment #13 from Katrin Fischer --- This will get easily lost if not documented - can we get a manual patch too? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23388] Make system preferences links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23388 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer --- Hi Nick, can you explain this bit please? FIXME: Note the floating toolbar actually breaks this because it hides the anchored pref. Add this CSS to IntrnateUSerCSS to fix it padding-top: 50px; margin-top: -50px; } Also: FAILkoha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt FAIL filters missing_filter at line 55 () wrong_html_filter at line 60 ([% NAME.name | html %]) wrong_html_filter at line 60 ([% NAME.name | html %]) missing_filter at line 60 ([% NAME.name | html %]) missing_filter at line 60 ([% NAME.name | html %]) wrong_html_filter at line 62 ([% NAME.name | html %]) wrong_html_filter at line 62 ([% NAME.name | html %]) missing_filter at line 62 ([% NAME.name | html %]) missing_filter at line 62 ([% NAME.name | html %]) wrong_html_filter at line 64 ([% NAME.name | html %]) wrong_html_filter at line 64 ([% NAME.name | html %]) missing_filter at line 64 ([% NAME.name | html %]) missing_filter at line 64 ([% NAME.name | html %]) FAIL forbidden patterns forbidden pattern: tab char (line 58) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23385] Hide default value fields by default on patron import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23385 Katrin Fischer changed: What|Removed |Added Attachment #91860|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 92094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92094=edit Bug 23385: (follow-up) Update link This follow-up adds a dummy href attribute to the link for showing and hiding the default values form so that it behaves more like a link. I removed "click to" from the link text and added Font Awesome icons common to "show/hide" links. Signed-off-by: George Williams Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23385] Hide default value fields by default on patron import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23385 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23039] Hold found modal on checkin screen ( circulation.pl ) obscures Check in message info
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23039 --- Comment #5 from Martha Fuerst --- Owen, from a user-standpoint, your fix is brilliant and does what it needs to do. I can't speak to anything back-end. Thanks so much! -Marti -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23039] Hold found modal on checkin screen ( circulation.pl ) obscures Check in message info
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23039 Owen Leonard changed: What|Removed |Added Version|unspecified |master Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | Status|NEW |ASSIGNED --- Comment #4 from Owen Leonard --- I've been working on a possible solution to this which moves check-in messages into the confirmation modals. I've posted a brief video here of how it looks: https://zivotdesign.com/p/uploads/big/3d6b8a24067f27a834d03b8e104d7a40.mp4 If there is no popup (no hold confirmation, no transfer), messages and/or errors will be displayed onscreen just like they have in the past. I'd love to hear opinions about it! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23434] Hold confirmation dialog problem if HoldsAutoFill is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23434 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23434] Hold confirmation dialog problem if HoldsAutoFill is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23434 Katrin Fischer changed: What|Removed |Added Attachment #92082|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 92093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92093=edit Bug 23434: Hold confirmation dialog problem if HoldsAutoFill is enabled This patch corrects a problem with hold confirmation dialogs on the checkin page when the HoldsAutoFill system preference is enabled and the item being checked in has a hold at another library. The confirmation dialog is converted to a modal to match other confirmation information. As part of this process two whole sections of the template have been removed because they were redundant. To test, apply the patch and test the following circumstances both with HoldsAutoFill enabled AND disabled: - A hold for a patron at your library - A hold for a patron not at your library - With HoldsAutoFill ON, both the "OK" and "Print slip and confirm" buttons should dismiss the modal without reloading the page. - A hold which is already marked 'Waiting' - An item which needs to be transferred - An item which has already been transferred In all cases the confirmation modal should appear with correct information. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23438] Use Font Awesome icons in intranet search results browser
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23438 Katrin Fischer changed: What|Removed |Added Attachment #92048|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 92092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92092=edit Bug 23438: Use Font Awesome icons in intranet search results browser In intranet after a search you see a results browser top left of biblio record details. Actually this uses text for links next and previous with a character for the arrows. I propose to use Font Awesome icons arrows. In fact the translated text is often too large for those buttons. For example "Previous" is "Préédant" in french and it causes the next and previous buttons to display on two lines. Using icons is more compact and easy to use. This patch also adds the list icon to back to results link and changes for a minimal text "Results". 1) Go to intranet 2) Perform a search with a few results 3) Click on first record 4) Check browser displays well 5) Click on next icon, check you go to next search result 6) Click on revious icon, check you go to previous search result 7) Click on "Results", you come back to search results 8) Clik on "Last" and click on last record 9) Check browser displays well Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23438] Use Font Awesome icons in intranet search results browser
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23438 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23321] Add 'tills' to the accounts system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 Martin Renvoize changed: What|Removed |Added Attachment #92065|0 |1 is obsolete|| --- Comment #26 from Martin Renvoize --- Created attachment 92091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92091=edit Bug 23321: Koha::Library additions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23321] Add 'tills' to the accounts system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 Martin Renvoize changed: What|Removed |Added Attachment #92064|0 |1 is obsolete|| --- Comment #25 from Martin Renvoize --- Created attachment 92090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92090=edit Bug 23321: (follow-up) Require cash registers for payments This follow-up catches the case where no cash registers have been defined for the current branch and as such payments cannot be processed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23321] Add 'tills' to the accounts system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 Martin Renvoize changed: What|Removed |Added Attachment #92062|0 |1 is obsolete|| --- Comment #23 from Martin Renvoize --- Created attachment 92088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92088=edit Bug 23321: Allow setting of branch default -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23321] Add 'tills' to the accounts system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 Martin Renvoize changed: What|Removed |Added Attachment #92063|0 |1 is obsolete|| --- Comment #24 from Martin Renvoize --- Created attachment 92089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92089=edit Bug 23321: Add cash register support to paycollect -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23321] Add 'tills' to the accounts system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 Martin Renvoize changed: What|Removed |Added Attachment #92061|0 |1 is obsolete|| --- Comment #22 from Martin Renvoize --- Created attachment 92087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92087=edit Bug 23321: Add cash register management Add in administrative interfaces to allow the management of cash registers. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23321] Add 'tills' to the accounts system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 Martin Renvoize changed: What|Removed |Added Attachment #92060|0 |1 is obsolete|| --- Comment #21 from Martin Renvoize --- Created attachment 92086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92086=edit Bug 23321: Add cash register permission -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23321] Add 'tills' to the accounts system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 Martin Renvoize changed: What|Removed |Added Attachment #92058|0 |1 is obsolete|| --- Comment #19 from Martin Renvoize --- Created attachment 92084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92084=edit Bug 23321: [DO NOT PUSH] DBIC Classes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23321] Add 'tills' to the accounts system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 Martin Renvoize changed: What|Removed |Added Attachment #92059|0 |1 is obsolete|| --- Comment #20 from Martin Renvoize --- Created attachment 92085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92085=edit Bug 23321: Add cash register preference -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23321] Add 'tills' to the accounts system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 Martin Renvoize changed: What|Removed |Added Attachment #92057|0 |1 is obsolete|| --- Comment #18 from Martin Renvoize --- Created attachment 92083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92083=edit Bug 23321: Add cash_registers table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23434] Hold confirmation dialog problem if HoldsAutoFill is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23434 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #7 from Martin Renvoize --- hmm.. try now? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23434] Hold confirmation dialog problem if HoldsAutoFill is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23434 Martin Renvoize changed: What|Removed |Added Attachment #92072|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 92082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92082=edit Bug 23434: Hold confirmation dialog problem if HoldsAutoFill is enabled This patch corrects a problem with hold confirmation dialogs on the checkin page when the HoldsAutoFill system preference is enabled and the item being checked in has a hold at another library. The confirmation dialog is converted to a modal to match other confirmation information. As part of this process two whole sections of the template have been removed because they were redundant. To test, apply the patch and test the following circumstances both with HoldsAutoFill enabled AND disabled: - A hold for a patron at your library - A hold for a patron not at your library - With HoldsAutoFill ON, both the "OK" and "Print slip and confirm" buttons should dismiss the modal without reloading the page. - A hold which is already marked 'Waiting' - An item which needs to be transferred - An item which has already been transferred In all cases the confirmation modal should appear with correct information. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23307] Add columns configuration to cataloguing/z3950_search.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23307 --- Comment #6 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23307] Add columns configuration to cataloguing/z3950_search.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23307 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22209] Move stock rotation stage and item forms into modals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22209 --- Comment #4 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22209] Move stock rotation stage and item forms into modals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22209 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23434] Hold confirmation dialog problem if HoldsAutoFill is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23434 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23434] Hold confirmation dialog problem if HoldsAutoFill is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23434 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer --- Patch doesn't apply for me :( Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 23434: Hold confirmation dialog problem if HoldsAutoFill is enabled error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt). error: could not build fake ancestor Patch failed at 0001 Bug 23434: Hold confirmation dialog problem if HoldsAutoFill is enabled The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-23434-Hold-confirmation-dialog-problem-if-Hold-wUIahn.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Maryse Simard changed: What|Removed |Added Attachment #91537|0 |1 is obsolete|| --- Comment #82 from Maryse Simard --- Created attachment 92081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92081=edit Bug 8643: Add important constraint to marc subfields This fix permits to add an "Important" option to the marc structure pages. Testing: 1) Apply the patch 2) Run updatedatabase.pl 3) Regenerate CSS 4) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 5) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 6) Edit a record to clear the field 100 (subfields are all blank) 7) Save the record. 8) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? Sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23402] Item search doesn't work with screen selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23402 --- Comment #15 from Katrin Fischer --- Glad to hear :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23307] Add columns configuration to cataloguing/z3950_search.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23307
Katrin Fischer changed:
What|Removed |Added
Attachment #91879|0 |1
is obsolete||
--- Comment #5 from Katrin Fischer ---
Created attachment 92080
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92080=edit
Bug 23307: Add columns configuration to cataloguing/z3950_search.tt
This patch adds columns configuration to the DataTable which displays
Z39.50 search results in the cataloging module.
The Z39.50 results screen has its own server-side paging system, so I
added some code to copy the page number information ("Page 2 / 6") to
the DataTable toolbar for a more consistent appearance. The wording of
that information has also been modified for consistency's sake.
To test, apply the patch and restart Plack (or restart_all on
kohadevbox)
- Go to Cataloging -> New from Z39.50/SRU.
- Perform a Z39.50 search which will return multiple pages of results.
- Confirm that the DataTable controls work correctly: Search, columns
show/hide, export.
- Confirm that the page number information is correct as you navigate
through pages of results.
- Go to Administration -> Columns settings.
- Confirm that the columns configuration settings for the z3950_search
table in the "Cataloging" section works correctly. Changes made here
should be reflected in the table of Z39.50 search results.
- Test other tables which use columns configuration to confirm that the
changes made in this patch doesn't disrupt their behavior. Test that
any custom columns configuration are applied. For example:
- Administration -> Libraries
- Reports -> Saved reports
- Circulation -> Holds queue
Signed-off-by: George Williams
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23307] Add columns configuration to cataloguing/z3950_search.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23307 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22209] Move stock rotation stage and item forms into modals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22209 Katrin Fischer changed: What|Removed |Added Attachment #91508|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 92079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92079=edit Bug 22209: Move stock rotation stage and item forms into modals This patch makes a number of interface changes to the Stock Rotation management interface: - "Add stage" and "Add items" forms are now triggered by clicking new buttons in the toolbar. - "Manage stages" and "Manage items" menu items have been added to a sidebar menu to be displayed when stages or items are being managed. - JavaScript has been added to move focus to the first form field in the modal when it is displayed. The "autofocus" attribute is not sufficent here because the modal is hidden by default. - Add messages to be shown when there are no items or stages to be displayed. - Correct "selected" attributes to use XHTML-style: selected="selected" (https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML_Templates) To test, apply the patch and go to Tools -> Stock rotation. - Create a rota if you don't already have one. - Manage stages for your rota. - If your rota has no stages you should see a message along with an "Add stage" button. The button should trigger the "Add stage" modal. - Test the "Add stage" button in the toolbar. It should trigger a modal dialog containing the form for adding a new stage. The cursor focus should automatically be on the "library" field. - Submitting the form should correctly add the stage. - Verify that there is a new menu in the sidebar, "Manage stages" and "Manage items." - Manage items for your rota. - If your rota has no items you should see a message along with an "Add items" button. The button should trigger the "Add items" modal. - Test the "Add items" button in the toolbar. It should trigger a modal dialog containing the form for adding new items. The cursor focus should automatically be on the "barcode" field. - Submitting either a barcode or a file of barcodes should work correctly. - Verify that the new menu items are shown in the sidebar. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22209] Move stock rotation stage and item forms into modals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22209 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23402] Item search doesn't work with screen selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23402 --- Comment #14 from Anke --- Thanks - we changed the file, and now it works! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23228] Add option to automatically display payment receipt for printing after making a payment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23228 Martin Renvoize changed: What|Removed |Added Text to go in the|This enhancement adds the |This enhancement adds the release notes|optional ability to |optional ability to |automatically popup the |automatically popup the |receipt print dialogue upon |receipt print dialogue upon |successful payments. in the |successful payments. in the |staff client. |staff client. | | |Note: The |Note: The |new `` must be enabled and |new `FinePaymentAutoPopup` |popup blocker may require |must be enabled and popup |setting to allow popups for |blocker may require setting |your Koha staff client |to allow popups for your |domain. |Koha staff client domain. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23228] Add option to automatically display payment receipt for printing after making a payment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23228 Martin Renvoize changed: What|Removed |Added Text to go in the||This enhancement adds the release notes||optional ability to ||automatically popup the ||receipt print dialogue upon ||successful payments. in the ||staff client. || ||Note: The ||new `` must be enabled and ||popup blocker may require ||setting to allow popups for ||your Koha staff client ||domain. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23228] Add option to automatically display payment receipt for printing after making a payment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23228 --- Comment #17 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23228] Add option to automatically display payment receipt for printing after making a payment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23228 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23228] Add option to automatically display payment receipt for printing after making a payment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23228 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #16 from Martin Renvoize --- Rescued and passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23228] Add option to automatically display payment receipt for printing after making a payment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23228 Martin Renvoize changed: What|Removed |Added Attachment #92075|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 92078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92078=edit Bug 23228: (QA follow-up) Add required filters Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23228] Add option to automatically display payment receipt for printing after making a payment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23228 Martin Renvoize changed: What|Removed |Added Attachment #92074|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 92077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92077=edit Bug 23228: (QA follow-up) Fix the DB update Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23228] Add option to automatically display payment receipt for printing after making a payment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23228 Martin Renvoize changed: What|Removed |Added Attachment #92073|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize --- Created attachment 92076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92076=edit Bug 23228: Add option to automatically display payment receipt for printing after making a payment Some libraries would like an auto-popup after making a payment so librarians don't have to navigate to the accounts page, locate the new payment, then click the print button. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Make a payment, note no difference in behavior 4) Enable the new syspref FinePaymentAutoPopup 5) Make a payment, note the popup for the payment receipt Signed-off-by: Lisette Scheer Rescued-by: Martin Renvoize Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17338] waitingreserves.pl should keep you on the same tab when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17338 --- Comment #6 from Christopher Brannon --- (In reply to Christopher Brannon from comment #5) > (In reply to Nick Clemens from comment #3) > > (In reply to Christopher Brannon from comment #2) > > > This is an old request. If there were an option to do that, it would be > > > great. I don't think it should just focus on that search filter always, > > > but > > > if there were a check box to keep the focus, that would streamline the use > > > of this page for those that are going through a pile of holds that need to > > > be cancelled. > > > > I am afraid I don't understand - can you describe the workflow where focus > > is lost? Do you mean if you search, then click a cancel link, the focus > > should return to the search? i.e. if the search box is populated we should > > focus there on page load? > > Yes. That is correct. If you look at the jquery, it does exactly what I am > explaining. (In reply to Ray Delahunty from comment #4) > When Christopher talks about the "loss of focus" does he mean that the loss > of both the sort order and the limitation to a specific library? We have 6 > libraries and the workflow staff are accustomed to was to limit to their > branch, sort by user name order, and then go along the hold shelf removing > the items and cancelling the hold and returning the item to the shelf (or > setting the item aside for return to library it belongs to, or triggering > the next hold). Now the loss of focus includes the need to move back to the > RHS tab, limit to library again, and sort again. BTW the bug 23192 has > already lead to data damage where staff have accidently cancelled an > unfulfilled hold (one on the tab they were forced back to!). Our support > company were unsuccessful in back porting the fix for 23192 into our 18.11 > Koha version. Loss of focus means the cursor is not staying on the search box at the top of the list. Nothing to do with sort. I see how that it could be beneficial to keep the sort though. On any page for that matter. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23228] Add option to automatically display payment receipt for printing after making a payment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23228 --- Comment #12 from Martin Renvoize --- Created attachment 92075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92075=edit Bug 23228: (QA follow-up) Add required filters Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23228] Add option to automatically display payment receipt for printing after making a payment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23228 Martin Renvoize changed: What|Removed |Added Attachment #91665|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 92073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92073=edit Bug 23228: Add option to automatically display payment receipt for printing after making a payment Some libraries would like an auto-popup after making a payment so librarians don't have to navigate to the accounts page, locate the new payment, then click the print button. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Make a payment, note no difference in behavior 4) Enable the new syspref FinePaymentAutoPopup 5) Make a payment, note the popup for the payment receipt Signed-off-by: Lisette Scheer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23228] Add option to automatically display payment receipt for printing after making a payment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23228 --- Comment #11 from Martin Renvoize --- Created attachment 92074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92074=edit Bug 23228: (QA follow-up) Fix the DB update Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17338] waitingreserves.pl should keep you on the same tab when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17338 --- Comment #5 from Christopher Brannon --- (In reply to Nick Clemens from comment #3) > (In reply to Christopher Brannon from comment #2) > > This is an old request. If there were an option to do that, it would be > > great. I don't think it should just focus on that search filter always, but > > if there were a check box to keep the focus, that would streamline the use > > of this page for those that are going through a pile of holds that need to > > be cancelled. > > I am afraid I don't understand - can you describe the workflow where focus > is lost? Do you mean if you search, then click a cancel link, the focus > should return to the search? i.e. if the search box is populated we should > focus there on page load? Yes. That is correct. If you look at the jquery, it does exactly what I am explaining. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23439] New: Barcode number with serveral users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23439 Bug ID: 23439 Summary: Barcode number with serveral users Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: lmoisesro...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Hello, everybody, When two or more users are trying to add a new item, the barcode field get the same numnber, so when they save the item and with have an error. This is happing since 19.05. Now only just one user can add item. Any help? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23013] Upgrade DataTables in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 --- Comment #5 from Owen Leonard --- In my tests there is some minor misalignment which varies between browsers, usually between one and two pixels. The problem is greater if your page zoom has been increased. I can work on a follow-up, but I hope this can move forward if that's the only problem which has turned up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 Martin Renvoize changed: What|Removed |Added Blocks||23091 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Depends on||22877 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23431] having Date of birth in PatronSelfModificationBorrowerUnwantedField causes DOB to be nullified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23431 --- Comment #7 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23431] having Date of birth in PatronSelfModificationBorrowerUnwantedField causes DOB to be nullified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23431 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23399] Reindent returns.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23399 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23399] Reindent returns.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23399 --- Comment #8 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23322] Elasticsearch - Record matching fails when multiple keys exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23322 --- Comment #6 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23286] Improve style of hold confirmation modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23286 --- Comment #6 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23322] Elasticsearch - Record matching fails when multiple keys exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23322 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23286] Improve style of hold confirmation modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23286 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23434] Hold confirmation dialog problem if HoldsAutoFill is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23434 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize --- Fixes the exposed issue.. Signing off.. thanks Owen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23434] Hold confirmation dialog problem if HoldsAutoFill is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23434 Martin Renvoize changed: What|Removed |Added Attachment #92028|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 92072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92072=edit Bug 23434: Hold confirmation dialog problem if HoldsAutoFill is enabled This patch corrects a problem with hold confirmation dialogs on the checkin page when the HoldsAutoFill system preference is enabled and the item being checked in has a hold at another library. The confirmation dialog is converted to a modal to match other confirmation information. As part of this process two whole sections of the template have been removed because they were redundant. To test, apply the patch and test the following circumstances both with HoldsAutoFill enabled AND disabled: - A hold for a patron at your library - A hold for a patron not at your library - With HoldsAutoFill ON, both the "OK" and "Print slip and confirm" buttons should dismiss the modal without reloading the page. - A hold which is already marked 'Waiting' - An item which needs to be transferred - An item which has already been transferred In all cases the confirmation modal should appear with correct information. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23399] Reindent returns.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23399 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23399] Reindent returns.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23399 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #7 from Martin Renvoize --- Always good to make the indenting a bit more sane.. thanks Owen! Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23399] Reindent returns.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23399 Martin Renvoize changed: What|Removed |Added Attachment #91911|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 92071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92071=edit Bug 23399: (follow-up) Markup comments and corrections This patch adds comments to the template to highlight the markup structure. It also corrects some minor markup errors. This patch should have no effect on the interface or functionality. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23399] Reindent returns.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23399 Martin Renvoize changed: What|Removed |Added Attachment #91910|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 92070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92070=edit Bug 23399: Reindent returns.tt This patch reindents circulation/returns.tt to use four spaces, following coding guidelines. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but each must take their own journey. Test the checkin process to confirm that everything still works correctly. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23286] Improve style of hold confirmation modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23286 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- This is a nice improvement, no breakage found. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23286] Improve style of hold confirmation modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23286 Martin Renvoize changed: What|Removed |Added Attachment #91935|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 92069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92069=edit Bug 23286: Improve style of hold confirmation modal This patch makes minor changes to the hold confirmation modal in the check-in template and adds some additional style. The goal is to make the information a little more readable. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Check in items with the following hold statuses: - On hold for a patron at your library - On hold for a patron at another library - On hold and already marked 'Waiting' Confirm that the hold confirmation modal is clear and well-styled. Signed-off-by: Kyle M Hall Signed-off-by: Nadine Pierre Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23322] Elasticsearch - Record matching fails when multiple keys exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23322 Martin Renvoize changed: What|Removed |Added QA Contact||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23431] having Date of birth in PatronSelfModificationBorrowerUnwantedField causes DOB to be nullified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23431 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23431] having Date of birth in PatronSelfModificationBorrowerUnwantedField causes DOB to be nullified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23431 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #6 from Martin Renvoize --- Trivial patch that works as expected.. It would have been nice to have an accompanying selenium regression test, but I don't feel it warrants a QA failure for it (especially as it's a major). Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23431] having Date of birth in PatronSelfModificationBorrowerUnwantedField causes DOB to be nullified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23431 Martin Renvoize changed: What|Removed |Added Attachment #92033|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 92068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92068=edit Bug 23431: Don't nullify DOB if it's hidden by sysprefs To test: Turn on OPACPatronDetails put dateofbirth in PatronSelfModificationBorrowerUnwantedField Have a patron with a set date of birth Attempt any modification on that patron through the OPAC The date of birth will be one of the fields changed for that borrower when you check it in the staff intranet. Apply this patch, repeat the above. Date of birth will not be one of the changed fields. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23322] Elasticsearch - Record matching fails when multiple keys exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23322 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Trivial patch, works as expected.. would have been nice to have a unit test for it.. but as it's ES dependant I'm not going to fail it for that. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23322] Elasticsearch - Record matching fails when multiple keys exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23322 Martin Renvoize changed: What|Removed |Added Attachment #91556|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 92067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92067=edit Bug 23322: Correct case for boolean in ES search I did not include tests only because this is a very small reasonable change and routine has no tests. It does not affect behaviour, it only touches syntax lightly. To test: 0 - Set SearchEngine to ElasticSearch 1 - Import the example record (a version is included in sample data in devbox/testing docker so you can skip) 2 - Stage the attached example record 3 - Match using 'ISBN' rule 4 - No matches found 5 - Apply patch 6 - Restart all the things 7 - Reapply matching with no rule 8 - Reapply with ISBN matcing 9 - It matches! 10 - Set SearchEngine to Zebra 11 - Reapply matching with no rule 12 - Reapply with ISBN matching 13 - Matching works as before in Zebra Signed-off-by: Ron Houk Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23405] Circulation autocomplete for patron lookup broken if cardnumber is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23405 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23405] Circulation autocomplete for patron lookup broken if cardnumber is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23405 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
