[Koha-bugs] [Bug 22581] Include the Verovio library to show musical incipits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111 Owen Leonard changed: What|Removed |Added CC||victor.grous...@biblibre.co ||m --- Comment #61 from Owen Leonard --- *** Bug 23378 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23378] Invalid OPAC search RSS: unescaped characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23378 Owen Leonard changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 16111 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a specific item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22387] Checkin alert for transfer items to stop further checkins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22387 Owen Leonard changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Owen Leonard --- I think this bug has been made obsolete by various recent changes to the check-in process. If I am mistaken please re-open. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23149] Unsuspend button in staff interface is confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23149 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14669] Search orders by managing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14669 --- Comment #12 from Owen Leonard --- (In reply to Katrin Fischer from comment #11) > Owen, just to make sure, could you maybe verify my conclusions about the > includes/QA failure? I agree that it looks like a false positive. When the page is displaying search results and the form is in the sidebar is it possible to preselect the managing library the user just searched for? To be consistent it should remember their selection. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23501] Drag-and-drop hold reordering in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23501 --- Comment #5 from Christopher Brannon --- Great idea. As it is now, that bugs me. Maybe a banner down at the bottom by the buttons in red text saying changes have not been saved yet? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23501] Drag-and-drop hold reordering in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23501 Owen Leonard changed: What|Removed |Added Status|Signed Off |ASSIGNED --- Comment #4 from Owen Leonard --- Thank you for the signoff Maryse! I did think of something I wanted to add to this, so I'm going to put it back to "assigned" and submit a follow-up. I want there to be some kind of way to indicate to the user that they have to save their changes after reordering priority. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19506] Staged Marc Import should warn if the selected encoding does not match MARC 21 leader
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19506 Sarah Cornell changed: What|Removed |Added CC||sbcornell@cityofportsmouth. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23321] Add 'tills' to the accounts system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 Maryse Simard changed: What|Removed |Added Attachment #92402|0 |1 is obsolete|| --- Comment #44 from Maryse Simard --- Created attachment 92475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92475&action=edit Bug 23321: (follow-up) Require cash registers for payments This follow-up catches the case where no cash registers have been defined for the current branch and as such payments cannot be processed. Test plan: 1) Ensure you have 'UseCashRegisters' set to 'Do' 2) Attempt to make a payment for a fee whilst logged into a branch that has not yet had cash registers configured. 3) Note that you are shown a warning and cannot proceed. 4) Signoff Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23321] Add 'tills' to the accounts system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 Maryse Simard changed: What|Removed |Added CC||maryse.sim...@inlibro.com Status|Needs Signoff |Signed Off --- Comment #45 from Maryse Simard --- Followed the test plans and everything work. I resolved a small conflict in one of the patches, moving changes in staff-global.scss to _tables.scss where the styles now reside since Bug 23013. Some comments: - In the cash registers page, I noticed that there seems to be a branch filter but I can't seem to make it work... - I wonder if a link to the page should be added to the admin-menu.inc so it appears in the navigation on the admin pages? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23321] Add 'tills' to the accounts system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 Maryse Simard changed: What|Removed |Added Attachment #92401|0 |1 is obsolete|| --- Comment #43 from Maryse Simard --- Created attachment 92474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92474&action=edit Bug 23321: Add cash register support to paycollect This patch ties in the cash registers system to the paycollect payment pages in the staff client. Test plan: 1) Add some manual fees to a test patron 2) Select some fees to pay off 3) Note the addition of a select box for selecting your cash register upon payment. 4) Set a branch default cash register for the current branch 5) Repeat step 3 and note that the pre-selected cash register is the one set in step 4. 6) Unset the branch default cash register for the current branch 7) Repeat step 3 and note that there is no cash register pre-selected 8) Set 'UseCashRegisters' to 'Do not' 9) Repeat step 3 and note that there is no longer an option to select a cash register 10) Signoff Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23321] Add 'tills' to the accounts system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 Maryse Simard changed: What|Removed |Added Attachment #92400|0 |1 is obsolete|| --- Comment #42 from Maryse Simard --- Created attachment 92473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92473&action=edit Bug 23321: Allow setting of branch default This adds the ability to set a cash register as the default selected option when making payments at a particular branch. 1) Note the addition of a 'Make branch default' button in each row of the table under 'Manage cash registers' 2) Click the button and note that the button has changed. 3) Click on an alternative cash register for the same branch and note that the default has been switched to the new register. 4) Click the 'unset' button on the default branch and note that there is no longer a default register for this branch. 5) Signoff Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23321] Add 'tills' to the accounts system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 Maryse Simard changed: What|Removed |Added Attachment #92399|0 |1 is obsolete|| --- Comment #41 from Maryse Simard --- Created attachment 92472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92472&action=edit Bug 23321: Add cash register management Add in administrative interfaces to allow the management of cash registers. Test plan: 1) Enable the use of cash registers by setting 'UseCashRegisters' to 'Do' 2) Check that the 'Accounts > Manage cash registers' option now appears in the 'Administration' area. 3) Click through to 'Manage cash registers' and note the message suggesting you add your first register 4) Add you're first cash register 5) Note that the message has now been replaced by a table of cash registers including the one you have added in the previous step. 6) Edit the cash register created in step 4 and note that the table reflects the changes 7) Signoff Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23321] Add 'tills' to the accounts system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 Maryse Simard changed: What|Removed |Added Attachment #92398|0 |1 is obsolete|| --- Comment #40 from Maryse Simard --- Created attachment 92471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92471&action=edit Bug 23321: Add cash register permission Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23321] Add 'tills' to the accounts system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 Maryse Simard changed: What|Removed |Added Attachment #92396|0 |1 is obsolete|| --- Comment #38 from Maryse Simard --- Created attachment 92469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92469&action=edit Bug 23321: Koha::Library additions This patch adds the relationship accessor for Cash::Registers to the Koha::Library class and include the relevant tests. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23321] Add 'tills' to the accounts system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 Maryse Simard changed: What|Removed |Added Attachment #92394|0 |1 is obsolete|| --- Comment #36 from Maryse Simard --- Created attachment 92467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92467&action=edit Bug 23321: Add cash_registers table Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23321] Add 'tills' to the accounts system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 Maryse Simard changed: What|Removed |Added Attachment #92397|0 |1 is obsolete|| --- Comment #39 from Maryse Simard --- Created attachment 92470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92470&action=edit Bug 23321: Add cash register preference Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23321] Add 'tills' to the accounts system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 Maryse Simard changed: What|Removed |Added Attachment #92395|0 |1 is obsolete|| --- Comment #37 from Maryse Simard --- Created attachment 92468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92468&action=edit Bug 23321: [DO NOT PUSH] DBIC Classes Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23504] New: Allow forgiving fines on returned lost items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23504 Bug ID: 23504 Summary: Allow forgiving fines on returned lost items Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Here's the situation: - Library has WhenLostForgiveFine set to Don't Forgive - Item is overdue with accruing fine - Item is set to lost - Fine switching from FU to F - Item is returned, checked in with Forgive Overdue Charges checked - Fine is not forgiven because it is accounttype F rather than FU Some libraries would like this fine to be forgiven when the item checks in w/ Forgive Overdue Charges -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23502] Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23502 Maryse Simard changed: What|Removed |Added CC||maryse.sim...@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23502] Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23502 Maryse Simard changed: What|Removed |Added Attachment #92458|0 |1 is obsolete|| --- Comment #2 from Maryse Simard --- Created attachment 92466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92466&action=edit Bug 23502: Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference This bug corrects the template logic controlling the display of the "Revert waiting status" and "Revert transit status" buttons on the staff client holds page so that it doesn't depend on having SuspendHoldsIntranet enabled. To test, apply the patch and locate a title which has multiple holds, including: - One waiting hold - One in-transit hold - At least one pending hold View the page with the SuspendHoldsIntranet preference both on and off. The "Revert transit status" and "Revert waiting status" buttons should be displayed either way. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23503] Personal name authority search: search results aren't sorted in alphabetical order after page 51
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23503 Marie-Luce Laflamme changed: What|Removed |Added Summary|Personal name authority |Personal name authority |search (Intranet): search |search: search results |results aren't sorted in|aren't sorted in |alphabetical order after|alphabetical order after |page 51 |page 51 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23501] Drag-and-drop hold reordering in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23501 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||maryse.sim...@inlibro.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23501] Drag-and-drop hold reordering in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23501 Maryse Simard changed: What|Removed |Added Attachment #92453|0 |1 is obsolete|| --- Comment #3 from Maryse Simard --- Created attachment 92465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92465&action=edit Bug 23501: Drag-and-drop hold reordering in the staff client This patch adds drag-and-drop priority reordering to the table of existing holds on a title. To test, apply the patch and regenerate the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Log in to Koha as a user who has permission to modify holds priority - Test on a record that has multiple holds, including one which is waiting and one which is in transit. - Holds which can be re-ordered should have a "drag handle" styled table cell in the first column. - Your mouse should show the "move" cursor when you hover over it. - Clicking and dragging from this table cell should reorder the table rows. - The priority numbers should be automatically updated when you "drop" the row. - It should not be possible to move a hold which is waiting or in transit. - It should not be possible to move a hold before a waiting or in transit hold. - Toggle lowest priority on a hold. The row should become unsortable, and it should be impossible to sort a hold below that hold. - Test again as a user who doesn't have permission to modify holds priority. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 --- Comment #15 from Kyle M Hall --- Created attachment 92464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92464&action=edit Bug 23068: [DO NOT PUSH] Debugging code for test plan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23503] Personal name authority search (Intranet): search results aren't sorted in alphabetical order after page 51
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23503 Marie-Luce Laflamme changed: What|Removed |Added Summary|Personal name authority |Personal name authority |search: search results |search (Intranet): search |aren't sorted in|results aren't sorted in |alphabetical order after|alphabetical order after |page 51 |page 51 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Kyle M Hall changed:
What|Removed |Added
Attachment #92461|0 |1
is obsolete||
Attachment #92462|0 |1
is obsolete||
--- Comment #14 from Kyle M Hall ---
Created attachment 92463
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92463&action=edit
Bug 23068: Add ability for Koha to handle X-Forwarded-For headers so
REMOTE_ADDR features work behind a proxy
Koha has a number of features that rely on knowing the IP address of the
connecting client. If that server is behind a proxy these features do not work.
This patch adds a module to automatically convert the X-Forwarded-For header
into the REMOTE_ADDR environment variable for both CGI and Plack processes.
TEST PLAN:
1) Apply this patch set
2) Install Plack::Middleware::RealIP via cpanm or your favorite utility
3) Update your plack.psgi with the changes you find in this patch set ( this
process differs based on your testing environment )
4) Restart plack
5) Tail the plack error log for your instance
6) Use curl to access the OPAC, adding an X-Forwarded-For header: curl --header
"X-Forwarded-For: 32.32.32.32" http://127.0.0.1:8080
7) Note the logs output this address if you are unproxied
8) If you are proxied, restart plack using a command like below, where the ip
you see in the logs ("REAL IP) is what you put in the koha conf:
172.22.0.1 1.1.1.1
9) Restart all the things!
10) Repeat step 6
11) You should now see "REAL IP: 32.32.32.32" in the plack logs as the remote
address in your plack-error.log logs!
12) Disable plack so you are running in cgi mode, repeat step 6 again
13) You should see "REAL IP: 32.32.32.32" as the remove address in your
opac-error.log logs!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 --- Comment #13 from Kyle M Hall --- Created attachment 92462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92462&action=edit Bug 23068: [DO NOT PUSH] Debugging code for test plan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Kyle M Hall changed:
What|Removed |Added
Attachment #90395|0 |1
is obsolete||
Attachment #91173|0 |1
is obsolete||
Attachment #91447|0 |1
is obsolete||
--- Comment #12 from Kyle M Hall ---
Created attachment 92461
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92461&action=edit
Bug 23068: Add ability for Koha to handle X-Forwarded-For headers so
REMOTE_ADDR features work behind a proxy
Koha has a number of features that rely on knowing the IP address of the
connecting client. If that server is behind a proxy these features do not work.
This patch adds a module to automatically convert the X-Forwarded-For header
into the REMOTE_ADDR environment variable for both CGI and Plack processes.
TEST PLAN:
1) Apply this patch set
2) Install Plack::Middleware::RealIP via cpanm or your favorite utility
3) Update your plack.psgi with the changes you find in this patch set ( this
process differs based on your testing environment )
4) Restart plack
5) Tail the plack error log for your instance
6) Use curl to access the OPAC, adding an X-Forwarded-For header: curl --header
"X-Forwarded-For: 32.32.32.32" http://127.0.0.1:8080
7) Note the logs output this address if you are unproxied
8) If you are proxied, restart plack using a command like below, where the ip
you see in the logs ("REAL IP) is what you put in the koha conf:
172.22.0.1 1.1.1.1
9) Restart all the things!
10) Repeat step 6
11) You should now see "REAL IP: 32.32.32.32" in the plack logs as the remote
address in your plack-error.log logs!
12) Disable plack so you are running in cgi mode, repeat step 6 again
13) You should see "REAL IP: 32.32.32.32" as the remove address in your
opac-error.log logs!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16882] Circ restrictions caused by long overdue should be removed when the offending item is returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16882 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23464] Update the process of quick spine label printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23464 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23464] Update the process of quick spine label printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23464 Maryse Simard changed: What|Removed |Added Attachment #92445|0 |1 is obsolete|| --- Comment #5 from Maryse Simard --- Created attachment 92460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92460&action=edit Bug 23464: (follow-up) QA fixes This patch corrects two issues raised during testing: - Move JavaScript out of template check for IntranetUserJS so that SpineLabelAutoPrint behavior works correctly. - Add "close" button to pop-up window for cases when the barcode was not found. Also changed: - Added "required" attribute to barcode input on quick spine label printing page so that submitting an empty form will not work. - Tweaked CSS slightly to fix alignment of spine label form and submit button. (You must rebuild the staff client CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23464] Update the process of quick spine label printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23464 Maryse Simard changed: What|Removed |Added Attachment #92241|0 |1 is obsolete|| --- Comment #4 from Maryse Simard --- Created attachment 92459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92459&action=edit Bug 23464: Update the process of quick spine label printing This patch makes changes to the way quick spine label printing works, either from the bibliographic details page or the Quick spine label creator page. To test, apply the patch and go to Tools -> Quick spine label creator. - Type or scan a barcode. Submitting the form should trigger a popup window with the spine label print page. The "print" button should be centered at the bottom of the window in a footer-like container. - If you have SpineLabelAutoPrint enabled, the print dialog should appear automatically. - After printing, the pop-up window should close and and focus should be returned to the barcode field. Enable the SpineLabelShowPrintOnBibDetails system preference. View the bibliographic details page for a record in the catalog. - In the holdings table, a "Spine label" column should appear as the second-to-last column. The column should contain "Print label" Bootstrap-style buttons. - Clicking a "Print label" button should trigger a pop-up window with the spine label print page. The behavior of the window should be the same as above. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23503] New: Personal name authority search: search results aren't sorted in alphabetical order after page 51
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23503 Bug ID: 23503 Summary: Personal name authority search: search results aren't sorted in alphabetical order after page 51 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: marie-luce.lafla...@inlibro.com QA Contact: testo...@bugs.koha-community.org After performing an authority search by "Personal name", we have noticed that search results aren't sorted in alphabetical order after page 51. 1) Go to Authority search (click on "More" and select "Authorities" on the top left corner) 2) Select "Personal Name" in the Default Menu. Leave the search box empty and submit. 3) Assess the first 50 pages of results (all results are sorted alphabetically) 4) Access page 51 and notice the different pattern of results ( results aren’t sorted in alphabetical order). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #2 from Christopher Brannon --- +1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Lisette Scheer changed: What|Removed |Added CC||cbran...@cdalibrary.org --- Comment #1 from Lisette Scheer --- *** Bug 23500 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23500] Last borrower time out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23500 Lisette Scheer changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC||lisettesla...@gmail.com --- Comment #1 from Lisette Scheer --- *** This bug has been marked as a duplicate of bug 23260 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23501] Drag-and-drop hold reordering in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23501 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23502] Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23502 --- Comment #1 from Owen Leonard --- Created attachment 92458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92458&action=edit Bug 23502: Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference This bug corrects the template logic controlling the display of the "Revert waiting status" and "Revert transit status" buttons on the staff client holds page so that it doesn't depend on having SuspendHoldsIntranet enabled. To test, apply the patch and locate a title which has multiple holds, including: - One waiting hold - One in-transit hold - At least one pending hold View the page with the SuspendHoldsIntranet preference both on and off. The "Revert transit status" and "Revert waiting status" buttons should be displayed either way. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23502] Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23502 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #42 from Nick Clemens --- Rebased and tested, this works excellently, I would love to move this forward, but I see a few issues in the patches: 1 - You removed QueryWeightedFields, but Zebra uses this, I obsoleted that patch 2 - There are changes to the authority searches here, things are improved, but a bit too strict, they don't relate to this bug, can you move those to a new report? 3 - Schema changes are mixed into first patch, they should be their own so RM can generate separately 4 - I did a minor rebase on top of 22258 and added a followup to allow searchig the entire record if using marc array Let me know if this makes sense or if I went too far anywhere -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 --- Comment #40 from Nick Clemens --- Created attachment 92456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92456&action=edit Bug 20589: Exclude boolean fields from search fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 --- Comment #41 from Nick Clemens --- Created attachment 92457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92457&action=edit Bug 20589: Add option for searching entire record if record stored as array -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 --- Comment #39 from Nick Clemens --- Created attachment 92455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92455&action=edit Bug 20589: fix QueryBuilder tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 Nick Clemens changed: What|Removed |Added Attachment #87411|0 |1 is obsolete|| Attachment #87412|0 |1 is obsolete|| Attachment #87415|0 |1 is obsolete|| Attachment #87416|0 |1 is obsolete|| --- Comment #38 from Nick Clemens --- Created attachment 92454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92454&action=edit Bug 20589: Add field boosting and use query_string fields parameter Generate a list of fields for the query_string query fields parameter, with possible boosts, instead of using "_all"-field. Also add "search" flag in search_marc_to_field table so that certain mappings can be excluded from searches. Add option to include/exclude fields in query_string "fields" parameter depending on searching in OPAC or staff client. Refactor code to remove all other dependencies on "_all"-field. How to test: 1) Reindex authorities and biblios. 2) Search biblios and try to verify that this works as expected. 3) Search authorities and try to verify that this works as expected. 4) Go to "Search engine configuration" 5) Change some "Boost", "Staff client", and "OPAC" settings and save. 6) Verify that those settings where saved accordingly. 7) Click the "Biblios" or "Authorities" tab and change one or more "Searchable" settings 8) Verfiy that those settings where saved accordingly. 9) Try to verify that these settings has taken effect by peforming some biblios and/or authorities searches. Sponsorded-by: Gothenburg Univesity Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23502] Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23502 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Owen Leonard changed: What|Removed |Added Blocks||23502 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23502 [Bug 23502] Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23502] New: Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23502 Bug ID: 23502 Summary: Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Depends on: 21608 Bug 21608 added buttons to revert the in transit or waiting statuses of holds in the staff client. However, the markup for the button is inside a check for the SuspendHoldsIntranet preference: [% IF SuspendHoldsIntranet %] I think this is unintentional. The buttons should be available even if a library has SuspendHoldsIntranet disabled. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23501] Drag-and-drop hold reordering in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23501 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23501] Drag-and-drop hold reordering in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23501 --- Comment #2 from Owen Leonard --- Created attachment 92453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92453&action=edit Bug 23501: Drag-and-drop hold reordering in the staff client This patch adds drag-and-drop priority reordering to the table of existing holds on a title. To test, apply the patch and regenerate the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Log in to Koha as a user who has permission to modify holds priority - Test on a record that has multiple holds, including one which is waiting and one which is in transit. - Holds which can be re-ordered should have a "drag handle" styled table cell in the first column. - Your mouse should show the "move" cursor when you hover over it. - Clicking and dragging from this table cell should reorder the table rows. - The priority numbers should be automatically updated when you "drop" the row. - It should not be possible to move a hold which is waiting or in transit. - It should not be possible to move a hold before a waiting or in transit hold. - Toggle lowest priority on a hold. The row should become unsortable, and it should be impossible to sort a hold below that hold. - Test again as a user who doesn't have permission to modify holds priority. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23501] Drag-and-drop hold reordering in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23501 Christopher Brannon changed: What|Removed |Added CC||cbran...@cdalibrary.org --- Comment #1 from Christopher Brannon --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22258] Elasticsearch - full record is not indexed in plain text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22258 --- Comment #20 from Nick Clemens --- I think this one can move ahead, ES is still in flux and we have decisions to make Even if 20589 removes the ability to search this when it goes in we can easily restore it I would love to see the ability to have a checkbox 'search entire record' so that we could isolate this functionality if the record is stored this way. Either way, it works as expected, PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22258] Elasticsearch - full record is not indexed in plain text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22258 Nick Clemens changed: What|Removed |Added Attachment #87440|0 |1 is obsolete|| Attachment #87441|0 |1 is obsolete|| --- Comment #18 from Nick Clemens --- Created attachment 92451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92451&action=edit Bug 22258: Elasticsearch: Add array as an alternative MARC format Adds preference ElasticsearchMARCFormat that controls whether MARC records are stored as ISO2709/MARCXML or array. Array is searchable by field and also indexes all subfields in the _all field for searching. Test plan: 1. Test that searching and indexing works with the patch without any changes. 2. Switch to array format and index some records. 3. Check e.g. the 008 field of a record and verify that the record can be found with the contents enclosed in quotes. 4. Check that it's possible to search for a specific field/subfield. Search query: marc_data_array.fields.655.subfields.a:Diaries 5. Check that tests still pass, especially t/Koha/SearchEngine/Elasticsearch.t Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22258] Elasticsearch - full record is not indexed in plain text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22258 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22258] Elasticsearch - full record is not indexed in plain text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22258 --- Comment #19 from Nick Clemens --- Created attachment 92452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92452&action=edit Bug 22258: Increase Elasticsearch maximum field count to 1 Increases maximum field count from the default 1000 to 1 to accommodate large records and MARC as an array. Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421 Owen Leonard changed: What|Removed |Added Depends on||23501 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23501 [Bug 23501] Drag-and-drop hold reordering in the staff client -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23501] New: Drag-and-drop hold reordering in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23501 Bug ID: 23501 Summary: Drag-and-drop hold reordering in the staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Blocks: 16421 It would be nice to be able to use drag-and-drop to reorder holds in the staff client. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421 [Bug 16421] Move hold edit actions into dropdown menu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23397] Order lines can be duplicated in acqui scripts spent.pl and ordered.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23397 Marcel de Rooy changed: What|Removed |Added Attachment #92446|0 |1 is obsolete|| --- Comment #11 from Marcel de Rooy --- Created attachment 92449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92449&action=edit Bug 23397: (follow-up) Split and display itemtypes Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23397] Order lines can be duplicated in acqui scripts spent.pl and ordered.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23397 Marcel de Rooy changed: What|Removed |Added Attachment #92344|0 |1 is obsolete|| --- Comment #10 from Marcel de Rooy --- Created attachment 92448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92448&action=edit Bug 23397: Fix grouping of orders in acqui scripts Bug 21622 attempted to fix some grouping for strict mode, however, it failed to take into account that single order can have multiple item types. To recreate: 1 - Place an order for 4 copies of a title in acq 2 - Make sure you are creating orders when ordering (AcqCreateItems syspref and/or when creating basket) 3 - Set three items to one type, and one to another 4 - Go to Acqui-Home and click 'ordered' for the used budget 5 - Note the line is duplicated for each itemtype in the order 6 - Recieve the items and note the same issue on 'Spent' 7 - Place another order as before so you have the problem in both ordered.pl and spent/pl 8 - Apply patch 9 - Note orders are no longer duplicated Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23397] Order lines can be duplicated in acqui scripts spent.pl and ordered.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23397 --- Comment #12 from Marcel de Rooy --- Created attachment 92450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92450&action=edit Bug 23397: (QA follow-up) Replace mod 2 by last Looks better: Maps | Books | Continuing Resources Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23397] Order lines can be duplicated in acqui scripts spent.pl and ordered.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23397 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23500] New: Last borrower time out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23500 Bug ID: 23500 Summary: Last borrower time out Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Would like to see a cron job that would anonymize the last borrower info. Currently, the last borrower info in an item until that item is checked out again and returned. If that item is not checked out again, that information is there indefinitely. For the sake of local or other laws, it would be great if there were a cron job that would look for any last borrower info that has been in place for a prescribed amount of time, and changed it to the anonymous borrower record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23397] Order lines can be duplicated in acqui scripts spent.pl and ordered.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23397 --- Comment #9 from Marcel de Rooy --- (In reply to Nick Clemens from comment #8) > Created attachment 92446 [details] [review] > Bug 23397: (follow-up) Split and display itemtypes Looking at it again -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23492] OPAC search facet header should not be a link at larger browser widths
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23492 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #6 from Andrew Fuerste-Henry --- *** Bug 23481 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23481] Refine Search button does not perform as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23481 Andrew Fuerste-Henry changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #9 from Andrew Fuerste-Henry --- Poking at Owen's patch on 23492 and looking at how this feature looks/works on mobile, it makes a lot more sense. I'm gonna just call this a dupe of 23492 and think about filing something else for the other half of my gripe on this ticket. Thanks all! *** This bug has been marked as a duplicate of bug 23492 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23492] OPAC search facet header should not be a link at larger browser widths
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23492 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #5 from Nick Clemens --- RM may want a second QA here - this is tiny though and we are the ones squeaking about it, so I went ahead and PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23492] OPAC search facet header should not be a link at larger browser widths
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23492 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23492] OPAC search facet header should not be a link at larger browser widths
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23492 Nick Clemens changed: What|Removed |Added Attachment #92442|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 92447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92447&action=edit Bug 23492: OPAC search facet header should not be a link at larger browser widths This patch adds some JavaScript-driven "breakpoints" to the OPAC so that on the search results page the "Refine your search" heading has different behaviors depending on whether facets are being displayed as a sidebar. To test, apply the patch and regenerate the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Go to the OPAC and resize your browser to be greater than ~ 800px wide. - Perform a catalog search which will return several results. - In the left-hand sidebar of the search results page, the "Refine your search" heading should not be styled like a link. Hovering over it with the mouse should not change the cursor to the pointing-hand. - Narrow your browser window until the sidebar collapses. - The "Refine your search" heading should now be styled as a link, with a right-arrow icon before it. - Clicking it should expand the facets. The icon should change to a down-arrow. - Widen your browser window and test again. - Perform the same tests when starting with a narrow browser window. Signed-off-by: Lucas Gass Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23397] Order lines can be duplicated in acqui scripts spent.pl and ordered.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23397 --- Comment #8 from Nick Clemens --- Created attachment 92446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92446&action=edit Bug 23397: (follow-up) Split and display itemtypes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23397] Order lines can be duplicated in acqui scripts spent.pl and ordered.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23397 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22573] Hold expiration date could be in the past
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22573 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22922] Allow to modify hold and hold expiration date in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 --- Comment #12 from Owen Leonard --- (In reply to Katrin Fischer from comment #11) > I think the date > pickers are a bit too wide in the table. Adding Owen. I usually give date input fields a size attribute of 10 on the assumption that is the maximum likely number of characters in a date: -00-00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23464] Update the process of quick spine label printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23464 --- Comment #3 from Owen Leonard --- Created attachment 92445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92445&action=edit Bug 23464: (follow-up) QA fixes This patch corrects two issues raised during testing: - Move JavaScript out of template check for IntranetUserJS so that SpineLabelAutoPrint behavior works correctly. - Add "close" button to pop-up window for cases when the barcode was not found. Also changed: - Added "required" attribute to barcode input on quick spine label printing page so that submitting an empty form will not work. - Tweaked CSS slightly to fix alignment of spine label form and submit button. (You must rebuild the staff client CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23464] Update the process of quick spine label printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23464 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #5 from Martin Renvoize --- Oops, forgot to squash before uploading to BZ... should be better now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize changed: What|Removed |Added Attachment #92443|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 92444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92444&action=edit Bug 23493: Replace rowGrouping with rowGroup This is an initial attempt to get some feedback. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #3 from Kyle M Hall --- Is this patch complete? I'm not seeing the CDN import line among other things :) (In reply to Martin Renvoize from comment #2) > This is a somewhat rough and ready attempt at replacement to get someone > started. > > I've directly included the new plugin via a CDN link, this would clearly > need to be bundled in our datatables bundle, but I didn't want to add all > there here in the first instance and confuse reviewers. > > I'm sure there's still more code that could be removed from the js file but > it would be good to get some initial feedback or perhaps for someone to take > it on. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #2 from Martin Renvoize --- This is a somewhat rough and ready attempt at replacement to get someone started. I've directly included the new plugin via a CDN link, this would clearly need to be bundled in our datatables bundle, but I didn't want to add all there here in the first instance and confuse reviewers. I'm sure there's still more code that could be removed from the js file but it would be good to get some initial feedback or perhaps for someone to take it on. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #1 from Martin Renvoize --- Created attachment 92443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92443&action=edit Bug 23493: Replace rowGrouping with rowGroup This is an initial attempt to get some feedback. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22922] Allow to modify hold and hold expiration date in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23397] Order lines can be duplicated in acqui scripts spent.pl and ordered.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23397 --- Comment #7 from Katrin Fischer --- I think if we can't fix showing the description, nothing is better right now and matches the behaviour before as far as I can tell from our installations where we have a mix of empty and itemtype description. What I was thinking was: if I understood GROUP_CONCAT right it gives you a comma separated string of values? Could we not split by , and loop through it template side? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22037] regression: guarantor no longer blocked (debarred) if child is over limit, when checking out via SIP.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22037 --- Comment #15 from Marcel de Rooy --- Just fyi from qa tools: * Commit title does not start with 'Bug X: ' - b329f91073 * Commit title does not contain 'follow-up' correctly spelt - b329f91073 * Commit title does not contain '(QA follow-up)' correctly spelt - b329f91073 Using the test plan from above with a patron status message (63): 63engMMDDHHMMSSXX|AOCPL|AA19|ADpassword| 64 YY eng201908230746410001AOCPL|AA19|AEHenry Acevedo|BLY|CQN|BV12|CC6|BD4345 Library Rd. Springfield, MA 44224|BF(212) 555-1212|PB20090530|PCK|PIN|AFGreetings from Koha. -- Patron owes 12.00 -- Invalid password| 63engMMDDHHMMSSXX|AOCPL|AA51|ADpassword| 64 YY eng20190823 0746530001AOCPL|AA51|AEMarcel Dev|BLY|CQN|BV17|CC6|BDadres_new|BEemail|PCS|PIY|AFGreetings from Koha. -- Patron owes 5.00 -- Invalid password| Even for NoIssuesChargeGuarantees == 4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23397] Order lines can be duplicated in acqui scripts spent.pl and ordered.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23397 --- Comment #6 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #5) > Could we deal with that in the template, splitting up the string and > displaying all itemtypes of an order? > > Worried about this one as it makes the amounts not add up... and libraries > don't like that. We could show the concatenated itypes if GetDescription does not come up with a value? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23397] Order lines can be duplicated in acqui scripts spent.pl and ordered.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23397 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer --- Could we deal with that in the template, splitting up the string and displaying all itemtypes of an order? Worried about this one as it makes the amounts not add up... and libraries don't like that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23397] Order lines can be duplicated in acqui scripts spent.pl and ordered.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23397 --- Comment #4 from Marcel de Rooy --- BTW While testing: DBD::mysql::st execute failed: Incorrect double value: '' for column `koha_master`.`aqorders`.`discount` at row 1 [for Statement "UPDATE aqorders SET basketno=?, biblionumber=?, quantity=?, budget_id=?, currency=?, listprice=?, discount=?, rrp=?, replacementprice=?, ecost=?, unitprice=?, order_internalnote=?, order_vendornote=?, sort1=?, sort2=?, subscriptionid=?, uncertainprice=?, tax_rate_on_ordering=?, rrp_tax_excluded=?, rrp_tax_included=?, ecost_tax_excluded=?, ecost_tax_included=?, tax_value_on_ordering=?, timestamp=NOW() WHERE ordernumber=?" with ParamValues: 0="67", 1="2578", 2="2", 3="123", 4="USD", 5="10", 6="", 7="10.00", 8="10.00", 9="10.00", 10="0.00", 11="", 12="", 13="", 14="", 15=undef, 16="0", 17="0", 18="10.00", 19="10", 20="10", 21="10", 22="0", 23="15"] at /usr/share/koha/C4/Acquisition.pm line 1358. With strict SQL saving the order failed invisibly.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
