[Koha-bugs] [Bug 23577] OPAC - patron e-mail notification of new login location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23577 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23601] New: Middle clicking a title from search results creates two tabs or a new tab and a new window in Firefox
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 Bug ID: 23601 Summary: Middle clicking a title from search results creates two tabs or a new tab and a new window in Firefox Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: bdaeu...@cityoffargo.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com When middle-clicking or ctrl-clicking a title in the results screen of the staff client, Firefox opens two new tabs. To reproduce: 1. Use a relatively recent version of Firefox (I've tested this on 68esr and 69) 2. Search for an item in the staff interface 3. From the results screen, middle click or control click a title. 4. Depending on your Firefox settings, Firefox will open an new window and a new tab or two new tabs. The popup blocker may also block the opening of these tabs. This appears to be related to the preventdefault() being used here, which Firefox handles differently than other browsers. There's the broader discussion of whether there's any need to use preventdefault() here at all. From the comments in the jquery it appears that someone thought it wasn't a good idea. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22988] Visible reduction in image quality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22988 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17650] Create the option to save the cover with the uploaded files.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #15 from Owen Leonard --- The patch applies fine (wow), and I have one suggestion right off the bat: The system preference should be worded and structured in a way that it is a sentence. Instead of: [Yes/No] Save the covers on the the hard disk instead of the database. It should be something like: Save cover images on the [hard disk/database]. Would it be clearer to say "server file system" instead of "hard disk?" Could people be confused that it referred to their own hard disk? I ran into a problem, though, as soon as I navigated to the 'Upload local cover image' page: Can't locate Koha/Upload.pm in @INC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23600] New: url broken in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23600 Bug ID: 23600 Summary: url broken in advanced search Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: aova...@biteca.com QA Contact: testo...@bugs.koha-community.org Hello, When performing an advanced search I have several libraries defined in a group. When performing the search it works fine, but when browsing the results it throws URL error (Request-URI Too LongThe requested URL's length exceeds the capacity limit for this server.) How could this be resolved from Koha or from the server? Regards! Andrés -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23384] Calling Koha::Article::Status::* without "use" in Patron.pm can cause breakage
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23384 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com --- Comment #2 from Michal Denar --- Hi Andrew, can you provede test plan for this patch? Thank you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23580] Add C4::Context->yaml_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23580 Tomás Cohen Arazi changed: What|Removed |Added Text to go in the||This trivial patch adds a release notes||convenient way to retrieve ||YAML-based system ||preferences in the code, ||avoiding the need to handle ||the decoding in each place ||they are used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6759] Use a different account type for account renewals than for new accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759 --- Comment #13 from Tomás Cohen Arazi --- Created attachment 92767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92767=edit Bug 6759: (QA follow-up) Unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6759] Use a different account type for account renewals than for new accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 92766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92766=edit Bug 6759: Update existing accountlines for 'A' Signed-off-by: Martin Renvoize Signed-off-by: Maryse Simard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6759] Use a different account type for account renewals than for new accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759 --- Comment #11 from Tomás Cohen Arazi --- Created attachment 92765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92765=edit Bug 6759: Split account creation and renewal charges Test plan: 1. Enable charging for patron enrolement 2. Add a new patron where the category is charged for 3. Note the charge of type 'Account management fee' 4. Renew the patron 5. Note the next charge of type 'Account management fee' 6. Apply patch 7. Repeat steps 1-6 and note the first charge will be of type 'Account creation fee' and the second of type 'Account renewal fee' 8. Bonus points, enable 'FeeOnChangePatronCategory' and check that when changing a patron from a free category to a charged one that a new 'Account renewal fee' is charged. Signed-off-by: Martin Renvoize Signed-off-by: Maryse Simard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Agustín Moyano changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #227 from Agustín Moyano --- Created attachment 92762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92762=edit Bug 22284: Add "patron's hold group" as new hold_fulfillment_policy option This patch adds "patron's hold group" as a new option to Hold pickup library match To test: 1. Set ReservesControlBranch preference to item. 2. Create a hold group 3. Go to circulation and fines rules SUCCESS => in 'Hold pickup library match' there is a new option called "patron's hold group" 4. In a library not in hold group set 'Hold policy' to "any" and 'Hold pickup library match' to "patron's hold group" 5. Search for a user in the hold group 6. 'Search to hold' for items of the library of step 4 7. Select an item and 'Place hold for [user]' SUCCESS => in 'Pickup at' you should see patron's hold group as options 8. In OPAC sign in as the same user of step 5 9. Search for the item in step 7 SUCCESS => in 'Pick up locations' you should see patron's hold group as options 10. Sign off Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #229 from Agustín Moyano --- Created attachment 92764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92764=edit Bug 22284: (Do not push) Schema update Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #228 from Agustín Moyano --- Created attachment 92763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92763=edit Bug 22284: (follow-up) Squash multiple follow-ups * Bug 22284: (follow-up) Use GetReserveControlBranch in Koha::Item->pickup_locations Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Fix tests Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Fix typo in request.tt Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Filter pickup on specific item click Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Fix typos transfered -> transferred Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #226 from Agustín Moyano --- Created attachment 92761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92761=edit Bug 22284: (follow-up) Squash multiple follow-ups * Bug 22284: (follow-up) Remove commented warn and address test failures Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec * Bug 22284: (follow-up) fix test count after merge Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec * Bug 22284: (follow-up) fixes after 15496 Signed-off-by: Josef Moravec * Bug 22284: (follow-up) fixes after 18936 Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Remove HomeOrHolding from reserves Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #225 from Agustín Moyano --- Created attachment 92760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92760=edit Bug 22284: Filter item's pickup locations in holds_table.inc This patch filters pickup locations per item in holds_table.inc To test: 1) Go to Circulation and fines rules and change max holds allowed to > 0, and change 'Hold pickup library match' to homebranch 2) Search for a patron 3) Click on "Search to hold" 4) Search for any bilio 5) Place hold on a specific item CHECK => Item's pickup location is a select with all libraries 6) Apply this patch 7) Repeat steps 2 to 5 SUCCESS => Item's pickup location is filtered by allowed pickup locations 8) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #223 from Agustín Moyano --- Created attachment 92758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92758=edit Bug 22284: (follow-up) Default to circulation control branch when no hold libraries are found Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #224 from Agustín Moyano --- Created attachment 92759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92759=edit Bug 22284: New message, new column and filter pickup locations in reserve/request.tt This patch adds a new message to 'Hold' column in 'Place a hold on a specific item' table. The message is "Cannot place hold from patrons's library". It appears when patron's homebranch is not in item's hold group, and hold_fulfillment_policy is set to 'holdgroup'. This patch also adds a new column "Allowed pickup locations" that lists allowed pickup locations per item. Finally, the select that displays pickup locations is filtered by allowed pickup locations, when multi_hold is not enabled To test: 1) Apply this patch 2) In library groups add a root group and check it as hold group. 3) Add two libraries to the group 4) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold policy change the value to 'From local hold group' 5) Search a patron from a different library than step 3, select one and click 'search to hold' 6) Search by location for items in any library of step 3 7) On any item, clic on 'Place hold for ...' SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Cannot place hold from patrons's library" in 'Hold' column => You should see a new column called "Allowed pickup locations" and the message is "Any library" 8) In circulation and fines rules, in 'Default checkout, hold and return policy', in 'Hold policy' change the value again to 'From any library' and change 'Hold pickup library match' to "Item's hold group" 8) Repeat steps 5 to 7 SUCCESS => when the page is loaded, you should see the "Pickup at" select filtered by libraries in hold group => You should see in "Allowed pickup locations" a coma separated list of the libraries in item's hold group => If biblio has an item whose control branch is not in a hold group, you should see the control branch name in "Allowed pickup locations" 9) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #222 from Agustín Moyano --- Created attachment 92757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92757=edit Bug 22284: Opac pickup_locations This patch modifies Koha::Libraries->pickup_location and moves most of the logic to Koha::Item and Koha::Biblio in preparation for api endpoints in the future. There where 2 methods added 1) Koha::Item->pickup_locations that given a patron, returns all pickup locations of this item, considering hold fulfillment rules, and hold allowed rules. 2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list of libraries returned by each of this biblio items pickup location. Koha::Libraries->pickup_location analyzes input param and calls Koha::Item->pickup_locations or Koha::Biblio->pickup_locations as needed. Also in opac-reserve.tt the way options where obtained to fill the pickup location select was modified to pass the patron as a parameter. To test: 1) opac: try to place hold on a item and check that all libraries are shown in the pickup location select. 2) intranet: in Library groups, add 2 root groups marked as local hold group and add different libraries to each. 3) opac: login as a user of a library belonging to one hold group, and search try to place a hold on an item belongin to the other hold group. 4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold pickup library match' rules. 5) opac: On each modification of the rules reload the page. SUCCESS => Every time you reload the page, the number of pickup locations showed in select varies. 6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t SUCCESS => Result: PASS 7) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284
--- Comment #221 from Agustín Moyano ---
Created attachment 92756
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92756=edit
Bug 22284: New methods in Koha::Library::Groups and Koha::Library
This patch adds new methods in Koha::Library::Groups and Koha::Library.
1) For Koha::Library::Groups adds get_root_ancestor that returns all root
groups for a given search parameters, for example
Koha::Library::Groups->get_root_ancestor( { id => $group_id } )
2) For Koha::Library adds
2.1) get_hold_libraries: returns all libraries (including self) that
belongs to the same holdgroups. If $self belongs to several holdgroups
it will return a distinct list of all libraries belonging to them.
2.2) validate_hold_sibling: Returns 1 if the given parameters matches any of
the
libraries that belong to any of the holdgroups this library belongs. For
example
$library->validate_hold_sibling( { branchcode => $branchcode } )
To test:
1) apply this patch
2) prove t/db_dependent/Koha/Libraries.t t/db_dependent/LibraryGroups.t
SUCCESS => green letters :-D
3) Sign off
Sponsored-by: VOKAL
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #220 from Agustín Moyano --- Created attachment 92755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92755=edit Bug 22284: Control hold groups in C4::Reserves This patch modifies C4::Reserves to control when hold group options where selected in smart rules. In CanItemBeReserved adds 2 new error status messages 1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group 2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group Also CheckReserves is modified when item's priority is defined, to control by hold group when required. Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when required. To test: 1) Apply this patch 2) prove t/db_dependent/Holds.t SUCCESS => Result: PASS 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #219 from Agustín Moyano --- Created attachment 92754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92754=edit Bug 22284: New hold group options in smart-rules This patch adds new options for 'Default checkout, hold and return policy' and 'Default holds policy by item type', both in 'Hold policy' and 'Hold pickup library match' columns To test: 1) Go to 'Circulation and fines rules' in admin 2) Check that there are no options for hold group in 'Hold policy' and 'Hold pickup library match' columns 3) Apply this patch SUCCESS => in 'Hold policy' you should see 'From local hold group' option, and in 'Hold pickup library match' you should see "Item's hold group" 4) Select any of those options and save SUCCESS => options should be selected when page reloads 5) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #92554|0 |1 is obsolete|| Attachment #92555|0 |1 is obsolete|| Attachment #92556|0 |1 is obsolete|| Attachment #92557|0 |1 is obsolete|| Attachment #92558|0 |1 is obsolete|| Attachment #92559|0 |1 is obsolete|| Attachment #92560|0 |1 is obsolete|| Attachment #92561|0 |1 is obsolete|| Attachment #92562|0 |1 is obsolete|| Attachment #92563|0 |1 is obsolete|| Attachment #92564|0 |1 is obsolete|| Attachment #92565|0 |1 is obsolete|| Attachment #92566|0 |1 is obsolete|| Attachment #92567|0 |1 is obsolete|| Attachment #92568|0 |1 is obsolete|| Attachment #92569|0 |1 is obsolete|| Attachment #92570|0 |1 is obsolete|| Attachment #92571|0 |1 is obsolete|| Attachment #92572|0 |1 is obsolete|| Attachment #92573|0 |1 is obsolete|| Attachment #92574|0 |1 is obsolete|| --- Comment #217 from Agustín Moyano --- Created attachment 92752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92752=edit Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option In order to add groups for holds, this patch provides a new column in library_groups to identify them. Also provides new enum option for hold_fulfillment_policy column of default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules. To test: 1) check that there is no ft_local_hold_group column in library_groups and that there are no 'holdgroup' enum option in hold_fulfillment_policy in default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules 2) apply this patch 3) perl installer/data/mysql/updatedatabase.pl && dbic SUCCESS => !(step 1) ;-D 4) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #218 from Agustín Moyano --- Created attachment 92753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92753=edit Bug 22284: Add new checkbox in Library Groups This patch adds a new checkbox option 'Is local hold group' when you create a new root group. To test: 1) In intranet go to Library Groups in admin module 2) Add new root group 3) Check that there is no 'Is local hold group' checkbox 4) Apply this patch 5) Add new root group SUCCESS => a new 'Is local hold group' checkbox appears 6) Select 'Is local hold group' and save 7) Click edit button for root group SUCCESS => 'Is local hold group' is checked 8) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19618] Add 'Club Holds' feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 --- Comment #18 from Agustín Moyano --- (In reply to Martin Renvoize from comment #15) > This all seems to work well enough to me.. Signing off.. > > Some QA notes though.. What happens if the club is disbanded (deleted).. > should the holds also be removed.. I don't see anything here doing that? Hi Martin, thanks for taking the time. I really wouldn't touch holds that were already placed, even if club was deleted. Patrons may depend on that hold. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6759] Use a different account type for account renewals than for new accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759 Tomás Cohen Arazi changed: What|Removed |Added Attachment #91663|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6759] Use a different account type for account renewals than for new accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759 Tomás Cohen Arazi changed: What|Removed |Added Attachment #91662|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6759] Use a different account type for account renewals than for new accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22744] 'Do not notify' is really a 'Clear' option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744 Martin Renvoize changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22744] 'Do not notify' is really a 'Clear' option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Signed Off --- Comment #25 from Martin Renvoize --- I prefer the 'alternate'.. i.e. removing the column altogether pending 5501 being worked on to properly implement the feature... however.. that patch needs some more work as it does not currently include the OPAC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6759] Use a different account type for account renewals than for new accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com QA Contact|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23228] Add option to automatically display payment receipt for printing after making a payment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23228 Martin Renvoize changed: What|Removed |Added Text to go in the|This enhancement adds the |This enhancement adds the release notes|optional ability to |optional ability to |automatically popup the |automatically popup the |receipt print dialogue upon |receipt print dialogue upon |successful payments in the |successful payments in the |staff client. |staff client. | | |Note: The | |new `FinePaymentAutoPopup` |Note: The |must be enabled and popup |new `FinePaymentAutoPopup` |blocker may require setting |must be enabled and popup |to allow popups for your|blocker may require setting |Koha staff client domain. |to allow popups for your ||Koha staff client domain. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Martin Renvoize changed: What|Removed |Added Text to go in the|**Important Note**: |**Important Note**: release notes|misc/batchRebuildBiblioTabl |misc/batchRebuildBiblioTabl |es.pl should be run, after |es.pl should be run, after |this enhancement is |this enhancement is |applied, to populate the|applied, to populate the |fields in the database, and |fields in the database, and |it will take some time for |it will take some time for |larger databases. |larger databases. | | |Keywords| |to MARC mapping |Keywords to MARC mapping |functionality has been |functionality has been |replaced with additional|replaced with additional |Koha fields in the |Koha fields in the |bibliographic framework. |bibliographic framework. || |The keyword mapping only| |offered a single field, |The keyword mapping only |subtitle, and the |offered a single field, |information was always |subtitle, and the |retrieved from the MARC |information was always |record, which made it |retrieved from the MARC |relatively slow. The|record, which made it |subtitle and other relevant |relatively slow. The |fields are now available as |subtitle and other relevant |normal Koha fields: |fields are now available as | |normal Koha fields: || |biblio.medium - Medium | |information (MARC 21: 245h, | |UNIMARC: 200b) |biblio.medium - Medium ||information (MARC 21: 245h, |biblio.subtitle - Subtitle |UNIMARC: 200b) |(MARC 21: 245b, UNIMARC:| |200e) |biblio.subtitle - Subtitle | biblio.part_number |(MARC 21: 245b, UNIMARC: |- Part number (MARC 21: |200e) |245n, UNIMARC: 200h) | ||biblio.part_number - Part |biblio.part_name - Part |number (MARC 21: 245n, |name (MARC 21: 245p,|UNIMARC: 200h) |UNIMARC: 200i) | | |biblio.part_name - Part |The |name (MARC 21: 245p, |subfields in the default|UNIMARC: 200i) |framework are automatically | |updated to include these| |new fields unless they are |The |already mapped to another |subfields in the default |Koha field. |framework are automatically ||updated to include these ||new fields unless they are ||already mapped to another ||Koha field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23228] Add option to automatically display payment receipt for printing after making a payment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23228 Martin Renvoize changed: What|Removed |Added Text to go in the|This enhancement adds the |This enhancement adds the release notes|optional ability to |optional ability to |automatically popup the |automatically popup the |receipt print dialogue upon |receipt print dialogue upon |successful payments. in the |successful payments in the |staff client. |staff client. | | |Note: The |Note: The |new `FinePaymentAutoPopup` |new `FinePaymentAutoPopup` |must be enabled and popup |must be enabled and popup |blocker may require setting |blocker may require setting |to allow popups for your|to allow popups for your |Koha staff client domain. |Koha staff client domain. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23584] Add public routes to change privacy settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23584 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Martin Renvoize changed: What|Removed |Added Text to go in the||SPONSORED BY: Vermont release notes||Organization of Koha ||Automated Libraries -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19618] Add 'Club Holds' feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 --- Comment #17 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #16) > Also.. was this sponsored by anyone? Southeast Kansas Library - SEKLS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #216 from Martin Renvoize --- (In reply to Martin Renvoize from comment #215) > Sponsored-by line is 'VOKAL'.. do they have an expanded name or is that it? `Vermont Organization of Koha Automated Libraries` perhaps? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #215 from Martin Renvoize --- Sponsored-by line is 'VOKAL'.. do they have an expanded name or is that it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19618] Add 'Club Holds' feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 --- Comment #16 from Martin Renvoize --- Also.. was this sponsored by anyone? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19618] Add 'Club Holds' feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 Martin Renvoize changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19618] Add 'Club Holds' feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #15 from Martin Renvoize --- This all seems to work well enough to me.. Signing off.. Some QA notes though.. What happens if the club is disbanded (deleted).. should the holds also be removed.. I don't see anything here doing that? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19618] Add 'Club Holds' feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 Martin Renvoize changed: What|Removed |Added Attachment #92678|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize --- Created attachment 92750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92750=edit Bug 19618: Add tests This patch adds tests for new features To test: 1) prove t/db_dependent/Koha/Club/Enrollment.t 2) prove t/db_dependent/Koha/Club/Hold.t 3) prove t/db_dependent/api/v1/clubs_holds.t 4) Sign off Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19618] Add 'Club Holds' feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 --- Comment #14 from Martin Renvoize --- Created attachment 92751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92751=edit Bug 19618: (QA follow-up) POD Fix Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19618] Add 'Club Holds' feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618
Martin Renvoize changed:
What|Removed |Added
Attachment #92677|0 |1
is obsolete||
--- Comment #12 from Martin Renvoize ---
Created attachment 92749
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92749=edit
Bug 19618: Add api endpoint for club holds
This patch adds an endpoint in thi api in /api/v1/clubs/{club_id}/holds whith
the verb POST that maps to Koha::REST::V1::Clubs::Holds#add controller.
Classes for club_holds and club_holds_to_patron_holds new tables where also
added.
To test:
1) Reach SUCCESS.3 test point of previous patch with club that has no
enrollments
2) Click on "Place Hold"
SUCCESS => an alert should appear that you cannot place hold on a club without
patrons
3) Reach SUCCESS.3 test point of previous patch with club that has enrollments
4) Click on "Place Hold"
SUCCESS => holds priority list should appear with holds for every patron in
club
5) Repeat steps 3 and 4.
SUCCESS => new holds should appear in different order
6) Sign off
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19618] Add 'Club Holds' feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 Martin Renvoize changed: What|Removed |Added Attachment #92676|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 92748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92748=edit Bug 19618: Add ability to place holds for members of a club in intranet This patch adds the ability to place a hold for each member of a club in random order. To test: 1) apply this patch 2) create 2 clubs, (club names should have some part in common, and some part different for each other) 3) in one of them add at least 6 members 4) enter patron clubs management and click on "Actions" button SUCCESS.1 => club with members has a new action called "search to hold" 5) click on search to hold SUCCESS.2 => in the list of bilios there appears an action called "Place hold for " 6) click on "Place hold for " SUCCESS.3 => a new window appears where you can select pickup location (defaults to club's library, if any), and the list of members. 7) go back to the list of bilios in the catalog and click on "Forget " 8) click on "Holds" action of any biblio SUCCESS.4 => a search box appears with two tabs: Patrons and Clubs 9) click on Clubs tab and search by the common part of clubs names SUCCESS.5 => a list of clubs that matches the search appears. If you click on any of them, the same page as SUCCESS.3 appears. 10) go back to the search box in SUCCESS.4 and search by the different part of the name. SUCCESS.6 => because there is only one club that matches search criteria, the same page as SUCCESS.3 appears; 11) Sign off Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19618] Add 'Club Holds' feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 Martin Renvoize changed: What|Removed |Added Attachment #92674|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 92746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92746=edit Bug 19618: Add club_holds and club_holds_to_patron_holds tables This patch adds 2 new tables 1. club_holds 2. club_holds_to_patron_holds They are ment to keep info about hold requests made in name of a club To test: 1) apply this patch 2) perl installer/data/mysql/updatedatabase.pl SUCCESS => 2 new tables were created Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19618] Add 'Club Holds' feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 Martin Renvoize changed: What|Removed |Added Attachment #92675|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 92747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92747=edit Bug 19618: [DO NOT PUSH] (follow-up) Schema structure Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19618] Add 'Club Holds' feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 Martin Renvoize changed: What|Removed |Added Text to go in the||This new feature adds the release notes||ability for clubs to place ||a hold for bibs. When such ||a hold is placed, in the ||background a hold will be ||automatically placed for ||each member of the group in ||random order. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19618] Add 'Club Holds' feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 Martin Renvoize changed: What|Removed |Added Keywords||Manual, ||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19618] Add 'Club Holds' feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 Martin Renvoize changed: What|Removed |Added Summary|Club holds support |Add 'Club Holds' feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19618] Club holds support
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 Martin Renvoize changed: What|Removed |Added Severity|enhancement |new feature CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21058] Missing class for results_summary spans
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21058] Missing class for results_summary spans
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058 --- Comment #11 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23580] Add C4::Context->yaml_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23580 Martin Renvoize changed: What|Removed |Added Keywords||release-notes-needed CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23580] Add C4::Context->yaml_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23580 --- Comment #11 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23580] Add C4::Context->yaml_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23580 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16825] Add API route for getting an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 --- Comment #52 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16825] Add API route for getting an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16825] Add API route for getting an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #51 from Martin Renvoize --- Agreed the terms seem sane.. not enough people present at meeting to hold a vote so I've taken the approach of asking key parties involved in the API design directly for comments.. all have agreed so I'm going to push. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15497] Limit Item Types by Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 --- Comment #34 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15497] Limit Item Types by Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15497] Limit Item Types by Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15497] Limit Item Types by Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Martin Renvoize changed: What|Removed |Added Keywords||Manual, ||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15497] Limit Item Types by Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Martin Renvoize changed: What|Removed |Added Text to go in the|Sponsored by Northeast | release notes|Kansas Library System, | |Southeast Kansas Library| |System and Central Kansas | |Library System. | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15497] Limit Item Types by Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Martin Renvoize changed: What|Removed |Added Attachment #92739|0 |1 is obsolete|| --- Comment #32 from Martin Renvoize --- Created attachment 92745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92745=edit Bug 15497: (QA follow-up) Fix call in search_with_localization Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15497] Limit Item Types by Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 --- Comment #33 from Martin Renvoize --- Sponsor lines moved into commit message so they're caught by the release notes script. Thankyou Northeast Kansas Library System, Southeast Kansas Library System and Central Kansas Library System. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15497] Limit Item Types by Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Martin Renvoize changed: What|Removed |Added Attachment #92737|0 |1 is obsolete|| --- Comment #30 from Martin Renvoize --- Created attachment 92743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92743=edit Bug 15497: Limit itemtypes by branch in additem.pl This patch adds a select multiple when you add/edit an itemtype, creates functions to return itemtypes by library, and filters the options of itemtype select in additem To test: 1) Apply this patch set 2) perl installer/data/mysql/updatedatabase.pl 3) In koha administration => item types, edit "Books" itemtype CHECK => there is now a select multiple whith libraries at the bottom 4) select centerville and save 5) set centerville as current libary 6) search for any biblio in the catalog 7) click on "edit items" CHECK => book item type is present 8) set any other libary as current library SUCCESS => book item type is not present 9) Sign off Sponsored-by: Northeast Kansas Library System Sponsored-by: Southeast Kansas Library System Sponsored-by: Central Kansas Library System Signed-off-by: Jessica Zairo Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15497] Limit Item Types by Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Martin Renvoize changed: What|Removed |Added Attachment #92738|0 |1 is obsolete|| --- Comment #31 from Martin Renvoize --- Created attachment 92744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92744=edit Bug 15497: (QA follow-up) Use the methods from bug 23281 instead Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15497] Limit Item Types by Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Martin Renvoize changed: What|Removed |Added Attachment #92736|0 |1 is obsolete|| --- Comment #29 from Martin Renvoize --- Created attachment 92742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92742=edit Bug 15497: Modify schemas Sponsored-by: Northeast Kansas Library System Sponsored-by: Southeast Kansas Library System Sponsored-by: Central Kansas Library System Signed-off-by: Jessica Zairo Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15497] Limit Item Types by Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Martin Renvoize changed: What|Removed |Added Attachment #92735|0 |1 is obsolete|| --- Comment #28 from Martin Renvoize --- Created attachment 92741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92741=edit Bug 15497: Add itemtypes_branches table and atomic update Sponsored-by: Northeast Kansas Library System Sponsored-by: Southeast Kansas Library System Sponsored-by: Central Kansas Library System Signed-off-by: Jessica Zairo Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15497] Limit Item Types by Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 --- Comment #27 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #26) > All works well for me and passes QA scripts... No obvious regressions. > > Passing QA. Thanks! > Some minor additions in the future might be nice.. there's nothing that ties > this in at the circ rules level.. one can still create a circ rule at any > branch with any itemtype for example and there's nothing to prevent an item > being permanently transferred to the branch without that itemtype and as > such you end up with an incorrectly types item at that branch. > > I don't see either of the above as failure points, but perhaps worth > mentioning and perhaps a followup bug creating to document these > shortcomings. I'm sure the consortia that sponsored this dev will have interesting additions and requests to make now that this is in master and can have a real-life test drive! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15497] Limit Item Types by Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #26 from Martin Renvoize --- All works well for me and passes QA scripts... No obvious regressions. Passing QA. Some minor additions in the future might be nice.. there's nothing that ties this in at the circ rules level.. one can still create a circ rule at any branch with any itemtype for example and there's nothing to prevent an item being permanently transferred to the branch without that itemtype and as such you end up with an incorrectly types item at that branch. I don't see either of the above as failure points, but perhaps worth mentioning and perhaps a followup bug creating to document these shortcomings. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376
Koha Team Lyon 3 changed:
What|Removed |Added
Attachment #76876|0 |1
is obsolete||
--- Comment #58 from Koha Team Lyon 3 ---
Created attachment 92740
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92740=edit
Bug 7376 Transfer limits should be checked at check-in
to answer to Victor (comment 56), the response is no, seems that bug 22330
don't encompass this one.
When you return an unauthorized item (according to the branch transfer limits
table), you get only a message "Please return this item to such branch", but
the return is done as well.
So the need to add a checking on branch transfert status is still on the
agenda.
The patch proposed is essentially the initial one from Martin Renvoize with a
little variant to tie the checking with the "anywhere" position of
ReturnToBranch syspref (because a priori, the need is much likely to appear in
this case).
Test Plan :
* ReturnToBranch must be set to "anywhere"
* UseBranchTransferLimits must be set
1) define your branch transfer limit. Refuse transfers from libraryA to
libraryOwner (= refuse return at libraryA of a book located at libraryOwner).
2) checkout a book owned by libraryOwner, at libraryOwner, with a librarian
located at libraryOwner
3) move the librarian to libraryA ("Set Library" link top/right)
4) check-in the book => "you get the message Please return this item to
libraryOwner"
Note that you get the same message whether the transfert from libraryA to
libraryOwner is authorized or not.
5) Install the patch
6) Redo steps 2 to 4
The message you get now at step 4 is "Cannot check in ... This item must be
checked in at following library: libraryOwner"
Olivier Crouzet
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15497] Limit Item Types by Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Martin Renvoize changed: What|Removed |Added Attachment #92727|0 |1 is obsolete|| --- Comment #23 from Martin Renvoize --- Created attachment 92737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92737=edit Bug 15497: Limit itemtypes by branch in additem.pl This patch adds a select multiple when you add/edit an itemtype, creates functions to return itemtypes by library, and filters the options of itemtype select in additem To test: 1) Apply this patch set 2) perl installer/data/mysql/updatedatabase.pl 3) In koha administration => item types, edit "Books" itemtype CHECK => there is now a select multiple whith libraries at the bottom 4) select centerville and save 5) set centerville as current libary 6) search for any biblio in the catalog 7) click on "edit items" CHECK => book item type is present 8) set any other libary as current library SUCCESS => book item type is not present 9) Sign off Signed-off-by: Jessica Zairo Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15497] Limit Item Types by Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Martin Renvoize changed: What|Removed |Added Attachment #92732|0 |1 is obsolete|| --- Comment #25 from Martin Renvoize --- Created attachment 92739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92739=edit Bug 15497: (QA follow-up) Fix call in search_with_localization Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15497] Limit Item Types by Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Martin Renvoize changed: What|Removed |Added Attachment #92726|0 |1 is obsolete|| --- Comment #22 from Martin Renvoize --- Created attachment 92736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92736=edit Bug 15497: Modify schemas Signed-off-by: Jessica Zairo Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15497] Limit Item Types by Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Martin Renvoize changed: What|Removed |Added Attachment #92728|0 |1 is obsolete|| --- Comment #24 from Martin Renvoize --- Created attachment 92738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92738=edit Bug 15497: (QA follow-up) Use the methods from bug 23281 instead Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15497] Limit Item Types by Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Martin Renvoize changed: What|Removed |Added Attachment #92725|0 |1 is obsolete|| --- Comment #21 from Martin Renvoize --- Created attachment 92735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92735=edit Bug 15497: Add itemtypes_branches table and atomic update Signed-off-by: Jessica Zairo Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23599] Koha::Objects::Limit::Library fails if no library passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23599 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23599] Koha::Objects::Limit::Library fails if no library passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23599 --- Comment #6 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23599] Koha::Objects::Limit::Library fails if no library passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23599 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23599] Koha::Objects::Limit::Library fails if no library passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23599 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23599] Koha::Objects::Limit::Library fails if no library passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23599 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #5 from Martin Renvoize --- Straight to QA.. works well, fixes the issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23599] Koha::Objects::Limit::Library fails if no library passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23599 Martin Renvoize changed: What|Removed |Added Attachment #92731|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 92734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92734=edit Bug 23599: Avoid exploding in search_with_library_limits when no library is passed Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23599] Koha::Objects::Limit::Library fails if no library passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23599 Martin Renvoize changed: What|Removed |Added Attachment #92730|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 92733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92733=edit Bug 23599: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15497] Limit Item Types by Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 92732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92732=edit Bug 15497: (QA follow-up) Fix call in search_with_localization Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23599] Koha::Objects::Limit::Library fails if no library passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23599 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17650] Create the option to save the cover with the uploaded files.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650 Holly changed: What|Removed |Added CC||h...@interleaf.ie --- Comment #14 from Holly --- Hi, I was just wondering if someone could provide some test steps for this please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23599] Koha::Objects::Limit::Library fails if no library passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23599 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 92731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92731=edit Bug 23599: Avoid exploding in search_with_library_limits when no library is passed Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15497] Limit Item Types by Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Tomás Cohen Arazi changed: What|Removed |Added Depends on||23599 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23599 [Bug 23599] Koha::Objects::Limit::Library fails if no library passed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23599] Koha::Objects::Limit::Library fails if no library passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23599 Tomás Cohen Arazi changed: What|Removed |Added Depends on||23281 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281 [Bug 23281] Add Koha::Objects::Limit::Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23599] Koha::Objects::Limit::Library fails if no library passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23599 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 92730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92730=edit Bug 23599: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23599] Koha::Objects::Limit::Library fails if no library passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23599 Tomás Cohen Arazi changed: What|Removed |Added Blocks||15497 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 [Bug 15497] Limit Item Types by Branch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23281] Add Koha::Objects::Limit::Library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281 Tomás Cohen Arazi changed: What|Removed |Added Blocks||23599 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23599 [Bug 23599] Koha::Objects::Limit::Library fails if no library passed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23599] Koha::Objects::Limit::Library fails if no library passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23599 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23599] New: Koha::Objects::Limit::Library fails if no library passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23599 Bug ID: 23599 Summary: Koha::Objects::Limit::Library fails if no library passed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org The search_with_library_limits method is not tested, and when used in 15497 it proved to explode when no library is passed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23101] Contracts permissions for staff patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23101 Holly changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||h...@interleaf.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23101] Contracts permissions for staff patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23101 ByWater Sandboxes changed: What|Removed |Added Attachment #91510|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 92729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92729=edit Bug 23101: Hide action buttons on contracts if user lacks permission When the user doesn't have superlibrarian, full acq or contracts_manage permission, don't show buttons for editing and deleting contracts. To test: - Create a vendor with a few contracts - Create a staff user with - superlibrarian = can view edit/delete contracts - full acq perms = same - without manage_contracts = can view, but action buttons are gone - Make sure the sorting of the contracts table works in all cases Signed-off-by: hc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15497] Limit Item Types by Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 --- Comment #19 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #14) > I think this shoudl depend on bug 23281? > > +use base qw(Koha::Object Koha::Object::Limit::Library); That was correct boss, it is just that Agustin wrote this and then I realized we had to have 23281 and stop repeating code. Thanks for pointing it out! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
