[Koha-bugs] [Bug 19406] REST API: Add route for checkins

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19406

Owen Leonard  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19814

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19814] Batch Check-in function

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814

Owen Leonard  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19406
Version|unspecified |master

--- Comment #6 from Owen Leonard  ---
Bug 19406 would simplify this feature a lot.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23756] New: Appendix for workflows

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23756

Bug ID: 23756
   Summary: Appendix for workflows
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Documentation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org

Wondering if the documentation should include workflow examples for different
tasks.  I know how different each library can be with their workflows, but
workflows seem to be a common topic, and there are multiple ways to approach
different tasks.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19814] Batch Check-in function

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #5 from Christopher Brannon  ---
Would find this useful for libraries with a wireless scanner.  Staff could scan
all the items they find lying around from in-house use and shelve them rather
than cart them back to a computer, check them in for in-house use, and then
shlep them all back to the shelves.  They could just upload all the barcodes
into a barcode text box and check them in at once.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11808] When searching for a cardnumber in the intranet, also try to search for it on the LDAP server if one is configured and add/update user

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11808

Maryse Simard  changed:

   What|Removed |Added

 CC||maryse.sim...@inlibro.com

--- Comment #11 from Maryse Simard  ---
For now, I've rebased the patch on current master and started to fix the
problems reported. Among those fixes, I've added a third option, as Katrin
suggested, for the system preference.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11808] When searching for a cardnumber in the intranet, also try to search for it on the LDAP server if one is configured and add/update user

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11808

--- Comment #10 from Maryse Simard  ---
Created attachment 93768
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93768=edit
Bug 11808: (QA follow-up) Adds a third option to SearchCardnumberWithLDAP and
other fixes

This patch does a few things:

- Adds a third option to the new system preference to choose between:
never use ldap,
make a request (and add) only when no patron is found,
and always make a request (add/update).
- Adds search and update with ldap in the case the patron is found
by it's cardnumber in circulation.
- Use Patron object in the new subs in C4/Auth_with_ldap.pm.

To test:
0. You need to have an ldap server containing patron informations
configured in Koha.

1. Apply patch and update database.

2. Check that the new system preference SearchCardnumberWithLDAP has
been added and set as 'never'.

3. Choose a patron who exists in your ldap server but not in Koha.
(you can delete an existing patron from Koha if needed)

4. Search for the patron by both it's cardnumber and any other
attributes (results should be the same in both case) in the search
bar in circ/circulation.pl.Do not choose from the dropdown list,
use the submit button.
=> Should return cardnumber not found

5. Change SearchCardnumberWithLDAP to 'if not found locally'.

6. Repeat step 4.
=> The patron should be added to Koha.

7. Edit the patron and change any of the existing information.

8. Repeat step 4.
=> The patron has not been updated (the change made in step 7 is
still there)

9. Change SearchCardnumberWithLDAP to 'always'.

10. Repeat step 4.
=> The patron has been updated. Change made in step 7 has been
rewritten and patron informations is the same as in step 6.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11808] When searching for a cardnumber in the intranet, also try to search for it on the LDAP server if one is configured and add/update user

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11808

--- Comment #9 from Maryse Simard  ---
Created attachment 93767
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93767=edit
Bug 11808: Add the SearchCardnumberWithLDAP system preference.

When activated, cardnumber searches in the intranet will also do a
search on the LDAP server if a user was not found in the local database.
If the cardnumber is found on the LDAP server, the user account is
imported in the local database.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23755] New: Inventory.pl should have a texbox for direct barcode scanning

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23755

Bug ID: 23755
   Summary: Inventory.pl should have a texbox for direct barcode
scanning
 Change sponsored?: ---
   Product: Koha
   Version: 18.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org

Inventory.pl needs a textbox to scan a batch of barcodes, much like any other
batch tool.  For those of us scanning on the fly, this would be a much more
direct method than having to save to a file first.

Bug 5227 seems to address this, but I do not see the results of that bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23754] Editing notice template fails

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23754

Bin Wen  changed:

   What|Removed |Added

Summary|Editing is_html status of   |Editing notice template
   |email template fails under  |fails
   |multi-languages |
 Status|NEW |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23754] Editing is_html status of email template fails under multi-languages

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23754

--- Comment #1 from Bin Wen  ---
Created attachment 93766
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93766=edit
Modify the parameters in tt

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

--- Comment #40 from Tomás Cohen Arazi  ---
Created attachment 93765
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93765=edit
Bug 17314: (QA follow-up) Adjust spec

This patch makes the exposed attribute names match what is defined in
the internal mapping in the code, and also the query parameters.

It also:
- Makes 'status' an enum, as we know the list of possible values/codes...
- Removes allow-owner and allow-guarantor, as said before, endpoints in
/public namespace are allowed to use those. I didn't go and write those
endpoints becuase I wasn't sure about the restrictions that apply in the
OPAC and might differ from the ones in the staff interface.
- Some numeric values are marked as such
- Dates are strings in OpenAPI, but there's a way to specify the format
inside the string: "format": "date". Use it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23692] Certificate expired for meetings.koha-community.org

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23692

David Nind  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #1 from David Nind  ---
Looks like the certificate has been renewed, so closing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

--- Comment #38 from Tomás Cohen Arazi  ---
Created attachment 93764
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93764=edit
Bug 17314 : Added _to_model and _to_api methods and changed attirbutes naming

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

--- Comment #39 from Tomás Cohen Arazi  ---
Rebased it on top of current master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

--- Comment #37 from Tomás Cohen Arazi  ---
Created attachment 93763
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93763=edit
Bug 17314: QA Followup

Test plan unchanged

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

--- Comment #36 from Tomás Cohen Arazi  ---
Created attachment 93762
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93762=edit
Bug 17314: Migration from Swagger2 to OpenApi

This patch migrates the original implementation so it uses the new
OpenAPI plugin.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

Tomás Cohen Arazi  changed:

   What|Removed |Added

Summary|REST API: Add API route to  |Routes to create, list and
   |create, list and delete a   |delete a purchase
   |purchase suggestion |suggestion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

--- Comment #35 from Tomás Cohen Arazi  ---
Created attachment 93761
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93761=edit
Bug 17314: Routes to handle purchase suggestions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #90171|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #90172|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #90176|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #91546|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005

--- Comment #62 from Tomás Cohen Arazi  ---
Created attachment 93760
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93760=edit
Bug 17005: Fix bad rebase

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005

--- Comment #60 from Tomás Cohen Arazi  ---
Created attachment 93758
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93758=edit
Bug 17005: Test for checked_in parameter

Test plan:
prove t/db_dependent/api/v1/checkouts.t

Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005

--- Comment #59 from Tomás Cohen Arazi  ---
Created attachment 93757
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93757=edit
Bug 17005: Add checked_in checkouts to REST API response

This patch implements parameter 'checked_in' on checkouts endpoint to
enable getting circulation history.

Test plan:
1) Apply the patch and restart plack
2) Use your favorite REST API tester and play with /checkouts endpoint:
- use it without checked_in parameter
- use checked_in=1 for getting returned checkouts

Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005

--- Comment #61 from Tomás Cohen Arazi  ---
Created attachment 93759
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93759=edit
Bug 17005: Add plugin parameters to /checkouts endpoint

Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #91237|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #91238|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #91235|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23754] New: Editing is_html status of email template fails under multi-languages

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23754

Bug ID: 23754
   Summary: Editing is_html status of email template fails under
multi-languages
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bin@inlibro.com
QA Contact: testo...@bugs.koha-community.org

letter.tt did not pass the parameter 'lang' of 'is_html' to letter.pl,
resulting in the failure to save the 'is_html' value of the corresponding
language.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #91236|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16910] Authority search plugin in cataloguing stops at 15 pages

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16910

Myka Kennedy Stephens  changed:

   What|Removed |Added

 CC||mkstephens@lancasterseminar
   ||y.edu

--- Comment #4 from Myka Kennedy Stephens  ---
I am seeing this bug in 18.11. A search in our authorities for heading "is
exactly" Catholic Church returned 723 results. The page links at the top show
<< 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 >>. You can click through these to see
each page of the results, and page 15 shows the results up to 300. Clicking on
>> takes you to results higher than 300, but the page number links do not
change.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13881] Add desk management

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

--- Comment #26 from Josef Moravec  ---
Comment on attachment 93453
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93453
Bug 13881: kohastructure and atomic update

Review of attachment 93453:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=13881=93453)
-

::: installer/data/mysql/kohastructure.sql
@@ +1842,4 @@
>CONSTRAINT `reserves_ibfk_2` FOREIGN KEY (`biblionumber`) REFERENCES 
> `biblio` (`biblionumber`) ON DELETE CASCADE ON UPDATE CASCADE,
>CONSTRAINT `reserves_ibfk_3` FOREIGN KEY (`itemnumber`) REFERENCES `items` 
> (`itemnumber`) ON DELETE CASCADE ON UPDATE CASCADE,
>CONSTRAINT `reserves_ibfk_4` FOREIGN KEY (`branchcode`) REFERENCES 
> `branches` (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE,
> +  CONSTRAINT `reserves_ibfk_5` FOREIGN KEY (`itemtype`) REFERENCES 
> `itemtypes` (`itemtype`) ON DELETE CASCADE ON UPDATE CASCADE,

added comma at the end of line by mistake...

@@ +1885,4 @@
>  ON DELETE SET NULL ON UPDATE SET NULL,
>CONSTRAINT `old_reserves_ibfk_4` FOREIGN KEY (`itemtype`) REFERENCES 
> `itemtypes` (`itemtype`)
>  ON DELETE SET NULL ON UPDATE SET NULL
> +ON DELETE SET NULL ON UPDATE SET NULL

line duplicated by mistake

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23731] Staff & OPAC both will display the DDC call number in XSLT but can't display the LC call number

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23731

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #93754|0   |1
is obsolete||

--- Comment #6 from ByWater Sandboxes  ---
Created attachment 93756
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93756=edit
Bug 23731: Give staff detail/OPAC detail option to display LOC classification

Signed-off-by: Kelly McElligott 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23677] Add route to get a bibliographic record

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23415] Notify patron fines when renewing

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #3 from Christopher Brannon  ---
I'm trying this on a sandbox, but I am not seeing any change in either renewal
process with the patch applied.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23735] area-userblock remains visible when empty

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23735

Christopher Brannon  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23735] area-userblock remains visible when empty

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23735

--- Comment #5 from Christopher Brannon  ---
I will mark this resolved and open a new bug on removing things from these
preferences.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23735] area-userblock remains visible when empty

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23735

--- Comment #4 from Christopher Brannon  ---
Well, I feel stupid.

However, I found that if I had a blank line and used delete or backspace, even
repeatedly on both, it will not get rid of everything.  I have to leave the
blank line and use CTRL-A and delete to get rid of anything hidden.  That isn't
very intuitive.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23718] New REST route for get and modify patron notifications preferences

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23718

claire.hernan...@biblibre.com  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from claire.hernan...@biblibre.com 
 ---
@Katrin. Oh yes thank you, I searched in bugzilla but not with the good words
:/

It is "in discussion" :( I close this one, we'll try to follow the  other.

Regards.

*** This bug has been marked as a duplicate of bug 17505 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17505] Add routes for messaging preferences

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505

--- Comment #22 from claire.hernan...@biblibre.com 
 ---
*** Bug 23718 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17505] Add routes for messaging preferences

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505

claire.hernan...@biblibre.com  changed:

   What|Removed |Added

 CC||claire.hernandez@biblibre.c
   ||om

--- Comment #21 from claire.hernan...@biblibre.com 
 ---
Does someone working on this BZ recently ?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22882] ItemType translation modal is not consistent with other modals

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22882

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #2 from Lucas Gass  ---
When I delete a translation it works but it also simultaneously displays:

The translation (id *) has been removed
successfully

AND 

An error occurred when deleting this
translation


They both disappear after about 3 or 4 seconds. Not sure whats going on here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23731] Staff & OPAC both will display the DDC call number in XSLT but can't display the LC call number

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23731

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22294] EDI wrongly assumes all ISBN13's have corresponding ISBN10's

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22294

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22294] EDI wrongly assumes all ISBN13's have corresponding ISBN10's

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22294

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #93668|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 93755
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93755=edit
Bug 22294: Check return of as_isbn10 before calling methods on it

Signed-off-by: Brendan Gallagher 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23731] Staff & OPAC both will display the DDC call number in XSLT but can't display the LC call number

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23731

Lucas Gass  changed:

   What|Removed |Added

Version|18.11   |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23731] Staff & OPAC both will display the DDC call number in XSLT but can't display the LC call number

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23731

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #5 from Lucas Gass  ---
Owen, that deletion was just a mistake on my part. I supplied a new patch that
also in includes the 050$b

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23731] Staff & OPAC both will display the DDC call number in XSLT but can't display the LC call number

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23731

Lucas Gass  changed:

   What|Removed |Added

  Attachment #93740|0   |1
is obsolete||

--- Comment #4 from Lucas Gass  ---
Created attachment 93754
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93754=edit
Bug 23731: Give staff detail/OPAC detail option to display LOC classification

This patch add the LOC classifiction number to the OPAC details and Staff
details page.
TO TEST:
1. Add/find a record with a classification number in the 050$a and 050$b field.
2. View the details page on both OPAC and staff.
3. Notice no LOC classification number is displaying.
4. Apply patch.
5. Refresh the OPAC/staff and see that the LOC classification number is
displaying.
6. Rejoice.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23710] Holds broken on intranet, displays a JSON page with an error

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710

--- Comment #24 from Agustín Moyano  ---
(In reply to Marcel de Rooy from comment #23)
> (In reply to Agustín Moyano from comment #21)
> > (In reply to Marcel de Rooy from comment #20)
> 
> > On point [2], I agree that code in API modules should be as simple and clean
> > as possible, but business logic must be checked on the "API side".. we can
> > not rely that it will be implemented on the cliente side. Maybe this kind of
> > logic could be implemented with helpers of mojolicious. What are your
> > thoughts?
> 
> Yes it must be checked on the API side. But iirc the idea was that the
> business logic should (mostly) be in the Koha objects, not duplicated on the
> REST API side. Because code redundancy == inconsistency && bugs.

Yes, of course.. I thoughts it after I commented before. I'll make a new bug to
move that code.

Thanks again

Thanks again

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23677] Add route to get a bibliographic record

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677

--- Comment #21 from Kyle M Hall  ---
Created attachment 93753
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93753=edit
Bug 23677: Unit tests

This patch introduces tests for the GET /biblios/{biblio_id} endpoint.
It tries to cover all the use cases.

To test:
- Apply this patchset
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/biblios.t
=> SUCCESS: Tests pass!
- Use Postman (or your favourite tool) to test the API
=> SUCCESS: Works as expected!
- Sign off :-D

Signed-off-by: Arthur Suzuki 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23677] Add route to get a bibliographic record

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677

--- Comment #20 from Kyle M Hall  ---
Created attachment 93752
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93752=edit
Bug 23677: Controller method and dependencies tweak

Signed-off-by: Arthur Suzuki 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23677] Add route to get a bibliographic record

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677

--- Comment #19 from Kyle M Hall  ---
Created attachment 93751
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93751=edit
Bug 23677: Schema fix

Signed-off-by: Arthur Suzuki 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23677] Add route to get a bibliographic record

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #93679|0   |1
is obsolete||
  Attachment #93680|0   |1
is obsolete||
  Attachment #93681|0   |1
is obsolete||
  Attachment #93682|0   |1
is obsolete||

--- Comment #18 from Kyle M Hall  ---
Created attachment 93750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93750=edit
Bug 23677: OpenAPI spec for GET /biblios/{biblio_id}

Signed-off-by: Arthur Suzuki 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23677] Add route to get a bibliographic record

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8645] Fix background-job-progressbar.js for translations

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645

Owen Leonard  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23753

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23753] New: Background job JavaScript should not try to call humanMsg library

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23753

Bug ID: 23753
   Summary: Background job JavaScript should not try to call
humanMsg library
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

While trying to fix Bug 8645 I noticed that background-job-progressbar.js has
error-handling code which tries to call the "humanMsg" function which is
defined in the "HUMANIZED MESSAGES" plugin humanmsg.js. The plugin is currently
loaded on the following pages:

admin\preferences.tt
cataloguing\editor.tt
tools\stage-marc-import.tt

Whereas background-job-progressbar.js is used on these pages:

offline_circ\process_koc.tt
tools\batch_record_modification.tt
tools\batchMod-edit.tt
tools\manage-marc-import.tt
tools\stage-marc-import.tt
tools\upload-images.tt

The background job error handling doesn't do anything other than return the
AJAX error message, so I don't think it's worth it to add the humanmsg plugin
everywhere. Better, I think, to change it to an alert.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23752] New: Search all z39.50 / SRU targets and resource discovery layer / open link resolver from any ILL backend

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23752

Bug ID: 23752
   Summary: Search all z39.50 / SRU targets  and resource
discovery layer / open link resolver from any ILL
backend
 Change sponsored?: ---
   Product: Koha
   Version: 18.11
  Hardware: All
OS: All
Status: NEW
  Severity: new feature
  Priority: P5 - low
 Component: ILL
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: niamh.walker-hea...@it-tallaght.ie

There needs to be additional options on the manage request screen irrespective
on the ‘interface’ selected Koha/Koha, FreeForm or BL. This ‘Search’ button
should be the first button on the row, and preferably pre-populate the search
with the request metadata. This should then open a new tab or pop up window
that presents the results to the staff member. This should be the 
1. The locally appropriate resource discover layer 
and 
2. The z39.50 targets set up on the system which already pop-up in the
cataloguing module. 

Ideally the resource discovery layer and/or the open link resolver should
searchable from within the manage request screen irrespective of interface so
that subscription resources and open access materials can be located
efficiently. 


When a patron submits an ILL via the opac, library staff in 'manage request'
can't search for a provider from within the ILL functionality and have to go to
other sources directly such as the resource discovery layer, and all the
individual suppliers catalogues to identify a source. This an inefficient
workflow and a significant increase in work load.  Staff time wasted on
ensuring item is the one required on inter-library loan as there is
insufficient information on the current Koha to Koha screen, and no option at
all to search from the freeform or bl backends, therefore the search must be
repeated elsewhere. Th results presented should be be expanded to include
edition and year, but preferably be configurable as it is for the z39.50 search
in cataloguing it is currently difficult to identify the title that best
matches the request.  

Please at least enable z39.50 searching for all targets set up on the system
within ILL and not just for other koha sites. The addition of local
availability from those targets would also be of value to our staff. 


Without more details returned on a search, library staff must go to the
individual library catalogue to get more information on the title before
placing the request.  
The current system results in Staff time wasted, user frustration, and ILL
requests submitted for material already available to the user.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23710] Holds broken on intranet, displays a JSON page with an error

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710

--- Comment #23 from Marcel de Rooy  ---
(In reply to Agustín Moyano from comment #21)
> (In reply to Marcel de Rooy from comment #20)

> On point [2], I agree that code in API modules should be as simple and clean
> as possible, but business logic must be checked on the "API side".. we can
> not rely that it will be implemented on the cliente side. Maybe this kind of
> logic could be implemented with helpers of mojolicious. What are your
> thoughts?

Yes it must be checked on the API side. But iirc the idea was that the business
logic should (mostly) be in the Koha objects, not duplicated on the REST API
side. Because code redundancy == inconsistency && bugs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22114] Untranslatable "Patron note:" in checkout.js

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22114

Owen Leonard  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3] mod_env module checking in installer.pl

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3

Owen Leonard  changed:

   What|Removed |Added

  Attachment #36440|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22114] Untranslatable "Patron note:" in checkout.js

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22114

--- Comment #1 from Owen Leonard  ---
Created attachment 93749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93749=edit
Bug 22114: Untranslatable "Patron note:" in checkout.js

This patch modifies JavaScript used in circulation, replacing an
untranslatable English string in the script with a variable defined in
strings.inc which can be translated.

To test you should have the AllowCheckoutNotes system preference
enabled.

 - Apply the patch and log in to the OPAC as a user who has two or more
   items checked out.
 - From the list of checkouts on the "Your summary" page, add a note to
   two or more checked-out items.
 - Log in to the staff client and open the checkout page for that user.
   - In the table of checkouts, check the "Check in" checkbox next to
 one of the titles you added a note to.
   - Click "Renew or check in selected items."
   - A message should appear in that table row showing your note,
 prefixed with the text "Patron note:"

To test translation, update and install the de-DE template:

 > cd misc/translator
 > perl translate update de-DE
 > perl translate install de-DE

 - Go to Administration -> System preferences and enable the "Deutsch
   (de-DE)" language under I18N/L10N preferences -> language.
 - Switch to the "Deutsch" translation.
 - Go to Ausleihe (Circulation) and check out to the same patron.
   - In the table of checkouts, check the checkbox in the "Rückgabe"
 column next to another title you added a note to.
   - Click the "Markierte Exemplare zurückgeben oder verlängern" button.
   - A message should appear in that table row showing your note
 prefixed with the text "Benutzernotizen:"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22114] Untranslatable "Patron note:" in checkout.js

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22114

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23703] Updating translation bricks creating subscriptions

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23703

--- Comment #2 from Owen Leonard  ---


*** This bug has been marked as a duplicate of bug 23713 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3] mod_env module checking in installer.pl

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3

Owen Leonard  changed:

   What|Removed |Added

 CC||b.paster...@gmail.com

--- Comment #2 from Owen Leonard  ---
*** Bug 23703 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23713] Subscription add form broken for translations

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713

Owen Leonard  changed:

   What|Removed |Added

 CC||b.paster...@gmail.com

--- Comment #13 from Owen Leonard  ---
*** Bug 23703 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23703] Updating translation bricks creating subscriptions

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23703

Owen Leonard  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Owen Leonard  ---


*** This bug has been marked as a duplicate of bug 3 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22882] ItemType translation modal is not consistent with other modals

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22882

Owen Leonard  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22882] ItemType translation modal is not consistent with other modals

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22882

--- Comment #1 from Owen Leonard  ---
Created attachment 93748
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93748=edit
Bug 22882: ItemType translation modal is not consistent with other modals

This patch modifies the itemtypes administration template replacing in
the translation process the Greybox modal with a Bootstrap modal.

To test you should have at least one translation enabled.

 - Apply the patch and go to Administration -> Item types.
 - Edit an existing item type.
 - Click the "Translate into other languages" link by the "Description"
   field.
   - A Bootstrap-styled modal should appear.
   - Test the process of adding and deleting a translation.
   - Test hiding and redisplaying the modal dialog.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22882] ItemType translation modal is not consistent with other modals

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22882

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23735] area-userblock remains visible when empty

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23735

--- Comment #3 from Owen Leonard  ---
I cannot reproduce this problem in master or 18.11.09. Could you have some
empty markup in the preference?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23735] area-userblock remains visible when empty

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23735

--- Comment #2 from Christopher Brannon  ---
(In reply to Lucas Gass from comment #1)
> Christopher,
> 
> I have tried to re create this and cannot. If I take everything out of the 
> IntranetmainUserblock syspref and look at the source I do not see the
> #area-userblock. 
> 
> Looking at the intranet-main.tt it looks to have an IF that will only
> display this section if the sysprwef has content. Did you recreate this on
> master?

No.  I specifically marked this for 18.11.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23710] Holds broken on intranet, displays a JSON page with an error

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710

--- Comment #22 from Agustín Moyano  ---
This is what happens when you write with your pone..

Please s/don't sorry/don't worry/g

:P

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23710] Holds broken on intranet, displays a JSON page with an error

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710

--- Comment #21 from Agustín Moyano  ---
(In reply to Marcel de Rooy from comment #20)
> QA Comment:
> I will pass QA on this patch set since we want to resolve the issue
> introduced by the clubs feature. Need to say that we should also test stuff
> that makes a feature fail in various ways so that a thing like this should
> have been noticed in earlier testing.
> 
> I am happy that we reached a point that we start using the API in code now,
> but I think that the communication about doing so was a bit "poor" (no
> offense). I would have expected more info on the mailing list or so.. Maybe
> it was discussed in the dev meeting, but I missed it ;)
> 
> I have my doubts on the code quality in this particular case though. Which
> is probably a direct result of incorporating the API in old
> templates/scripts. I understand completely the complexity of doing this in a
> minimalistic way..
> 
> [1] The current reserve template on OPAC does not use API calls. The
> intranet template uses a mix of API calls and the old script. Solving bugs
> here will even be harder while holds already is a difficult area.
> 
> [2] The Holds module of the REST API and especially here the add subroutine
> should not contain lots of "business logic" such as e.g. testing
> AllowHoldDateInFuture here. There is really too much code there, and again a
> mix of AddReserve and Koha::Holds. Again I understand that the refactoring
> of C4/Reserves is not complete. Performance issues etc. But in the meantime
> we now also "polluted" our new REST API code?
> 
> Please do not consider this as hard criticism on the REST API, but I am just
> being concerned about the growing complexity of the codebase while we all
> are still working on parallel tracks..

Hi Marcel, first of all, thanks for testing, and don't sorry, no offence taken.

On point [1] I agree completly. OPAC should use the same method as intranet, so
I'll add a bug as soon as I can.

On point [2], I agree that code in API modules should be as simple and clean as
possible, but business logic must be checked on the "API side".. we can not
rely that it will be implemented on the cliente side. Maybe this kind of logic
could be implemented with helpers of mojolicious. What are your thoughts?

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23626] Add a system preference to limit the number of rows of data used when charting or exporting report results

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626

--- Comment #44 from Paul Hoffman  ---
(In reply to Nick Clemens from comment #35)

> The issues with exporting should probably be filed on a new separate bug to
> assess.

I've reopened bug 23685, which covers the issue with exporting.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23685] Exporting report may consume unlimited memory

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685

Paul Hoffman  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |---

--- Comment #4 from Paul Hoffman  ---
I'm reopening this as suggested by Nick Clemens in bug 23626.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23732] Hold rules checker: show matched rules and syspref values to help understand why a hold is possible or not

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |victor.grous...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21652] reserves.waitingdate is set to current date by printing new hold slip

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21652

Sally  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #19 from Caroline Cyr La Rose  ---
Hi! A lot of our libraries would love to see this added as the refunds for lost
items create many headaches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

--- Comment #23 from sandbo...@biblibre.com  ---
Created attachment 93747
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93747=edit
Bug 16126 - Display base-level amounts on the acquisition module home page

This patch will display on the acquisition module home page the information
already displayed on the "manage fund" page (aqbudgets.pl).

Currently, Koha display the base-level amounts only.

This patch will :

1. rename the column "ordered", "spent" and "available" to "base-level
[ordered|spent|available]"

2. add the column "ordered", "spent" and available with the same calculation
from the "manage fund" page.

TEST PLAN :

1. Go to the Administration module
2. Add a new budget (ie : Budget 2016)
3. Add a fund to this budget (ie : Book)
4. Add a child fund (ie : Adult fiction)

You will have this hierarchy :

Budget 2016
 | Book
 |_ Adult fiction

5. Go to the Acquisition module
6. Place an order and use the "Adult fiction" budget
7. Go back the Acquisition home page and compare the table with the table from
the aqbudgets.pl page (Administration > Budget > Fund)
8. You will see :

BEFORE PATCH :
the base level amounts only

AFTER PATCH :
the base level and the total amounts

Followed test plan, works as expected.
Signed-off-by: Marc Véron 
Signed-off-by: Tomas Cohen Arazi 
I tested the functionality and it works as expected. It also passes the QA
script.
It basically adds 'base-level' information to the acquisitions page. The only
difference
with what is displayed on the funds page is that it doesn't add the base-level
available
amounts. So the table is more compact and easy to follow.

I think this is a useful enhancement even if it makes this table closer to the
funds one.
I checked it totalizes correctly on each scenario and respects the acq workflow
exactly as
the funds table.

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #84094|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||sandbo...@biblibre.com

--- Comment #22 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23731] Staff & OPAC both will display the DDC call number in XSLT but can't display the LC call number

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23731

--- Comment #3 from Kelly McElligott  ---
Lucas,
the LOC number is generally both the 050$a and 050$b- can the $b be also
included- I apologize I didn't clearly say this in my initial submission.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23551] Problem with renewal period when using the renewal tab in 19.05.03

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551

--- Comment #9 from Martin Renvoize  ---
I think this traces back to bug 7088, though that's not in 18.11.x series as
far as I can tell.

Either way, the fix should resolve the issue and I will attempt to add a
selenium regression test shortly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592

--- Comment #30 from Séverine Queune  ---
(In reply to Ere Maijala from comment #27)
> Yes, exactly! :)

Thank you Ere !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23551

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23551] Problem with renewal period when using the renewal tab in 19.05.03

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=7088

--- Comment #8 from Martin Renvoize  ---
I

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23551] Problem with renewal period when using the renewal tab in 19.05.03

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23551] Problem with renewal period when using the renewal tab in 19.05.03

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23551] Problem with renewal period when using the renewal tab in 19.05.03

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551

--- Comment #7 from Martin Renvoize  ---
Created attachment 93746
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93746=edit
Bug 23551: Fix AddRenewal call in circ/renew.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #93743|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592

--- Comment #29 from sandbo...@biblibre.com  ---
Created attachment 93745
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93745=edit
Bug 22592: Add index scan emulation to Elasticsearch

Adds support for using the "scan indexes" action in advanced search by using
faceting with a prefix filter. Requires that the field be set as facetable for
anything to be found.

Test plan:
1. Apply patch
2. Go to advanced search and click "More options"
3. Select author as the search field, enter a last name and check "Scan
indexes"
4. Perform search and observe the result list resembling scan results

Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592

sandbo...@biblibre.com  changed:

   What|Removed |Added

 CC||sandbo...@biblibre.com
 Status|Needs Signoff   |Signed Off

--- Comment #28 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592

--- Comment #27 from Ere Maijala  ---
Yes, exactly! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592

--- Comment #26 from Séverine Queune  ---
So if my understanding is good, you mean I can sign the patch, am I right ? :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23751] New: Description of staffaccess permission should be improved.

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23751

Bug ID: 23751
   Summary: Description of staffaccess permission should be
improved.
 Change sponsored?: ---
   Product: Koha
   Version: 18.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: r.delahu...@arts.ac.uk
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

In Bug 23108 is the comment “A user without the staffaccess permission cannot
change the permissions or password for another user belonging to a patron
category that is not type Staff. This works as intended.” Both the
documentation and the on-screen explanation of this permission makes no mention
that this permission is necessary to modify usernames or passwords. May I
suggest that the description of the staffaccess permission be changed to read:
“Allow staff members to modify permissions and usernames & passwords for other
staff members”.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592

--- Comment #25 from Ere Maijala  ---
The search it performs is currently not quite perfect match for the term list
since search ignores punctuation etc. and may include results that start with
the given term. Since the created search query does not carry information on
the actual origin of the search, we can't handle it in a different way from a
normal search in the ES code. I'm sure this could be further refined, but this
is a minimal implementation to make not just fail completely.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23750] New: token cleaning script

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23750

Bug ID: 23750
   Summary: token cleaning script
 Change sponsored?: ---
   Product: Project Infrastructure
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Mana-kb (server)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: paul.poul...@biblibre.com

A token that has been created but not activated within 1 day => send a
reminder.

If not activated within 7 days is deleted and send an email "expired, request a
new one if you want"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23749] New: batch import mana-kb reports

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23749

Bug ID: 23749
   Summary: batch import mana-kb reports
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Mana-kb
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: paul.poul...@biblibre.com

Add a command line tool to batch import mana-kb reports.
Alternatively/additionaly, add this feature to web installer.
The list of SQL reports to import from mana would be a a list of mana-kb IDs.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   4   >