[Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673

--- Comment #3 from Agustín Moyano  ---
I decided to change "Time sent" column name for "Time status changed".

I thought it would be clearer in the case the message failed. The other way, a
user may see that the message failed and a timestamp in "Time sent" column and
may be confused thinking that the message was sent but failed afterwards.

If anyone comes up with a better name for the column I'll change it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673

--- Comment #2 from Agustín Moyano  ---
Created attachment 94504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94504=edit
Bug 23673: Add "Time status changed" column to patron's notices

This patch adds "Time status changed" column to patron's notices tab. It also
adds logic to C4::Letters to update time_status_changed column when status is
changed, and leaves time_queued with message creation time.

To test:

1. Apply patches.

2. Restart plack.

3. Choose a patron and add a purchase suggestion.

4. Change suggestion status.

5. Open patron's notifications.
CHECK => Messages table has now "Time status changed" and "Time created"
columns, and "Time" column is gone.
SUCCESS => There is a message with status pending, with a "time created" and no
"time status changed"

6. Execute in the shell in Koha directory

   $ ./misc/cronjobs/process_message_queue.pl

7. Open patron's notifications one more time.
SUCCESS => The message changed status. Time created remained the same, and now
"time status changed" has the current timestamp.

8. Resend the message and repeat sep 6.
SUCCESS => Every time you change the status, time created remains the same and
time status changed updates.

9. prove t/db_dependant/Letters.t

10. Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673

Agustín Moyano  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673

--- Comment #1 from Agustín Moyano  ---
Created attachment 94503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94503=edit
Bug 23673: change db structure

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20340] Ability to use authentication plugin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340

hannah...@northwestu.edu changed:

   What|Removed |Added

 CC|hannah...@northwestu.edu|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20340] Ability to use authentication plugin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340

hannah...@northwestu.edu changed:

   What|Removed |Added

 CC||hannah...@northwestu.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18549] There should be a warning that logging out of Koha will leave browser session logged in to OAuth

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18549

hannah...@northwestu.edu changed:

   What|Removed |Added

 CC||hannah...@northwestu.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19793] Add a field for email in batch patron modification

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

David Roberts  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |david.roberts@ptfs-europe.c
   |y.org   |om
 CC||david.roberts@ptfs-europe.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23862] Add enumchron to holds-table on checkout page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23862

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23862] Add enumchron to holds-table on checkout page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23862

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #94501|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall  ---
Created attachment 94502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94502=edit
Bug 23862: add enumchron to holds-table

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23862] Add enumchron to holds-table on checkout page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23862

--- Comment #1 from Lucas Gass  ---
Created attachment 94501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94501=edit
Bug 23862: add enumchron to holds-table

TEST PLAN:
1. find or make  an item that includes volume # (enumchron, 952$h)
2. place the item on hold for a patron and view the holds-table
3. notice that the volume # does not display  
4. apply patch  
5. restart_all
6. notice that the volume # now displays

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23862] Add enumchron to holds-table on checkout page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23862

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23863] Editing a basket clears create_items value

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23863

--- Comment #1 from Andrew Fuerste-Henry  ---
I've confirmed this behavior on both 18.11 and 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23863] New: Editing a basket clears create_items value

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23863

Bug ID: 23863
   Summary: Editing a basket clears create_items value
 Change sponsored?: ---
   Product: Koha
   Version: 19.05
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

To test:
- Create a basket with a non-default value for aqbasket.create_items
- Click Edit from basket.pl
- Click Save without changing anything
- Note that aqbasket.create_items is no longer set

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23862] New: Add enumchron to holds-table on checkout page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23862

Bug ID: 23862
   Summary: Add enumchron to holds-table on checkout page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

on the checkout page if you look at the issues-table you will see that the
enumchron is displayed as part of the title. If you look at the holds-table it
does NOT include the enumchron. 

Showing the enumchron is helpful to librarians, it should display just like it
does in holds-table.

patch coming

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23861] New: Add authorised value categories description option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23861

Bug ID: 23861
   Summary: Add authorised value categories description option
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

I really like the way the authorised values page looks now. I think it's much
more user friendly with the descriptions and the categories all laid out and
not in a drop-down.

Right now, the descriptions for each category are "hardcoded" in the template.
Would it be feasible to move those in the DB? That way, when we add new
categories, we would be able to add our own description. For example, if I add
a category for RDA media type, I would be able to add a description saying it's
meant to be used with 337$a.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23860] Patrons endpoint not setting the Location header

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23860

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||23860


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23860
[Bug 23860] Patrons endpoint not setting the Location header
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23860] Patrons endpoint not setting the Location header

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23860

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Depends on||23843
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843
[Bug 23843] Make existing endpoints use Koha::Object(s)->to_api
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23860] New: Patrons endpoint not setting the Location header

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23860

Bug ID: 23860
   Summary: Patrons endpoint not setting the Location header
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: REST api
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23859] Cities endpoint not setting the Location header

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 94499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94499=edit
Bug 23859: Make POST add the Location header on cities endpoint

According to the coding guidelines, this endpoint should be adding the
Location header on POST actions.

To test:
1. Apply the tests patch
2. Run:
$ kshell
k$ prove t/db_dependent/api/v1/cities.t
=> FAIL: Tests fail!
3. Apply this patch
4. Repeat (1)
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23859] Cities endpoint not setting the Location header

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859

--- Comment #4 from Tomás Cohen Arazi  ---
Created attachment 94500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94500=edit
Bug 23859: Update tests to new style

The /cities endpoint is refered in several places as the reference
implementation of a route for devs to pick it for copy and pasting. Yet,
it is outdated in terms of how the tests are written.

This patch rewrites some bits so it uses BASIC auth and the built-ins
Test::Mojo provides.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23859] Cities endpoint not setting the Location header

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 94498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94498=edit
Bug 23859: Regression tests

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23859] Cities endpoint not setting the Location header

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #94497|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23859] Cities endpoint not setting the Location header

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23859] Cities endpoint not setting the Location header

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 94497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94497=edit
Bug 23859: Update tests to new style

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #257 from Agustín Moyano  ---
(In reply to Katrin Fischer from comment #243)
> Patch doesn't apply, can you please rebase?
> 
> 
> Apply? [(y)es, (n)o, (i)nteractive] y
> Applying: Bug 22284: New ft_local_hold_group column, and 'holgroup' enum
> option
> Applying: Bug 22284: Add new checkbox in Library Groups
> Applying: Bug 22284: New hold group options in smart-rules
> Applying: Bug 22284: Control hold groups in C4::Reserves
> Applying: Bug 22284: New methods in Koha::Library::Groups and Koha::Library
> Using index info to reconstruct a base tree...
> M Koha/Library.pm
> M t/db_dependent/Koha/Libraries.t
> Falling back to patching base and 3-way merge...
> Auto-merging t/db_dependent/Koha/Libraries.t
> CONFLICT (content): Merge conflict in t/db_dependent/Koha/Libraries.t
> Auto-merging Koha/Library.pm
> CONFLICT (content): Merge conflict in Koha/Library.pm
> error: Failed to merge in the changes.
> Patch failed at 0001 Bug 22284: New methods in Koha::Library::Groups and
> Koha::Library
> The copy of the patch that failed is found in: .git/rebase-apply/patch
> When you have resolved this problem run "git bz apply --continue".
> If you would prefer to skip this patch, instead run "git bz apply --skip".
> To restore the original branch and stop patching run "git bz apply --abort".
> Patch left in
> /tmp/Bug-22284-New-methods-in-KohaLibraryGroups-and-Koh-yTz2MT.patch

Patches rebased!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843

--- Comment #10 from Tomás Cohen Arazi  ---
Created attachment 94496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94496=edit
Bug 23843: (QA follow-up) Fix tests for funds

Now that we use ->to_api all the object attributes are returned, so the
original tests that didn't follow the FKs would pass, and now they
don't. If there is no budget linked to the fund, it will return undef,
which is not accepted on the API (though it accepts not returning the
attribute).

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/acquisitions_funds.t
=> SUCCESS: Tests pass!

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #256 from Agustín Moyano  ---
Created attachment 94495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94495=edit
Bug 22284: (Do not push) Schema update

Signed-off-by: Josef Moravec 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #253 from Agustín Moyano  ---
Created attachment 94492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94492=edit
Bug 22284: (follow-up) Squash multiple follow-ups

  * Bug 22284: (follow-up) Remove commented warn and address test failures

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Josef Moravec 

  * Bug 22284: (follow-up) fix test count after merge

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Josef Moravec 

  * Bug 22284: (follow-up) fixes after 15496

Signed-off-by: Josef Moravec 

  * Bug 22284: (follow-up) fixes after 18936

Signed-off-by: Josef Moravec 

  * Bug 22284: (follow-up) Remove HomeOrHolding from reserves

Signed-off-by: Josef Moravec 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #252 from Agustín Moyano  ---
Created attachment 94491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94491=edit
Bug 22284: Filter item's pickup locations in holds_table.inc

This patch filters pickup locations per item in holds_table.inc

To test:
1) Go to Circulation and fines rules and change max holds allowed to > 0, and
change 'Hold pickup library match' to homebranch
2) Search for a patron
3) Click on "Search to hold"
4) Search for any bilio
5) Place hold on a specific item
CHECK => Item's pickup location is a select with all libraries
6) Apply this patch
7) Repeat steps 2 to 5
SUCCESS => Item's pickup location is filtered by allowed pickup locations
8) Sign off

Sponsored-by: VOKAL

Signed-off-by: Josef Moravec 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #250 from Agustín Moyano  ---
Created attachment 94489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94489=edit
Bug 22284: (follow-up) Default to circulation control branch when no hold
libraries are found

Signed-off-by: Josef Moravec 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #255 from Agustín Moyano  ---
Created attachment 94494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94494=edit
Bug 22284: (follow-up) Squash multiple follow-ups

  * Bug 22284: (follow-up) Use GetReserveControlBranch in
Koha::Item->pickup_locations

Signed-off-by: Josef Moravec 

  * Bug 22284: (follow-up) Fix tests

Signed-off-by: Josef Moravec 

  * Bug 22284: (follow-up) Fix typo in request.tt

Signed-off-by: Josef Moravec 

  * Bug 22284: (follow-up) Filter pickup on specific item click

Signed-off-by: Josef Moravec 

  * Bug 22284: (follow-up) Fix typos transfered -> transferred

Signed-off-by: Josef Moravec 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #254 from Agustín Moyano  ---
Created attachment 94493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94493=edit
Bug 22284: Add "patron's hold group" as new hold_fulfillment_policy option

This patch adds "patron's hold group" as a new option to Hold pickup library
match

To test:
1. Set ReservesControlBranch preference to item.
2. Create a hold group
3. Go to circulation and fines rules
SUCCESS => in 'Hold pickup library match' there is a new option called
"patron's hold group"
4. In a library not in hold group set 'Hold policy' to "any" and 'Hold pickup
library match' to "patron's hold group"
5. Search for a user in the hold group
6. 'Search to hold' for items of the library of step 4
7. Select an item and 'Place hold for [user]'
SUCCESS => in 'Pickup at' you should see patron's hold group as options
8. In OPAC sign in as the same user of step 5
9. Search for the item in step 7
SUCCESS => in 'Pick up locations' you should see patron's hold group as options
10. Sign off

Signed-off-by: Josef Moravec 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #245 from Agustín Moyano  ---
Created attachment 94484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94484=edit
Bug 22284: Add new checkbox in Library Groups

This patch adds a new checkbox option 'Is local hold group' when you create a
new root group.

To test:
1) In intranet go to Library Groups in admin module
2) Add new root group
3) Check that there is no 'Is local hold group' checkbox
4) Apply this patch
5) Add new root group
SUCCESS => a new 'Is local hold group' checkbox appears
6) Select 'Is local hold group' and save
7) Click edit button for root group
SUCCESS => 'Is local hold group' is checked
8) Sign off

Sponsored-by: VOKAL
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Josef Moravec 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #251 from Agustín Moyano  ---
Created attachment 94490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94490=edit
Bug 22284: New message, new column and filter pickup locations in
reserve/request.tt

This patch adds a new message to 'Hold' column in 'Place a hold on a specific
item' table.

The message is "Cannot place hold from patrons's library". It appears when
patron's homebranch is not in item's hold group, and hold_fulfillment_policy is
set to 'holdgroup'.

This patch also adds a new column "Allowed pickup locations" that lists allowed
pickup locations per item.

Finally, the select that displays pickup locations is filtered by allowed
pickup locations, when multi_hold is not enabled

To test:
1) Apply this patch
2) In library groups add a root group and check it as hold group.
3) Add two libraries to the group
4) In circulation and fines rules, in 'Default checkout, hold and return
policy', in Hold policy change the value to 'From local hold group'
5) Search a patron from a different library than step 3, select one and click
'search to hold'
6) Search by location for items in any library of step 3
7) On any item, clic on 'Place hold for ...'
SUCCESS => when the page is loaded, in the 'Place a hold on a specific item',
you should see the message "Cannot place hold from patrons's library" in 'Hold'
column
=> You should see a new column called "Allowed pickup locations" and
the message is "Any library"
8) In circulation and fines rules, in 'Default checkout, hold and return
policy', in 'Hold policy' change the value again to 'From any library' and
change 'Hold pickup library match' to "Item's hold group"
8) Repeat steps 5 to 7
SUCCESS => when the page is loaded, you should see the "Pickup at" select
filtered by libraries in hold group
=> You should see in "Allowed pickup locations" a coma separated list
of the libraries in item's hold group
=> If biblio has an item whose control branch is not in a hold group,
you should see the control branch name in "Allowed pickup locations"
9) Sign off

Sponsored-by: VOKAL
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Josef Moravec 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #249 from Agustín Moyano  ---
Created attachment 94488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94488=edit
Bug 22284: Opac pickup_locations

This patch modifies Koha::Libraries->pickup_location and moves most of the
logic to
Koha::Item and Koha::Biblio in preparation for api endpoints in the future.

There where 2 methods added

1) Koha::Item->pickup_locations that given a patron, returns all pickup
locations of
this item, considering hold fulfillment rules, and hold allowed rules.

2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list
of
libraries returned by each of this biblio items pickup location.

Koha::Libraries->pickup_location analyzes input param and calls
Koha::Item->pickup_locations
or Koha::Biblio->pickup_locations as needed.

Also in opac-reserve.tt the way options where obtained to fill the pickup
location select
was modified to pass the patron as a parameter.

To test:
1) opac: try to place hold on a item and check that all libraries are shown in
the
pickup location select.
2) intranet: in Library groups, add 2 root groups marked as local hold group
and
add different libraries to each.
3) opac: login as a user of a library belonging to one hold group, and search
try to
place a hold on an item belongin to the other hold group.
4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold
pickup
library match' rules.
5) opac: On each modification of the rules reload the page.
SUCCESS => Every time you reload the page, the number of pickup locations
showed in
select varies.
6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t
SUCCESS => Result: PASS
7) Sign off

Sponsored-by: VOKAL

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Josef Moravec 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #248 from Agustín Moyano  ---
Created attachment 94487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94487=edit
Bug 22284: New methods in Koha::Library::Groups and Koha::Library

This patch adds new methods in Koha::Library::Groups and Koha::Library.
1) For Koha::Library::Groups adds get_root_ancestor that returns all root
groups for a given search parameters, for example
Koha::Library::Groups->get_root_ancestor( { id => $group_id } )
2) For Koha::Library adds
2.1) get_hold_libraries: returns all libraries (including self) that
belongs to the same holdgroups. If $self belongs to several holdgroups
it will return a distinct list of all libraries belonging to them.
2.2) validate_hold_sibling: Returns 1 if the given parameters matches any of
the
libraries that belong to any of the holdgroups this library belongs. For
example
$library->validate_hold_sibling( { branchcode => $branchcode } )

To test:
1) apply this patch
2) prove t/db_dependent/Koha/Libraries.t t/db_dependent/LibraryGroups.t
SUCCESS => green letters :-D
3) Sign off

Sponsored-by: VOKAL
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Josef Moravec 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #247 from Agustín Moyano  ---
Created attachment 94486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94486=edit
Bug 22284: Control hold groups in C4::Reserves

This patch modifies C4::Reserves to control when hold group options where
selected
in smart rules.
In CanItemBeReserved adds 2 new error status messages
1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group
2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold
group
Also CheckReserves is modified when item's priority is defined, to control by
hold
group when required.
Finally, IsAvailableForItemLevelRequest was also modified to control by hold
group when
required.

To test:
1) Apply this patch
2) prove t/db_dependent/Holds.t
SUCCESS => Result: PASS
3) Sign off

Sponsored-by: VOKAL

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Josef Moravec 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #246 from Agustín Moyano  ---
Created attachment 94485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94485=edit
Bug 22284: New hold group options in smart-rules

This patch adds new options for 'Default checkout, hold and return policy'
and 'Default holds policy by item type', both in 'Hold policy' and 'Hold
pickup library match' columns

To test:
1) Go to 'Circulation and fines rules' in admin
2) Check that there are no options for hold group in 'Hold policy' and 'Hold
pickup library match' columns
3) Apply this patch
SUCCESS => in 'Hold policy' you should see 'From local hold group' option, and
in
'Hold pickup library match' you should see "Item's hold group"
4) Select any of those options and save
SUCCESS => options should be selected when page reloads
5) Sign off

Sponsored-by: VOKAL
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Josef Moravec 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

Agustín Moyano  changed:

   What|Removed |Added

  Attachment #92849|0   |1
is obsolete||
  Attachment #92850|0   |1
is obsolete||
  Attachment #92851|0   |1
is obsolete||
  Attachment #92852|0   |1
is obsolete||
  Attachment #92853|0   |1
is obsolete||
  Attachment #92854|0   |1
is obsolete||
  Attachment #92855|0   |1
is obsolete||
  Attachment #92856|0   |1
is obsolete||
  Attachment #92857|0   |1
is obsolete||
  Attachment #92858|0   |1
is obsolete||
  Attachment #92859|0   |1
is obsolete||
  Attachment #92860|0   |1
is obsolete||
  Attachment #92861|0   |1
is obsolete||

--- Comment #244 from Agustín Moyano  ---
Created attachment 94483
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94483=edit
Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option

In order to add groups for holds, this patch provides a new column in
library_groups to identify them. Also provides new enum option for
hold_fulfillment_policy column of default_branch_circ_rules,
default_circ_rules, default_branch_item_rules and branch_item_rules.

To test:
1) check that there is no ft_local_hold_group column in library_groups
and that there are no 'holdgroup' enum option in hold_fulfillment_policy
in default_branch_circ_rules, default_circ_rules, default_branch_item_rules
and branch_item_rules
2) apply this patch
3) perl installer/data/mysql/updatedatabase.pl && dbic
SUCCESS => !(step 1) ;-D
4) Sign off

Sponsored-by: VOKAL

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Josef Moravec 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

Agustín Moyano  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23858] Vendors endpoint not setting the Location header

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23858

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||23843


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843
[Bug 23843] Make existing endpoints use Koha::Object(s)->to_api
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23859] Cities endpoint not setting the Location header

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||23843


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843
[Bug 23843] Make existing endpoints use Koha::Object(s)->to_api
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||23859


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859
[Bug 23859] Cities endpoint not setting the Location header
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||23858


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23858
[Bug 23858] Vendors endpoint not setting the Location header
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23859] Cities endpoint not setting the Location header

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23859] New: Cities endpoint not setting the Location header

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859

Bug ID: 23859
   Summary: Cities endpoint not setting the Location header
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: REST api
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23858] Vendors endpoint not setting the Location header

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23858

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 94482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94482=edit
Bug 23858: (follow-up) Return code fix

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23858] Vendors endpoint not setting the Location header

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23858

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23858] Vendors endpoint not setting the Location header

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23858

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 94481
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94481=edit
Bug 23858: Make POST add the Location header on vendors endpoint

According to the coding guidelines, this endpoint should be adding the
Location header on POST actions.

To test:
1. Apply the tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/acquisition_vendors.t
=> FAIL: Tests fail!
3. Apply this patch
4. Repeat (1)
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23858] Vendors endpoint not setting the Location header

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23858

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 94480
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94480=edit
Bug 23858: Regression tests

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23858] Vendors endpoint not setting the Location header

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23858

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23858] New: Vendors endpoint not setting the Location header

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23858

Bug ID: 23858
   Summary: Vendors endpoint not setting the Location header
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: REST api
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com

It is not being set when creating a new vendor.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23858] Vendors endpoint not setting the Location header

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23858

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Severity|enhancement |minor
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |
URL||https://wiki.koha-community
   ||.org/wiki/Coding_Guidelines
   ||_-_API#SWAGGER3.4.1_POST

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23856] Split author and ISBN/ISSN out of citation in staged MARC record management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23856

--- Comment #1 from Owen Leonard  ---
Created attachment 94479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94479=edit
Bug 23856: Split author and ISBN/ISSN out of citation in staged MARC record
management

This patch modifies the way data is passed to the staged MARC record
management template, splitting author, ISBN, and ISSN out of the
"citation" variable and passing them separately.

The DataTables configuration for the staged MARC record management page
is modified so that those now-separate variables are conditionally
displayed.

Unrelated minor change: Added a class to the MARC preview modal so that
it displays wider.

To test, apply the patch and view the "Staged MARC management" page for
both batches of bibliographic records and batches of authority records.

In each case the title or authority heading should be displayed as a
link while author, ISBN, and ISSN (if any) should not.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23856] Split author and ISBN/ISSN out of citation in staged MARC record management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23856

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23857] Club holds endpoint not setting Location header

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23857

Tomás Cohen Arazi  changed:

   What|Removed |Added

URL||https://wiki.koha-community
   ||.org/wiki/Coding_Guidelines
   ||_-_API#SWAGGER3.4.1_POST
 Depends on||19618


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618
[Bug 19618] Add 'Club Holds' feature
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||23857


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23857
[Bug 23857] Club holds endpoint not setting Location header
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23857] New: Club holds endpoint not setting Location header

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23857

Bug ID: 23857
   Summary: Club holds endpoint not setting Location header
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: REST api
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com

It is not being set

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843

--- Comment #6 from Tomás Cohen Arazi  ---
Created attachment 94475
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94475=edit
Bug 23843: Add mapping to Koha::Patron

This patch adds a to_api_mapping method to the class. This in effect
enables calling ->to_api on the object. The mapping is borrowed from the
API controller. It is not removed from the controller so we are able to
verify (through the tests) that there is no behavior change.
Once this is pushed we need to implement the counter-wise methods and
clean the controllers.
To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/patrons.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat (1)
=> SUCCESS: Tests still pass!
4. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843

--- Comment #9 from Tomás Cohen Arazi  ---
Created attachment 94478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94478=edit
Bug 23843: Add mapping to Koha::Acquisition::Fund

This patch adds a to_api_mapping method to the class. This in effect
enables calling ->to_api on the object. The mapping is borrowed from the
API controller. It is not removed from the controller so we are able to
verify (through the tests) that there is no behavior change.
Once this is pushed we need to implement the counter-wise methods and
clean the controllers.
To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/acquisitions_funds.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat (1)
=> SUCCESS: Tests still pass!
4. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843

--- Comment #8 from Tomás Cohen Arazi  ---
Created attachment 94477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94477=edit
Bug 23843: Add mapping to Koha::Acquisition::Bookseller

This patch adds a to_api_mapping method to the class. This in effect
enables calling ->to_api on the object. The mapping is borrowed from the
API controller. It is not removed from the controller so we are able to
verify (through the tests) that there is no behavior change.
Once this is pushed we need to implement the counter-wise methods and
clean the controllers.
To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/acquisitions_vendors.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat (1)
=> SUCCESS: Tests still pass!
4. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843

--- Comment #7 from Tomás Cohen Arazi  ---
Created attachment 94476
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94476=edit
Bug 23843: Add mapping to Koha::Item

This patch adds a to_api_mapping method to the class. This in effect
enables calling ->to_api on the object. The mapping is borrowed from the
API controller. It is not removed from the controller so we are able to
verify (through the tests) that there is no behavior change.
Once this is pushed we need to implement the counter-wise methods and
clean the controllers.
To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/items.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat (1)
=> SUCCESS: Tests still pass!
4. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843

--- Comment #5 from Tomás Cohen Arazi  ---
Created attachment 94474
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94474=edit
Bug 23843: Add mapping to Koha::Library

This patch adds a to_api_mapping method to the class. This in effect
enables calling ->to_api on the object. The mapping is borrowed from the
API controller. It is not removed from the controller so we are able to
verify (through the tests) that there is no behavior change.
Once this is pushed we need to implement the counter-wise methods and
clean the controllers.
To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/libraries.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat (1)
=> SUCCESS: Tests still pass!
4. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843

--- Comment #4 from Tomás Cohen Arazi  ---
Created attachment 94473
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94473=edit
Bug 23843: Add mapping to Koha::Hold

This patch adds a to_api_mapping method to the class. This in effect
enables calling ->to_api on the object. The mapping is borrowed from the
API controller. It is not removed from the controller so we are able to
verify (through the tests) that there is no behavior change.
Once this is pushed we need to implement the counter-wise methods and
clean the controllers.
To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/holds.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat (1)
=> SUCCESS: Tests still pass!
4. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 94472
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94472=edit
Bug 23843: Add mapping to Koha::Club::Holds

This patch adds a to_api_mapping method to the class. This in effect
enables calling ->to_api on the object. The mapping is borrowed from the
API controller. It is not removed from the controller so we are able to
verify (through the tests) that there is no behavior change.
Once this is pushed we need to implement the counter-wise methods and
clean the controllers.
To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/clubs_holds.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat (1)
=> SUCCESS: Tests still pass!
4. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 94471
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94471=edit
Bug 23843: Add mapping to Koha::Checkout

This patch adds a to_api_mapping method to the class. This in effect
enables calling ->to_api on the object. The mapping is borrowed from the
API controller. It is not removed from the controller so we are able to
verify (through the tests) that there is no behavior change.
Once this is pushed we need to implement the counter-wise methods and
clean the controllers.
To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/checkouts.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat (1)
=> SUCCESS: Tests still pass!
4. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 94470
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94470=edit
Bug 23843: Add mapping to Koha::Account::Line

This patch adds a to_api_mapping method to the class. This in effect
enables calling ->to_api on the object. The mapping is borrowed from the
API controller. It is not removed from the controller so we are able to
verify (through the tests) that there is no behavior change.

Once this is pushed we need to implement the counter-wise methods and
clean the controllers.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/patrons_accounts.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat (1)
=> SUCCESS: Tests still pass!
4. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23856] New: Split author and ISBN/ISSN out of citation in staged MARC record management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23856

Bug ID: 23856
   Summary: Split author and ISBN/ISSN out of citation in staged
MARC record management
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: /cgi-bin/koha/tools/manage-marc-import.pl?import_batch
_id=XXX
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

On the "Manage staged MARC records" page the list of staged records currently
displays the title (or authority heading), author, and ISBN/ISSN together in
one link. I think this makes the information hard to parse. I propose to send
author, ISBN, and ISSN as separate variables, and move some of the display
logic into the DataTables configuration.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23594] Batch modification for itemtypes on suggestions page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23594] Batch modification for itemtypes on suggestions page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

--- Comment #1 from Jonathan Druart  
---
Created attachment 94469
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94469=edit
Bug 23594: Batch modification for itemtypes on suggestions page

This new enhancement adds the ability to update the item types for
selected suggestions on the suggestions management page
(suggestion/suggestion.pl)

To achieve this goal we needed to refresh a bit the template, in order
to get rid of weird code. To not recreate the previous coding awkwardness
some code has been rewritten (mainly the removal of suggestiontype)

Test plan:
- Create some suggestions
- On the suggestions management page, select some of them and a new item
types.
- Submit the form and confirm that the itemtype of the suggestions has
been updated

- Also you should confirm that the "delete" and "change status" still
work as before

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23855] Cannot mark the selected suggestion as "pending"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23855

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||23594


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594
[Bug 23594] Batch modification for itemtypes on suggestions page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23594] Batch modification for itemtypes on suggestions page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||23855


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23855
[Bug 23855] Cannot mark the selected suggestion as "pending"
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #94461|0   |1
is obsolete||

--- Comment #175 from Bin Wen  ---
Created attachment 94468
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94468=edit
Bug 11879: (follow-up) Corrected OPAC and removed unrelated changes

modified:   koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt
modified:  
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt

Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #94458|0   |1
is obsolete||

--- Comment #172 from Bin Wen  ---
Created attachment 94465
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94465=edit
Bug 11879: (QA follow-up) Fix problems found in code review

Signed-off-by: Lucie Gay 

Signed-off-by: Katrin Fischer 

Signed-off-by: Hayley Mapley 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #94460|0   |1
is obsolete||

--- Comment #174 from Bin Wen  ---
Created attachment 94467
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94467=edit
Bug 11879: Remove unecessary code in controller

- adds the field required is defined in BorrowerMandatoryField (staff
only)
- removes code from controller (not needed, we can follow existing
pattern)
- does not send patron's attribute separately (we have the 'patron'
variable already)

Need to be done:
- same changes for the OPAC
- remove extra changes made to moremember-brief.tt (if bugfix it needs
to be moved on a separate bug report)
- deal with PatronSelfModificationBorrowerUnwantedField and
PatronSelfRegistrationBorrowerUnwantedField

I first thought it would have replaced AutoEmailPrimaryAddress, but it
actually only needed for display purpose, how/where can we explain that?
Are release notes enough?

Signed-off-by: Hayley Mapley 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #94457|0   |1
is obsolete||

--- Comment #171 from Bin Wen  ---
Created attachment 94464
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94464=edit
Bug 11879: (follow-up) Streamline markup and make label corrections

This patch makes minor markup corrections to the patron detail page
template:

- Simplify the SWITCH markup
- Add "primary" to primary phone label
- Correct case on label
- Add IF statement to hide label if there is no primary contact
  method

Signed-off-by: Lucie Gay 

Signed-off-by: Katrin Fischer 

Signed-off-by: Hayley Mapley 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #94459|0   |1
is obsolete||

--- Comment #173 from Bin Wen  ---
Created attachment 94466
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94466=edit
Bug 11879: Schema updates

Signed-off-by: Lucie Gay 

Signed-off-by: Katrin Fischer 

Signed-off-by: Hayley Mapley 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23855] Cannot mark the selected suggestion as "pending"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23855

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #94456|0   |1
is obsolete||

--- Comment #170 from Bin Wen  ---
Created attachment 94463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94463=edit
Bug 11879: Add the "Main contact method" field in borrower informations.

This patch adds the "Main Contact Method" field in the borrower modification
form.

This field is useful for reporting purposes, or to know which contact method to
use first when trying to contact a borrower.

Following Nicolas' fix, removed a $branch variable from patch, since it has
been suppressed in Bug 17284.

Test case :
* Edit a borrower's informations. The "Main Contact Method" selectbox should
appear in the form and its value should be saved correctly.

Sponsored-by: CCSR 

Signed-off-by: Lucie Gay 

Signed-off-by: Katrin Fischer 

Signed-off-by: Hayley Mapley 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23855] Cannot mark the selected suggestion as "pending"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23855

--- Comment #1 from Jonathan Druart  
---
Created attachment 94462
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94462=edit
Bug 23855: Fix "Mark selected suggestion as" status

On the suggestions management page (suggestion/suggestion.pl) you can
select suggestions and change their status.
But it only works for "ACCEPTED" or "REJECTED".

Maybe caused by bug 22905.

Test plan:
Select at least one suggestion on the screen and select the "Pending"
status.
=> The status of the selected suggestions must have been updated

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23855] Cannot mark the selected suggestion as "pending"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23855

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22905] Cannot update the status of suggestions if the branchcode filter is set to all

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||23855


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23855
[Bug 23855] Cannot mark the selected suggestion as "pending"
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #93854|0   |1
is obsolete||

--- Comment #167 from Bin Wen  ---
Created attachment 94459
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94459=edit
Bug 11879: Schema updates

Signed-off-by: Lucie Gay 

Signed-off-by: Katrin Fischer 

Signed-off-by: Hayley Mapley 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23855] New: Cannot mark the selected suggestion as "pending"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23855

Bug ID: 23855
   Summary: Cannot mark the selected suggestion as "pending"
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 22905

On the suggestions management page (suggestion/suggestion.pl) you can select
suggestions and change their status.
But it only works for "ACCEPTED" or "REJECTED".

Maybe caused by bug 22905.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905
[Bug 22905] Cannot update the status of suggestions if the branchcode filter is
set to all
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #93852|0   |1
is obsolete||

--- Comment #165 from Bin Wen  ---
Created attachment 94457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94457=edit
Bug 11879: (follow-up) Streamline markup and make label corrections

This patch makes minor markup corrections to the patron detail page
template:

- Simplify the SWITCH markup
- Add "primary" to primary phone label
- Correct case on label
- Add IF statement to hide label if there is no primary contact
  method

Signed-off-by: Lucie Gay 

Signed-off-by: Katrin Fischer 

Signed-off-by: Hayley Mapley 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #93853|0   |1
is obsolete||

--- Comment #166 from Bin Wen  ---
Created attachment 94458
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94458=edit
Bug 11879: (QA follow-up) Fix problems found in code review

Signed-off-by: Lucie Gay 

Signed-off-by: Katrin Fischer 

Signed-off-by: Hayley Mapley 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #93851|0   |1
is obsolete||

--- Comment #164 from Bin Wen  ---
Created attachment 94456
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94456=edit
Bug 11879: Add the "Main contact method" field in borrower informations.

This patch adds the "Main Contact Method" field in the borrower modification
form.

This field is useful for reporting purposes, or to know which contact method to
use first when trying to contact a borrower.

Following Nicolas' fix, removed a $branch variable from patch, since it has
been suppressed in Bug 17284.

Test case :
* Edit a borrower's informations. The "Main Contact Method" selectbox should
appear in the form and its value should be saved correctly.

Sponsored-by: CCSR 

Signed-off-by: Lucie Gay 

Signed-off-by: Katrin Fischer 

Signed-off-by: Hayley Mapley 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #93901|0   |1
is obsolete||

--- Comment #169 from Bin Wen  ---
Created attachment 94461
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94461=edit
Bug 11879: (follow-up) Corrected OPAC and removed unrelated changes

modified:   koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt
modified:  
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #93855|0   |1
is obsolete||

--- Comment #168 from Bin Wen  ---
Created attachment 94460
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94460=edit
Bug 11879: Remove unecessary code in controller

- adds the field required is defined in BorrowerMandatoryField (staff
only)
- removes code from controller (not needed, we can follow existing
pattern)
- does not send patron's attribute separately (we have the 'patron'
variable already)

Need to be done:
- same changes for the OPAC
- remove extra changes made to moremember-brief.tt (if bugfix it needs
to be moved on a separate bug report)
- deal with PatronSelfModificationBorrowerUnwantedField and
PatronSelfRegistrationBorrowerUnwantedField

I first thought it would have replaced AutoEmailPrimaryAddress, but it
actually only needed for display purpose, how/where can we explain that?
Are release notes enough?

Signed-off-by: Hayley Mapley 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23854] New: Cannot edit a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854

Bug ID: 23854
   Summary: Cannot edit a suggestion
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

I get:

DBD::mysql::st execute failed: Incorrect date value: '21/10/2019' for column
`koha_kohadev`.`suggestions`.`accepteddate` at row 1 [for Statement "UPDATE
`suggestions` SET `accepteddate` = ?, `budgetid` = ?, `copyrightdate` = ?,
`manageddate` = ?, `quantity` = ?, `rejecteddate` = ?, `suggesteddate` = ?
WHERE ( `suggestionid` = ? )" with ParamValues: 0="21/10/2019", 1=undef,
2=undef, 3='2019-10-21T17:33:23', 4=undef, 5='2019-10-21T17:33:23',
6='2019-10-21T00:00:00', 7=1] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm
line 1836.

Could someone confirm? Is it a recent regression?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23594] Batch modification for itemtypes on suggestions page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||18743


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743
[Bug 18743] Filter suggestion lists correctly for IndependentBranches
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||23594


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594
[Bug 23594] Batch modification for itemtypes on suggestions page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23594] Batch modification for itemtypes on suggestions page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

Jonathan Druart  changed:

   What|Removed |Added

  Change sponsored?|Seeking developer   |Sponsored
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23852] Merge biblio-title.inc and biblio-default-view.inc

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852

--- Comment #1 from Owen Leonard  ---
Created attachment 94455
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94455=edit
Bug 23852: Merge biblio-title.inc and biblio-default-view.inc

This patch moves the functionality contained in biblio-default-view.inc
into biblio-title.inc. biblio-title.inc can now be called with a "link =
1" parameter in order for the title to be displayed as a link which is
controlled by the IntranetBiblioDefaultView preference.

To test, apply the patch and test the affected pages, especially titles
linked to in breadcrumbs menus

Acquisitions:
 - Add to basket -> From existing record -> Search
   - Title in search results

Catalog:
 - Search for a record
   - Add record to cart
 - Open cart
   - Title in brief display
 - Check that link opens the correct page in the main window
   - View bibliographic record
 - ISBD view
 - MARC view
 - Normal view
  - Local cover image detail page
  - Checkout history
  - Request article
 - Item details
 - From the "Edit" menu -> Attach item
 - Stock rotation rota
 - Place hold

Cataloging:
 - Cataloging search -> Search results

Circulation:
 - Article requests
 - Overdues with fines
 - Overdues
 - Holds queue
 - Holds to pull
 - Hold ratios
 - Holds awaiting pickup
 - Transfers to recevie
 - Renew
 - Batch checkout

Lists:
 - View list contents

Patrons:
 - View patron details
   - Holds history
   - Checkout history

Tools:
 - Rotating collections
   - View collection
 - Add item
 - Tags
   - Click term to see titles tagged with that term

 - Batch record deletion
   - Submit batch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23852] Merge biblio-title.inc and biblio-default-view.inc

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23852] Merge biblio-title.inc and biblio-default-view.inc

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852

Owen Leonard  changed:

   What|Removed |Added

 Depends on||23841


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23841
[Bug 23841] Add link to bibliographic details page in item details breadcrumbs
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23841] Add link to bibliographic details page in item details breadcrumbs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23841

Owen Leonard  changed:

   What|Removed |Added

 Blocks||23852


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852
[Bug 23852] Merge biblio-title.inc and biblio-default-view.inc
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/