[Koha-bugs] [Bug 23931] New: software error

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23931

Bug ID: 23931
   Summary: software error
 Change sponsored?: ---
   Product: Koha
   Version: 18.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dissanayakekuma...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Software error:
Can't call method "data" on an undefined value at
/usr/share/koha/lib/C4/Search.pm line 1927.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19722] Add a MaxItemsToDisplayForBatchMod preference

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722

AspenCat Team  changed:

   What|Removed |Added

 CC||aspencatt...@clicweb.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23470] Elasticsearch - OpacSuppression not implemented in search result

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23470

AspenCat Team  changed:

   What|Removed |Added

 CC||aspencatt...@clicweb.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089

AspenCat Team  changed:

   What|Removed |Added

 CC||aspencatt...@clicweb.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23930] No permissions SSO login to staff client should redirect to a custom URL

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23930

--- Comment #1 from Alex Buckley  ---
Created attachment 94894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94894=edit
Bug 23930: Implemented syspref where you can configure URL re-directed to whena
 patron with insufficient permissions tries to login to the staff client

Sponsored-by: Waikato Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23930] New: No permissions SSO login to staff client should redirect to a custom URL

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23930

Bug ID: 23930
   Summary: No permissions SSO login to staff client should
redirect to a custom URL
 Change sponsored?: Sponsored
   Product: Koha
   Version: 17.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Authentication
  Assignee: alexbuck...@catalyst.net.nz
  Reporter: alexbuck...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org

Presently if a patron tries to login to the staff client and they have
insufficient permissions they are re-directed back to the Koha login page with
the message: 'Error: You do not have permissions to access this page'.

This is fine when the staff client authentication is the native Koha login, but
when you have a SSO implemented then logging in via the Koha login page and
then being re-directed to a native koha login form does not make sense. 

We'd like to implement a syspref InsufficientPermissionRedirectURL which the
staff client re-directs to if the authenticating patron does not have
permission to view the staff client.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22581] Add support for Plaine & Easie musical incipits rendering in OPAC

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581

--- Comment #14 from Agustín Moyano  ---
I've updated the commits in gitlab, with Owen Leonard's code and suggestion
(Thanks Owen!)

I didn't realize that the midi player didn't play nice if multiple 031 were
present.

Thanks again Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23903] Replace OPAC icons with Font Awesome

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23903

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com

--- Comment #3 from Liz Rea  ---
I went through your plan, all of the icons were looking so lovely and modern. 

All the yes to this patch, didn't spot anything amiss.

You may have my sign off!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23929] New: Invoice adjustments should filter inactive funds

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23929

Bug ID: 23929
   Summary: Invoice adjustments should filter inactive funds
 Change sponsored?: ---
   Product: Koha
   Version: 18.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: david.robe...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 94893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94893=edit
Screenshot of unfiltered funds in adjustments

When adding an adjustment to an invoice, the funds dropdown shows all funds.
There should be a filter to allow only active funds, similar to the one on the
shipping fund dropdown, as it is impossible to identify the active fund when
they are similarly named. See screenshot.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374

Maxime Dufresne  changed:

   What|Removed |Added

 CC||maxime.dufre...@inlibro.com

--- Comment #33 from Maxime Dufresne  ---
Test plan was fine, but I realized that the dropdown options were different
between before and after patch: I saw at least one new field.

Everything else worked as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374

Maxime Dufresne  changed:

   What|Removed |Added

  Attachment #94890|0   |1
is obsolete||

--- Comment #32 from Maxime Dufresne  ---
Created attachment 94892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94892=edit
Bug 17374: Make use of fields from syspref 'DefaultPatronSearchFields' in
patron search fields dropdown

This patch preserves the current dropdown choices for patron search and adds
fields from
the DefaultPatronSearchFields system preference

To test:
1 - View the regular patron search and note fields in dropdown
2 - Apply patch, ensure dropdown has not changed
3 - Add fields to DefaultPatronSearchFields, note they are available in
dropdown
4 - Ensure existing and new fields search properly

Signed-off-by: Kelly 
Signed-off-by: Maxime Dufresne 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374

Maxime Dufresne  changed:

   What|Removed |Added

  Attachment #94876|0   |1
is obsolete||

--- Comment #31 from Maxime Dufresne  ---
Created attachment 94891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94891=edit
Bug 17374: (follow-up) Unit tests and remove warns

Signed-off-by: Maxime Dufresne 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23805] Add a dedicated credit_types table

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805

--- Comment #48 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #47)
> (In reply to Martin Renvoize from comment #43)
> > Created attachment 94815 [details] [review] [review]
> > Bug 23805: (RM follow-up) updatedatabase.pl mariadb support
> > 
> > MySQL and MariaDB have different syntax when it comes to dropping a
> > CHECK constraint.
> > 
> > Signed-off-by: Martin Renvoize 
> 
> That's what I would do, even if dirty. Maybe we should reverse the 2
> queries: first try the MariaDB syntax, to highlight that it's our first
> choice.

Have you seen the comments on bug 23914 about DBMS versions and support of
check constraints?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374

Maxime Dufresne  changed:

   What|Removed |Added

  Attachment #94831|0   |1
is obsolete||

--- Comment #30 from Maxime Dufresne  ---
Created attachment 94890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94890=edit
Bug 17374: Make use of fields from syspref 'DefaultPatronSearchFields' in
patron search fields dropdown

This patch preserves the current dropdown choices for patron search and adds
fields from
the DefaultPatronSearchFields system preference

To test:
1 - View the regular patron search and note fields in dropdown
2 - Apply patch, ensure dropdown has not changed
3 - Add fields to DefaultPatronSearchFields, note they are available in
dropdown
4 - Ensure existing and new fields search properly

Signed-off-by: Kelly 
Signed-off-by: Maxime Dufresne 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23918] search results incorrect for multiple vowel words

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23918

--- Comment #3 from Katrin Fischer  ---
I think it's etc/zebradb/etc/word-phrase-utf.chr

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #5 from Chris Cormack  ---
NZ is just going through privacy legislation rule, and will bring us much
closer to the GDPR too, so I agree this should be optional

(The library will need to assume responsibility for a data breach, and report
it and be liable for damages etc, so it's a choice they should conciously make)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23903] Replace OPAC icons with Font Awesome

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23903

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916

--- Comment #4 from Katrin Fischer  ---
For the borrower-issue information we have a means of anonymizing via the GUI -
so libraries can clean the data and it's not stored forever. The action_logs
can also be cleaned by cronjob if the library chooses to. Cleaning/anonymizing
statistics has been discussed in the GDPR meetings
(https://wiki.koha-community.org/wiki/Gdpr)

I think we should make it a general habit not to add more person related
information, without thinking about how to limit/anonymize/remove it if
required, keeping the principle of data minimization in mind. (GDPR etc.)

Libraries here are rather critical about reading histories and the like
already, so that's why I was asking for optional. :) I'd be really interested
what the use case is. - Always good to learn about others needs/requirements.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||josef.mora...@gmail.com

--- Comment #86 from Josef Moravec  ---
sorry, tried to apply, but got:

Applying: Bug 18936: More fixes
error: sha1 information is lacking or useless (C4/Reserves.pm).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com
 QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260

--- Comment #42 from Josef Moravec  ---
Created attachment 94887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94887=edit
Bug 15260: (follow-up) Fix bug in subtraction

prev_open_days can receive either positive or negative numbers and
then does the right thing with them. However, we weren't also doing this
with the number it receives back from get_push_amt

Signed-off-by: Liz Rea 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260

--- Comment #43 from Josef Moravec  ---
Created attachment 94888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94888=edit
Bug 15260: (QA follow-up) Fix updatedatabase message

Signed-off-by: Liz Rea 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260

--- Comment #44 from Josef Moravec  ---
Created attachment 94889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94889=edit
Bug 15260: (follow-up) Add missing POD

As per comment #33

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260

--- Comment #41 from Josef Moravec  ---
Created attachment 94886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94886=edit
Bug 15260: (follow-up) Fix misnamed variable

This was causing the amount to push by to be incorrectly calculated

Sponsored-by: Cheshire West and Chester and Cheshire East Councils
Sponsored-by: Newcastle City Council
Sponsored-by: Sefton Council

Signed-off-by: Liz Rea 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260

--- Comment #40 from Josef Moravec  ---
Created attachment 94885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94885=edit
Bug 15260: Fix calculation of add amount

In a sequence of closed days, we should take into account the nature
of each closed day as we encounter it in order to calculate the amount
to add to reach the next potential closed date. We are now doing this.

Sponsored-by: Cheshire West and Chester and Cheshire East Councils
Sponsored-by: Newcastle City Council
Sponsored-by: Sefton Council

Signed-off-by: Liz Rea 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260

--- Comment #38 from Josef Moravec  ---
Created attachment 94883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94883=edit
Bug 15260: Implement weekly rollforward

This patch will, when appropriate, roll due dates forward by full weeks,
rather than single days.

Sponsored-by: Cheshire West and Chester and Cheshire East Councils
Sponsored-by: Newcastle City Council
Sponsored-by: Sefton Council

Signed-off-by: Liz Rea 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260

--- Comment #39 from Josef Moravec  ---
Created attachment 94884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94884=edit
Bug 15260: Add unit tests

This patch adds unit tests of the CalcDueDate function to ensure that
the useDaysMode "Dayweek" mode works as expected

Sponsored-by: Cheshire West and Chester and Cheshire East Councils
Sponsored-by: Newcastle City Council
Sponsored-by: Sefton Council

Signed-off-by: Liz Rea 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260

Josef Moravec  changed:

   What|Removed |Added

  Attachment #89380|0   |1
is obsolete||
  Attachment #89381|0   |1
is obsolete||
  Attachment #89382|0   |1
is obsolete||
  Attachment #89383|0   |1
is obsolete||
  Attachment #89384|0   |1
is obsolete||
  Attachment #89385|0   |1
is obsolete||
  Attachment #89386|0   |1
is obsolete||
  Attachment #89387|0   |1
is obsolete||
  Attachment #89388|0   |1
is obsolete||
  Attachment #89885|0   |1
is obsolete||

--- Comment #35 from Josef Moravec  ---
Created attachment 94880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94880=edit
Bug 15260: Add new useDaysMode option "Dayweek"

This patch adds a new "Dayweek" option to the useDaysMode syspref, it
has the description: "the calendar to push the due date to the next open
day on the same weekday".

Sponsored-by: Cheshire West and Chester and Cheshire East Councils
Sponsored-by: Newcastle City Council
Sponsored-by: Sefton Council

Signed-off-by: Liz Rea 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260

--- Comment #37 from Josef Moravec  ---
Created attachment 94882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94882=edit
Bug 15260: Modify next/prev_open_day

We require next_open_day & prev_open_day to be more flexible. We could
create a separate sub, but that's not very DRY given that they'll do
pretty much the same thing.

So next_open_day becomes next_open_days and prev_open_day becomes
prev_open_days and both functions accept an additional parameter which
determines how many days they add or subtract.

All calls of these two functions have been modified accordingly.

Sponsored-by: Cheshire West and Chester and Cheshire East Councils
Sponsored-by: Newcastle City Council
Sponsored-by: Sefton Council

Signed-off-by: Liz Rea 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260

--- Comment #36 from Josef Moravec  ---
Created attachment 94881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94881=edit
Bug 15260: Modify description of Dayweek option

Sponsored-by: Cheshire West and Chester and Cheshire East Councils
Sponsored-by: Newcastle City Council
Sponsored-by: Sefton Council

Signed-off-by: Liz Rea 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Margaret  changed:

   What|Removed |Added

 CC||margaret@bywatersolutions.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23866] HEA submission preferences should prompt similar to ManaKB

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23866

Josef Moravec  changed:

   What|Removed |Added

  Attachment #94678|0   |1
is obsolete||

--- Comment #3 from Josef Moravec  ---
Created attachment 94879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94879=edit
Bug 23866: Prompt for HEA configuration

Signed-off-by: Jonathan Druart 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23866] HEA submission preferences should prompt similar to ManaKB

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23866

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com
 QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23866] HEA submission preferences should prompt similar to ManaKB

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23866

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697

--- Comment #73 from Josef Moravec  ---
Created attachment 94878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94878=edit
Bug 14697: (QA follow-up) Remove tab chars

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
   |y.org   |

--- Comment #72 from Tomás Cohen Arazi  ---
Good job Kyle. I would love to see the resolution types be outside of AVs, but
that's really out of the scope of this bug now, as this is the way things are
actually done in Koha so far.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23928] New: Move saved reports JavaScript into separate file

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23928

Bug ID: 23928
   Summary: Move saved reports JavaScript into separate file
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org

Coding guideline JS1
(https://wiki.koha-community.org/wiki/Coding_Guidelines#JS1:_Embedding_JavaScript_blocks_in_templates)
says "Whenever possible JavaScript should be placed in a separate file."

I propose to move most of the JS embedded in reports/guided_reports_start.tt to
a separate file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23827] Cash register statistics uses old accounttype values

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23827

--- Comment #9 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #8)
> (In reply to Nick Clemens from comment #7)
> > (In reply to Jonathan Druart from comment #6)
> > > "OVERDUEA"? I suspect a typo here.
> > 
> > OVERDUEA = OVERDUE ACCRUING (UNRETURNED)
> 
> Where did you find that?
> 
> git grep 'OVERDUEA'
> git grep 'OVERDUE ACCRUING'
> => No result.

It was in the code later, that is how I understood it:
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94305=diff#a/reports/cash_register_stats.pl_sec1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23927] New: Duplicate a "Complete" order link the "New" one to the invoice

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23927

Bug ID: 23927
   Summary: Duplicate a "Complete" order  link the "New" one to
the invoice
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: severine.que...@bulac.fr
QA Contact: testo...@bugs.koha-community.org

To reproduce :
- receive an order, remember the amount of your invoice
- in a new basket, add an order "From exisitions orders (copy)"
- search your received order
- duplicate
- go to the bibliographic record "Acquisition details" tab : you can see the
"New" order as the same invoice number as the original order
- go to the invoice : you can see the 2 orders are mentioned and added to the
total amount

Sorry Jonathan I didn't catch that point when testing the new feature...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697

--- Comment #71 from Tomás Cohen Arazi  ---
Created attachment 94877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94877=edit
Bug 14697: (follow-up) Add auth values to the sample data

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13291] Remove prog option from OPACFallback syspref

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291

Owen Leonard  changed:

   What|Removed |Added

 CC|oleon...@myacpl.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374

--- Comment #29 from Nick Clemens  ---
Created attachment 94876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94876=edit
Bug 17374: (follow-up) Unit tests and remove warns

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23922] Auto-renewal digest option

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23922

Martha Fuerst  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #6 from Martha Fuerst  ---


*** This bug has been marked as a duplicate of bug 18532 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532

Martha Fuerst  changed:

   What|Removed |Added

 CC||mfue...@hmcpl.org

--- Comment #5 from Martha Fuerst  ---
*** Bug 23922 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22581] Add support for Plaine & Easie musical incipits rendering in OPAC

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581

--- Comment #13 from Agustín Moyano  ---
(In reply to Martin Renvoize from comment #12)
> Minor QA comments.

Hi Martin, I'll reply your comments

> * We appear to load the verovio css regardless of the syspref settings

Yes, I didn't notice that one

> * I think we seem to load the midi player JS even if we're only interested
> in displaying the musical notation (this might be me just not understanding
> the way the library code works)

No, midi player JS is wrapped by an IF statement


[% IF playMusicalInscripts %]
[% Asset.js("lib/verovio/000_acoustic_grand_piano.js") | $raw %]
[% Asset.js("lib/verovio/midiplayer.js") | $raw %]
[% END %]


> * The clips seem to play very quickly to me.. I'm no musician though so
> perhaps they're playing at the proper speed?

I really don't know.. the midi player library has no options to control playing
speed

> * I'm sure how the $u subfield is intended to work.. you suggest in the test
> plan that it is required for this feature.. or is that simply to prove that
> $u still displays correctly when the verovio incipit are in place?

$u subfield it's really not related to the musical inscripts.. if it's not set,
you simply don't get a link. 

I tought that it was very little effort to add a link if someone defined a url
to the audio file

Regarding your previous comment, I'll change the preferences to use '
Koha.Preference('

Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23922] Auto-renewal digest option

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23922

Carolyn Hughesman  changed:

   What|Removed |Added

 CC||chughes...@cclslib.org

--- Comment #5 from Carolyn Hughesman  ---
We have about 1/3 of our libraries using auto-renewals.  We think this is a
good idea.

Carolyn, Chautauqua-Cattaraugus Library System

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23922] Auto-renewal digest option

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23922

Hasina  changed:

   What|Removed |Added

 CC||shum...@gmail.com

--- Comment #4 from Hasina  ---
We are planning to use Auto-Renewals soon. It would be nice if we do able to
see those functions get implemented. 

Thanks.
Hasina Akhter- Pasco County Libraries

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

Bouzid Fergani  changed:

   What|Removed |Added

  Attachment #94819|0   |1
is obsolete||

--- Comment #30 from Bouzid Fergani  ---
Created attachment 94875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94875=edit
Bug 11300 - Add a new authority linker which searches for authority links on a
Z39.50 server.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23926] In EDI Order limit GIR segment to five pieces of information

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926

Colin Campbell  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |colin.campbell@ptfs-europe.
   |ity.org |com

--- Comment #2 from Colin Campbell  ---
Created attachment 94874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94874=edit
Patch correcting GIR format and test cases

To test - Tests of the functionality in t/Ediorder.t, as routine does not
require db connection can run in a development environment

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23926] In EDI Order limit GIR segment to five pieces of information

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926

Colin Campbell  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
   Severity|enhancement |normal

--- Comment #1 from Colin Campbell  ---
note some suppliers' software cannot process orders containing incorrectly
formatted GIR segments

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23918] search results incorrect for multiple vowel words

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23918

--- Comment #2 from Bernard  ---
I don't think it is fuzzy search settings. QueryFuzzy is set to "Don't try".
Which file in the zebra mapping could it be so I can check?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23830] Koha::AuthorisedValues should use Koha::Objects::Limit::Library

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23830

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23926] New: In EDI Order limit GIR segment to five pieces of information

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926

Bug ID: 23926
   Summary: In EDI Order limit GIR segment to five pieces of
information
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: colin.campb...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

In the specification for the GIR segment it states

If there are more than five items of information for one
copy or for one part order, the segment may be repeated with the same copy or
part-order sequence number in DE 7297

This was something we initially did not need to do as we have limited locations
to store GIR data. This is no longer the case as some sites are using this for
other data codes, so we need to implement the standard format

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Julian Maurice  changed:

   What|Removed |Added

  Attachment #93136|0   |1
is obsolete||

--- Comment #77 from Julian Maurice  ---
Created attachment 94871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94871=edit
Bug 15261: Check if checkout/reserve request overlaps existing reserves

When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.

- A user places a hold from opac whose requested period overlaps with an
  existing reserve period => prevent reserve
- A librarian places a hold from staff whose requested period overlaps
  with an existing reserve period => Warn librarian (Ask for
  confirmation)
- A librarian makes a checkout from staff whose requested period
  overlaps with an existing reserve period => Warn librarian (Ask for
  confirmation)

Test plan:

Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture
  PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod

1 (staff side):
- Place a hold on title (which has only one items) level with start date
  and expiration date.
- Place another hold (also title level) with period overlaping this
  reserve.
- Check you are warned about an existing reserve

2 (staff side):
- Place a hold on title (which has more than one items) level with start
  date and expiration date.
- Place another hold (also title level) with period overlaping this
  reserve.
- Check you are NOT warned about an existing reserve. Because it remains
  at least one item not reserved.

3 (staff side):
- Place a hold on item level with start date and expiration date.
- Place another hold on item level with period overlaping this reserve.
- Check you are warned about an existing reserve.

4 (opac side):
- Do the same than for staff side. Instead of a warn, reserve is
  prevented.

5:
- Place a hold on title (which has only one items) level with start date
  and expiration date.
- Try to checkout the unique item from this title with period overlaping
  the reserve period.
- Check you are warned about an existing reserve

6:
- Place a hold on title (which has more than one items) level with start
  date and expiration date.
- Checkout an item from this title with period overlaping the reserve
  period.
- Check you are NOT warned about an existing reserve.

7:
- Place a hold on item level with start date and expiration date.
- Checkout this item period overlaping the reserve period.
- Check you are warned about an existing reserve

8:
- Create a checkout (i.e from ${TODAY} to ${TODAY + 10 days}),
- Place a hold on the same item from ${TODAY + 11 days} to ${TODAY + 30
days}),
- Check that you cannot renew the checkout.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #10 from Jonathan Druart  
---
And so we need a test.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414

--- Comment #9 from Jonathan Druart  
---
Nick, it was either you restored the elsif's, or you changed the order, not
both :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #93786|0   |1
is obsolete||

--- Comment #32 from Andrew Isherwood  ---
Created attachment 94870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94870=edit
Bug 23681: Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23827] Cash register statistics uses old accounttype values

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23827

--- Comment #8 from Jonathan Druart  
---
(In reply to Nick Clemens from comment #7)
> (In reply to Jonathan Druart from comment #6)
> > "OVERDUEA"? I suspect a typo here.
> 
> OVERDUEA = OVERDUE ACCRUING (UNRETURNED)

Where did you find that?

git grep 'OVERDUEA'
git grep 'OVERDUE ACCRUING'
=> No result.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #93785|0   |1
is obsolete||

--- Comment #31 from Andrew Isherwood  ---
Created attachment 94869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94869=edit
Bug 23681: Clean up on delete

When a patron restriction type is deleted, any debarments that use that
type need to revert to the default type, this patch implements this
behaviour

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #93784|0   |1
is obsolete||

--- Comment #30 from Andrew Isherwood  ---
Created attachment 94868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94868=edit
Bug 23681: Allow for selection of restriction type

This patch displays a restriction type select box (when appropriate)
when adding manual patron restrictions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #93783|0   |1
is obsolete||

--- Comment #29 from Andrew Isherwood  ---
Created attachment 94867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94867=edit
Bug 23681: Allow for changes to debarments

The structure of debarments has changes slightly in that the displayed
text is now a product of a call to Koha::RestrictionTypes rather than
just the debarment's code. This patch allows for that

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #93782|0   |1
is obsolete||

--- Comment #28 from Andrew Isherwood  ---
Created attachment 94866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94866=edit
Bug 23681: Add management UI

This patch adds UI to allow CRUD operations on restriction types

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #93781|0   |1
is obsolete||

--- Comment #27 from Andrew Isherwood  ---
Created attachment 94865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94865=edit
Bug 23681: Add Koha::RestrictionType(s)

This patch adds the following objects:

Koha::RestrictionType
Koha::RestrictionTypes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #93778|0   |1
is obsolete||

--- Comment #24 from Andrew Isherwood  ---
Created attachment 94862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94862=edit
Bug 23681: Add PatronRestrictionTypes syspref

This patch adds the new syspref "PatronRestrictionTypes"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #93780|0   |1
is obsolete||

--- Comment #26 from Andrew Isherwood  ---
Created attachment 94864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94864=edit
Bug 23681: Add modify_patron_restrictions perm

This patch adds a new "modify_patron_restrictions" permission

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #93779|0   |1
is obsolete||

--- Comment #25 from Andrew Isherwood  ---
Created attachment 94863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94863=edit
Bug 23681: Add debarment_types

This patch adds the table debarment_types and changes
borrower_debarments.type to be a foreign key to it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23912] Get correct authorised values for location and collections facets

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23912

--- Comment #6 from Jonathan Druart  
---
(In reply to Lari Taskula from comment #4)
> Created attachment 94813 [details] [review]
> Bug 23912: Use C4::Context->interface instead of passing $opac

Also, maybe we should move this one to its own bug report (more a code
improvement than a bug fix).
It seems that we could (should?) replace the first parameter of 
searchResults at the same time ( { interface => 'opac' } )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23912] Get correct authorised values for location and collections facets

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23912

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Depends on||18322

--- Comment #5 from Jonathan Druart  
---
Change for LOC is a regression from bug 17248 (>= 16.11). CCODE is coming from
bug 18322 (>= 18.11).


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322
[Bug 18322] Add facets for ccode to zebra
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18322] Add facets for ccode to zebra

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||23912


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23912
[Bug 23912] Get correct authorised values for location and collections facets
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #28 from Jonathan Druart  
---
There are debug statements left in the patch. Also, tests are missing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23873] Allow marc modification templates to use capturing groups in substitutions

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23873

Jonathan Druart  changed:

   What|Removed |Added

   Severity|major   |enhancement
Version|19.05   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23805] Add a dedicated credit_types table

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #47 from Jonathan Druart  
---
(In reply to Martin Renvoize from comment #43)
> Created attachment 94815 [details] [review]
> Bug 23805: (RM follow-up) updatedatabase.pl mariadb support
> 
> MySQL and MariaDB have different syntax when it comes to dropping a
> CHECK constraint.
> 
> Signed-off-by: Martin Renvoize 

That's what I would do, even if dirty. Maybe we should reverse the 2 queries:
first try the MariaDB syntax, to highlight that it's our first choice.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916

--- Comment #3 from Andrew Isherwood  ---
Development note: The data being stored here (issuer) should also be made
visible in a biblio's "Checkout history" page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916

--- Comment #2 from Andrew Isherwood  ---
Hi Katrin

To me it seems that the correct place to record this is with the issue, storing
an issue ID in the action logs feels a bit like a hack. We have been known to
purge action_logs at a customer's request during an upgrade. This would mean
that relationship between the issue and they issuer would then be lost. Storing
the issuer with the issue will be forever! :)

I'm not sure it raises any data privacy issues that do not equally apply to
storing the borrower with the issue, which we already do, as well as in the
action_logs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925

paxed  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |pasi.kalli...@koha-suomi.fi
   |ity.org |

--- Comment #1 from paxed  ---
Created attachment 94861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94861=edit
Bug 23925: Value builder plugin to check ISBN validity

This patch adds a new value builder plugin ISBN.pl, which should
be attached to field 020a. The plugin will perform a simple
checksum checking when trying to save the record, and inform the
user that the ISBN is illegal if the checksum doesn't match.

The ISBN plugin is a test case for additional value builder plugin
functionality that lets the plugins check field values and
prevent saving if so desired. The example plugin has been updated
with information on how to write a pre-save check function.

To test:
1) Add the ISBN.pl plugin to the field 020a in MARC subfield
   structure admin.
2) Go to cataloguing and try to save the record, no complaints
   about the ISBN (Because the plugin will not complain about
   empty field)
3) Enter something in the 020a field and try to save, you should
   receive a complaint about illegal ISBN.
4) Enter a valid ISBN (eg. 978-951-1-27641-8) and try to save,
   there should be no complaints about the ISBN.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925

paxed  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=906

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 906] ISBN Check

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=906

paxed  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23925

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23925] New: Value builder plugin to check ISBN validity

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925

Bug ID: 23925
   Summary: Value builder plugin to check ISBN validity
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: pasi.kalli...@koha-suomi.fi
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

This patch adds a new value builder plugin ISBN.pl, which should
be attached to field 020a. The plugin will perform a simple
checksum checking when trying to save the record, and inform the
user that the ISBN is illegal if the checksum doesn't match.

The ISBN plugin is a test case for additional value builder plugin
functionality that lets the plugins check field values and
prevent saving if so desired. The example plugin has been updated
with information on how to write a pre-save check function.

To test:
1) Add the ISBN.pl plugin to the field 020a in MARC subfield
   structure admin.
2) Go to cataloguing and try to save the record, no complaints
   about the ISBN (Because the plugin will not complain about
   empty field)
3) Enter something in the 020a field and try to save, you should
   receive a complaint about illegal ISBN.
4) Enter a valid ISBN (eg. 978-951-1-27641-8) and try to save,
   there should be no complaints about the ISBN.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

--- Comment #76 from Axelle Aix-Marseille Université 
 ---
(In reply to Martin Renvoize from comment #75)
> Comment 74 is clear.. these patches, as there is a set of alternatives,
> cannot be tested on the sandboxes as they stand. They do apply however if
> you know how to pick individual sets.. hence my setting it to needs
> signoff.. right now with a 'Patch doesn't apply' status it won't be picked
> up with others.

Ok. So, sorry for my note. I thought that because status had changed, it meant
that patch was corrected and could be tested in a sandbox. I didn't know that
for one bug, you could have several patches to test.

May I replace the status to "Needs signoff" ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

--- Comment #75 from Martin Renvoize  ---
Comment 74 is clear.. these patches, as there is a set of alternatives, cannot
be tested on the sandboxes as they stand. They do apply however if you know how
to pick individual sets.. hence my setting it to needs signoff.. right now with
a 'Patch doesn't apply' status it won't be picked up with others.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23924] Add a parameter to the script add_date_fields_to_marc_records.pl to specify a date field

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23924

Jonathan Druart  changed:

   What|Removed |Added

 CC||ha...@orex.es

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23924] Add a parameter to the script add_date_fields_to_marc_records.pl to specify a date field

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23924

--- Comment #1 from Jonathan Druart  
---
Created attachment 94860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94860=edit
Bug 23924: Add --date-field to add_date_fields_to_marc_records.pl

The date used in the script will use this parameter, instead of today.

Test plan:
Use the POD of the script to understand how this flag works. Then use
the script to create fields with a date contained in a specific MARC
field.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22581] Add support for Plaine & Easie musical incipits rendering in OPAC

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581

--- Comment #12 from Martin Renvoize  ---
Minor QA comments.

* We appear to load the verovio css regardless of the syspref settings
* I think we seem to load the midi player JS even if we're only interested in
displaying the musical notation (this might be me just not understanding the
way the library code works)
* The clips seem to play very quickly to me.. I'm no musician though so perhaps
they're playing at the proper speed?
* I'm sure how the $u subfield is intended to work.. you suggest in the test
plan that it is required for this feature.. or is that simply to prove that $u
still displays correctly when the verovio incipit are in place?

Generally, I really like this feature and think we can probably do some
cleaning up in followups. 

I'm going to let this one slip past the Slush deadline a little so we should
still make it before the freeze.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23924] Add a parameter to the script add_date_fields_to_marc_records.pl to specify a date field

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23924

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22509] Add a script to generate MARC fields containing date formatted strings

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22509

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||23924


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23924
[Bug 23924] Add a parameter to the script add_date_fields_to_marc_records.pl to
specify a date field
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23924] New: Add a parameter to the script add_date_fields_to_marc_records.pl to specify a date field

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23924

Bug ID: 23924
   Summary: Add a parameter to the script
add_date_fields_to_marc_records.pl to specify a date
field
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz
Depends on: 22509

This date field will be used to set the date used in the script, instead of
today.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22509
[Bug 22509] Add a script to generate MARC fields containing date formatted
strings
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23914] Hea - share the DBMS (name and version)

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23914

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #5 from Julian Maurice  ---
(In reply to Martin Renvoize from comment #4)
> Also worth noting, CHECK constraints are not a mysqlism.. they're
> implemented in Postgres, MySQL, MariaDB, MSSQL to name but a few... the
> problem comes from how they're defined (or rather removed in this case).

In this case, I think the question should not be "is it a mysqlism ?" but
rather "is it supported by the RDBMS we support ?". And CHECK constraints
support was added in Mysql 8.0.16 and MariaDB 10.2.1. Previous versions accept
the syntax but ignore it.
I think we shouldn't rely on something that is ignored by a good part of RDBMS
(if we support Debian oldstable, MySQL version is 5.5 and MariaDB is 10.1)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Axelle Aix-Marseille Université  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||axelle.clari...@univ-amu.fr

--- Comment #74 from Axelle Aix-Marseille Université 
 ---
The status was changed from "Patch does'nt apply" to "Needs signoff" today. So
I tried on a sandbox but it still not works : 


The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 7376:
Something went wrong !Applying: Bug 7376 Transfer limits should be
checked at check-in
Applying: Bug 7376: Refactoring subroutines
Using index info to reconstruct a base tree...
M   C4/Circulation.pm
Falling back to patching base and 3-way merge...
Auto-merging C4/Circulation.pm
CONFLICT (content): Merge conflict in C4/Circulation.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 7376: Refactoring subroutines
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 7376 - Transfer limits should be checked at check-in

92774 - Bug 7376 Transfer limits should be checked at check-in
93194 - (ANOTHER IMPLEMENTATION) Bug 7376: Refactoring subroutines
93195 - (ANOTHER IMPLEMENTATION) Bug 7376: Fix wrong indentation of
CanBookBeReturned
93196 - (ANOTHER IMPLEMENTATION) Bug 7376: Transfer limits should be checked at
check-in

Apply? [(y)es, (n)o, (i)nteractive] Patch left in
/tmp/ANOTHER-IMPLEMENTATION-Bug-7376-Refactoring-subrou-21wcKc.patch .

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23911] Possibility to do more complex analysis of systempreference usage

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23911

--- Comment #2 from Jonathan Druart  
---
I can do it for you (direct access to the DB) if you provide me the sysprefs
you want to check.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23914] Hea - share the DBMS (name and version)

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23914

Jonathan Druart  changed:

   What|Removed |Added

Summary|SQL Server Version  |Hea - share the DBMS (name
   ||and version)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23825] Object.t is failing - Exception not caught

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825

--- Comment #20 from Jonathan Druart  
---
10.4.8-MariaDB-1:10.4.8+maria~stretch for me. Note that I upgraded using a
specific repo (to get the latest), before (last week) I had the one packaged
for Stretch and got the same failure.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22581] Add support for Plaine & Easie musical incipits rendering in OPAC

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581

--- Comment #11 from Martin Renvoize  ---
So far so good, I've left a comment about using `Koha.Preference(` in the
templates as an alterative to adding preference called inside the controller. 

I'll continue to test here.. going to load on of our music libraries catalogues
in and see how that looks..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Martin Renvoize  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding'

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||rel_19_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding'

2019-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293

Martin Renvoize  changed:

   What|Removed |Added

   Severity|normal  |major

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >