[Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 --- Comment #17 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23522] Show "Actual price" in basket when available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23522 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23522] Show "Actual price" in basket when available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23522 --- Comment #14 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523 --- Comment #14 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23733] Passwort import explodes when password is too 'weak' and doesn't allow empty passwords anymore
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23733 Martin Renvoize changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #8 from Martin Renvoize --- *** This bug has been marked as a duplicate of bug 23473 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23733] Passwort import explodes when password is too 'weak' and doesn't allow empty passwords anymore
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23733 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #7 from Martin Renvoize --- Isn't this a duplicate of bug 23473 ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 Martin Renvoize changed: What|Removed |Added Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 --- Comment #10 from Martin Renvoize --- *** Bug 23733 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 --- Comment #11 from Martin Renvoize --- Escalating to Major as this appears to be a regression rather than an enhancement as highlighted by bug 23733. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Fridolin SOMERS changed: What|Removed |Added Status|Needs Signoff |In Discussion CC||fridolin.som...@biblibre.co ||m --- Comment #7 from Fridolin SOMERS --- Oh using order_by on all barcodes may be a performance issue. See if we can change this code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23968] New: OPACMySummaryNote does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968
Bug ID: 23968
Summary: OPACMySummaryNote does not work
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: OPAC
Assignee: oleon...@myacpl.org
Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
The system preference OPACMySummaryNote is used to display on the logged-in
patron summary page at OPAC.
It does not display anymore.
Looks like it comes from code :
[% IF OPACMySummaryNote %][% Koha.Preference('OPACMySummaryNote') | $raw %][%
END %]
OPACMySummaryNote used to be a provided variable.
I propose to fix and add a div with an id to allow tunning of this specific
display.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23968] OPACMySummaryNote does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968 Fridolin SOMERS changed: What|Removed |Added Assignee|oleon...@myacpl.org |fridolin.som...@biblibre.co ||m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23968] OPACMySummaryNote does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968
--- Comment #1 from Fridolin SOMERS ---
Created attachment 95039
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95039&action=edit
Bug 23968: fix OPACMySummaryNote feature
The system preference OPACMySummaryNote is used to display on the logged-in
patron summary page at OPAC.
It does not display anymore.
Looks like it comes from code :
[% IF OPACMySummaryNote %][% Koha.Preference('OPACMySummaryNote') | $raw %][%
END %]
OPACMySummaryNote used to be a provided variable.
Test plan:
1) Enable system preference OPACMySummaryNote
2) Enter some HTML into it
3) Go to OPAC and loggin
4) Check you see the HTML in opac-user.pl
5) Disable the preference
6) Check you dont see the HTML anymore
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23968] OPACMySummaryNote does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968 Fridolin SOMERS changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23968] OPACMySummaryNote does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968 --- Comment #2 from Fridolin SOMERS --- Created attachment 95040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95040&action=edit Bug 23968: Add div this id around OPACMySummaryNote content -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23774] When placing a hold editing using Inspect Element allows addition to the code of non listed library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23774 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23774] When placing a hold editing using Inspect Element allows addition to the code of non listed library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23774 Jonathan Druart changed: What|Removed |Added Attachment #95023|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 95041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95041&action=edit Bug 23774: Server-side confirmation for hold pickup location in OPAC While placing a hold on a book, if a user opens up Inspect Element on the Pick up location drop down box they can change the pick up location in the code to a library that is not listed as a pick up location. How to replicate: Search for a book Select book Click Place Hold On the screen Home > Placing a hold Right click on Pick up location Select 'Inspect Element' Under Pick Up location:=$0 Option values are listed that relate to the pick up location, this value can be changed to another new location and when the hold is placed the hold will be placed for this new location instead of the listed options in the Pick up location drop down list. To test: 1. Apply patch 2. Repeat "How to replicate" 3. Observe it is no longer possible to place holds on libraries not defined as pickup location by changing option value via Inspect Element tool Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23969] New: Add library to public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23969 Bug ID: 23969 Summary: Add library to public lists Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: baselibrary.consort...@nhs.net QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl We would like to add a column and sort by library name, or separate tabs for each library on the public lists on the OPAC. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17359] Patron import results use wrong encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 --- Comment #28 from Jonathan Druart --- Created attachment 95042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95042&action=edit Bug 17359: Use a unicode character in tests And remove an unused variable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23970] New: itemsearch: when combining two fields with the boolean operator OR, the entry of the second field is not taken into account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23970 Bug ID: 23970 Summary: itemsearch: when combining two fields with the boolean operator OR, the entry of the second field is not taken into account Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: christian.stelzenmuel...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Itemsearch. Search for: publication date: 2005 OR publication date: 2006 Koha doesn't take the search for 2006 into account. Only items from 2005 are shown in the search results. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17359] Patron import results use wrong encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359
--- Comment #29 from Jonathan Druart
---
(In reply to Marcel de Rooy from comment #27)
Hi Marcel, thanks for the review.
> my $surname ='Chloé';
> my $surname_utf8 = encode_utf8($surname);
> => This name is not the best example for UTF-8. Could be Latin too.
> => You dont do anything with this encoded string.
> => When I am adding some Chinese character in the surname, the test fails.
Looks correct for me, see the last patch. Which tests fail?
> decode_utf8($borrowerline)
> Instead of adding this all over the place, we should try to fix at the
> source or at least closer.
> LINE: while ( my $borrowerline = <$handle> ) {
> You could add it here, which would be closer but thats not all. Is the
> assumption correct that it is UTF-8? We just got a handle from the caller.
> On the report I am reading about people uploading Latin data.
> Actually, we see in tools/import_borrowers.pl:
> use CGI qw ( -utf8 );
> and
> my $handle = $input->upload('uploadborrowers');
> CGI tells me that "binary upload data ... are left untouched".
> Do we actually need another parameter for the file encoding?
As it seems that there is no encoding issue during the import process I tried
to provide a patch that will not have impact on it. That's why I preferred to
only modify the lines where @missing_criticals was used.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23969] Add library to public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23969 BASE Library Consortium changed: What|Removed |Added CC||baselibrary.consortium@nhs. ||net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11514] "Uncertain" no longer display in acq
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Jonathan Druart changed: What|Removed |Added Summary|Untranslatable "Uncertain" |"Uncertain" no longer |text in acq |display in acq -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11514] Untranslatable "Uncertain" text in acq
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11514] "Uncertain" no longer display in acq
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Jonathan Druart changed: What|Removed |Added Attachment #93323|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11514] "Uncertain" no longer display in acq
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11514] "Uncertain" no longer display in acq
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Jonathan Druart changed: What|Removed |Added Attachment #93323|0 |1 is obsolete|| --- Comment #15 from Jonathan Druart --- Created attachment 95043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95043&action=edit Bug 11514: Untranslatable "Uncertain" text in acq This patch modifies two pages so that the "Uncertain price" information is shown by the template rather than the Perl script, making the text translatable. To test, apply the patch and go to Acquisitions. - Locate or create an order in a basket which has an uncertain price. - When viewing the contents of that basket the order which was marked as having an uncertain price should be labeled "Uncertain." - The same should be true for the invoice page. If you don't have an existing invoice with an "uncertain" order, - Go to "Receive shipments" for the vendor your "uncertain" order is with. - Create a new invoice. - Receive one or more orders which has an uncertain price. - Press the "finish receiving" button. - In the "Invoice details" section of the invoice page you should see the "Uncertain" label on the correct order. Signed-off-by: Christophe Croullebois Signed-off-by: Jonathan Druart For the invoice view: close, receive, reopen, mark prices uncertain, go to the invoice page (not sure it's expected however) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11514] "Uncertain" no longer display in acq
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11514] "Uncertain" no longer display in acq
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23825] Object.t is failing - Exception not caught
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #24 from Jonathan Druart --- 10.4.8-MariaDB-1:10.4.8+maria~stretch master: fail with patches: ok 10.1.41-MariaDB-0+deb9u1 master: ok with patches: fail # Failed test 'Column should be the expected one' # at t/db_dependent/Koha/Object.t line 413. # 'lastseen' # doesn't match '(?^u:borrowers\.lastseen)' # Looks like you failed 1 test of 3. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23825] Object.t is failing - Exception not caught
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 --- Comment #25 from Jonathan Druart --- Created attachment 95044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95044&action=edit Bug 23825: table name is not always displayed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23825] Object.t is failing - Exception not caught
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #26 from Jonathan Druart --- With this last patch I got the tests passing for both 10.4.8-MariaDB-1:10.4.8+maria~stretch and 10.1.41-MariaDB-0+deb9u1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 --- Comment #18 from Matthias Meusburger --- Tomás, didn't you forgot to "use Try::Tiny;" in catalogue/detail.pl for your last patch? (attachment 95013) Without the use statement, I get the following error when trying to display content: Can't locate object method "catch" via package "1" (perhaps you forgot to load "1"?) at /home/koha/src/catalogue/detail.pl line 89. With the use statement, it works properly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 --- Comment #19 from Tomás Cohen Arazi --- (In reply to Matthias Meusburger from comment #18) > Tomás, didn't you forgot to "use Try::Tiny;" in catalogue/detail.pl for your > last patch? (attachment 95013 [details] [review]) > > Without the use statement, I get the following error when trying to display > content: > > Can't locate object method "catch" via package "1" (perhaps you forgot to > load "1"?) at /home/koha/src/catalogue/detail.pl line 89. > > With the use statement, it works properly. I did -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 --- Comment #3 from Jonathan Druart --- Created attachment 95045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95045&action=edit Bug 22857: Sync koha-conf.xml files Missing entries are added to those files. Test plan: Search for typos Compare the two files and comfirm the entries are the same in both. Exception: supportdir exists in etc/koha-conf.xml only, but I think it's obsolete. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23918] Search results incorrect for multiple vowel words
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23918 Katrin Fischer changed: What|Removed |Added Version|18.11 |master Summary|search results incorrect|Search results incorrect |for multiple vowel words|for multiple vowel words -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] New: Add logging for basket relation actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Bug ID: 23971 Summary: Add logging for basket relation actions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherw...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org Acquisitions currently creates no action_logs. Some of our customers are requesting the addition of logs. The first stage of this work is to add the following logging: 1. Who created a basket and when Basket number, Basket name, Creation date, Vendor name, Creator name 2. Who edited a basket and when Basket number, Basket name, Edited date, Vendor name, Editor name 3. Who approved a basket and when Basket number, Basket name, Approval date, Vendor name, Who approved 4. Who closed a basket and when Basket number, Basket name, Closed date, Vendor name, Who closed (all should include EDI order information) This bug is related to Bug 13325, which requests logging of fund related actions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket relation actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23968] OPACMySummaryNote does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23968] OPACMySummaryNote does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968
Katrin Fischer changed:
What|Removed |Added
Attachment #95039|0 |1
is obsolete||
--- Comment #3 from Katrin Fischer ---
Created attachment 95046
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95046&action=edit
Bug 23968: fix OPACMySummaryNote feature
The system preference OPACMySummaryNote is used to display on the logged-in
patron summary page at OPAC.
It does not display anymore.
Looks like it comes from code :
[% IF OPACMySummaryNote %][% Koha.Preference('OPACMySummaryNote') | $raw %][%
END %]
OPACMySummaryNote used to be a provided variable.
Test plan:
1) Enable system preference OPACMySummaryNote
2) Enter some HTML into it
3) Go to OPAC and loggin
4) Check you see the HTML in opac-user.pl
5) Disable the preference
6) Check you dont see the HTML anymore
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23968] OPACMySummaryNote does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968 Katrin Fischer changed: What|Removed |Added Attachment #95040|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 95047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95047&action=edit Bug 23968: Add div this id around OPACMySummaryNote content Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23968] OPACMySummaryNote does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer --- Obvious template fix, passing QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23969] Add library to public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23969 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi! Can you clarify what is meant by library here? The home library of the list's creator? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Katrin Fischer changed: What|Removed |Added Depends on||22794 CC||katrin.fisc...@bsz-bw.de Summary|Add logging for basket |Add logging for basket |relation actions|related actions Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 [Bug 22794] Omnibus: Improve and extend logging in Koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 Katrin Fischer changed: What|Removed |Added Blocks||23971 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 [Bug 23971] Add logging for basket related actions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23733] Passwort import explodes when password is too 'weak' and doesn't allow empty passwords anymore
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23733 Katrin Fischer changed: What|Removed |Added Status|REOPENED|NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23733] Passwort import explodes when password is too 'weak' and doesn't allow empty passwords anymore
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23733 Katrin Fischer changed: What|Removed |Added Resolution|DUPLICATE |--- Status|RESOLVED|REOPENED --- Comment #9 from Katrin Fischer --- No, it's not a duplicate. This is about initial import and a regression, the other is a completely new behaviour. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23733] Passwort import explodes when password is too 'weak' and doesn't allow empty passwords anymore
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23733 Katrin Fischer changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #10 from Katrin Fischer --- I've retested and it seems better now: Initial import (new patrons) cardnumber,surname,userid,categorycode,branchcode,password test1,Mcknight,test1,YA,SPL,'' test2,Edwards,test2,PT,MPL, Patrons are imported, only thing I wonder about: password, userid ! test2 $2a$08$.28krH.OYaHspkZ98mTew.MBDYc4ggbgaxslZgBtmlewQ58Xoip.Wtest3 What password has been set for the second patron? Overwriting them matching on cardnumber also works as expected. Maybe I was not testing in a clean installation - closing this for now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 --- Comment #12 from Katrin Fischer --- (In reply to Martin Renvoize from comment #11) > Escalating to Major as this appears to be a regression rather than an > enhancement as highlighted by bug 23733. I just restested bug 23733 and all seems well - should we downgrade again? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 Katrin Fischer changed: What|Removed |Added Attachment #95045|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 95048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95048&action=edit Bug 22857: Sync koha-conf.xml files Missing entries are added to those files. Test plan: Search for typos Compare the two files and comfirm the entries are the same in both. Exception: supportdir exists in etc/koha-conf.xml only, but I think it's obsolete. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 --- Comment #5 from Katrin Fischer --- Reads well, just wondering if this could cause problems being there by default when not using the Let's encrypt feature provided by Koha for your certs? + __DB_USE_TLS__ + __DB_TLS_CA_CERTIFICATE__ + __DB_TLS_CLIENT_CERTIFICATE__ + __DB_TLS_CLIENT_KEY__ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 Nick Clemens changed: What|Removed |Added Attachment #93074|0 |1 is obsolete|| Attachment #93594|0 |1 is obsolete|| Attachment #94822|0 |1 is obsolete|| --- Comment #13 from Nick Clemens --- Created attachment 95049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95049&action=edit Bug 23473: Allow overwrite of passwords during import To test: 1 - Have some patrons in your system 2 - Export some of their info via reports SELECT cardnumber, userid, surname, firstname, password, branchcode, categorycode 3 - Edit the file from above, changing all the password lines 4 - Import the file with overwrite 5 - Confirm passwords have not changed (run the report again and confirm the hashes are the same) 6 - Apply patch 7 - Restart all the things 8 - Check the new box on import screen to overwrite passwrods 9 - Import file again 10 - Confirm passwords have changed 11 - Signin using new password to verify the hash is the password as supplied 12 - Repeat via commandline import supplying --overwrite_passwords option 13 - Verify works as expected 14 - Prove -v t/db_dependent/Koha/Patrons/Import.t Sponsored-by: ByWater Solutions Signed-off-by: Ron Marion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 --- Comment #14 from Nick Clemens --- Created attachment 95050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95050&action=edit Bug 23473: (follow-up) Make passwords 'secure' for tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 --- Comment #15 from Nick Clemens --- Created attachment 95051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95051&action=edit Bug 23473: (follow-up) check if overwrite_passwords is set -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 --- Comment #16 from Nick Clemens --- Created attachment 95052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95052&action=edit Bug 23473: (follow-up) Catch and show password exceptions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23825] Object.t is failing - Exception not caught
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Marcel de Rooy changed: What|Removed |Added Attachment #95044|0 |1 is obsolete|| --- Comment #27 from Marcel de Rooy --- Created attachment 95053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95053&action=edit Bug 23825: table name is not always displayed Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23972] New: No property remove_debarment for Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23972
Bug ID: 23972
Summary: No property remove_debarment for Koha::Patron
Change sponsored?: ---
Product: Koha
Version: 18.11
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Patrons
Assignee: koha-bugs@lists.koha-community.org
Reporter: mag...@libriotech.no
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
To reproduce:
- Make sure you have a borrower with a debarment
- Go to the full "patron edit" screen, e.g.
/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=1&categorycode=STAFF
- Tick the checkbox for "Remove?" connected with the debarment
- Click "Save" on the floating toolbar on the top of the screen
- Observe the "Internal Server Error" message
- Check the plack-error.log and it should say just "No property
remove_debarment for Koha::Patron"
Tested on a debian package install of Koha 18.11.03. (I also tested on current
master, but could NOT reproduce the problem there.)
I tried to grep for instances of remove_debarment being used as a property of a
Koha::Patron object, but with no luck:
$ grep -rn remove_debarment *
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt: 954:
members/memberentry.pl: 112: my @debarments_to_remove =
$input->multi_param('remove_debarment');
members/memberentry.pl: 224: qr/^add_debarment$/,
qr/^debarred_expiration$/, qr/^remove_debarment$/, # We already dealt with
debarments previously
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23972] No property remove_debarment for Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23972 Magnus Enger changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Magnus Enger --- *** This bug has been marked as a duplicate of bug 23082 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23082] Fatal error editing a restricted patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #18 from Magnus Enger --- *** Bug 23972 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23973] New: Serials module broken by Swedish translation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23973
Bug ID: 23973
Summary: Serials module broken by Swedish translation
Change sponsored?: ---
Product: Koha
Version: 18.11
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Serials
Assignee: koha-bugs@lists.koha-community.org
Reporter: mag...@libriotech.no
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com
One customer recently upgraded to 19.05.04.000 (Debian packages). After the
upgrade the serials module is broken when they view the Swedish translation,
but not when they view it in English. The most visually striking problem is
that both page 1 and 2 of the serials form is displayed on one page.
I have narrowed the problem down to
koha-tmpl/intranet-tmpl/prog/sv-SE/modules/serials/subscription-add.tt line 509
which looks like this in the Swedish translation:
var mana_enabled = [% IF (Koha.Preference('Mana') == 1 && mana_url) %]1[%
ELSE %][% END %];
and this in the English original:
var mana_enabled = [% IF (Koha.Preference('Mana') == 1 && mana_url) %]1[%
ELSE %]0[% END %];
Notice the missing 0 between ELSE and END in the Swedish template.
I have tried to look through the Swedish staff .po file, but I have not been
able to spot any strings that affect this area of the file.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #57 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #53) > As a final note, there has been a check constraint in Koha since 2012-09-12 > when one was added as part of bug 5911 +CREATE TABLE transport_cost ( + frombranch varchar(10) NOT NULL, + tobranch varchar(10) NOT NULL, + cost decimal(6,2) NOT NULL, + disable_transfer tinyint(1) NOT NULL DEFAULT 0, + CHECK ( frombranch <> tobranch ), -- a dud check, mysql does not support that + PRIMARY KEY (frombranch, tobranch), + CONSTRAINT transport_cost_ibfk_1 FOREIGN KEY (frombranch) REFERENCES branches (branchcode) ON DELETE CASCADE ON UPDATE CASCADE, + CONSTRAINT transport_cost_ibfk_2 FOREIGN KEY (tobranch) REFERENCES branches (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE +) ENGINE=InnoDB DEFAULT CHARSET=utf8; a dud check? Interestingly, MySQL 5.5, 5.7 allows you to define CHECK constraints, but with the note that they are parsed, but ignored by all storage engines. I am having the impression that this explained why I saw it and you did not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 Martin Renvoize changed: What|Removed |Added Severity|major |enhancement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18731] Add routes for acquisition orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Needs Signoff CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18731] Add routes for acquisition orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi changed: What|Removed |Added Attachment #84134|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18731] Add routes for acquisition orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi changed: What|Removed |Added Attachment #84133|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #58 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #56) > I've plain removed the check constraints from both this bug and 23049 too.. > Clearly people are generally not interested in data integrity [..] Surely people are. Too bad that you had to remove it for now. But couldnt we add a check on the about: System information ? > and it's > causing too many headaches attempting to pretend MariaDB and MySQL are the > same. On the DBMS part, since a default mysql-server install now means MariaDB in Debian, we should imo try to keep the sql stuff in mysql folder running under MariaDB and MySQL as long as practically feasible. Making another sql folder like we did for PostgreSQL was no success. Removed in 2013. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18731] Add routes for acquisition orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #18 from Tomás Cohen Arazi --- Created attachment 95055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95055&action=edit Bug 18731: OpenAPI definitions This patch introduces the OpenAPI definitions required for the orders endpoint. It matches the voted RFC. Sponsored-by: Camden County Signed-off-by: Matthias Meusburger -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18731] Add routes for acquisition orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 95054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95054&action=edit Bug 18731: Unit tests This patch implements unit tests for the orders endpoint. Sponsored-by: Camden County -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18731] Add routes for acquisition orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 95056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95056&action=edit Bug 18731: /acquisitions/orders endpoint This patches implement the /acquisitions/orders endpoint. The attribute names are consistent with the voted RFC To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => SUCCESS: Tests pass! 3. Test the API with your favourite tool (Postman?) => SUCCESS: It works as expected! 4 Sign off :-D Sponsored-by: Camden County Signed-off-by: Matthias Meusburger -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #13 from Marcel de Rooy ---
(In reply to Julian Maurice from comment #12)
> (In reply to Marcel de Rooy from comment #11)
> > (In reply to Martin Renvoize from comment #10)
> > > This seems sane to me and I like to follow the example set by DBIx::Class
> > > to
> > > be honest.. that project has been around for a long time and has made
> > > allot
> > > of good decisions for good reasons.
> >
> > I would agree with you if we were writing Koha::Objects->find at this
> > moment. But in the meantime they go back to bug 13019, pushed 02/2015. How
> > many find calls do we have now, and associated if conditions etc.?
> > In view of that volume and the risk of breaking a lot of code, I would not
> > recommend it now.
>
> Currently, calls to `find` are always in scalar context (because otherwise
> Koha croaks), and this patch doesn't change the behaviour of `find` in
> scalar context. Why do you think there's a risk of breaking code ?
Hi Julian,
This might have been a bit overcautious, you are right.
But looking at the code, I still see some problems:
+@pars = grep { defined } @pars;
This is not the same as the earlier check:
-return if !@pars || none { defined($_) } @pars;
Btw note that this statement would return an empty list (with the croak
removed).
return $object;
This is no longer good. Since you are returning 'undef' here literally while
you want to return empty list if it is list context.
You should do:
if (@pars) {
my $result = $self->_resultset()->find(@pars);
if ($result) {
$object = $self->object_class()->_new_from_dbic($result);
return $object;
}
}
return;
The last return gives empty list in list context and undef in scalar context.
I would like to see that tested too in the Objects.t test.
And we need a rebase on members/pay.pl
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260
Marcel de Rooy changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #13 from Marcel de Rooy ---
Thx for continuing here, Augustin.
Just wondering what happens here:
-subtest 'Logged in librarian is not superlibrarian & IndependentBranches'
=> sub {
Why remove another subtest??
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17359] Patron import results use wrong encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 --- Comment #30 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #28) > Created attachment 95042 [details] [review] > Bug 17359: Use a unicode character in tests > > And remove an unused variable. t/db_dependent/Koha/Patrons/Import.t | 2 +- Where did you remove it? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17359] Patron import results use wrong encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 --- Comment #31 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #29) > Looks correct for me, see the last patch. Which tests fail? my $surname ='Chloé覂'; And now it does not fail. So what can I say? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17359] Patron import results use wrong encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 --- Comment #32 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #29) > As it seems that there is no encoding issue during the import process I > tried to provide a patch that will not have impact on it. That's why I > preferred to only modify the lines where @missing_criticals was used. I think that Text::CSV resolves the issue for us by guessing the encoding correctly. Formally, we cannot even pass it the encoding because we don't know. So I can understand your point. And will pass QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17359] Patron import results use wrong encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 Marcel de Rooy changed: What|Removed |Added Attachment #94809|0 |1 is obsolete|| --- Comment #33 from Marcel de Rooy --- Created attachment 95057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95057&action=edit Bug 17359: Add tests Signed-off-by: Séverine QUEUNE Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17359] Patron import results use wrong encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17359] Patron import results use wrong encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 Marcel de Rooy changed: What|Removed |Added Attachment #95042|0 |1 is obsolete|| --- Comment #35 from Marcel de Rooy --- Created attachment 95059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95059&action=edit Bug 17359: Use a unicode character in tests And remove an unused variable. Signed-off-by: Marcel de Rooy [EDIT] Now really removed it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17359] Patron import results use wrong encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 Marcel de Rooy changed: What|Removed |Added Attachment #94810|0 |1 is obsolete|| --- Comment #34 from Marcel de Rooy --- Created attachment 95058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95058&action=edit Bug 17359: Correct encoding when displaying patron import summary There is an encoding issue when the patron import summry, the string must be UTF8 decoded before being sent to the template. Test plan: - Create a patron import CSV file with import issues. Use UTF8 characters. See file attached to the bug report 'patron_import.csv' => The screen should display the line correctly - Correct the import issue (add a surname for Chloé) => The imported patrons should contain the correct values. Signed-off-by: Séverine QUEUNE Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809
--- Comment #14 from Julian Maurice ---
(In reply to Marcel de Rooy from comment #13)
> Hi Julian,
> This might have been a bit overcautious, you are right.
> But looking at the code, I still see some problems:
>
> +@pars = grep { defined } @pars;
> This is not the same as the earlier check:
> -return if !@pars || none { defined($_) } @pars;
> Btw note that this statement would return an empty list (with the croak
> removed).
Yes, but the croak is there, so if we reach this line it means we're in scalar
context, so it would return undef.
Also, I am failing to see what the differences are between the two checks. In
both cases, if @pars is empty or contain only undefined values, the rest of the
subroutine is not executed. Can you give a value of @pars for which the
behavior differ ?
>
> return $object;
> This is no longer good. Since you are returning 'undef' here literally while
> you want to return empty list if it is list context.
I do not want to return an empty list. I want Koha::Objects::find to behave
like DBIx::Class::ResultSet::find, which returns undef if no results were found
(even if in list context)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17359] Patron import results use wrong encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 --- Comment #36 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #30) > (In reply to Jonathan Druart from comment #28) > > Created attachment 95042 [details] [review] [review] > > Bug 17359: Use a unicode character in tests > > > > And remove an unused variable. > > t/db_dependent/Koha/Patrons/Import.t | 2 +- > > Where did you remove it? :) You... lack imagination! ;) Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809
--- Comment #15 from Marcel de Rooy ---
(In reply to Julian Maurice from comment #14)
> (In reply to Marcel de Rooy from comment #13)
> > Hi Julian,
> > This might have been a bit overcautious, you are right.
> > But looking at the code, I still see some problems:
> >
> > +@pars = grep { defined } @pars;
> > This is not the same as the earlier check:
> > -return if !@pars || none { defined($_) } @pars;
> > Btw note that this statement would return an empty list (with the croak
> > removed).
>
> Also, I am failing to see what the differences are between the two checks.
> In both cases, if @pars is empty or contain only undefined values, the rest
> of the subroutine is not executed. Can you give a value of @pars for which
> the behavior differ ?
Yes, this is very theoretical.
You strip the @pars array now. Before we passed the original array unless it
only consisted of undefined values.
So suppose I pass 51, undef, 13. You are now passing 51, 13. Different thing!
Note that find responds to multiple column PKs and unique constraint stuff. (We
are probably not using in Koha.)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 --- Comment #16 from Marcel de Rooy --- (In reply to Julian Maurice from comment #14) > > return $object; > > This is no longer good. Since you are returning 'undef' here literally while > > you want to return empty list if it is list context. > > I do not want to return an empty list. I want Koha::Objects::find to behave > like DBIx::Class::ResultSet::find, which returns undef if no results were > found (even if in list context) OK. I didnt get that right away. It is quite unperlish to return ( undef ). But yes, I checked and DBIx does it here.. So, should we stick to perl or to DBIx ? Since Koha::Objects relies on DBIx, I wouldnt mind doing the latter here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #27 from Nick Clemens --- Okay, I reviewed this, what it does is that: Available doesn't change Items marked 'not for loan' at itemtype level go into 'Available for reference' Items marked 'not for loan' individually, whether negative or positive, are displayed in the 'unavailable' section with the description of the 'not for loan' status showing. If you have several not for loan statuses with the same description, e.g. 'Available for reference' then they will be displayed together in the unavailable section It also adds some classes and styling to allow for the end user to adjust using css/jquery I am attaching a smaple record as described in the test plan which you can import if using the default database. You will need to add a 'NOT_LOAN' value of 4 with opac description 'Ordered' to see it in operation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 --- Comment #28 from Nick Clemens --- Created attachment 95060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95060&action=edit Bug 7611: (follow-up) Fix display of undefined statuses and add a class -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 --- Comment #29 from Nick Clemens --- Created attachment 95061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95061&action=edit Sample marc record to illustrate display -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23974] New: hours_between and days_between lack tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Bug ID: 23974 Summary: hours_between and days_between lack tests Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Those two methods are not covered by tests, which makes difficult changes like: commit a693c7243c23f888e2fad38a4fff9f37ff4a9301 Bug 23382: hours_between should match the logic of days_between We need to add more test coverage in order to improve them. For example we would like to improve the calculation for hourly loans (due date or suspension). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23974] hours_between and days_between lack tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23382 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23974 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23974] hours_between and days_between lack tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #3 from Jonathan Druart --- Created attachment 95064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95064&action=edit Bug 23974: Add tests for days_between -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23974] hours_between and days_between lack tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #4 from Jonathan Druart --- Created attachment 95065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95065&action=edit Bug 23974: both methods should have the same logic/construction -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23974] hours_between and days_between lack tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #2 from Jonathan Druart --- Created attachment 95063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95063&action=edit Bug 23974: Add new tests for hours_between -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23974] hours_between and days_between lack tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #1 from Jonathan Druart --- Created attachment 95062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95062&action=edit Bug 23974: Improve readability This patch does not change anything, just a bit of cleaning -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23974] hours_between and days_between lack tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Jonathan Druart changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|ASSIGNED|In Discussion --- Comment #5 from Jonathan Druart --- Now that we have a base for tests we can discuss the expected behaviors/values :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260
--- Comment #14 from Agustín Moyano ---
(In reply to Marcel de Rooy from comment #13)
> Thx for continuing here, Augustin.
>
> Just wondering what happens here:
> -subtest 'Logged in librarian is not superlibrarian &
> IndependentBranches' => sub {
>
> Why remove another subtest??
Hi Marcel, now that we don't search the patron to anonymise, this test has no
sense..
We can no longer check the library of the borrower in case IndependentBranches
preference is set on.
Thanks
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
