[Koha-bugs] [Bug 23960] Issue with MariaDB version (rows column name in creator_template table)

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23960

Amit Gupta  changed:

   What|Removed |Added

 CC||chr...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22784] Archiving Purchase Suggestions

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Change sponsored?|Seeking developer   |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #39 from David Cook  ---
_FixPriority seems horrifically broken. I was really hoping that someone else
had already fixed it... heh

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #24 from David Cook  ---
This makes me so happy. I was just about to open a bug report for this, as this
would substantially improve my life .

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun)

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983

Caroline Cyr La Rose  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun)

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983

--- Comment #1 from Caroline Cyr La Rose  ---
Created attachment 95129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95129=edit
Bug 23983: Contextualization of 'Order' (verb) vs 'Order' (noun)

This patch adds context (word class, either verb or noun) to the word
'Order' when it is displayed alone in the acquisitions module.

The following files have been modified:
basket.tt
neworderbiblio.tt
newordersubscription.tt
newordersuggestion.tt
ordered.tt
parcel.tt
spent.tt
transferorder.tt
uncertainprice.tt
z3950_search.tt

To test, check all those pages in English to make sure there is
no change.
1- Go to Acquisitions
2- Create a basket
3- Add to basket from an existing record (neworderbiblio)
4- Add to basket from a subscription (newordersubscription)
5- Add to basket from a suggestion (newordersuggestion)
6- Add to basket from an external source (z3950_search)
7- In one of the orders, check the uncertain price box
8- Check the basket display table (basket)
9- Click transfer on one of the orders (transferorder)
10- Go to the vendor page and click on 'Uncertain prices' 
(uncertainprice)
11- Click on 'Receive parcel' (parcel)
12- Go to the Acquisitions home page and click on the
amount for 'ordered' (ordered)
13- Go to the Acquisitions home page and click on the
amount for 'spent' (spent)

Next, install a new language (fr-CA used as example)
1- translate create fr-CA
2- open fr-CA-messages.po and add a translation for Order
(verb) and Order (noun) (it doesn't have to be real, just
write something different for each)
3- translate install fr-CA
4- in the system preferences, enable the french language in
'language'
5- change interface language to french

Redo the tests above to make sure the word you put in the translation
for the verb is in the places where 'Order' should be a verb and that
the translation you put in for the noun is in the places where 'Order'
should be a noun

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21939] Permission for holds history tab is too strict

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #94991|0   |1
is obsolete||

--- Comment #5 from ByWater Sandboxes  ---
Created attachment 95128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95128=edit
Bug 21939: Fix permissions for holds history tab

The tab will show when the staff user has edit_borrowers
permission, but the page itself will not be accessible.
This patch fixes the page permissions to allow access
with the edit_borrowers permission as suggested by the
comments on the original bug report.

To test:
- Create a staff user with only "edit_borrowers" permission
  from the borrowers module
- Try to access the holds history tab from any patron account
- Verify you are blocked
- Apply patch
- Try again and verify the page is accessible now
- Repeat with superlibrarian and full borrowers permission.

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Bob Bennhoff 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23983] New: Contextualization of "Order" (verb) vs "Order" (noun)

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983

Bug ID: 23983
   Summary: Contextualization of "Order" (verb) vs "Order" (noun)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr

In French, the words for "Order" (verb) and "Order" (noun) are slightly
different.

We need to add contextualization (as added in 15395) to some acquisitions tt
files.

I looked through the acqui tt files and listed all the files where the word
"Order" is alone (without a sentence for context)

basket.tt
neworderbiblio.tt
newordersubscription.tt 
newordersuggestion.tt
order.tt
parcel.tt
spent.tt
transferorder.tt
uncertainprice.tt
z3950_search.tt

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381

Lisette Scheer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #94925|0   |1
is obsolete||

--- Comment #6 from ByWater Sandboxes  ---
Created attachment 95127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95127=edit
Bug 22381: Change wording on Calendar-related system preferences

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

--- Comment #103 from Bouzid Fergani  ---
Hi Michal,
I fixed the problem for import z3950.
Thanks.
Bouzid.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #30 from Katrin Fischer  ---
(In reply to Nick Clemens from comment #27)
> Okay, I reviewed this, what it does is that:
> Available doesn't change
> Items marked 'not for loan' at itemtype level go into 'Available for
> reference'
> Items marked 'not for loan' individually, whether negative or positive, are
> displayed in the 'unavailable' section with the description of the 'not for
> loan' status showing.
> 
> If you have several not for loan statuses with the same description, e.g.
> 'Available for reference' then they will be displayed together in the
> unavailable section
> 
> It also adds some classes and styling to allow for the end user to adjust
> using css/jquery
> 
> I am attaching a smaple record as described in the test plan which you can
> import if using the default database. You will need to add a 'NOT_LOAN'
> value of 4 with opac description 'Ordered' to see it in operation

Hi Nick, 

first: thank you for the summary! Second: I am sorry, it just doesn't feel
quite right yet to me :( I am trying to put into words, but please feel free to
get others opinions as well.

>Items marked 'not for loan' at itemtype level go into 'Available for reference'
>Items marked 'not for loan' individually, whether negative or positive, are 
>displayed in the 'unavailable' section with the >description of the 'not for 
>loan' status showing

1) We have built on the fact that the not-for-loan works the same on item type
as on individual level and I think this change might be controversial. With the
patch, itype level 'not for loan' is green, but individual show red = different
messages. Koha defines available as 'on the shelf' not as 'loanable' in my
understanding - so green seems the better default choice.

2) The display with the extra break looks like we are missing a label (I think
it's intended, but that's the impression I get):

Availability: Items available for loan: Midway (1).
Centerville Staff Collection (1).

Or with some more items:

Availability: Items available for loan: Centerville (1). Items available for
reference: Centerville (1).
Centerville Staff Collection (1). Damaged (1). 

I think I'd opt for removing the line break and always displaying the "Itmes
available for reference:" when there is at least one item with a not for loan
value. That would mean the first example would look like this:

Availability: Items available for loan: Midway (1). Items available for
reference: Centerville Staff Collection (1).

And the second could be like this, using a comma between different values:

Availability: Items available for loan: Centerville (1). Items available for
reference: Centerville (1),
Centerville Staff Collection (1). Damaged (1). 



Just notes (no lockers at all): 

I see that you use individual CSS classes on the items, I like that. Just
wondering: currently we use the description, so a description change will mean
the CSS needs to change as well. On the other side: not for loan values are
numeric and we are grouping the onces with the same name and I like that - so
that's probably the best way.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

Bouzid Fergani  changed:

   What|Removed |Added

  Attachment #94818|0   |1
is obsolete||

--- Comment #102 from Bouzid Fergani  ---
Created attachment 95126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95126=edit
Bug 11299 - Add a button to the biblio edition page to automatically add
authority links in the current biblio record via AJAX. Also adds a button to
easily create missing authority records.

add authority type in the form to create the missing  authority.
 when authority was found, the 600$9 field have the authid.

Testing scenario (Creating an authority record for a failed automatic link) :

 * In you system preferences, deactivate the "AutoCreateAuthorities"
preference.
 * Go to the biblio record creation form to create a new biblio record.
(koha/cataloguing/addbiblio.pl)
 * Click the "Link authorities automatically" button. A message should appear,
telling the user "No authority link was changed."
 * Add random informations in field 600$a of the biblio record.
 * Click the "Link authorities automatically" button.
   * if matching authority was found,  The message box should now show "600 - A
matching authority was found in the local database".
   * if no matching authority was found, the message box should now show  "600
- No matching authority found.".  For this scenario, we want the authority
match to have failed.
 * The 600$9 field should now be red and icons should have appeared next to
it. Click on the "create authority" icon.
 * A popup will appear, containing a form to create the missing  authority.
The form should be pre-filled, a the informations in the 600$a field of the
biblio shouldbe in the 100$a field of this new authority record.
 * Fill in the form and click the "Save" button
 * The 600$9 field in the biblio record should now be back to normal and have
the authid of the authority record that was just created.
 * Click the "Link authorities automatically" button again. The message box
should now show "No authority link was changed.".

Signed-off-by: Katrin Fischer 

https://bugs.koha-community.org/show_bug.cgi?id=12299

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

Bouzid Fergani  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23982] Count/pagination broken for reports with duplicated column names

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23982

Nick Clemens  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||ke...@bywatersolutions.com,
   ||martin.renvoize@ptfs-europe
   ||.com, tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23982] New: Count/pagination broken for reports with duplicated column names

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23982

Bug ID: 23982
   Summary: Count/pagination broken for reports with duplicated
column names
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Reports
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

bug 23624 simplified how we get the count of rows in a report, however, it
breaks under certain circumstances.

A report like:
SELECT * FROM issues JOIN borrowers USING (borrowernumber)

will have two borrowernumber columns - SQL will give us there rsults, but if we
try to wrap them in a SELECT COUNT(*) FROM (report) it throws a duplicated
column error.

I don't know an easy fix except to state that one must name the columns they
want to avoid duplication

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532

--- Comment #9 from Katrin Fischer  ---
Comment on attachment 95031
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95031
Bug 18532: set auto_renewals as patron messaging preference

Review of attachment 95031:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18532=95031)
-

::: misc/cronjobs/automatic_renewals.pl
@@ +2,4 @@
>  
>  # This file is part of Koha.
>  #
> +# Copyright (C) 2014 Hochschule f�r Gesundheit (hsg), Germany

It looks like maybe the encoding of the file was changed? it Should be reading
"für".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23600] Library group search broken for group with a big number of libraries

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23600

--- Comment #5 from Katrin Fischer  ---
I can see the link but for me the list ends at ENTIDAD THE PRUEBA in Firefox
and Chromium. Can you check, if you see the same when using the catalog without
logging in first?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532

--- Comment #8 from Chris Cormack  ---
Comment on attachment 95031
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95031
Bug 18532: set auto_renewals as patron messaging preference

Review of attachment 95031:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18532=95031)
-

::: misc/cronjobs/automatic_renewals.pl
@@ +2,4 @@
>  
>  # This file is part of Koha.
>  #
> +# Copyright (C) 2014 Hochschule f�r Gesundheit (hsg), Germany

This looks like a typo, can you fix please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949

--- Comment #7 from Tomás Cohen Arazi  ---
Created attachment 95125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95125=edit
Bug 23949: Add z3950 directory to koha-common.install

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23600] Library group search broken for group with a big number of libraries

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23600

--- Comment #4 from Andres Ovalle  ---
(In reply to Katrin Fischer from comment #3)
> (In reply to Andres Ovalle from comment #2)
> > (In reply to Katrin Fischer from comment #1)
> > > How many libraried did you group? Can you share the URL by chance? 
> > > 
> > > From the error it sounds like the search link generated got too long.
> > 
> > Hello,
> > 
> > Indeed it happens because the library group is very large, there are about
> > 800 libraries within the group.
> > 
> > Here is the OPAC URL, however the problem also occurs in the administrative
> > cataloging interface.
> > 
> > https://catalogo.patrimoniofilmico.org.co/
> > 
> > Select the "Inventario" group that appears at the end of the search box per
> > library.
> > 
> > In the list of results go to the second page.
> > 
> > Thanks
> > 
> > Andrés,
> 
> Hi Andres, I really think it's the number of libraries, but don't see a
> Group Inventario - or another group - on your Advanced search? Btw, love the
> OPAC design.


Hello,

The simple search also occurs by searching for the Inventory library group at
the end of the library list.

Could you see the following link?

https://www.dropbox.com/s/13ns9icyx4cnnu7/Nov-06-2019%2014-01-26.mp4?dl=0

The OPAC design has been stylized to look like the institutional site

Thanks,

Andrés,

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding'

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293

--- Comment #12 from Tomás Cohen Arazi  ---
Created attachment 95121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95121=edit
Bug 23293: Add system preference

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding'

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293

--- Comment #14 from Tomás Cohen Arazi  ---
Created attachment 95123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95123=edit
Bug 23293: (follow-up) Add tests for C4::Circulation change

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding'

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293

--- Comment #13 from Tomás Cohen Arazi  ---
Created attachment 95122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95122=edit
Bug 23293: Apply OPACFineNoRenewalsIncludeCredit preference

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23600] Library group search broken for group with a big number of libraries

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23600

Katrin Fischer  changed:

   What|Removed |Added

Summary|Library group search broken |Library group search broken
   |in advanced search  |for group with a big number
   ||of libraries

--- Comment #3 from Katrin Fischer  ---
(In reply to Andres Ovalle from comment #2)
> (In reply to Katrin Fischer from comment #1)
> > How many libraried did you group? Can you share the URL by chance? 
> > 
> > From the error it sounds like the search link generated got too long.
> 
> Hello,
> 
> Indeed it happens because the library group is very large, there are about
> 800 libraries within the group.
> 
> Here is the OPAC URL, however the problem also occurs in the administrative
> cataloging interface.
> 
> https://catalogo.patrimoniofilmico.org.co/
> 
> Select the "Inventario" group that appears at the end of the search box per
> library.
> 
> In the list of results go to the second page.
> 
> Thanks
> 
> Andrés,

Hi Andres, I really think it's the number of libraries, but don't see a Group
Inventario - or another group - on your Advanced search? Btw, love the OPAC
design.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding'

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293

--- Comment #15 from Tomás Cohen Arazi  ---
Created attachment 95124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95124=edit
Bug 23293: (QA follow-up) Minor fix for tests

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding'

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #93150|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding'

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #93149|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding'

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #93151|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding'

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding'

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23600] Library group search broken in advanced search

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23600

--- Comment #2 from Andres Ovalle  ---
(In reply to Katrin Fischer from comment #1)
> How many libraried did you group? Can you share the URL by chance? 
> 
> From the error it sounds like the search link generated got too long.

Hello,

Indeed it happens because the library group is very large, there are about 800
libraries within the group.

Here is the OPAC URL, however the problem also occurs in the administrative
cataloging interface.

https://catalogo.patrimoniofilmico.org.co/

Select the "Inventario" group that appears at the end of the search box per
library.

In the list of results go to the second page.

Thanks

Andrés,

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19718] Create message for patrons with multiple holds on the same item

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19718

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #92489|0   |1
is obsolete||

--- Comment #5 from ByWater Sandboxes  ---
Created attachment 95120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95120=edit
Bug 19718: Show message if patron has existing holds on a title

To test:
 1 - Set a rule to allow multiple holds on a title
 2 - Place a single hold in the opac for a patron
 3 - Return to record and attempt place a second hold
 4 - Note there is no message but that you must match the type placed before
(item or record level)
 5 - Don't place the hold
 6 - Apply patch
 7 - Attempt to place second hold again
 8 - Note there is a message informing you of which level hold you may place
 9 - Test with both item/record level holds and placing a single request or
multiple requests

Signed-off-by: donnab 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

Agustín Moyano  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23868] PayPal payment button is never enabled

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #95066|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 95119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95119=edit
Bug 23868: Check if threshold is undefined in javascript block of
opac-account.tt

This patch fixes a bug introduced by checking payment plugins threshold

To test:
1. do not apply this patch
2. configure paypal options in intranet
3. create a manual invoice for a patron
4. in opac try to pay that invoice
CHECK => Make Payment button is disabled, even when invoices where checked.
5. apply this patch
6. repeat step 4
SUCCESS => Make Payment button is enabled when an invoice is checked.
7. Sign off

Signed-off-by: Jonathan Druart 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23868] PayPal payment button is never enabled

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23868] PayPal payment button is never enabled

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|String patch|Trivial patch

--- Comment #6 from Katrin Fischer  ---
Just changing: String patch = Interface/GUI strings, changing to Trivial.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23470] Elasticsearch - OpacSuppression not implemented in search result

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23470

Katrin Fischer  changed:

   What|Removed |Added

 CC||ere.maij...@helsinki.fi

--- Comment #14 from Katrin Fischer  ---
(In reply to Marjorie Barry-Vila from comment #13)
> (In reply to Katrin Fischer from comment #11)
> > Hi Caroline, I think if it works for for Nick but not for you, we need to
> > look for the difference...
> > 
> > What version of Koha are they running?
> > Is there a way to confirm that the suppress index is configured and filled?
> 
> Hi Katrin,
> 
> Have you been able to watch Caroline's last comment?
> I have another client reporting the same problem and everything seems well
> configured for the suppress index.
> 
> Regards,
> Marjorie

Hi Marjorie, I am actually not a Elasticsearch expert, but have tried to help
narrow it down and get he experts to take a look. Last I had talked to Nick in
Marseille about it - adding both Nick and Ere in hope they have a minute and
some new ideas.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249

--- Comment #21 from Martin Renvoize  ---
Would love to see this picked back up near the beginning of the next cycle..
I'm afraid it's just missed the freeze for 19.11 :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23981] Inconsistencies with the different prices

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23981

--- Comment #2 from Caroline Cyr La Rose  ---
Created attachment 95118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95118=edit
Screenshot showing the price fields

Sorry again, just a minor thing. I noticed there is not prefilled "0.00" in the
retail price field as there is with other price fields. See attached screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|rel_19_11_candidate |rel_20_05_target
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23695] Items holdingbranch should be set to the originating library when generating a manual transfer

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|rel_19_11_candidate |rel_20_05_target

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23981] Inconsistencies with the different prices

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23981

--- Comment #1 from Caroline Cyr La Rose  ---
Another thing I noticed, when importing files into a basket, the fields are
simply labeled "Price" and "Replacement price". Price is copied into every db
field that is not replacementprice (rrp, ecost, listprice, unitprice, etc), so
there is no risk of confusion here. However, we might want to relabel it Retail
price?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|rel_19_11_candidate |rel_20_05_target

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23467] Duplicated screen if error in opac-reserve.pl

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
   Keywords|rel_19_11_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23774] When placing a hold editing using Inspect Element allows addition to the code of non listed library

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23774

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|rel_19_11_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|rel_19_11_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23522] Show "Actual price" in basket when available

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23522

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|rel_19_11_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|rel_19_11_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|rel_19_11_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|rel_19_11_candidate |rel_20_05_target

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23981] Inconsistencies with the different prices

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23981

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414

--- Comment #32 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23981] Inconsistencies with the different prices

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23981

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de,
   ||martin.renvoize@ptfs-europe
   ||.com,
   ||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23981] New: Inconsistencies with the different prices

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23981

Bug ID: 23981
   Summary: Inconsistencies with the different prices
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

I was investigating bug 18639 and I came across some inconsistencies in the
prices, where they are used, the calculations, etc.

To reproduce :
(Note: my vendor setting is "tax excluded" for both list and invoice price, I
tried with different settings and as far as I can tell, the result is the same)
1- Create a new basket
2- Add an order
3- In the financial details, enter the following informations (I know it
doesn't make sense IRL, but we are entering different prices just to see what
goes where):
   - Vendor price: 10.99
   - Tax rate: 0%
   - Discount: 0%
   - Retail price: 12.99
   - Replacement cost: 15.99
   - Actual cost: 18.99
4- Note that Budgeted cost and Total are based on *vendor* price (10.99)
5- Save your order
6- If you have access to your database, check the info that is entered (if you
don't have access to your database, you can do an SQL report with the following
query

SELECT * from aqorders where basketno = X;

Substitute de X for your basket number

My db shows the following:

listprice: 10.99
unitprice: 18.99
rrp: 12.99
replacementprice: 15.99
rrp_tax_excluded: 12.99
rrp_tax_included: 12.99
ecost: 10.99
ecost_tax_excluded: 12.99
ecost_tax_included: 12.99

Note that the ecost_tax_excluded and ecost_tax_included are not based on ecost,
but on rrp.
7- Go back to acquisitions home page and click on the amount ordered in your
budget
8- Find your order and note that the estimated cost per unit is the retail
price (12.99), not the vendor price (10.99) and not the budgeted cost as
calculated during the order (10.99).
9- Close the basket
10- Receive the order
11- On the receipt summary page (which lists all the items yet to be received),
the unit cost is the retail price (12.99) and the replacement cost is correct
12- On the item receiving page, the retail price is correct, the replacement
price is correct, the budgeted cost is the retail price not the vendor price
(listprice) nor the budgeted cost calculated during the order (ecost), the
actual price is correct.
13- In the already received page, the prices are correct
14- In the "Spent column" of the budget, the price taken out of the fund is the
actual price, which is correct.

Summary:
- The vendor price/listprice is not used anywhere else than during the first
step of the order
- The budgeted cost (ecost) is based on the retail price, the order form needs
to reflect that

Propositions:
- Unless there is a good reason to keep it (like someone wanting to
discriminate between how much the vendor sells it vs how much another vendor
might sell it), I would remove the vendor price completely and replace it with
the retail price
- Correct the order form to show the real estimated price, based on the retail
price
- Correct the db calculations to make sure the ecost is based on the rrp and
that the tax are calculated on the ecost

I'm sorry if this is all over the place, hopefully by following the steps, you
will see what I mean.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22677] Include hint on OAI-PMH URL for Koha in system preference

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22677

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|Academy,|
   |rel_19_11_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22677] Include hint on OAI-PMH URL for Koha in system preference

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22677

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)||19.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||19.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22677] Include hint on OAI-PMH URL for Koha in system preference

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22677

--- Comment #6 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414

--- Comment #31 from Martin Renvoize  ---
Well done getting this one over the finish line just in time for the freeze
guys. I was about to update it to rel_20_05_target when I spotted the diligent
final QAing.. Thanks!

Looks good, clarifies things and improves performance, Pushing :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21406] Not adding author to request can cause JS errors

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406

Lucas Gass  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to oldstable

--- Comment #10 from Lucas Gass  ---
backported to 18.11.x for 18.11.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23968] OPACMySummaryNote does not work

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968

--- Comment #6 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |jonathan.dru...@bugs.koha-c
   |y.org   |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23774] When placing a hold editing using Inspect Element allows addition to the code of non listed library

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23774

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||19.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23719] Record matching for authorities using defined fields is broken under ES

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23719

--- Comment #13 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23968] OPACMySummaryNote does not work

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||19.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23774] When placing a hold editing using Inspect Element allows addition to the code of non listed library

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23774

--- Comment #8 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23467] Duplicated screen if error in opac-reserve.pl

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467

--- Comment #7 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23483] When writing off a fine, the title of the patron is shown as description

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483

--- Comment #8 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23719] Record matching for authorities using defined fields is broken under ES

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23719

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||19.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23467] Duplicated screen if error in opac-reserve.pl

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||19.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23483] When writing off a fine, the title of the patron is shown as description

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)||19.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075

--- Comment #45 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17359] Patron import results use wrong encoding

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)||19.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17359] Patron import results use wrong encoding

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359

--- Comment #37 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11514] "Uncertain" no longer display in acq

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514

--- Comment #16 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11514] "Uncertain" no longer display in acq

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)||19.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23961] [18.11] Menu "add subcription fields" has disappeared

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23961

Lucas Gass  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to oldstable

--- Comment #5 from Lucas Gass  ---
backported to 18.11.x for 18.11.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23658] [18.11] WrongTransfer modal drops off specified checkin date on returns.pl

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23658

Lucas Gass  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to oldstable
 CC||lu...@bywatersolutions.com

--- Comment #6 from Lucas Gass  ---
backported to 18.11.x for 18.11.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23968] OPACMySummaryNote does not work

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23979] "Account is locked" message on moremember.pl should be displayed on the "Check out" tab in addition to the "Details" tab

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23979

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22677] Include hint on OAI-PMH URL for Koha in system preference

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22677

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22677] Include hint on OAI-PMH URL for Koha in system preference

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22677

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23483] When writing off a fine, the title of the patron is shown as description

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Signed Off  |Passed QA

--- Comment #7 from Martin Renvoize  ---
Trivial patch works as expected.. passing qa

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22677] Include hint on OAI-PMH URL for Koha in system preference

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22677

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #94358|0   |1
is obsolete||

--- Comment #5 from Martin Renvoize  ---
Created attachment 95117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95117=edit
Bug 22677: Include hint to OAI page path on OAI-PMH preference

This copies the way we are doing it for othe rprefs (ILSDI and similar)
and adds a hint to the description to make it easier to find the
right path for the OAI server.

To test:
- Apply patch
- Verify that the system preference for OAI-PMH includes
  now a hint to: /cgi-bin/koha/oai.pl?verb=Identify
- Verify the hint is correct (add OPAC base URL)

Signed-off-by: Lucas Gass 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23483] When writing off a fine, the title of the patron is shown as description

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #94992|0   |1
is obsolete||

--- Comment #6 from Martin Renvoize  ---
Created attachment 95116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95116=edit
Bug 23483: Show the description, not the patron's title when writing off an
individual fine/fee

When writing off an individual fine, the description shown
was the patron's title, instead of the fine description.
Fixing it by changing it to the same template variable used for
paying individuals so they match up.

To test:
- Pick a patron and make sure salutation is set (Mr, Mrs, ...)
- Create a manual fine
- For the fine, compare the description shown when using the Writeoff
  and Pay buttons next to the fine
- Verify the display is different and writeoff displays the salutation
- Apply patch
- Repeat, descriptions now should match up

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23854] Cannot edit a suggestion

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #5 from Jonathan Druart  
---
Setting to Needs Signoff to collect ideas.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23980] [18.11] Non existent include prevents template display

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23980

--- Comment #4 from Andrew Isherwood  ---
OK, I *think* I know what's going on. Bug 23229 should never have been
backported to 18.11.x since it contains patches that don't correspond with the
ILL template in that version and they add file includes to files that don't
exist in 18.11.x.

Fortunately, there have been no commits to ill-requests.tt since this was
backported, so it should be just a case of reverting the commits.

I'll add Lucas to this, since he did the backport of 23229

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809

--- Comment #25 from Julian Maurice  ---
> I am having the impression that he did not want you to give up at all. So
> please continue (ungladly) and make it work again!

I know, but at this point, it just feel like I'm pushing something that is a
matter of personal preferences rather than an objective improvement. And it's
not important enough to waste time on it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23529] Interlibrary loan javascript is broken

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23529

--- Comment #17 from Andrew Isherwood  ---
Actually, hold off on that last request... It may not actually be the case.
Just trying to determine what the heck is going on.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809

--- Comment #24 from Julian Maurice  ---
Patch rebased + some changes:

- Explicitly say in POD that `find` returns undef when there is no results.
- Fix the `if` condition so that the behaviour is unchanged (see comment 15)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23980] [18.11] Non existent include prevents template display

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23980

Andrew Isherwood  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

--- Comment #3 from Andrew Isherwood  ---
Looking at this further, I have noticed that the request for:
[% Asset.js("js/ill-list-table.js") | $raw %]
is also incorrect since, in 18.11.x, the JS has not been moved out of the
template. I will create another patch to address this

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809

Julian Maurice  changed:

   What|Removed |Added

  Attachment #92825|0   |1
is obsolete||

--- Comment #23 from Julian Maurice  ---
Created attachment 95115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95115=edit
Bug 19809: Re-allow to call Koha::Objects::find in list context

and remove 'scalar' keyword in calls where it's not needed.

Signed-off-by: Brendan Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #42 from Jonathan Druart  
---
Created attachment 95114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95114=edit
Bug 14973: Add missing filters in templates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #41 from Jonathan Druart  
---
Created attachment 95113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95113=edit
Bug 14973: Remove double declaration of suggestions_loop

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23529] Interlibrary loan javascript is broken

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23529

Katrin Fischer  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #16 from Katrin Fischer  ---
It needs to go into 19.05 first - adding Fridolin und Lucas. As discussed at
the IRC meeting today, you might want to email them.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23529] Interlibrary loan javascript is broken

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23529

Katrin Fischer  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23945] koha-remove does not support older mysql and mariadb

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23945

--- Comment #7 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #6)
> (In reply to Jonathan Druart from comment #3)
> > Debian stretch is still using MySQL 5.5, and we are suppose to support the
> > oldstable debian version.
> 
> Jessie indeed

I meant Stretch:

vagrant@kohadevbox$ more /etc/debian_version
9.11
vagrant@kohadevbox$ apt show mysql-server
Package: mysql-server
Version: 5.5.+default

But that's not a "real" mysql-server package

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23980] [18.11] Non existent include prevents template display

2019-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23980

--- Comment #2 from Andrew Isherwood  ---
Test plan:
- Do not apply the patch
- Go to /cgi-bin/koha/ill/ill-requests.pl
=> TEST: Observe that you receive the error:
   "Template process failed: file error - ill-list-table-strings.inc: not found
at ..."
- Apply the patch
- Refresh the page
=> TEST: Observe that you no longer receive the error

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >