[Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 Julian Maurice changed: What|Removed |Added Attachment #95129|0 |1 is obsolete|| Attachment #95160|0 |1 is obsolete|| --- Comment #7 from Julian Maurice --- Created attachment 95183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95183&action=edit Bug 23983: Contextualization of 'Order' (verb) vs 'Order' (noun) This patch adds context (word class, either verb or noun) to the word 'Order' when it is displayed alone in the acquisitions module. The following files have been modified: basket.tt neworderbiblio.tt newordersubscription.tt newordersuggestion.tt ordered.tt parcel.tt spent.tt transferorder.tt uncertainprice.tt z3950_search.tt To test, check all those pages in English to make sure there is no change. 1- Go to Acquisitions 2- Create a basket 3- Add to basket from an existing record (neworderbiblio) 4- Add to basket from a subscription (newordersubscription) 5- Add to basket from a suggestion (newordersuggestion) 6- Add to basket from an external source (z3950_search) 7- In one of the orders, check the uncertain price box 8- Check the basket display table (basket) 9- Click transfer on one of the orders (transferorder) 10- Go to the vendor page and click on 'Uncertain prices' (uncertainprice) 11- Click on 'Receive parcel' (parcel) 12- Go to the Acquisitions home page and click on the amount for 'ordered' (ordered) 13- Go to the Acquisitions home page and click on the amount for 'spent' (spent) Next, install a new language (fr-CA used as example) 1- translate create fr-CA 2- open fr-CA-messages.po and add a translation for Order (verb) and Order (noun) (it doesn't have to be real, just write something different for each) 3- translate install fr-CA 4- in the system preferences, enable the french language in 'language' 5- change interface language to french Redo the tests above to make sure the word you put in the translation for the verb is in the places where 'Order' should be a verb and that the translation you put in for the noun is in the places where 'Order' should be a noun Signed-off-by: Julian Maurice -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 Julian Maurice changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #8 from Julian Maurice --- I squashed the two patches together. It works as expected. Signed off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | Status|Signed Off |BLOCKED CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 --- Comment #6 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #5) > Reads well, just wondering if this could cause problems being there by > default when not using the Let's encrypt feature provided by Koha for your > certs? > > + __DB_USE_TLS__ > + __DB_TLS_CA_CERTIFICATE__ > + __DB_TLS_CLIENT_CERTIFICATE__ > + __DB_TLS_CLIENT_KEY__ This is stuff from an older 'feature': commit 84e48d03238ce2446e7ea24401bda0a8f4e4422d Author: Dimitris Kamenopoulos Date: Sun Dec 27 16:01:43 2015 +1300 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #121 from Martin Renvoize --- Fix pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23986] Batch Record Deletion does not remove records from Elasticsearch search index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23986 --- Comment #4 from Jonathan Druart --- Now it makes sense! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857
--- Comment #7 from Marcel de Rooy ---
if( $self->{'tls'} && $self->{'tls'} eq 'yes' ) {
=> if tls == __DB_USE_TLS_ (since it was not replaced by koha-create), the
condition still works
=> But I could imagine that we should want to comment it
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 Marcel de Rooy changed: What|Removed |Added Attachment #95048|0 |1 is obsolete|| --- Comment #8 from Marcel de Rooy --- Created attachment 95184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95184&action=edit Bug 22857: Sync koha-conf.xml files Missing entries are added to those files. Test plan: Search for typos Compare the two files and comfirm the entries are the same in both. Exception: supportdir exists in etc/koha-conf.xml only, but I think it's obsolete. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 --- Comment #9 from Marcel de Rooy --- Created attachment 95185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95185&action=edit Bug 22857: (QA follow-up) Cosmetic changes: typo, whitespace Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23993] New: Can't call method "notforloan" on an undefined value at C4/Reserves.pm line 1177.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23993 Bug ID: 23993 Summary: Can't call method "notforloan" on an undefined value at C4/Reserves.pm line 1177. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org Imported an unknown item type. Tried to place a hold. Can't call method "notforloan" on an undefined value at /usr/share/koha/C4/Reserves.pm line 1177. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23993] Can't call method "notforloan" on an undefined value at C4/Reserves.pm line 1177.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23993 Marcel de Rooy changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23993] Can't call method "notforloan" on an undefined value at C4/Reserves.pm line 1177.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23993 --- Comment #1 from Marcel de Rooy --- Created attachment 95186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95186&action=edit Bug 23993: Add check if itemtype exists in IsAvailableForItemLevelRequest Trivial change Test plan: Run Reserves.t Import book with unknown item type, try to place hold (with/without patch) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23993] Can't call method "notforloan" on an undefined value at C4/Reserves.pm line 1177.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23993 Marcel de Rooy changed: What|Removed |Added Severity|enhancement |normal Status|Needs Signoff |Signed Off Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | --- Comment #2 from Marcel de Rooy --- Trivial fix, self signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23994] New: AdditionalFields.t is failing randomly (U18)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994
Bug ID: 23994
Summary: AdditionalFields.t is failing randomly (U18)
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Test Suite
Assignee: ch...@bigballofwax.co.nz
Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t .. 1/12
# Failed test '->additional_field_values should return the correct values'
# at t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t line 82.
# Structures begin differing at:
# $got->[0]{value} = 'bar value for basket2'
# $expected->[0]{value} = 'foo value for basket2'
# Looks like you failed 1 test of 12.
We do not really know why, but the values are not returned in the order they
are stored in DB. Fixing this random failure for now at test level.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23994] AdditionalFields.t is failing randomly (U18)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994
--- Comment #1 from Jonathan Druart
---
Created attachment 95187
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95187&action=edit
Bug 23994: Fix random failure from AdditionalFields.t (U18)
t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t .. 1/12
# Failed test '->additional_field_values should return the correct values'
# at t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t line 82.
# Structures begin differing at:
# $got->[0]{value} = 'bar value for basket2'
# $expected->[0]{value} = 'foo value for basket2'
# Looks like you failed 1 test of 12.
We do not really know why, but the values are not returned in the order they
are stored in DB. Fixing this random failure for now at test level.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23994] AdditionalFields.t is failing randomly (U18)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23994] AdditionalFields.t is failing randomly (U18)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23994] AdditionalFields.t is failing randomly (U18)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #2 from Martin Renvoize --- As discussed on IRC, this works and gets the tests passing again... no idea why it returns differently on U18 but the order is unimportant in the context anyway. Passing QA and Pushing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23994] AdditionalFields.t is failing randomly (U18)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23986] Batch Record Deletion does not remove records from Elasticsearch search index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23986 --- Comment #5 from Jonathan Druart --- I guess we could have replaced <=> with cmp, but it seems wrong (we want a numeric sort). It's weird to see the delete request ignored by Catmandu. What about tests? I do not think it should be required for this patch as it's a quite critical bugfix, but we really should start cover that area a bit more... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23986] Batch Record Deletion does not remove records from Elasticsearch search index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23986 Jonathan Druart changed: What|Removed |Added Attachment #95177|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 95188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95188&action=edit Bug 23986: Pass strings to Catmandu for deletion The deletion subroutine expects to get a string, this is fine in most places, but when we sort our records for batch deletion they are cast to numbers and the delete is not processed. This patch quotes the biblionumbers as strings before passing them to Catmandu To aid in detecting orphaned records you can use the patches on bug 22831 To test: 1 - Have or create a bib 2 - Go to Tools->Batch record deletion 3 - Click 'Enter a list of record numbers' 4 - Enter the biblionumber' 5 - Confirm deletion 6 - Search for the record, it still appears 7 - Apply patch, restart all the things 8 - Repeat 1-6 9 - This time the record is deleted 10 - Test other methods of record deletion to confirm the record is removed Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23986] Batch Record Deletion does not remove records from Elasticsearch search index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23986 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23986] Batch Record Deletion does not remove records from Elasticsearch search index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23986 Jonathan Druart changed: What|Removed |Added Version|19.05 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22329] Parent funds showing incorrect amounts for Ordered, Spent, Available on Acquisitions Home
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22329 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #2 from Martin Renvoize --- Is this perhaps a duplicate of bug 23767 ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 Martin Renvoize changed: What|Removed |Added Keywords||rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13775] software error when choosing authority via plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775 --- Comment #10 from Jonathan Druart --- (In reply to Katrin Fischer from comment #8) > Hi Jonathan, those are the ones for MARC21: > > SELECT authtypecode, auth_tag_to_report FROM koha_kohadev.auth_types where > authtypecode != "" > > 'CHRON_TERM', '148' > 'CORPO_NAME', '110' > 'GENRE/FORM', '155' > 'GEOGR_NAME', '151' > 'MEETI_NAME', '111' > 'PERSO_NAME', '100' > 'TOPIC_TERM', '150' > 'UNIF_TITLE', '130' It that correct for all marc flavors? Only for existing installs I guess? Fix should be provided for existing installs, at code level then. What kind message should we display to the user? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23827] [19.05] Cash register statistics uses old accounttype values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23827 Marcel de Rooy changed: What|Removed |Added Summary|Cash register statistics|[19.05] Cash register |uses old accounttype values |statistics uses old ||accounttype values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23827] [19.05] Cash register statistics uses old accounttype values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23827 --- Comment #18 from Marcel de Rooy --- QA generally skips patches for older versions. Change status in order to put it on the list of the appropriate RMaint ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5365] It should be more clear how to reopen a basket in a basket group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5365] It should be more clear how to reopen a basket in a basket group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365 Marcel de Rooy changed: What|Removed |Added Attachment #95106|0 |1 is obsolete|| --- Comment #13 from Marcel de Rooy --- Created attachment 95189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95189&action=edit Bug 5365: Make more clear how to reopen a basket in a basket group The "reopen basket" button will be visible but disabled if the basket cannot be reopened. A tooltip is attached to the button to add more information. Note that the export button is still hidden, would it makes sense to display it (visible and active)? Test plan: - Create a basket - Close it - Go to the basket detail view => The reopen button should be displayed and enabled - Attach it to a basket group - Go to the basket detail view => The reopen button should be displayed but disabled Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5365] It should be more clear how to reopen a basket in a basket group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365 Marcel de Rooy changed: What|Removed |Added QA Contact|katrin.fisc...@bsz-bw.de|m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23933] commit_file.pl Can't call method "get_effective_marcorgcode" on an undefined value at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 578.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23933 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23933] commit_file.pl Can't call method "get_effective_marcorgcode" on an undefined value at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 578.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23933 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23933] commit_file.pl Can't call method "get_effective_marcorgcode" on an undefined value at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 578.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23933 Marcel de Rooy changed: What|Removed |Added Attachment #95026|0 |1 is obsolete|| --- Comment #5 from Marcel de Rooy --- Created attachment 95190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95190&action=edit Bug 23933: (bug 10132 follow-up) Fix commit_file.pl Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 Martin Renvoize changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23995] New: Check constraints are supported differently by MySQL and MariaDB so we should remove them for now.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 Bug ID: 23995 Summary: Check constraints are supported differently by MySQL and MariaDB so we should remove them for now. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org We had two check constraints in kohastructure.. MariaDB and MySQL have now both implimented support for such constraints, but decided to use different, incompatible, syntaxes. As such, we should remove the current check constraints until a time when we have a better understanding on how to work around these differences. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 --- Comment #1 from Martin Renvoize --- Created attachment 95191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95191&action=edit Bug 23995: Remove CHECK constraints from kohastructure MySQL8 and MariaDB10.3 impliment check constraints but utilise different, incompatible, syntaxes to do so. This patch removes the check constraints entirely whilst we work on a better solution to work around the incompatabilities of the two DBs. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 --- Comment #2 from Martin Renvoize --- Mysql8 Manual: `Foreign key referential actions (ON UPDATE, ON DELETE) are prohibited on columns used in CHECK constraints. Likewise, CHECK constraints are prohibited on columns used in foreign key referential actions.` This is why the accountline check constraint must be dropped to support mysql8 (no such requirement in mariadb I believe) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- Error is: DBD::mysql::st execute failed: Column 'frombranch' cannot be used in a check constraint 'transport_cost_chk_1': needed in a foreign key constraint 'transport_cost_ibfk_1' referential action. at /usr/share/perl5/DBIx/RunSQL.pm line 273. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23847] Custom item search fields don't work if subfield is 0 (e.g. Withdrawn)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23847 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 --- Comment #4 from Martin Renvoize --- Ditto for the other check constraint.. that's also upon a foreign key column then :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 Jonathan Druart changed: What|Removed |Added Attachment #95191|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 95192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95192&action=edit Bug 23995: Remove CHECK constraints from kohastructure MySQL8 and MariaDB10.3 impliment check constraints but utilise different, incompatible, syntaxes to do so. This patch removes the check constraints entirely whilst we work on a better solution to work around the incompatabilities of the two DBs. Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23996] New: MySQL 8 support
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 Bug ID: 23996 Summary: MySQL 8 support Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 Jonathan Druart changed: What|Removed |Added Blocks||23996 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 [Bug 23996] MySQL 8 support -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23996] MySQL 8 support
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 Jonathan Druart changed: What|Removed |Added Depends on||23995 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23996] MySQL 8 support
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 Jonathan Druart changed: What|Removed |Added Depends on||23997 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23997 [Bug 23997] sample_z3950_servers.sql is failing on MySQL 8 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23997] New: sample_z3950_servers.sql is failing on MySQL 8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23997
Bug ID: 23997
Summary: sample_z3950_servers.sql is failing on MySQL 8
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs@lists.koha-community.org
Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Blocks: 23996
koha_1 | DBD::mysql::st execute failed: You have an error in your SQL
syntax; check the manual that corresponds to your MySQL server version for the
right syntax to use near 'rank, syntax, encoding,recordtype) VALUES
koha_1 | ('lx2.loc.gov',210,'LCDB','','','LIBRA' at line 2 at
/usr/share/perl5/DBIx/RunSQL.pm line 273.
https://dev.mysql.com/doc/refman/8.0/en/keywords.html
=> RANK (R); added in 8.0.2 (reserved)
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996
[Bug 23996] MySQL 8 support
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23997] sample_z3950_servers.sql is failing on MySQL 8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23997 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23997] sample_z3950_servers.sql is failing on MySQL 8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23997 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23997] sample_z3950_servers.sql is failing on MySQL 8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23997 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23998] Messages REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23998 Lari Taskula changed: What|Removed |Added Severity|enhancement |new feature Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |lari.task...@hypernova.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23998] New: Messages REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23998 Bug ID: 23998 Summary: Messages REST API Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST api Assignee: koha-bugs@lists.koha-community.org Reporter: lari.task...@hypernova.fi Expose messages table via REST API. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23997] sample_z3950_servers.sql is failing on MySQL 8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23997
--- Comment #1 from Jonathan Druart
---
Created attachment 95193
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95193&action=edit
Bug 23997: Escape z3950servers.rank as it's a new MySQL 8 kw
This patch will fix installation of Koha on MySQL 8
DBD::mysql::st execute failed: You have an error in your SQL syntax; check the
manual that corresponds to your MySQL server version for the right syntax to
use near 'rank, syntax, encoding,recordtype) VALUES
('lx2.loc.gov',210,'LCDB','','','LIBRA' at line 2 at
/usr/share/perl5/DBIx/RunSQL.pm line 273.
https://dev.mysql.com/doc/refman/8.0/en/keywords.html
=> RANK (R); added in 8.0.2 (reserved)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23999] New: auth_header.sql is failing on MySQL 8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23999 Bug ID: 23999 Summary: auth_header.sql is failing on MySQL 8 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Blocks: 23996 koha_1 | DBD::mysql::st execute failed: Column 'modification_time' cannot be null at /usr/share/perl5/DBIx/RunSQL.pm line 273. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 [Bug 23996] MySQL 8 support -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23996] MySQL 8 support
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 Jonathan Druart changed: What|Removed |Added Depends on||23999 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23999 [Bug 23999] auth_header.sql is failing on MySQL 8 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23999] auth_header.sql is failing on MySQL 8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23999 --- Comment #1 from Jonathan Druart --- It's actually an error from misc4dev. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23847] Custom item search fields don't work if subfield is 0 (e.g. Withdrawn)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23847 --- Comment #5 from Marcel de Rooy --- Confusing title and test plan. Just figured out how to reproduce by searching on withdrawn in the box below instead of the withdrawn field above it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23847] Custom item search fields don't work if subfield is 0 (e.g. Withdrawn)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23847 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23847] Custom item search fields don't work if subfield is 0 (e.g. Withdrawn)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23847 Marcel de Rooy changed: What|Removed |Added Attachment #94983|0 |1 is obsolete|| --- Comment #6 from Marcel de Rooy --- Created attachment 95194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95194&action=edit Bug 23847: Fix custom item search fields if subfield is '0' The subfield is not used if is false, so if 0. We want to test if the subfield is defined and not an empty string. Test plan: - Define a new custom item search fields using a subfield '0' (withdrawn=952$0 for instance) - Define one which does not have a subfield (control field) - Search items using those newly created fields. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24000] New: working title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24000 Bug ID: 24000 Summary: working title Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24000] working title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24000 Marcel de Rooy changed: What|Removed |Added Severity|enhancement |trivial Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23960] Issue with MariaDB version (rows column name in creator_template table)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23960 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #2 from Martin Renvoize --- Can you detail how to replicate this issue Amit.. having dug around the codebase it looks like 'rows' is always correctly quoted as an identifier to me, so I'm struggling to narrow down the problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23999] auth_header.sql is failing on MySQL 8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23999 Jonathan Druart changed: What|Removed |Added Resolution|--- |MOVED Status|ASSIGNED|RESOLVED --- Comment #2 from Jonathan Druart --- Moved to koha-misc4dev https://gitlab.com/koha-community/koha-misc4dev/issues/34 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23996] MySQL 8 support
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 Bug 23996 depends on bug 23999, which changed state. Bug 23999 Summary: auth_header.sql is failing on MySQL 8 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23999 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #10 from Séverine Queune --- Created attachment 95195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95195&action=edit Bug 14973: Check existing biblio when submitting a purchase suggestion (opac side) Test plan: - Go to opac suggestions page (opac-suggestions.pl) and click on "New purchase suggestion", - type the title (and author?) of a document that stand in you database - you should get a warning message about an exiting biblio. - clicking on confirm your suggestion add it, cancel does nothing Signed-off-by: Nicole Engard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Séverine Queune changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24000] working title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24000 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #13 from Séverine Queune --- Created attachment 95198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95198&action=edit Bug 14973: Remove double textarea for notes Certainly a bad merge conflict resolution (I am certainly the one to blame). However I do not understand where this "note" variable come from. Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #11 from Séverine Queune --- Created attachment 95196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95196&action=edit Bug 14973: Check existing biblio when submitting a purchase suggestion (staff side) Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #12 from Séverine Queune --- Created attachment 95197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95197&action=edit Bug 14973: Do not skip validation step when submiting a suggestion - OPAC Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #15 from Séverine Queune --- Created attachment 95201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95201&action=edit Bug 14973: Add missing filters in templates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Séverine Queune changed: What|Removed |Added Attachment #95175|0 |1 is obsolete|| --- Comment #18 from Séverine Queune --- Created attachment 95204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95204&action=edit Bug 14963: Fix ergonomic issue on small screen Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24000] working title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24000 --- Comment #1 from Marcel de Rooy --- Created attachment 95199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95199&action=edit Bug 24000: Koha::Item::Search::Field does not return 1 Test plan: Run t/db_dependent/Koha/Item/Search/Field.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Séverine Queune changed: What|Removed |Added Attachment #95173|0 |1 is obsolete|| --- Comment #17 from Séverine Queune --- Created attachment 95203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95203&action=edit Bug 14963: Set status=ORDERED for suggestions created from existing record Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #14 from Séverine Queune --- Created attachment 95200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95200&action=edit Bug 14973: Remove double declaration of suggestions_loop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Séverine Queune changed: What|Removed |Added Attachment #95170|0 |1 is obsolete|| --- Comment #16 from Séverine Queune --- Created attachment 95202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95202&action=edit Bug 14963: Add the ability to suggest purchase on existing title This patch adds the ability to create a new purchase suggestion from an existing title. This will prevent the creation of bibliographic records that already exist in the catalogue. Also it will ease the process during acquisition. Test plan: - Login at the OPAC and go to the detail of a bibliographic record. - Note that there is a new link "New purchase suggestion for this title" on the right of the screen - Please suggest an other icon if that one is not appropriated - Click on it and submit your new suggestion => You should not get the confirmation screen (introduced by bug 14973) warning you that the title already exists. - Login staff side and order from this suggestion. - Receive items and confirm that a new bibliographic record is not created. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24000] Koha::Item::Search::Field does not return 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24000 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off Summary|working title |Koha::Item::Search::Field ||does not return 1 --- Comment #2 from Marcel de Rooy --- Super trivial, signing off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #19 from Séverine Queune --- I'm sorry Jonathan, I missed everything with bug 14973 when I signed the present one... #shameonme... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23960] Issue with MariaDB version (rows column name in creator_template table)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23960 --- Comment #3 from Amit Gupta --- (In reply to Martin Renvoize from comment #2) > Can you detail how to replicate this issue Amit.. having dug around the > codebase it looks like 'rows' is always correctly quoted as an identifier to > me, so I'm struggling to narrow down the problem. Hi Martin, I am using MariaDB version 10.3.13 (while saving the template I found the issue) and checked the log giving errors. Seems "rows" are the keyword in MariaDB 10.3.13. Can you install 10.3.13 and see the issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23997] sample_z3950_servers.sql is failing on MySQL 8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23997 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23997] sample_z3950_servers.sql is failing on MySQL 8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23997 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #2 from Martin Renvoize --- Another good catch with a trivial fix.. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 --- Comment #6 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23997] sample_z3950_servers.sql is failing on MySQL 8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23997 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23997] sample_z3950_servers.sql is failing on MySQL 8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23997 --- Comment #3 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #20 from Jonathan Druart --- (In reply to Séverine Queune from comment #19) > I'm sorry Jonathan, I missed everything with bug 14973 when I signed the > present one... > #shameonme... I will fix that :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #43 from Séverine Queune --- Found an issue coming from this patch, when testing bug 14763 : biblioitems.itemtypes is now mandatory to edit a suggestion. It seems an important data to map, so I don't think a modification of the present code is needed, but maybe a warning should be clearly displayed in the release note, and maybe Koha (About > System information ?). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Jonathan Druart changed: What|Removed |Added Attachment #95195|0 |1 is obsolete|| Attachment #95196|0 |1 is obsolete|| Attachment #95197|0 |1 is obsolete|| Attachment #95198|0 |1 is obsolete|| Attachment #95200|0 |1 is obsolete|| Attachment #95201|0 |1 is obsolete|| Attachment #95202|0 |1 is obsolete|| Attachment #95203|0 |1 is obsolete|| Attachment #95204|0 |1 is obsolete|| --- Comment #21 from Jonathan Druart --- Created attachment 95205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95205&action=edit Bug 14963: Add the ability to suggest purchase on existing title This patch adds the ability to create a new purchase suggestion from an existing title. This will prevent the creation of bibliographic records that already exist in the catalogue. Also it will ease the process during acquisition. Test plan: - Login at the OPAC and go to the detail of a bibliographic record. - Note that there is a new link "New purchase suggestion for this title" on the right of the screen - Please suggest an other icon if that one is not appropriated - Click on it and submit your new suggestion => You should not get the confirmation screen (introduced by bug 14973) warning you that the title already exists. - Login staff side and order from this suggestion. - Receive items and confirm that a new bibliographic record is not created. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #22 from Jonathan Druart --- Created attachment 95206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95206&action=edit Bug 14963: Set status=ORDERED for suggestions created from existing record Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #23 from Jonathan Druart --- Created attachment 95207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95207&action=edit Bug 14963: Fix ergonomic issue on small screen Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23851] Auto generate accession number format yymm0001 fails to add branchcode prefix(branchcode) for multiple item addition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23851 Marcel de Rooy changed: What|Removed |Added Attachment #94974|0 |1 is obsolete|| --- Comment #8 from Marcel de Rooy --- Created attachment 95208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95208&action=edit Bug 23851: Add the homebranch prefix to the barcode when adding multiple copies of an items See the comment in the code for more information. Test plan: - Set autoBarcode to hbyymmincr - Create an item and click on the barcode field - A barcode prefixed by the homebranch is generated - Click the "Add multiple copies of this item" and enter 4 - Save => Without this patch only the first item has the homebranch prefix => With this patch applied they all have a barcode in the same format Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23851] Auto generate accession number format yymm0001 fails to add branchcode prefix(branchcode) for multiple item addition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23851 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23851] Auto generate accession number format yymm0001 fails to add branchcode prefix(branchcode) for multiple item addition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23851 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23851] Auto generate accession number format yymm0001 fails to add branchcode prefix(branchcode) for multiple item addition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23851 --- Comment #9 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #6) > 3 bugs for the price of one sign-off... a good deal I'd say :) No good deal, this is horrible code ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
