[Koha-bugs] [Bug 23696] build_oai_sets.pl should take biblios from deletedbiblio_metadata too
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23696 --- Comment #5 from Josef Moravec --- (In reply to Katrin Fischer from comment #4) > This patch appears pretty straight-forward and it works for me, but I am > having trouble with rerunning the script: > > 1) On running the script a second time, I get a lot of errors: > DBD::mysql::st execute failed: Duplicate entry '50-1' for key 'PRIMARY' [for > Statement " > INSERT INTO oai_sets_biblios (set_id, biblionumber) > VALUES (?,?) > " with ParamValues: 0='1', 1=50] at > /home/vagrant/kohaclone/C4/OAI/Sets.pm line 597. > DBD::mysql::st execute failed: Duplicate entry '52-1' for key 'PRIMARY' [for > Statement " > INSERT INTO oai_sets_biblios (set_id, biblionumber) > VALUES (?,?) > " with ParamValues: 0='1', 1=52] at > /home/vagrant/kohaclone/C4/OAI/Sets.pm line 597. Hi Katrin, thanks for testing! when you are running this script more than once, you need to add -r parameter - it will clean the table before generating it again. > > 2) Also the links for Metadata and Set don't appear to work in our HTML > representation of the OAI-Server: > > /cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=oai_dc&set=TEST Can you add more details to this question? > > 3) Even without the patch and after rerunning the script reporting 45 > records (instead of the 46 it should have), I still can see a deleted record > in the web output of the set. The access to records are not limited by set, you can use OAI without set parameter in Koha. And it is OK, because set is optional by standard: http://www.openarchives.org/OAI/openarchivesprotocol.html#Set -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Failed QA --- Comment #17 from Marcel de Rooy --- Patrons.t fails on set_password set_password contains an update (which was formerly DBIx, and now no longer), so it is now routed back to sub store which starts another txn_do store contains a get_from_storage for the password, and here we end up in some transaction problem with wrong data -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24184] Reword FallbackToSMSIfNoEmail syspref text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24184 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24184] Reword FallbackToSMSIfNoEmail syspref text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24184 Marcel de Rooy changed: What|Removed |Added Attachment #96054|0 |1 is obsolete|| --- Comment #4 from Marcel de Rooy --- Created attachment 96057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96057&action=edit Bug 24184: Reword FallbackToSMSIfNoEmail syspref text Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24184] Reword FallbackToSMSIfNoEmail syspref text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24184 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- We might consider renaming the pref here ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24170] sysprefs search result does not have a consistent order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24170 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24170] sysprefs search result does not have a consistent order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24170 Marcel de Rooy changed: What|Removed |Added Attachment #95995|0 |1 is obsolete|| --- Comment #4 from Marcel de Rooy --- Created attachment 96058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96058&action=edit Bug 24170: Fix sysprefs search result order The same sysprefs search will not always return the results in the same order. If you search for 'd' in the "search system preferences" box /cgi-bin/koha/admin/preferences.pl?op=search&searchfield=d you will see that the modules are not ordered consistently. This patch makes them display alphabetically Test plan: Search the same string several times in the syspref list. The search result should always be ordered the same way Signed-off-by: cori Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24170] sysprefs search result does not have a consistent order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24170 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24184] Reword FallbackToSMSIfNoEmail syspref text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24184 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] "Not finding what you're looking" display needs to be fixed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #21 from Marcel de Rooy --- QAing Intrigued, cant we do this simpler? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] "Not finding what you're looking" display needs to be fixed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Marcel de Rooy changed: What|Removed |Added Attachment #96035|0 |1 is obsolete|| --- Comment #22 from Marcel de Rooy --- Created attachment 96059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96059&action=edit Bug 21270: "Not finding what you're looking for" displaying uselessly When doing OPAC search, at the bottom you have an offer presented with "Not finding what you're looking for" to introduce Suggestions or ILL if enabled. Bug 7317 modified the if-else and now if you enable ILLModule but not AnonSuggestions and are not logged, you have this little string sitting there, offering nothing to the user. Just taunting them... TEST: 0) Set IllModule to true, AnonSuggestions to false. 1) Without login, just to an OPAC search. At the bottom will be a nice string laughing at your failed search 2) Apply the patch. 3) Problem at 1) is fixed. 4) Login to validate that ILL link now appear. 5) Modify combination of IllModule and AnonSuggestions to validate links appearing. Patch applies and functions as described. Signed-off-by: Dilan Johnpullé Signed-off-by: Andrew Isherwood Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] "Not finding what you're looking" display needs to be fixed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Marcel de Rooy changed: What|Removed |Added Attachment #96037|0 |1 is obsolete|| --- Comment #23 from Marcel de Rooy --- Created attachment 96060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96060&action=edit Bug 21270: Display "Make an Interlibrary loan request" even if "suggestions" is turned off Test plan: - Turn off "suggestions" - Turn on "ILLModule" => When logged in you should see the "Make an Interlibrary loan request" - Turn on "suggestions" - Turn off "ILLModule" => When logged in you should see the "Make a purchase suggestion" - Turn on "suggestions" - Turn on "ILLModule" => When logged in you should see both links. - Turn off "suggestions" - Turn off "ILLModule" => You should not see the "Not finding what you're looking for?" block - Turn on "suggestions" - Turn on AnonSuggestions => You should see the "Make a purchase suggestion" even when logged out Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] "Not finding what you're looking" display needs to be fixed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] "Not finding what you're looking" display needs to be fixed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 --- Comment #24 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #21) > QAing Intrigued, cant we do this simpler? Probably only marginal ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] "Not finding what you're looking" display needs to be fixed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Marcel de Rooy changed: What|Removed |Added QA Contact||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23483] When writing off a fine, the title of the patron is shown as description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 --- Comment #9 from Katrin Fischer --- We found this in 18.11 - please backport! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23970] itemsearch - publication date not taken into account if not used in the first field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23970 Marcel de Rooy changed: What|Removed |Added Attachment #95991|0 |1 is obsolete|| --- Comment #6 from Marcel de Rooy --- Created attachment 96061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96061&action=edit Bug 23970: Make search with "Publication date" field work at any position The changes made in the following commit: commit 0d2e83bca5b91376e9262b6cb0b993f09b919018 Bug 14636: Item search - fix search and sort by publication date for MARC21 was put at the wrong place. It was inside a "if $i == 1" test that impacts the first field only. Test plan: 0/ Use a MARC21 installation 1/ Search items by publication date, use twice the field using different values. For instance: publication date: 2005 OR publication date: 2006 => Without this patch you only get results for 2005 => With this patch applied you get results for both years. Signed-off-by: Joonas Kylmälä Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23970] itemsearch - publication date not taken into account if not used in the first field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23970 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23970] itemsearch - publication date not taken into account if not used in the first field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23970 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24136] Add libraries (sponsors) to the about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24136 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24136] Add libraries (sponsors) to the about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24136 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24136] Add libraries (sponsors) to the about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24136 Marcel de Rooy changed: What|Removed |Added Attachment #95882|0 |1 is obsolete|| --- Comment #6 from Marcel de Rooy --- Created attachment 96062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96062&action=edit Bug 24136: Update sponsors for 19.11 cycle Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24185] New: 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185
Bug ID: 24185
Summary: 'If all unavailable' state for 'on shelf holds' makes
holds page very slow if there's a lot of items
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Cataloging
Assignee: koha-bugs@lists.koha-community.org
Reporter: nug...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl
When "reserve/request.pl -> C4/Reserves.pm::IsAvailableForItemLevelRequest"
called many times with hundred of items and "on shelf holds" parameter set to
"If all unavailable" for these items+patron, it goes very slow.
This happens because in subloop there are re-checking if all other item
unavailable so it is O(n^2) and it re-checks each time a lot of the same info
for each item with repeating DB/data requests, these three:
- GetBranchItemRule (per item type)
- IsItemOnHoldAndFound (per item)
- notforloan (per item)
Proposed fix: I created patch to have in-variable cache in upper-level
subroutine before entering the first "items" loop and passing that hash
reference down into subs to cache these three values by keys per-item and
per-item-type.
It is simplest way to make it fast without re-thinking pretty complicated whole
algorithm and business logic, and, when tested by speed it gave big improvement
in execution time.
How to reproduce:
1) on fresh installed kohadevbox create/import one book,
record that biblionumber for later use it in down below,
2) add 100 items for that book for some library,
3) find some patron, that patron's card number we will
use as a borrower down below to open holds page,
4) check for the rule or set up single circulation rule
in admin "/cgi-bin/koha/admin/smart-rules.pl",
so that rule will match above book items/libary/patron,
check that rule to have non-zero number of holds (total, daily, count) allowed,
and, IMPORTANT: set up "On shelf holds allowed" to "If all unavailable",
("item level holds" doesn't matter).
5) open "Home > Catalog > THAT_BOOK > Place a hold on THAT_BOOK" page
("holds" tab), and enter patron code in the search field,
or you can create direct link by yourself, for example in my case it was:
/cgi-bin/koha/reserve/request.pl?biblionumber=4&findborrower=23529000686353
6) it should be pretty long page generation time.
I tested on my computer in VirtualBox for this page generation times,
(stats below is for many runs and smallest value taken from similar in a
repetition),
last one block eith times with that in-var-cache solution I am proposing:
"On shelf holds allowed" != "If all unavailable":
for 100 items:5 seconds,
for 200 items: 10 seconds,
for 300 items: 11 seconds,
"On shelf holds allowed" == "If all unavailable":
for 100 items:50 seconds,
for 200 items: 3.1 minutes,
for 300 items: 7.0 minutes,
"On shelf holds allowed" == "If all unavailable" with cache:
for 100 items:7 seconds,
for 200 items: 20 seconds,
for 300 items: 38 seconds,
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Andrew Nugged changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |nug...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24168] Errors with use of CanItemBeReserved return value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
--- Comment #4 from Marcel de Rooy ---
Hmm. I actually do not see the difference this patch makes. Looks to me if
nothing really changes here.
Before we tested $var->{status} eq 'OK' and now we put status into $var and
test $var eq 'OK'.
Where is the bug that we should solve ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #12 from Andrew Isherwood --- Created attachment 96063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96063&action=edit Bug 23961: (follow-up) Remove data duplication In response to Séverine observations in comment #10, this patch removes the duplicate logging of the borrowernumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #13 from Andrew Isherwood --- (In reply to Séverine Queune from comment #10) > 3 things about this MODIFY_BASKET log : > - as the borrowernumber is saved in the 'user' field, why duplicating it > in the 'info' field ? Thanks for point this out, I have attached a patch that removes this duplication. > - in this 'info' field, we usually have the details of the action made by > the user. To me, the information displays for now in not really usefull. The idea is that we're logging the minimal amount of information in the action logs but, through a report, it would be possible to obtain additional information about the related objects as required, such as basket, borrower etc. This logging is very much a starting point, I'll be elaborating on this point in response to Katrin's message. > - I only get log when I modify the "Managing library" but not when I > update the managers of the basket, not when I edit the basket. Is that the > expected behaviour ? Again, this logging is a starting point > > > - Approve a basket via EDI > > => TEST: Observe that an Acquisitions action log has been created > > containing: > > => Basket number > > => Borrowernumber of the user who approved the basket, this is stored in > > "info" as a left padded 10 digit number which can be joined on to the > > borrowers table > I tried several EDI settings but it still doesn't work so one mode ime, I > didn't test this part (would be happy if someone could help !). Thanks, I'll do some testing and fix any problems. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #14 from Andrew Isherwood --- (In reply to Katrin Fischer from comment #11) > I am sorry... but I'd like to at least try to explain my point of view a bit > more. This bug states to add logging for basket related actions and of all > the basket related actions one is missing. I don't feel this is out of scope > at all. I've thought about why this is bothering me so much. I think it > comes down to this: One of the biggest challenges we face is to develop Koha > to be consistent and intuitive, to work as one piece of software, for > everyone using it. When I have a feeling that something will cause question > marks, and have me say: 'I know that doesn't make sense' to a library later, > I feel I have to point it out. Hi Katrin Thanks for your comments :) Firstly, I *completely* understand what you're saying and agree with everything. The challenge I face is that we have very specific requirements from the customer who is sponsoring this work and the patches that I have created address those requirements. So my comment about additional logging being out of scope meant that it was out of scope of those requirements. You're right, it is not out of scope of basket logging. There are many actions that can be performed on a basket, Séverine highlighted this by pointing out that logging did not occur when a basket manager is changed. Our requirement was to add logging of basket modification in the context of modifying the basket contents. Ideally, this bug would log every possible action on a basket, but that would significantly increase development time. I feel that this work is a foundation which will facilitate the addition of further logging. That said, I am about to create a patch to add basket reopening and basket header modification logging since those were specifically mentioned by yourself and Séverine. It's also worth me pointing out that I am about to embark on a further Acq logging development that is being sponsored by another customer, this will add substantial logging to other areas of Acq and will hopefully partly address some of your concerns. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #15 from Katrin Fischer --- (In reply to Andrew Isherwood from comment #14) > (In reply to Katrin Fischer from comment #11) > > > I am sorry... but I'd like to at least try to explain my point of view a bit > > more. This bug states to add logging for basket related actions and of all > > the basket related actions one is missing. I don't feel this is out of scope > > at all. I've thought about why this is bothering me so much. I think it > > comes down to this: One of the biggest challenges we face is to develop Koha > > to be consistent and intuitive, to work as one piece of software, for > > everyone using it. When I have a feeling that something will cause question > > marks, and have me say: 'I know that doesn't make sense' to a library later, > > I feel I have to point it out. > > Hi Katrin > > Thanks for your comments :) Firstly, I *completely* understand what you're > saying and agree with everything. The challenge I face is that we have very > specific requirements from the customer who is sponsoring this work and the > patches that I have created address those requirements. So my comment about > additional logging being out of scope meant that it was out of scope of > those requirements. You're right, it is not out of scope of basket logging. > > There are many actions that can be performed on a basket, Séverine > highlighted this by pointing out that logging did not occur when a basket > manager is changed. Our requirement was to add logging of basket > modification in the context of modifying the basket contents. Ideally, this > bug would log every possible action on a basket, but that would > significantly increase development time. I feel that this work is a > foundation which will facilitate the addition of further logging. > > That said, I am about to create a patch to add basket reopening and basket > header modification logging since those were specifically mentioned by > yourself and Séverine. > > It's also worth me pointing out that I am about to embark on a further Acq > logging development that is being sponsored by another customer, this will > add substantial logging to other areas of Acq and will hopefully partly > address some of your concerns. Thx Andrew for not getting this wrong most of all :) Also for considering an additon - you are right, Severine made a good point about the basket users. I am not going to block this and secretly hope the path of logging might lead you in direction of funds and budgetes - I know this was often wished for. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 Marcel de Rooy changed: What|Removed |Added QA Contact|martin.renvoize@ptfs-europe |m.de.r...@rijksmuseum.nl |.com| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
--- Comment #8 from Marcel de Rooy ---
my $suspension_days = $deltadays * $finedays;
finedays is a number, deltadays is not ?
and then:
floor( $suspension_days->in_units('days') etc
suspension_days is just a number not a duration?
Does not look good to me.
Why do the tests pass ? Do we need more tests ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 --- Comment #9 from Marcel de Rooy --- Why do we need a fine charging interval and a suspension interval btw ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #16 from Andrew Isherwood --- (In reply to Katrin Fischer from comment #15) > [..] I am not going to block this and secretly hope the > path of logging might lead you in direction of funds and budgetes - I know > this was often wished for. Well, you will hopefully be pleased. These are the requirements for the next work I am doing: 1. Order line cancellations This would show order line details including who made the cancellation and when the cancellation was made 2. Order line creations This would show order line details including who created the order line, when it was created, the fund, and amount 3. Invoice adjustment additions This would show the adjustment details, who added the adjustment, when it was added, the fund, and amount 4. Invoice adjustment amendments This would show the adjustment details, who amended the adjustment, when it was amended, the fund, and amount 5. Invoice adjustment deletions This would show the adjustment details, who deleted the adjustment, when it was deleted, the fund, and amount 6. Order line receipts against an invoice This would show the order line details, who received the order line, when it was received, the fund, and amount 7. Budget Adjustments This would show amounts added or removed from a budget (excluding spent), who, when, and amount 8. Fund adjustments This is essentially a bank statement. It would show additions and subtractions to a fund (excluding spent), who, when, amount, previous total, new total 9. Order release date (1) This would show individual order lines from an EDI message, when they were sent, who sent it, fund, and amount 10. Order release date (2) This would show individual order lines from a basket, when it was closed, who closed it, fund, and amount -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 Katrin Fischer changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- CC||katrin.fisc...@bsz-bw.de --- Comment #40 from Katrin Fischer --- This was "RESOLVED FIXED" as part of the automatic clean-up after release - I am reopening it because of Christopher's comment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 Katrin Fischer changed: What|Removed |Added Status|REOPENED|NEW -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 --- Comment #10 from Hugo Agud --- because some libraries doesn't suspend 1 day a patron for every day delayed, as the same way that not all libraries charge 1 usd per every day delayed. In fact I guess that the majority has "x" suspension days for every "y" delayed days, at least in Spain, I am not sure how it works in other countries.. it gives more flexibility to circulation rules hope it helps! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Bug 23091 depends on bug 22877, which changed state. Bug 22877 Summary: Returning a lost item not marked as returned can generate additional overdue fines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 --- Comment #11 from Marcel de Rooy --- (In reply to Hugo Agud from comment #10) > because some libraries doesn't suspend 1 day a patron for every day delayed, > as the same way that not all libraries charge 1 usd per every day delayed. > > In fact I guess that the majority has "x" suspension days for every "y" > delayed days, at least in Spain, I am not sure how it works in other > countries.. it gives more flexibility to circulation rules > > hope it helps! Hi Hugo My question is about the two intervals. Why would you charge 1 usd per 2 days and 2 suspension days per another interval ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 --- Comment #12 from Marcel de Rooy --- But is not really relevant to ask :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #17 from Andrew Isherwood --- Created attachment 96064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96064&action=edit Bug 23971: (follow-up) Add additional basket logging This patch adds additional basket logging as discussed in comment #14 - Basket reopening - Basket users (manager) modification - Basket header modification -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #18 from Andrew Isherwood --- I can't find any problems with the EDI approval basket closure. I'm going to set this back to "Needs Signoff" as I think I've addressed the additional requirements. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23391] Hide finished ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391 --- Comment #1 from Magnus Enger --- This is getting to be a real problem for some of our more ILL-active libraries. One solution could be to just have a syspref that takes a list of statuses that should be hidden by default, perhaps? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24106] In returns.pl, don't search for item if no barcode is provided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24106 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23541 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24085] Double submission of forms on returns.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24085 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23541 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23541] Duplicate Hold Notifications
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23541 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24106, ||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24085 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
--- Comment #13 from Jonathan Druart
---
(In reply to Marcel de Rooy from comment #8)
> my $suspension_days = $deltadays * $finedays;
> finedays is a number, deltadays is not ?
>
> and then:
> floor( $suspension_days->in_units('days') etc
>
> suspension_days is just a number not a duration?
I am not sure I understand your concern here.
perl -MDateTime::Duration -e 'my $dur = DateTime::Duration->new( days => 3 );
$dur *= 3; print $dur->in_units("days")'
This is valid and will display 9
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 --- Comment #14 from Jonathan Druart --- Also note that I am not modifying anything here, just moving up a code that is not at the correct place. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24168] Errors with use of CanItemBeReserved return value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168 --- Comment #5 from Jonathan Druart --- Take a look at the file and search for "can_item_be_reserved". There is another occurrence. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 Martin Renvoize changed: What|Removed |Added Attachment #96005|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 96065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96065&action=edit Bug 24146: Add test cases This patch adds test cases for both checking amountoutstanding values are handled correctly and also that the paid down accruing fines do not add additional fines on increment. Test plan: Read the changeset and asses whether the changes/additional tests are correct as per the expected behaviour. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 --- Comment #11 from Martin Renvoize --- Created attachment 96067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96067&action=edit Bug 24146: Corrections to UpdateFine logic concerning maxFine The `maxFine` system preference actually refers to the amount of outsanding debt (in fines) a patron may have at a given time. This patch corrects the functionality of UpdateFine such that it properly respects that counter given the payment of accruing fines scenario. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 Martin Renvoize changed: What|Removed |Added Attachment #96006|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 96066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96066&action=edit Bug 24146: Increment existing fine We should increment an existing fine even if it has been fully paid off whilst it is still incrementing and not create a new fine. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 --- Comment #12 from Nick Clemens --- Created attachment 96068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96068&action=edit Bug 24146: Illustrate increasing and decreasing fine -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
