[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235

Josef Moravec  changed:

   What|Removed |Added

   Severity|normal  |major

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11)

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
 Status|Signed Off  |BLOCKED

--- Comment #12 from Marcel de Rooy  ---
Looking here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24090] Subfield text in red when mandatory in record edition

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24090

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24090] Subfield text in red when mandatory in record edition

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24090

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #96075|0   |1
is obsolete||

--- Comment #3 from Marcel de Rooy  ---
Created attachment 96237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96237&action=edit
Bug 24090: Subfield text in red when mandatory in record edition

In biblio or autority record edition, color subfield text in red when
mandatory.
Like patron fields in patron edition form.

Test plan :
1) Edit a biblio record
2) See that mandatory subield text is red (#C00)
3) Same in autority record edition

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24090] Subfield text in red when mandatory in record edition

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24090

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684

--- Comment #11 from Marcel de Rooy  ---
Not sure if this works:
+ok( ref($r_us) && ref($r_them),
+'Successful delete should return the object ' );

Note that it depends on the storage backend:
"The return value is a pass through of what the underlying storage backend
returned, and may vary."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684

--- Comment #10 from Marcel de Rooy  ---
Distracted by:
warn "Deleted $count patrons\n" if $params->{verbose};
in Koha/Patrons.pm ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24230] intranet_js plugin hook is after body end tag

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24230

--- Comment #1 from Fridolin SOMERS  ---
Created attachment 96236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96236&action=edit
Bug 24230: fix intranet_js plugin hook before body end tag

The plugin hook intranet_js is after body tag in intranet-bottom.inc :

[% KohaPlugins.get_plugins_intranet_js | $raw %]


It must be before like in opac-bottom.inc

Test plan :
1) Install a Koha plugin with intranet_js hook, like KitechenSink
2) Go to an intranet page
3) Look at source of the page to see plugin code is before body end tag

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24230] intranet_js plugin hook is after body end tag

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24230

Fridolin SOMERS  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24230] intranet_js plugin hook is after body end tag

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24230

Fridolin SOMERS  changed:

   What|Removed |Added

Summary|intranet_js plugin hook is  |intranet_js plugin hook is
   |after body  |after body end tag

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23223] Allow requested items to be checked out via SIP2

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23223

--- Comment #3 from Agustín Moyano  ---
Created attachment 96234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96234&action=edit
Bug 23223: Add AllowItemsOnHoldCheckoutSIP preference

This patch adds a new systempreference for behavior for
AllowItemsOnHoldCheckout may difer between intranet, SCO and SIP

To test:
1. apply this patch
2. perl installer/data/mysql/updatedatabase.pl
SUCCESS => There is a new syspref called AllowItemsOnHoldCheckoutSIP
3. configure and start SIPServer
4. with misc/sip_cli_emulator.pl try to checkout an item with a hold
CHECK => checkout is not allowed
5. set AllowItemsOnHoldCheckoutSIP to Allow
6. restart SIPServer
7. repeat step 4
SUCCESS => checkout is allowed
8. Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23223] Allow requested items to be checked out via SIP2

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23223

--- Comment #4 from Agustín Moyano  ---
Created attachment 96235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96235&action=edit
Bug 23223: Disable syspref cache in SIPServer

When a syspref is modified, SIPServer doesn't update it's cached value until
restarted. This patch disables syspref cache for SIPServer.

To test:
1. set AllowItemsOnHoldCheckoutSIP preference to Don't allow
2. configure and start sipserver
3. with misc/sip_cli_emulator.pl try to checkout an item that has a hold
CHECK => checkout is not allowed
4. set AllowItemsOnHoldCheckoutSIP preference to Allow
5. repeat step 3
CHECK => checkout is still not allowed
6. apply this patch and restart_all
7. repeat steps 1 to 5
SUCCESS => checkout is allowed / disallowed according to
AllowItemsOnHoldCheckoutSIP preference value and no SIPServer restart is needed
8. Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23223] Allow requested items to be checked out via SIP2

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23223

Agustín Moyano  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24236] New: Using quotes in a cataloging search, resulting in multiple pages, will not allow you to advance page

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24236

Bug ID: 24236
   Summary: Using quotes in a cataloging search, resulting in
multiple pages, will not allow you to advance page
 Change sponsored?: ---
   Product: Koha
   Version: 19.05
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tgoat...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

When you do a search that has multiple page results in cataloging, if you do
that search in quotations it will not allow you to advance the page.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235

--- Comment #2 from Radek Šiman (R-Bit Technology, s.r.o.)  ---
To reproduce this bug, please turn OFF sms PREDUEDGST, but have sms DUEDGST
turned ON for a given borrower. Sms version of DUEDGST is never generated into
the message queue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235

--- Comment #1 from Radek Šiman (R-Bit Technology, s.r.o.)  ---
Function send_digests contains hard-coded value "advance_notice" in messge_name
(line 552 of advance_notice.pl), but it should be passed-in as a parameter,
because it's called for Advance_Notice as well as for Item_Due message
attributes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235

Michal Denar  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235

Michal Denar  changed:

   What|Removed |Added

   Severity|enhancement |normal
 CC||blac...@gmail.com,
   ||josef.mora...@gmail.com,
   ||mag...@libriotech.no,
   ||martin.renvoize@ptfs-europe
   ||.com, r...@rbit.cz
   Priority|P5 - low|P3

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24235] New: /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235

Bug ID: 24235
   Summary: /misc/cronjobs/advance_notices.pl DUEDGST does NOT
send sms, just e-mail
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: blac...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Advanced notices DUEDGST does NOT send sms, just e-mail.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21939] Permission for holds history tab is too strict

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable

--- Comment #9 from Lucas Gass  ---
backported to 19.05.x for 19.05.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21939] Permission for holds history tab is too strict

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24210] Export biblio returns empty file after update

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24210

--- Comment #12 from Katrin Fischer  ---
(In reply to Bohdan from comment #11)
> It appears the problem was in the default framework.
> It did not have item field and biblioitemnumber defined there.
> After I added those export worked.

Thx for the feedback!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set when creating a child patron from the adult

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660

Michael Spagnuolo  changed:

   What|Removed |Added

 CC||mspagnu...@nrhtx.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24234] New: Spacing of availability note in intranet search results unclear

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24234

Bug ID: 24234
   Summary: Spacing of availability note in intranet search
results unclear
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 96233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96233&action=edit
results list

In search results on the Intranet, Koha lists available copies then unavailable
copies, with a note about why they're unavailable. See attached screenshot. The
spacing of this information makes the unavailable note ("1 unavailable:" or "1
on loan:") end up closer to the item above than the item below, giving the
impression that the note applies to the first item rather than the second.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #94504|0   |1
is obsolete||

--- Comment #5 from ByWater Sandboxes  ---
Created attachment 96232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96232&action=edit
Bug 23673: Add "Time status changed" column to patron's notices

This patch adds "Time status changed" column to patron's notices tab. It also
adds logic to C4::Letters to update time_status_changed column when status is
changed, and leaves time_queued with message creation time.

To test:

1. Apply patches.

2. Restart plack.

3. Choose a patron and add a purchase suggestion.

4. Change suggestion status.

5. Open patron's notifications.
CHECK => Messages table has now "Time status changed" and "Time created"
columns, and "Time" column is gone.
SUCCESS => There is a message with status pending, with a "time created" and no
"time status changed"

6. Execute in the shell in Koha directory

   $ ./misc/cronjobs/process_message_queue.pl

7. Open patron's notifications one more time.
SUCCESS => The message changed status. Time created remained the same, and now
"time status changed" has the current timestamp.

8. Resend the message and repeat sep 6.
SUCCESS => Every time you change the status, time created remains the same and
time status changed updates.

9. prove t/db_dependant/Letters.t

10. Sign off

Signed-off-by: Kelly McElligott 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24233] New: Library branches editor doesn't allow email addresses with a name

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24233

Bug ID: 24233
   Summary: Library branches editor doesn't allow email addresses
with a name
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

So, when we send email via koha, we set the from field to just the branch email
address ( e.g. "u...@library.org" ). Some libraries would like to be able to 
have
the library name as part of the email address ( e.g. "Your Library
" ).

The problem is that this does not pass validation in the branches editor. We
know this format works because some libraries set this email format before the
syntax validation was implemented.

We should update the validation algorithm to allow for the latter format in
addition to the former.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24232] New: Deleting a bib record after attaching the last item to another bib

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232

Bug ID: 24232
   Summary: Deleting a bib record after attaching the last item to
another bib
 Change sponsored?: ---
   Product: Koha
   Version: 19.05
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Cataloging
  Assignee: tomasco...@gmail.com
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Bug 15496
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496
Now gives the ability to delete the bib if the item you are attaching to
another bib is the last item on the record.  The code states that the
permission needed is Edit Catalogue, however, when this process is done, the
API is making a call and not getting the right signal (or something). 

Upon working on this, it seems that a librarian would need to have the
Overarching Permission in the Admin module to perform this action.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24046] 'Activate filters' untranslatable

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24046

--- Comment #4 from Maryse Simard  ---
(In reply to Jonathan Druart from comment #2)
> I would suggest to have those strings defined in datatables.inc instead, as
> they are related to dataTable

This makes sense. I amended the patch to move the strings to this file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24046] 'Activate filters' untranslatable

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24046

Maryse Simard  changed:

   What|Removed |Added

  Attachment #95514|0   |1
is obsolete||

--- Comment #3 from Maryse Simard  ---
Created attachment 96231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96231&action=edit
Bug 24046: Untranslatable 'Activate filters'

Bug 9573 moved the code for the table filters activation to it's
own javascript file. The strings contained in this file are not
translatable. This patch moves the strings to the datatables
include file since the filters are related to datatables.

Test plan:
Visit the catalogue/detail.pl and reports/itemslost.pl and test
that the 'Activate/Deactivate filters' option still work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156

Jonathan Druart  changed:

   What|Removed |Added

  Text to go in the||Sponsored-by: Institute of
  release notes||Technology Tallaght

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #96228|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart  
---
Created attachment 96230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96230&action=edit
Bug 24156: Make sort order and number of items to display configurable (basket
page)

This patch is the main patch of this patchset, you will find the
description and the test plan.

The idea of this new enhancement is to add the ability to define the
default sort order and the default number of rows displayed on the
acquisition basket page.
The existing "columns settings" feature was replaced by a
"tables settings" feature. To prepare the ground, there were some
works that were needed:
  * rename variables and files
  * Modify the structure of the yml files
  * Create a new DB table to store the tables settings

Test plan:
0)
  a. Execute the update DB entry to create the new table
  b. Restart all (to get a new version of the yml file, that is cached by
   memcached)
  c. Create several orders for a given basket
1) Go to the basket view page
=> The default values are the same than without this patchset, the
number of entries to display is set to "20" and the table is sorted by
basket number (first column)
2) Go to the "Columns settings" page
3) Unfold the "Acquisition" tab
=> Notice the 2 dropdown lists at the bottom of the basket table
4) Select different values for "Default display length" and "Default
sort order"
5) Refresh the basket view page
=> Notice that the default settings are now effective on the table

QA note: We can decide to replace the different occurrences of "Columns
settings"
by "Tables settings" if needed.

Sponsored-by: Institute of Technology Tallaght

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156

--- Comment #7 from Jonathan Druart  
---
Created attachment 96229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96229&action=edit
Bug 24156: Adjust other tables in the yml file

To match the new structure, we adjust the other tables.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156

--- Comment #5 from Jonathan Druart  
---
Created attachment 96227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96227&action=edit
Bug 24156: Add missing columns to yml

There were 2 columns missing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156

--- Comment #6 from Jonathan Druart  
---
Created attachment 96228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96228&action=edit
Bug 24156: Make sort order and number of items to display configurable (basket
page)

This patch is the main patch of this patchset, you will find the
description and the test plan.

The idea of this new enhancement is to add the ability to define the
default sort order and the default number of rows displayed on the
acquisition basket page.
The existing "columns settings" feature was replaced by a
"tables settings" feature. To prepare the ground, there were some
works that were needed:
  * rename variables and files
  * Modify the structure of the yml files
  * Create a new DB table to store the tables settings

Test plan:
0)
  a. Execute the update DB entry to create the new table
  b. Restart all (to get a new version of the yml file, that is cached by
   memcached)
  c. Create several orders for a given basket
1) Go to the basket view page
=> The default values are the same than without this patchset, the
number of entries to display is set to "20" and the table is sorted by
basket number (first column)
2) Go to the "Columns settings" page
3) Unfold the "Acquisition" tab
=> Notice the 2 dropdown lists at the bottom of the basket table
4) Select different values for "Default display length" and "Default
sort order"
5) Refresh the basket view page
=> Notice that the default settings are now effective on the table

QA note: We can decide to replace the different occurrences of "Columns
settings"
by "Tables settings" if needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156

--- Comment #1 from Jonathan Druart  
---
Created attachment 96223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96223&action=edit
Bug 24156: DB changes

Add a new table tables_settings to store default_display_length and
default_sort_order.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156

--- Comment #2 from Jonathan Druart  
---
Created attachment 96224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96224&action=edit
Bug 24156: DBIC changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156

--- Comment #4 from Jonathan Druart  
---
Created attachment 96226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96226&action=edit
Bug 24156: Add columns_settings.yml changes

Modification of the structure of the yml file.
It was
  table:
- column list
It now becomes
table:
  default_display_length: X
  default_sort_order: Y
  columns:
- column list

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156

--- Comment #3 from Jonathan Druart  
---
Created attachment 96225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96225&action=edit
Bug 24156: move ColumnsSettings to TablesSettings

We are preparing the ground with this patch. As the "Columns settings"
page will now add the ability to modify settings for the whole table, it
makes sense to rename the file and the variables.

Note that the controller script (admin/columns_settings.pl) and the yml
(admin/columns_settings.yml) files have not been moved to not break
shortcuts and abits people could have. But if QA decides, it could be
easy to do.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24210] Export biblio returns empty file after update

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24210

Bohdan  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #11 from Bohdan  ---
It appears the problem was in the default framework.
It did not have item field and biblioitemnumber defined there.
After I added those export worked.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7907] PDF printing of lists

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7907

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23711] Icons on staff main page should be font icons

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23506] Sound material type displays wrong icon in OPAC/Staff details

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23506] Sound material type displays wrong icon in OPAC/Staff details

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable

--- Comment #10 from Lucas Gass  ---
backported to 19.05.x for 19.05.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24203] overduerules.pl does not work with bug 20436

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24203

--- Comment #4 from Katrin Fischer  ---
(In reply to Christopher Brannon from comment #3)
> (In reply to Katrin Fischer from comment #2)
> > Can you explain this with an example maybe?
> 
> Itemtype A could go long overdue after 28 days.
> Itemtype B could go long overdue after 14 days.
> Itemtype C could go long overdue after 7 days.
> 
> How can you set overdue notices to coincide with those overdue times?  You
> can't.  Right now, to cover everything, you would have to set the trigger
> time to be 28 days to accurately cover everything.  Except there would be a
> delay on the notices for the itemtypes that go overdue 7 or 14 days.

Hi Christopher, we don't use the longoverdue process ourselves, I was not aware
that it's used in combination with the overdue notices. This is really
interesting. For our libraries the major concern is that it should be timed
with the creating of fines, which is usually happening in a weekly interval
here. 

I wonder if it could make sense to not tie it overdue notices but to their own
set of notices by itemtype? Both could live on the same configuration page tho.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24231] New: Create classes to the message that was created with sys pref UpdateItemLocationOnCheckin

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24231

Bug ID: 24231
   Summary: Create classes to the message that was created with
sys pref UpdateItemLocationOnCheckin
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

With the introduction of this new system preference
UpdateItemLocationOnCheckin, the cart to shelf system preference was removed
and rolled into this one.  However, the alert that comes along with this new
system preference is not a welcome addition to the libraries that are using
Cart to Shelf functionality.  Prior to this, cart to shelf functionality was a
backend process that would (without staff interaction) take an item that was
checked in, move it to the cart.  Now, when an item is checked in (at the
system preference UpdateItemLocationOnCheckin has the value _ALL: CART - each
time an item is checked in, the staff get a large yellow message box and an
alert.  

If we add a class to this message or even 2 classes this would allow these
alert/audio to be turned off for those libraries that don't wish to receive
this yellow alert box with every checkin.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944

--- Comment #31 from Christopher Brannon  ---
(In reply to Jonathan Druart from comment #30)
> Christopher, could you add your stamp on Kyle's follow-up?

I tested master without the patch, and the hold is routed properly.  Something
has changed.  I don't know if it is Owen's work on the modal, but it seems to
be working properly without the patch.  Can anyone confirm?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24203] overduerules.pl does not work with bug 20436

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24203

--- Comment #3 from Christopher Brannon  ---
(In reply to Katrin Fischer from comment #2)
> Can you explain this with an example maybe?

Itemtype A could go long overdue after 28 days.
Itemtype B could go long overdue after 14 days.
Itemtype C could go long overdue after 7 days.

How can you set overdue notices to coincide with those overdue times?  You
can't.  Right now, to cover everything, you would have to set the trigger time
to be 28 days to accurately cover everything.  Except there would be a delay on
the notices for the itemtypes that go overdue 7 or 14 days.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24049] Limit for Consecutive Hold Requests

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24049

--- Comment #2 from Christopher Brannon  ---
Let's say you place a hold on item A.  You set the preference to not allow
consecutive holds on the same item for 30 days.  You would therefore not be
able to place a hold on item A until 30 days has passed.  This would give other
people a chance to queue up and prevent you from constantly keeping the item on
hold.  It would also give the item a chance to sit on the shelf for people to
see.

This is definitely different than the daily hold limit.  That just limits the
holds in general.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24215] Warnings about guarantor relationships show ARRAY errors

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #4 from Jonathan Druart  
---
Confirmed.
To recreate:
Do nothing, go to about.pl.
You see: https://snipboard.io/83ID0r.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11353] Searches with QueryParser activated are broken if an Uppercase is used in the index name

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11353

Jonathan Druart  changed:

   What|Removed |Added

   Severity|major   |normal
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
IIRC QueryParser was not finished/polished and usable in production, lowering
severity.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24097] Don't show claims tab in patron account, when there are no claims

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24097

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #17 from Jonathan Druart  
---
(In reply to Martin Renvoize from comment #16)
> I've attempted a rebase of the patch.. it's not an area I'm all that
> familiar with so testing is required.

Reading previous comments it seems that this patch will introduce regressions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

Jonathan Druart  changed:

   What|Removed |Added

  Component|Searching   |Searching - Zebra
 QA Contact|testo...@bugs.koha-communit |
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23391] Hide finished ILL requests

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391

--- Comment #3 from Magnus Enger  ---
One point that should be considered: I take the string from the syspref and try
to clean it up a bit with this syspref:

$hidden_statuses_string =~ s/[^0-9A-Za-z_|]//g;

This means that status code will only be able to contain numbers, lower and
upper ascii letters and underscore. This is perhaps too strict?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23391] Hide finished ILL requests

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391

--- Comment #2 from Magnus Enger  ---
Created attachment 96222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96222&action=edit
Bug 23391 - Hide finished ILL requests

Currently, the main table of ILL requests will display all ILL
requests in the database, regardless of their status. For libraries
with active ILL this quickly leads to a lot of requests being displayed,
and the main page of the ILL module taking a long time to load. This
patch proposes to fix this by introducing the ILLHiddenRequestStatuses
syspref, which can take a pipe-separated list of ILL statuses that
will be hidden from view in the ILL module. This means that the
only way to find a hidden request will be through a report.

To test:
- Apply the patch and make sure the atomic database update is run
- Make sure you have a few ILL requests, with at least two different
  statuses
- Check that all requests are still displayed in the main table of
  ILL requests
- Add one of the statuses* you have in your database to the
  ILLHiddenRequestStatuses syspref, reload the ILL module frontpage
  and verify that requests with the given status are not displayed
- Change the syspref to another status and verify requests with
  that status are now hidden
- Change the syspref to hold both statuses, separated by the pipe
  symbol (e.g.: A|B). Verify that no requests with the given
  statuses are now displayed
- Run the ILL REST API tests, e.g.:
  $ sudo koha-shell -c "prove t/db_dependent/api/v1/illrequests.t" kohadev

* = The ILLHiddenRequestStatuses syspref should hold status codes, like
"REQ" and "NEW", not their human readable counterparts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23391] Hide finished ILL requests

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391

Magnus Enger  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents linking to correct records

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094

--- Comment #2 from Donna  ---
(In reply to Myka Kennedy Stephens from comment #1)
> Donna,
> Would you clarify which search engine you have enabled when you're seeing
> this behavior? I am doing some extensive testing with authorities on
> Elasticsearch and am not seeing this problem with the linker. I also have
> broader_headings enabled under LinkerOptions.
> My experience is that the linker is correctly matching x00 headings with a
> relator term present *only* when the x00 heading has only $a and $e present.
> For headings that also include dates ($d) or any other subfields, the linker
> will not find a match. I'm thinking this is a different bug and will be
> submitting it after I do some more tests.

This is on Zebra, Myka.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24164] Patron emailer cronjob is not generating unique content for notices

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164

--- Comment #8 from Jonathan Druart  
---
Created attachment 96221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96221&action=edit
Bug 24164: Copy the letter for each email

To test:
1 - Set or have two patrons with emails - note thier borrowernumber for the
report
2 - Create a report - note the report id ($REPORT_ID)
SELECT borrowernumber, surname, firstname, email FROM borrowers WHERE
borrowernumber IN (##,##);
3 - Create a notice in circulation with code TESTEMAIL
4 - The content should be "[% surname %]"
5 - perl misc/cronjobs/patron_emailer.pl --report $REPORT_ID --notice TESTEMAIL
--module circulation --from any...@anywhere.com --verbose
6 - Note that the emails both have the same surname
7 - Apply patch
8 - Repeat 5
9 - Emails now have correct content

Signed-off-by: Kelly McElligott 

Signed-off-by: Jessica Zairo 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24164] Patron emailer cronjob is not generating unique content for notices

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #95982|0   |1
is obsolete||
  Attachment #96211|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  
---
Created attachment 96220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96220&action=edit
Bug 24164: Unit test

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24164] Patron emailer cronjob is not generating unique content for notices

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24097] Don't show claims tab in patron account, when there are no claims

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24097

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||24164


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164
[Bug 24164] Patron emailer cronjob is not generating unique content for notices
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24164] Patron emailer cronjob is not generating unique content for notices

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||16149
 QA Contact|testo...@bugs.koha-communit |jonathan.dru...@bugs.koha-c
   |y.org   |ommunity.org
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149
[Bug 16149] Generate and send custom notices based on report output
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24097] Don't show claims tab in patron account, when there are no claims

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24097

Owen Leonard  changed:

   What|Removed |Added

 Depends on||14697


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697
[Bug 14697] Extend and enhance "Claims returned" lost status
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697

Owen Leonard  changed:

   What|Removed |Added

 Blocks||24097


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24097
[Bug 24097] Don't show claims tab in patron account, when there are no claims
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22880] Convert opacheader system preference to news block

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880

--- Comment #28 from Owen Leonard  ---
Created attachment 96219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96219&action=edit
Bug 22880: (follow-up) Process all installed languages, not just enabled

This patch changes the database update so that the system preference is
copied to news items in all installed languages, not just those enabled
in the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24230] intranet_js plugin hook is after body

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24230

Fridolin SOMERS  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |fridolin.som...@biblibre.co
   ||m
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684

--- Comment #9 from Jonathan Druart  
---
I think we should follow this path.
If you all agree I will provide a follow-up to fix the different calls.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #81317|0   |1
is obsolete||
  Attachment #81318|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart  
---
Created attachment 96218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96218&action=edit
Bug 21684: Fix delete methods and add more tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23391] Hide finished ILL requests

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391

Magnus Enger  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |mag...@libriotech.no
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24230] New: intranet_js plugin hook is after body

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24230

Bug ID: 24230
   Summary: intranet_js plugin hook is after body
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

The plugin hook intranet_js is after body tag in intranet-bottom.inc :

[% KohaPlugins.get_plugins_intranet_js | $raw %]


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23953] Cancelling hold does not work if checkout not completed

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23953

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17798] Checking out an item on hold for another patron prints a slip but does not update hold

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24229] /items API tests fail on Ubuntu 18.04

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24229

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||16825
   Assignee|ch...@bigballofwax.co.nz|tomasco...@gmail.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825
[Bug 16825] Add API route for getting an item
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23243] Allow filtering out of historic subscription expirations in the check expiration of serials page

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] Add API route for getting an item

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||24229


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24229
[Bug 24229] /items API tests fail on Ubuntu 18.04
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24229] New: /items API tests fail on Ubuntu 18.04

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24229

Bug ID: 24229
   Summary: /items API tests fail on Ubuntu 18.04
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Tests fail in a weird way:

kohadev-koha@7369d4443675:/kohadevbox/koha$ prove t/db_dependent/api/v1/items.t
t/db_dependent/api/v1/items.t .. # Inactivity timeout

#   Failed test 'GET
//RTrSH14TLmPlTAsO1RAR9x8MhJtMO7XJS5IKOwBKfwcFnpzHSGSEPM7k:thePassword123@/api/v1/items'
#   at t/db_dependent/api/v1/items.t line 75.

#   Failed test 'SWAGGER3.2.2'
#   at t/db_dependent/api/v1/items.t line 75.
#  got: undef
# expected: '200'
# Looks like you planned 12 tests but ran 5.
# Looks like you failed 2 tests of 5 run.
t/db_dependent/api/v1/items.t .. 1/2
#   Failed test 'list() tests'
#   at t/db_dependent/api/v1/items.t line 95.
Can't use an undefined value as an ARRAY reference at
t/db_dependent/api/v1/items.t line 79.
# Looks like your test exited with 255 just after 1.
t/db_dependent/api/v1/items.t .. Dubious, test returned 255 (wstat 65280,
0xff00)
Failed 2/2 subtests

It happens almost randomly (I reproduced the first time I started
koha-testing-docker with the master-bionic image, but then it wouldn't
reproduce).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22880] Convert opacheader system preference to news block

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880

--- Comment #27 from Owen Leonard  ---
(In reply to Marcel de Rooy from comment #26)

> Could we have similar problems when a language is disabled on the system at
> a certain point (while having news items connected to it)?

The news interface offers the ability to add items in any translation which is
present, not just enabled. So in order for the problem to repeat I think you'd
have to:

1. Delete a translation without disabling it in the OPAC first.
2. Run this database update.
3. Try to edit a news item in the previously-enabled language.

There is also the disconnect between languages enabled in the staff client and
those enabled in the OPAC. It sounds like the db update should try to take into
account installed languages rather than enabled languages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15522] New interface for revamped circulation rules

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

--- Comment #42 from Martin Renvoize  ---
This all scans well, if you get a chance it would be great to have a final
SO/QA by January as it's one I'm targetting for an early push.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com,
   ||k...@bywatersolutions.com,
   ||lari.task...@hypernova.fi,
   ||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936

--- Comment #90 from Martin Renvoize  ---
This all scans well, if you get a chance it would be great to have a final
SO/QA by January as it's one I'm targetting for an early push.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24228] New: Add a parameter to recursively embed objects in Koha::Object(s)->to_api

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228

Bug ID: 24228
   Summary: Add a parameter to recursively embed objects in
Koha::Object(s)->to_api
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Using a syntax similar to MongoDB's dot notation, we need a way to specify
which relations should be followed for recursively embedding objects. For
example:

$patron->to_api({ embed => { checkouts => { 'pickup_location' => 1 }, credits
=> 1 } })

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||23843


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843
[Bug 23843] Make existing endpoints use Koha::Object(s)->to_api
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||24228


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228
[Bug 24228] Add a parameter to recursively embed objects in
Koha::Object(s)->to_api
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091

--- Comment #4 from Martin Renvoize  ---
Created attachment 96217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96217&action=edit
Bug 23091: Work In Progress

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24212] OPAC send list dialog opens too small in IE

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24212

Owen Leonard  changed:

   What|Removed |Added

  Attachment #96212|0   |1
is obsolete||

--- Comment #5 from Owen Leonard  ---
Created attachment 96216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96216&action=edit
Bug 24212: Increase size of OPAC 'send list' dialog box for IE

To test:
1) Create a list and view it in the OPAC (ensure you are using Internet
Explorer as a browser)
2) Click Send list
3) Notice the dialog box cuts off the content in the window
4) Close the popup, apply the patch
5) Click Send list again
6) Confirm the dialog box shows the entire window
7) Confirm the box is resizable and has scrollbars

Sponsored-by: Toi Ohomai Institute of Technology

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24212] OPAC send list dialog opens too small in IE

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24212

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132

--- Comment #42 from Kelly McElligott  ---
Let me test again, using the back button did not save my barcodes in the Batch
Item Deletion tool.  I will attempt this again.

I understand what you mean with the non-triggered holds and agree that this
would be different than other Koha procedures.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24227] New: System Preference: EmailPurchaseSuggestion missing from the 19.05 manual

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24227

Bug ID: 24227
   Summary: System Preference: EmailPurchaseSuggestion missing
from the 19.05 manual
 Change sponsored?: ---
   Product: Koha
   Version: 19.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Documentation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

The system preference, EmailPurchaseSuggestion is missing from the 19.05 (and
19.11) manual.

Here is the information needed for this system preference
There are two new system preferences that work together on this new feature:

EmailPurchaseSuggestions &EmailAddressForSuggestions

There are a few options for the first system preference,
EmailPurchaseSuggestion. The email can be sent:

-None

-Email Address of Branch (found in the Libraries section of Admin)

-Email address for Suggestions - which if chosen, then the next system
preference will be used

-Koha Admin Email Address- which is an email in the system preference,
KohaAdminEmail.

If a library would like to use an email separate from either the Email Address
of the Branch ore the Koha Admin Email Address, then the next system
preference, EmailAddressforSuggestions, should be filled in.

If a library does not want to be emailed when a purchase suggestion has been
made, a library would choose None (which will be set as the default on an
upgrade).

There is a new notice that is called New_Suggestion for this email.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8959] Self checkout timeout is JavaScript-dependent

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8959

Martin Renvoize  changed:

   What|Removed |Added

   Severity|major   |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008

--- Comment #6 from Martin Renvoize  ---
I think it's clearer as a positive amount personally.. it's a 'credit' so it's
already identified as such in the sentence rather than needing to state the
sign.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19876] Koha::Account->pay() does not exit specific fine loop when balance is used up

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876

--- Comment #5 from Tomás Cohen Arazi  ---
In the described case, the API for adding credits against a list of debit lines
could be used, and it wouldn't suffer from this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19876] Koha::Account->pay() does not exit specific fine loop when balance is used up

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876

--- Comment #4 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #3)
> Hi Tomas, do you plan to work on this one?

Not in a short term. Ask Martin, as he was working on replacement methods.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #6 from Jonathan Druart  
---
(In reply to j.kylmala from comment #5)
> (In reply to Lucio Moraes from comment #4)
> > Hi Joonas,
> > if you have a staged file to test, could you share with me?
> > Thank you
> 
> Unfortunately I don't have one. And now I'm thinking if the patch I supplied
> here is obsolete because this might only apply for the
> https://github.com/KohaSuomi/kohasuomi version of Koha. I'll change the
> status to "In Discussion" for now.

Does it mean the original issue you reported is not valid for the community
version?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12452] Check subscription expiration doesn't work

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12452

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #5 from Jonathan Druart  
---
I do not understand this bug report so I am suggesting to move to the new bug
23243. It would be helpful to get the patch tested there.

*** This bug has been marked as a duplicate of bug 23243 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23243] Allow filtering out of historic subscription expirations in the check expiration of serials page

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243

Jonathan Druart  changed:

   What|Removed |Added

 CC||k...@univ-lyon3.fr

--- Comment #6 from Jonathan Druart  
---
*** Bug 12452 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23243] Allow filtering out of historic subscription expirations in the check expiration of serials page

2019-12-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243

--- Comment #5 from Jonathan Druart  
---
Created attachment 96215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96215&action=edit
Bug 23243: Adjust previous patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >