[Koha-bugs] [Bug 13326] Add possibilty to edit purchase suggestion on opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13326 Vinod changed: What|Removed |Added CC||mishrav...@gmail.com --- Comment #3 from Vinod --- Hi, The provision can be made in this way A system preference in OPAC with following option to choose/activate can be made 1. Users can edit/delete purchase suggestion at any stage 2. Users can edit/delete purchase suggestion before approval/ordered only A message should populate on OPAC if option two is selected by librarian " you can't edit/delete purchase suggestion" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24304] Incomplete returns (notes)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24304 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com --- Comment #1 from Lisette Scheer --- This would be very helpful for us as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24308] Suggestions table on suggestions.pl should have separate columns for dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24308 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228
--- Comment #9 from Agustín Moyano ---
Created attachment 96646
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96646&action=edit
Bug 24228: (follow-up) Check wether each child or children can('to_api') and
throw exception otherwise
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228
--- Comment #8 from Agustín Moyano ---
Created attachment 96645
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96645&action=edit
Bug 24228: Make ->to_api params a hashref
This patch makes the parameters for Koha::Object(s)->to_api a hashref
preparing the ground for new parameters. The proposed syntax is:
$object->to_api(
{
embed => {
'items' => {
'children' => {
'homebranch' => {}
}
}
}
}
);
Tests are added for the Koha::Objects implementation and tests for
Koha::Object are adjusted to the new syntax, and a test for the single
result accessor is added as well.
To test:
1. Apply this patches
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Object.t t/db_dependent/Koha/Objects.t
=> SUCCESS: Tests pass!
3. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Agustin Moyano
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228 Agustín Moyano changed: What|Removed |Added Attachment #96612|0 |1 is obsolete|| Attachment #96622|0 |1 is obsolete|| --- Comment #7 from Agustín Moyano --- Created attachment 96644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96644&action=edit Bug 24228: Add parameters to Koha::Object(s)->to_api to automatically embed objects This patch makes Koha::Object(s)->to_api have an 'embeds' parameter that using dot notation (e.g. resource.related_resource.another_one) allows embedding objects recursively. To test: 1. Apply this patch 2. prove t/db_dependent/Koha/Object.t Signed-off-by: Tomas Cohen Arazi Signed-off-by: Agustin Moyano -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24302] Add a way to specify nested objects to embed in OpenAPI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24302 Agustín Moyano changed: What|Removed |Added Blocks||20936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 [Bug 20936] Holds History for patrons in OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228 Agustín Moyano changed: What|Removed |Added Blocks|20936 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 [Bug 20936] Holds History for patrons in OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Agustín Moyano changed: What|Removed |Added Depends on|24228 |24302 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228 [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24302 [Bug 24302] Add a way to specify nested objects to embed in OpenAPI -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #15 from Agustín Moyano --- Created attachment 96643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96643&action=edit Bug 23673: (follow-up) Change time_status_changed to updated_on -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Agustín Moyano changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #14 from Agustín Moyano --- Hi Jonathan > 1. Should not we have the new column with the "default CURRENT_TIMESTAMP on > update CURRENT_TIMESTAMP" clause in order to delegate the update of this > value to the DBMS? Mysql doesn't accept a table with 2 columns with "default CURRENT_TIMESTAMP".. there can be only one. > 2. I think we almost agreed on a pattern for the timestamp/datetime columns > (there is nothing in the coding guidelines however), to name them suffixed > by _on > time_status_changed would be updated_on Ok, I didn't know about that rule.. I'll change that name in follow up. Regards. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24311] New: aqbasket.booksellerinvoicenumber is not used and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24311 Bug ID: 24311 Summary: aqbasket.booksellerinvoicenumber is not used and should be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org This field used to contain the invoice information. But it was moved to a separate table (aqinvoices) and the remainding occurrences in the codebase seem to translate it from the templates into a query on aqinvoices. i.e.: C4::Acquisitions:2464 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24310] New: Use Text::Lorem instead of String::Random in Test::Builder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24310 Bug ID: 24310 Summary: Use Text::Lorem instead of String::Random in Test::Builder Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org That would help to get something more readable. Currently we generate a string of one word that is the size of the column. It produces a lot of overflow when displayed on the screen. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24308] Suggestions table on suggestions.pl should have separate columns for dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24308 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24308] Suggestions table on suggestions.pl should have separate columns for dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24308 --- Comment #1 from Lucas Gass --- Created attachment 96642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96642&action=edit Bug 24308: Suggestions table on suggestions.pl should have separate columns for dates This patch sepearetes the "Suggested by - on" and "Managed by - on" columns into sepearte columns for the names and dates for better sortability. It adds a data-order class to the so it will sort the dates correctly.$ TEST PLAN: 1. Have multiple suggestions with multiple dates. Make sure some are Pending, Accepted, Checked, Rejected, Available, and Ordered 2. Notice the 'Suggested by - on' and 'Managed by - on' are a single column and you cannot sort by date. 3. Apply patch 4. The tables should now have seprate columns "Suggested on" and "Managed on" that are sortable by date. 5. Make sure you can sort in the "Pending", "Accepted", and "Rejected" columns. 6. Sign off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24280] Claims Returned items give erroneous refund message on return
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24280 Andrew Fuerste-Henry changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Andrew Fuerste-Henry --- *** This bug has been marked as a duplicate of bug 19508 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19508] When returning a lost item, Koha claim to have applied a refund when it has not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19508 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- *** Bug 24280 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24309] New: Holds on multiple in the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24309 Bug ID: 24309 Summary: Holds on multiple in the same record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Currently there is no way to place simultaneous holds on multiple records in the same record. It would be great if there were a batch feature that would allow you to place holds on multiple items, whether in the same record or not, with the option to specify identical or individual settings (notes, dates, etc) on the items in the batch. Basically, there needs to be something similar to batch item modification, where you can specify a list of barcodes, and the items will load, and you can specify global settings on the holds, or if you fill in something on a specific item, it will not take the global setting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24308] New: Suggestions table on suggestions.pl should have separate columns for dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24308 Bug ID: 24308 Summary: Suggestions table on suggestions.pl should have separate columns for dates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com On the suggestions management page the table has a column called "Suggested by - on". Some librarians would like to be able to sort by both patron name and suggestion date and they currently cannot since it is a single column. This should be 2 columns. The same is true for the "Managed by - on" column. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24307] New: Allow loose item matching for on-order items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24307 Bug ID: 24307 Summary: Allow loose item matching for on-order items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl We run into this issue with libraries who are not using EDI, get their items pre-processed by a vendor, and want on-order items to show in the catalog: - MARC records are imported for on-order titles - On-order items are created - Vendor sends final MARC records including 952 tags with barcode, ccode, location, etc - Final records match to existing records at the bib level, but cannot match at the item level - Item records need to be manually touched either to add final details to on-order items or to delete on-order items in favor of newly-created final items The vendor cannot give a barcode number when supplying on-order records and (without EDI) Koha doesn't have a way to send the on-order item numbers to the vendor to be included in the final item info. I'm imagining something like a syspref that lets us say "if an item has notforloan of [X], then allow item overlay without matching an itemnumber or barcode." But as I type that I suspect there are a lot of ways it could go bad. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #90 from Bernardo Gonzalez Kriegel --- (In reply to Bernardo Gonzalez Kriegel from comment #89) > (In reply to Jonathan Druart from comment #88) > > 1. Who is the original author of this patch? Bernardo? Regarding the history > > I do not think so. > I just signed, ~2015 first time, and now. All these people, from InLibro, seems to have worked on this bug Maxime Pelletier simith.doliveira@inlibro Rémi Mayrand-Provencher Mehdi Hamidi Philippe Audet-Fortin Charles Farmer Pierre-Marc Thibault Maryse Simard Arthur Bousquet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23838] Add ability to view item renew history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-c
||ommunity.org
--- Comment #33 from Jonathan Druart
---
+$('#patronRenewals #incomplete').append(note + ': ' +
data.length + ' ' + out_of + ' ' + renewals + ' ' + renewals_logged).show();
To make this correctly translatable you should use the .format() JS function.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228 Tomás Cohen Arazi changed: What|Removed |Added Blocks|18731 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 [Bug 18731] Add routes for acquisition orders -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18731] Add routes for acquisition orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi changed: What|Removed |Added Depends on|24228 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228 [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24302] Add a way to specify nested objects to embed in OpenAPI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24302 Tomás Cohen Arazi changed: What|Removed |Added CC||agustinmoy...@theke.io, ||oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228 Tomás Cohen Arazi changed: What|Removed |Added CC||oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |Failed QA --- Comment #13 from Jonathan Druart --- A couple of small things: 1. Should not we have the new column with the "default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP" clause in order to delegate the update of this value to the DBMS? 2. I think we almost agreed on a pattern for the timestamp/datetime columns (there is nothing in the coding guidelines however), to name them suffixed by _on time_status_changed would be updated_on I know that it's not exactly what the patch does, but in practice it will be the same I think. Once queued, we only update their status afaik. Marked as Failed QA but could be considered as "In discussion" if you disagree or if I missed something. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #45 from Jonathan Druart
---
Comment on attachment 95566
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95566
Bug 23112: Add circulation to ILL requests
Review of attachment 95566:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23112&attachment=95566)
-
Also, I think you should use patron-title.inc to display patron's info.
::: Koha/Illrequest.pm
@@ +1211,5 @@
> +# For some reason, AddIssue requires an unblessed Patron
> +$issue_args[0] = $patron->unblessed;
> +my $issue = C4::Circulation::AddIssue(@issue_args);
> +
> +if ($issue && %{$issue}) {
AddIssue return a Koha::Checkout object. The test will work but I think it's
confusing.
::: koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
@@ +704,4 @@
>
> [% INCLUDE 'ill-list-table-strings.inc' %]
> [% Asset.js("js/ill-list-table.js") | $raw %]
> +[% Asset.js("js/ill-check-out.js") | $raw %]
Where does this file come from?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22838] Warning from runreport.pl 'Explicitly setting a MIME header field (content-type) is dangerous'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22838 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #4 from Jonathan Druart --- (In reply to Jonathan Druart from comment #3) > Created attachment 96641 [details] [review] > Bug 22838: Specify a content-type for other formats What about this patch? Should not we set content-type for other formats as well? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22838] Warning from runreport.pl 'Explicitly setting a MIME header field (content-type) is dangerous'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22838 --- Comment #3 from Jonathan Druart --- Created attachment 96641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96641&action=edit Bug 22838: Specify a content-type for other formats -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24302] Add a way to specify nested objects to embed in OpenAPI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24302 Tomás Cohen Arazi changed: What|Removed |Added Attachment #96639|0 |1 is obsolete|| --- Comment #4 from Tomás Cohen Arazi --- Created attachment 96640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96640&action=edit Bug 24302: Add a way to specify nested objects to embed in OpenAPI This patch introduces a helper for handling x-koha-embed headers on API requests. It reads the embed definitions and adds them to the stash for later use (either manually on the controllers, or in the objects.search helper. x-koha-embed needs to be defined as a list on the OpenAPI spec. It throws an exception when invalid combinations are found. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3.Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24302] Add a way to specify nested objects to embed in OpenAPI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24302 Tomás Cohen Arazi changed: What|Removed |Added Attachment #96624|0 |1 is obsolete|| --- Comment #3 from Tomás Cohen Arazi --- Created attachment 96639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96639&action=edit Bug 24302: Add a way to specify nested objects to embed in OpenAPI This patch introduces a helper for handling x-koha-embed headers on API requests. It reads the embed definitions and adds them to the stash for later use (either manually on the controllers, or in the objects.search helper. x-koha-embed needs to be defined as a list on the OpenAPI spec. It throws an exception when invalid combinations are found. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3.Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24302] Add a way to specify nested objects to embed in OpenAPI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24302 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959 Jonathan Druart changed: What|Removed |Added QA Contact|katrin.fisc...@bsz-bw.de|jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23873 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23873] Allow marc modification templates to use capturing groups in substitutions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23873 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21959 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959 Jonathan Druart changed: What|Removed |Added Attachment #95432|0 |1 is obsolete|| Attachment #95433|0 |1 is obsolete|| Attachment #95434|0 |1 is obsolete|| --- Comment #27 from Jonathan Druart --- Created attachment 96636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96636&action=edit Bug 21959: Batch item modification - ability to apply regular expression on text fields Test plan: - go to Tools > Batch item modification, - select items to modify, - for one or some text fields, check the second checkbox (Use regular expression) and type your regex, - check the regex has been applied. Signed-off-by: Pierre-Marc Thibault Signed-off-by: Mathilde Formery Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959 --- Comment #29 from Jonathan Druart --- Created attachment 96638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96638&action=edit Bug 21959: allow only i and g regex modifiers Signed-off-by: Mathilde Formery Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959 --- Comment #28 from Jonathan Druart --- Created attachment 96637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96637&action=edit Bug 21959: use a link instead of a checkbox Signed-off-by: Mathilde Formery Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24302] Add a way to specify nested objects to embed in OpenAPI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24302 Tomás Cohen Arazi changed: What|Removed |Added Blocks||18731 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 [Bug 18731] Add routes for acquisition orders -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18731] Add routes for acquisition orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi changed: What|Removed |Added Depends on||24302 Status|Needs Signoff |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24302 [Bug 24302] Add a way to specify nested objects to embed in OpenAPI -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Assignee|gmcha...@gmail.com |n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24302] Add a way to specify nested objects to embed in OpenAPI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24302 Tomás Cohen Arazi changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||josef.mora...@gmail.com, ||k...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com Assignee|agustinmoy...@theke.io |tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #64 from Jonathan Druart --- Created attachment 96635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96635&action=edit Bug 7882: (follow-up) Only show sortable icon for sortable tags Only tags which can be repeated can be sorted, so the "bars" icon should not display by these tags. Signed-off-by: Maryse Simard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #63 from Jonathan Druart --- Created attachment 96634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96634&action=edit Bug 7882: (follow-up) Update sorting interaction This follow-up modifies the CSS for the sortable fields so that a different icon is used. Elsewhere in Koha (stock rotation stage sorting) we use the "bars" icon to indicate a sortable element. I think it would be good to continue to use this. The cursor is now styled as a "Move" cursor. The configuration of the sortable function in the script has been updated in two ways: 1. The movement of the element is constrained along the y-axis, and 2. The movement of the element is contstrained to the container within which it can be moved (for the tag, the tab, and for the subfield, the tag). To test, apply the patch and edit a MARC record in the basic cataloging editor. Confirm that the new icon is used, and that the "Move" cursor shows when you hover over the icon. Confirm that a tag can be dragged up and down within the constraints of the visible section. A subfield should be only movable within its parent tag. Signed-off-by: Maryse Simard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Jonathan Druart changed: What|Removed |Added Attachment #96344|0 |1 is obsolete|| Attachment #96541|0 |1 is obsolete|| Attachment #96542|0 |1 is obsolete|| --- Comment #62 from Jonathan Druart --- Created attachment 96633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96633&action=edit Bug 7882: Add ability to move and reorder fields in MARC editor Use jQueryUI sortable to make fields and subfields moveable in the MARC editor for both records and authorities. This patch convert items from div's to ul's and consequently alter css and js to match. It also replace the up arrow with a more adapted icon (from font awesome). Primary authorship by Elliott Davis. To Test: 1. Add or edit a record in cataloguing module. 2. You should be able to move the fields and subfields around. - You can click on any part of the element to drag it, the move icon to the left of the item is a good place to do it. => You can only change the order of fields of the same tag. 3. Make sure all of the javascript driven fonctionnality still work : - Duplicate fields/subfields - Remove fields/subfields - Using the tag editor for control fields or to link authorities - etc 4. Reorder some fields/subfields and save the record. 5. Edit the record again. 6. The order in the editor should match the changes which were saved. - Empty subfields should appear after the ones with content. 7. Repeat steps 1-6 with the authority editor. Signed-off-by: Séverine QUEUNE Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24289] Deleting branch will not delete entry in special holidays
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24289 --- Comment #3 from Jonathan Druart --- Created attachment 96632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96632&action=edit Bug 24289: Make sure sample_holidays will load after sample_libraries They are inserted depending on their alpha order, and sample_holidays will fail because of missing branchcode. This patch suggests a simple fix: rename sample_holidays to sample_libraries_holidays, to make sure it will be loaded after sample_libraries Test plan: Start a fresh installation and select all sample data -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24289] Deleting branch will not delete entry in special holidays
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24289 --- Comment #2 from Jonathan Druart --- Created attachment 96631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96631&action=edit Bug 24289: DBIC changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24289] Deleting branch will not delete entry in special holidays
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24289 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24289] Deleting branch will not delete entry in special holidays
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24289 --- Comment #1 from Jonathan Druart --- Created attachment 96630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96630&action=edit Bug 24289: Add foreign keys on *_holidays.branchcode tables Those are missing foreign keys, it will also clean the holidays tables and automatically remove the holidays when a library is removed. Test plan: 0. Do not apply this patch 1. Create a new library 2. Create special and repeatable holiday for this library 3. Remove the library => Notice that the holidays still exist in DB 4. Apply this patch 5. Execute the update database entry => Notice that the holidays for this library have been removed from the DB 6. Repeat 1-3 => Notice that the holidays have been removed along with the library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5334] Omnibus: Add explicit foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Jonathan Druart changed: What|Removed |Added Depends on||24289 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24289 [Bug 24289] Deleting branch will not delete entry in special holidays -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24289] Deleting branch will not delete entry in special holidays
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24289 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24289] Deleting branch will not delete entry in special holidays
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24289 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Blocks||5334 Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] Omnibus: Add explicit foreign key constraints -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24305] Batch Item modification via item number in reports does not work with CONCAT in report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305 Jonathan Druart changed: What|Removed |Added Depends on||19233 CC||jonathan.dru...@bugs.koha-c ||ommunity.org Version|19.05 |master Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 [Bug 19233] Add ability to send itemnumbers in report results to batch modification -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19233] Add ability to send itemnumbers in report results to batch modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Jonathan Druart changed: What|Removed |Added Blocks||24305 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305 [Bug 24305] Batch Item modification via item number in reports does not work with CONCAT in report -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24305] Batch Item modification via item number in reports does not work with CONCAT in report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24305] Batch Item modification via item number in reports does not work with CONCAT in report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305
--- Comment #1 from Jonathan Druart
---
Created attachment 96629
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96629&action=edit
Bug 24305: Fix links to batch tools when report's columns do not contain
integers
If report's columns do not only contain integers, we should not point to
batch tools.
For instance, if the value is a link, the batch tools will not work as
they will not retrieve the id (itemnnumber or biblionumber) properly
Test plan:
Create a report like:
SELECT CONCAT('', itemnumber,
'' ) AS itemnumber
FROM items
LIMIT 10;
Execute it
=> There is not link to the batch tools
Edit the report like:
SELECT itemnumber
FROM items
LIMIT 10;
Execute it
=> There is a link to the batch tools
Edit the report like
SELECT itemnumber, CONCAT('', itemnumber,
'' ) AS itemnumber
FROM items
LIMIT 10;
Execute it
=> There is link to the batch tools
Try other combinations with biblionumber.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #89 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #88) > 1. Who is the original author of this patch? Bernardo? Regarding the history > I do not think so. I just signed, ~2015 first time, and now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #88 from Jonathan Druart --- I am quite ok with this patch, just a couple of things: 1. Who is the original author of this patch? Bernardo? Regarding the history I do not think so. 2. Not blocker but, when a code is not nice, better refactore and improve it than duplicate it ;) I am referring to the JS code to test if a mandatory field is filled, it would have been easier to make the function accepts an argument to check for mandatories or importants. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment #87 from Jonathan Druart
---
(In reply to Jonathan Druart from comment #86)
> Does not work for me:
>
> Can't use an undefined value as an ARRAY reference at
> /usr/lib/x86_64-linux-gnu/perl5/5.24/DBI.pm line 2088
> DBD::_::st::fetchall_arrayref('DBI::st=HASH(0x5570f6dbc278)',
> 'HASH(0x5570f6dbc440)', undef) called at
> /kohadevbox/koha/admin/marctagstructure.pl line 330
>
> CGI::Compile::ROOT::kohadevbox_koha_admin_marctagstructure_2epl::
> StringSearch(0, 'ACQ') called at /kohadevbox/koha/admin/marctagstructure.pl
> line 284
> eval {...} at /kohadevbox/koha/admin/marctagstructure.pl line 349
Sorry, I forgot the new DB column!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #86 from Jonathan Druart
---
Does not work for me:
Can't use an undefined value as an ARRAY reference at
/usr/lib/x86_64-linux-gnu/perl5/5.24/DBI.pm line 2088
DBD::_::st::fetchall_arrayref('DBI::st=HASH(0x5570f6dbc278)',
'HASH(0x5570f6dbc440)', undef) called at
/kohadevbox/koha/admin/marctagstructure.pl line 330
CGI::Compile::ROOT::kohadevbox_koha_admin_marctagstructure_2epl::StringSearch(0,
'ACQ') called at /kohadevbox/koha/admin/marctagstructure.pl line 284
eval {...} at /kohadevbox/koha/admin/marctagstructure.pl line 349
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
