[Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Katrin Fischer changed: What|Removed |Added Blocks||24479 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479 [Bug 24479] New POS doesn't follow CurrencyFormat -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24479] New: New POS doesn't follow CurrencyFormat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479 Bug ID: 24479 Summary: New POS doesn't follow CurrencyFormat Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Depends on: 23354 There is some hardcoded stuff in the new POS feature that is wrong when another CurrencyFormat tha US is used: The change to give is 0.00. 0.00 This needs a thorough check and fix. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Katrin Fischer changed: What|Removed |Added Blocks||24478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478 [Bug 24478] Make it possible to deactivate point of sale -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24478] New: Make it possible to deactivate point of sale
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478 Bug ID: 24478 Summary: Make it possible to deactivate point of sale Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Depends on: 23354 It would be nice if the new POS module could be deactivated for libraries not using it. A common demand from smaller libraries is to hide all functionality they don't use to make things less confusing and less error prone. As the new POS feature shows up as a new module on the start page it's prominently placed and it would be nice if there was a pref to turn off this functionality separate from fines permissions. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Katrin Fischer changed: What|Removed |Added Blocks||24477 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477 [Bug 24477] No permissions check for POS feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24477] No permissions check for POS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477 Katrin Fischer changed: What|Removed |Added Depends on||23354 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24477] New: No permissions check for POS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477
Bug ID: 24477
Summary: No permissions check for POS feature
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: critical
Priority: P5 - low
Component: Fines and fees
Assignee: koha-bugs@lists.koha-community.org
Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
At the moment it appears that POS can be used without any permission - This
means a patron with no permissions can access the page!
my ( $template, $loggedinuser, $cookie, $user_flags ) = get_template_and_user(
{
template_name => 'pos/pay.tt',
query => $q,
type=> 'intranet',
authnotrequired => 0,
}
);
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24452] Advanced editor - show multiple spaces visually
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24452 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer --- Note: With the helpers on 00x deactivated it will also show the wanted whitespace there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24452] Advanced editor - show multiple spaces visually
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24452 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24452] Advanced editor - show multiple spaces visually
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24452 Katrin Fischer changed: What|Removed |Added Attachment #97548|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 97692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97692=edit Bug 24452: Advanced editor - show multiple spaces visually This patch updates the JavaScript and CSS for the advanced MARC editor so that multiple consecutive spaces within a line will be detected and highlighted. To test the EnableAdvancedCatalogingEditor system preference should be enabled. Apply the patch and clear your browser cache if necessary. - Go to Cataloging -> Advanced editor. - On any text entry line (e.g. 245), enter some words with one, two, and more spaces in between them. When there are two or more spaces between words the spaces between the words should have a dotted red underline. - Remove the extra spaces and confirm that the dotted line disappears. Signed-off-by: Cori Lynn Arnold Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23594] Batch modification for itemtypes on suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #15 from Katrin Fischer --- Sorry Joubu, some fails on the QA test tools: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt FAIL filters wrong_html_filter at line 473 () missing_filter at line 473 () missing_filter at line 497 () missing_filter at line 498 () missing_filter at line 502 () missing_filter at line 648 (Delete selected) FAIL forbidden patterns forbidden pattern: Attribute type should not be used for script tags (bug 20053) (line 840) OK git manipulation OK js_in_body OK spelling OK tt_valid OK valid_template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23594] Batch modification for itemtypes on suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24161] Late orders improvements - keeping track of claims
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #11 from Katrin Fischer --- I had already started here yesterday, so trying to clean up my notes: +=head3 authorizer Wonder if we should make this 'creator', as we have discussed for the API endpoint. Missing description in the updatedatabase: +print "Upgrade to $DBversion done (Bug X - description)\n"; Both not blocking further testing! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16721] Add table configuration to serial claims table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16721 --- Comment #2 from Katrin Fischer --- (In reply to Owen Leonard from comment #1) > This bug faces the same obstacle Bug 23565 does: The > jquery.dataTables.columnFilter.js plugin doesn't play well with columns > configuration. I wonder if it would be an acceptable alternative to move the > filter fields into the sidebar? I am not a fan of the filters on the columns as the 'sample text' inside often is squashed, especially after translation. We often have filters on the side - I think that could work. We also have the additional fields on subscriptions showing up in the side filters - so maybe similar here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Hayley Mapley changed: What|Removed |Added Blocks||24454 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454 [Bug 24454] currency formatting from JS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24454] currency formatting from JS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z Depends on||20212 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 [Bug 20212] Slowness in Receiving in Acquisitions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Hayley Mapley changed: What|Removed |Added Attachment #95284|0 |1 is obsolete|| --- Comment #23 from Hayley Mapley --- Created attachment 97691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97691=edit Bug 23777: Use To.json in request.tt Test plan: Use quotes in a library's name, then place an item on hold for a patron that cannot do it. If you are allowed to overwrite this restriction you will get a warning: "This item normally cannot be put on hold except for patrons from BRANCHNAME" The library's name should be correcty displayed Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Hayley Mapley changed: What|Removed |Added Attachment #95283|0 |1 is obsolete|| --- Comment #22 from Hayley Mapley --- Created attachment 97690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97690=edit Bug 23777: Use TO.json in value_builder/unimarc_field_4XX.tt No idea how to test this but, as other fixes work, this one should, right? Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Hayley Mapley changed: What|Removed |Added Attachment #95282|0 |1 is obsolete|| --- Comment #21 from Hayley Mapley --- Created attachment 97689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97689=edit Bug 23777: Use To.json in results.tt Test plan: Search for a string with quote and confirm that it is correctly highlighted in the result list. Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Hayley Mapley changed: What|Removed |Added Attachment #95280|0 |1 is obsolete|| --- Comment #19 from Hayley Mapley --- Created attachment 97687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97687=edit Bug 23777: Use To.json in preferences.tt Test plan: Search for "foo bar" (with double quotes) in the sysprefs Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Hayley Mapley changed: What|Removed |Added Attachment #95281|0 |1 is obsolete|| --- Comment #20 from Hayley Mapley --- Created attachment 97688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97688=edit Bug 23777: Use To.json in authorities.tt No fix here. Test plan: Edit GENRE/FORM 040$a With text: Original catalo'"ging age"'ncy Save, you get the alert Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Hayley Mapley changed: What|Removed |Added Attachment #95279|0 |1 is obsolete|| --- Comment #18 from Hayley Mapley --- Created attachment 97686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97686=edit Bug 23777: Fix for the advanced editor Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Hayley Mapley changed: What|Removed |Added Attachment #95275|0 |1 is obsolete|| --- Comment #17 from Hayley Mapley --- Created attachment 97685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97685=edit Bug 23777: Fix auth finder escaping Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23064] Cannot edit subscription with strict SQL modes turned on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z --- Comment #8 from Hayley Mapley --- Hi Jonathan, I am unable to reproduce this bug on master. Steps I have taken: 1) Define a budget, active fund, and vendor 2) Create new subscription 3) Edit that subscription 4) Put 'f' in the 'Number of issues to display to staff' field (I also tried putting 'f' in the Subscription length field, which saves with no errors and is NULLed) 5) Kept an eye on the plack-error.log and the intranet-error.log during the testing, did not see any error. Would you please tell me what I have missed here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #23 from David Cook --- I'm really interested in this issue, but juggling a few things at the moment, so not going to do the full test. However, I do want to say the following: 1. koha_perl_deps.pl is working great with this change 2. prove t/Installer_pm.t t/Installer_PerlModules.t passed its tests, although they spat out a bunch of Test::MockTime warnings on my non-Debian system running Perl 5.26.1. I imagine that's unrelated though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21586] Add generic OpenIDConnect client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21586 --- Comment #11 from David Cook --- Created attachment 97684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97684=edit Local login plus external login Example of local login plus external logins. The links/buttons are for URLs like this: https://gitlab.com/users/auth/google_oauth2 https://gitlab.com/users/auth/twitter It would be interesting to have plugins so that we could do things like: https://koha/users/auth/google https://koha/users/auth/custom_idp1 https://koha/users/auth/custom_idp2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24476] New: Allow patrons to opt-out of Auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 Bug ID: 24476 Summary: Allow patrons to opt-out of Auto-renewal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: n...@bywatersolutions.com Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Some patrons prefer to renew their books on their own. This development will allow a patron to opt-out of auto-renewals -the cron will ignore these checkouts and items will be renewable both via the staff and opac. Patrons will be able to set this flag themselves, staff will also be able to. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15726] Add columns configuration and export options to circulation and fine rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15726 Owen Leonard changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15726] Add columns configuration and export options to circulation and fine rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15726 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15726] Add columns configuration and export options to circulation and fine rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15726 Owen Leonard changed: What|Removed |Added Attachment #90452|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16721] Add table configuration to serial claims table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16721 --- Comment #1 from Owen Leonard --- This bug faces the same obstacle Bug 23565 does: The jquery.dataTables.columnFilter.js plugin doesn't play well with columns configuration. I wonder if it would be an acceptable alternative to move the filter fields into the sidebar? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22572] Garbled content of MARC control fields in MARC view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22572 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23794] Convert OpacMainUserBlock system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23794 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |RESOLVED Resolution|--- |WONTFIX --- Comment #13 from Owen Leonard --- This interface still needs work but it's going to end up being quite different after Bug 23501 so I think this should be closed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19704] OPACs most popular feature includes titles hidden by OpacHiddenItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19704 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24385] Add menu into pages tools and admin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24385 --- Comment #1 from Owen Leonard --- Could we have some more details about this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24475] Reword FinesMode system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 Andrew Fuerste-Henry changed: What|Removed |Added CC||jza...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24475] New: Reword FinesMode system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 Bug ID: 24475 Summary: Reword FinesMode system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The text for FinesMode reads: (Don't Calculate / Calculate and Charge / Calculate but only for mailing to the admin) fines (when misc/cronjobs/fines.pl is being run). NOTE: Fines can also be charged by the CalculateFinesOnReturn system preference. NOTE: This system preference requires the misc/cronjobs/fines.pl cronjob. Ask your system administrator to schedule it. This gives the impression that CalculateFinesOnReturn is an alternative to FinesMode -- that one could set FinesMode to "Don't calculate" and turn on CalculateFinesOnReturn in order to only calculate fines when an item is checked in. However, CalculateFinesOnReturn only works when FinesMode is set to "Calculate and charge." CalculateFinesOnReturn is an alternative to the fines cron, not to FinesMode. I'll think on better wording here and get back to this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24475] Reword FinesMode system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 Andrew Fuerste-Henry changed: What|Removed |Added CC||bwsdo...@gmail.com, ||ke...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 Lucas Gass changed: What|Removed |Added Assignee|lu...@bywatersolutions.com |oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24054] Typo in ClaimReturnedWarningThreshold system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24054 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|20.05.00, 19.11.02. |20.05.00, 19.11.02. released in|19.05.07|19.05.07, 18.11.14 --- Comment #6 from Hayley Mapley --- Backported to 18.11.x for 18.11.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24054] Typo in ClaimReturnedWarningThreshold system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24054 Lucas Gass changed: What|Removed |Added Version(s)|20.05.00, 19.11.02 |20.05.00, 19.11.02. released in||19.05.07 Status|Pushed to stable|Pushed to oldstable CC||lu...@bywatersolutions.com --- Comment #5 from Lucas Gass --- backported to 19.05.x for 19.05.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Chris Cormack changed: What|Removed |Added Summary|Lost items that are checked |Lost items that are checked |out are always returned |out are always returned, ||even when attempting to ||renew them CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24181] Make our datepicker inputs sexy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00, 19.11.02 |20.05.00 released in|| Status|Pushed to stable|ASSIGNED --- Comment #20 from Joy Nelson --- Reverted from 19.11.x branch until more fixes available. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982 --- Comment #22 from Aleisha Amohia --- I have opened Bug 24474 depending on this one to fix the bug that this has caused. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] New: Lost items that are checked out are always returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Bug ID: 24474 Summary: Lost items that are checked out are always returned Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com This was a bug introduced by Bug 22982. "Hey all, this patch is causing problems for some of our libraries because it's been assumed that lost items with no attached charge should automatically be returned. This is not always the desired behaviour - we have one case where the library wants to keep lost items on a patron's record, and another case where a checked out lost item will be renewed, but the amount outstanding is zero, so the item gets returned. These are edge cases, but the assumptions in this patch do not consider them, and are causing problems. Is there a workaround? Or perhaps a better way of doing this patch that can allow for the cases of 'renewing a lost item' or 'wanting to keep a lost item on the checkouts record'? A solution that avoids doing circulation actions in the accounts modules as this patch does would be ideal." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982 Aleisha Amohia changed: What|Removed |Added Blocks||24474 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 [Bug 24474] Lost items that are checked out are always returned -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Aleisha Amohia changed: What|Removed |Added Depends on||22982 Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982 [Bug 22982] Paying lost fee does not always remove lost item from checkouts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz --- Comment #21 from Aleisha Amohia --- Hey all, this patch is causing problems for some of our libraries because it's been assumed that lost items with no attached charge should automatically be returned. This is not always the desired behaviour - we have one case where the library wants to keep lost items on a patron's record, and another case where a checked out lost item will be renewed, but the amount outstanding is zero, so the item gets returned. These are edge cases, but the assumptions in this patch do not consider them, and are causing problems. Is there a workaround? Or perhaps a better way of doing this patch that can allow for the cases of 'renewing a lost item' or 'wanting to keep a lost item on the checkouts record'? A solution that avoids doing circulation actions in the accounts modules as this patch does would be ideal. Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24249] OPAC lists page should require login for login-dependent operations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249 Owen Leonard changed: What|Removed |Added Attachment #96350|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 97683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97683=edit Bug 24249: OPAC lists page should require login for login-dependent operations This patch modifies opac-shelves.pl so that login is required if the requested operation is anything but "view" and "list." The patch also modifies a couple of "Log in to create a new list" links so that they point to the list creation form instead of opac-user.pl. To test, apply the patch and go to the main lists page (the list of lists) in the OPAC while not logged in. - Click the "Log in to create a new list" link. - Log in. - You should be taken to the "Create a new list" form. - Also test the "New list" link shown in the toolbar when you're viewing the contents of a list. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23884] Merge strings.inc and browser-strings.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23884 David Nind changed: What|Removed |Added Attachment #97659|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 97682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97682=edit Bug 23884: Merge strings.inc and browser-strings.inc This patch take the contents of the JavaScript in browser-strings.inc and puts it in strings.inc. browser-strings.inc is deleted. To test, apply the patch and perform a catalog search in the staff client. - View any result. In the left-hand sidebar there should be a search results browser box with "previous" and "next" arrows and a link back to search results. - Click on each different "view" tab and confirm that the search results navigation box persists: Normal, MARC, Labeled MARC, ISBD, Items. - From any of these views select Edit -> Edit items. The same navigation box should appear. Note: addbiblio.tt and stockrotation.tt are modified but feature doesn't currently work on those pages. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23884] Merge strings.inc and browser-strings.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23884 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24356] objects.search prefetch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #3 from Tomás Cohen Arazi --- This is missing tests for the helpers. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24356] objects.search prefetch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 97680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97680=edit Bug 24356: prefetch_whitelist tests This patch adds tests for the introduced methods. To test: 1. Run the tests :-D => SUCCESS: They pass! 2. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24356] objects.search prefetch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 97681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97681=edit Bug 24356: Make objects.search prefetch embedded relations This patch makes the Koha::Object(s) derived classes expose information about prefetch-able relations. This is then used by a new helper to generate the prefetch information for the DBIC query. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object* \ t/db_dependent/Koha/REST/Plugin/Objects.t \ t/db_dependent/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Needs Signoff CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13325] Add logs for budgets and funds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325 Barbara Johnson changed: What|Removed |Added CC||barbara.johnson@bedfordtx.g ||ov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24417] Charges/Fees.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24417 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #1 from Joy Nelson --- Let me know if something needs doing on 19.11.x branch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #52 from Joy Nelson --- Enhancement not backported to 19.11.x branch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13325] Add logs for budgets and funds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22868] Circulation staff with suggestions_manage can have access to acquisition data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868 --- Comment #21 from Marie-Luce Laflamme --- I've tested the patch and here are my results... - a patron with a super librarian permission can manage and add suggestion - a patron without "suggestion management" permission cannot add suggestion There is a tiny issue with the 3rd type of patron account... - patron with several permissions (including "suggestion management") can add suggestion, but it also has the ability to "manage suggestions" (accept or reject suggestions) when you click on "Back to suggestion." To reproduce: Create a patron with "suggestion management" permission (see previous comment for details) Apply the patch Login with a patron who has the "suggestion management" permission Find a patron account. Click on "Purchase suggestion" and Add a suggestion. After submitting the suggestion, click on the title of the suggestion to assess the request. At the bottom of the suggestion form, click on "Back to suggestion" After clicking on "Back to suggestion", you are sent to the "Suggestion Management" page (Acquisition > Suggestion), where you can accept or reject suggestions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7468] Add label to batch by barcode range
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 David Nind changed: What|Removed |Added Text to go in the||This enhancement to the release notes||label creator tool adds an ||option to let you generate ||a range of barcode numbers ||(for example, from 05000 to ||05500) and save these as a ||PDF, ready for printing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 David Roberts changed: What|Removed |Added CC|david.roberts@ptfs-europe.c | |om | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16147] OpacItemLocation and not for circulation Item types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16147 --- Comment #4 from Ed Veal --- I am ok with this bug being closed. I think it is an old issue that has evolved since my original submission is not a big deal. Ed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24105] Longoverdue gives error message when --itemtypes are specified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24105 David Roberts changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 David Roberts changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||david.roberts@ptfs-europe.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24105] Longoverdue gives error message when --itemtypes are specified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24105 David Roberts changed: What|Removed |Added CC||david.roberts@ptfs-europe.c ||om --- Comment #2 from David Roberts --- Seems to work OK in my dev environment according to the test plan. Signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 --- Comment #12 from Katrin Fischer --- I'll add some more problem pages: * Reports: /cgi-bin/koha/reports/issues_stats.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24473] Syndetics content should be $raw filtered on opac-detail.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24473] Syndetics content should be $raw filtered on opac-detail.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473 --- Comment #1 from Lucas Gass --- Created attachment 97679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97679=edit Bug 24473: Add $raw filter for Syndetics content TEST PLAN: 1. have a Syndetics account set up and turn on the Syndetics system preferences. 2. Find title(s) with Syndetics content for 'Title Notes', 'About The Author', 'Excerpt' and 'Reviews'. 3. Notice that any HTML markup displays literally. 4. Apply patch and restart_all. 5. Notice that HTML should display correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24356] objects.search prefetch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |agustinmoy...@theke.io |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13371] Add filters to the supplier list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Marci changed: What|Removed |Added CC||mc...@mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24473] Syndetics content should be $raw filtered on opac-detail.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473 Lucas Gass changed: What|Removed |Added Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24473] New: Syndetics content should be $raw filtered on opac-detail.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473 Bug ID: 24473 Summary: Syndetics content should be $raw filtered on opac-detail.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Syndetics offers enhanced content in the OPAC under the tabs 'Title Notes', 'Excerpt', 'About the author', 'Editions'. They provide this info as HTML therefore we should filter it as $raw so the content shows up without the markup. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13325] Add logs for budgets and funds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325 Marci changed: What|Removed |Added CC||mc...@mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Aly changed: What|Removed |Added CC||aratt...@nwacc.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Christopher Kellermeyer changed: What|Removed |Added CC||ckellermeyer@altadenalibrar ||y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11161] Relabel 'child fund' to 'sub fund'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11161 David Roberts changed: What|Removed |Added CC||david.roberts@ptfs-europe.c ||om --- Comment #3 from David Roberts --- I tried signing this off on the PTFS Sandbox, but it doesn't seem to apply correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Barbara Johnson changed: What|Removed |Added CC||barbara.johnson@bedfordtx.g ||ov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22658] aqbasket.authorisedby is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22658 --- Comment #7 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #6) > Looking forward to seeing this one.. did you want me to have a bash at it > Tomas or were you intended to adopt it? I prefer to finish my works first. If it is not done yet, I'll pick it. I intended to use it for bug 24464, but can adapt it once the relationship is done. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22658] aqbasket.authorisedby is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22658 --- Comment #6 from Martin Renvoize --- Looking forward to seeing this one.. did you want me to have a bash at it Tomas or were you intended to adopt it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23237] Add support for [% INCLUDE %] in plugin templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237 --- Comment #11 from Martin Renvoize --- Any further thoughts regarding Tomas's comment Frederic? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23237] Add support for [% INCLUDE %] in plugin templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237 Martin Renvoize changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #22 from Martin Renvoize --- I like the idea of moving to cpanfile as it means moving away from koha specific code and toward well maintained wider community code.. This patchset all looks solid to me, but I'm not a packaging expert so I'm not sure how that side of things would be affected by this.. calling Mason and Mirko for comment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Martin Renvoize changed: What|Removed |Added CC||mi...@abunchofthings.net, ||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7468] Add label to batch by barcode range
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 --- Comment #63 from Martin Renvoize --- Label.pm of course.. I was never good at multi-tasking ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 --- Comment #27 from Martin Renvoize --- Personally, I'm pretty onboard with this.. moving us closer to DBIx::Class seems reasonable and productive. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24472] New: Add ability to log changes to hold suspensions to action logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24472 Bug ID: 24472 Summary: Add ability to log changes to hold suspensions to action logs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24471] Rename ILL method handle_commit_maybe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471 --- Comment #1 from Andrew Isherwood --- Created attachment 97678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97678=edit Bug 24471: handle_commit_maybe => redirect_user This patch renames all occurrences of handle_commit_maybe to redirect_user Test plan: - Navigate around ILL and check redirections from one action/stage to another are happening correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24471] Rename ILL method handle_commit_maybe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471 Andrew Isherwood changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24471] Rename ILL method handle_commit_maybe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471 Andrew Isherwood changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24471] New: Rename ILL method handle_commit_maybe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471 Bug ID: 24471 Summary: Rename ILL method handle_commit_maybe Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherw...@ptfs-europe.com The naming of “handle_commit_maybe” is very misleading. As far as I can see from comments and old commits, it was intended to do more at some point but all it does, and has ever done, is redirect the user based on some conditions. A better name would be something simpler like “redirect_user” -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24339] SIP codes are missing from the default payment_types on installation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Martin Renvoize changed: What|Removed |Added Attachment #96988|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 97677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97677=edit Bug 24339: Remove SIP payment types from staff pay screens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24339] SIP codes are missing from the default payment_types on installation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Martin Renvoize changed: What|Removed |Added Attachment #96976|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 97676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97676=edit Bug 24339: Add SIP2 payment types for installation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24339] SIP codes are missing from the default payment_types on installation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #5 from Martin Renvoize --- Regarding test plan, the Payments types are just Authorized Values as they have been for years.. this patch just ensures they are present for installs (currently they're just populated during upgrades). Hmm, I can't replicate your test failure either :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24459] Overloaded ->to_api needs to pass $params through
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24459 --- Comment #5 from Jonathan Druart --- Created attachment 97675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97675=edit Bug 24459: Make ->to_api pass $params through This patch makes the to_api method in Koha::Acquisition::Inovice and Koha::Patron pass the passed parameters to the base class to_api method. This is required for things like embedding related objects. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t \ t/db_dependent/Koha/Acquisition/Invoice.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24459] Overloaded ->to_api needs to pass $params through
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24459 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |Passed QA --- Comment #6 from Jonathan Druart --- Trivial, same as bug 24457, skipping QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
