[Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 David Nind changed: What|Removed |Added Attachment #96826|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 97937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97937&action=edit Bug 23944: Phase out use of jquery.cookie.js in favor of js.cookie.js This patch adds a new JavaScript file to the staff client's global JavaScript include file: js.cookie-2.2.1.min.js. This "plugin" will replace jquery.cookie.js which is no longer maintained. The "About" page in the staff client is updated to include this new resource as well as adding previously-missing information about the old plugin which will remain until all instances of its usage have been removed. To test, apply the patch and check the About page to confirm the correct information is included. No functionality change is introduced by this bug. The only other observable change is the existence of the new files and the inclusion of the minified version of the file in any staff client page. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 David Nind changed: What|Removed |Added Attachment #96827|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 97938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97938&action=edit Bug 23944: (follow-up) Update circulation to use new library This patch updates the circulation page to use the new JavaScript Cookie library for cookie management. To test, apply the patch and open a patron record for checkout in the staff client. - Click "Search to hold" in the toolbar and perform a catalog search which will return results. - On the search results page, the toolbar at the top of the results should include a split "Place hold" button. The button's menu should include "Place hold for " and "Forget " options. Test that these work correctly. - In the table of search results each title should include a "Place hold for " link. - Go to the checkouts page for a patron with one or more checked-out items. - Check the "Always show checkouts immediately" checkbox. - The patron's checkouts should load. - Open another patron for checkout who has checked-out items. - The table of checkouts should load automatically. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24356] objects.search prefetch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 --- Comment #10 from Agustín Moyano --- Created attachment 97936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97936&action=edit Bug 24356: Make objects.search prefetch embedded relations This patch makes the Koha::Object(s) derived classes expose information about prefetch-able relations. This is then used by a new helper to generate the prefetch information for the DBIC query. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object* \ t/db_dependent/Koha/REST/Plugin/Objects.t \ t/db_dependent/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24356] objects.search prefetch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Agustín Moyano changed: What|Removed |Added Attachment #97851|0 |1 is obsolete|| Attachment #97852|0 |1 is obsolete|| --- Comment #9 from Agustín Moyano --- Created attachment 97935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97935&action=edit Bug 24356: prefetch_whitelist tests This patch adds tests for the introduced methods. To test: 1. Run the tests :-D => SUCCESS: They pass! 2. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24356] objects.search prefetch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Agustín Moyano changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24502] objects.search filter by prefetched columns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 Agustín Moyano changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24502] objects.search filter by prefetched columns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 --- Comment #1 from Agustín Moyano --- Created attachment 97934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97934&action=edit Bug 24502: object.search also filter by prefetched columns This patch adds the possibility to object.search helper, to also filter by prefetched columns. In order to dynamically add filter parameters, they must be coded as json string, and sent within the q parameter. The coded json, is in fact dbix syntax. To test: 1. apply this patch 2. prove t/Koha/REST/Plugin/Query.t t/db_dependent/Koha/REST/Plugin/Objects.t 3. Sign off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24515] Column Configuration for pay-fines-table does not hide Account Type properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24515] Column Configuration for pay-fines-table does not hide Account Type properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515 David Nind changed: What|Removed |Added Attachment #97931|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 97933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97933&action=edit Bug 24515: Column Configuration for pay-fines-table does not hide Account Type properly This patch corrects the order of the columns in the columns configuration YML file. The incorrect order was causing the wrong column to be hidden when changing the columns settings for the table in Administration. To test, apply the patch and go to Administration -> Columns settings. - Under Patrons -> pay-fines-table, test hiding the account_type and description columns, together and separately. - Verify that the correct columns are hidden on the pay fines screen (Patron -> Accounting -> Make a payment) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- Created attachment 97932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97932&action=edit Bug 13327: Screenshots with different options Results from my testing: - For OPACPopupAuthorsSearch enabled and OPACXSLTDetailsDisplay default: • works for the author search (the new style for the modal is much nicer) • the modal for subject terms doesn't appear/work - For OPACPopupAuthorsSearch enabled and OPACXSLTDetailsDisplay empty: • search icon different for additional authors • old search icon displays for ‘Subject(s):’ • the modal for subject terms works, but uses 'old style' - For OPACPopupAuthorsSearch disabled and OPACXSLTDetailsDisplay empty - the record displays the same as for OPACPopupAuthorsSearch enabled and OPACXSLTDetailsDisplay empty I've attached a document with screenshots. Tested use Firefox Developer Edition and Google Chrome on Ubuntu 18.04 - cleared browser history, cache, etc for different combination of options. Also used a fresh container for each combination using koha-testing-docker. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24515] Column Configuration for pay-fines-table does not hide Account Type properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24515] Column Configuration for pay-fines-table does not hide Account Type properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | Version|19.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24515] Column Configuration for pay-fines-table does not hide Account Type properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515 --- Comment #1 from Owen Leonard --- Created attachment 97931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97931&action=edit Bug 24515: Column Configuration for pay-fines-table does not hide Account Type properly This patch corrects the order of the columns in the columns configuration YML file. The incorrect order was causing the wrong column to be hidden when changing the columns settings for the table in Administration. To test, apply the patch and go to Administration -> Columns settings. - Under Patrons -> pay-fines-table, test hiding the account_type and description columns, together and separately. - Verify that the correct columns are hidden on the pay fines screen (Patron -> Accounting -> Make a payment) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24490] Clarify wording and function of Purchase Items link on POS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 David Roberts changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #8 from David Roberts --- Hi Katrin OK, try that instead. Do I need to mark it back to Needs Signoff? I've done that anyway, just in case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24490] Clarify wording and function of Purchase Items link on POS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 David Roberts changed: What|Removed |Added Attachment #97879|0 |1 is obsolete|| --- Comment #7 from David Roberts --- Created attachment 97930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97930&action=edit Bug 24490: Clarify wording and function of Purchase Items link on POS This patch changes the wording of the links on the POS side menu To test: 1) Apply the patch 2) Check that the links on the left hand side of the screen read "Configure Cash Registers" and "Configure Items for Purchase" 3) Click both links to ensure you are taken to the relevant config pages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18186] Plack config: Amounts with decimal comma instead of decimal dot breaking payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18186 --- Comment #6 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #5) > (In reply to Tomás Cohen Arazi from comment #4) > > So, if you fix some variables: > > - browser, > > - browser locale > > - settings in Koha > > > > then if you switch the locale and restart plack the behaviour change? > > Yes. We have seen this happen twice - we fixed it, we lost the setting in > Plack... we fixed it again. I know it sounds strange, we were a bit puzzled > as well. The only thing I can think of right now is that Plack is smart and imports the env locales settings. And I bet some of our libraries for handling number representations, like TT, is picking that. So we should be hardcoding the 'no-locale' setting. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24305] Batch Item modification via item number in reports does not work with CONCAT in report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305 --- Comment #18 from Katrin Fischer --- I think almost all our libraries would fail the cardnumber is numeric test... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24305] Batch Item modification via item number in reports does not work with CONCAT in report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
--- Comment #17 from Katrin Fischer ---
(In reply to Marcel de Rooy from comment #14)
> Still one question remaining. No blocker for me.
>
> + id="cardnumberlist">[% FOREACH result IN results %][% FOREACH cells IN
> result.cells %][% place = loop.index %][% IF header_row.$place.cell ==
> 'cardnumber' || header_types.item(header_row.$place.cell) == 'cardnumber' &&
> cells.cell.match('^(\d+)$') %][% SET batch_cardnumbers = 1 %]
>
> Why do you check on only digits for cardnumber here? The field cardnumber is
> a varchar ?
So... should we not have removed it?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24490] Clarify wording and function of Purchase Items link on POS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 --- Comment #6 from Katrin Fischer --- Btw - I like the new wording much better :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24490] Clarify wording and function of Purchase Items link on POS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer --- I am sorry David, but the new text doesn't have the right capitalization. Only the first word of each link should be capitalized (see coding guidelines). Do you want to have a go at fixing this? Let me know if I can help. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24504] branchtransfers.pl - Entering checked out item cause Internal Server Error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24504 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- Could it be the item was missing a holdingbranch or something like that? But Jonathan is right, without more information (steps we can replicate) or at least the error from the logs, I am not sure how we can help here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24501] Authorities 'merge' is confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24501 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- I understand that it is confusing, but changing a cronjob name means that in every installations people might have to change their cronjob setup... I am not sure if we should do this. And if we do it, maybe it should be a gradual process turning the current script into a wrapper that sends a deprecation warning to the logs for one release and asks you to switch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18186] Plack config: Amounts with decimal comma instead of decimal dot breaking payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18186 --- Comment #5 from Katrin Fischer --- (In reply to Tomás Cohen Arazi from comment #4) > So, if you fix some variables: > - browser, > - browser locale > - settings in Koha > > then if you switch the locale and restart plack the behaviour change? Yes. We have seen this happen twice - we fixed it, we lost the setting in Plack... we fixed it again. I know it sounds strange, we were a bit puzzled as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24497] CodeMirror indentation problems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24497 Christopher Brannon changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||cbran...@cdalibrary.org --- Comment #6 from Christopher Brannon --- Yes! You are a life saver! Works much better! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24497] CodeMirror indentation problems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24497 ByWater Sandboxes changed: What|Removed |Added Attachment #97893|0 |1 is obsolete|| --- Comment #5 from ByWater Sandboxes --- Created attachment 97929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97929&action=edit Bug 24497: Turn off smartIndent for SQL Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #23 from Nick Clemens --- Created attachment 97927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97927&action=edit Bug 24476: DO NOT PUSH - Schema updates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #24 from Nick Clemens --- Created attachment 97928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97928&action=edit Bug 24476: Add boolean for all TINYINT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #22 from Nick Clemens --- Created attachment 97926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97926&action=edit Bug 24476: Allow patrons to opt out of auto-renewal To test: 1 - Verify on staff side that patron can be edited to opt in our out of auto renewal 2 - Check out some items to a patron opted in to auto renewal 3 - Ensure the items are checked out and set to autorenew 4 - Login on the opac at the patron 5 - Verify items cannot be renewed as scheduled for auto-renewal 6 - On staff side, opt patron out of auto renewal 7 - Verify on opac items are no longer marked for auto renewal 8 - Run the auto renewal cron job, items are not renewed 9 - Set 'no renewal before' to a setting that would prevent renewal 10 - Verify that opting patron in or out of auto renewal changes only the reason items cannot be renewed 11 - Set 'no renewal before' to a setting that would allow for renewal 12 - Verify that opting patron in/out changes their ability to renew 13 - Verify that when opted out cron does not renew 14 - Verify that when opted in the item is auto renewed 15 - Reset the due date, opt out, verify manual renewal succeeds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #21 from Nick Clemens --- Created attachment 97925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97925&action=edit Bug 24476: Change CanBookBeRenewed and adjust tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #20 from Nick Clemens --- Created attachment 97924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97924&action=edit Bug 24476: API Updates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 Nick Clemens changed: What|Removed |Added Attachment #97831|0 |1 is obsolete|| Attachment #97832|0 |1 is obsolete|| Attachment #97833|0 |1 is obsolete|| Attachment #97834|0 |1 is obsolete|| Attachment #97835|0 |1 is obsolete|| Attachment #97836|0 |1 is obsolete|| --- Comment #19 from Nick Clemens --- Created attachment 97923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97923&action=edit Bug 24476: Database updates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24510] When Placing a Hold, cursor doesn't focus on Patron Name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Kelly McElligott changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24510] When Placing a Hold, cursor doesn't focus on Patron Name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 ByWater Sandboxes changed: What|Removed |Added Attachment #97887|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 97922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97922&action=edit Bug 24510: Add focus to Patron/club input Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24515] New: Column Configuration for pay-fines-table does not hide Account Type properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515 Bug ID: 24515 Summary: Column Configuration for pay-fines-table does not hide Account Type properly Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com In the Patron set of the Column Configuration under Pay-Fines-Table, checking to hide the "account type" field does not hide the "Account Type" in pay.pl. If "Account Type" and "Description" are both chosen, it will hide the "account type" in pay.pl but not the "description". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #61 from Tomás Cohen Arazi --- Created attachment 97920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97920&action=edit Bug 23463: cn_sort needs to be updated if cn_source changed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #60 from Tomás Cohen Arazi --- Created attachment 97919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97919&action=edit Bug 23463: Replace recently added occurrences Few occurrences have been added since this patchset has been originaly written -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #59 from Tomás Cohen Arazi --- Created attachment 97918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97918&action=edit Bug 23463: build cn_sort only if needed No need to calculate cn_sort if not dirty when we store -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #58 from Tomás Cohen Arazi --- Created attachment 97917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97917&action=edit Bug 23463: Fix items.cn_source vs cn_source -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #62 from Tomás Cohen Arazi --- Created attachment 97921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97921&action=edit Bug 23463: (follow-up) Remove DelItemCheck and ItemSafeToDelete Wrong replacement in additem.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #54 from Tomás Cohen Arazi --- Created attachment 97913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97913&action=edit Bug 23463: Fix failing tests And adding a FIXME about discard_changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #57 from Tomás Cohen Arazi --- Created attachment 97916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97916&action=edit Bug 23463: update permanent_location if location has been updated This change to Koha::Item->store seems correct here, but tests from /db_dependent/Items.t is failing now. Adjusting them to make them pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #53 from Tomás Cohen Arazi --- Created attachment 97912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97912&action=edit Bug 23463: Fix CancelReceipt.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #56 from Tomás Cohen Arazi --- Created attachment 97915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97915&action=edit Bug 23463: Fix AutomaticItemModificationByAge.t We do not want to log if nothing changed How could we do that better? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #55 from Tomás Cohen Arazi --- Created attachment 97914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97914&action=edit Bug 23463: Getting less item-level_itypes warnings (?) So, we get less warnings. I do not really understand why... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #51 from Tomás Cohen Arazi --- Created attachment 97910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97910&action=edit Bug 23463: Remove DelItemCheck and ItemSafeToDelete -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #52 from Tomás Cohen Arazi --- Created attachment 97911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97911&action=edit Bug 23463: Remove no longer needed subs related to default values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #49 from Tomás Cohen Arazi --- Created attachment 97908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97908&action=edit Bug 23463: Remove ModItem There should not be any calls left -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #50 from Tomás Cohen Arazi --- Created attachment 97909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97909&action=edit Bug 23463: Remove DelItem -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #48 from Tomás Cohen Arazi --- Created attachment 97907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97907&action=edit Bug 23463: Remove _mod_item_dates We did not do anything useful here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #43 from Tomás Cohen Arazi --- Created attachment 97902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97902&action=edit Bug 23463: Replace ModItem with Koha::Item->store Starting to replace the ModItem calls with Koha::Item->store -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #44 from Tomás Cohen Arazi --- Created attachment 97903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97903&action=edit Bug 23463: remove trivial UpdateHoldingbranch sub We do not need this subroutine, moving it where it is used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #45 from Tomás Cohen Arazi --- Created attachment 97904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97904&action=edit Bug 23463: Move plugin hook From C4::Items to Koha::Item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #46 from Tomás Cohen Arazi --- Created attachment 97905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97905&action=edit Bug 23463: _set_derived_columns_for_mod was only used for cn_sort Same as _set_defaults_for_add -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #47 from Tomás Cohen Arazi --- Created attachment 97906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97906&action=edit Bug 23463: _do_column_fixes_for_mod dealt with integer location and timestamp moved That's done in Koha::Item->store, and Koha::Object->store for integers. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #41 from Tomás Cohen Arazi --- Created attachment 97900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97900&action=edit Bug 23463: Replace _set_derived_columns_for_add Remove the unique call to _set_derived_columns_for_add Even if design to deal with other values it only dealts with cn_sort -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #38 from Tomás Cohen Arazi --- Created attachment 97897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97897&action=edit Bug 23463: fix for testbuilder - set default value items.damaged=0 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #42 from Tomás Cohen Arazi --- Created attachment 97901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97901&action=edit Bug 23463: AddItem removing We are done with AddItem, only need to log and index. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #37 from Tomás Cohen Arazi --- Created attachment 97896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97896&action=edit Bug 23463: Remove uneeded SearchItemsByField subroutine It is no longer used. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #40 from Tomás Cohen Arazi --- Created attachment 97899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97899&action=edit Bug 23463: Remove _set_defaults_for_add _set_defaults_for_add is no longer needed as it is handled by dbic and koha::object->store -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #39 from Tomás Cohen Arazi --- Created attachment 97898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97898&action=edit Bug 23463: Replace AddItem calls with Koha::Item->store Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi changed: What|Removed |Added Attachment #95925|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi changed: What|Removed |Added Attachment #95922|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi changed: What|Removed |Added Attachment #95923|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #36 from Tomás Cohen Arazi --- Created attachment 97895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97895&action=edit Bug 23463: Replace SearchItemsByField by SearchItems The subroutine SearchItemsByField is only called once and can be replaced easily with SearchItems Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi changed: What|Removed |Added Attachment #95919|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi changed: What|Removed |Added Attachment #95921|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi changed: What|Removed |Added Attachment #95918|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi changed: What|Removed |Added Attachment #95915|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi changed: What|Removed |Added Attachment #95917|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi changed: What|Removed |Added Attachment #95920|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi changed: What|Removed |Added Attachment #95916|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi changed: What|Removed |Added Attachment #95911|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi changed: What|Removed |Added Attachment #95914|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi changed: What|Removed |Added Attachment #95913|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi changed: What|Removed |Added Attachment #95912|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi changed: What|Removed |Added Attachment #95910|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi changed: What|Removed |Added Attachment #95909|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi changed: What|Removed |Added Attachment #95906|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi changed: What|Removed |Added Attachment #95908|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi changed: What|Removed |Added Attachment #95905|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi changed: What|Removed |Added Attachment #95907|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi changed: What|Removed |Added Attachment #95904|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi changed: What|Removed |Added Attachment #95900|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi changed: What|Removed |Added Attachment #95903|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi changed: What|Removed |Added Attachment #95901|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi changed: What|Removed |Added Attachment #95902|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi changed: What|Removed |Added Attachment #95899|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi changed: What|Removed |Added Attachment #96145|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #35 from Tomás Cohen Arazi --- Rebased against master. Leaving ASSIGNED while I QA this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24486] Account Wording Information is duplicated in Patron's Fines Tab on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 Christofer Zorn changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||christofer.zorn@ajaxlibrary ||.ca --- Comment #5 from Christofer Zorn --- Followed test plan and was able to duplicate the error. After applying the patch, the duplication of text was no longer there. Christofer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24486] Account Wording Information is duplicated in Patron's Fines Tab on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 ByWater Sandboxes changed: What|Removed |Added Attachment #97883|0 |1 is obsolete|| --- Comment #4 from ByWater Sandboxes --- Created attachment 97894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97894&action=edit Bug 24486: Remove duplicated account information at the OPAC commit efc21e6f47801503e55e3ba709a48c3f426f90ac Bug 23115: (follow-up) Move switches to a TT block Duplicated the following line: +[% PROCESS account_type_description account=ACCOUNT_LINE %] [%- PROCESS account_status_description account=ACCOUNT_LINE -%] Which cause the info to appear twice Test plan: Create a manual invoice Pay it Void it Go to the opac, account => You should see only one "(Voided)" Signed-off-by: Christofer Zorn -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6138] Show local help and isbd punctuation automatically when we are cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6138 Ingrid changed: What|Removed |Added CC||ingridschie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24486] Account Wording Information is duplicated in Patron's Fines Tab on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #3 from Lucas Gass --- Hi Jonathan, Yes I only see one one "(Voided)" but in some cases (when payment has not been voided) I see nothing at all. I could be wrong but shouldn't it be 'account_status_description' that is deleted and 'account_type_description' that should stay? Thank you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24025] Make CodeMirror content searchable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24025 Lucas Gass changed: What|Removed |Added Severity|enhancement |minor CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24497] CodeMirror indentation problems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24497 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24497] CodeMirror indentation problems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24497
--- Comment #4 from Lucas Gass ---
Created attachment 97893
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97893&action=edit
Bug 24497: Turn off smartIndent for SQL
This only seems to effect SQL CodeMirror inputs and I belive it to be the
smartIndent feature. This patch turns that off for SQL only.
TEST PLAN:
1. Enter 'SELECT CONCAT( CONCAT('a','b'))' into a SQL Report and press Enter
2. Extreme indent
3. Apply patch.
4. Enter 'SELECT CONCAT( CONCAT('a','b'))' into a SQL Report and press Enter
5. No indent.
6. Check that other indenting still works proper.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24497] CodeMirror indentation problems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24497 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24511] Patron emailer report not using specified email column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24511 Kelly McElligott changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ke...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
