[Koha-bugs] [Bug 24539] Build generic authentication module interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24539 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21791] Add payment type on Cash register report (cash_register_stats.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21791 --- Comment #4 from Martin Renvoize --- I would say for an inbuilt report like this one then translating codes to descriptions is the preferred approach.. however this is a great start. Just to note, however, I am currently considering a patch to merge payment_type into credit_types as I'm not sure that having two levels of 'type' makes sense now that we have a clearer distinction between 'credit' and 'debit' lines. I'd be interested in feedback for that approach.. are there really times when one would want `pay` + `cash` or `credit` + `beans` vs just having `cash`, `card` and `beans` as a top-level credit type? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 --- Comment #42 from Martin Renvoize --- (In reply to David Cook from comment #39) > It's too bad there are no unit tests for Koha::Middleware::RealIP. I ended > up writing a very basic one here just to test that it worked for multiple > proxies. Agreed, but I didn't want to hold up this vital development and we weren't at all sure how to write such a test.. as it sounds like you've got the foundations for a test written, please submit it upstream ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24539] Build generic authentication module interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24539 --- Comment #1 from David Cook --- I'm not using the existing Koha plugin system, as I'm still not 100% sure I want to implement these as plugins that end-users can upload... but still thinking. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21586] Add generic OpenIDConnect client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21586 --- Comment #12 from David Cook --- I decided to make some strides on generic authentication and opened https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24539 I've refactored my OpenID Connect code to take advantage of a standard generic interface in Auth.pm and opac-auth.tt. I still have some work to do on the endpoint that triggers the login, but I have some ideas about that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24539] New: Build generic authentication module interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24539 Bug ID: 24539 Summary: Build generic authentication module interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org CC: dpav...@rot13.org Locally, I run a number of custom authentication integrations for Koha, and I've been thinking it would be great if there were a generic authentication module interface. So I've refactored my local OpenID Connect implementation, so that the changes to Auth.pm and opac-auth.tt are very generic, and other authentication modules could easily leverage them without touching Auth.pm or opac-auth.tt. (The latter remains translateable as generic messages are in opac-auth.tt and they are bound to keys passed from the authentication module.) Right now, you invoke a custom endpoint (I have ideas about making those more generic and extensible too) and it passes an object to C4::Auth::checkauth(). The module for that object and some other data are persisted in the logged in user's session. To log off, you just hit the log off button, Koha gets relevant info from the user's session, and runs the authentication module's logout hook. My goal is to make it so that people can rapidly develop authentication modules, and make it easy to swap in and out different modules. (For instance, my local OpenID Connect code works and works reasonable well, but it's not perfect. However, I shouldn't need to touch Auth.pm and opac-auth.tt to improve that code. The improvements should be isolated within the specific authentication module itself.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #41 from Katrin Fischer --- Created attachment 98106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98106=edit Bug 17374: (QA follow-up) Make search labels match with patron record Makes some small changes to the patronfields.inc to make sure the search labels match with the labels in the patron record. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13121] Move search results "action" links ("Place hold, " "Add tag, " etc) into include file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13121 David Nind changed: What|Removed |Added Text to go in the||This patch moves markup for release notes||controls repeated across ||several OPAC templates into ||a single include (making it ||easier to maintain in the ||future): Place hold, ||Request article, Add tag, ||Save to lists, and Add to ||cart. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23885] Move staff client search results JavaScript into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23885 David Nind changed: What|Removed |Added Text to go in the||As part of the coding release notes||guidelines (JS1 - Whenever ||possible JavaScript should ||be placed in a separate ||file), this patch patch ||moves most of the ||JavaScript embedded in ||results.tt for the staff ||interface into a separate ||file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Katrin Fischer changed: What|Removed |Added Depends on|14874 | See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=14874 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Katrin Fischer changed: What|Removed |Added Blocks|17374 | See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17374 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24537] Allow IP ranges in ILS-DI:AuthorizedIPs using Net::Netmask
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24537 Katrin Fischer changed: What|Removed |Added CC||b...@interleaf.ie --- Comment #3 from Katrin Fischer --- *** Bug 20243 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20243] ILS-DI CIDR notation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20243 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- I think this is a possible duplicate to bug 24537 - marking as such, please undo if incorrect. *** This bug has been marked as a duplicate of bug 24537 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22490] Some strings in javascript files are untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22490 Fridolin SOMERS changed: What|Removed |Added Depends on||24046 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24046 [Bug 24046] 'Activate filters' untranslatable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22490] Some strings in javascript files are untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22490 Fridolin SOMERS changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|fridolin.som...@biblibre.co |koha-b...@lists.koha-commun |m |ity.org --- Comment #6 from Fridolin SOMERS --- Bug 24046 fixed "Activate filters" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24046] 'Activate filters' untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24046 Fridolin SOMERS changed: What|Removed |Added Blocks||22490 CC||fridolin.som...@biblibre.co ||m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22490 [Bug 22490] Some strings in javascript files are untranslatable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24537] Allow IP ranges in ILS-DI:AuthorizedIPs using Net::Netmask
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24537 --- Comment #2 from David Cook --- Note that this really shines when you're running Koha behind a reverse proxy and you use koha_trusted_proxies to set your REMOTE_USER to the IP address that contacted your reverse proxy (or the last one in a trust chain). (Note also that there are other places in Koha that could benefit from this. Like OpacSuppressionByIPRange, RestrictedPageLocalIPs, etc.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24537] Allow IP ranges in ILS-DI:AuthorizedIPs using Net::Netmask
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24537 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23068 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24537 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24537] Allow IP ranges in ILS-DI:AuthorizedIPs using Net::Netmask
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24537
--- Comment #1 from David Cook ---
Created attachment 98105
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98105=edit
Bug 24537: Allow IP ranges in ILS-DI:AuthorizedIPs using Net::Netmask
This patch uses Net::Netmask to match IPs from ILS-DI:AuthorizedIPs
against $ENV{REMOTE_USER}. By using Net::Netmask, we can use addresses
in a variety of formats. This includes 127.0.0.1, 192.168.1.0/24,
10.0.0, and so on.
To Test:
1. Apply the patch
2. Empty the 'ILS-DI:AuthorizedIPs' system preference
3. Send a request to
'/cgi-bin/koha/ilsdi.pl?service=LookupPatron=1_type=cardnumber'
3b. Note that the request is successful
4. Set the 'ILS-DI:AuthorizedIPs' system preference to a subnet including
your IP address (e.g. 192.168.1.0/24)
5. Send a request to
'/cgi-bin/koha/ilsdi.pl?service=LookupPatron=1_type=cardnumber'
5b. Note that the request is successful
6. Set the 'ILS-DI:AuthorizedIPs' system preference to a subnet that doesn't
include
your IP address (e.g. 1.1.1)
7. Send a request to
'/cgi-bin/koha/ilsdi.pl?service=LookupPatron=1_type=cardnumber'
7b. Note that your request is refused
8. Try a variety of permutations including bad values (e.g. 192.168.1.) or
multiple values
(e.g. 10.0.0.0/8,192.168.1.0/24) or multiple values including a mix of good and
bad values
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24537] Allow IP ranges in ILS-DI:AuthorizedIPs using Net::Netmask
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24537 David Cook changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24538] REMOTE_USER set to undef if koha_trusted_proxies contains invalid value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538
--- Comment #1 from David Cook ---
The solution should probably use either the new2 constructor (code smell...) or
check the $objet->{'ERROR'} value as per
https://metacpan.org/pod/Net::Netmask#CONSTRUCTING.
(Note that I actually found this while testing a patch for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24537)
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 David Cook changed: What|Removed |Added Blocks||24538 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538 [Bug 24538] REMOTE_USER set to undef if koha_trusted_proxies contains invalid value -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24538] New: REMOTE_USER set to undef if koha_trusted_proxies contains invalid value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538 Bug ID: 24538 Summary: REMOTE_USER set to undef if koha_trusted_proxies contains invalid value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org If koha_trusted_proxies contains an invalid or unparseable value, say due to a typo, like "1.1.1.", it'll treat it as a 0.0.0.0/0 mask and match against everything. In my tests, this leads to REMOTE_USER being set to undef. (On the plus side, at least a 0.0.0.0/0 mask leads to zero privileges rather than all privileges.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24538] REMOTE_USER set to undef if koha_trusted_proxies contains invalid value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538 David Cook changed: What|Removed |Added Depends on||23068 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 --- Comment #41 from David Cook --- Ok found a little problem and I'll open up a separate bug report for it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24537] New: Allow IP ranges in ILS-DI:AuthorizedIPs using Net::Netmask
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24537 Bug ID: 24537 Summary: Allow IP ranges in ILS-DI:AuthorizedIPs using Net::Netmask Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org By using Net::Netmask (introduced by Bug 23068), we can allow IP ranges in the ILS-DI:AuthorizedIPs system preference. This makes it much easier to integrate with other systems. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 --- Comment #40 from David Cook --- One last note for people interested in this feature, Net::Netmask lets you define IP addresses in a number of ways. If you wanted to trust a whole local subnet, you could do 192.168.0.0/16, or something like that. (If you're using a proxy like an AWS Elastic Load Balancer, which is dynamically assigned an IP address chosen by AWS, you could specify the subnets for your ELBs, and then wouldn't have to worry about IP addresses changing and keeping your koha-conf.xml up to date.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 --- Comment #39 from David Cook --- I've been thinking about this one more, and I just want to say again well done, Kyle! I like how it can handle multiple proxies, and the trust model so that end users can't hack REMOTE_USER using their own user-supplied headers. It's too bad there are no unit tests for Koha::Middleware::RealIP. I ended up writing a very basic one here just to test that it worked for multiple proxies. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 --- Comment #38 from David Cook --- I just want to say that this is working beautifully in 19.11. Thanks a lot, Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login attempts [part 1]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190 --- Comment #34 from Agnes Rivers-Moore --- I added comments as an end-user, my way of supporting work on this - will be sad to see it die. I appreciate the work done. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21791] Add payment type on Cash register report (cash_register_stats.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21791 --- Comment #3 from Eric Phetteplace --- I took a pass at adding this field but I'm not sure if it will work; I didn't test on a sandbox instance. One question I had: the values of accountlines.payment_type come from the PAYMENT_TYPE authorized values. Should the report show the field's literal value (the code) or its (more readable) associated Description? I lean towards showing literal values as they tend to be more consistent over time but I'm not sure if there's a standardized approach for Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21791] Add payment type on Cash register report (cash_register_stats.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21791 --- Comment #2 from Eric Phetteplace --- Created attachment 98104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98104=edit UNTESTED patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24347] Add a 'search to order' option similar to 'search to hold'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 --- Comment #8 from Katrin Fischer --- Thx a lot Owen for picking up my idea and running with it! Possible improvement I could imagine: - Add a link to jump directly to Advanced search - Improve the styling of the 'Add to order' pop up to make all our different options a bit easier to handle (not related to this bug actually) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24456] previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder sort incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24456 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24347] Add a 'search to order' option similar to 'search to hold'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Katrin Fischer changed: What|Removed |Added Attachment #97949|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 98102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98102=edit Bug 24347: (follow-up) Remove custom catalog search from acquisitions This patch removes the "neworderbiblio" script and template which are made obsolete by the "search to order" feature. deleted:acqui/neworderbiblio.pl deleted:koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderbiblio.tt Some documentation in addorder.pl has been corrected to remove reference to neworderbiblio.pl. To test, apply the patch and verify that the correct files have been removed. Search the Koha codebase to verify that no links to acqui/neworderbiblio.pl remain. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24456] previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder sort incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24456 ByWater Sandboxes changed: What|Removed |Added Attachment #97580|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 98103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98103=edit Bug 24456: change default sort orders/make wording clearer Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24347] Add a 'search to order' option similar to 'search to hold'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24347] Add a 'search to order' option similar to 'search to hold'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Katrin Fischer changed: What|Removed |Added Attachment #97948|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 98101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98101=edit Bug 24347: Add a 'search to order' option similar to 'search to hold' This patch modifes the process of searching for an existing record to add to a basket. Now the search is performed as a keyword search in the regular catalog rather than via a custom search script. Options are added to the search results and detail pages to add results to an order. This process follows the same pattern as the "Search to hold" feature: When the search is initiated, a cookie is set with the requisite information--in this case vendor id and basket number. If the search results or bibliographic detail pages detect that a "searchToOrder" cookie is present, the correct "Add order" link will be shown. Like with the "search to hold" feature, the cookie expires in 10 minutes. To test, apply the patch and log into the staff client as a user who has permission to add to a basket in acquisitions. - Go to Acquisitions -> Vendor -> Basket -> Add to basket. - Using the "From an existing record" option, perform a search. - On the search results page, test the "Add order" link which appears with each result. Clicking the link should take you to the "New order" page for the correct vendor and basket. The catalog details section of the form should include the correct information. - From the search results page view the bibliographic details page for any record. There should be a new toolbar button, "Add order." Verify that it works correctly. - Test the same thing from all bibliographic detail pages: Normal, MARC, Labeled MARC, ISBD, as well as the items page (moredetail.pl). - Test this process for both the locations in acquisitions where one can add to an existing basket: Vendor search results and the basket detail page - Test the cookie timeout: Wait 10 minutes and perform another catalog search. The "Add order" link should no longer be present. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24347] Add a 'search to order' option similar to 'search to hold'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Katrin Fischer changed: What|Removed |Added Keywords||Manual QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22868] Circulation staff with suggestions_manage can have access to acquisition data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868 --- Comment #28 from Katrin Fischer --- This patch will fix the regression found (see comments before), for further improving/splitting permissions, it would be great if separate bug reports could be reported. There are small glitches: - The top permission has one sub permission now. It might have been slightly more consistent to have it only as a top level module permission, but seeing requests here for more granular permissions, this might see more work later. - The breadcrumbs show Acquisitions, but when you click on it, you got no permission. I am not seeing this as a blocker, as this is what we had before the regression was introduced. So I think we can think about this separately. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22868] Circulation staff with suggestions_manage can have access to acquisition data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868 Katrin Fischer changed: What|Removed |Added Attachment #97951|0 |1 is obsolete|| --- Comment #27 from Katrin Fischer --- Created attachment 98100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98100=edit Bug 22868: Move suggestions_manage subperm out of acquisition perm Bug 11911 replaced the permission of suggestions.pl (create a purchase suggestion) from catalogue => 1 to acquisition => 'suggestions_manage'. However we have a lot of acquisition scripts that have lax permissions (acquisition => '*' which means any sub permissions of acquisition is enough). That causes problem when a circulation staff can create purchase suggestions but not access acquisition information. One solution is to move the suggestions_manage subpermission out of the acquisition permission and create a new suggestion permission. Test plan: 0. Setup * Create a patron with several permission (and full acquisition permission) * Create another patron with several permission, and suggestions_manage permission * Create another patron without the suggestions_manage permission 1. Apply the patch and execute the update database entry 2. Note that the third patron you create still does not have suggestions_manage 3. Confirm that you can create a purchase suggestion if you have suggestions_manage, but cannot access acquisition pages if you do not have any subpermissions of the acquisition permission Signed-off-by: Hayley Mapley Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22868] Circulation staff with suggestions_manage can have access to acquisition data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24376] Wording of Fine Returned is confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24376 --- Comment #6 from Katrin Fischer --- I agree about final not being ideal. Not being a native speaker probably doesn't help much here... but is the opposite of an accrueing fine? Static? Frozen? just: Fine Unpaid? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24376] Wording of Fine Returned is confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24376 --- Comment #5 from amanda.jo...@williamsoncounty-tn.gov --- Patrons can also see this wording on the OPAC. They might be thrown off by one fine stating FINAL then seeing that fine begin to accrue again. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||katrin.fisc...@bsz-bw.de --- Comment #52 from Katrin Fischer --- Onto the next one... Jonathan, can you please rebase? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23594] Batch modification for itemtypes on suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24536 --- Comment #29 from Katrin Fischer --- Filed bug 24536 for adding a new column for itemtype. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24536] Move itemtype on suggestions table into its own column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24536 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23594 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23594] Batch modification for itemtypes on suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594 Katrin Fischer changed: What|Removed |Added Attachment #98094|0 |1 is obsolete|| --- Comment #28 from Katrin Fischer --- Created attachment 98099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98099=edit Bug 23594: Fix bad resolution conflict with bug 16784 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23594] Batch modification for itemtypes on suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594 Katrin Fischer changed: What|Removed |Added Attachment #97665|0 |1 is obsolete|| --- Comment #26 from Katrin Fischer --- Created attachment 98097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98097=edit Bug 23594: Restore previous view after delete or update itemtype We want to restore the previous view when suggestions are deleted or their itemtypes are updated. To avoid c/p the code is moved to a new subroutine. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23594] Batch modification for itemtypes on suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594 Katrin Fischer changed: What|Removed |Added Attachment #97693|0 |1 is obsolete|| --- Comment #27 from Katrin Fischer --- Created attachment 98098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98098=edit Bug 23594: Add missing html filters Also fixes the following QA failure: forbidden pattern: Attribute type should not be used for script tags (bug 20053) (line 840) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23594] Batch modification for itemtypes on suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594 Katrin Fischer changed: What|Removed |Added Attachment #97663|0 |1 is obsolete|| --- Comment #24 from Katrin Fischer --- Created attachment 98095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98095=edit Bug 23594: Batch modification for itemtypes on suggestions page This new enhancement adds the ability to update the item types for selected suggestions on the suggestions management page (suggestion/suggestion.pl) To achieve this goal we needed to refresh a bit the template, in order to get rid of weird code. To not recreate the previous coding awkwardness some code has been rewritten (mainly the removal of suggestiontype) Test plan: - Create some suggestions - On the suggestions management page, select some of them and a new item types. - Submit the form and confirm that the itemtype of the suggestions has been updated - Also you should confirm that the "delete" and "change status" still work as before Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23594] Batch modification for itemtypes on suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594 Katrin Fischer changed: What|Removed |Added Attachment #97664|0 |1 is obsolete|| --- Comment #25 from Katrin Fischer --- Created attachment 98096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98096=edit Bug 23594: Fix [un]checkall links Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23594] Batch modification for itemtypes on suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594 Katrin Fischer changed: What|Removed |Added Attachment #97781|0 |1 is obsolete|| --- Comment #23 from Katrin Fischer --- Created attachment 98094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98094=edit Bug 23594: Fix bad resolution conflict with bug 16784 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23594] Batch modification for itemtypes on suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24536] New: Move itemtype on suggestions table into its own column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24536 Bug ID: 24536 Summary: Move itemtype on suggestions table into its own column Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org the itemtype on the suggestions page in acq is part of the suggestion (title) information. It would be nice if it was sortable in its own column. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23031] Improve UX of buttons on order search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23031] Improve UX of buttons on order search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031 Katrin Fischer changed: What|Removed |Added Attachment #97409|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 98093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98093=edit Bug 23031: Make 'add to basket' accessible in one click (fix regression) Since bug 21364 we have 'view' then 'add to basket' that is accessible in 2 clicks. We should have it directly accessible. Test plan: Create a new basket Add a new order to the basket (note that the link is directly accessible) When a new order is added you can close the basket from the basket list view Note that the dropdown button displays correctly Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23031] Improve UX of buttons on order search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031 --- Comment #5 from Katrin Fischer --- If I understand this correctly, the 'view' is on the basket name link and the 'add to order' is default action on the button? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23915] Replace OPAC list sort menu with Bootstrap menu button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915
Katrin Fischer changed:
What|Removed |Added
Attachment #98045|0 |1
is obsolete||
--- Comment #9 from Katrin Fischer ---
Created attachment 98092
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98092=edit
Bug 23915: Replace OPAC list sort menu with Bootstrap menu button
This patch adds JavaScript to the list contents page which converts the
resort form's menu into a Bootstrap dropdown menu. This allows
for a more compact and consistent display.
To test, apply the patch and regenerate the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
View a list in the OPAC. The toolbar of list controls ("New list,"
"Download list," etc.) should have a similary-styled "Sort" button. Each
sorting option should work correctly.
Signed-off-by: David Nind
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23915] Replace OPAC list sort menu with Bootstrap menu button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19814] Batch Check-in function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Change sponsored?|--- |Seeking cosponsors --- Comment #9 from Katrin Fischer --- (In reply to Sebastian Hierl from comment #8) > (In reply to Sebastian Hierl from comment #7) > > We would welcome this feature as well and would be able to contribute to a > > development. > > Actually, would anyone be interested in co-sponsoring? It seems that this > would be a fairly easy (and affordable) thing to implement. Perhaps just two > or three libraries coming together could make it happen. Hi Sebastian, I've set 'seeking cosponsors' in the Change sponsored? field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24535] New: Add the ability to have longer barcodes than 20 digits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24535 Bug ID: 24535 Summary: Add the ability to have longer barcodes than 20 digits Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: n...@bywatersolutions.com Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Currently, in Koha, an item's barcode can only be up to 20 digits, it would be nice to increase this value to possibly a higher number such as 32. Koha recently increased the patron's barcode length to 32 and it was helpful to libraries. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24376] Wording of Fine Returned is confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24376 Katrin Fischer changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #4 from Katrin Fischer --- (In reply to amanda.jones from comment #3) > We also take issue with the wording (Returned). We prefer the to replace it > with (Outstanding) as Final may not be the case if that item is renewed and > then becomes late again. Hi Amanda, if the item is renewed and becomes overdue again, this will create a new line in the accounting table (fine accrueing). But I think that's another reason why returned might not be a good pick here - if it's also used for renewals? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Aleisha Amohia changed: What|Removed |Added Summary|Add system preference to|Add system preference to |hide expiration date|disable the use of |options for reserves|expiration dates for ||reserves --- Comment #7 from Aleisha Amohia --- (In reply to Katrin Fischer from comment #6) > (In reply to Aleisha Amohia from comment #5) > > (In reply to Jonathan Druart from comment #3) > > > Should not it be hidden locally in CSS or JS instead? > > > > It turns out the library wants to not use expiration dates for reserves at > > all, so the latest patch now includes not setting an expiration date when > > setting a reserve as waiting, and nullifying an expiration date when > > reverting waiting status. Back to needs signoff, with a new test plan. > > Hi Aleisha, can you please update the bug title? Sounds like quite a > different thing now! Fair enough Katrin, have updated! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24377] Record branch in statistics for auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377 Nick Clemens changed: What|Removed |Added Severity|normal |major --- Comment #7 from Nick Clemens --- Bumping to major, this causes data loss for statistics -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Agustín Moyano changed: What|Removed |Added Attachment #96451|0 |1 is obsolete|| Attachment #96452|0 |1 is obsolete|| Attachment #96643|0 |1 is obsolete|| --- Comment #19 from Agustín Moyano --- Created attachment 98090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98090=edit Bug 23673: change db structure Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #20 from Agustín Moyano --- Created attachment 98091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98091=edit Bug 23673: Add "Updated on" column to patron's notices This patch adds "Updated on" column to patron's notices tab. It also adds logic to C4::Letters to retrieve updated_on column. To test: 1. Apply patches. 2. Restart plack. 3. Choose a patron and add a purchase suggestion. 4. Change suggestion status. 5. Open patron's notifications. CHECK => Messages table has now "Updated on" and "Time created" columns, and "Time" column is gone. SUCCESS => There is a message with status pending, with a "time created" that equals "updated on" 6. Execute in the shell in Koha directory $ ./misc/cronjobs/process_message_queue.pl 7. Open patron's notifications one more time. SUCCESS => The message changed status. Time created remained the same, and now "updated on" has the current timestamp. 8. Resend the message and repeat sep 6. SUCCESS => Every time you change the status, time created remains the same and updated on updates. 9. prove t/db_dependant/Letters.t 10. Sign off Signed-off-by: Kelly McElligott Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21791] Add payment type on Cash register report (cash_register_stats.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21791 Eric Phetteplace changed: What|Removed |Added CC||ephettepl...@cca.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24377] Record branch in statistics for auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #27 from Agustín Moyano --- (In reply to Catherine E. Ingram from comment #21) > We were playing around with it this morning and wondered about roll out. > The way it looked in the sandbox was that it would default to all existing > patrons getting NO notices (with both email and digest un-checked). Did > anyone else encounter this? > ~Catherine Hi Catherine, you were right.. I believed that if I didn't add that preference on patrons that already had preferences setted, Koha would break, but it didn't happen at the end. Thanks for spotting that out. Can you please try it out again? Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Tomás Cohen Arazi changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #214 from Julian Maurice --- (In reply to Martin Renvoize from comment #212) > Are you hoping to pick this back up at some point Julian or are you hoping > someone will adopt it? I'm always hoping to have the time to work on patches I submitted, but that shouldn't stop people to rebase them, or submit follow-up patches. I certainly won't be mad if someone other than me make it pass QA :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #45 from Jonathan Druart --- (In reply to Kelly McElligott from comment #44) > Hi Martin, > Attempted to sign off on this bug Martin, > Looks like something in the Bug that this is dependant (23463) on has > changed, I received this error while testing: > > > Template process failed: undef error - The method Koha::Item->safe_to_delete > is not covered by tests! Hi Kelly, are you able to use the remote branch? You should be able to specify it if you are using the sandboxes. The problem is that the patches from bug 23463 are not attached to the bug report (but also on a remote branch). The remote branch https://gitlab.com/joubu/Koha/commits/bug_8132 contains all the necessary commits. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #28 from Martin Renvoize --- Corrected by reverting the errantly pushed patches and applying the followup here instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24534] Selection Options for Importing Staged MARC Records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24534 Jessie Zairo changed: What|Removed |Added CC||ke...@bywatersolutions.com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24534] New: Selection Options for Importing Staged MARC Records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24534 Bug ID: 24534 Summary: Selection Options for Importing Staged MARC Records Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: jza...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org It would be great to have a selection option in the Staged MARD Management tool that allowed you to choose which bibliographic records get imported into the system. Right now the only option is to import all records. Sometimes librarians get records from vendors where the record may have errors or not be complete. It would be great to have an option to select the records you want to import on /koha/tools/manage-marc-import.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24376] Wording of Fine Returned is confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24376 amanda.jo...@williamsoncounty-tn.gov changed: What|Removed |Added CC||amanda.jones@williamsoncoun ||ty-tn.gov --- Comment #3 from amanda.jo...@williamsoncounty-tn.gov --- We also take issue with the wording (Returned). We prefer the to replace it with (Outstanding) as Final may not be the case if that item is renewed and then becomes late again. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #213 from Owen Leonard --- (In reply to Martin Renvoize from comment #212) > Are you hoping to pick this back up at some point Julian or are you hoping > someone will adopt it? I second this question! My library is looking for something like this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24533] Improved sorting in checkouts table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533 Martin Renvoize changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24533] Improved sorting in checkouts table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533 Martin Renvoize changed: What|Removed |Added CC||oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24533] Improved sorting in checkouts table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533 --- Comment #1 from Martin Renvoize --- Created attachment 98088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98088=edit Bug 24533: Switch to aDataSort for multi-column sorting This patch adds aDataSort configurations for each sortable column such that we always maintain the group sorting primarily and apply a secondary sort using the column in question. When sorting by due date you are much more likely to want the true date sorting without forcing a primary sort on the grouping column. We achieve that by removing the primary sort on checkout date and disable rowGrouping in such a case. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24533] Improved sorting in checkouts table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24533] Improved sorting in checkouts table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24533] Improved sorting in checkouts table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533 Martin Renvoize changed: What|Removed |Added Depends on||23493 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24533] New: Improved sorting in checkouts table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533 Bug ID: 24533 Summary: Improved sorting in checkouts table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com The sorting in the checkouts table regressed with bug 23493. Before the patch: * Initial table load would group the results by "Today's checkouts" and "Previous checkouts". * Any subsequent column sort would disable the grouping entirely. After the patch: * Initial table load groups the results by "Today's checkouts" and "Previous checkouts". * Any subsequent column sort will sort by that column, but leave the group titles intact. As such, sorting by title for example can end up with multiple "Today's checkouts" header rows which is confusing. I propose that for all column sorts, with the exception of due date, we perform a primary sort on the grouping field followed by a secondary sort on the column in question. This way we maintain the grouping and just sort within the groups. For the due date column sort I propose sorting directly on due date and removing the grouping header rows entirely. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize changed: What|Removed |Added Blocks||24533 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533 [Bug 24533] Improved sorting in checkouts table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #44 from Kelly McElligott --- Hi Martin, Attempted to sign off on this bug Martin, Looks like something in the Bug that this is dependant (23463) on has changed, I received this error while testing: Template process failed: undef error - The method Koha::Item->safe_to_delete is not covered by tests! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24528] Add a syntax for specifying counts on x-koha-embed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528 Tomás Cohen Arazi changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24529] Uninitialised value warnings in C4::Reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24529 --- Comment #5 from Jonathan Druart --- Created attachment 98087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98087=edit Bug 24529: Silence another uninitialised value warning Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24529] Uninitialised value warnings in C4::Reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24529 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24529] Uninitialised value warnings in C4::Reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24529 Jonathan Druart changed: What|Removed |Added Attachment #98075|0 |1 is obsolete|| Attachment #98076|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 98086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98086=edit Bug 24529: Silence warnings for title level holds This patch simply adds a test for itemnumber being defined in the reserve before comparing it to silence the warning. Test plan: 1) Prior to patch, run prove t/db_dependant/Circulation.t and note lots of `Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/C4/Reserves.pm line 790` warnings. 2) Apply the patch, re-run the test and note the tests still pass but the warnings are now gone. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs of opac detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 Marcel de Rooy changed: What|Removed |Added Summary|Show a number in title |Show a number in title |notes just as in the other |notes just as in the other |tabs|tabs of opac detail page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24532] Some account types are converted to debits when they shouldn't be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532 Nick Clemens changed: What|Removed |Added Severity|normal |major Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24532] New: Some account types are converted to debits when they shouldn't be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532 Bug ID: 24532 Summary: Some account types are converted to debits when they shouldn't be Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Bug 23049 converts some credit types to debit types The logic seems to be: 1 - Get all unique types where the accountline is a debit 2 - Convert all lines with these types to have debit codes But in step 1 if we have any type 'Pay' or 'W' for example, where the amount is greater than 0 (pathological credits which have debit amounts) then 'Pay' is added as a debit type and all 'Pay' lines get that as a debit code. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 Marcel de Rooy changed: What|Removed |Added Assignee|oleon...@myacpl.org |m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23896] logaction should pass the correct interface to Koha::Logger
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23896 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23896] logaction should pass the correct interface to Koha::Logger
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23896 Jonathan Druart changed: What|Removed |Added Attachment #98080|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 98085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98085=edit Bug 23896: logaction should pass the correct interface to Koha::Logger Trivial fix. Test plan: Run t/db../Log.t to ensure that we did not break stuff. If you set opac to debug in log4perl config, inspect opac-error.log to see if you have extra loglines from running the test script. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 --- Comment #2 from Marcel de Rooy --- Created attachment 98084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98084=edit Bug 24530: Show a number for title notes on opac-detail A number (just as on most other tabs) tells more than a boolean (i.e. the tab does not appear for zero marc notes). Intuitively, you might be misled by "Holdings (1), Descriptions" and think there are none. Test plan: Verify that the number of title notes on opac detail page matches your expectations. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
