[Koha-bugs] [Bug 24528] Add a syntax for specifying counts on x-koha-embed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528 Marcel de Rooy changed: What|Removed |Added Attachment #98201|0 |1 is obsolete|| --- Comment #12 from Marcel de Rooy --- Created attachment 98214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98214&action=edit Bug 24528: Add a syntax to x-koha-embed to specify counts This patch adds a + syntax to specify on the x-koha-embed header that we want the count of a relation in the response. For example: GET /patrons/1 x-koha-embed: checkouts+count Would return a JSON representation of a Koha::Patron, with a new attribute added: checkouts_count, which will be the result of calling $patron->checkouts->count. This is all done automatically in to_api. This patch makes parsing the x-koha-embed header build the right structure for passing to the to_api method. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24528] Add a syntax for specifying counts on x-koha-embed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528 Marcel de Rooy changed: What|Removed |Added QA Contact||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24528] Add a syntax for specifying counts on x-koha-embed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528 Marcel de Rooy changed: What|Removed |Added Attachment #98199|0 |1 is obsolete|| --- Comment #10 from Marcel de Rooy --- Created attachment 98212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98212&action=edit Bug 24528: Unit tests for Koha::Object->to_api This patch introduces unit tests for the new to_api bejaviour for *_count methods. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => FAIL: Tests fail because the feature is not implemented Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24528] Add a syntax for specifying counts on x-koha-embed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24528] Add a syntax for specifying counts on x-koha-embed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528
Marcel de Rooy changed:
What|Removed |Added
Attachment #98200|0 |1
is obsolete||
--- Comment #11 from Marcel de Rooy ---
Created attachment 98213
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98213&action=edit
Bug 24528: Add *_count support to to_api
This patch adds a way to tell to_api an attribute needs to be calculated
as the count on an existing method/relationship result. For example, if
we wanted to include the holds_count attribute for a Koha::Patron
object, we would call it:
$ patron_json = $patron->to_api({ embed => { holds_count => { is_count => 1
} } });
This way to_api will internally call
$json->{holds_count} = $self->holds->count;
To test:
1. Apply the tests patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Object.t
=> FAIL: Tests fail!
3. Apply this patch
4. Repeat (2)
=> SUCCESS: Tests pass!
5. Sign off :-D
Signed-off-by: David Nind
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Ere Maijala changed: What|Removed |Added Attachment #98210|0 |1 is obsolete|| --- Comment #28 from Ere Maijala --- Created attachment 98211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98211&action=edit Bug 22690: Refactor merging of records to improve performance (Elasticsearch) This patch allows merging of records with many items without the web server timing out. Test plan: Without the patch: - Create 2 records (one with e.g. 1000 items). - Do a cataloguing search that displays both records, select them and click "Merge selected". - Choose the record with many items as the one to be eliminated. - Start the merging. - After a while the web server should give you a timeout error (the merging process may still continue) With the patch: - Do the same as above - This time verify that the records are merged without timeout - Create a new biblio with an item - Add with the item: * acquisition order * hold (reserve) - Merge the biblio to another one - Verify that the item and its related data was moved - Verify that tests pass: prove -v t/db_dependent/Koha/Item.t prove -v t/db_dependent/Items/MoveItemFromBiblio.t Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 --- Comment #29 from Ere Maijala --- Rename done. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Ere Maijala changed: What|Removed |Added Attachment #98143|0 |1 is obsolete|| --- Comment #27 from Ere Maijala --- Created attachment 98210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98210&action=edit Bug 22690: Refactor merging of records to improve performance (Elasticsearch) This patch allows merging of records with many items without the web server timing out. Test plan: Without the patch: - Create 2 records (one with e.g. 1000 items). - Do a cataloguing search that displays both records, select them and click "Merge selected". - Choose the record with many items as the one to be eliminated. - Start the merging. - After a while the web server should give you a timeout error (the merging process may still continue) With the patch: - Do the same as above - This time verify that the records are merged without timeout - Create a new biblio with an item - Add with the item: * acquisition order * hold (reserve) - Merge the biblio to another one - Verify that the item and its related data was moved - Verify that tests pass: prove -v t/db_dependent/Koha/Item.t prove -v t/db_dependent/Items/MoveItemFromBiblio.t Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #10 from David Nind --- I get this message when trying to apply this patch (git bz apply 24502): Failed to retrieve bug information: NotPermitted Other bugs apply fine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 --- Comment #26 from Ere Maijala --- I'll rename the method as Martin suggested. Any other changes will cause complications with bug 20447 where we need to move holdings too (so that would become adopt_holdings_and_items_from_biblio). They can't really be separated since they depend on each other. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24523] Fix opac-password-recovery markup mistake
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24523 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24523] Fix opac-password-recovery markup mistake
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24523 Katrin Fischer changed: What|Removed |Added Attachment #98008|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 98209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98209&action=edit Bug 24523: add missing Signed-off-by: David Roberts Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=24532 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 --- Comment #25 from Joonas Kylmälä --- (In reply to Katrin Fischer from comment #24) > > Or we could do this even in the Item and Items objects for maximum code > > reusability, like $biblio->items->move_to_biblio? > > Maybe just move in this case? They can't go anywhere else than another > biblio. This bug is a dependency for Bug 20447 which introduces holdings records so similar moving of items to another holdings record is needed there in addition to moving to another biblio. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21357] Filter elisions from index and search terms in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357 --- Comment #36 from Ere Maijala --- I can't really see the benefit since, as far as I can see, elision handling is not prone to cause conflicts with other language analysis. Separating analysis for different languages also won't work for mixed-language fields. Think about names and a (very fictional) example phrase "Images from movie l'Avion". You'd get either elision filtering or English stemming but not both. For sure it will still be found with a simple keyword search, but it breaks at least adjacent word searches and relevance ranking. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #24 from Katrin Fischer --- > Or we could do this even in the Item and Items objects for maximum code > reusability, like $biblio->items->move_to_biblio? Maybe just move in this case? They can't go anywhere else than another biblio. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24440] Add ->current_holds to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 David Nind changed: What|Removed |Added Attachment #98197|0 |1 is obsolete|| --- Comment #16 from David Nind --- Created attachment 98208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98208&action=edit Bug 24440: (follow-up) Make related objects prefetchable This patch creates aliases for the relations used to retrieve the linked objects from other tables. It makes the accessor names match the used relation name, for consistency. This is important for code trying to be smart and guessing what needs to be prefetched, like the API code. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Order.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests pass! No behaviour change 4. Verify the POD changes make sense 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24440] Add ->current_holds to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 David Nind changed: What|Removed |Added Attachment #98194|0 |1 is obsolete|| --- Comment #13 from David Nind --- Created attachment 98205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98205&action=edit Bug 24440: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24440] Add ->current_holds to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24440] Add ->current_holds to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 David Nind changed: What|Removed |Added Attachment #98196|0 |1 is obsolete|| --- Comment #15 from David Nind --- Created attachment 98207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98207&action=edit Bug 24440: ->biblio tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24440] Add ->current_holds to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 David Nind changed: What|Removed |Added Attachment #98195|0 |1 is obsolete|| --- Comment #14 from David Nind --- Created attachment 98206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98206&action=edit Bug 24440: Add ->current_holds to Koha::Acquisition::Order This patch introduces a method to fetch the current holds associated with the items linked to an order line. It basically implements what's done in parcel.pl, but fully tested and suitable for using on the API. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Order.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24528] Add a syntax for specifying counts on x-koha-embed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #9 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 --- Comment #23 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #22) > I would just reverse the original idea: move_items_to_biblio. Then it should > be obvious we are talking about the current object's items being moved. Not > sure if perl OO style supports overloading, but in that case it could be > just move_items, and the parameters defined whether we move them to another > biblio or (yet to be included to Koha) to a holdings record. Or we could do this even in the Item and Items objects for maximum code reusability, like $biblio->items->move_to_biblio? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and subscriptions tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Failed QA --- Comment #6 from Marcel de Rooy --- Inclined to think that could be a blocker. We dont want large installs fail on this step. Feel free to change the status again, well argumented ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and subscriptions tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 --- Comment #5 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #1) > 0/ It would be useful to test the update DB entry on a big and old > production DB, to make sure the constraints will be added correctly. > We could remove the entries before creating the constraints, but it can > be unecessary Since it is theoretically possible that a delete was not completely executed somehow leaving some bad keys in the table, it would be useful to remove the entries and not assume they are not. Cannot be verified by one or two tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24356] objects.search prefetch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |Failed QA --- Comment #11 from David Nind --- Tests fail: prove t/db_dependent/Koha/Object* t/db_dependent/Koha/Objects.t .. 18/21 # Failed test 'Relationship matching method name is listed' # at t/db_dependent/Koha/Objects.t line 800. # Failed test 'Guessed the object class correctly' # at t/db_dependent/Koha/Objects.t line 804. # got: undef # expected: 'Koha::Acquisition::BasketGroup' # Looks like you failed 2 tests of 2. # Failed test 'prefetch_whitelist() tests' # at t/db_dependent/Koha/Objects.t line 809. # Looks like you failed 1 test of 21. t/db_dependent/Koha/Objects.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/21 subtests t/db_dependent/Koha/Object.t ... 17/18 # Failed test 'Relationship matching method name is listed' # at t/db_dependent/Koha/Object.t line 754. # Failed test 'Guessed the object class correctly' # at t/db_dependent/Koha/Object.t line 758. # got: undef # expected: 'Koha::Acquisition::BasketGroup' # Looks like you failed 2 tests of 2. # Failed test 'prefetch_whitelist() tests' # at t/db_dependent/Koha/Object.t line 763. # Looks like you failed 1 test of 18. t/db_dependent/Koha/Object.t ... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/18 subtests Test Summary Report --- t/db_dependent/Koha/Objects.t (Wstat: 256 Tests: 21 Failed: 1) Failed test: 21 Non-zero exit status: 1 t/db_dependent/Koha/Object.t (Wstat: 256 Tests: 18 Failed: 1) Failed test: 18 Non-zero exit status: 1 Files=2, Tests=39, 22 wallclock secs ( 0.05 usr 0.01 sys + 17.92 cusr 3.05 csys = 21.03 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and subscriptions tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl --- Comment #4 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24213] Koha::Object->get_from_storage should return undef if the object has been deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213 Marcel de Rooy changed: What|Removed |Added Attachment #98176|0 |1 is obsolete|| --- Comment #10 from Marcel de Rooy --- Created attachment 98204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98204&action=edit Bug 24213: Fix Koha::Object->get_from_storage if the object has been deleted Without this patch it fails with something like: DBIC result _type isn't of the _type Subscription at t/db_dependent/Biblio.t line 627. Test plan: - Apply the first patch (Add tests) - Confirm that they fail - Apply this patch - Confirm that the tests pass Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24213] Koha::Object->get_from_storage should return undef if the object has been deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213 Marcel de Rooy changed: What|Removed |Added Attachment #98175|0 |1 is obsolete|| --- Comment #9 from Marcel de Rooy --- Created attachment 98203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98203&action=edit Bug 24213: Add tests Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24213] Koha::Object->get_from_storage should return undef if the object has been deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24213] Koha::Object->get_from_storage should return undef if the object has been deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690
--- Comment #22 from Joonas Kylmälä ---
(In reply to Martin Renvoize from comment #21)
> Comment on attachment 98143 [details] [review]
> Bug 22690: Refactor merging of records to improve performance (Elasticsearch)
>
> Review of attachment 98143 [details] [review]:
> -
>
> This looks like a reasonable approach to me and seems to work well.. a
> relatively minor point regarding the introduce Koha/Biblio method.
>
> ::: Koha/Biblio.pm
> @@ +854,5 @@
> > +Move items from the given biblio
> > +
> > +=cut
> > +
> > +sub move_items_from_biblio {
>
> I feel like 'move_items_from_biblio' isn't immediately obvious as a function
> name.. are we moving from 'this' biblio or to it.. perhaps
> 'adopt_items_from_biblio' is a bit clearer?
I would just reverse the original idea: move_items_to_biblio. Then it should be
obvious we are talking about the current object's items being moved. Not sure
if perl OO style supports overloading, but in that case it could be just
move_items, and the parameters defined whether we move them to another biblio
or (yet to be included to Koha) to a holdings record.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24213] Koha::Object->get_from_storage should return undef if the object has been deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213 --- Comment #8 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #7) > # Subtest: Bad value tests > 1..3 > # No tests run! > not ok 16 - No tests run for subtest "Bad value tests" > # Failed test 'No tests run for subtest "Bad value tests"' > # at t/db_dependent/Koha/Object.t line 685. > # Looks like you failed 1 test of 16. > not ok 16 - store() tests > # Failed test 'store() tests' > # at t/db_dependent/Koha/Object.t line 688. > > Stumbling across this fail, but also without your patch. Can be ignored. Resolved with strict_sql_mode. Maybe an idea to put this key in the default koha-conf.xml (commented or zero)? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24467] *_count methods should be avoided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467 David Nind changed: What|Removed |Added Attachment #98198|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 98202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98202&action=edit Bug 24467: Remove _count methods introduced for API use This patch removes some methods that were introduced for API usage in the first iteration of the object embedding development effort. Those methods were obsoleted by bug 24528, which introduces a smarter way for Koha::Object->to_api to embed *_count attributes on the output structure based on the relationships and a call to ->count. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass 3. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24467] *_count methods should be avoided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24213] Koha::Object->get_from_storage should return undef if the object has been deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213 --- Comment #7 from Marcel de Rooy --- # Subtest: Bad value tests 1..3 # No tests run! not ok 16 - No tests run for subtest "Bad value tests" # Failed test 'No tests run for subtest "Bad value tests"' # at t/db_dependent/Koha/Object.t line 685. # Looks like you failed 1 test of 16. not ok 16 - store() tests # Failed test 'store() tests' # at t/db_dependent/Koha/Object.t line 688. Stumbling across this fail, but also without your patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23924] Add a parameter to the script add_date_fields_to_marc_records.pl to specify a date field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23924 Hugo Agud changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #5 from Hugo Agud --- when processing more than one record, the firts records creates propertly 905 field, but the second one doubles de 905 field with the info from record 1 and record 3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24213] Koha::Object->get_from_storage should return undef if the object has been deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #6 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24528] Add a syntax for specifying counts on x-koha-embed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528
David Nind changed:
What|Removed |Added
Attachment #98047|0 |1
is obsolete||
--- Comment #7 from David Nind ---
Created attachment 98200
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98200&action=edit
Bug 24528: Add *_count support to to_api
This patch adds a way to tell to_api an attribute needs to be calculated
as the count on an existing method/relationship result. For example, if
we wanted to include the holds_count attribute for a Koha::Patron
object, we would call it:
$ patron_json = $patron->to_api({ embed => { holds_count => { is_count => 1
} } });
This way to_api will internally call
$json->{holds_count} = $self->holds->count;
To test:
1. Apply the tests patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Object.t
=> FAIL: Tests fail!
3. Apply this patch
4. Repeat (2)
=> SUCCESS: Tests pass!
5. Sign off :-D
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24528] Add a syntax for specifying counts on x-koha-embed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528 David Nind changed: What|Removed |Added Attachment #98065|0 |1 is obsolete|| --- Comment #8 from David Nind --- Created attachment 98201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98201&action=edit Bug 24528: Add a syntax to x-koha-embed to specify counts This patch adds a + syntax to specify on the x-koha-embed header that we want the count of a relation in the response. For example: GET /patrons/1 x-koha-embed: checkouts+count Would return a JSON representation of a Koha::Patron, with a new attribute added: checkouts_count, which will be the result of calling $patron->checkouts->count. This is all done automatically in to_api. This patch makes parsing the x-koha-embed header build the right structure for passing to the to_api method. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24528] Add a syntax for specifying counts on x-koha-embed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24528] Add a syntax for specifying counts on x-koha-embed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528 David Nind changed: What|Removed |Added Attachment #98046|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 98199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98199&action=edit Bug 24528: Unit tests for Koha::Object->to_api This patch introduces unit tests for the new to_api bejaviour for *_count methods. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => FAIL: Tests fail because the feature is not implemented Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24467] *_count methods should be avoided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467 Tomás Cohen Arazi changed: What|Removed |Added Depends on|24440 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 [Bug 24440] Add ->current_holds to Koha::Acquisition::Order -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24440] Add ->current_holds to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 Tomás Cohen Arazi changed: What|Removed |Added Blocks|24467 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467 [Bug 24467] *_count methods should be avoided -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24467] *_count methods should be avoided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24467] *_count methods should be avoided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 98198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98198&action=edit Bug 24467: Remove _count methods introduced for API use This patch removes some methods that were introduced for API usage in the first iteration of the object embedding development effort. Those methods were obsoleted by bug 24528, which introduces a smarter way for Koha::Object->to_api to embed *_count attributes on the output structure based on the relationships and a call to ->count. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24467] *_count methods should be avoided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24467] *_count methods should be avoided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467 Tomás Cohen Arazi changed: What|Removed |Added Attachment #97746|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24467] *_count methods should be avoided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467 Tomás Cohen Arazi changed: What|Removed |Added Depends on|20212 | Blocks||20212 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 [Bug 20212] Slowness in Receiving in Acquisitions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi changed: What|Removed |Added Blocks|24467 | Depends on||24467 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467 [Bug 24467] *_count methods should be avoided -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi changed: What|Removed |Added Depends on||24528 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528 [Bug 24528] Add a syntax for specifying counts on x-koha-embed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24528] Add a syntax for specifying counts on x-koha-embed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528 Tomás Cohen Arazi changed: What|Removed |Added Blocks||20212 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 [Bug 20212] Slowness in Receiving in Acquisitions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24440] Add ->current_holds to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 98197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98197&action=edit Bug 24440: (follow-up) Make related objects prefetchable This patch creates aliases for the relations used to retrieve the linked objects from other tables. It makes the accessor names match the used relation name, for consistency. This is important for code trying to be smart and guessing what needs to be prefetched, like the API code. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Order.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests pass! No behaviour change 4. Verify the POD changes make sense 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24440] Add ->current_holds to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 --- Comment #11 from Tomás Cohen Arazi --- Created attachment 98196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98196&action=edit Bug 24440: ->biblio tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24440] Add ->current_holds to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 98195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98195&action=edit Bug 24440: Add ->current_holds to Koha::Acquisition::Order This patch introduces a method to fetch the current holds associated with the items linked to an order line. It basically implements what's done in parcel.pl, but fully tested and suitable for using on the API. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Order.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24440] Add ->current_holds to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 98194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98194&action=edit Bug 24440: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24440] Add ->current_holds to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 Tomás Cohen Arazi changed: What|Removed |Added Attachment #97492|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24440] Add ->current_holds to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24440] Add ->current_holds to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 Tomás Cohen Arazi changed: What|Removed |Added Status|In Discussion |Needs Signoff Summary|Add ->holds and |Add ->current_holds to |->holds_count to|Koha::Acquisition::Order |Koha::Acquisition::Order| --- Comment #8 from Tomás Cohen Arazi --- During the QA review, it was pointed out that this method was not well conceived as it needed to replicate the behaviour from parcel.pl and it wasn't doing that. I have now reworked it. Thanks Jonathan for your feedback! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24440] Add ->current_holds to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 Tomás Cohen Arazi changed: What|Removed |Added Attachment #97491|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23968] OPACMySummaryNote does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968 Arthur Suzuki changed: What|Removed |Added CC||arthur.suz...@biblibre.com --- Comment #8 from Arthur Suzuki --- The functionality is broken for 18.11 though but patch applies fine :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24551] OpacMySummaryHTML broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24551 Arthur Suzuki changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Arthur Suzuki --- My bad, my mistake... sry for that :) (too late to be working properly I guess?) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24551] OpacMySummaryHTML broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24551 --- Comment #1 from Arthur Suzuki --- Forgot to mention that I saw this on the opac-user.pl but the bug also affects opac-readingrecord.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24551] New: OpacMySummaryHTML broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24551 Bug ID: 24551 Summary: OpacMySummaryHTML broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: arthur.suz...@biblibre.com QA Contact: testo...@bugs.koha-community.org Created attachment 98193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98193&action=edit Screenshot showing html broken I was trying to use OpacMySummaryHTML to display things upon patrons connection but the functionality seems broken, at least on 18.11. the html gets its ending quote escaped and/or removed which make part of the link have a funny address like : Download as iCal/.ics file Also it kind of make things look ugly and desired message might not show up for patrons. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24550] New: Books renewals triggers item loan policies to revert to branch renewing item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24550 Bug ID: 24550 Summary: Books renewals triggers item loan policies to revert to branch renewing item Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: rruss...@pacificoaks.edu QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Created attachment 98192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98192&action=edit Renewal changes item policies Since the new update, we've noticed issues with our items not following policies from their home branch, triggering overdue notices, causing issues with holds, not charging fines, and reverting to the default branch. Not certain if self renewal is triggering this as well. These were never issues before. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate an export file as cataloger saves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429 Cori Lynn Arnold changed: What|Removed |Added Attachment #97404|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24377] Record branch in statistics for auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.03 released in|| CC||j...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #12 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24484] Add explanatory text to batch patron deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.03 released in|| Status|Pushed to master|Pushed to stable --- Comment #16 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23443] Paying off a lost fee will return the item, even if it is checked out to a different patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23443 Joy Nelson changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|20.05.00|20.05.00, 19.11.03 released in|| CC||j...@bywatersolutions.com --- Comment #12 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24421] Generated authorities are missing subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.03 released in|| CC||j...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #12 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24423] Broken link to return to record after batch item modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.03 released in|| CC||j...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #10 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate an export file as cataloger saves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429 Cori Lynn Arnold changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426 Joy Nelson changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.03 released in|| --- Comment #18 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17885] Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885 Joy Nelson changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.03 released in|| --- Comment #18 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23676] Elasticsearch - 0 is not a valid boolean for suppress
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Joy Nelson changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|20.05.00|20.05.00, 19.11.03 released in|| CC||j...@bywatersolutions.com --- Comment #13 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23934] Item level holds not checked for LocalHoldsPriority in Holds Queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.03 released in|| Status|Pushed to master|Pushed to stable --- Comment #12 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15142] Titles facet does not work in UNIMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15142 Joy Nelson changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|20.05.00|20.05.00, 19.11.03 released in|| CC||j...@bywatersolutions.com --- Comment #17 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10879] OverDrive should check for OverDriveLibraryID before performing search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10879 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10879] OverDrive should check for OverDriveLibraryID before performing search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10879 Lucas Gass changed: What|Removed |Added Attachment #95584|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 98191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98191&action=edit Bug 10879: OverDrive should check for OverDriveLibraryID before performing search This patch modifies the OPAC search results template to check for three populated system preferences before performing an OverDrive search: OverDriveLibraryID, OverDriveClientKey, and OverDriveClientSecret. Previously OverDriveLibraryID was not checked, but without it the interface reports an error performing the search. To test you must have credentials for the OverDrive API as defined in OverDriveClientKey, OverDriveClientSecret, and OverDriveLibraryID system preferences. - With OverDriveLibraryID defined, the catalog search results page in the OPAC should show a link to results in the library's OverDrive collection. - With no value in the OverDriveLibraryID preference the catalog search page should not show any message about an OverDrive collection. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24371] OPAC 'Showing only available items/Show all items' is double encoded
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24371 Joy Nelson changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|20.05.00|20.05.00, 19.11.03 released in|| CC||j...@bywatersolutions.com --- Comment #6 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.03 released in|| CC||j...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #48 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23274] t/db_dependent/XISBN.t fails with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23274 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.03 released in|| Status|Pushed to master|Pushed to stable --- Comment #7 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24323] Advanced editor - Invalid 008 with helper silently fails to save
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.03 released in|| CC||j...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #10 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24396] Suggestions.t is failing with MySQL 8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24396 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Status|Pushed to master|Pushed to stable Version(s)|20.05.00|20.05.00, 19.11.03 released in|| --- Comment #5 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23377] bulkmarcimport.pl disables syspref caching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23377 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.03 released in|| Status|Pushed to master|Pushed to stable --- Comment #8 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24200] Borrower_PrevCheckout.t failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24200 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.03 released in|| CC||j...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #6 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Lucas Gass changed: What|Removed |Added Attachment #96172|0 |1 is obsolete|| --- Comment #12 from Lucas Gass --- Created attachment 98190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98190&action=edit Bug 23533: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the interface or functionality. https://bugs.koha-community.org/show_bug.cgi?id=23533 Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Lucas Gass changed: What|Removed |Added Attachment #96170|0 |1 is obsolete|| --- Comment #11 from Lucas Gass --- Created attachment 98189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98189&action=edit Bug 23533: Reindent patron entry form (memberentrygen.tt) This patch re-indents the template for patron entry/editing. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, create or edit a patron. Test every aspect of the process. At each step the page should work correctly. Including: - Adult patron - Child patron - Organizational patron - Quick patron add - Duplicate patron - With mandatory fields - With 'BorrowerUnwantedField's defined - With ExtendedPatronAttributes enabled Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 --- Comment #43 from David Cook --- (In reply to Martin Renvoize from comment #42) > (In reply to David Cook from comment #39) > > It's too bad there are no unit tests for Koha::Middleware::RealIP. I ended > > up writing a very basic one here just to test that it worked for multiple > > proxies. > > Agreed, but I didn't want to hold up this vital development and we weren't > at all sure how to write such a test.. as it sounds like you've got the > foundations for a test written, please submit it upstream ;) That makes sense. I really am loving this development overall! I'll do a patch for https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538 and write a test for it. It won't be total coverage I suppose, but it should be enough to test the change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20243] ILS-DI CIDR notation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20243 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- Yeah this is definitely a duplicate. Barry, feel free to sign off https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24537 :D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10352] Cataloguing log search mixing itemnumber/bibnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Status|Pushed to master|Pushed to stable Version(s)|20.05.00|20.05.00, 19.11.03 released in|| --- Comment #33 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24394] Typo when adding a new cash register
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24394 Joy Nelson changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|20.05.00|20.05.00, 19.11.03 released in|| CC||j...@bywatersolutions.com --- Comment #5 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24313] XSLT errors should show in the logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24313 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.03 released in|| Status|Pushed to master|Pushed to stable --- Comment #6 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24123] bulkmarcimport.pl doesn't support UTF-8 encoded MARCXML records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24123 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.03 released in|| CC||j...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #10 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23974] hours_between and days_between lack tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Joy Nelson changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.03 released in|| --- Comment #46 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Needs Signoff |Signed Off --- Comment #19 from Victor Grousset/tuxayo --- > I've attempted a rebase of the patch.. > it's not an area I'm all that familiar with so testing is required. - test plan passed - signed off - fixed test plan: TryQueryParser => UseQueryParser - clarified test plan: "enable QueryAutoTruncate" => "set QueryAutoTruncate to auto" As per the uncertainty about regressions, should the ticket status be "In discussion" ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #96167|0 |1 is obsolete|| --- Comment #18 from Victor Grousset/tuxayo --- Created attachment 98188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98188&action=edit Bug 12430 - Truncation disables relevance ranking when not using QueryParser The system preference "QueryWeightFields" is mutually exclusive with the system preference "QueryAutoTruncate" and the * truncation modifier, when not using QueryParser. If you use truncation, relevance won't work anymore. (N.B. Relevance doesn't work probably when using QueryParser, but for a very different reason beyond the current scope of this bug.) This patch adds relevance ranking when using truncation (or basically when QueryWeightFields is disabled). _TEST PLAN_ 1) Turn on "QueryWeightFields" and set "QueryAutoTruncate" to auto 2) Turn off "UseQueryParser" 3) Do a keyword search in the OPAC 4) Note that the results are ordered by biblionumber ascending 5) Apply patch 6) Do the same keyword search in the OPAC 7) Note that the results are never ordered differently (presumably in relevance order :P) If you're a stickler, throw in some warns so that you can see what CCL query is being sent to Zebra. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21357] Filter elisions from index and search terms in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357 --- Comment #35 from Katrin Fischer --- Hi Julian, does it mean it searches the different representations simultanously? I am still not quite sure about 'French specific'. It feels like every catalog containing some French materials would be happy to have "l'avion" work the way you describe - we would. In my experience most catalogs contain records in different languages. I wonder how it would work for English, thinking of words like "can't" or "doesn't". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of Sale page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 David Nind changed: What|Removed |Added Attachment #98035|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 98187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98187&action=edit Bug 24525: Remove SIP payment types from point of sale This patch removes the SIP payments types from displaying in the select options on the point of sale payment page. Test plan: 1) Enable the point of sale feature (EnablePointOfSale + UseCashRegisters system preferences) 2) Add a cash register for a library (Home > Point of sale > Cash registers > New cash register) 3) Go to to the point of sale page and select the 'Payment type' drop down list - you should see these payment types: - Cash - Cash via SIP - Creditcard via SIP2 - Visa via SIP2 4) Apply the patch 5) Refresh the point of sale page 6) Now only Cash should be displayed in the drop down list 7) Sign-off the patch! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of Sale page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
