[Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 --- Comment #25 from David Nind --- Magic! Have tested in Google Chrome and Firefox Developer Edition on Ubuntu 18.04. Everything looks much better - date pickers and upload buttons. While I didn't check all the screens with data pickers, I checked a fair number of them and they all look consistent. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 David Nind changed: What|Removed |Added Attachment #98387|0 |1 is obsolete|| --- Comment #24 from David Nind --- Created attachment 98428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98428=edit Bug 24363: (follow-up) Remove height from input[type='file'] Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 David Nind changed: What|Removed |Added Attachment #97466|0 |1 is obsolete|| --- Comment #22 from David Nind --- Created attachment 98426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98426=edit Bug 24363: Datepicker calendar is not sexy on additem.pl This patch is essentially an alternative to Bug 24181. Instead of trying to make the datepicker inputs match default fields, it defines a default style for text inputs, selects, and textareas. This new default style borrows some from Bootstrap's input styling and some from the Select2 plugin's style. This makes forms like the one on the add item page have unified styling for all fields. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Test as many pages as you can to look for consistent styling of form fields: Patron entry, cataloging (basic and advanced), reports, batch item modification, system preferences, etc. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 David Nind changed: What|Removed |Added Attachment #98366|0 |1 is obsolete|| --- Comment #23 from David Nind --- Created attachment 98427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98427=edit Bug 24363: Do not use the two-value syntax for background-position-x It's not supported by chrome and chromium (inspector says "invalidd property value". See also: https://developer.mozilla.org/en-US/docs/Web/CSS/background-position-x section "Browser compatibility" Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24587] reserve/placerequest.pl is not used anymore and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24587 --- Comment #1 from Julian Maurice --- Created attachment 98425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98425=edit Bug 24587: Remove unused script reserve/placerequest.pl Bug 19618 removed the last place where reserve/placerequest.pl was used and forgot to remove it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24587] reserve/placerequest.pl is not used anymore and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24587 Julian Maurice changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19618] Add 'Club Holds' feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 Julian Maurice changed: What|Removed |Added Blocks||24587 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24587 [Bug 24587] reserve/placerequest.pl is not used anymore and should be removed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24587] New: reserve/placerequest.pl is not used anymore and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24587 Bug ID: 24587 Summary: reserve/placerequest.pl is not used anymore and should be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maur...@biblibre.com Reporter: julian.maur...@biblibre.com QA Contact: testo...@bugs.koha-community.org Depends on: 19618 Bug 19618 removed the last place where reserve/placerequest.pl was used and forgot to remove it. It should be removed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 [Bug 19618] Add 'Club Holds' feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Julian Maurice changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261
Julian Maurice changed:
What|Removed |Added
Attachment #98383|0 |1
is obsolete||
--- Comment #81 from Julian Maurice ---
Created attachment 98424
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98424=edit
Bug 15261: Check if checkout/reserve request overlaps existing reserves
When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.
- A user places a hold from opac whose requested period overlaps with an
existing reserve period => prevent reserve
- A librarian places a hold from staff whose requested period overlaps
with an existing reserve period => Warn librarian (Ask for
confirmation)
- A librarian makes a checkout from staff whose requested period
overlaps with an existing reserve period => Warn librarian (Ask for
confirmation)
Test plan:
Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture
PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod
1 (staff side):
- Place a hold on title (which has only one items) level with start date
and expiration date.
- Place another hold (also title level) with period overlaping this
reserve.
- Check you are warned about an existing reserve
2 (staff side):
- Place a hold on title (which has more than one items) level with start
date and expiration date.
- Place another hold (also title level) with period overlaping this
reserve.
- Check you are NOT warned about an existing reserve. Because it remains
at least one item not reserved.
3 (staff side):
- Place a hold on item level with start date and expiration date.
- Place another hold on item level with period overlaping this reserve.
- Check you are warned about an existing reserve.
4 (opac side):
- Do the same than for staff side. Instead of a warn, reserve is
prevented.
5:
- Place a hold on title (which has only one items) level with start date
and expiration date.
- Try to checkout the unique item from this title with period overlaping
the reserve period.
- Check you are warned about an existing reserve
6:
- Place a hold on title (which has more than one items) level with start
date and expiration date.
- Checkout an item from this title with period overlaping the reserve
period.
- Check you are NOT warned about an existing reserve.
7:
- Place a hold on item level with start date and expiration date.
- Checkout this item period overlaping the reserve period.
- Check you are warned about an existing reserve
8:
- Create a checkout (i.e from ${TODAY} to ${TODAY + 10 days}),
- Place a hold on the same item from ${TODAY + 11 days} to ${TODAY + 30
days}),
- Check that you cannot renew the checkout.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22437] Subsequent authority merges in cron cause biblios to lose authority information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22437 Andreas Roussos changed: What|Removed |Added CC||arouss1...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24586] Double quote escape doesn't work properly in C4::AuthoritiesMarc::SearchAuthorities with QueryParser enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24586 --- Comment #4 from Katrin Fischer --- I've added the omnibus bug for QueryParser - there is a ton of issues with it basically. I think we might deprecate it soon. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24586] Double quote escape doesn't work properly in C4::AuthoritiesMarc::SearchAuthorities with QueryParser enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24586 Katrin Fischer changed: What|Removed |Added Blocks||12742 CC||katrin.fisc...@bsz-bw.de Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12742 [Bug 12742] Omnibus: QueryParser -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12742] Omnibus: QueryParser
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12742 Katrin Fischer changed: What|Removed |Added Depends on||24586 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24586 [Bug 24586] Double quote escape doesn't work properly in C4::AuthoritiesMarc::SearchAuthorities with QueryParser enabled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 --- Comment #3 from Katrin Fischer --- I'll usually just do it - but I noticed it happens quite often now, so trying to get to the root of the issue :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer --- Hi Lucas, can you please update your patch to include a bug description and test plan? I think you might have done it in the git bz attach step - but that doesn't change the patch file itself and it's still empty. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24586] Double quote escape doesn't work properly in C4::AuthoritiesMarc::SearchAuthorities with QueryParser enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24586 --- Comment #3 from David Cook --- I've included a patch that I'm temporarily using as a workaround, but silently failing isn't perfect either. We should probably give the user a report after saving the record saying what happened with the authority linking. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24586] Double quote escape doesn't work properly in C4::AuthoritiesMarc::SearchAuthorities with QueryParser enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24586 --- Comment #2 from David Cook --- Created attachment 98423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98423=edit Bug 24586: Gracefully fail authority lookup if PQF query invalid If Koha's query building has produced an invalid PQF query, don't throw a fatal error. Instead, trap the error, warn, and then skip the authority lookup for that field. Test Plan: I don't really have a good test plan at the moment. Enable AutoCreateAuthorities and BiblioAddsAuthorities maybe, and then try to do a search for 830$a with a value of the following: Bad "query" value -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18127] Add batch modified records to an existing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18127] Add batch modified records to an existing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Aleisha Amohia changed: What|Removed |Added Attachment #60366|0 |1 is obsolete|| --- Comment #4 from Aleisha Amohia --- Created attachment 98422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98422=edit Bug 18127: Add batch modified records to an existing list To test: 1) Start by having no (zero) lists 2) Go to Tools -> Batch record modification 3) Go through the batch record modification process, confirm everything works as normal and there is a link to do a new batch record modification at the end 4) In another tab, go to Lists and create a new list 5) Go back to the first tab and start a new batch modification process 6) At the end of the process, there should be a new option to add modified records to an existing list 7) Select a list from the dropdown and confirm you are able to save your modified records to the list as expected 8) Start a new batch modification process, this time for authorities records 9) At the end confirm there is no option to add modified records to a list, because authorities cannot be added to lists Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24586] Double quote escape doesn't work properly in C4::AuthoritiesMarc::SearchAuthorities with QueryParser enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24586 --- Comment #1 from David Cook --- QueryParser takes this as input: (authtype:UNIF_TITLE) match-heading:"McGraw-Hill \\"Demystified\\" series" #AuthidAsc And it outputs this: @or @attr 1=Local-Number @attr 7=1 0 @and @and @attr 1=authtype @attr 5=100 @attr 4=6 "UNIF_TITLE" @and @attr 1=Match-heading @attr 4=1 @attr 5=100 @attr 6=3 "Demystified"" @attr 1=Match-heading @attr 4=1 @attr 5=100 @attr 6=3 "series\\"" @attr 1=Match-heading @attr 4=1 @attr 5=100 @attr 6=3 "McGraw-Hill \\" Which causes ZOOM::Query::PQF to throw a fatal error: ZOOM error 20003 "can't set prefix query" (addinfo: "@or @attr 1=Local-Number @attr 7=1 0 @and @and @attr 1=authtype @attr 5=100 @attr 4=6 "UNIF_TITLE" @and @attr 1=Match-heading @attr 4=1 @attr 5=100 @attr 6=3 "Demystified"" @attr 1=Match-heading @attr 4=1 @attr 5=100 @attr 6=3 "series\\"" @attr 1=Match-heading @attr 4=1 @attr 5=100 @attr 6=3 "McGraw-Hill \\"") -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24586] New: Double quote escape doesn't work properly in C4::AuthoritiesMarc::SearchAuthorities with QueryParser enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24586 Bug ID: 24586 Summary: Double quote escape doesn't work properly in C4::AuthoritiesMarc::SearchAuthorities with QueryParser enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au Double quote escape doesn't work properly in C4::AuthoritiesMarc::SearchAuthorities with QueryParser enabled -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #24 from Andrew Fuerste-Henry --- Re-checked and re-signed-off. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 --- Comment #1 from Lucas Gass --- Created attachment 98421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98421=edit Bug 24585: Add suggested on/managed on columns This patch adds 2 new columns on the suggestions table on purchase-suggestions.tt. These use the data-order attribute to allow for sorting. TEST PLAN: 1. Have a patron with some suggestions that have been managed by staff. (accept or reject the request). 2. View that patrons suggestions from purchase-suggestions.pl. 3. No suggested on or managaed on columns. 4. Apply patch and reload the page. 5. The new columns are there, have multiple suggestions and make sure sorting by the date works. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 ByWater Sandboxes changed: What|Removed |Added Attachment #98091|0 |1 is obsolete|| --- Comment #23 from ByWater Sandboxes --- Created attachment 98420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98420=edit Bug 23673: Add "Updated on" column to patron's notices This patch adds "Updated on" column to patron's notices tab. It also adds logic to C4::Letters to retrieve updated_on column. To test: 1. Apply patches. 2. Restart plack. 3. Choose a patron and add a purchase suggestion. 4. Change suggestion status. 5. Open patron's notifications. CHECK => Messages table has now "Updated on" and "Time created" columns, and "Time" column is gone. SUCCESS => There is a message with status pending, with a "time created" that equals "updated on" 6. Execute in the shell in Koha directory $ ./misc/cronjobs/process_message_queue.pl 7. Open patron's notifications one more time. SUCCESS => The message changed status. Time created remained the same, and now "updated on" has the current timestamp. 8. Resend the message and repeat sep 6. SUCCESS => Every time you change the status, time created remains the same and updated on updates. 9. prove t/db_dependant/Letters.t 10. Sign off Signed-off-by: Kelly McElligott Signed-off-by: Kelly McElligott Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 ByWater Sandboxes changed: What|Removed |Added Attachment #98090|0 |1 is obsolete|| --- Comment #22 from ByWater Sandboxes --- Created attachment 98419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98419=edit Bug 23673: change db structure Signed-off-by: Kelly McElligott Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24585] New: Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Bug ID: 24585 Summary: Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When looking a specific patrons suggestions from pat_purchase_suggestions.tt it would be nice if there were columns for 'Managed on' date and 'Suggested on' date which could sort by these dates. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #24 from David Cook --- (In reply to Katrin Fischer from comment #23) > I'd argue it's still a very bad bug and Elastic not ready yet for wide use > yet (thinking of libraries without IT experts and support especially). As it > breaks things when NOT using QueryParser, there is no link to that. It hurts > a lot of our libraries and is very hard to figure out - I think we shoudl > really fix it. The sole reason it was not fixed yet is probably people are > scared of Search.pm. I'm not scared but there's no time/money for me to work on fixing it :/. In my opinion, Search.pm is really really bad, and fixing it would be a very time-consuming exercise. (I suppose part of the time-consuming part would be finding a lack of people wiling to test/QA because of fear of Search.pm though that's true...) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Bernardo Gonzalez Kriegel changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |bgkrie...@gmail.com |ity.org | CC|frede...@tamil.fr | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24584] New: Rewrite optional installation files to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Bug ID: 24584 Summary: Rewrite optional installation files to YAML Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: bgkrie...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr A complete rewrite of optional instalation files from SQL to YAML is presented, one patch for each file, the result could be squashed. The goal is to allow the translation of the installation files -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 98415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98415=edit Bug 24583: Rewrite mandatory/class_sources to YAML YAML version of mandatory class_sources To test: 1) Same test plan of first patch, only check tables class_sort_rules, class_split_rules and class_sources -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 98416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98416=edit Bug 24583: Rewrite mandatory/sample_frequencies to YAML YAML version of mandatory sample_frequencies To test: 1) Same test plan of first patch, only check table subscription_frequencies -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 --- Comment #5 from Bernardo Gonzalez Kriegel --- Created attachment 98418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98418=edit Bug 24583: Rewrite mandatory/sample_numberpatterns to YAML YAML version of mandatory sample_numberpatterns To test: 1) Same test plan of first patch, only check table subscription_numberpatterns -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 98414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98414=edit Bug 24583: Rewrite mandatory/auth_values to YAML YAML version of mandatory auth_values. To test: 1) Do a clean install, dump auth_values, reserve. 2) Apply this patch and it's dependencies 3) Do a clean install, dump again and compare No differences expected 4) Try translation a) Go to misc/translator b) create files for a new language ./translate create xx-YY c) Check new file po/xx-YY-instaler.po Verify strings from this file. d) Install new language ./translate install xx-YY e) Try clean install with new files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 98417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98417=edit Bug 24583: Rewrite mandatory/sample_notices to YAML YAML version of mandatory sample_notices To test: 1) Same test plan of first patch, only check table letter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24410] Multi holds broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Agustín Moyano changed: What|Removed |Added CC||agustinmoy...@theke.io --- Comment #6 from Agustín Moyano --- (In reply to Jonathan Druart from comment #5) > From Nick on bug 24571 > > """ > In the staff client do a search that returns 20+ results that can be held > > Select all > > Place hold > > Confirm > > The api submits ~8 requests, then the page moves to the hold results, but > not alll records are held > > > While this does work in Chrome, there is no feedback as to what is happening > - the submit button is not disabled. Testing with 200 holds there is a lot > of waiting with no feedback > """ I'm thinking.. is there any RFC for bulk processing endpoints?.. maybe we can create an endpoint that does multiholds. What do You think Jonathan? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC|frede...@tamil.fr | Assignee|koha-b...@lists.koha-commun |bgkrie...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24583] New: Rewrite mandatory installation files to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Bug ID: 24583 Summary: Rewrite mandatory installation files to YAML Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: bgkrie...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr A complete rewrite of mandatary instalation files from SQL to YAML is presented, one patch for each file, the result could be squashed. The goal is to allow the translation of the installation files. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #78 from Katrin Fischer --- Hi George, I think an option to clean it is not in question, I just think we should not tie it to the same 'switch' - so libraries can make the decision to delete both tables after a different number of days. This change as proposed currently would not only affect the cronjob. The method changed is used in different areas: - batch_anonymise.pl cronjob - When using the batch anonymize feature tool in the staff interface - When a patron decides to delete their reading history from the OPAC (OpacPrivacy etc.) So if I know I just returned a damaged book via the self check... I could delete my reading history from the OPAC. Info might still be retrievable somewhere, but I feel StoreLastPatron should be covering that use case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org --- Comment #77 from George Williams (NEKLS) --- NEKLS is sponsoring the development of this cronjob. Currently we have StoreLastBorrower turned on because we want the last borrower information stored if patron privacy is anonymized. We also have a cron running that prunes old_issues more than 400 days old so that all patron data is effectively anonymized after about 13 months. But we are not pruning items_last_borrower because staff at many of our libraries want the last borrower information saved on the item record if the item was lost. This means that we are currently anonymizing patron data in old_issues after it's 400 days old and never anonymizing that same data in items_last_borrower for the sake of the libraries that want that data saved for lost items. So for us the point of this cronjob is to prune items_last_borrower once the data is more than 400 days old which is in line with the other pruning we're already doing but it will make an exception if the item has a lost status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24582] Cloning circ rules does not maintain checkouts allowed or on-site checkouts allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24582 Andrew Fuerste-Henry changed: What|Removed |Added CC||daniel.gaghan@pueblolibrary ||.org, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24582] New: Cloning circ rules does not maintain checkouts allowed or on-site checkouts allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24582 Bug ID: 24582 Summary: Cloning circ rules does not maintain checkouts allowed or on-site checkouts allowed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When cloning circ rules to a branch, Koha clones the issuingrules table but not the circulation_rules table. That means all the created rules have Unlimited for number of checkouts and onsite checkouts allowed. That's not great. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24581] New: DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.privacy_guarantor_fines' in 'field list' at /usr/share/koha/lib/Koha/Objects.pm line 92
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24581 Bug ID: 24581 Summary: DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.privacy_guarantor_fines' in 'field list' at /usr/share/koha/lib/Koha/Objects.pm line 92 Change sponsored?: --- Product: Koha Version: 19.11 Hardware: HP OS: Linux Status: NEW Severity: blocker Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs@lists.koha-community.org Reporter: rajofigue...@yahoo.com QA Contact: testo...@bugs.koha-community.org In upgrading Koha I.L.S. from koha 19.05 to koha 19.10.2. I installe koha 19.10 en my laptop envy hp, in Debian 10 buster, and everything was ok. But whan I bring tried to change the new database with the old one , it give me that error mesage DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.privacy_guarantor_fines' in 'field list' at /usr/share/koha/lib/Koha/Objects.pm line 92 An in the OPAC : Software error: Template process failed: undef error - DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.reset_password' in 'field list' at /usr/share/koha/lib/Koha/Objects.pm line 269 Please some hep needed. Thanks a lot Lic. Ramon Figueroa, from caracas, Venezuea -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19419] 008 Material type reverts Book
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19419 Myka Kennedy Stephens changed: What|Removed |Added CC||mkstephens@lancasterseminar ||y.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24338] CASH is missing from the default payment_types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 David Nind changed: What|Removed |Added Attachment #98388|0 |1 is obsolete|| --- Comment #10 from David Nind --- Created attachment 98413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98413=edit Bug 24338: (QA follow-up) Make update idempotent Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24338] CASH is missing from the default payment_types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 David Nind changed: What|Removed |Added Attachment #98381|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 98412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98412=edit Bug 24338: Add 'CASH' to default 'PAYMENT_TYPE' AV Bug 23321 adds cash registers to the koha accounts system and as part of that work introduces the 'CASH' payment type as a required option to allow requirment of a 'CASH_REGISTER' when making cash payments. The original patchset, however, forgot to add this new authorised value during installation and upgrade. Test plan: 1) Check the values shown for the PAYMENT_TYPE authorized value category (Home > Administration > Basic parameters > Authorized values) 2) There should be no CASH authorized value 3) Apply the patch 4) Run the database update (perl installer/data/mysql/updatedatabase.pl) 5) Refresh the PAYMENT_TYPE authorized value page 6) A CASH authorized value should now be one of the values 7) Sign-off! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24338] CASH is missing from the default payment_types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #14 from Martin Renvoize --- Thanks for the clarifications guys.. it's a real action at a distance issue I see.. hmm, I agree it would be best to strip out the behaviour from the accounts code and push it up a level into the controllers really. I'll have a go at that when I'm fresh tomorrow.. unless anyone else wants to give it a punt.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #13 from Chris Cormack --- Thats right, you have an item that is marked lost. But the library wants that to stay on the persons card. Not be removed, so it is still out to them. Then if you renew that item, * then that makes it no longer lost - correct * removes the charge - correct - Now the code goes on, there is a paid charge for lost, I will return it - not correct IE when you renew a lost item, the code in the accounts now returns it, because it has a paid for charge. I feel like having circulation actions inside the accounts module is a bad thing anyway, but certainly creates unexpected (and wrong) behaviour in this case -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 Martin Renvoize changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10532] koha-run-backups option --output doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10532 --- Comment #7 from Magnus Enger --- What it is the right approach here? 1. Create the directory indicated by --output if it does not exist 2. Check if the directory indicated by --output exists, and exit if it does not -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #12 from Katrin Fischer --- WhenLostChargeReplacementFee DefaultLongOverdueChargeValue MarkLostItemsAsReturned Are the ones I am thinking of. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #11 from Katrin Fischer --- .. or maybe they just don't charge a fee. (no lost charge). I really wish our lost handling options were less confusing and more in one spot. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #10 from Katrin Fischer --- From what I understand: - the LOST charge is applied, but the library decided to not auto-return the item (config wise) - then renewing the item returns it I'll have to give this a go in testing, but I think we need to verify and try stuff here. Would be great to get a step by step by Aleisha if possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #23 from Katrin Fischer --- (In reply to Martin Renvoize from comment #22) > De-escalating this one.. it's been around for 6 years and hasn't really > recieved the attention a critical should.. I personally feel at the time it > was critical and it's still a nice to fix.. but as we're moving toward > elastic search and possible deprecating QueryParser entirely I'm not sure > how to progress this bug. I'd argue it's still a very bad bug and Elastic not ready yet for wide use yet (thinking of libraries without IT experts and support especially). As it breaks things when NOT using QueryParser, there is no link to that. It hurts a lot of our libraries and is very hard to figure out - I think we shoudl really fix it. The sole reason it was not fixed yet is probably people are scared of Search.pm. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24580] Allow patron_emailer or parallel structure to generate custom print notices from report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24580 Andrew Fuerste-Henry changed: What|Removed |Added CC||k...@bywatersolutions.com, ||lu...@bywatersolutions.com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24580] New: Allow patron_emailer or parallel structure to generate custom print notices from report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24580 Bug ID: 24580 Summary: Allow patron_emailer or parallel structure to generate custom print notices from report output Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Bug 16149 adds the ability to combine report results with a custom notice to generate emails. Many libraries do not reliably have email addresses for their patrons and could use a method to generate print notices. This could be a failover from email to print (as overdues do) or a separate cron. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24347] Add a 'search to order' option similar to 'search to hold'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 --- Comment #17 from Katrin Fischer --- (In reply to Jonathan Druart from comment #16) > Would it make sense to have the "Add order" link a bit more visible? As you have to start from the basket I don't mind the current display - people will be looking for the link. But open to ideas, what were you thinking of? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Martin Renvoize changed: What|Removed |Added Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Martin Renvoize changed: What|Removed |Added Component|Websites, Mailing Lists,|Web services |etc | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474
--- Comment #9 from Martin Renvoize ---
(In reply to Jonathan Druart from comment #7)
> I gave a try to this, wrote the test then try to fix it.
>
> But my understanding of the code leads me to abandon. I do not understand
> why there are 3 calls to ReturnLostItem:
>
> Koha/Account.pm:C4::Circulation::ReturnLostItem(
> $self->{patron_id}, $fine->itemnumber ) unless $checkout;
> Koha/Account.pm:C4::Circulation::ReturnLostItem(
> $self->{patron_id}, $fine->itemnumber ) unless $checkout;
> Koha/Account/Line.pm:C4::Circulation::ReturnLostItem(
> $self->borrowernumber, $debit->itemnumber );
>
> That seems wrong to me.
>
> So I guess my test will not cover all the cases. Hope it could help as a
> start anyway.
Not sure I understand what you tried here Jonathan.. looking like you're simply
adding a second check to see if the item is still checked out before returning
it..
I think we need clarification on the requested behaviour before continuing
here.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #8 from Martin Renvoize --- (In reply to Aleisha Amohia from comment #0) > This was a bug introduced by Bug 22982. > > "Hey all, this patch is causing problems for some of our libraries because > it's been assumed that lost items with no attached charge should > automatically be returned. I don't understand what you mean by this.. the code in bug 22982 only applies to LOST charges.. I'm not sure I can see how items are being returned when no lost item charge is attached in the first place? > This is not always the desired behaviour - we have one case where the > library wants to keep lost items on a patron's record, and another case > where a checked out lost item will be renewed, but the amount outstanding is > zero, so the item gets returned. So, this is where there are LOST charges being applied right? Instead of automatically returning the item on lost charge payment we want to allow for configurable state changes instead.. or am I misunderstanding the problem/request? > > These are edge cases, but the assumptions in this patch do not consider > them, and are causing problems. Is there a workaround? Or perhaps a better > way of doing this patch that can allow for the cases of 'renewing a lost > item' or 'wanting to keep a lost item on the checkouts record'? A solution > that avoids doing circulation actions in the accounts modules as this patch > does would be ideal." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22302] ITEMTYPECAT description doesn't fall back to description if OPAC description is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22302 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #7 from Andrew Fuerste-Henry --- Amended test plan: 1 create an authorized value in the ITEMTYPECAT category, give it a description but not a description (OPAC) 2 connect an item type to your category 3 go to the advanced search page on the OPAC 4 see a radio button with no label 5 apply patch 6 reload OPAC adv search page 7 radio button has a label 8 go back to authorized values and add a Description (OPAC) that does not match Description 9 Reload OPAC and see that your radio button shows Description (OPAC) Signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22302] ITEMTYPECAT description doesn't fall back to description if OPAC description is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22302 ByWater Sandboxes changed: What|Removed |Added Attachment #98395|0 |1 is obsolete|| --- Comment #5 from ByWater Sandboxes --- Created attachment 98410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98410=edit Bug 22302: Unit tests Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Benjamin Daeuber changed: What|Removed |Added CC||bdaeu...@cityoffargo.com --- Comment #34 from Benjamin Daeuber --- (In reply to Christopher Brannon from comment #31) > (In reply to Jonathan Druart from comment #30) > > Christopher, could you add your stamp on Kyle's follow-up? > > I tested master without the patch, and the hold is routed properly. > Something has changed. I don't know if it is Owen's work on the modal, but > it seems to be working properly without the patch. Can anyone confirm? The problem is still occurring on master for me. However, I am getting the same error as Lisette when testing the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22302] ITEMTYPECAT description doesn't fall back to description if OPAC description is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22302 ByWater Sandboxes changed: What|Removed |Added Attachment #98396|0 |1 is obsolete|| --- Comment #6 from ByWater Sandboxes --- Created attachment 98411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98411=edit Bug 22302: Make ITEMTYPECAT descriptions fallback to lib description if no opac description Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22302] ITEMTYPECAT description doesn't fall back to description if OPAC description is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22302 --- Comment #4 from Andrew Fuerste-Henry --- Test plan: - create an authorized value in the ITEMTYPECAT category, give it a description but not a description (OPAC) - connect an item type to your category - go to the advanced search page on the OPAC - see a radio button with no label - apply patch - reload OPAC adv search page - radio button has a label -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #18 from Martin Renvoize --- Followup pushed, thanks Jonathan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 --- Comment #17 from Jonathan Druart --- Created attachment 98409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98409=edit Bug 23533: Remove spaces after/before the open/close parenthesis t/db_dependent/selenium/patrons_search.t is failing because of this change: # got: 'Koha › Patrons › Modify patron fir's"tname \123 ❤ test_patron_1 ( iOVAoJj )' # expected: 'Koha › Patrons › Modify patron fir's"tname \123 ❤ test_patron_1 (iOVAoJj)' We are adding space after and before the open/close parenthesis of the category code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #161 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #16 from Jonathan Druart --- t/db_dependent/selenium/patrons_search.t is failing because of this change: # got: 'Koha › Patrons › Modify patron fir's"tname \123 ❤ test_patron_1 ( iOVAoJj )' # expected: 'Koha › Patrons › Modify patron fir's"tname \123 ❤ test_patron_1 (iOVAoJj)' We are adding space after and before the open/close parenthesis of the category code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #159 from Jonathan Druart --- Created attachment 98407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98407=edit Bug 18936: Display 'Unlimited' for Holds allowed (total) holds_per_day and reservesallowed are set to unlimited in the rules inserted by misc4dev -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #160 from Jonathan Druart --- Created attachment 98408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98408=edit Bug 18936: Fix selenium/administration_tasks.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-c
||ommunity.org
--- Comment #7 from Jonathan Druart
---
I gave a try to this, wrote the test then try to fix it.
But my understanding of the code leads me to abandon. I do not understand why
there are 3 calls to ReturnLostItem:
Koha/Account.pm:C4::Circulation::ReturnLostItem(
$self->{patron_id}, $fine->itemnumber ) unless $checkout;
Koha/Account.pm:C4::Circulation::ReturnLostItem(
$self->{patron_id}, $fine->itemnumber ) unless $checkout;
Koha/Account/Line.pm:C4::Circulation::ReturnLostItem(
$self->borrowernumber, $debit->itemnumber );
That seems wrong to me.
So I guess my test will not cover all the cases. Hope it could help as a start
anyway.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18155] Add useful classes to the rows of checkouts table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18155 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22302] ITEMTYPECAT description doesn't fall back to description if OPAC description is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22302 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22302] ITEMTYPECAT description doesn't fall back to description if OPAC description is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22302 --- Comment #3 from Nick Clemens --- Created attachment 98396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98396=edit Bug 22302: Make ITEMTYPECAT descriptions fallback to lib description if no opac description -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22302] ITEMTYPECAT description doesn't fall back to description if OPAC description is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22302 --- Comment #2 from Nick Clemens --- Created attachment 98395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98395=edit Bug 22302: Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24485] Sys Pref AllowHoldPolicyOverride will not Staff override a Holds Per Record Rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 Martin Renvoize changed: What|Removed |Added Attachment #98038|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 98394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98394=edit Bug 24485: Allow hold when some can be overridden The check to see if we can place a hold counts the number that we can override vs the number of items on the record. We cannot override if we already have a hold on an item, however, we don't count these to see if they plus the number of overrides equal the items on the record. To test: 1 - Set max reserves to 2, allow 2 holds per recrod 2 - Place 2 holds for a patron on some records 3 - Find another record with 2 items 4 - Place a hold on the first item, you will be notified about the limit but you can override 5 - Attempt to place hold on second item, cannot be done, button disabled 6 - Apply patch 7 - Repeat 8 - You can place the second hold Signed-off-by: Kelly McElligott Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24485] Sys Pref AllowHoldPolicyOverride will not Staff override a Holds Per Record Rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Code scans well and does whats expected.. simple improvement and passes qa scripts.. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24485] Sys Pref AllowHoldPolicyOverride will not Staff override a Holds Per Record Rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 Martin Renvoize changed: What|Removed |Added Patch complexity|--- |Trivial patch CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #5 from Jonathan Druart --- Created attachment 98392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98392=edit Bug 24474: Add tests This does the following using the interface: - Unselect all the options from MarkLostItemsAsReturned - Check an item out - Create a manual invoice LOST for the checked in item - Pay the fine (Make a payment> Pay > Confirm) - Renew the item => Item is checked in (NOT EXPECTED) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #6 from Jonathan Druart --- Created attachment 98393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98393=edit Bug 24474: A try This does not work -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 Martin Renvoize changed: What|Removed |Added Severity|critical|normal --- Comment #22 from Martin Renvoize --- De-escalating this one.. it's been around for 6 years and hasn't really recieved the attention a critical should.. I personally feel at the time it was critical and it's still a nice to fix.. but as we're moving toward elastic search and possible deprecating QueryParser entirely I'm not sure how to progress this bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #21 from Martin Renvoize --- (In reply to Jonathan Druart from comment #17) > (In reply to Martin Renvoize from comment #16) > > I've attempted a rebase of the patch.. it's not an area I'm all that > > familiar with so testing is required. > > Reading previous comments it seems that this patch will introduce > regressions. I think there are regressions for specific versions of zebra.. but I also felt that relevance issues outweighted the regressions introduced. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23391] Hide finished ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391 Andrew Isherwood changed: What|Removed |Added Attachment #98390|0 |1 is obsolete|| --- Comment #10 from Andrew Isherwood --- Created attachment 98391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98391=edit Bug 23391 - Hide finished ILL requests Currently, the main table of ILL requests will display all ILL requests in the database, regardless of their status. For libraries with active ILL this quickly leads to a lot of requests being displayed, and the main page of the ILL module taking a long time to load. This patch proposes to fix this by introducing the ILLHiddenRequestStatuses syspref, which can take a pipe-separated list of ILL statuses that will be hidden from view in the ILL module. This means that the only way to find a hidden request will be through a report. To test: - Apply the patch and make sure the atomic database update is run - Make sure you have a few ILL requests, with at least two different statuses - Check that all requests are still displayed in the main table of ILL requests - Add one of the statuses* you have in your database to the ILLHiddenRequestStatuses syspref, reload the ILL module frontpage and verify that requests with the given status are not displayed - Change the syspref to another status and verify requests with that status are now hidden - Change the syspref to hold both statuses, separated by the pipe symbol (e.g.: A|B). Verify that no requests with the given statuses are now displayed - Run the ILL REST API tests, e.g.: $ sudo koha-shell -c "prove t/db_dependent/api/v1/illrequests.t" kohadev * = The ILLHiddenRequestStatuses syspref should hold status codes, like "REQ" and "NEW", not their human readable counterparts. Signed-off-by: Andrew Isherwood -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23391] Hide finished ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391 Andrew Isherwood changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11420] Patron preference to restrict staff from changing location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11420 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24338] CASH is missing from the default payment_types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Martin Renvoize changed: What|Removed |Added Blocks|24525 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 [Bug 24525] Hide SIP payment types from the Point of Sale page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of Sale page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 Martin Renvoize changed: What|Removed |Added Depends on|24338 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 [Bug 24338] CASH is missing from the default payment_types -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23391] Hide finished ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391 --- Comment #9 from Magnus Enger --- New version of the patch is without the cleanup. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23391] Hide finished ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391 Magnus Enger changed: What|Removed |Added Attachment #96222|0 |1 is obsolete|| --- Comment #8 from Magnus Enger --- Created attachment 98390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98390=edit Bug 23391 - Hide finished ILL requests Currently, the main table of ILL requests will display all ILL requests in the database, regardless of their status. For libraries with active ILL this quickly leads to a lot of requests being displayed, and the main page of the ILL module taking a long time to load. This patch proposes to fix this by introducing the ILLHiddenRequestStatuses syspref, which can take a pipe-separated list of ILL statuses that will be hidden from view in the ILL module. This means that the only way to find a hidden request will be through a report. To test: - Apply the patch and make sure the atomic database update is run - Make sure you have a few ILL requests, with at least two different statuses - Check that all requests are still displayed in the main table of ILL requests - Add one of the statuses* you have in your database to the ILLHiddenRequestStatuses syspref, reload the ILL module frontpage and verify that requests with the given status are not displayed - Change the syspref to another status and verify requests with that status are now hidden - Change the syspref to hold both statuses, separated by the pipe symbol (e.g.: A|B). Verify that no requests with the given statuses are now displayed - Run the ILL REST API tests, e.g.: $ sudo koha-shell -c "prove t/db_dependent/api/v1/illrequests.t" kohadev * = The ILLHiddenRequestStatuses syspref should hold status codes, like "REQ" and "NEW", not their human readable counterparts. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23391] Hide finished ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391 --- Comment #7 from Magnus Enger --- (In reply to Andrew Isherwood from comment #6) > I'm just not sure what it gives us other than potentially breaking the > matching. I think we have to trust users to be able to enter the status > codes without messing them up. Of course, I could be entirely missing your > intention with the cleanup! I'm not sure myself, any longer... I'll do a revised patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23391] Hide finished ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391 --- Comment #6 from Andrew Isherwood --- (In reply to Magnus Enger from comment #5) > (In reply to Andrew Isherwood from comment #4) > So do you think I should get rid of the cleanup? I'm just not sure what it gives us other than potentially breaking the matching. I think we have to trust users to be able to enter the status codes without messing them up. Of course, I could be entirely missing your intention with the cleanup! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24579] Add the ability to email the Cart contents without Logging into Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24579 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- I remember poking at this once before, but cannot find the existing bug. Wherever it is, that bug raises the concern that emailing the cart without logging in opens the possibility of koha being used to send bot spam. That's a solvable problem, but a complication. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24577] API schema merging breaks with older versions of JSON module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24577 --- Comment #2 from Andrew Isherwood --- Sounds like a possibility. Though I think we'd have to audit all 172 uses of the JSON module and ensure that a) Mojo::JSON fulfils all requirements (JSON does a lot) and b) has an straightforward migration path -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
