[Koha-bugs] [Bug 13193] Make Memcached usage fork safe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Joonas Kylmälä changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #55 from Joonas Kylmälä --- The fix looks good but commit message title doesn't tell what the bug does (https://wiki.koha-community.org/wiki/Commit_messages#Good_commit_messages_2). Mason, if you could just move the "update debian/control file" to the title and maybe add a body describing why it needed to be updated would be great! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13193] Make Memcached usage fork safe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 --- Comment #56 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #55) > The fix looks good but commit message title doesn't tell what the bug does oh, I was supposed to write it doesn't tell what the patch does. The problem is that it tells what the bug is. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||da...@davidnind.com --- Comment #12 from David Nind --- This all works as expected for the file name changes - with the default of marc, and when changing the file name. However, the content when authority records are exported as XML is in MARC format, rather than XML (this works correctly before the patch is applied). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22890] Add a chronological changelog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890 --- Comment #12 from Martin Renvoize --- I still think maintaining this inside Bugzilla and pulling it into a changelog.md file for each release is the way to go... I'd maintain it in a file with every commit/patchset if we were only supporting one definitive version/branch of Koha but as we're continually supporting at least 3 versions in parallel I think ensuring it's properly chronological would be difficult in commits.. An example would be with almost any bug.. it's is the rmaints decision whether the bug is a required backport and as such the RM doesn't know at the time of his/her push what version this bug is going to appear in.. as such they would put it under their version, and when the rmaints backported the rm would then need to forward port a second patch to get move the change down the changelog to get the chronology right again. By maintaining this in bugzilla we already have scripts to add koha version into the relevant fields at the time of push and also have tools that pull out the release notes fields for release note built at release.. so we could have a clear way of getting the chronology correct at release time. As for the format, the keepachangelog seems great to me.. I wouldn't be against having two distinct fields in bugzilla.. one for librarian facing release notes and one for developer-facing notes as they're often rather different use cases. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22890] Add a chronological changelog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890 --- Comment #13 from Martin Renvoize --- In fact, I'd go so far as to say it might be nice to filter out a fair bit of the existing data that goes into the release notes.. I don't think librarian end users actually need/want to see a record of every single 'bug' that's made it into a release.. especially at the moment whilst there's lots of architectural bugs going in that don't really affect end users. By having the two distinct fields we could more easily direct the information to the right people. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of Sale page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 --- Comment #5 from Martin Renvoize --- Created attachment 98548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98548&action=edit Bug 24525: (follow-up) Factor out to an include -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of Sale page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 Martin Renvoize changed: What|Removed |Added Attachment #98187|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 98547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98547&action=edit Bug 24525: Remove SIP payment types from point of sale This patch removes the SIP payments types from displaying in the select options on the point of sale payment page. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of Sale page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 --- Comment #6 from Martin Renvoize --- Followup as requested.. I should just have done it this way in the first place :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22890] Add a chronological changelog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890 --- Comment #14 from Julian Maurice --- (In reply to Martin Renvoize from comment #12) > I still think maintaining this inside Bugzilla and pulling it into a > changelog.md file for each release is the way to go... I'd maintain it in a > file with every commit/patchset if we were only supporting one definitive > version/branch of Koha but as we're continually supporting at least 3 > versions in parallel I think ensuring it's properly chronological would be > difficult in commits.. > > An example would be with almost any bug.. it's is the rmaints decision > whether the bug is a required backport and as such the RM doesn't know at > the time of his/her push what version this bug is going to appear in.. as > such they would put it under their version, and when the rmaints backported > the rm would then need to forward port a second patch to get move the change > down the changelog to get the chronology right again. I don't think the forward port would be needed. Each stable branch would have its own changelog. For instance, if you are on 19.11.x Changelog would contain: # Unreleased - bugfix X - ... # 19.11.01 - bugfix Y - ... #19.11.00 And on master you would have # Unreleased - bugfix X - bugfix Y - ... # 19.11.00 I think it would be confusing to have bugfixes referenced twice or more in the same file (once for master, once for stable, once for oldstable, ...). Stable branches live their own life and I think it's ok if only them contain the changes for minor releases. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22890] Add a chronological changelog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890 --- Comment #15 from Martin Renvoize --- I don't think I explained myself well.. you've actually basically highlighted my point. I don't want bugs to appear twice at all.. I'd want them to appear once and only once and at the earliest point that they were added to the codebase. I'm thinking of upgrades from one mid-point release.. say a 17.05.04 to another mid-point release in the next major version, say 18.11.08. The Changelog should simply list all changes between those two versions in order and you shouldn't have to refer to different files from the different branches. Does that make more sense? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23210] login4tags should be a link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Version(s)|19.11.00,19.05.04 |19.11.00,19.05.04, 18.11.10 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24604] Add 'Pay' button under Transactions tab in patron accounting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24604 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24604] Add 'Pay' button under Transactions tab in patron accounting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24604 David Nind changed: What|Removed |Added Attachment #98538|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 98549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98549&action=edit Bug 24604: Add 'Pay' button under Transactions tab in patron accounting It does the same thing as the 'Pay' button under 'Make a payment' tab. It is nothing more than a shortcut. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13193] Make Memcached usage fork safe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment #57 from Martin Renvoize --- Sorry Joonas, I think I've confused the issue here.. Mason just did the packaging of the requisit dependancy for me at my request.. the bug itself was already PQA. You are indeed correct regarding the commit message of the followup.. but I'll just fix that on push now we have the dependancy packaged and on our repository. Many thanks for taking a look though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13193] Make Memcached usage fork safe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Mason James changed: What|Removed |Added Attachment #98546|0 |1 is obsolete|| --- Comment #58 from Mason James --- Created attachment 98550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98550&action=edit Bug 13193: Add new module to debian/control file this patch adds the new module to the debian/control file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13193] Make Memcached usage fork safe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Mason James changed: What|Removed |Added Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13193] Make Memcached usage fork safe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13193] Make Memcached usage fork safe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13193] Make Memcached usage fork safe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 --- Comment #59 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13193] Make Memcached usage fork safe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24607] New: XSLT output should be listed in MARC tag order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24607 Bug ID: 24607 Summary: XSLT output should be listed in MARC tag order Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: david.robe...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl It would be useful if the (e.g.) MARC21slim2OPACDetail.xsl template displayed the fields in numeric MARC tag order, for example 100, 110, 245, 246, 260, 300, etc. At the moment, it seems fairly random, e.g. 505, 583, 508, 586, 773, 511 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22890] Add a chronological changelog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890 --- Comment #16 from Julian Maurice --- (In reply to Martin Renvoize from comment #15) > Does that make more sense? Yep. After re-reading your original comment I see what I misunderstood. Sorry :) But still... there is no "earliest point" for a particular bug. We have several different timelines. Let's take an example: - I install Koha 19.11.00 on release day - I wait a few months, in the meantime bugfixes are backported to 19.11.x, some of which are also backported to 19.05.x. - On the next 19.11.x release, changelog entries for bugs that have been pushed to 19.05.x are moved down to the corresponding 19.05.x release. - Now I want to update and see what changed between 19.11.00 and 19.11.06. Problem: the changelog will not be complete because some entries are under 19.05.x section instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22890] Add a chronological changelog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890 --- Comment #17 from Julian Maurice --- (In reply to Martin Renvoize from comment #13) > In fact, I'd go so far as to say it might be nice to filter out a fair bit > of the existing data that goes into the release notes.. I don't think > librarian end users actually need/want to see a record of every single 'bug' > that's made it into a release.. especially at the moment whilst there's lots > of architectural bugs going in that don't really affect end users. I did not answer to that, but I totally agree with you. I'm not sure if we should have several changelog/release notes for specific audience, but each different kind of users (end-users, sysadmins, developers, ...) should be able to find useful infos quickly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24607] XSLT output should be listed in MARC tag order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24607 Fiona Borthwick changed: What|Removed |Added CC||fiona.borthwick@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24607] XSLT output should be listed in MARC tag order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24607 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi David, I am not sure if this would work a general rule - an example would be the 700, 710, 711, etc. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||da...@davidnind.com --- Comment #12 from David Nind --- Patch no longer applies. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24607] XSLT output should be listed in MARC tag order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24607 --- Comment #2 from David Roberts --- No, I agree that the 1XX and 7XX fields are currently a complication that might make it difficult to implement 100%. I still think that it is expected that the fields are in the correct order though, and librarians new to Koha often query why this is not the case. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24607] XSLT output should be listed in MARC tag order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24607 --- Comment #3 from Fiona Borthwick --- I have just completed training for a new customer and they requested that the 700 fields display after the 650 Subjects and questioned why some other fields seemed to be out of numerical order. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603 David Nind changed: What|Removed |Added Attachment #98534|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 98551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98551&action=edit Bug 24603: Allow to cancel charges in patron accounting There is already a button to void a payment. It should be possible to cancel a charge too. This patch adds a button in patron's accounting section (Transactions tab) that allow to cancel charges. Charges that have been fully or partially paid cannot be cancelled. It also fixes Koha::Account::Line::is_credit by looking at credit_type_code instead of amount (amount can be 0 for voided payments) It also fixes the tests for Koha::Account::Line::void when database does not contain the borrowernumber 51 (the default in t::lib::Mocks::mock_userenv) Test plan: 1. Go to a patron's accounting section 2. Create a manual invoice 3. In Transactions tab, you should see a 'Cancel charge' button. Click on it. It should now be marked as cancelled 4. Create another manual invoice 5. Pay it (partially or fully) 6. Notice that the 'Cancel charge' button is not available 7. Void the payment 8. 'Cancel charge' button is available again. Click on it and verify that it still works 9. prove t/db_dependent/Koha/Account/Lines.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24608] New: Allow modification of checkout due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 Bug ID: 24608 Summary: Allow modification of checkout due date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherw...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Currently it is not possible to modify a checkout's due date. This bug proposes to allow such an action. It is only proposed to allow modification of a due date *forward* at this stage as moving a due date backwards may involve additional complication that will require further thought. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24608] Allow modification of checkout due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 Andrew Isherwood changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24608] Allow modification of checkout due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 Andrew Isherwood changed: What|Removed |Added Depends on||24609 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 [Bug 24609] Add routes for getting and setting checkout due date -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24609] New: Add routes for getting and setting checkout due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609
Bug ID: 24609
Summary: Add routes for getting and setting checkout due date
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: REST API
Assignee: koha-bugs@lists.koha-community.org
Reporter: andrew.isherw...@ptfs-europe.com
To allow the work in bug 24608 to proceed, we need an API route to allow the
setting of a checkout's due date. I will add a GET route also.
The proposed endpoints are:
Return a checkout's due date:
Method: GET
URL: /checkouts/{checkout_id}/date_due
Set a checkout's due date:
Method: POST
URL: /checkouts/{checkout_id}/date_due
Body: { date_due: '2020-02-07 10:49:08' }
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24609] Add routes for getting and setting checkout due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Andrew Isherwood changed: What|Removed |Added Blocks||24608 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 [Bug 24608] Allow modification of checkout due date -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24610] New: Let user switch between 'Pay' and 'Write off' mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24610 Bug ID: 24610 Summary: Let user switch between 'Pay' and 'Write off' mode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: julian.maur...@biblibre.com Reporter: julian.maur...@biblibre.com QA Contact: testo...@bugs.koha-community.org In patron's accounting section, under 'Make a payment' tab, you have the choice between 'Pay' and 'Write off'. It takes you to another form, but once there you cannot change mode. You have to click on Cancel, re-select the lines you had selected (if you made a selection) and click on the right button. This bug will add a way to switch between 'Pay' and 'Write off' mode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24610] Let user switch between 'Pay' and 'Write off' mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24610 --- Comment #2 from Julian Maurice --- Created attachment 98553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98553&action=edit Bug 24610: Compiled CSS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24610] Let user switch between 'Pay' and 'Write off' mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24610
--- Comment #1 from Julian Maurice ---
Created attachment 98552
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98552&action=edit
Bug 24610: Let user switch between 'Pay' and 'Write off' mode
In patron's accounting section, under 'Make a payment' tab, you have the
choice between 'Pay' and 'Write off'. It takes you to another form, but
once there you cannot change mode. You have to click on Cancel,
re-select the lines you had selected (if you made a selection) and click
on the right button.
This patch adds link above the form to easily switch between the two
modes.
Also fixes a CSS bug to be able to use Bootstrap's nav pills inside
.statictabs
Test plan:
1. Create some manual invoices
2. Go to 'Make a payment' tab
3. Click on the 'Pay' button in a table row
4. Above the form you should see two links ('Pay' and 'Write off').
Click on 'Write off', confirm the write off and verify that it did
make a 'write off'.
5. Go to 'Make a payment' tab
6. Click on the 'Write off' button in a table row
7. Click 'Pay', confirm the pay and verify that it did make a 'pay'
8. Go to 'Make a payment' tab
9. Select some lines and click on 'Pay selected'
10. Click on 'Write off', confirm the 'write off' and verify that it did
make a 'write off'
11. Go to 'Make a payment' tab
12. Select some lines and click on 'Write off selected'
13. Click on 'Pay', confirm the pay and verify that it did make a 'pay'
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24610] Let user switch between 'Pay' and 'Write off' mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24610 Julian Maurice changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24602] The fallback value for onshelfholds should be 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- Is this a warning? root@8881cb995d76:koha(bz24602)$ prove t/db_dependent/Reserves.t t/db_dependent/Reserves.t .. 8/62 Argument "book_reserved" isn't numeric in numeric eq (==) at /kohadevbox/koha/C4/Items.pm line 1776. t/db_dependent/Reserves.t .. ok All tests successful. Files=1, Tests=62, 8 wallclock secs ( 0.04 usr 0.00 sys + 6.64 cusr 0.63 csys = 7.31 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24602] The fallback value for onshelfholds should be 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602 --- Comment #4 from Tomás Cohen Arazi --- (In reply to David Nind from comment #3) > Is this a warning? > > root@8881cb995d76:koha(bz24602)$ prove t/db_dependent/Reserves.t > t/db_dependent/Reserves.t .. 8/62 Argument "book_reserved" isn't numeric in > numeric eq (==) at /kohadevbox/koha/C4/Items.pm line 1776. > t/db_dependent/Reserves.t .. ok > All tests successful. > Files=1, Tests=62, 8 wallclock secs ( 0.04 usr 0.00 sys + 6.64 cusr 0.63 > csys = 7.31 CPU) > Result: PASS That's new, this is the warning I'm referring to: Use of uninitialized value $on_shelf_holds in numeric eq (==) at /kohadevbox/koha/C4/Reserves.pm line 1239. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24602] The fallback value for onshelfholds should be 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24602] The fallback value for onshelfholds should be 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602 David Nind changed: What|Removed |Added Attachment #98532|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 98554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98554&action=edit Bug 24602: Tests for get_onshlefholds_policy Ths patch introduces tests for get_onshelf_policy. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/CirculationRules.t => FAIL: Tests fail because the current code returns undef instead of 0 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24602] The fallback value for onshelfholds should be 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602 David Nind changed: What|Removed |Added Attachment #98533|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 98555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98555&action=edit Bug 24602: Make get_onshelfholds_policy fallback to 0 The onshelfholds circulation rules values are more of an ENUM type (as opposed to other rules with integers like max*qty). In the quantities cases, it makes sense to have undef mean unlimited. In the enum type it is clearer to just set a default value (0) as the code already expects (Note: undef and 0 both eval to false so there's no behaviour problem, but warnings or we get forced to check for defined when the rule is used. It seems trivial to just make the rule fallback to a chosen default value). This patch makes it fallback to 0. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/CirculationRules.t \ t/db_dependent/Reserves.t => FAIL: CirculationRules.t fails and Reserves.t prints a warning 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests pass! No warning! 4. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4985] Edit a calendar entry for all branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985 Emmi Takkinen changed: What|Removed |Added CC||emmi.takki...@outlook.com Status|NEW |Needs Signoff Assignee|gmcha...@gmail.com |emmi.takki...@outlook.com --- Comment #4 from Emmi Takkinen --- Created attachment 98556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98556&action=edit Bug 4985: Edit a calendar entry for all branches Bug 4985: Edit a calendar entry for all branches This patch adds functionality to calendar tool to make edits or deletes to all branches at once. To test: -Apply patch -Add holiday for a library and copy it to all or some libraries -Edit previosly made holiday (edit, delete etc.) and check out "Copy changes to all libraries." checkbox => Changes are made to all libraries sharing changed holiday Sponsored by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24589] Add plugin hook addbiblio_check_record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24589 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12022] Independent branches does not isolate pending and approved comments by branch.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Severity|major |normal --- Comment #9 from Martin Renvoize --- Is this still valid.. or perhaps it should really be moved to library groups rather than independent branches at this point? At this point, it feels like an enhancement to me? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18731] Add routes for acquisition orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi changed: What|Removed |Added Blocks||24611 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 [Bug 24611] wrong budget_id query parameter in /acquisitions/orders -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24611] New: wrong budget_id query parameter in /acquisitions/orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 Bug ID: 24611 Summary: wrong budget_id query parameter in /acquisitions/orders Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com Between the writing time of the endpoint (2017) and the time it was refactored and pushed, attribute mappings were introduced, and the query parameters didn't get enough attention so it still refers to budget_id. We need to fix it! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24611] wrong budget_id query parameter in /acquisitions/orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 Tomás Cohen Arazi changed: What|Removed |Added Depends on||18731 Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 [Bug 18731] Add routes for acquisition orders -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24611] wrong budget_id query parameter in /acquisitions/orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 Tomás Cohen Arazi changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 --- Comment #8 from Martin Renvoize --- Created attachment 98561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98561&action=edit Bug 16719: (follow-up) Update check on password mapping Change to allow for unmapped default passwords Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Attachment #52316|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 Martin Renvoize changed: What|Removed |Added Attachment #53124|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 --- Comment #7 from Martin Renvoize --- Created attachment 98560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98560&action=edit Bug 16719: Pass through undef rather than empty string in LDAP mapping Nullable DB fields should be passed null in cases where ldap fields are empty and not replaced with empty strings. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 Martin Renvoize changed: What|Removed |Added Version|3.22|master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 Martin Renvoize changed: What|Removed |Added Status|In Discussion |Signed Off --- Comment #9 from Martin Renvoize --- Code works as expected and seems to resolve the issue described. I could not spot any regressions and it appears a sane change to me. Signing off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 --- Comment #10 from Oliver Behnke --- Seems like you accepted both of my patches. Nice! Thanks guys! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #28 from Martin Renvoize --- (In reply to David Cook from comment #27) > I have been thinking that maybe we should modularize search more so that it > would make it easier to customize behaviour, unit test, and swap different > backends in/out, but... I think one of the biggest struggles we face is that > Koha doesn't really have a search query language. > > We have something like CCL, but it's not CCL, and our compensating for that > fact leads to problems. And without a real query language, we don't have a > real query parser, and without a real query parser, it's hard to safely and > programmatically alter the queries. > > But... I don't really have a solution in mind either. Sometimes, I hope that > we'll just get rid of Zebra, and then we can just focus on Elasticsearch, > and maybe change our search query syntax to be safer, easier to parse, and > easier to integrate with Elasticsearch. I think it would be a breaking > change away from the Zebra CCL-like search syntax we've used... but that > would probably be a good thing. Agreed, but I feel that's for another bug ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #29 from Martin Renvoize --- Regarding this bug, I think we should use the patch here and update our minimum required zebra version (and document how to get said zebra version via either the indexdata repo's or pulling a copy into the koha repo) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24611] wrong budget_id query parameter in /acquisitions/orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 98562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98562&action=edit Bug 24611: Regression test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24611] wrong budget_id query parameter in /acquisitions/orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 98563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98563&action=edit Bug 24611: Fix wrong budget_id query param in /acquisitions/orders This patch fixes the wrong query parameter that slipped on rewriting the patches for the voted RFC. To test: 1. Apply the tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => FAIL: Tests fail because fund_id is not a valid query parameter 3. Apply this patch 4. Repeat (2) => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24611] wrong budget_id query parameter in /acquisitions/orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff CC||ere.maij...@helsinki.fi, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24111] Incorrect "Can't create any orders" alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24111 Stina Hallin changed: What|Removed |Added CC||stina.hal...@ub.lu.se --- Comment #2 from Stina Hallin --- Hello, I cannot recreate the error message in the sandbox. I can recreate it in our own test Koha on version 19.05.04. Of course there can be differences in our setups. I have tried the sandbox both with and without the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #22 from Julian Maurice --- Created attachment 98564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98564&action=edit Bug 17702: Add UI to manage account credit types It is the same as for debit types. It adds a new column `archived` in table `account_credit_types` that has the same purpose than `account_debit_types.archived` Test plan: 0. Apply patch && run updatedatabase && update_dbix_class_files 1. Go to Admin » Credit types 2. Add a new credit type, give it a code and a description and check 'Can be manually added' 3. Go to a patron's accounting section, 'Create manual credit' tab 4. Verify that the new credit type appears 5. Return to Admin » Credit types and archive the credit type 6. Verify that the new credit type is not available anymore in 'Create manual credit' 7. Restore the credit type and verify that it is available again 8. Create a manual credit with the new credit type 9. Go to Reports » Cash register and make sure you can find the transaction by filtering on transaction type 10. Edit the new credit type and set some library limitations, make sure that the credit type doesn't appear if you're connected to a library you didn't selected, and that it appears if you're connected to a library you selected. Note to QA team: The change in Koha/Account.pm, I added it because otherwise Koha died when adding a manual credit with a custom type. In that case, offset type will default to 'Manual Credit'. I'm not sure if that is the best thing to do. I'm open to suggestions :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #23 from Julian Maurice --- Not sure if it should still be BLOCKED, or if it is the right bug for this patch. Martin, can you take a look please ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24609] Add routes for getting and setting checkout due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609
Andrew Isherwood changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |andrew.isherwood@ptfs-europ
|ity.org |e.com
Status|NEW |ASSIGNED
--- Comment #1 from Andrew Isherwood ---
Change of plan on this one. It's unnecessary to create a new endpoint for this.
Following a discussion with Martin, I've realised we can just add a PUT
endpoint for the /checkouts/{checkout_id} route, with whole checkout objects
passed as the body.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4985] Edit a calendar entry for all branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985 ByWater Sandboxes changed: What|Removed |Added Attachment #98556|0 |1 is obsolete|| --- Comment #5 from ByWater Sandboxes --- Created attachment 98565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98565&action=edit Bug 4985: Edit a calendar entry for all branches This patch adds functionality to calendar tool to make edits or deletes to all branches at once. To test: -Apply patch -Add holiday for a library and copy it to all or some libraries -Edit previosly made holiday (edit, delete etc.) and check out "Copy changes to all libraries." checkbox => Changes are made to all libraries sharing changed holiday Sponsored by: Koha-Suomi Oy Signed-off-by: Christofer -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4985] Edit a calendar entry for all branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985 Christofer Zorn changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||christofer.zorn@ajaxlibrary ||.ca --- Comment #6 from Christofer Zorn --- Good morning! Followed test plan and was able to create a single date holiday and apply it to all branches. Was then able to switch branches, make the edit and apply to all and it worked. I'm not sure if this is intended to edit holidays over a range, but when I tried for a "closure week", the edit didn't apply and only changed the first day. Thanks! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24610] Let user switch between 'Pay' and 'Write off' mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24610
ByWater Sandboxes changed:
What|Removed |Added
Attachment #98552|0 |1
is obsolete||
--- Comment #3 from ByWater Sandboxes ---
Created attachment 98566
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98566&action=edit
Bug 24610: Let user switch between 'Pay' and 'Write off' mode
In patron's accounting section, under 'Make a payment' tab, you have the
choice between 'Pay' and 'Write off'. It takes you to another form, but
once there you cannot change mode. You have to click on Cancel,
re-select the lines you had selected (if you made a selection) and click
on the right button.
This patch adds link above the form to easily switch between the two
modes.
Also fixes a CSS bug to be able to use Bootstrap's nav pills inside
.statictabs
Test plan:
1. Create some manual invoices
2. Go to 'Make a payment' tab
3. Click on the 'Pay' button in a table row
4. Above the form you should see two links ('Pay' and 'Write off').
Click on 'Write off', confirm the write off and verify that it did
make a 'write off'.
5. Go to 'Make a payment' tab
6. Click on the 'Write off' button in a table row
7. Click 'Pay', confirm the pay and verify that it did make a 'pay'
8. Go to 'Make a payment' tab
9. Select some lines and click on 'Pay selected'
10. Click on 'Write off', confirm the 'write off' and verify that it did
make a 'write off'
11. Go to 'Make a payment' tab
12. Select some lines and click on 'Write off selected'
13. Click on 'Pay', confirm the pay and verify that it did make a 'pay'
Signed-off-by: Christofer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24610] Let user switch between 'Pay' and 'Write off' mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24610 ByWater Sandboxes changed: What|Removed |Added Attachment #98553|0 |1 is obsolete|| --- Comment #4 from ByWater Sandboxes --- Created attachment 98567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98567&action=edit Bug 24610: Compiled CSS Signed-off-by: Christofer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24610] Let user switch between 'Pay' and 'Write off' mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24610 Christofer Zorn changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||christofer.zorn@ajaxlibrary ||.ca --- Comment #5 from Christofer Zorn --- Hello! I was able to follow the test plan below and it worked according to the plan. Thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24381] ACCOUNT_CREDIT slip not printing information about paid fines/fees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #10 from Martin Renvoize --- I need some more of the other accounts bugs to move before I can delegate time to this I'm afraid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24610] Let user switch between 'Pay' and 'Write off' mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24610 --- Comment #6 from Julian Maurice --- Thank you for testing it ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Martin Renvoize changed: What|Removed |Added Attachment #97485|0 |1 is obsolete|| --- Comment #25 from Martin Renvoize --- Created attachment 98569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98569&action=edit Bug 19735: Move Perl deps definitions into a cpanfile cpanfile is a format for describing CPAN dependencies for Perl applications. It is more concise - thus easier to read and maintain - than C4::Installer::PerlDependencies, and allows to describe requirements more accurately (using version ranges or features for instance) Additionally it can be read by tools such as cpanm or carton for an easy way to install dependencies on non-Debian-based systems. For more information on cpanfile, see http://search.cpan.org/~miyagawa/Module-CPANfile-1.1002/lib/cpanfile.pod This patch replace C4::Installer::PerlDependencies by an equivalent cpanfile and update all scripts/modules that were using PerlDependencies It also removes dead code from C4::Installer::PerlModules (some subroutines were not used at all, except in unit tests) Added dependencies: - Module::CPANfile - CPAN::Meta (dependency of Module::CPANfile, but we need a more recent version than the one Module::CPANfile requires) Test plan: 1. Go to About page, tab Perl modules and keep this browser tab open 2. Apply patch 3. Install Module::CPANfile and CPAN::Meta a. On Debian-based systems: # will install libcpan-meta-perl as a dependency sudo apt install libmodule-cpanfile-perl b. Others: # will install CPAN::Meta as a dependency sudo cpanm Module::CPANfile 4. In a new browser tab, go to About page, tab Perl modules and compare the table with the one in the previous browser tab They should be identical, except for newly added dependencies (Module::CPANfile and CPAN::Meta) 5. Do a 'standard' install a. perl Makefile.PL (select 'standard') b. make c. sudo make install d. Configure your database, web server, ... and go through the web install process 6. Verify that the cpanfile got copied into PERL_MODULE_DIR (which should be /usr/share/koha/lib) 7. Go to the about page of this fresh install and compare it with your dev install 8. Verify that debian/list-deps still works This takes a lot of time and it may not be necessary to wait until the end. If you see some Debian package names that correspond to modules in cpanfile, it means it still works (you need apt-file for this script to work) 9. Verify that koha_perl_deps.pl still works 10. prove t/Installer_pm.t t/Installer_PerlModules.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #26 from Martin Renvoize --- Created attachment 98570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98570&action=edit Bug 19735: Remove C4::Installer::PerlDependancies This patch does the actual removal of the PerlDependancies module. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Martin Renvoize changed: What|Removed |Added Attachment #97484|0 |1 is obsolete|| --- Comment #24 from Martin Renvoize --- Created attachment 98568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98568&action=edit Bug 19735: Script to generate cpanfile (DO NOT PUSH) For testing purposes only Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #27 from Martin Renvoize --- Signing off.. all works as expected. I did a minor rebase whilst I was testing (new dependencies added to PerlDependancies. As part of that I separated the 'remove PerlDependancies' step into it's own commit to make it easier to rebase and use the included test script for building an updated cpanfile at time of push. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23119] MARC21 added title 246, 730 subfield i displays out of order, and should display before subfield a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23119 Wendy Sharkey changed: What|Removed |Added CC||cata...@bfli.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23528] Show 'log in to add tags' link on all search result entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23528 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23528] Show 'log in to add tags' link on all search result entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23528 Lucas Gass changed: What|Removed |Added Version(s)|19.11.00|19.11.00, 19.05.08 released in|| CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #4 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #28 from Julian Maurice --- (In reply to Martin Renvoize from comment #27) > Signing off.. all works as expected. > > I did a minor rebase whilst I was testing (new dependencies added to > PerlDependancies. As part of that I separated the 'remove PerlDependancies' > step into it's own commit to make it easier to rebase and use the included > test script for building an updated cpanfile at time of push. I wanted to do that, but never did... Thanks :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #107 from Bouzid Fergani --- Created attachment 98571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98571&action=edit Bug 11299: Add a button to the biblio edition page to automatically add authority links in the current biblio record via AJAX. Also adds a button to easily create missing authority records. add authority type in the form to create the missing authority. when authority was found, the 600$9 field have the authid. Testing scenario (Creating an authority record for a failed automatic link) : * In you system preferences, deactivate the "AutoCreateAuthorities" preference. * Go to the biblio record creation form to create a new biblio record. (koha/cataloguing/addbiblio.pl) * Click the "Link authorities automatically" button. A message should appear, telling the user "No authority link was changed." * Add random informations in field 600$a of the biblio record. * Click the "Link authorities automatically" button. * if matching authority was found, The message box should now show "600 - A matching authority was found in the local database". * if no matching authority was found, the message box should now show "600 - No matching authority found.". For this scenario, we want the authority match to have failed. * The 600$9 field should now be red and icons should have appeared next to it. Click on the "create authority" icon. * A popup will appear, containing a form to create the missing authority. The form should be pre-filled, a the informations in the 600$a field of the biblio shouldbe in the 100$a field of this new authority record. * Fill in the form and click the "Save" button * The 600$9 field in the biblio record should now be back to normal and have the authid of the authority record that was just created. * Click the "Link authorities automatically" button again. The message box should now show "No authority link was changed.". Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=12299 Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Bouzid Fergani changed: What|Removed |Added Attachment #95152|0 |1 is obsolete|| Attachment #98571|0 |1 is obsolete|| --- Comment #108 from Bouzid Fergani --- Created attachment 98572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98572&action=edit Bug 11299: Add a button to the biblio edition page to automatically add authority links in the current biblio record via AJAX. Also adds a button to easily create missing authority records. add authority type in the form to create the missing authority. when authority was found, the 600$9 field have the authid. Testing scenario (Creating an authority record for a failed automatic link) : * In you system preferences, deactivate the "AutoCreateAuthorities" preference. * Go to the biblio record creation form to create a new biblio record. (koha/cataloguing/addbiblio.pl) * Click the "Link authorities automatically" button. A message should appear, telling the user "No authority link was changed." * Add random informations in field 600$a of the biblio record. * Click the "Link authorities automatically" button. * if matching authority was found, The message box should now show "600 - A matching authority was found in the local database". * if no matching authority was found, the message box should now show "600 - No matching authority found.". For this scenario, we want the authority match to have failed. * The 600$9 field should now be red and icons should have appeared next to it. Click on the "create authority" icon. * A popup will appear, containing a form to create the missing authority. The form should be pre-filled, a the informations in the 600$a field of the biblio shouldbe in the 100$a field of this new authority record. * Fill in the form and click the "Save" button * The 600$9 field in the biblio record should now be back to normal and have the authid of the authority record that was just created. * Click the "Link authorities automatically" button again. The message box should now show "No authority link was changed.". Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=12299 Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #109 from Bouzid Fergani --- Hi, 1. Refactoring AddAuthorityFromHeading 2. Deleting New images and use bootstrap icons 3. Replace require by use In authorities.pl 4. Add permission editcatalogue in cataloguing/automatic_linker.pl. 5. Indentation in all files 6. When running qa tools, all it's ok Thanks. Bouzid. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 Nick Clemens changed: What|Removed |Added Attachment #98560|0 |1 is obsolete|| Attachment #98561|0 |1 is obsolete|| --- Comment #11 from Nick Clemens --- Created attachment 98573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98573&action=edit Bug 16719: Pass through undef rather than empty string in LDAP mapping Nullable DB fields should be passed null in cases where ldap fields are empty and not replaced with empty strings. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 --- Comment #12 from Nick Clemens --- Created attachment 98574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98574&action=edit Bug 16719: (follow-up) Update check on password mapping Change to allow for unmapped default passwords Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 --- Comment #13 from Nick Clemens --- Created attachment 98575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98575&action=edit Bug 16719: (QA follow-up) Remove tabs Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #14 from Nick Clemens --- https://wiki.koha-community.org/wiki/Ldap_testing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #29 from Martin Renvoize --- Created attachment 98576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98576&action=edit Bug 19735: (QA follow-up) Drop references to 'usage' The 'usage' key was dropped as part of this migration to cpanfile but it was still refered to by the installed. This patch simply removes references to it. After considering how we might add it back in I decided that as it stands it wasn't a well maintained list and should be re-implimented in the future in a more consistent form if we miss it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23383] IdRef link appears even with syspref is off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23383 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel --- Hi, testing this. Patch is simple and syntactically correct. What framework are you using? With english or unimarc_complete (fr-FR) field 009 is hidden. Are you using another one? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #30 from Martin Renvoize --- Created attachment 98577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98577&action=edit Bug 19735: Add support for max_ver -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24602] The fallback value for onshelfholds should be 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24602] The fallback value for onshelfholds should be 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602 Nick Clemens changed: What|Removed |Added Attachment #98554|0 |1 is obsolete|| Attachment #98555|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 98578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98578&action=edit Bug 24602: Tests for get_onshlefholds_policy Ths patch introduces tests for get_onshelf_policy. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/CirculationRules.t => FAIL: Tests fail because the current code returns undef instead of 0 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24602] The fallback value for onshelfholds should be 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602 --- Comment #8 from Nick Clemens --- Created attachment 98579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98579&action=edit Bug 24602: Make get_onshelfholds_policy fallback to 0 The onshelfholds circulation rules values are more of an ENUM type (as opposed to other rules with integers like max*qty). In the quantities cases, it makes sense to have undef mean unlimited. In the enum type it is clearer to just set a default value (0) as the code already expects (Note: undef and 0 both eval to false so there's no behaviour problem, but warnings or we get forced to check for defined when the rule is used. It seems trivial to just make the rule fallback to a chosen default value). This patch makes it fallback to 0. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/CirculationRules.t \ t/db_dependent/Reserves.t => FAIL: CirculationRules.t fails and Reserves.t prints a warning 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests pass! No warning! 4. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15563] Cronjob to regularly delete patroncard and label batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15563 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com Summary|Cronjob to regularly delete |Cronjob to regularly delete |patroncard label batches|patroncard and label ||batches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of Sale page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of Sale page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 Nick Clemens changed: What|Removed |Added Attachment #98547|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 98580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98580&action=edit Bug 24525: Remove SIP payment types from point of sale This patch removes the SIP payments types from displaying in the select options on the point of sale payment page. Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of Sale page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 Nick Clemens changed: What|Removed |Added Attachment #98548|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 98581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98581&action=edit Bug 24525: (follow-up) Factor out to an include Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
