[Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first field with a given tag

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531

--- Comment #12 from Magnus Enger  ---
(In reply to Josef Moravec from comment #6)
> What if there is repeated subfield with same code in one field? Then only
> first one is taken into account. I do think we want to count on all of
> them...

I have updated the tests and the code to account for repeated subfields. I
reset the status to SO, please reset to NSO if necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23571] fines.pl may block server

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23571

Hugo Agud  changed:

   What|Removed |Added

  Attachment #96056|0   |1
is obsolete||

--- Comment #5 from Hugo Agud  ---
Created attachment 98899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98899=edit
Bug 23571: Add flock to fines.pl

This patch adds a lock file for fines.pl.

To test:
1. Apply this patch
2. In two separate consoles run misc/cronjobs/fines.pl
SUCCESS => The first one runs normally, but the second one fails with a message
flock failed for the lock file.
3. Sign off.

Sponsored-by: Orex Digital

Signed-off-by: Hugo Agud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23571] fines.pl may block server

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23571

Hugo Agud  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23571] fines.pl may block server

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23571

Hugo Agud  changed:

   What|Removed |Added

  Attachment #96055|0   |1
is obsolete||

--- Comment #4 from Hugo Agud  ---
Created attachment 98898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98898=edit
Bug 23571: [DO NOT PUSH] crash condition builder

This patch adds t/db_dependent/bug_23571_crash_condition_builder.t file
This file is not intended to be part of Koha, but it's used to emulate crash
conditions.
It will create 5000 users, 5000 biblios with 2 items each, and each item issued
to a user.
It really takes a lot of time, so please be zen about it ;)

To use it execute
prove t/db_dependent/bug_23571_crash_condition_builder.t

Sponsored-by: Orex Digital

Signed-off-by: Hugo Agud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first field with a given tag

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531

Magnus Enger  changed:

   What|Removed |Added

  Attachment #98895|0   |1
is obsolete||

--- Comment #11 from Magnus Enger  ---
Created attachment 98897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98897=edit
Bug 24531 - Fix OAI-PMH sets for records with repeated fields

Currently, an OAI-PMH set mapping will only match if the value it
is looking for occurs in the first instance of a repeated field.

To test:
- Apply the first patch with two new tests
- Run something like this:
  sudo koha-shell -c "prove -v t/db_dependent/OAI/Sets.t" kohadev
- Verify that the last test fails
- Apply this secind patch
- Rerun the test file above
- Verify that all tests now pass

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first field with a given tag

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531

Magnus Enger  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first field with a given tag

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531

Magnus Enger  changed:

   What|Removed |Added

  Attachment #98894|0   |1
is obsolete||

--- Comment #10 from Magnus Enger  ---
Created attachment 98896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98896=edit
Bug 24531 - Test for OAI-PMH sets and repeated fields

This patch adds two tests related to OAI-PMH sets. It creates a
dummy record with a repeated field, with different values. It then
tests if the record is caught by mappings that match the value in
the first field, and then if it is caught by mappings that match
the second field.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first field with a given tag

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531

Magnus Enger  changed:

   What|Removed |Added

  Attachment #98221|0   |1
is obsolete||

--- Comment #8 from Magnus Enger  ---
Created attachment 98894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98894=edit
Bug 24531 - Test for OAI-PMH sets and repeated fields

This patch adds two tests related to OAI-PMH sets. It creates a
dummy record with a repeated field, with different values. It then
tests if the record is caught by mappings that match the value in
the first field, and then if it is caught by mappings that match
the second field.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first field with a given tag

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531

Magnus Enger  changed:

   What|Removed |Added

  Attachment #98222|0   |1
is obsolete||

--- Comment #9 from Magnus Enger  ---
Created attachment 98895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98895=edit
Bug 24531 - Fix OAI-PMH sets for records with repeated fields

Currently, an OAI-PMH set mapping will only match if the value it
is looking for occurs in the first instance of a repeated field.

To test:
- Apply the first patch with two new tests
- Run something like this:
  sudo koha-shell -c "prove -v t/db_dependent/OAI/Sets.t" kohadev
- Verify that the last test fails
- Apply this secind patch
- Rerun the test file above
- Verify that all tests now pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24404] Add missing space on invoices page

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404

--- Comment #8 from Katrin Fischer  ---
(In reply to Hayley Mapley from comment #7)
> Enhancement will not be backported to 18.11.x series.

Really just a typo fix (adds one space) - but causes a string change.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and Catmandu::MARC are missing from cpanfile

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de,
   ||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24659] Improve Patron Notice Status options to be more clear to staff

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24659

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
I'd vote for not generating notices in this case - if a patron has opted out of
receiving notices by not adding an email address, we should not generate any.

I think it doesn't generate emails for all notices, would you object to make
this about the auto-renewal notice for now and change the bug description
accordingly?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5016] Fix some terminology and wording issues on English PDF order templates

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5016

--- Comment #8 from Katrin Fischer  ---
Thx David, almost forgot about this one!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363

David Nind  changed:

   What|Removed |Added

  Attachment #98857|0   |1
is obsolete||

--- Comment #32 from David Nind  ---
Created attachment 98893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98893=edit
Bug 24363: Move the datepicker icon out of the input

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and Catmandu::MARC are missing from cpanfile

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #73542|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #65696|0   |1
is obsolete||
  Attachment #65697|0   |1
is obsolete||

--- Comment #58 from Srdjan Jankovic  ---
Created attachment 98891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98891=edit
Bug 14803: Reload checkouts table on renewal

svc/checkouts: get real rental charges for patron, rather than itemtype
indication

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #73541|0   |1
is obsolete||

--- Comment #59 from Srdjan Jankovic  ---
Created attachment 98892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98892=edit
bug 14803: KOHA.Checkouts js object

* Use javascript to:
- update fines/checkouts info
- show/hide checkouts form and messages
* Created svc/fines

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16683] Help links to fields 59X in cataloguing form are broken

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16683

Hayley Mapley  changed:

   What|Removed |Added

 CC||hayleymap...@catalyst.net.n
   ||z

--- Comment #9 from Hayley Mapley  ---
Hi,

Could this please be rebased for 18.11.x?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061

Hayley Mapley  changed:

   What|Removed |Added

 Version(s)|20.05.00, 19.11.03, |20.05.00, 19.11.03,
released in|19.05.08|19.05.08, 18.11.14
 Status|Pushed to oldstable |Pushed to oldoldstable
 CC||hayleymap...@catalyst.net.n
   ||z

--- Comment #36 from Hayley Mapley  ---
Backported to 18.11.x for 18.11.14.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24025] Make CodeMirror content searchable

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24025

Hayley Mapley  changed:

   What|Removed |Added

 CC||hayleymap...@catalyst.net.n
   ||z

--- Comment #12 from Hayley Mapley  ---
Enhancement will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24452] Advanced editor - show multiple spaces visually

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24452

Hayley Mapley  changed:

   What|Removed |Added

 CC||hayleymap...@catalyst.net.n
   ||z

--- Comment #9 from Hayley Mapley  ---
Enhancement will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24236] Using quotes in a cataloging search, resulting in multiple pages, will not allow you to advance page

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24236

Hayley Mapley  changed:

   What|Removed |Added

 CC||hayleymap...@catalyst.net.n
   ||z

--- Comment #11 from Hayley Mapley  ---
Is someone able to also test 18.11.x for the presence of this bug?

I have tested, and I am able to paginate with results still coming up even when
searching with "cat".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24214] Due date displayed in ISO format (when sticky)

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24214

Hayley Mapley  changed:

   What|Removed |Added

 CC||hayleymap...@catalyst.net.n
   ||z

--- Comment #6 from Hayley Mapley  ---
Hi there,

Could you please rebase this patch for 18.11.x?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17667] Standing orders - cancelling a receipt increase the original quantity

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17667

Hayley Mapley  changed:

   What|Removed |Added

 Status|Pushed to oldstable |Pushed to oldoldstable
 Version(s)|20.05.00, 19.11.03, |20.05.00, 19.11.03,
released in|19.05.08|19.05.08, 18.11.14
 CC||hayleymap...@catalyst.net.n
   ||z

--- Comment #16 from Hayley Mapley  ---
Backported to 18.11.x for 18.11.14.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24404] Add missing space on invoices page

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404

Hayley Mapley  changed:

   What|Removed |Added

 CC||hayleymap...@catalyst.net.n
   ||z

--- Comment #7 from Hayley Mapley  ---
Enhancement will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20292] Filter/censor info sent via SIP

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20292

Hayley Mapley  changed:

   What|Removed |Added

 CC||hayleymap...@catalyst.net.n
   ||z

--- Comment #19 from Hayley Mapley  ---
Enhancement will not be backported to 18.11.x.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24275] Inventory table should be sortable by title without leading articles (allow for title sort with anti-the)

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24275

Hayley Mapley  changed:

   What|Removed |Added

 CC||hayleymap...@catalyst.net.n
   ||z

--- Comment #8 from Hayley Mapley  ---
Enhancement will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not enforced after item is captured for hold

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567

Hayley Mapley  changed:

   What|Removed |Added

 CC||hayleymap...@catalyst.net.n
   ||z

--- Comment #23 from Hayley Mapley  ---
Enhancement/patch will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24391] Remove event attributes from patron clubs edit template

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391

Hayley Mapley  changed:

   What|Removed |Added

 CC||hayleymap...@catalyst.net.n
   ||z

--- Comment #10 from Hayley Mapley  ---
Enhancement will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23790] fr-CA translation of ACCOUNT_DEBIT and ACCOUNT_CREDIT notices

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23790

Hayley Mapley  changed:

   What|Removed |Added

 CC||hayleymap...@catalyst.net.n
   ||z

--- Comment #8 from Hayley Mapley  ---
Patch will not be backported to 18.11.x series (unless requested).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24206] Change URLs for default options in OPACSearchForTitleIn

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206

Hayley Mapley  changed:

   What|Removed |Added

 CC||hayleymap...@catalyst.net.n
   ||z

--- Comment #24 from Hayley Mapley  ---
Patches will not be backported to 18.11.x series as no one should be installing
18.11.x.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9989] Closing a basket without creating a basketgroup should not redirect to baskets list

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9989

Aleisha Amohia  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9989] Closing a basket without creating a basketgroup should not redirect to baskets list

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9989

--- Comment #1 from Aleisha Amohia  ---
Created attachment 98890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98890=edit
Bug 9989: Stay on basket page after closing it

Instead of redirecting to the list of vendor's baskets.

To test:
1) Go to Acquisitions. Ensure you have a budget, fund and vendor
defined.
2) Create a basket. Add an item to it.
3) Close the basket. Do not attach to a basketgroup.
4) Notice you are redirected to the list of vendor's baskets.
5) Apply the patch and go to the basket's page. Reopen the basket.
6) Close the basket. Do not attach to a basketgroup.
7) Confirm you remain on the closed basket's page.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9989] Closing a basket without creating a basketgroup should not redirect to baskets list

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9989

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
 CC||alei...@catalyst.net.nz
   Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9872] Logs explode with messages when adding a new order in acquisitions

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9872

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz

--- Comment #1 from Aleisha Amohia  ---
Hi Katrin, can you please confirm whether this test plan still produces these
warns? I'm unable to reproduce them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8595] link to 'host item' confusing

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8595

--- Comment #3 from Aleisha Amohia  ---
Created attachment 98889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98889=edit
Bug 8595: Rename 'host item' to 'host record'

To test:

1) Enable the syspref EasyAnalyticalRecords
2) Find a biblio record, go to the detail page
3) Click the Edit dropdown and notice the option "Link to host item"
4) Apply patch and refresh page
5) Click the Edit dropdown and confirm the renamed "Link to host record"
button

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8595] link to 'host item' confusing

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8595

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21296] Suspend hold ignores system preference on intranet

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.05.00, 19.11.03  |20.05.00, 19.11.03,
released in||19.05.08
 CC||lu...@bywatersolutions.com
 Status|Pushed to stable|Pushed to oldstable

--- Comment #7 from Lucas Gass  ---
backported to 19.05.x for 19.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16683] Help links to fields 59X in cataloguing form are broken

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16683

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.05.00, 19.11.03  |20.05.00, 19.11.03,
released in||19.05.08
 CC||lu...@bywatersolutions.com
 Status|Pushed to stable|Pushed to oldstable

--- Comment #8 from Lucas Gass  ---
backported to 19.05.x for 19.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7000] show home and holding branch on staff search results

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7000

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz

--- Comment #2 from Aleisha Amohia  ---
It looks like this has been fixed in master and now uses the
StaffSearchResultsDisplayBranch syspref. Can you confirm we can close this bug
report?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #30 from Lucas Gass  ---
choosing not backport enhancement to 19.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24289] Deleting branch will not delete entry in special or repeatable holidays

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24289

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.05.00, 19.11.03  |20.05.00, 19.11.03,
released in||19.05.08
 CC||lu...@bywatersolutions.com
 Status|Pushed to stable|Pushed to oldstable

--- Comment #13 from Lucas Gass  ---
backported to 19.05.x for 19.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14237] allow bibs to be added to course without items

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14237

Rogan Hamby  changed:

   What|Removed |Added

 CC||rogan.ha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24025] Make CodeMirror content searchable

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24025

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.05.00, 19.11.03  |20.05.00, 19.11.03,
released in||19.05.08
 Status|Pushed to stable|Pushed to oldstable

--- Comment #11 from Lucas Gass  ---
backported to 19.05.x for 19.05.08

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24452] Advanced editor - show multiple spaces visually

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24452

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.05.00, 19.11.03  |20.05.00, 19.11.03,
released in||19.05.08
 CC||lu...@bywatersolutions.com
 Status|Pushed to stable|Pushed to oldstable

--- Comment #8 from Lucas Gass  ---
backported to 19.05.x for 19.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24105] Longoverdue gives error message when --itemtypes are specified

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24105

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Pushed to stable|Pushed to oldstable
 Version(s)|20.05.00, 19.11.03  |20.05.00, 19.11.03,
released in||19.05.08

--- Comment #6 from Lucas Gass  ---
backported to 19.05.x for 19.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23064] Cannot edit subscription with strict SQL modes turned on

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Version(s)|20.05.00, 19.11.03  |20.05.00, 19.11.03,
released in||19.05.08
 Status|Pushed to stable|Pushed to oldstable

--- Comment #15 from Lucas Gass  ---
backported to 19.05.x for 19.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24286] FindDuplicateAuthority does not escape forward slash in 'GENRE/FORM'

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24286

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #10 from Lucas Gass  ---
19.05.x does not include QueryRegexEscapeOptions, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24649] Cloning item subfields misses a tag

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||alei...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24649] Cloning item subfields misses a tag

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #98829|0   |1
is obsolete||

--- Comment #10 from Aleisha Amohia  ---
Created attachment 9
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9=edit
Bug 24649: Fix two other missing  tags for cloned subfields

Same problem as previous patch in Batch item modification as well as
serial-edit.pl.

Test plan:
[1] Go to Tools/Batch item modification.
Test cloning subfield on batchMod-edit.
[2] Go to a serial with "Create item when receiving".
Receive an issue. Click add item.
Test cloning subfield.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24649] Cloning item subfields misses a tag

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #98797|0   |1
is obsolete||

--- Comment #9 from Aleisha Amohia  ---
Created attachment 98887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98887=edit
Bug 24649: Fix missing  tag on item editor for cloned subfield

Instead of the parentNode (which is a div), we need the parent of the div
(which is a li).
So a simple fix.

Test plan:
To see the difference, test first without patch applied:
Mark item subfield, say URI, as repeatable.
Clone that subfield in item editor.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24236] Using quotes in a cataloging search, resulting in multiple pages, will not allow you to advance page

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24236

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 CC||lu...@bywatersolutions.com

--- Comment #10 from Lucas Gass  ---
backported to 19.05.x for 19.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24249] OPAC lists page should require login for login-dependent operations

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249

David Nind  changed:

   What|Removed |Added

  Attachment #98824|0   |1
is obsolete||

--- Comment #8 from David Nind  ---
Created attachment 98886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98886=edit
Bug 24249: OPAC lists page should require login for login-dependent operations

This patch modifies opac-shelves.pl so that login is required if the
requested operation is anything but "view" and "list."

The patch also modifies a couple of "Log in to create a new list" links
so that they point to the list creation form instead of opac-user.pl.

To test, apply the patch and go to the main lists page (the list of
lists) in the OPAC while not logged in.

 - Click the "Log in to create your own lists" link.
 - Log in.
 - You should be taken to the "Create a new list" form.
 - Also test the "New list" link shown in the toolbar when you're
   viewing the contents of a list.
 - When not logged in click the "Lists" menu in the page's header menu.
   Clicking "Log in to create a new list" should take you to the login
   form and then to the list creation form.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24249] OPAC lists page should require login for login-dependent operations

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15726] Add columns configuration and export options to circulation and fine rules

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15726

Owen Leonard  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24660] ModBiblio spams cataloguing log when linking to authorities

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24660

Nick Clemens  changed:

   What|Removed |Added

 Depends on||18816


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18816
[Bug 18816] Make CataloguingLog work in production by preventing circulation
from spamming the log
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18816] Make CataloguingLog work in production by preventing circulation from spamming the log

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18816

Nick Clemens  changed:

   What|Removed |Added

 Blocks||24660


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24660
[Bug 24660] ModBiblio spams cataloguing log when linking to authorities
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24660] ModBiblio spams cataloguing log when linking to authorities

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24660

Nick Clemens  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com,
   ||l...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24660] New: ModBiblio spams cataloguing log when linking to authorities

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24660

Bug ID: 24660
   Summary: ModBiblio spams cataloguing log when linking to
authorities
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

bug 18816 altered ModItem to have a switch on logging, we need the same for
ModBiblio so that authchanges by the linker are not recorded

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327

Owen Leonard  changed:

   What|Removed |Added

  Attachment #96919|0   |1
is obsolete||

--- Comment #5 from Owen Leonard  ---
Created attachment 98885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98885=edit
Bug 13327: OPACPopupAuthorsSearch doesn't work with XSLT views

This patch reimplements the OPACPopupAuthorsSearch feature so that it
will work in the XSLT view.

To test, apply the patch and view the detail page for a bibliographic
record in the OPAC. Test under the following conditions:

 - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay "default"
 - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay empty
 - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay "default"
 - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay empty

In each of these cases, test the detail page's listing of additional
authors/contributors and subjects. Test records which have both multiple
contributors or subjects and which have only one author or subject.

When OPACPopupAuthorsSearch is turned on, verify that the author/subject
selection modal appears and that your selections are correctly combined
to build a search string.

Note that OPACPopupAuthorsSearch feature has a problem with terms
containing parentheses. The issue predates this patch.

Also note that the QA tools will give a false positive about Bootstrap
button styles. This rule only applies to the staff client.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24659] New: Improve Patron Notice Status options to be more clear to staff

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24659

Bug ID: 24659
   Summary: Improve Patron Notice Status options to be more clear
to staff
 Change sponsored?: ---
   Product: Koha
   Version: 19.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: marga...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When patron messaging preferences are selected not to send courtesy notices,
and there is no email for them to be sent to, Koha generates a notice and marks
it as failed. 

The case I'm specifically looking at involves Auto Renewal notices. These
“failures” are visible in the Patron Notices Log and then general circulation
staff sees “failed” and gets confused.

Staff education is important, but we can make things easier for our users by
clarifying these types of messages. Either we could skip making them, as
determined the Patron messaging preferences, to find a better status term for
these types of messages. 

"Not applicable"
"Unsent"
"Not required"
"No emails selected"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146

--- Comment #28 from Lucas Gass  ---
if this needs to be in 19.05.x please rebase so it will pass unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24338] CASH is missing from the default payment_types

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #19 from Lucas Gass  ---
missing dependencies for 19.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146

--- Comment #27 from Lucas Gass  ---
i cannot make this patchset both work and pass tests in 19.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657

Agustín Moyano  changed:

   What|Removed |Added

  Attachment #98883|0   |1
is obsolete||

--- Comment #2 from Agustín Moyano  ---
Created attachment 98884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98884=edit
Bug 24657: Fix t/db_dependent/Koha/Item.t and t/db_dependent/Holds.t

on t/db_dependent/Koha/Item.t on line 172 I created 2 Koha::Library::Groups
like this

my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value
=> { ft_local_hold_group => 1 } } );
my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value
=> { ft_local_hold_group => 1 } } );

I didn't realize this was creating 2 new libraries that sometimes messed up
with tests, so I changed it to this

my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value
=> { ft_local_hold_group => 1, branchcode => undef } } );
my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value
=> { ft_local_hold_group => 1, branchcode => undef } } );

on t/db_dependent/Holds.t on line 1058 I created 3 libraries like this

my $library1  = $builder->build_object( { class => 'Koha::Libraries' } );
my $library2  = $builder->build_object( { class => 'Koha::Libraries' } );
my $library3  = $builder->build_object( { class => 'Koha::Libraries' } );

but they needed to be pickup_locations, and sometimes they wheren't set as
such, so I changed it to this

my $library1  = $builder->build_object( { class => 'Koha::Libraries', value =>
{pickup_location => 1} } );
my $library2  = $builder->build_object( { class => 'Koha::Libraries', value =>
{pickup_location => 1} } );
my $library3  = $builder->build_object( { class => 'Koha::Libraries', value =>
{pickup_location => 1} } );

To test:
1. do not apply this patch
2. in bash:
   for i in {1..300}; do echo "loop $i"; prove t/db_dependent/Koha/Item.t
t/db_dependent/Holds.t; if [ "$?" = "1" ]; then break; fi; done
3. Grab a cup of coffee (or tea if you are healthy) and wait for a while
4. Whithin 300 iterations there should be an error in any of both scripts and
for loop should exit
5. Apply this patch
6. repeat step 2 and 3 (decaff this time!)
7. All 300 loops should pass
8. Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24630] UNIMARC XSLT Update for bug 7611

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630

Owen Leonard  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24654] Trailing double-quote in rda 264 subfield b on opac xslt

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24654

Owen Leonard  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657

Agustín Moyano  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657

--- Comment #1 from Agustín Moyano  ---
Created attachment 98883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98883=edit
Bug 24657: Fix t/db_dependent/Koha/Item.t and t/db_dependent/Holds.t

on t/db_dependent/Koha/Item.t on line 172 I created 2 Koha::Library::Groups
like this

my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value
=> { ft_local_hold_group => 1 } } );
my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value
=> { ft_local_hold_group => 1 } } );

I didn't realize this was creating 2 new libraries that sometimes messed up
with tests, so I changed it to this

my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value
=> { ft_local_hold_group => 1, branchcode => undef } } );
my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value
=> { ft_local_hold_group => 1, branchcode => undef } } );

on t/db_dependent/Holds.t on line 1058 I created 3 libraries like this

my $library1  = $builder->build_object( { class => 'Koha::Libraries' } );
my $library2  = $builder->build_object( { class => 'Koha::Libraries' } );
my $library3  = $builder->build_object( { class => 'Koha::Libraries' } );

but they needed to be pickup_locations, and sometimes they wheren't set as
such, so I changed it to this

my $library1  = $builder->build_object( { class => 'Koha::Libraries', value =>
{pickup_location => 1} } );
my $library2  = $builder->build_object( { class => 'Koha::Libraries', value =>
{pickup_location => 1} } );
my $library3  = $builder->build_object( { class => 'Koha::Libraries', value =>
{pickup_location => 1} } );

To test:
1. do not apply this patch
2. in bash:
   for i in {1..300}; do echo "loop $i"; prove t/db_dependent/Koha/Item.t
t/db_dependent/Holds.t; if [ "$?" = "1" ]; then break; fi; done
3. Grab a cup of coffee (or tea if you are healthy) and wait for a while
4. Whithin 300 iterations there should be an error in any of both scripts and
for loop should exit
5. Apply this patch
6. repeat step 2 and 3 (decaff this time!)
7. All 300 loops should pass
8. Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24658] Deleting items with fines does not update itemnumber in accountlines to NULL causing ISE

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24658

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
   Assignee|koha-b...@lists.koha-commun |ad...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24658] New: Deleting items with fines does not update itemnumber in accountlines to NULL causing ISE

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24658

Bug ID: 24658
   Summary: Deleting items with fines does not update itemnumber
in accountlines to NULL causing ISE
 Change sponsored?: ---
   Product: Koha
   Version: 19.05
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Database
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ad...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

When batch deleting items through the staff client, the itemnumber in the
accountlines table remains and does update to NULL. If you then go into the
Accountlines tab of a borrower and into the Transactions you will get an
internal server error if there is a fine in that patrons accountlines with an
itemnumber in the database for the deleted item

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

Agustín Moyano  changed:

   What|Removed |Added

 Blocks||24657


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657
[Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657

Agustín Moyano  changed:

   What|Removed |Added

 Depends on||22284
   Assignee|koha-b...@lists.koha-commun |agustinmoy...@theke.io
   |ity.org |
 Status|NEW |ASSIGNED
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||tomasco...@gmail.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284
[Bug 22284] Groups of pickup locations for holds
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24657] New: Fix tests of bug 22284 - Groups of pickup locations for holds

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657

Bug ID: 24657
   Summary: Fix tests of bug 22284 - Groups of pickup locations
for holds
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: agustinmoy...@theke.io
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Tests in bug 22284 had conditions where they randomly fail

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #301 from Agustín Moyano  ---
(In reply to Agustín Moyano from comment #300)
> (In reply to Jonathan Druart from comment #299)
> > A different failure from jenkins (D9 run 1139):
> > 
> > https://jenkins.koha-community.org/job/Koha_Master_D9/1139/consoleFull
> > 
> > 
> > koha_1   | 
> > koha_1   | #   Failed test 'Patron can place hold if no circ_rules
> > where defined'
> > koha_1   | #   at t/db_dependent/Holds.t line 1095.
> > koha_1   | # Structures begin differing at:
> > koha_1   | #  $got->{status} = 'libraryNotPickupLocation'
> > koha_1   | # $expected->{status} = 'OK'
> > koha_1   | 
> > koha_1   | #   Failed test 'Patron cannot place hold because pickup
> > location is not part of hold group'
> > koha_1   | #   at t/db_dependent/Holds.t line 1122.
> > koha_1   | # Structures begin differing at:
> > koha_1   | #  $got->{status} = 'libraryNotPickupLocation'
> > koha_1   | # $expected->{status} = 'pickupNotInHoldGroup'
> > koha_1   | 
> > koha_1   | #   Failed test 'Patron can place hold if
> > default_branch_circ_rules is set to "any" for library 2'
> > koha_1   | #   at t/db_dependent/Holds.t line 1142.
> > koha_1   | # Structures begin differing at:
> > koha_1   | #  $got->{status} = 'libraryNotPickupLocation'
> > koha_1   | # $expected->{status} = 'OK'
> > koha_1   | 
> > koha_1   | #   Failed test 'Patron cannot place hold if
> > hold_fulfillment_policy is set to "hold group" for library 2'
> > koha_1   | #   at t/db_dependent/Holds.t line 1162.
> > koha_1   | # Structures begin differing at:
> > koha_1   | #  $got->{status} = 'libraryNotPickupLocation'
> > koha_1   | # $expected->{status} = 'pickupNotInHoldGroup'
> > koha_1   | 
> > koha_1   | #   Failed test 'Patron can place hold if
> > hold_fulfillment_policy is set to "any" for itemtype 2'
> > koha_1   | #   at t/db_dependent/Holds.t line 1182.
> > koha_1   | # Structures begin differing at:
> > koha_1   | #  $got->{status} = 'libraryNotPickupLocation'
> > koha_1   | # $expected->{status} = 'OK'
> > koha_1   | 
> > koha_1   | #   Failed test 'Patron cannot place hold if
> > hold_fulfillment_policy is set to "hold group" for itemtype 2'
> > koha_1   | #   at t/db_dependent/Holds.t line 1202.
> > koha_1   | # Structures begin differing at:
> > koha_1   | #  $got->{status} = 'libraryNotPickupLocation'
> > koha_1   | # $expected->{status} = 'pickupNotInHoldGroup'
> > koha_1   | 
> > koha_1   | #   Failed test 'Patron can place hold if
> > hold_fulfillment_policy is set to "any" for itemtype 2 and library 2'
> > koha_1   | #   at t/db_dependent/Holds.t line 1222.
> > koha_1   | # Structures begin differing at:
> > koha_1   | #  $got->{status} = 'libraryNotPickupLocation'
> > koha_1   | # $expected->{status} = 'OK'
> > koha_1   | 
> > koha_1   | #   Failed test 'Patron cannot place hold if
> > hold_fulfillment_policy is set to "hold group" for itemtype 2 and library 2'
> > koha_1   | #   at t/db_dependent/Holds.t line 1242.
> > koha_1   | # Structures begin differing at:
> > koha_1   | #  $got->{status} = 'libraryNotPickupLocation'
> > koha_1   | # $expected->{status} = 'pickupNotInHoldGroup'
> > koha_1   | # Looks like you failed 8 tests of 9.
> > koha_1   | 
> > koha_1   | #   Failed test 'CanItemBeReserved / 
> > pickup_not_in_hold_group'
> > koha_1   | #   at t/db_dependent/Holds.t line 1249.
> > koha_1   | # Looks like you failed 1 test of 61.
> > koha_1   | [15:06:03] t/db_dependent/Holds.t
> 
> Hi Jonathan,
> 
> I think I spotted this failure.. should I make a new bug to fix this tests?
> 
> The random failure on Item.t I'm at a loss. Supposedly I delete every
> circulation_rule, every item, every issue and every patron, but it seems not
> everything gets deleted.. or that's what I guess.
> 
> Do you have any tip of what could be wrong?

Never mind, I think I nailed it!.. I'll submit patches in following bug!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22898] Selenium tests for placing holds from the staff interface

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22898] Selenium tests for placing holds from the staff interface

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #21 from Martin Renvoize  ---
We're better off with these tests than without.. they are all currently passing
and read ok.. Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22898] Selenium tests for placing holds from the staff interface

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #98879|0   |1
is obsolete||

--- Comment #20 from Martin Renvoize  ---
Created attachment 98882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98882=edit
Bug 22898: Fix failure since bug 19618

See comment in the code, this is not the correct fix, but cannot find
something better for now.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22898] Selenium tests for placing holds from the staff interface

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #98878|0   |1
is obsolete||

--- Comment #19 from Martin Renvoize  ---
Created attachment 98881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98881=edit
Bug 22898: Since bug 23957, submit element is now a button (no longer input)

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22898] Selenium tests for placing holds from the staff interface

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #98877|0   |1
is obsolete||

--- Comment #18 from Martin Renvoize  ---
Created attachment 98880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98880=edit
Bug 22898: Add selenium tests placing holds (staff)

Quick selenium tests to prevent regressions like bug 22895.

Test plan:
Make sure the selenium tests return green

You can also test the buggy branch:
% git checkout v18.11.05
% prove t/db_dependent/selenium/basic_workflow.t
=> Failure
% git bz apply 22895.
% prove t/db_dependent/selenium/basic_workflow.t
=> Success

Signed-off-by: Victor Grousset 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24214] Due date displayed in ISO format (when sticky)

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24214

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Version(s)|20.05.00|20.05.00, 19.05.08,
released in||19.11.03
 Status|Pushed to master|Pushed to stable

--- Comment #5 from Lucas Gass  ---
backported to 19.11.x for 19.11.03

backported to 19.05.x for 19.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24214] Due date displayed in ISO format (when sticky)

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24214

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.05.00, 19.11.03  |20.05.00, 19.11.03,
released in||19.05.08
 Status|Pushed to stable|Pushed to oldstable

--- Comment #35 from Lucas Gass  ---
backported to 19.05.x for 19.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17667] Standing orders - cancelling a receipt increase the original quantity

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17667

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.05.00, 19.11.03  |20.05.00, 19.11.03,
released in||19.05.08
 Status|Pushed to stable|Pushed to oldstable
 CC||lu...@bywatersolutions.com

--- Comment #15 from Lucas Gass  ---
backported to 19.05.x for 19.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24655] RoundFinesAtPayment can leave partial cent credits on patrons account

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24655

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24656] Koha should not allow creating partial cents fines/fees that cannot be paid in currency

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24656

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 459] No uninstall script

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=459

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #6 from Kyle M Hall  ---
(In reply to Liz Rea from comment #5)
> Why would we not use koha-remove  and then apt uninstall
> koha-common then apt autoremove?
> 
> I'm not sure this bug needs a fix anymore? A developer is going to be using
> either a devbox or a koha-testing-docker; an average user hopefully will be
> using Debian packages as advised in our documentation, and certainly,
> support vendors will be using the packages as well.

I tend to agree, but isn't installation from tarball still supported?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24656] New: Koha should not allow creating partial cents fines/fees that cannot be paid in currency

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24656

Bug ID: 24656
   Summary: Koha should not allow creating partial cents
fines/fees that cannot be paid in currency
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Fines and fees
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Koha allows for 6 decimal places in accountlines amount - most currencies do
not have units for amounts this small. We need to address this fact somehow

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24404] Add missing space on invoices page

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|20.05.00, 19.11.03  |20.05.00, 19.11.03,
released in||19.05.08
 CC||lu...@bywatersolutions.com

--- Comment #6 from Lucas Gass  ---
backported to 19.05.x for 19.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #300 from Agustín Moyano  ---
(In reply to Jonathan Druart from comment #299)
> A different failure from jenkins (D9 run 1139):
> 
> https://jenkins.koha-community.org/job/Koha_Master_D9/1139/consoleFull
> 
> 
> koha_1   | 
> koha_1   | #   Failed test 'Patron can place hold if no circ_rules
> where defined'
> koha_1   | #   at t/db_dependent/Holds.t line 1095.
> koha_1   | # Structures begin differing at:
> koha_1   | #  $got->{status} = 'libraryNotPickupLocation'
> koha_1   | # $expected->{status} = 'OK'
> koha_1   | 
> koha_1   | #   Failed test 'Patron cannot place hold because pickup
> location is not part of hold group'
> koha_1   | #   at t/db_dependent/Holds.t line 1122.
> koha_1   | # Structures begin differing at:
> koha_1   | #  $got->{status} = 'libraryNotPickupLocation'
> koha_1   | # $expected->{status} = 'pickupNotInHoldGroup'
> koha_1   | 
> koha_1   | #   Failed test 'Patron can place hold if
> default_branch_circ_rules is set to "any" for library 2'
> koha_1   | #   at t/db_dependent/Holds.t line 1142.
> koha_1   | # Structures begin differing at:
> koha_1   | #  $got->{status} = 'libraryNotPickupLocation'
> koha_1   | # $expected->{status} = 'OK'
> koha_1   | 
> koha_1   | #   Failed test 'Patron cannot place hold if
> hold_fulfillment_policy is set to "hold group" for library 2'
> koha_1   | #   at t/db_dependent/Holds.t line 1162.
> koha_1   | # Structures begin differing at:
> koha_1   | #  $got->{status} = 'libraryNotPickupLocation'
> koha_1   | # $expected->{status} = 'pickupNotInHoldGroup'
> koha_1   | 
> koha_1   | #   Failed test 'Patron can place hold if
> hold_fulfillment_policy is set to "any" for itemtype 2'
> koha_1   | #   at t/db_dependent/Holds.t line 1182.
> koha_1   | # Structures begin differing at:
> koha_1   | #  $got->{status} = 'libraryNotPickupLocation'
> koha_1   | # $expected->{status} = 'OK'
> koha_1   | 
> koha_1   | #   Failed test 'Patron cannot place hold if
> hold_fulfillment_policy is set to "hold group" for itemtype 2'
> koha_1   | #   at t/db_dependent/Holds.t line 1202.
> koha_1   | # Structures begin differing at:
> koha_1   | #  $got->{status} = 'libraryNotPickupLocation'
> koha_1   | # $expected->{status} = 'pickupNotInHoldGroup'
> koha_1   | 
> koha_1   | #   Failed test 'Patron can place hold if
> hold_fulfillment_policy is set to "any" for itemtype 2 and library 2'
> koha_1   | #   at t/db_dependent/Holds.t line 1222.
> koha_1   | # Structures begin differing at:
> koha_1   | #  $got->{status} = 'libraryNotPickupLocation'
> koha_1   | # $expected->{status} = 'OK'
> koha_1   | 
> koha_1   | #   Failed test 'Patron cannot place hold if
> hold_fulfillment_policy is set to "hold group" for itemtype 2 and library 2'
> koha_1   | #   at t/db_dependent/Holds.t line 1242.
> koha_1   | # Structures begin differing at:
> koha_1   | #  $got->{status} = 'libraryNotPickupLocation'
> koha_1   | # $expected->{status} = 'pickupNotInHoldGroup'
> koha_1   | # Looks like you failed 8 tests of 9.
> koha_1   | 
> koha_1   | #   Failed test 'CanItemBeReserved / pickup_not_in_hold_group'
> koha_1   | #   at t/db_dependent/Holds.t line 1249.
> koha_1   | # Looks like you failed 1 test of 61.
> koha_1   | [15:06:03] t/db_dependent/Holds.t

Hi Jonathan,

I think I spotted this failure.. should I make a new bug to fix this tests?

The random failure on Item.t I'm at a loss. Supposedly I delete every
circulation_rule, every item, every issue and every patron, but it seems not
everything gets deleted.. or that's what I guess.

Do you have any tip of what could be wrong?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22898] Selenium tests for placing holds from the staff interface

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898

--- Comment #17 from Jonathan Druart  
---
I skip the 18.11 patch.

New test plan:
Make sure the tests pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22898] Selenium tests for placing holds from the staff interface

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898

--- Comment #16 from Jonathan Druart  
---
Created attachment 98879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98879=edit
Bug 22898: Fix failure since bug 19618

See comment in the code, this is not the correct fix, but cannot find
something better for now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22898] Selenium tests for placing holds from the staff interface

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898

--- Comment #15 from Jonathan Druart  
---
Created attachment 98878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98878=edit
Bug 22898: Since bug 23957, submit element is now a button (no longer input)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22898] Selenium tests for placing holds from the staff interface

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22898] Selenium tests for placing holds from the staff interface

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #90208|0   |1
is obsolete||
  Attachment #90241|0   |1
is obsolete||
  Attachment #97655|0   |1
is obsolete||
  Attachment #97656|0   |1
is obsolete||

--- Comment #14 from Jonathan Druart  
---
Created attachment 98877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98877=edit
Bug 22898: Add selenium tests placing holds (staff)

Quick selenium tests to prevent regressions like bug 22895.

Test plan:
Make sure the selenium tests return green

You can also test the buggy branch:
% git checkout v18.11.05
% prove t/db_dependent/selenium/basic_workflow.t
=> Failure
% git bz apply 22895.
% prove t/db_dependent/selenium/basic_workflow.t
=> Success

Signed-off-by: Victor Grousset 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24655] New: RoundFinesAtPayment can leave partial cent credits on patrons account

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24655

Bug ID: 24655
   Summary: RoundFinesAtPayment can leave partial cent credits on
patrons account
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Fines and fees
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

To recreate:
1 - Create a manual invoice for 1.4286 for a patron
2 - Enable RoundFinesAtPayment
3 - Pay 1.43 on the patrons account
4 - The fine is paid off, however, if you view the accountlines in the DB the
patron has a credit of .0014

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24367] With strict enabled, Search.t is too verbose

2020-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24367

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #14 from Martin Renvoize  ---
I still see one final warning: 

Use of uninitialized value in concatenation (.) or string at
/kohadevbox/koha/C4/Search.pm line 1818.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   4   >