[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||24715


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24715
[Bug 24715] Cache repeatable subfield in TransformKohaToMarc
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24715] Cache repeatable subfield in TransformKohaToMarc

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24715

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24715] Cache repeatable subfield in TransformKohaToMarc

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24715

Marcel de Rooy  changed:

   What|Removed |Added

 Depends on||21800


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800
[Bug 21800] TransformKohaToMarc should respect non-repeatability of item
subfields
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24715] Cache repeatable subfield in TransformKohaToMarc

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24715

Marcel de Rooy  changed:

   What|Removed |Added

 CC||ere.maij...@helsinki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24715] New: Cache repeatable subfield in TransformKohaToMarc

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24715

Bug ID: 24715
   Summary: Cache repeatable subfield in TransformKohaToMarc
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

Follow-up of bug 21800

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800

--- Comment #15 from Marcel de Rooy  ---
(In reply to Ere Maijala from comment #13)
> Sorry, I'd say that caching is pretty crucial. TransformKohaToMarc is used
> also e.g. in the Elasticsearch index builder, OAI-PMH Provider and exporter
> (really, anything that calls e.g. EmbedItemsInMarcBiblio).

Will address that on a new report then.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800

--- Comment #14 from Marcel de Rooy  ---
(In reply to Ere Maijala from comment #13)
> Ok, I'm fine with the framework stuff, but it strikes me a bit odd that we
> use mapping from default framework and repeatability from another. Unless
> I'm completely lost it provides ample opportunity for user confusion.

The interface follows this line. No frameworks in Koha to MARC mappings. No
possibility to change kohafield in framework editor (as before).
All other fields (like repeatability) are framework based.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800

Ere Maijala  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #13 from Ere Maijala  ---
Ok, I'm fine with the framework stuff, but it strikes me a bit odd that we use
mapping from default framework and repeatability from another. Unless I'm
completely lost it provides ample opportunity for user confusion.

Sorry, I'd say that caching is pretty crucial. TransformKohaToMarc is used also
e.g. in the Elasticsearch index builder, OAI-PMH Provider and exporter (really,
anything that calls e.g. EmbedItemsInMarcBiblio).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24697] Split items.uri on staff detail view

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24697

--- Comment #4 from Marcel de Rooy  ---
(In reply to Bernardo Gonzalez Kriegel from comment #3)
> Signed-off-by: Bernardo Gonzalez Kriegel 
> Works as described, no errors.

Thx Bernardo

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710

--- Comment #6 from Katrin Fischer  ---
Hi Lucas, if you do a follow-up (a second patch with the requested changes)
next time, you can keep the signed-off status most of the time (also applies to
bug 23547) and the original sign-offer won't be lost either. It's how we
usually handle things once the first sign-off has been achieved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24605] Series link from 830 is not uri encoded

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
Hi Bernardo, you also need a 490 where the indicator is set to traced.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23064] Cannot edit subscription with strict SQL modes turned on

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064

Hayley Mapley  changed:

   What|Removed |Added

 Version(s)|20.05.00, 19.11.03, |20.05.00, 19.11.03,
released in|19.05.08|19.05.08, 18.11.15
 Status|Pushed to oldstable |Pushed to oldoldstable

--- Comment #19 from Hayley Mapley  ---
Backported to 18.11.x for 18.11.15.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Delegate background jobs execution

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #29 from David Cook  ---
I won't be at the Marseille hackfest, but maybe some folk will think about
working on this there next month?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24693] GD is declared as an optional dependency but Koha dies without it

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #99299|0   |1
is obsolete||

--- Comment #2 from Bernardo Gonzalez Kriegel  ---
Created attachment 99475
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99475=edit
Bug 24693: Move GD from recommends to requires in cpanfile

Without it, catalogue/detail.pl dies (and probably other scripts too)

Test plan:
1. Uninstall GD, reload starman
2. Go to catalogue/detail.pl. Confirm that it dies
3. Reinstall GD, reload starman
4. Go to catalogue/detail.pl. Confirm that it work normally

Signed-off-by: Bernardo Gonzalez Kriegel 
catalogue/detail.pl dies without GD.
Seems correct switch to require
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24693] GD is declared as an optional dependency but Koha dies without it

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24605] Series link from 830 is not uri encoded

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com

--- Comment #2 from Bernardo Gonzalez Kriegel  ---
Hi,
What kind of record is needed?
I edited a record to add an 830 field, does not show in the opac.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24527] misc/cronjobs/update_totalissues.pl problem with multiple items

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24527

--- Comment #2 from Bernardo Gonzalez Kriegel  ---
Created attachment 99474
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99474=edit
Bug 24527: misc/cronjobs/update_totalissues.pl problem with multiple items

misc/cronjobs/update_totalissues.pl when issuing statistics table,
no-incremental,  has a problem for biblio with multiple items.
The first SQL query gets the biblios linked to items with issues in statistics
:

SELECT biblio.biblionumber, COUNT(statistics.itemnumber) FROM biblio LEFT JOIN
items ON (biblio.biblionumber=items.biblionumber) LEFT JOIN statistics ON
(items.itemnumber=statistics.itemnumber) WHERE statistics.type = 'issue' $limit
GROUP BY biblio.biblionumber

The second SQL query is :
SELECT biblio.biblionumber, 0 FROM biblio LEFT JOIN items ON
(biblio.biblionumber=items.biblionumber) LEFT JOIN statistics ON
(items.itemnumber=statistics.itemnumber) WHERE statistics.itemnumber IS NULL
GROUP BY biblio.biblionumber

The problem is that this second query will set to 0 where ANY item has no entry
in statistics table.
So when running it sets 0 to the biblio that had a value from first
query.

I think the best fix is to use "WHERE statistics.type = 'issue'" inside que
JOIN :
LEFT JOIN statistics ON (items.itemnumber=statistics.itemnumber AND
statistics.type = 'issue')

Test plan :
1) Begin with an empty database
2) Create a biblio 1 with no items
3) Create a biblio 2 with 3 items
4) Create a biblio 3 with 2 items
5) Checkout and checkin all items of biblio 2
6) Checkout and checkin the firt item of biblio 3
7) run misc/cronjobs/update_totalissues.pl --use-stats -v
8) Check biblio 1 has biblioitems.totalissues = 0
9) Check biblio 2 has biblioitems.totalissues = 3
10) Without patch the biblio 3 has biblioitems.totalissues = 0
11) With patch the biblio 3 has biblioitems.totalissues = 1
12) Check misc/cronjobs/update_totalissues.pl --incremental is OK

Signed-off-by: Bernardo Gonzalez Kriegel 
Work as described following test plan.
totalissues is calculated correctly, incremental works ok.
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24527] misc/cronjobs/update_totalissues.pl problem with multiple items

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24527

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24291] Explanation next to limit item types by library is confusing

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24291

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24291] Explanation next to limit item types by library is confusing

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24291

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #97939|0   |1
is obsolete||

--- Comment #2 from Bernardo Gonzalez Kriegel  ---
Created attachment 99473
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99473=edit
Bug 24291: Update the item type form text for library limitation field

Bug 15497 introduced the ability to limit item types by library.
However, the text next to the 'Library limitation' selection field on
the item type form mentions authorized values and is confusing.

The current text reads: "Select 'All libraries' if this authorized value
must be displayed all the time. Otherwise select libraries you want to
associate with this value."

This patch updates the text on the item type add or edit form for the
'Library limitation' field to something more understandable.

To test:
1) Apply the patch
2) Go to Administration > Basic parameters > Item types
3) Click 'Edit' for any item type
4) The text next to the 'Library limitation' field should now show
"Select 'All libraries' if all libraries use this item type. Otherwise,
select the specific libraries that use this item type."
5) Sign off

Signed-off-by: Bernardo Gonzalez Kriegel 
String change, no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9989] Closing a basket without creating a basketgroup should not redirect to baskets list

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9989

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED

--- Comment #8 from Aleisha Amohia  ---
Ah yup understood, thanks Katrin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9989] Closing a basket without creating a basketgroup should not redirect to baskets list

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9989

--- Comment #7 from Katrin Fischer  ---
Hi Aleiha, 

when there was only one page where you could close the basket (the basket
summary page) this made a lot of sense - and it still does. 
The problem is that a not so long while ago another page was added where you
can close the basket - the 'search result' page when you search for the vendor.
So the thing that was strange here, that it would not return to the page where
you started from, applies now there.

Would it be possible to just return to the page where you came from?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9989] Closing a basket without creating a basketgroup should not redirect to baskets list

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9989

--- Comment #6 from Aleisha Amohia  ---
I wrote a patch addressing the solution in the description of this bug. If we
don't want that solution anymore, surely just close the bug report?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17016] Button to clear all fields in budget planning

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17016

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710

Lucas Gass  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710

Lucas Gass  changed:

   What|Removed |Added

  Attachment #99451|0   |1
is obsolete||

--- Comment #5 from Lucas Gass  ---
Created attachment 99472
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99472=edit
Bug 24710: Add span classes to patron first/other/sur names

This patch adds some  elements with classes to patron-title.inc
TEST PLAN:
1. Have a patron with a title, firstname, surname, and othername
2. Apply patch
3. There should be no visible changes but if you inscept each element you
should see seperate elements with clases.
4. Add each of these to IntranetUserCSS  to make sure it hides that element
(this effects patroninfo section AND breadcrumbs)
.firstname {display: none;}
.othernames {display:none};
.surname{display:none;}
.title{display:none;}
5. Sign-off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23547] Add column configuration to course reserves table in the OPAC

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23547

--- Comment #5 from Lucas Gass  ---
re-added the dataTables confiuration line to allow for a search bar within the
table. reset to needs signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23547] Add column configuration to course reserves table in the OPAC

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23547

Lucas Gass  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23547] Add column configuration to course reserves table in the OPAC

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23547

Lucas Gass  changed:

   What|Removed |Added

  Attachment #99339|0   |1
is obsolete||

--- Comment #4 from Lucas Gass  ---
Created attachment 99471
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99471=edit
Bug 23547: Add column configuration to course reserves table in the OPAC

This patch adds opac-course-reserves to the column config tool
TEST PLAN:
1. Have some course reserves and go look at opac-course-reserves.pl
2. See all the unconfigurable columns
3. Apply patch
4. Browse to column config > OPAC > course_reserves_table
5. Try hiding each column and make sure the correct column is hidden on
opac-course-reserves.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24701] Add column configuration to course_items_table in the OPAC

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701

--- Comment #7 from Lucas Gass  ---
Cait,

It looks like I was missing a dataTable configuation, I added this back in.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24701] Add column configuration to course_items_table in the OPAC

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701

Lucas Gass  changed:

   What|Removed |Added

  Attachment #99469|0   |1
is obsolete||

--- Comment #6 from Lucas Gass  ---
Created attachment 99470
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99470=edit
Bug 24701: Add column config to course_items_table

This patch adds course_items_table to the column config tool
TEST PLAN:
1. Have some course reserves
2. Add some items to that course reserve and browse to opac-course-details
2. See all the unconfigurable columns
3. Apply patch
4. Browse to column config > OPAC > opac-course-details
5. Try hiding each column and make sure the correct column is hidden on
opac-course-details.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24701] Add column configuration to course_items_table in the OPAC

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701

Lucas Gass  changed:

   What|Removed |Added

  Attachment #99455|0   |1
is obsolete||

--- Comment #5 from Lucas Gass  ---
Created attachment 99469
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99469=edit
Bug 24701: Add column config to course_items_table

This patch adds course_items_table to the column config tool
TEST PLAN:
1. Have some course reserves
2. Add some items to that course reserve and browse to opac-course-details
2. See all the unconfigurable columns
3. Apply patch
4. Browse to column config > OPAC > opac-course-details
5. Try hiding each column and make sure the correct column is hidden on
opac-course-details.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24701] Add column configuration to course_items_table in the OPAC

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701

Lucas Gass  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13412] Allow configuration of auto-created authorities

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13412

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #3 from David Nind  ---
The patch still applies!

Not sure whether comment 2 needs to be addressed (make it work when creating
from the command line) so that bug can progress.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

--- Comment #94 from David Nind  ---
Similar to Bug 17229 you get an error on the patron's page when following the
test plan (step 2 before patch), but before trying to apply the patch:

1) For the patron, the holds tab heading shows that there is a hold (1).

2) When you click on the patron's holds tab a message pops up with "DataTables
warning: table id=holds-table - Ajax error. For more information about this
error, please see http://datatables.net/tn/7;

3) The bibliographic record shows that there is a hold.

I'm assuming that is because the DataTables feature for displaying results is a
more recent addition to Koha.

(Test URL I used for ILS_DI was
http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldTitle_id=19_id=15_location='127.0.0.1'
using koha-testing-docker)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||da...@davidnind.com

--- Comment #93 from David Nind  ---
Patch no longer applies:

root@e83d8895749e:koha(bz11999)$ git bz apply 11999
Bug 11999 - Add two checks in CanBookBeReserved and CanItemBeReserved

91581 - Bug 11999: Check for age restriction in CanBookBeReserved
91591 - Bug 11999: Add maxreserves check in CanBookBeReserved and
CanItemBeReserved
91593 - Bug 11999: Test improvements

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 11999: Check for age restriction in CanBookBeReserved
error: sha1 information is lacking or useless (C4/Reserves.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 11999: Check for age restriction in CanBookBeReserved

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24699] Split items.uri on OPAC detail page

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24699

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #99355|0   |1
is obsolete||

--- Comment #2 from Bernardo Gonzalez Kriegel  ---
Created attachment 99468
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99468=edit
Bug 24699: Split items.uri in OPAC detail view

Same change as in bug 24697 for staff. If there are more URIs in 952u,
we split them and show the real URL instead of Link to resource or the
value of pref URLLinkText.

I introduced a few template variables here to make the code a bit more
compact and readable.

Signed-off-by: Bernardo Gonzalez Kriegel 
Work as described, no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24699] Split items.uri on OPAC detail page

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24699

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24697] Split items.uri on staff detail view

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24697

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #99354|0   |1
is obsolete||

--- Comment #3 from Bernardo Gonzalez Kriegel  ---
Created attachment 99467
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99467=edit
Bug 24697: Split items.uri on staff detail view

If there are more URIs, we split on vertical bar and show the real URL
instead of duplicated text. Otherwise display depends on the pref
URLLinkText.

Test plan:
Create item with uri = A | B | C
Create another item with uri = D
Check the results on staff detail view (items table).

Signed-off-by: Bernardo Gonzalez Kriegel 
Works as described, no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24697] Split items.uri on staff detail view

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24697

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23980] [18.11] Non existent include prevents template display

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23980

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com

--- Comment #12 from Bernardo Gonzalez Kriegel  ---
Hi, is this still valid?
I tested using 18.11.14 and error message from test plan does not show.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23510] Allow QR codes to be used in label/patroncard creator

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23510

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24711] Can't log in to OPAC after logout if OpacPublic disabled

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24711

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24711] Can't log in to OPAC after logout if OpacPublic disabled

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24711

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #99457|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 99466
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99466=edit
Bug 24711: Don't add logout input to login form

To test:
1 - Set OpacPublic syspref to 'Disable'
2 - Log in to OPAC
3 - Log out
4 - Try to log in again
5 - No error, but you get the login form again
6 - Apply patch
7 - Repeat
8 - This time you can log in again

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24706] Toolbar not rendered correctly when a list is empty

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24706

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #99391|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 99465
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99465=edit
Bug 24706: Fix ergonomic issue on the list view if empty

If the list is empty, the toolbar does not render correctly.
Buttons are displayed instead of links, also the "Sort" is displayed
when it should not

Test plan:
- Create a new list, do not add items
- Notice that the toolbar now renders correctly
- Use the different link to create/edit/delete
- Confirm that the sort link is not displayed
- Add a new item
- Confirm that the toolbar is looking the same as before

Signed-off-by: Sally 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24706] Toolbar not rendered correctly when a list is empty

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24706

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24701] Add column configuration to course_items_table in the OPAC

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701

Katrin Fischer  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org
 Status|Signed Off  |Failed QA

--- Comment #4 from Katrin Fischer  ---
Love the patch, but sadly it removes the 'search' input field above the table
in my tests, that we have without the configuration. :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24646] RoundFinesAtPayment is not a self check in preference

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #99459|0   |1
is obsolete||

--- Comment #9 from Katrin Fischer  ---
Created attachment 99464
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99464=edit
Bug 24646: Move RoundFinesAtPayment to 'Fines policy' section

To test:
 - Search Admin->System preferences for 'RoundFinesAtPayment'
 - Note it is listed under self-check
 - Apply patch
 - Restart/refresh
 - Note it is now under Accounting -> Policy

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24646] RoundFinesAtPayment is not a self check in preference

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
Hi Lucas, looking at the patch I wonder why some classes seem to be missing:

 [%- IF display_patron_name -%]
 [%- IF data.category_type == 'I' -%]
-[%- data.surname | html %] [% IF data.othernames %] ([%
data.othernames | html %])[% END -%]
+[%- data.surname | html %] [% IF
data.othernames %] ([% data.othernames | html
%])[% END -%]
 [%- ELSIF invert_name -%]
-[% data.title | $raw %][%- data.surname | html %], [% data.firstname |
html %] [% IF data.othernames %] ([% data.othernames | html %]) [% END -%]
+[% data.title | $raw %][%- data.surname | html %], [% data.firstname | html %] [% IF data.othernames %]
([% data.othernames | html %]) [% END -%]

Here the surname could have a class as well, to keep things consistent.


 [%- ELSE -%]
-[% data.title | $raw %][%- data.firstname | html %] [% IF
data.othernames %] ([% data.othernames | html %]) [% END %] [% data.surname |
html -%]
+[% data.title | $raw %][%- data.firstname |
html %] [% IF data.othernames %]([%
data.othernames | html %]) [% END %] [%
data.surname | html -%]


Should we add a class for title as well?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229

--- Comment #38 from David Nind  ---
You get an error on the patron's page when following the test plan, but before
trying to apply the patch - the URL is entered:

1) For the patron, the holds tab heading shows that there is a hold (1).

2) When you click on the patron's holds tab a message pops up with "DataTables
warning: table id=holds-table - Ajax error. For more information about this
error, please see http://datatables.net/tn/7;

3) The bibliographic record shows that there is a hold.

Other notes for testing:

- Enable the ILS-DI system preference
- The BlockExpiredPatronOpacActions system preference options are now 'Block'
and 'Don't block', rather then 'ON'
- For the URL, enter the bibliographic record id, not an individual item id

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24707] Remove AMICUS from default fr-CA z39.50 servers

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24707

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #99458|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 99463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99463=edit
Bug 24707: Remove AMICUS from default fr-CA z39.50 servers

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24707] Remove AMICUS from default fr-CA z39.50 servers

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24707

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
Might have a little conflict with bug 24708, but should be easy to resolve for
RM ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24707] Remove AMICUS from default fr-CA z39.50 servers

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24707

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24708] Update Z39.50 server attribute in fr-CA installation file

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24708

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #99430|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 99462
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99462=edit
Bug 24708: Update Z39.50 server attribute in fr-CA installation file

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24708] Update Z39.50 server attribute in fr-CA installation file

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24708

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24701] Add column configuration to course_items_table in the OPAC

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
Thx Lucas and Lisette!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24588] Set `Mailer-X` and `MessageID` mail headers to reduce the likelihood of Koha mail being marked as spam

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588

Katrin Fischer  changed:

   What|Removed |Added

Summary|Set `Mailer-X` and  |Set `Mailer-X` and
   |`MessageID` mail headers to |`MessageID` mail headers to
   |reduce the likelihood of|reduce the likelihood of
   |Koha mail being marked as   |Koha mail being marked as
   |spam.   |spam

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24262] Translate installer data in YAML format

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #11 from Katrin Fischer  ---
(In reply to Martin Renvoize from comment #10)
> OK.. I'm loving this work..
> 
> I just had a moment of inspiration though.. what about upgrades?
> 
> Currently, we add to both an atomicupdate file (which gets put into
> updatedatabase) and add nearly the same code into various .SQL files (now
> becoming .yaml files) for install time.  I'm now wondering if as a further
> bug we could add a function into updatedatabase to walk through the tree of
> yaml files to install translated missing default data at the end of any run
> of updatedatabase and save ourselves from having to write the atomicupdate
> and the yaml file for such DB changes?

I think this might get a little too complicated. For example libraries might
have removed sample data on purpose, changed or reconfigured it. It would be
hard to differentiate. We will want to add a new notice on update, but should
respect if a library deleted it etc. (hope I understood correctly). So I think
having different mechanisms (triggered for new and for a specific update) would
be better.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||da...@davidnind.com

--- Comment #37 from David Nind  ---
Patch no longer applies

Applying: Bug 17229: Add unit test for BlockExpiredPatronOpacActions check
.git/rebase-apply/patch:41: space before tab in indent.
dateexpiry => '2000-01-01',
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M   t/db_dependent/Holds.t
.git/rebase-apply/patch:41: space before tab in indent.
dateexpiry => '2000-01-01',
.git/rebase-apply/patch:56: new blank line at EOF.
+
warning: 1 line applied after fixing whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Holds.t
CONFLICT (content): Merge conflict in t/db_dependent/Holds.t
error: Failed to merge in the changes.
Patch failed at 0001 Bug 17229: Add unit test for BlockExpiredPatronOpacActions
check

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV

2020-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #90 from David Nind  ---
Sorry, the patch no longer applies 8-(... 

Applying: Bug 7957: Routing lists enhancements
.git/rebase-apply/patch:146: trailing whitespace.
 FROM serial 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M   C4/Serials.pm
M   installer/data/mysql/kohastructure.sql
M   serials/routing-preview.pl
.git/rebase-apply/patch:146: trailing whitespace.
 FROM serial 
warning: 1 line adds whitespace errors.
Falling back to patching base and 3-way merge...
Removing serials/routing.pl
CONFLICT (modify/delete): serials/routing-preview.pl deleted in Bug 7957:
Routing lists enhancements and modified in HEAD. Version HEAD of
serials/routing-preview.pl left in tree.
Removing serials/reorder_members.pl
Removing koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt
Removing koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing-preview.tt
Auto-merging installer/data/mysql/kohastructure.sql
Auto-merging C4/Serials.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 7957: Routing lists enhancements

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/