[Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate Guarantor Information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808 --- Comment #7 from Alex Buckley --- Created attachment 100844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100844=edit Bug 23808: Added missing filter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 David Nind changed: What|Removed |Added Attachment #100817|0 |1 is obsolete|| --- Comment #179 from David Nind --- Created attachment 100843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100843=edit Bug 11879: Add a new field to patron record: main contact method Fixed the problem mentioned above. Test plan is same as before: 0) Apply patch 1) updatedatabase.pl 2) In the staff client, edit a patron's contact info. There should be a new dropdown select to choose the main contact method 3) In the opac page, edit the personal details.There should be a new dropdown select to choose the main contact method. 4) Save the form. It should work. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate Guarantor Information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Change sponsored?|--- |Sponsored Version|18.11 |master --- Comment #6 from Alex Buckley --- Hi all, I have replicated the bug behaviour George mentioned in comment #1 on master. Which is slightly different to what Kelly mentioned in 'Description'. Currently in master if you 'Add guarantee' from Adult's patron form then the guarantor/adults details are not pre-filled in the 'Guarantor information' section of memberentry.pl I've written a patch fix to solve that. Please have a test and let me know how you get on. Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate Guarantor Information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808 Alex Buckley changed: What|Removed |Added Attachment #100841|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate Guarantor Information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808 --- Comment #5 from Alex Buckley --- Created attachment 100842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100842=edit Bug 23808: Pre-fill guarantor fields when adding guarantee to guarantor Bug 14570 removed the guarantor pre-fill functionality when selecting 'Add guarantee' to an Adult patron. This is because guarantor information would now only display if (1) the patron record exists (which it won't when first adding guarantee to guarantor record) and (2) if there is already a guarantor added to a guarantee This patchfix will pre-fill guarantor fields if no relationship (existing guarantor data exists) and a guarantor_id is handed to memberenty.pl in URL when clicking 'Add guarantee' button on Adults patron record. Test plan: 1. Add adult patron 2. Select 'Add guarantee' 3. Observe no details of the adult patron are displaying in the 'Guarantor information' section of the memberentry.pl page 4. Select 'Search to add', search for your adult patron and choose 'Select' to add them as guarantor 5. Fill out rest of memberentry.pl and 'Save' 6. Observe adult is showing as the guarantor 7. Apply patch 8. Run tests: sudo koha-shell prove xt prove t 9. Confirm tests pass 10. Return to your adult patron 11. Select 'Add guarantee' 12. Observe in 'Guarantor information' section of memberentry.pl pre-filled is the 'patron #' (borrowernumber), surname, firstname 13. Fill out the rest of memberenty.pl and save and confirm your adult patron is showing as the guarantor 14. Repeat steps 10,11 and 12 and in the 'Guarantor information' select 'Search to add' and add another adult as guarantor 15. Fill out the rest of memberentry.pl and 'Save' and notice with this patch applied you can still add multiple guarantors successfully Sponsored-By: South Taranaki Distict Libraries, NZ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13547] Item field 'Materials specified' would be useful to see in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547 --- Comment #9 from Christopher Brannon --- (In reply to Katrin Fischer from comment #8) > This patch works as expected, but there is a little catch: For libraries, > that have used this field to add information that is patron privacy relevant > (like the name of someone), this change might be problematic. I have seen > this happening, as the field will show up on checkout/checkin in a prominent > way. (When returned, hand over to X next or something like that). > > Even when the materials column is hidden, it's still fully visible in the > source code. > > Would it be possible not to pass it to the template if the column > configuration is set to not display it? Is it fair to withhold this functionality because some might be using it for something it wasn't intended for? How many other fields are used in a similar fashion? I can understand this caution on a field that was meant to hold sensitive information, but I am not sure about this one. Maybe it could be suppressed with column configuration, but unless we treat other fields the same way, this suppression might get lost in future upgrades because it doesn't coincide with other column practices. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #6 from Christopher Brannon --- This could be resolved in a combination of ways. One way would be to send an e-mail to specific addresses when the hold is cancelled. Another would be to have an alert on the staff screen, along with the moderation alerts. It should give several pieces of information about the item, the patron it was on hold for, when it was placed on hold, when it was to expire, and when it was cancelled. Most of this information is for tracking the item down, depending on how the library shelved it. I am for having a way for the patron to cancel the hold. And I don't think it is optics. Before, if the hold was cancelled, it was on the hold shelf and just sat there. That was the optics. Here, if staff are notified in some way, it moves back into circulation faster. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 --- Comment #2 from Christopher Brannon --- (In reply to Katrin Fischer from comment #1) > This reads a bit similar to bug 11722, could these be duplicates? Not sure. That was 6 years ago. This gives a better explanation, if it is. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate Guarantor Information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808 Alex Buckley changed: What|Removed |Added Attachment #100840|0 |1 is obsolete|| --- Comment #4 from Alex Buckley --- Created attachment 100841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100841=edit Bug 23808: Pre-fill guarantor fields when adding guarantee to guarantor Bug 14570 removed the guarantor pre-fill functionality when selecting 'Add guarantee' to an Adult patron. This is because guarantor information would now only display if (1) the patron record exists (which it won't when first adding guarantee to guarantor record) and (2) if there is already a guarantor added to a guarantee This patchfix will pre-fill guarantor fields if no relationship (existing guarantor data exists) and a guarantorid is handed to memberenty.pl in URL when clicking 'Add guarantee' button on Adults patron record. Test plan: 1. Add adult patron 2. Select 'Add guarantee' 3. Observe no details of the adult patron are displaying in the 'Guarantor information' section of the memberentry.pl page 4. Select 'Search to add', search for your adult patron and choose 'Select' to add them as guarantor 5. Fill out rest of memberentry.pl and 'Save' 6. Observe adult is showing as the guarantor 7. Apply patch 8. Run tests: sudo koha-shell prove xt prove t 9. Confirm tests pass 10. Return to your adult patron 11. Select 'Add guarantee' 12. Observe in 'Guarantor information' section of memberentry.pl pre-filled is the 'patron #' (borrowernumber), surname, firstname 13. Fill out the rest of memberenty.pl and save and confirm your adult patron is showing as the guarantor 14. Repeat steps 10,11 and 12 and in the 'Guarantor information' select 'Search to add' and add another adult as guarantor 15. Fill out the rest of memberentry.pl and 'Save' and notice with this patch applied you can still add multiple guarantors successfully Sponsored-By: South Taranaki Distict Libraries, NZ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate Guarantor Information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808 --- Comment #3 from Alex Buckley --- Created attachment 100840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100840=edit Bug 23808: Pre-fill guarantor fields when adding guarantee to guarantor Bug 14570 removed the guarantor pre-fill functionality when selecting 'Add guarantee' to an Adult patron. This is because guarantor information would now only display if (1) the patron record exists (which it won't when first adding guarantee to guarantor record) and (2) if there is already a guarantor added to a guarantee This patchfix will pre-fill guarantor fields if no relationship (existing guarantor data exists) and a guarantorid is handed to memberenty.pl in URL when clicking 'Add guarantee' button on Adults patron record. Test plan: 1. Add adult patron 2. Select 'Add guarantee' 3. Observe no details of the adult patron are displaying in the 'Guarantor information' section of the memberentry.pl page 4. Select 'Search to add', search for your adult patron and choose 'Select' to add them as guarantor 5. Fill out rest of memberentry.pl and 'Save' 6. Observe adult is showing as the guarantor 7. Apply patch 8. Run tests: sudo koha-shell prove xt prove t 9. Confirm tests pass 10. Return to your adult patron 11. Select 'Add guarantee' 12. Observe in 'Guarantor information' section of memberentry.pl pre-filled is the 'patron #' (borrowernumber), surname, firstname 13. Fill out the rest of memberenty.pl and save and confirm your adult patron is showing as the guarantor 14. Repeat steps 10,11 and 12 and in the 'Guarantor information' select 'Search to add' and add another adult as guarantor 15. Fill out the rest of memberentry.pl and 'Save' and notice with this patch applied you can still add multiple guarantors successfully Sponsored-By: South Taranaki Distict Libraries, NZ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate Guarantor Information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808 Alex Buckley changed: What|Removed |Added Attachment #100839|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate Guarantor Information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808 Alex Buckley changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate Guarantor Information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808 --- Comment #2 from Alex Buckley --- Created attachment 100839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100839=edit Bug 23808: Pre-fill guarantor fields when adding guarantee to guarantor Bug 14570 removed the guarantor pre-fill functionality when selecting 'Add guarantee' to an Adult patron. This is because guarantor information would now only display if (1) the patron record exists (which it won't when first adding guarantee to guarantor record) and (2) if there is already a guarantor added to a guarantee This patchfix will pre-fill guarantor fields if no relationship (existing guarantor data exists) and a guarantorid is handed to memberenty.pl in URL when clicking 'Add guarantee' button on Adults patron record. Test plan: 1. Add adult patron 2. Select 'Add guarantee' 3. Observe no details of the adult patron are displaying in the 'Guarantor information' section of the memberentry.pl page 4. Select 'Search to add', search for your adult patron and choose 'Select' to add them as guarantor 5. Fill out rest of memberentry.pl and 'Save' 6. Observe adult is showing as the guarantor 7. Apply patch 8. Run tests: sudo koha-shell prove xt prove t 9. Confirm tests pass 10. Return to your adult patron 11. Select 'Add guarantee' 12. Observe in 'Guarantor information' section of memberentry.pl pre-filled is the 'patron #' (borrowernumber), surname, firstname 13. Fill out the rest of memberenty.pl and save and confirm your adult patron is showing as the guarantor 14. Repeat steps 10,11 and 12 and in the 'Guarantor information' select 'Searcg to add' and add another adult as guarantor 15. Fill out the rest of memberentry.pl and 'Save' and notice with this patch applied you can still add multiple guarantors successfully Sponsored-By: South Taranaki Distict Libraries, NZ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24886] New: Reindent reports template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886 Bug ID: 24886 Summary: Reindent reports template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org I propose to reformat the reports template (guided_reports_start.tt) so that it has consistent spacing and indentation. Let this bug race with Bug 24885 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page (19.11.x)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874 Mason James changed: What|Removed |Added Attachment #100836|0 |1 is obsolete|| --- Comment #8 from Mason James --- Created attachment 100838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100838=edit Bug 24874: Printing is broken on opac-results.pl page (19.11.x) to test in 19.11.x... - search for something in opac - print page using file -> print - observe printing is broken (pic1) - apply patch - search for something in opac - print page using file -> print - observe printing is fixed (pic2) it seems this issue was introduced by bug 5287 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page (19.11.x)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874
--- Comment #6 from Mason James ---
(In reply to Lucas Gass from comment #5)
> Mason,
>
> I cannot clean apply this to the 19.11.x branch:
>
> .git/rebase-apply/patch:32: trailing whitespace.
> @page { margin: 1cm }
> warning: 1 line adds whitespace errors.
aah, good catch Lucas, i'll correct the patch :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page (19.11.x)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874 Mason James changed: What|Removed |Added Attachment #100719|0 |1 is obsolete|| --- Comment #7 from Mason James --- Created attachment 100836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100836=edit Bug 24874: Printing is broken on opac-results.pl page (19.11.x) to test in 19.11.x... - search for something in opac - print page using file -> print - observe printing is broken (pic1) - apply patch - search for something in opac - print page using file -> print - observe printing is fixed (pic2) it seems this issue was introduced by bug 5287 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23433] Make consistent use of patron-title.inc in hold confirmation dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 --- Comment #4 from Lucas Gass --- I guess returns.tt is a moving target, sadly this again doesn't apply cleanly. :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24837] selectbranchprinter needs to be renamed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24837 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #3 from Lucas Gass --- I think there is still one more under Comments > Moderate patron comments. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24854] Remove IDreamBooks integration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854 Lucas Gass changed: What|Removed |Added Attachment #100833|0 |1 is obsolete|| --- Comment #4 from Lucas Gass --- Created attachment 100835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100835=edit Bug 24854: Remove IDreamBooks integration The IDreamBooks service has not seen updates in a long time, so we should remove the service from Koha as it's no longer operational. To test: - Apply patch and run the database update - Verify that the IDreamBooks related system preferences are gone - Verify that opac detail pages and result lists still work as expected - Run t/db_dependent/UsageStats.t Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24266] Noisy error in reconcile_balances.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24266 --- Comment #9 from Aleisha Amohia --- Ah that totally makes sense. Perhaps instead of going into the database in the test plan, create a test borrower, add some accountline, then delete the borrower. The script should know to skip past them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24885] New: Remove guided reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24885 Bug ID: 24885 Summary: Remove guided reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org The guided reports feature was never fully developed and isn't useful. SQL reports are clearly the focus of development moving forward and should be the center of the reports module instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24266] Noisy error in reconcile_balances.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24266 --- Comment #8 from Tomás Cohen Arazi --- I totally forgot about this one. Sorry. Borrowernumbers get emptied when the patron gets deleted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24882] Date updated and Date/time of change are the same on payment/fee details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24882 --- Comment #1 from Katrin Fischer --- Created attachment 100834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100834=edit Screenshot of fee details -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24882] Date updated and Date/time of change are the same on payment/fee details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24882 Katrin Fischer changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #2 from Katrin Fischer --- Hm, looking at it again, type and type of change match up as well - I wonder if there is something wrong with the template or if this is intentional. Adding Kyle and a screenshot in hope of help! :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24884] New: Remove 'New list' button in 'Public lists' tab if OpacAllowPublicListCreation is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24884 Bug ID: 24884 Summary: Remove 'New list' button in 'Public lists' tab if OpacAllowPublicListCreation is disabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl When OpacAllowPublicListCreation is disabled (i.e. patrons are not allowed to create public lists from the OPAC), there shouldn't be a 'New list' button in the 'Public lists' tab. I am aware this does not enable patrons to create public lists, but it can be confusing, since it is in the 'Public lists' tab. To replicate: 1) In Administration > Global system preferences, search for OpacAllowPublicListCreation 2) Choose "Don't allow" and Save 3) Go to the OPAC and log into an account 4) In your account go to "your lists" 5) Click on the "Public lists" tab Note there is a 'New list' button. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #92 from Katrin Fischer --- Almost there - thx for the work on the notice. 1) I think this slipped in from another feature in the tree (22784): +Include archived: + + + 2) From comment#91 > > 1) When I change the manager, the lastmodification* are not updated. > > That was expected (I think). The field lastmodification* are only updated > when the suggestion is edited via the edit form. If we want to update it > whenever the table is updated, the change must be moved to ModSuggestion. > > Séverine, can you confirm the behavior you expect? Still waiting for an answer here, but I think we could fix that on a follow-up if needed. The change will be minor compared to the work needed to keep this patchset up-to-date with master. -- This one is confusing to me and I keep wondering if this should have been more than one bug :) So at the moment, in suggestions we got: `date` timestamp NOT NULL default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP, -- date and time the suggestion was updated lastmodificationby INT(11) default NULL, -- borrowernumber for the librarian who edit the suggestion for the last time lastmodificationdate date default NULL, -- date of the last modification So date is actually always updated and should probably be renamed 'datetime' or similar. What is the use case for the additional lastmodificationdate? From the description it's not clear to me. Do we really need it if we have date? Please feel free to get others to look at this - 1) should be a quick fix, 2) is a bit puzzling to me right now! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24854] Remove IDreamBooks integration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854 Katrin Fischer changed: What|Removed |Added Attachment #100713|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 100833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100833=edit Bug 24854: Remove IDreamBooks integration The IDreamBooks service has not seen updates in a long time, so we should remove the service from Koha as it's no longer operational. To test: - Apply patch and run the database update - Verify that the IDreamBooks related system preferences are gone - Verify that opac detail pages and result lists still work as expected - Run t/db_dependent/UsageStats.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24266] Noisy error in reconcile_balances.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24266 --- Comment #7 from Aleisha Amohia --- Created attachment 100832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100832=edit Bug 24266: (alternate patch) Only use defined borrowernumbers in reconcile_balances.pl cron I believe the error is triggered when borrowernumbers are left empty in the accountlines table. Not sure why this would happen, but it appears to be what causes the problem. Do not apply the first patch if testing this patch. To test: 1) sudo koha-mysql INSTANCENAME 2) if you don't have any accountlines where the borrowernumber is null, update one of your accountlines where the amountoutstanding is more than zero, and make the borrowernumber NULL 3) ensure the AccountAutoReconcile syspref is disabled 4) Go to [borrowernumber]'s accounting tab 5) Create a manual credit or debit. Confirm this shows in the 'Make a payment' tab as an amount that COULD be applied, but isn't automatically applied 6) in your terminal, run the reconcile_balances.pl script 7) Confirm the error does not show in the logs and the balance for [borrowernumber] is correctly reconciled. Sponsored-by: Horowhenua District Council -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24266] Noisy error in reconcile_balances.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24266 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz Change sponsored?|--- |Sponsored Assignee|tomasco...@gmail.com|alei...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24883] Command line utility to load yaml files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 100831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100831=edit Bug 24883: Command line utility to load yaml files This patch adds a command line utility to load yaml files. To test: 1) Apply the patch 2) Try loading a file, e.g. sample notices a) mysql -e "delete from letter" b) misc/load_yaml.pl -f installer/data/mysql/en/mandatory/sample_notices.yml 3) Try loading a file with a syntax error, edit previous file adding ':' at the end of a field without quotes then load again -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24883] Command line utility to load yaml files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883 Bernardo Gonzalez Kriegel changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |bgkrie...@gmail.com |ity.org | Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21296] Suspend hold ignores system preference on intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 --- Comment #12 from Hayley Mapley --- Many thanks Jonathan! I must have removed it in error during the merge. Cheers, Hayley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z --- Comment #14 from Hayley Mapley --- Hi, Backporting this to 18.11.x resulted in conflicts which I don't know how to resolve. Can somebody please rebase for 18.11.x? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24510] When placing a hold, cursor doesn't focus on patron name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Katrin Fischer changed: What|Removed |Added Attachment #99661|0 |1 is obsolete|| --- Comment #16 from Katrin Fischer --- Created attachment 100827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100827=edit Bug 24510: Add focus to Patron/club input Signed-off-by: Kelly McElligott Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24510] When placing a hold, cursor doesn't focus on patron name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Katrin Fischer changed: What|Removed |Added Attachment #99666|0 |1 is obsolete|| --- Comment #18 from Katrin Fischer --- Created attachment 100829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100829=edit Bug 24510: Code cleaning Additional test plan: Create 3 clubs: abc adf axy place a hold for on of those club, search for a club 'a' you will get the focus on the "Clubs" tab Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24510] When placing a hold, cursor doesn't focus on patron name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Katrin Fischer changed: What|Removed |Added Attachment #100733|0 |1 is obsolete|| --- Comment #19 from Katrin Fischer --- Created attachment 100830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100830=edit Bug 24510: Add missing filter Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24510] When placing a hold, cursor doesn't focus on patron name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Katrin Fischer changed: What|Removed |Added Attachment #99665|0 |1 is obsolete|| --- Comment #17 from Katrin Fischer --- Created attachment 100828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100828=edit Bug 24510: When Placing a Hold, cursor doesn't focus on Patron Name This alternate patch tries to implement a fix in a more "correct" way by tying the cursor focus to the initialization of the jQueryUI tabs. By configuring both the "create" and "activate" events we can make sure the correct input field is focused. I think the only advantage of this patch over the other one is that tying the focus to the tabs activation makes it a little more obvious where in the DOM loading sequence the focus is being set. To test, follow the original patch's test plan: TEST PLAN: 1. Go to Biblio Record 2. Place Hold (request.pl) - either the Hold above the Bib or the Hold on the left, it does the same thing. 3. Note that the cursor does not go to Patron Name (for whom to place the hold for), it goes to the Top Search bar under Checkout. 4. Apply patch and reload the page. 5. The focus should now be correctly set. 6. Toggle between 'Patrons' and 'Club' tabs. 7. Focus should stay set. Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24510] When placing a hold, cursor doesn't focus on patron name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24883] New: Command line utility to load yaml files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883 Bug ID: 24883 Summary: Command line utility to load yaml files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: bgkrie...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz Now that the installation files are in YAML, a tool to load them would be handy. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24774] Specify 2 space indentation for JSON files in .editorconfig
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24774 Katrin Fischer changed: What|Removed |Added Attachment #100280|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 100826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100826=edit Bug 24774: Set JSON indentation of 2 spaces in .editorconfig To test: 1. Start an editor that supports .editorconfig 2. Open or create a JSON file 3. Observe identation is set to 2 spaces by default Sponsored-by: Hypernova Oy Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24774] Specify 2 space indentation for JSON files in .editorconfig
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24774 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24722] reserves.priority must be NOT NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24722 Katrin Fischer changed: What|Removed |Added Attachment #99642|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 100825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100825=edit Bug 24722: Add atomicupdate file Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24722] reserves.priority must be NOT NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24722 Katrin Fischer changed: What|Removed |Added Attachment #99597|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 100824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100824=edit Bug 24722: DBIC changes Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24722] reserves.priority must be NOT NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24722 Katrin Fischer changed: What|Removed |Added Attachment #99596|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 100823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100823=edit Bug 24722: Add test Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24722] reserves.priority must be NOT NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24722 Katrin Fischer changed: What|Removed |Added Attachment #99595|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 100822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100822=edit Bug 24722: Enforce NOT NULL constraint on reserves.priority This field is never NULL and must always be equal to an integer. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24722] reserves.priority must be NOT NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24722 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24722] reserves.priority must be NOT NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24722 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #10 from Katrin Fischer --- This seems ok. Only wondering: should we be changing old_reserves as well? The table still has: `priority` smallint(6) default NULL, -- where in the queue the patron sits -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24818] Accountline creation dates should be datetimes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24818 Katrin Fischer changed: What|Removed |Added Attachment #100566|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 100821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100821=edit Bug 24818: Update database accountlines.date to timestamp This update increases the resolution for the 'date' field, used for 'creation date' in accountlines from a 'date' to a 'timestamp'. This matches other tables where both a created and updated field are included. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24818] Accountline creation dates should be datetimes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24818 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24882] New: Date updated and Date/time of change are the same on payment/fee details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24882 Bug ID: 24882 Summary: Date updated and Date/time of change are the same on payment/fee details Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org When looking at the fee details, there are 2 columns in the table: - date updated - date/time of change Both columns appear to show the same information. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24851] No sample libraries for UNIMARC installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851 Katrin Fischer changed: What|Removed |Added Attachment #100736|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 100820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100820=edit Bug 24851: Translate the .txt in French Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24851] No sample libraries for UNIMARC installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851 Katrin Fischer changed: What|Removed |Added Attachment #100818|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 100819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100819=edit Bug 24851: Insert libraries sample data for "UNIMARC" I am trying to make koha-testing-docker UNIMARC compabible. In order to have koha-misc4dev insert all the data correctly (users, etc.) we need at least 1 library. I am suggesting to reuse the usual library list for UNIMARC. misc4dev will use fr-FR sample data for "UNIMARC" This is related to https://gitlab.com/koha-community/koha-misc4dev/issues/29 Test plan: outside your box, in koha-testing-docker (up-to-date), edit .env and set KOHA_MARC_FLAVOUR=unimarc DEBUG_GIT_REPO_MISC4DEV_URL=https://gitlab.com/joubu/koha-misc4dev.git DEBUG_GIT_REPO_MISC4DEV_BRANCH=unimarc Then start the koha container When the misc4dev will start its job, the scripts will have the expected data to continue. Without this patch you will get koha_1 | Not enough data in the database, library and/or patron category does not exist at /kohadevbox/misc4dev/create_superlibrarian.pl line 31. And plenty of errors will follow. Also, the sample data used in misc4dev will use CPL (/kohadevbox/misc4dev/data/sql/unimarc/1812/after_22155/items.sql) Signed-off-by: Jon Knight Signed-off-by: Katrin Fischer Current status: Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24851] No sample libraries for UNIMARC installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851 Katrin Fischer changed: What|Removed |Added Attachment #100596|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 100818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100818=edit Bug 24851: Insert libraries sample data for "UNIMARC" I am trying to make koha-testing-docker UNIMARC compabible. In order to have koha-misc4dev insert all the data correctly (users, etc.) we need at least 1 library. I am suggesting to reuse the usual library list for UNIMARC. misc4dev will use fr-FR sample data for "UNIMARC" This is related to https://gitlab.com/koha-community/koha-misc4dev/issues/29 Test plan: outside your box, in koha-testing-docker (up-to-date), edit .env and set KOHA_MARC_FLAVOUR=unimarc DEBUG_GIT_REPO_MISC4DEV_URL=https://gitlab.com/joubu/koha-misc4dev.git DEBUG_GIT_REPO_MISC4DEV_BRANCH=unimarc Then start the koha container When the misc4dev will start its job, the scripts will have the expected data to continue. Without this patch you will get koha_1 | Not enough data in the database, library and/or patron category does not exist at /kohadevbox/misc4dev/create_superlibrarian.pl line 31. And plenty of errors will follow. Also, the sample data used in misc4dev will use CPL (/kohadevbox/misc4dev/data/sql/unimarc/1812/after_22155/items.sql) Signed-off-by: Jon Knight Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24851] No sample libraries for UNIMARC installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4985] Edit a calendar entry for all branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #15 from Katrin Fischer --- I am sorry, I have given this another test run, but I still have issues: - Add 2 holidays as 'repeated holidays on a range' - Try to delete them using 'Delete the repeated holidays on a range.' - Holidays are not deleted With the patch applied, I am not able to delete them. Emmi, can you pleas re-check? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 David Roberts changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |david.roberts@ptfs-europe.c |ity.org |om CC||david.roberts@ptfs-europe.c ||om -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Donna changed: What|Removed |Added CC||bwsdo...@gmail.com --- Comment #2 from Donna --- This is a functionality libraries request on a regular basis. Great idea! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran slowly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881 --- Comment #8 from Lucas Gass --- Jonathan, no errors. This makes Circulation.t pass all tests. TY. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran slowly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881 --- Comment #7 from Jonathan Druart --- (In reply to Lucas Gass from comment #6) > backported to 19.05.x for 19.05.09 Can you confirm this patch did fix something? Which error did you get? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What|Removed |Added Attachment #96432|0 |1 is obsolete|| --- Comment #178 from Bin Wen --- Created attachment 100817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100817=edit Bug 11879 - Add a new field to patron record: main contact method Fixed the problem mentioned above. Test plan is same as before: 0) Apply patch 1) updatedatabase.pl 2) In the staff client, edit a patron's contact info. There should be a new dropdown select to choose the main contact method 3) In the opac page, edit the personal details.There should be a new dropdown select to choose the main contact method. 4) Save the form. It should work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran slowly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881 --- Comment #6 from Lucas Gass --- backported to 19.05.x for 19.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran slowly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881 Lucas Gass changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran slowly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881 Lucas Gass changed: What|Removed |Added Version(s)||19.05.09 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran slowly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881 Lucas Gass changed: What|Removed |Added Status|Passed QA |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran slowly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881 Lucas Gass changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran slowly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran slowly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran slowly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881 --- Comment #5 from Lucas Gass --- ahh, of course. Thanks Jonathan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24582] Cloning circ rules does not maintain checkouts allowed or on-site checkouts allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24582 Margaret changed: What|Removed |Added Version(s)||20.05 released in|| CC||margaret@bywatersolutions.c ||om -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24853] Add a tab in system preferences for accounting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24853 --- Comment #3 from Katrin Fischer --- Hi Kelly, looks like this bug is to blame: Bug 23321 - Add 'cash registers' to the accounts system (19.11) We could also reuse this bug by changing the bug title :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24728] Short Last Name Search Issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24728 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15148] Serials: Test prediction pattern starts at First issue date, not Subscription start date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15148 --- Comment #11 from Katrin Fischer --- (In reply to Nick Clemens from comment #10) > I think the issue here has been for bringing in subscriptions from another > system, so you are setting the first issue to the first one held, but then > adding the start date and wanting to see the issues from that date forward? > > Either way, maybe a better solution is to preserve existing behaviour and > add an option (radio button) to select generating from the sub start date > instead of first issue? Sounds good to me! I'd also be interested in being able to compare to understand the differences pointed out here better -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24609] Add routes for getting and setting checkout due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 --- Comment #11 from Tomás Cohen Arazi --- The code for update() is missing a ->discard_changes() call before returning $checkout->to_api, so the timestamp does not look updated on the response, Regarding the logic in it, I'm worried about the simplicity and how this might need some round actions to trigger things like account fixes, etc.I'm not saying it is wrong, but it looks suspiciously simple without having dug too much into the area recently (i.e. I would accept an 'is safe' from you, if you say so). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran slowly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881 --- Comment #4 from Jonathan Druart --- Lucas, this means that you are using a master DB on a 19.05.x branch. reset_all on 19.05.x and you should not get that error. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 --- Comment #20 from Jonathan Druart --- Created attachment 100815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100815=edit Bug 23591: [DO NOT PUSH] CSS Changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 --- Comment #19 from Jonathan Druart --- Created attachment 100814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100814=edit Bug 23591: Use same css for suggestion notes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 --- Comment #18 from Jonathan Druart --- Created attachment 100813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100813=edit Bug 23591: Display a new "Suggestion detail" tab on the bib detail page This patch adds a new "Suggestion detail" tab on the bibliographic detail page. It will help suggestion management. Test plan: - Create several suggestions for a given biblio - Go to the detail page of the bibliographic record and confirm that there is a new "Suggestion detail" tab with all the suggestions you created. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 --- Comment #21 from Jonathan Druart --- Created attachment 100816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100816=edit Bug 23591: Hide archived suggestions However we are adding a note on top of the table to tell how many suggestions are archived. It seems that there is no good reason to display the archived suggestions on this table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 Jonathan Druart changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 Jonathan Druart changed: What|Removed |Added Attachment #95600|0 |1 is obsolete|| Attachment #95601|0 |1 is obsolete|| Attachment #95602|0 |1 is obsolete|| Attachment #95603|0 |1 is obsolete|| Attachment #95604|0 |1 is obsolete|| --- Comment #17 from Jonathan Druart --- Created attachment 100812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100812=edit Bug 23591: Add some useful methods to Koha::Suggestions Those are methods initially written for bug 23991. I finally need them before than expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22784] Archiving Purchase Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #35 from Jonathan Druart --- Created attachment 100811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100811=edit Bug 22784: Add a cronjob to archive suggestions given age or status criteria In order to deal automatically with suggestions that need to be archived, this cronjob will help to add the "archived" flag following their age or status. Test plan: - Execute the script with the --help parameter and read the documentation. - Does it make sense? - Use it without the --confirm flag and try several combination For instance you will want to archive suggestions that have been rejected for more than a week: perl misc/cronjobs/archive_purchase_suggestions.pl --age-date-field=rejecteddate --age=weeks:1 or even suggestion that have been suggested for more than a year and have a ORDERED status: perl misc/cronjobs/archive_purchase_suggestions.pl --age-date-field=suggesteddate --age=years:1 --status=ORDERED - Use it with the --confirm flag and make sure the suggestions have been archived. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22784] Archiving Purchase Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #34 from Jonathan Druart --- Created attachment 100810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100810=edit Bug 22784: Do not display an empty table This is terrible and highlight that the whole script must be rewrite. GetDistinctValues does not handle the "archived" flag (and we do not want to put our hands there), so let's hack that and plan to rewrite the whole script. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22784] Archiving Purchase Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #33 from Jonathan Druart --- Created attachment 100809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100809=edit Bug 22784: Bugfix - do not modify #description build Debian packages from a git repository Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22784] Archiving Purchase Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #32 from Jonathan Druart --- Created attachment 100808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100808=edit Bug 22784: Add the ability to archive/unarchive a purchase suggestions There are performance issues when searching suggestions if there are thousands of suggestions. To prevent that we are going to add the ability to archive purchase suggestions, in order to remove them from the search list (by default). Test plan: 0. Apply all the patches, execute the updatedatabase.pl script, restart all 1. Create some suggestions 2. Search for them 3. Use the "Archive" action button for one of them 4. Restart the search => The archived suggestion does no longer appear in the list 5. Use the filter "Included archived" in the "Suggestion information" filter box => The archived suggestion is now displayed 6. Use other filters => The "archived" filter is kept from one search to another 7. Use one of the action at the bottom of the suggestion list (change the status for instance) => The "archived" filter is still kept Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22784] Archiving Purchase Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #31 from Jonathan Druart --- Created attachment 100807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100807=edit Bug 22784: DBIC Changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22784] Archiving Purchase Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Jonathan Druart changed: What|Removed |Added Attachment #96900|0 |1 is obsolete|| Attachment #96901|0 |1 is obsolete|| Attachment #96902|0 |1 is obsolete|| Attachment #96903|0 |1 is obsolete|| Attachment #96904|0 |1 is obsolete|| Attachment #96905|0 |1 is obsolete|| --- Comment #30 from Jonathan Druart --- Created attachment 100806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100806=edit Bug 22784: DB Changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22784] Archiving Purchase Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Jonathan Druart changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #91 from Jonathan Druart --- (In reply to Jonathan Druart from comment #71) > (In reply to Katrin Fischer from comment #69) > > Notes & questions > > > > 1) We might want to modify the bug title a little - in addition to allow > > changing the manager, this will also store the last person to change and > > date. Also gives a checkbox for TO_PROCESS. We really needs some release > > notes :) > > Any suggestions? :) Done, hope that makes sense. > > 3) Is there a reason why we don't let the db update thelastmodificationdate? > > We can pick the max date of suggesteddate, manageddate, accepteddate, > rejecteddate, is that was you have in mind? I added a follow-up to update the 2 new columns. > > Blockers > > > > 1) When I change the manager, the lastmodification* are not updated. > > That was expected (I think). The field lastmodification* are only updated > when the suggestion is edited via the edit form. If we want to update it > whenever the table is updated, the change must be moved to ModSuggestion. > > Séverine, can you confirm the behavior you expect? Still waiting for an answer here, but I think we could fix that on a follow-up if needed. The change will be minor compared to the work needed to keep this patchset up-to-date with master. > > 2) The TO_PROCESS email goes to the fund owner - this patch is reusing it > > for the manager. I believe this should be handled separately. ( Bug 13014: > > Notify budget owner on new suggestion - cronjob) > > That was part of the original specification. > It makes sense to have 2 different notice templates. Something to suggest? > UPDATE_MANAGER, SUGGEST_MANAGER, TO_PROCESS_MANAGER? Done, a new template notice "NOTIFY_MANAGER" has been added. Sending back to the QA queue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590
Jonathan Druart changed:
What|Removed |Added
Summary|Allow to modify the manager |Allow to modify and notify
|of a suggestion |the manager of a suggestion
Text to go in the||This new feature adds the
release notes||ability to modify the
||manager of a suggestion.
||When assigning a suggestion
||to a new manager, a notice
||NOTIFY_MANAGER could be
||sent to the manager to
||alert them.
||
||To keep track
||of the different
||modification, 2 new columns
||are added to the suggestion
||table: lastmodificationby
||and lastmodificationdate,
||which will be updated
||automatically when a
||suggestion is edited.
--- Comment #90 from Jonathan Druart
---
(In reply to Jonathan Druart from comment #71)
> (In reply to Katrin Fischer from comment #69)
> > Notes & questions
> >
> > 1) We might want to modify the bug title a little - in addition to allow
> > changing the manager, this will also store the last person to change and
> > date. Also gives a checkbox for TO_PROCESS. We really needs some release
> > notes :)
>
> Any suggestions? :)
>
> > 2) lastmodificationdate and lastmodificationby are quite long. It might be
> > nicer to used something more readable like: last_modified_on and
> > last_modified_by. Not blocker for me, but putting the thought out there.
>
> I followed the existing pattern As there were already 4 of those I thought
> it was better to keep names consistent.
>
> > 3) Is there a reason why we don't let the db update thelastmodificationdate?
>
> We can pick the max date of suggesteddate, manageddate, accepteddate,
> rejecteddate, is that was you have in mind?
>
> > 4) Please check my follow-up
>
> They look good, thanks!
>
> > Blockers
> >
> > 1) When I change the manager, the lastmodification* are not updated.
>
> That was expected (I think). The field lastmodification* are only updated
> when the suggestion is edited via the edit form. If we want to update it
> whenever the table is updated, the change must be moved to ModSuggestion.
>
> Séverine, can you confirm the behavior you expect?
>
> > 2) The TO_PROCESS email goes to the fund owner - this patch is reusing it
> > for the manager. I believe this should be handled separately. ( Bug 13014:
> > Notify budget owner on new suggestion - cronjob)
>
> That was part of the original specification.
> It makes sense to have 2 different notice templates. Something to suggest?
> UPDATE_MANAGER, SUGGEST_MANAGER, TO_PROCESS_MANAGER?
>
> > 3)
> > +if ( $notify ) {
> > +my $patron = Koha::Patrons->find(
> > $suggestion_only->{managedby} );
> > +my $email_address = $patron->notice_email_address;
> > +if ($patron->notice_email_address) {
> > +my $budget = C4::Budgets::GetBudget(
> > $suggestion_only->{budgetid} );
> > $budget appears not to be used - possibly a copy because of 2).
>
> Indeed, follow-up coming.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15688] Renew item that is on hold: Display information about hold's patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15688 --- Comment #2 from Lucas Gass --- Obsoleting Nick's patch as it is attached to the wrong bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15688] Renew item that is on hold: Display information about hold's patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15688 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Attachment #100751|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24176] Make datelastborrowed a column in holdings_table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24176 --- Comment #5 from Lucas Gass --- Yes, I will redo this patch once/if bz15668 makes it into master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #89 from Jonathan Druart --- Created attachment 100804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100804=edit Bug 23590: Create a separate template notice NOTIFY_MANAGER To separate the two feature we want to create a distinct template notice. A new NOTIFY_MANAGER notice is added. A follow-up patch will be added for other languages, when this one will be approved by QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15668] Add column configuration to the items table in staff detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668 Lucas Gass changed: What|Removed |Added Attachment #100787|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15668] Add column configuration to the items table in staff detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668 Lucas Gass changed: What|Removed |Added Attachment #100787|0 |1 is obsolete|| --- Comment #10 from Lucas Gass --- Created attachment 100805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100805=edit Bug 15668: (follow up) add selector to th follow up add a selector to the to ensure we count the table in questions. Should not affect other pages but is needed on detail.tt where there are two tables to configure -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #86 from Jonathan Druart --- Created attachment 100801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100801=edit Bug 23590: remove unused variable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
