[Koha-bugs] [Bug 24925] New: C
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24925 Bug ID: 24925 Summary: C Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: QA tools Assignee: jonathan.dru...@bugs.koha-community.org Reporter: okokari...@gmail.com Created attachment 101343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101343&action=edit B Ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24926] New: C
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24926 Bug ID: 24926 Summary: C Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: QA tools Assignee: jonathan.dru...@bugs.koha-community.org Reporter: okokari...@gmail.com Ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24926] C
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24926 --- Comment #1 from Aris --- Created attachment 101344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101344&action=edit Kon X -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24927] New: Sons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24927 Bug ID: 24927 Summary: Sons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: danurmy...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Created attachment 101345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101345&action=edit Sons Sons -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24928] New: Sus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24928 Bug ID: 24928 Summary: Sus Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: danurmy...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 101346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101346&action=edit Sus Sus -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24929] New: Nakagan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24929 Bug ID: 24929 Summary: Nakagan Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Browser compatibility Assignee: oleon...@myacpl.org Reporter: mamakhe...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 101347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101347&action=edit Kontol -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24930] New: Nakagan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24930 Bug ID: 24930 Summary: Nakagan Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: mamakhe...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 101348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101348&action=edit Haruka -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24930] Nakagan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24930 Ramdans changed: What|Removed |Added CC||mamakhe...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24931] New: Ler
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24931 Bug ID: 24931 Summary: Ler Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: throvin...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 101349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101349&action=edit G Gghh -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24932] New: Throvinus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24932 Bug ID: 24932 Summary: Throvinus Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: throvin...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 101350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101350&action=edit Purba Gggghjnb -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24921] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24921 Katrin Fischer changed: What|Removed |Added Summary|000 |SPAM CC||katrin.fisc...@bsz-bw.de Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24922] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24922 Katrin Fischer changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED CC||katrin.fisc...@bsz-bw.de Summary|000 |SPAM -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24923] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24923 Katrin Fischer changed: What|Removed |Added Resolution|--- |INVALID Summary|H |SPAM CC||katrin.fisc...@bsz-bw.de Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24924] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24924 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Summary|8080|SPAM Resolution|--- |INVALID CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24926] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24926 Katrin Fischer changed: What|Removed |Added Summary|C |SPAM Resolution|--- |INVALID CC||katrin.fisc...@bsz-bw.de Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24925] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24925 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Summary|C |SPAM Resolution|--- |INVALID CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24927] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24927 Katrin Fischer changed: What|Removed |Added Summary|Sons|SPAM Status|NEW |RESOLVED Resolution|--- |INVALID CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24929] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24929 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Resolution|--- |INVALID Status|NEW |RESOLVED Summary|Nakagan |SPAM -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24928] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24928 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|NEW |RESOLVED Summary|Sus |SPAM Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24930] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24930 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Summary|Nakagan |SPAM CC||katrin.fisc...@bsz-bw.de Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24931] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24931 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID Summary|Ler |SPAM CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24932] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24932 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED CC||katrin.fisc...@bsz-bw.de Summary|Throvinus |SPAM Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24920] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24920 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24915] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24915 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24916] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24916 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24917] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24917 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24919] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24919 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875 --- Comment #5 from Katrin Fischer --- Created attachment 101351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101351&action=edit Bug 24875: (follow-up) Remove ending . from Comments Removes another extra ending . from the Comments section of the tools start page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875 --- Comment #6 from Katrin Fischer --- (In reply to Lucas Gass from comment #3) > I think there is still one more under Comments > Moderate patron comments. Thx for the sign-off and pointing this out - added a tiny follow-up with the fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24876] Fix capitalization on patron search for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24876 Katrin Fischer changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24876] Fix capitalization on patron search for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24876 Katrin Fischer changed: What|Removed |Added Attachment #100722|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 101352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101352&action=edit Bug 24876: Fix capitalization on patron search for holds When placing a hold in the staff interface, the heading on the search box reads: Search Patrons or clubs The patch changes it to be Search patrons... instead. Also changes club id to club ID. To test: - Place a hold in the staff interface - Verify the capitalization error - Switch tabs to Clubs, see: club id - Apply patch - Verify it's all good now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24876] Fix capitalization on patron search for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24876 --- Comment #5 from Katrin Fischer --- (In reply to Bernardo Gonzalez Kriegel from comment #3) > Sorry No need to - new patch attached :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24902] Elasticsearch - different limits are joined with OR instead of AND
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24902 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24902] Elasticsearch - different limits are joined with OR instead of AND
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24902
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Attachment #101002|0 |1
is obsolete||
--- Comment #2 from Bernardo Gonzalez Kriegel ---
Created attachment 101353
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101353&action=edit
Bug 24902: Join different mc- limits with AND (elasticsearch)
In the advanced search form, you can enable several limits using syspref
AdvancedSearchTypes (namely itemtypes, shelving locations, collections)
When used, the resulting query parts end up being joined with OR, even
if the field is different. That means that if you pick "Book" under
itemtypes tab, and "Fiction" under collection tab, it will search
"itype:BOOK OR ccode:FIC". It should be AND.
For instance, if you select:
Itemtypes:
✓ Book
✓ DVD
Location:
✓ Child
✓ Adult
it should search:
itype:(Book OR DVD) AND location:(Child OR Adult)
Test plan:
0. Do not apply the patch yet
1. Enable elasticsearch
2. Set syspref AdvancedSearchTypes = 'itemtypes|loc|ccode'
3. Create a new itemtype and a new authorised value for categories LOC
and CCODE
4. Create a biblio with the new itemtype, another biblio with the new
location, another biblio with the new collection, and again another
biblio with the new itemtype, location and collection
5. Verify that you can find these new biblio records using only the
"advanced search types" in the advanced search form
6. In the advanced search form, pick all 3 limits (itemtype, location,
collection) and verify that it returns the 4 records.
7. Apply the patch
8. Repeat step 6, it should now return only the biblio that satisfies
all criteria
9. Verify that if you select more than one
{itemtype|location|collection} it still returns results that
satisfies any selected criteria
10. prove t/Koha/SearchEngine/ElasticSearch/QueryBuilder.t
Signed-off-by: Bernardo Gonzalez Kriegel
Works nice, no errors.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24876] Fix capitalization on patron search for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24876 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #101352|0 |1 is obsolete|| --- Comment #6 from Bernardo Gonzalez Kriegel --- Created attachment 101354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101354&action=edit Bug 24876: Fix capitalization on patron search for holds When placing a hold in the staff interface, the heading on the search box reads: Search Patrons or clubs The patch changes it to be Search patrons... instead. Also changes club id to club ID. To test: - Place a hold in the staff interface - Verify the capitalization error - Switch tabs to Clubs, see: club id - Apply patch - Verify it's all good now Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24876] Fix capitalization on patron search for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24876 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Andrew Nugged changed: What|Removed |Added Attachment #97375|0 |1 is obsolete|| Attachment #97376|0 |1 is obsolete|| Attachment #97377|0 |1 is obsolete|| Attachment #97378|0 |1 is obsolete|| --- Comment #19 from Andrew Nugged --- Created attachment 101355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101355&action=edit Bug 24185: Make holds page faster - improved "if" `$can_item_be_reserved eq 'OK'` moved in `&&` before `IsAvailableForItemLevelRequest` to cut away with static known values before calling to more resource consuming subroutine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 --- Comment #20 from Andrew Nugged --- Created attachment 101356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101356&action=edit Bug 24185: Make holds page faster - call to subroutine moved below "if" `$on_shelf_holds` was assigned before "return .. if" but not used in that code piece, so sometimes it was useless. Moved assignment after "return .. if". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 --- Comment #21 from Andrew Nugged --- Created attachment 101357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101357&action=edit Bug 24185: Make holds page faster: preparatory refactoring This is just refactoring. extracting logically independent code to separate sub + tests update. No logic change yet. Searching for "any_available" item among all biblionumber items was done inside of "elsif on_shelf_holds == 2", and it is logically very independent piece of code (this "@items" loop), it needs just biblionumber and patron as parameters so it can be extracted into separate subroutine, and later also called/reused from somewhere else. This ability to call from another place also made for future patch to remove O(n^2) problem with nested loops. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Andrew Nugged changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185
--- Comment #22 from Andrew Nugged ---
Created attachment 101358
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101358&action=edit
Bug 24185: Make holds page fast when 'on shelf holds' set to 'If all
unavailable'
When "reserve/request.pl -> C4/Reserves.pm::IsAvailableForItemLevelRequest"
called many times with hundred of items and "on shelf holds" parameter set to
"If all unavailable" for these items + patron, it goes slow.
It happens because in subloop it is checking if all items available so it is
O(n^2) and it re-checks each time the same info for each item with repeating
DB/data requests.
Fix:
The inner loop 1:1 picked out into separate subroutine and called outside of
the loop, saving data in 'items_any_available' variable once, this variable
passed to IsAvailableForItemLevelRequest to be used inside as the precalculated
result.
This made algorithm O(n) instead of O(n^2) so there is noticeable speed
increase.
How to reproduce:
1) on freshly installed kohadevbox create/import one book,
remember that biblionumber for later use it in down below,
2) add 100 items for that book for some library,
3) find some patron, that patron's card number we will
use as a borrower down below to open holds page,
4) check for the rule or set up a single circulation rule
in admin "/cgi-bin/koha/admin/smart-rules.pl",
that rule should match above book items/library/patron,
check that rule to have a non-zero number of holds (total, daily, count)
allowed,
and, IMPORTANT: set up "On shelf holds allowed" to "If all unavailable",
("item level holds" doesn't matter).
5) open "Home > Catalog > THAT_BOOK > Place a hold on THAT_BOOK" page
("holds" tab), and enter patron code in the search field,
or you can create a direct link by yourself, for example, in my case it was:
/cgi-bin/koha/reserve/request.pl?biblionumber=4&findborrower=23529000686353
6) it should be pretty long page generation time on old code, densely
increasing for every hundred items added. In the case of this solution, it's
fast, and time increases a little only, linear.
I tested on my computer in VirtualBox for page generation times,
did 3-5 runs for same case to check if results are stable, and got such values:
(old code):
100 items:50 seconds
200 items: 3.2 minutes
300 items: 7.3 minutes
(version with fix):
100 items: 4.4 seconds
200 items: 7.5 seconds
300 items: 10.4 seconds
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for basket_group in Basket.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #6 from Katrin Fischer --- I see that this is the start of a tree of patches - Joubu, can we continue here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24933] New: wadimor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24933 Bug ID: 24933 Summary: wadimor Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: vbdlkr...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 101359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101359&action=edit wadimor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24934] New: or
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24934 Bug ID: 24934 Summary: or Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: xploitn...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 101360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101360&action=edit ok -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24933] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24933 Katrin Fischer changed: What|Removed |Added Summary|wadimor |SPAM CC||katrin.fisc...@bsz-bw.de Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24934] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24934 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Summary|or |SPAM Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24907] Optionally exclude suspended holds from holds ratio report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24907 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24907] Optionally exclude suspended holds from holds ratio report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24907 Katrin Fischer changed: What|Removed |Added Attachment #101062|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 101362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101362&action=edit Bug 24907: Add 'include suspended' to holds ratio report Some libraries would like the option to ignore suspended holds when using the holds ratio report Note: this report fails with strict mode enabled, please disable to test To test: 1 - Add enough holds to a record (3) to make it show on the holds ration report 2 - Browse to Circulation->Holds ratio 3 - Run with default settings and confirm the title shows up 4 - Suspend one of the holds 5 - Run report again and confirm title still shows 6 - Apply patch 7 - Reload the report 8 - Note new option 9 - Run report - title does not show 10 - Lower ratio to 2 and confirm the hold shows Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24907] Optionally exclude suspended holds from holds ratio report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24907 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer --- This follows the existing pattern so I think a slight behaviour change is ok in that case (default is now to exclude suspended holds). Wondering if on a separate report we could reformat the checkboxes: [checkbox] Text And maybe: Include instead of included? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24902] Elasticsearch - different limits are joined with OR instead of AND
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24902 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24902] Elasticsearch - different limits are joined with OR instead of AND
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24902
Katrin Fischer changed:
What|Removed |Added
Attachment #101353|0 |1
is obsolete||
--- Comment #3 from Katrin Fischer ---
Created attachment 101363
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101363&action=edit
Bug 24902: Join different mc- limits with AND (elasticsearch)
In the advanced search form, you can enable several limits using syspref
AdvancedSearchTypes (namely itemtypes, shelving locations, collections)
When used, the resulting query parts end up being joined with OR, even
if the field is different. That means that if you pick "Book" under
itemtypes tab, and "Fiction" under collection tab, it will search
"itype:BOOK OR ccode:FIC". It should be AND.
For instance, if you select:
Itemtypes:
✓ Book
✓ DVD
Location:
✓ Child
✓ Adult
it should search:
itype:(Book OR DVD) AND location:(Child OR Adult)
Test plan:
0. Do not apply the patch yet
1. Enable elasticsearch
2. Set syspref AdvancedSearchTypes = 'itemtypes|loc|ccode'
3. Create a new itemtype and a new authorised value for categories LOC
and CCODE
4. Create a biblio with the new itemtype, another biblio with the new
location, another biblio with the new collection, and again another
biblio with the new itemtype, location and collection
5. Verify that you can find these new biblio records using only the
"advanced search types" in the advanced search form
6. In the advanced search form, pick all 3 limits (itemtype, location,
collection) and verify that it returns the 4 records.
7. Apply the patch
8. Repeat step 6, it should now return only the biblio that satisfies
all criteria
9. Verify that if you select more than one
{itemtype|location|collection} it still returns results that
satisfies any selected criteria
10. prove t/Koha/SearchEngine/ElasticSearch/QueryBuilder.t
Signed-off-by: Bernardo Gonzalez Kriegel
Works nice, no errors.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #15 from Katrin Fischer --- I tested with Firefox in Ubuntu and can't replicate the issue. What I see is good alignment of the text on the left without the patch and a bit too much whitespace with the patch. I think we might want to investigate more to nail down when the problem appears and maybe browser differences? Sending back to sign off for additional testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24823] Drop Catmandu dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823 Katrin Fischer changed: What|Removed |Added QA Contact||julian.maur...@biblibre.com CC||ere.maij...@helsinki.fi, ||katrin.fisc...@bsz-bw.de, ||n...@bywatersolutions.com --- Comment #7 from Katrin Fischer --- Julian, do you plan to continue here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Katrin Fischer changed: What|Removed |Added Attachment #99517|0 |1 is obsolete|| --- Comment #24 from Katrin Fischer --- Created attachment 101364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101364&action=edit Bug 21800: Add tests for repeatable subfields Test plan: Do not apply the second patch [note 1]. Run t/db_dependent/Biblio/TransformKohaToMarc.t Run t/db_dependent/Biblio/TransformMarcToKoha.t Apply the second patch and run them again. Both tests should pass now. Note 1: The TransformKohaToMarc test should fail with something like: # Failed test 'Check 260e' # at t/db_dependent/Biblio/TransformKohaToMarc.t line 60. # got: 'A' # expected: 'A | B' Signed-off-by: Marcel de Rooy Signed-off-by: Ere Maijala Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Katrin Fischer changed: What|Removed |Added Attachment #99518|0 |1 is obsolete|| --- Comment #25 from Katrin Fischer --- Created attachment 101365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101365&action=edit Bug 21800: Make TransformKohaToMarc aware of non-repeatable subfields If a kohafield (in Koha to MARC mappings) contains a pipe char (say A | B), we split it up into two subfields A and B in MARC. We will only do that for repeatable subfields now. If the field is not repeatable, the value will just be 'A | B'. Note 1: As bug 10306 and its friends (19096) made the Default framework authoritative, we do no longer have the frameworkcode in this routine. Formally, we should check the corresponding framework. Note 2: Does this impact the reverse operation in TransformMarcToKoha? No, the check on repeatable subfields is done in the interface and not in TransformMarcToKoha. This routine simply translates two instances of the same subfield, say A and B, into the value 'A | B' for a kohafield. Not allowing two instances of a non-repeatable subfield is not in the scope of this report. Test plan: [1] Mark an item field as repeatable in the Default framework. Edit an item. Insert A|B in this field and another not-repeatable field. Save and reopen. Verify that the repeatable field is duplicated and the other one contains the pipe character in the text box. [2] Look for a repeatable subfield in MARC like e.g. 260$c. Go to the cataloguing editor and add A|B in this field. Signed-off-by: Marcel de Rooy Signed-off-by: Ere Maijala Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Katrin Fischer changed: What|Removed |Added Attachment #99520|0 |1 is obsolete|| --- Comment #27 from Katrin Fischer --- Created attachment 101367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101367&action=edit Bug 21800: Add tests for _check_split This new subroutine supports checking the repeatable tag from another framework. (It will be useful for the item editor.) Test plan: Run t/db_dependent/Biblio/TransformKohaToMarc.t Signed-off-by: Marcel de Rooy Signed-off-by: Ere Maijala Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Katrin Fischer changed: What|Removed |Added Attachment #99519|0 |1 is obsolete|| --- Comment #26 from Katrin Fischer --- Created attachment 101366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101366&action=edit Bug 21800: Check the correct framework for the repeatable tag This depends on the framework parameter. Which should be added back to the call in C4::Items. Test plan: [1] Mark in Default framework one subfield A repeatable and B not repeatable. Go to item editor. (Work on a biblio in Default framework.) Check saving and reopening these subfields with VAL1 | VAL2. Subfield A should be cloned, B should be glued as entered. [2] Mark in another Framework A not repeatable and B repeatable. Change framework for this biblio. Go to item editor again. Reopen item. Behavior subfields in reverse? Signed-off-by: Marcel de Rooy Signed-off-by: Ere Maijala Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24700] Improve Mojo startup speed for REST APIs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24700 Katrin Fischer changed: What|Removed |Added CC||julian.maur...@biblibre.com ||, katrin.fisc...@bsz-bw.de --- Comment #7 from Katrin Fischer --- Don't understand the code well enough to QA here - still gave it a go to provoke some movement. Might be my data, but I have failing tests with and without the patch: Test Summary Report --- t/db_dependent/Koha/REST/Plugin/PluginRoutes.t (Wstat: 65280 Tests: 2 Failed: 1) Failed test: 2 Non-zero exit status: 255 # Failed test 'No tests run for subtest "Disabled plugins tests"' # at t/db_dependent/Koha/REST/Plugin/PluginRoutes.t line 121. Can't locate Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm in @INC (you may need to install the Koha::Plugin::Com::ByWaterSolutions::KitchenSink module) (@INC contains: /home/vagrant/kohaclone /home/vagrant/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base t/db_dependent/Koha/REST/Plugin/../../../../lib) at /usr/share/perl/5.24/Module/Load.pm line 77. Can't locate Koha/Plugin/Com/ByWaterSolutions/KitchenSink in @INC (@INC contains: /home/vagrant/kohaclone /home/vagrant/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base t/db_dependent/Koha/REST/Plugin/../../../../lib) at /usr/share/perl/5.24/Module/Load.pm line 77. # Looks like your test exited with 255 just after 2. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/2 subtests t/db_dependent/api/v1/acquisitions_orders.t (Wstat: 256 Tests: 5 Failed: 1) Failed test: 1 Non-zero exit status: 1 [Sun Mar 22 13:31:12 2020] [debug] GET "/api/v1/acquisitions/orders" [Sun Mar 22 13:31:12 2020] [debug] Routing to controller "Koha::REST::V1::Auth" and action "under" [Sun Mar 22 13:31:12 2020] [debug] 400 Bad Request (0.027112s, 36.884/s) ok 6 - GET //W0txdhLojIJjsOm41yB0E6aNafhS1vdorHkDUn9Z17KvscSt:thePassword123@/api/v1/acquisitions/orders?order_blah=blah ok 7 - 400 Bad Request ok 8 - exact match for JSON Pointer "" # Looks like you failed 2 tests of 8. not ok 1 - list() tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24324] delete_records_via_leader.pl cron error with item deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24324 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24324] delete_records_via_leader.pl cron error with item deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24324 Katrin Fischer changed: What|Removed |Added Attachment #101337|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 101370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101370&action=edit Bug 24324: Resolve error with delete_records_via_leader.pl To test: Have a record with the 000 position 5 set to "deleted" (record status) Use koha-shell to run the job with the -i flag: perl misc/cronjobs/delete_records_via_leader.pl -c -i -v * items and the record should be deleted Mark another record with the 000 position 5 set to deleted (record status) Use koha-shell to run the job without the -i flag: perl misc/cronjobs/delete_records_via_leader.pl -c -v * if the record had items, it will not be deleted * if the record did not have items, it will be deleted. Signed-off-by: Bernardo Gonzalez Kriegel Works ok. Fixed tab char in line 98, no more errors. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20399] Remove "did you mean" for the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24324] delete_records_via_leader.pl cron error with item deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24324 Katrin Fischer changed: What|Removed |Added Version|19.05 |master CC||katrin.fisc...@bsz-bw.de Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20399] Remove "did you mean" for the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- I think there is a problem here with this minimalistic approach: - Go to the did you mean admin page - Make changes to sequence and check/uncheck something - Save - Check system preference / local use / INTRAdidyoumean, it will contain only ] - Access the did you mean page again - BOOM malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "]") at /usr/share/perl5/JSON.pm line 171 I had a follow-up ready to remove the note form the intro text as well - it appears unnecessary. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24837] selectbranchprinter needs to be renamed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24837 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24837] selectbranchprinter needs to be renamed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24837 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #100715|0 |1 is obsolete|| --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 101371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101371&action=edit Bug 24837: Rename selectbranchprinter.pl to set-library.pl This renames the selectbranchprinter.pl file to the more fitting set-library.pl. To test: - Change the library with "Set library" from - The menu in the top navigation bar - The circulation start page - Verify the help link on page leads to the correct section in the manual - Read the code... and verify all occurences have been caught Signed-off-by: Bernardo Gonzalez Kriegel Works ok, fixed tab char in circ/branchtransfers.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24938] New: Mr.Jenskins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24938 Bug ID: 24938 Summary: Mr.Jenskins Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: reuspaul5...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 101372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101372&action=edit Hacked by Mr.Jenskins -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22098] Update stocknumberAV cataloguing plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22098] Update stocknumberAV cataloguing plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098 Katrin Fischer changed: What|Removed |Added Attachment #101329|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 101373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101373&action=edit Bug 22098: Update stocknumberAV cataloguing plugin to use objects This patch: - changes SQL to Koha::AuthorisedValues - remove type param from script tag - fixes the plugin description 0) Do not apply the patch 1) Set the plugin 1.1) Update a biblio framework and link plugin stocknumberAV.pl to some item subfield 1.2) Add authorised values category called "INVENTORY" 1.3) Add some authorised values: authorised value is prefix and description is a current stock/inventory number 2) Add an item and try to use this plugin to ensure you set it correctly 2.1) Use a defined prefix to see if the number is correct 2.2) Ensure the number is correctly incremented in authorised values 2.3) Use not defined prefix to see the error message 2.4) Insert a not prefix string (eg number) to see it is not changed 3) Apply the patch 4) Repeat 2) and see it is working the same 5) Look into patch and confirm the description does make sense and is rigth according to what you see in UI 6) Sign off :D Signed-off-by: Fridolin Somers Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22098] Update stocknumberAV cataloguing plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098 Katrin Fischer changed: What|Removed |Added Attachment #101330|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 101375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101375&action=edit Bug 22098: (follow-up) fix grammar/formating Perldoc - nubers => numbers - some vertical spacing - !}fmt -w65 - "contains of letters" => "containing letters" TEST PLAN - perldoc cataloguing/value_builder/stocknumberAV.pl apply patch perldoc cataloguing/value_builder/stocknumberAV.pl -- after the patch is more readable. Signed-off-by: Fridolin Somers Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22098] Update stocknumberAV cataloguing plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098 Katrin Fischer changed: What|Removed |Added Attachment #101373|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 101374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101374&action=edit Bug 22098: Update stocknumberAV cataloguing plugin to use objects This patch: - changes SQL to Koha::AuthorisedValues - remove type param from script tag - fixes the plugin description 0) Do not apply the patch 1) Set the plugin 1.1) Update a biblio framework and link plugin stocknumberAV.pl to some item subfield 1.2) Add authorised values category called "INVENTORY" 1.3) Add some authorised values: authorised value is prefix and description is a current stock/inventory number 2) Add an item and try to use this plugin to ensure you set it correctly 2.1) Use a defined prefix to see if the number is correct 2.2) Ensure the number is correctly incremented in authorised values 2.3) Use not defined prefix to see the error message 2.4) Insert a not prefix string (eg number) to see it is not changed 3) Apply the patch 4) Repeat 2) and see it is working the same 5) Look into patch and confirm the description does make sense and is rigth according to what you see in UI 6) Sign off :D Signed-off-by: Fridolin Somers Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22098] Update stocknumberAV cataloguing plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098 --- Comment #9 from Katrin Fischer --- Created attachment 101376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101376&action=edit Bug 22098: (QA follow-up) Improving documentation Improves the documentation of the script a bit, but makes one important change: -If no prefix is submitted, or prefix does not contain only -numbers, it returns the inserted code (= keep a field unchanged) +If no prefix is submitted, or the prefix does contain only +numbers, it returns the inserted code (= keep the field unchanged). To test: - Add an authorised INVENTORY value with 2020 as prefix - After linking the stocknumberAV.pl to the 952$i in the frameworks - Edit an item - Add 2020 in the stocknumber field - Trigger plugin - Verify nothing happens If the prefix contains only numbers... nothing happens. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24938] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24938 Katrin Fischer changed: What|Removed |Added Summary|Mr.Jenskins |SPAM CC||katrin.fisc...@bsz-bw.de Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21708] Editing a record moves field 999 to first in the marcxml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21708] Editing a record moves field 999 to first in the marcxml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708 Katrin Fischer changed: What|Removed |Added Attachment #101334|0 |1 is obsolete|| --- Comment #20 from Katrin Fischer --- Created attachment 101377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101377&action=edit Bug 21708: Add a few tests in TransformHtmlToMarc.t Test plan: Run t/db_dependent/Biblio/TransformHtmlToMarc.t without the module change patch. Verify that the test fails on the order of fields. Go to test plan of the second patch. Signed-off-by: Bernardo Gonzalez Kriegel Test fails Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21708] Editing a record moves field 999 to first in the marcxml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708 Katrin Fischer changed: What|Removed |Added Attachment #101335|0 |1 is obsolete|| --- Comment #21 from Katrin Fischer --- Created attachment 101378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101378&action=edit Bug 21708: Sort MARC fields in TransformHtmlToMarc Instead of pushing 999 in the front :) Test plan: Do not yet apply this patch. Edit a record. Save. And open MARC view/view plain on opac-detail. Verify that the biblionumber field (MARC21 999) follows leader. Apply this patch. Restart Plack. Edit a record. Save. And open MARC view/view plain on opac-detail. Verify that the biblionumber field is in right position. Run t/db_dependent/Biblio/TransformHtmlToMarc.t. Should pass now. Signed-off-by: Bernardo Gonzalez Kriegel Test pass, correct tag order. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24468] C4::Reserves::_get_itype is no longer used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24468] C4::Reserves::_get_itype is no longer used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468 Katrin Fischer changed: What|Removed |Added Attachment #101315|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 101379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101379&action=edit Bug 24468: Remove unused C4::Reserves::_get_itype subroutine Since bug 21206, C4::Reserves::_get_itype is not longer used and should be removed. commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem UPDATE: In the meanwhile another occurrence was added to Reserves.t, but easy to replace Test plan: % git grep _get_itype must not return any occurrences. If one needs it, Koha::Item->effective_itemtype must be used instead. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22589] Remove sub C4::Overdues::BorType
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22589 Katrin Fischer changed: What|Removed |Added Attachment #101014|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 101380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101380&action=edit Bug 22589: Remove C4::Overdues::BorType Test plan: 0) Apply patch 1) try to run affected scripts and ensure the amounts are corectly calculated for different patron categories: installer/data/mysql/fix_unclosed_nonaccruing_fines_bug17135.pl misc/cronjobs/fines.pl misc/cronjobs/staticfines.pl Signed-off-by: Fridolin Somers Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22589] Remove sub C4::Overdues::BorType
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22589 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24108] Advanced Editor: Save .mrc save with a configurable value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 --- Comment #10 from Katrin Fischer --- Created attachment 101381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101381&action=edit Bug 24108: Advanced Editor: Save .mrc save with a configurable value Creates a new systempref "SaveRecordbyControlNumber" which is initially set to 0 (off/no). By default saving .mrc (and .xml) will be saved by the biblionumber. To test: Apply the patches. 1. Open a record in the advanced editor 2. Save the record using the drop down box selecting "Save as MARC (.mrc) file. 3. Note that the file saved is the same as the biblionumber at the top of the Advanced Editor interface. 4. Update the preference: Search for "SaveRecordbyControlNumber" in system preferences. Change to "Save by ControlNumber" 5. Restart Koha 6. Verify that there is not a 001 field in the record (delete it if there is) Repeat steps 1, 2, & 3 for both .mrc and .xml options (the file should still be saved as the biblionumber if there is no control field) 7. Add a 001 field to the record such as "001 abc00012345" Repeat steps 1, 2 for both .mrc and .xml Verify that the files saved are named abc00012345.mrc and abc00012345.xml Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24108] Advanced Editor: Save .mrc save with a configurable value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 --- Comment #11 from Katrin Fischer --- Created attachment 101382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101382&action=edit Bug 24108: (follow-up) Fix capitalization of sys pref description Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24108] Advanced Editor: Save .mrc save with a configurable value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 --- Comment #12 from Katrin Fischer --- Created attachment 101383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101383&action=edit Bug 24108: Alternativ phrasing of the system preference decription Suggestion: When exporting a record in the advanced editor (Rancor), use the [biblionumber|control number] in the file name. Default is by biblionumer. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24108] Advanced Editor: Save .mrc save with a configurable value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 Katrin Fischer changed: What|Removed |Added Attachment #101383|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 101384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101384&action=edit Bug 24108: (follow-up) Alternative phrasing of the system preference decription Suggestion: When exporting a record in the advanced editor (Rancor), use the [biblionumber|control number] in the file name. Default is by biblionumer. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 Katrin Fischer changed: What|Removed |Added Attachment #101069|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 Katrin Fischer changed: What|Removed |Added Summary|Advanced Editor: Save .mrc |Advanced editor: configure |save with a configurable|if biblionumber or control |value |number is used for saved ||files CC||katrin.fisc...@bsz-bw.de --- Comment #14 from Katrin Fischer --- Hi Cori, i added 2 follow-ups: - A fix for the capitalization in your pref description (this would be a QA blocker) - A suggestion for rephrasing it - I think it might be easier to understand (hopefully). There is still a blocker for me. If 001/biblionumer (for a new record) is missing, we now get .mrc or .xml as file name. Before there was record.mrc record.xml. I think we should keep this behaviour - a fallback for missing values. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21443] Add ability to exclude holidays when calculating rentals fees by time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #15 from Katrin Fischer --- Hi Kyle, giving this a go: 1) QA Tools fail: FAIL installer/data/mysql/kohastructure.sql FAIL tinyint_has_boolean_flag The new column itemtypes.rentalcharge_daily_calendar is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/Itemtype.pm), see the SQL12 coding guideline The new column itemtypes.rentalcharge_hourly_calendar is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/Itemtype.pm), see the SQL12 coding guideline 2) Usability I am a bit worried about usability: Say: finescalender is set to ignore holidays. And on the itemtype I check: Daily rentals use calendar But, if I understand correctly, they won't - because it falls back to finescalendar which is set to ignore holidays. This seems potentially confusing to me, as you can't see what finescalendar is set to and you have to read the 'fine print' (hint) and look it up to determine the actual behaviour. Instead, maybe we could label it: Use finescalendar setting. If not checked, holidays will be excluded when calculating rental charges. (please feel free to rephrase!) We could also include the value of finescalendar somewhere in the template maybe? Alternatively... should we remove the dependeny on finescalendar and make just the itemtype setting relevant? then we could just have: - ignore calendar - exclude holidays And it would be immediately visible from the item type configuration page, what rule will apply. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Katrin Fischer changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #29 from Katrin Fischer --- Currently blocked by bug 24455 - please reset once dependencies have cleared up! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15400] Display patron age in useful places
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #60 from Katrin Fischer --- Applying these patches, patron search does no longer work for me: SyntaxError: JSON.parse: bad control character in string literal at line 22 column 20 of the JSON data Please double check! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #49 from Katrin Fischer --- Created attachment 101385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101385&action=edit Bug 24476 Standardize on 'auto renew(al)' and improve db update There were several versions: auto renew, auto-renew, autorenew I've decided to use auto renew (from automatic renewal) to keep things a bit more consistent. The DB update was missing AFTER and IGNORE for the sys pref. Also fixed a tiny typo (tp > to) Also changed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #50 from Katrin Fischer ---
I am stuck on this one :(
The schema update patch would not apply, so I skipped it.
Tried running DBIC:
Koha::Schema::Result::Zebraqueue->set_primary_key("id");
DBIx::Class::ResultSource::column_info(): No such column autorenew_checkouts at
(eval 1297) line 1656
Tried running the updatedatabase script (with and without my patch):
$ updatedatabase
{UNKNOWN}: DBIx::Class::ResultSource::column_info(): No such column
autorenew_checkouts at /home/vagrant/kohaclone/Koha/Schema/Result/Borrower.pm
line 1656
Compilation failed in require at /usr/share/perl5/Class/C3/Componentised.pm
line 150. at /usr/share/perl5/Class/C3/Componentised.pm line 155
Compilation failed in require at /home/vagrant/kohaclone/Koha/Database.pm line
50.
Can you please check and rabase? Also added a follo-up, please have a look.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #13 from Katrin Fischer ---
I am wondering if noissuecharge is the right value here.
We got:
OPACFineNoRenewals = fine limit for renewals in the OPAC, but nothing for staff
specifically.
noissuecharge = fine limit for checkouts (as name says). It's used in this
patch set, but there are other complications with this one:
noissuescharge
Prevent patrons from checking out books if they have more than EUR in fines.
HoldsInNoissuesCharge
[Don't include|Include] hold charges when summing up charges for
noissuescharge.
ManInvInNoissuesCharge
[Don't include|Include] custom debit type charges when summing up charges for
noissuescharge.
RentalsInNoissuesCharge
[Don't include|Include] rental charges when summing up charges for
noissuescharge.
NoIssuesChargeGuarantees
Prevent a patron from checking out if the patron has guarantees owing in total
more than EUR in fines.
So I think this is not covering it:
+ my $amountlimit = C4::Context->preference("noissuescharge");
+ var fines = "[% fines | html %]
We'd need the amount calculated taking all noissues* prefs into account.
I think I'd prefer not using noissuecharge here, as it only speaks of checkouts
and we have a distinct one for renewals. Using OPACFineNoRenewals would make
sense to me, as you can still override in the staff interface. So having a
'hint' there would work.
Also a little worried that this adds a confirm step - but as none of the
testers complained, I think it's probably ok :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #66 from Katrin Fischer --- The tests are failing for me: t/XSLT.t ... 1..12 ok 1 - use C4::XSLT; ok 2 - Found test/en ok 3 - Found test/es-ES ok 4 - Found test/en ok 5 - Found test/es-ES ok 6 - Fell back to test/en for test/fr-FR ok 7 - Fell back to prog/es-ES for nope/es-ES ok 8 - Fell back to prog/en for nope/fr-FR ok 9 - singleBranchMode has a value of 0 Use of uninitialized value in pattern match (m//) at /home/vagrant/kohaclone/C4/XSLT.pm line 422. not ok 10 - CustomXSLTExportList finds custom XSLTs # Failed test 'CustomXSLTExportList finds custom XSLTs' # at t/XSLT.t line 107. Use of uninitialized value in string eq at t/XSLT.t line 108. not ok 11 - Title is specified in root node # Failed test 'Title is specified in root node' # at t/XSLT.t line 108. Use of uninitialized value in string eq at t/XSLT.t line 109. not ok 12 - Title is filename if not specified # Failed test 'Title is filename if not specified' # at t/XSLT.t line 109. # Looks like you failed 3 tests of 12. Dubious, test returned 3 (wstat 768, 0x300) Failed 3/12 subtests Test Summary Report --- t/XSLT.t (Wstat: 768 Tests: 12 Failed: 3) Failed tests: 10-12 Non-zero exit status: 3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show circulation note and OPAC note with line feeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Katrin Fischer changed: What|Removed |Added Attachment #99712|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 101386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101386&action=edit Bug 23409: show borrowernotes and opacnote's lines feeds Test plan: - Fill borrowernotes and opacnote with lines separated by lines endings, - save and check the content is displayed on a single line, - apply this patch, - check lines endings are displayed Signed-off-by: Katrin Fischer Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show circulation note and OPAC note with line feeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show circulation note and OPAC note with line feeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Katrin Fischer changed: What|Removed |Added Attachment #99713|0 |1 is obsolete|| --- Comment #16 from Katrin Fischer --- Created attachment 101387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101387&action=edit Bug 23409: (follow-up) Allow HTML in circulation note and add line breaks in OPAC user account This patch makes 2 changes: - bug 22702 allowed adding HTML to the circulation note, so this patch restores that ability. - display OPAC note and messages as multi-line in OPAC To test: - Add a circulation and an OPAC note with line breaks and HTML tags to the patron account - Add a message with line breaks to the patron account - Check line breaks don't show on - OPAC > patron account > my summary page - Staff > patron account > details - Apply patches - Repeat test Signed-off-by: Bernardo Gonzalez Kriegel Notes and messages show line breaks in OPAC, Notes on staff HTML tags are processed in circulation notes No errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24591] Add developer script to preview a letter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24591 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel --- Hi, could you add a copyright message? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #30 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #29) > Currently blocked by bug 24455 - please reset once dependencies have cleared > up! You can QA it anyways. I think Martin and Agustín has a conversation about this but the status wasn't updated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24158] Receive items in multiple currencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer --- QA tools fail: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt FAIL filters missing_filter at line 308 ([% active_currency.currency %] ([% active_currency.symbol %])) missing_filter at line 308 ([% active_currency.currency %] ([% active_currency.symbol %])) missing_filter at line 308 ([% active_currency.currency %] ([% active_currency.symbol %])) missing_filter at line 310 ([% currency.currency %] ([% currency.symbol %])) missing_filter at line 310 ([% currency.currency %] ([% currency.symbol %])) missing_filter at line 310 ([% currency.currency %] ([% currency.symbol %])) I know this will bounce back quickly :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
