[Koha-bugs] [Bug 23172] Issuingrules not checked when returning item and allocating to bib-level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 Aleisha Amohia changed: What|Removed |Added Attachment #92252|0 |1 is obsolete|| --- Comment #14 from Aleisha Amohia --- Created attachment 102101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102101=edit Bug 23172: Fixes to failing Circulation.t and Reserves.t unit tests This patch adds to the unit test coverage of the new Koha::Hold->check_if_existing_hold_matches_issuingrules(). In patch two on bug 23172 I added unit test for directly testing the new subroutine Koha::Hold->check_if_existing_hold_matches_issuingrules(). In this patch I fix the test failures in t/db_dependent/Circulation.t and t/db_dependent/Reserves.t and add a test to confirm C4::Circulation->AddReturn() works correctly with Koha::Hold->check_if_existing_hold_matches_issuingrules(). This is because when an item is returned C4::Circulation->AddReturn() calls C4::Reserves->CheckReserves() which in turn calls the aforementioned new subroutine. So the additional unit tests in this patch check all these subroutines work correctly together. Test plan: 1. Apply first two patches and follow their respective test plans 2. Enter Koha shell: sudo koha-shell 3. Run (from your koha home directory): prove t/db_dependent/Circulation.t Confirm it fails 4. Run: prove t/db_dependent/Reserves.t Confirm it fails 5. Apply this patch 6. Repeat steps 3 and 4 and confirm the tests pass 6. Confirm t/db_dependent/Holds.t still passes by repeating step 2 and then running: prove t/db_dependent/Holds.t Sponsored-By: Brimbank Library, Australia Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23172] Issuingrules not checked when returning item and allocating to bib-level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 Aleisha Amohia changed: What|Removed |Added Attachment #92250|0 |1 is obsolete|| --- Comment #12 from Aleisha Amohia --- Created attachment 102099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102099=edit Bug 23172: When returning items check issuingrules When iterating over every reserve on a biblio when it is being returned retrieve the issuingrule reserveallowed and holds_per_record values for the reserves requester borrower category and returned item type. If the issuingrule defines that reservesallowed or holds_per_record is 0 then skip allocating that item to the current bib-level reserve. Test plan: 1. Find/make a biblio record with two items: one with item type of 'BK' (book) and the other with the itemtype of 'CR' (Continuing Resource) 2. In Administration > Circulation and fine rules define 2 new rules: Patron category: 'B' (Board)/ item type: 'BK'/ holds allowed (total): 0/ hold allowed (daily): 0 / holds per record: 0 Patron category: 'P' (Patron)/Item type: 'BK' / holds allowed (total): 1/ holds allowed (daily): 1 / holds per record 1 3. On the biblio record place a biblio-level hold for patron A (who has patron category of 'B') and patron B (who has patron category of 'P') 4. Return the 'BK' item (item with item type of 'BK') 5. Notice a popup asking you to confirm the hold by patron A (even though patrons of category 'B' cannot hold items of item type 'BK') 6. Apply patch and restart memcached and plack 7. Remove both holds on biblio 8. Repeat steps 3-5 but notice instead of a popup for patron A appearing, a popup asking you to confirm patron B appears i.e. patron A's bib-level hold is skipped as the issuingrules has been checked when the item was returned and it has been found that they cannot reserve an item with that specific itemtype Sponsored-By: Brimbank Library, Australia Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23172] Issuingrules not checked when returning item and allocating to bib-level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 Aleisha Amohia changed: What|Removed |Added Attachment #92251|0 |1 is obsolete|| --- Comment #13 from Aleisha Amohia --- Created attachment 102100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102100=edit Bug 23172: Unit tests Adding unit tests to check the output of the Koha::Hold->check_if_existing_hold_matches_issuingrules() Test plan: 1. Run test plan in first patch 2. Enter Koha shell: sudo koha-shell 3. Run: prove t/db_dependent/Hold.t 4. All tests should pass Sponsored-By: Brimbank Library, Australia Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23295] Automatically debar patrons if SMS or email notice fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23295 Aleisha Amohia changed: What|Removed |Added Attachment #102068|0 |1 is obsolete|| --- Comment #5 from Aleisha Amohia --- Created attachment 102098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102098=edit Bug 23295: Automatically restrict (debar) patrons when email/sms notices fail When the 'RestrictPatronsWithFailedNotices' syspref is enabled then patrons with email and sms notices which failed sending (have a message_queue.status field of 'failed') have a restriction (debarment) applied to them. Test plan: 1. In the Koha staff client > Tools > Overdue notice/status triggers and create the 'First' rule for all patron categories as: Delay: 1 Letter: Overdue Notice SMS: ticked Ensure you have an SMS notice for the ODUE letter. 2. In the system preferences make sure you enter dummy data into the SMSSendUsername, SMSSendPassword and EmailSMSSendDriverFromAddress sysprefs 2. Find two non-debarred patrons and make sure they have invalid SMS numbers set. The SMS numbers must be INCORRECT, for example "123" as an SMS number. Leaving this field empty will result in the message_transport_type defaulting to 'print' instead of 'sms'. 3. Check one item out to each patron in step 2 4. Jump into the database and run the query: UPDATE issues SET date_due=<2 days before current date> WHERE borrowernumber=; UPDATE issues SET date_due=<2 days before current date> WHERE borrowernumber=; 5. Go to misc/cronjobs directory and enter the Koha shell: sudo koha-shell 6. Run: ./overdue_notices.pl 7. Exit the shell and jump back into the database and run the query: SELECT message_transport_type, status FROM message_queue WHERE borrowernumber= OR borrowernumber=; 8. Confirm both new notice records have the message_transport_type is 'sms' and the status of 'pending' 9. Exit the database and re-enter the Koha shell and run the command: ./process_message_queue.pl 10. Jump back into the database re-run the query from step 7 and confirm the status is 'failed' for both 11. Also run the query: SELECT * FROM borrower_debarments WHERE borrowernumber= OR borrowernumber=; Notice there is no added debarment to these two patrons 12. Apply patch, restart memcached and plack. In the installer/data/mysql directory enter the Koha shell and run the command: ./update_database.pl 13. In the Administration > Global System Preferences interface of the staff client notice there is a new system (set to "Don't" by default) named 'RestrictPatronsWithFailedNotices'. Enable it (i.e. select 'Do') 14. Create a new file in the /etc/cron.daily directory named koha-custom and add the following line to it: koha-foreach --chdir --enabled /usr/share/koha/bin/cronjobs/restrict_patrons_with_failed_notices.pl 15. In the misc/cronjobs directory enter the Koha shell and run the command: ./restrict_patrons_with_failed_notices.pl 16. The script should output text saying: There are borrowers with failed SMS or email notices However because you haven't given the script the argument -c it won't apply debarments (restrictions) to any of the patrons with the failed SMS or email notices. 16. Query the borrower_debarments table: SELECT * FROM borrower_debarments WHERE borrowernumber= OR borrowernumber=; Notice they still have no restriction 17. Now in the Koha shell run the command: ./restrict_patrons_with_failed_notices.pl -c 18. Notice the script outputs the text: There are borrowers with failed SMS or email notices Applying restriction to patron : ; 19. Repeat step 16 and notice both patrons now have 1 restriction each with the borrower_debarments.type=SUSPENSION and comment=SMSnumber invalid and expiration=NULL 20. Query the borrowers table: SELECT debarred, debarredcomment FROM borrowers WHERE borrowernumber= OR borrowernumber=; 21. Notice the values are: debarred= -12-31 debarredcomment= SMS number invalid 22. Repeat step 17 and notice the script outputs: There are borrowers with failed SMS or email notices Patron : is currently restricted due to having an invalid SMS number. No new restriction applied" 23. Repeat step 16 and notice no new debarment has been added to those borrowers as they have already been restricted from having a failed SMS notice. 24. In the Koha home directory run the command: prove t/db_dependent/Koha/Notices.t This unit test contains the tests for the new subroutines added to Koha/Notice/Message.pm which are restrict_patron_when_notice_fails() and get_failed_notices() 25. All tests should pass 26. Sign off Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org
[Koha-bugs] [Bug 23295] Automatically debar patrons if SMS or email notice fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23295 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22534] Add ability to choose which fields are copied from guarantor to guarantee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22534] Add ability to choose which fields are copied from guarantor to guarantee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 --- Comment #15 from Alex Buckley --- Created attachment 102097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102097=edit Bug 22534: Added syspref for defining what guarantee fields are pre filled Librarians should be able to define what sections in member entryfields in 'Main address', 'Contact' and 'Alternate contact' in member entry form for guarantee's are pre-filled from guarantor's record The 'Guarantor surname, 'Guarantor first name' and 'relationship' fields in the 'Contact' section should not be filled from guarantor patron record as those fields are intended for guarantor's without patron records in Koha. Test plan: 1. On an adult patron's record (which has all fields filled out in the 'Main address', 'Contact' (Except for 'Guarantor surname', 'Guarantor first name', and 'relationship'), 'Alternate address', and 'Alternate contact') select 'Add guarantee' 2. Observe: * Fields in 'Main address' are all automatically pre-filled from guarantor record * Fields in 'Contact' (except 'Guarantor surname', 'Guarantor firstname' and 'relationship') are all automatically pre-filled from guarantor record * Fields in 'Alternate address' (except for Contact note) are pre-filled from guarantor record * None of the fields in 'Alternate contact' are pre-filled from guarantor 4. Apply patch 5. Run database updates cd installer/data/mysql sudo koha-shell ./updatedatabase.pl 6. Restart plack: sudo koha-plack --restart 7. Go to Administration > Global system preferences and search for the new PrefillGuaranteeField system preference 8. Observe this syspref contains checkboxes and the following are selected by default: Contact - Primary email Contact - Primary phone Main address - Address Main address - City Main address - Country Main address - State Main address - ZIP/Postal code Main address - street number Please note: 'Contact - Guarantor surname', 'Contact - Guarantor first name', Contact - relationship' are not in PrefillGuaranteeField syspref as they are for non Koha patrons and so should not be pre-filled from a Koha patron. 9. Repeat step 1 and observe the following fields are prefilled from guarantor: In Main address section - streetnumber address city state zipcode/postal code country In Contact section - Primary phone Primary email 10. In the PrefillGuaranteeField syspref click '[Select all]' checkboxes 11. Repeat step 1 and observe all fields in 'Main address', 'Contact' (except Guarantor surname, Guarantor first name, and relationship), Alternate address and Alterate contact are filled from guarantor record. i.e. The values in guarantor's 'Alternate address' fields fill the guarantee's 'Alternate address' fields 12. Change a few of the prefilled field values and 'Save' and observe your changes have been saved in addition to the unaltered pre-filled values in other fields 13. Amend PrefillGuarantee field syspref to have no checkboxes selected 14. Repeat step 1 and observe none of the fields in Main address, Contact, Alternate address and Alternate contact are pre-filled 15. Run tests: sudo koha-shell prove xt prove t Sponsored-by: Waitaki Distict Council, NZ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22534] Add ability to choose which fields are copied from guarantor to guarantee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 --- Comment #14 from Alex Buckley --- Hi all, I've amended my patch. I realised I was incorrectly assigning guatantors main address and guarantor contact fields directly into guarantee alternate address and alternate contact. In my new patch the pre-filling mapping is: guarantor:main address = guarantee:main address guarantor:contact = guarantee:contact guarantor:Alternate address = guarantee:Alternate address guarantor:Alternate contact = guarantee:Alternate contact I've also changed the syspref to be 'multiple' like you requested Jonathan. I've listed individual fields (ordered alphabetically based on the displayed text) in the PrefillGuaranteeField rather than sections of the member entry form like in CollapseFieldsPatronAddForm this is to give librarians more granulated control if they want to pre-fill some but not all fields in 'contact' section of member entry form for example. As I have changed the syspref quite significantly I'll need to obsolete the patch on this ticket already tested otherwise I'd have to make another atomicupdate to UPDATE the syspref. Could you please re-test Sally (or anyone else interested to do so)? Many thanks, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22534] Add ability to choose which fields are copied from guarantor to guarantee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Alex Buckley changed: What|Removed |Added Attachment #101563|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20062] Remove support for Internet Explorer 7 in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20062 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #7 from David Cook --- Say what you will about Windows 10, but I think it has been instrumental in eliminating the use of Internet Explorer 7 in government. I think I still maintain some of my older IE fixes, but I could probably drop those local fixes and not have anyone notice anymore. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #55 from David Cook --- We should've changed this title as it's actually really misleading in hindsight, but oh well! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25001] 'News' should be renamed now we are migrating other content blocks to it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25001 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- Thanks for opening this issue, Martin. I think this is a great idea! I am curious how we'll differentiate this functionality from the CMS functionality in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326. It looks like the CMS will be advertised as "Pages" with a description of "Create and edit additional content pages". I personally like the sound of "Blocks", but I've asked one librarian so far and they said that made no sense to them. They suggested something like "Interface customization", "Home page customization", or something like that. But they're also a more tech savvy person too. They did say that "Administration" would be a better place than "Tools" to put this functionality and I'm inclined to agree. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #37 from David Cook --- (In reply to Martin Renvoize from comment #36) > Bug added: 25001 Cheers, Martin. You're a legend :). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Delegate background jobs execution
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #39 from David Cook --- (As a side note, I am looking at packaging (as RPMs) newer versions of DBD::Pg and DBI to provide access to new PostgreSQL versions for older OSes for a different project, and it doesn't seem too challenging.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Delegate background jobs execution
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #38 from David Cook --- (In reply to Julian Maurice from comment #35) > STOMP is very simple indeed. But combined with RabbitMQ it becomes a > powerful solution for dispatching messages. And that's not a bad thing of > course, but I think it adds a useless layer of complexity in our case. I am willing to try both Minion and RabbitMQ (and I keep telling myself I will try them soon in my personal time since I'm staying home due to the pandemic). But I want to say first that I don't think we'd be adding a useless layer of complexity with RabbitMQ. Provided the implementation is well-architected, I think message queues are an integral part of scaling up an application and improving interoperability. Using a language agnostic protocol like STOMP, it could be easier to implement higher performance workers in other languages. For instance, maybe we'd want to implement some workers in Golang, which makes concurrent programming very easy with its implementation of user threads as goroutines balanced against kernel threads depending on resource demands. For my work on a OAI-PMH harvester, I have been thinking of rewriting it in something like Golang instead of Perl, and then hooking into Koha using a standard message queue (instead of my bespoke POE-based implementation) and/or APIs. (Honestly though my Perl version is quite high performance in terms of downloads but the bottleneck is importing into Koha. That's still slower than I'd like. I occasionally think about how to optimally implement a scalable high performance MARCXML record importer. But that's a whole other topic really.) That said, RabbitMQ is a new dependency, and I think our collective fear of new dependencies has kept us from implementing a message queue previously. I think we've arrived at a point where we *have* to have some kind of job/message queue though. Anyway, sorry for the ramble. It's just a topic in which I have a strong interest. I'm going to put it at the top of my personal to try pile. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24740] use biblio title if available rather than biblio number in OPAC search result cover images tooltips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740 didier changed: What|Removed |Added Attachment #99695|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24740] use biblio title if available rather than biblio number in OPAC search result cover images tooltips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740 --- Comment #7 from didier --- Created attachment 102096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102096=edit Bug 24740: Use biblio title rather than biblio number in OPAC search result cover images tooltips In OPAC biblionum doesn't mean much to patrons, use biblio title field if not empty. Test plan: OPAC search 1) Apply the patch 2) For each cover images providers available to tester in: /cgi-bin/koha/admin/preferences.pl?tab==search=Cover OPACLocalCoverImages, AdlibrisEnabled, OPACAmazonCoverImages, GoogleJackets, Coce provider. 3) Enable the provider. 4) Search a Library Catalog for a book with a cover image. 6) test mouse over cover image display biblio title. OPAC Shelves 1) Enable OPAC virtualshelves preference 2) Create a list. 3) For each covers providers available. 4) Search the List 5) test mouse over cover image display biblio title. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23395] batch operations on biblios/items should be able to pass a list of plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23395 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #5 from Tomás Cohen Arazi --- Why did I leave this one ASSIGNED? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 --- Comment #20 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #16) > Tomas, > See my comment13. > I have a book with three items. One is CF. > Without your patch, normal view and marc view show 2 items. Which is ok. > With your patch, normal view shows still 2 items (of course), but marc view > shows no available items. Should be 2. > > Failed QA Phew, it took me a while to be back here. Please re-test with the follow-up. I rebased the first patch against master (IssuingRules vs CirculationRules) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 --- Comment #19 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #12) > Does this report obsolete the borcat parameter of GetMarcBiblio btw? > If so, please provide a follow-up to get rid of it? The plan is to get rid of GetMarcBiblio altogether. Gimme some more time to align things :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 --- Comment #18 from Tomás Cohen Arazi --- Created attachment 102095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102095=edit Bug 23247: (QA follow-up) Restore embedding items in record The original code called GetMarcBiblio with embeditems => 1, and I overlooked it. This patch makes it embed the items. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 102094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102094=edit Bug 23247: Simplify visibility logic used in opac-MARCdetail.pl This patch uses the OO code, with prefetching and all, to make decisions on visibility. It shouldn't change any behaviour, unless you are counting DB queries, execution time, etc. To test: - Find a known record, go to the OPAC MARC page of it. - Play with several options in OpacHiddenItems, refreshing it - Play with OpacHiddenItemsExceptions as well => SUCCESS: Things work as expected - Apply this patch - Repeate the tests above => SUCCESS: Things work as expected! - Sign off :-D Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Tomás Cohen Arazi changed: What|Removed |Added Depends on||25006 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25006 [Bug 25006] Koha::Item->as_marc_field generates undef subfields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25006] Koha::Item->as_marc_field generates undef subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25006 Tomás Cohen Arazi changed: What|Removed |Added Blocks||23247 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Tomás Cohen Arazi changed: What|Removed |Added Attachment #93528|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Signed Off CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24114] Remove warn statements from Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Status|Pushed to master|Pushed to stable Version(s)|20.05.00|20.05.00, 19.11.05 released in|| --- Comment #24 from Joy Nelson --- PUshed to 19.11.x branch for 19.11.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24711] Can't log in to OPAC after logout if OpacPublic disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24711 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.05 released in|| CC||j...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #5 from Joy Nelson --- pushed to 19.11.x branch for 19.11.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24682] Clarify UsageStatsGeolocation syspref description and behaviour
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24682 Joy Nelson changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.05 released in|| --- Comment #6 from Joy Nelson --- PUshed to 19.11.x branch for 19.11.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24527] misc/cronjobs/update_totalissues.pl problem with multiple items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24527 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Status|Pushed to master|Pushed to stable Version(s)|20.05.00|20.05.00, 19.11.05 released in|| --- Comment #5 from Joy Nelson --- Pushed to 19.11.x for 19.11.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23303] When uninstalling a plugin we don't call any form of 'unload'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23303 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Component|Architecture, internals,|Plugin architecture |and plumbing| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23312] Add ability to mark an item ‘Lost’ from ‘Holds Queue List
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23312 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Version|18.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23311] Normalization Rules set up in Record Matching Rules in Administration Module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23311 Katrin Fischer changed: What|Removed |Added Keywords||Manual -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23323] Koha::RefundLostItemFeeRules->find() should require `branchcode`, `categorycode` and `itemtype`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23323 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- Can this be closed with bug 18936 pushed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23423] Online resource links which are OPAC retrieve file references are not correctly formatted in the OPAC detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23423 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=6892 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6892] If a URL has been entered without http://, it isn't correctly linked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6892 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23423 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6892] If a URL has been entered without http://, it isn't correctly linked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6892 Katrin Fischer changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #5 from Katrin Fischer --- *** Bug 23337 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23337] Links without the protocol in the 856$u fail when using TrackClicks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23337 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 6892 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24707] Remove AMICUS from default fr-CA z39.50 servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24707 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #7 from Joy Nelson --- Enhancement not pushed to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24708] Update Z39.50 server attribute in fr-CA installation file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24708 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #6 from Joy Nelson --- Enhancement not pushed to 19.11.x branch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23343] Koha::Library->selected()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23343 --- Comment #4 from Katrin Fischer --- (In reply to Jonathan Druart from comment #3) > What you are looking for is options_for_libraries from html_helpers.inc. Should this be closed then? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24705] Holds placed via SIP will be given first priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24705 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #8 from Joy Nelson --- Does not apply to 19.11.x branch. Please rebase! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23347] Columns settings for items in OPAC should be according to the framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23347 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Marjorie, do you mean that there should be an option to have different configurations for different frameworks? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23395] batch operations on biblios/items should be able to pass a list of plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23395 Katrin Fischer changed: What|Removed |Added Component|Architecture, internals,|Plugin architecture |and plumbing| CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23393] Add Requestor to PO when basket created via Quotes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23393 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Version|18.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23454] Fine for the previous overdue may get overwritten by the next one
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23454 Katrin Fischer changed: What|Removed |Added Component|Circulation |Fines and fees -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23461] Popup blockers triggered by option to automatically display payment receipt for printing after making a payment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23461 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Not sure if this one was forgotten? :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23469] Update of fr-CA default MARC21 framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23469 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Caroline, do you know that you can use translate https://translate.koha-community.org/fr_CA/marc21/ and download the files here: https://translate.koha-community.org/files/ ? :) The new YAML installer might also be an option, but if you have extra data compared to standard installer, this might work quicker for now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23477] Alphabet error searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23477 Katrin Fischer changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- There haven't been any more information provided on this bug - closing for now. Please reopen if this is still an issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23820] Club Hold pickup locations should be able to default to patron's home branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23820 --- Comment #1 from Agustín Moyano --- Created attachment 102093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102093=edit Bug 23820: Add checkout to default to patron's home branch on club hold This patch adds a checkbox to make holds created by club hold to default to patron's home branch if possible. To test: 1. Apply this patch 2. Create a club, and add two patrons (from now on called patron A and patron B) to it, each one form a different library.. 3. Create a hold for the club, and in the details set pickup location different from any of the patrons. 4. Check "Pickup at patron's home library when possible" checkbox SUCCESS => when submitted, pickup location of holds defaults to patron's home branch 5. Modify patron A's library and set pickup location to no. 6. Repeat steps 3 and 4. SUCCESS => when submitted, patron A's hold now points to pickup location setted on step 3, and patron B's hold still points to his home branch. 7. Sign off Sponsored-by: Southeast Kansas Library - SEKLS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23820] Club Hold pickup locations should be able to default to patron's home branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23820 Agustín Moyano changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25008] Koha::RecordProcessor->options doesn't refresh the filters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25008 Tomás Cohen Arazi changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23480] Improve usability of renewal/return columns in the checkouts table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23480 Katrin Fischer changed: What|Removed |Added Summary|Check out screen|Improve usability of |(circulation.pl)|renewal/return columns in ||the checkouts table CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23504] Allow forgiving fines on returned lost items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23504 Katrin Fischer changed: What|Removed |Added Version|18.11 |master CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23968] OPACMySummaryNote does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23968] OPACMySummaryNote does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|19.11.00|19.11.00, 19.05.10 released in|| --- Comment #11 from Lucas Gass --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25008] Koha::RecordProcessor->options doesn't refresh the filters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25008 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25019 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25008] Koha::RecordProcessor->options doesn't refresh the filters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25008 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25019] Non standard initialization in ViewPolicy filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25019 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25008 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25019] Non standard initialization in ViewPolicy filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25019 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25021] New: Add summary and links to each patron record when using block guarantors/guarantees based on fees owed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25021 Bug ID: 25021 Summary: Add summary and links to each patron record when using block guarantors/guarantees based on fees owed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: barbara.john...@bedfordtx.gov QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Expand the blocking message produced by bug #19382 (Add ability to block guarantees based on fees owed by guarantor and other guarantees) on circulation.pl to include a summary on the screen that lists each family member with their associated fines along with clickable links to make immediate payments. I think this would improve efficiency and clarity regarding what fines are contributing to the blocking behavior. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23968] OPACMySummaryNote does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968 Eric Phetteplace changed: What|Removed |Added CC||ephettepl...@cca.edu --- Comment #10 from Eric Phetteplace --- Yes this bug very much affects 19.05, we are on 19.05.08 and suffer from it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24101] Due date to on-site loans according to the calendar and possibility to renew on-site loans
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24101 Lari Taskula changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24101] Due date to on-site loans according to the calendar and possibility to renew on-site loans
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24101 Lari Taskula changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lari.task...@hypernova.fi |ity.org | Change sponsored?|--- |Sponsored Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24101] Due date to on-site loans according to the calendar and possibility to renew on-site loans
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24101 --- Comment #2 from Lari Taskula --- Created attachment 102092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102092=edit Bug 24101: (OLD CIRC RULES GUI) Add circulation rule onsite_renewalsallowed For current testing purposes this patch adds onsite renewals count to circulation rules page. We plan to block Bug 24101 by Bug 15522, so this patch will eventually be dropped. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24101] Due date to on-site loans according to the calendar and possibility to renew on-site loans
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24101
--- Comment #1 from Lari Taskula ---
Created attachment 102091
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102091=edit
Bug 24101: Enable renewals for on-site checkouts
To test:
1. Enable system preference OnSiteCheckouts
2. Set onsite_renewalsallowed circulation rule (regardless the choice of GUI)
by
executing the following command on your Koha instance's shell
RENEWS=0; perl -e 'use Koha::CirculationRules; '\
'Koha::CirculationRules->set_rule({ branchcode => undef, categorycode =>
undef,'\
'itemtype => undef, rule_name => "onsite_renewalsallowed", rule_value => '\
"$RENEWS"' });'
3. Perform an on-site checkout
4. Try to renew the loan
5. Observe a similar error dialog:
"Cannot renew on-site checkout:
test / ( test ) has been renewed the maximum number of times by ( admin )"
6. Execute the following shell command
RENEWS=1; perl -e 'use Koha::CirculationRules; '\
'Koha::CirculationRules->set_rule({ branchcode => undef, categorycode =>
undef,'\
'itemtype => undef, rule_name => "onsite_renewalsallowed", rule_value => '\
"$RENEWS"' });'
7. Try to renew the loan
8. Observe success
9. Try to renew the loan
10. Observe the step 5 error dialog
Run unit tests:
1. prove t/db_dependent/Circulation.t
2. prove t/db_dependent/OnSiteCheckouts.t
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19382] Add ability to block guarantees based on fees owed by guarantor and other guarantees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382 ByWater Sandboxes changed: What|Removed |Added Attachment #99196|0 |1 is obsolete|| --- Comment #9 from ByWater Sandboxes --- Created attachment 102090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102090=edit Bug 19382: Add ability to block guarantees based on fees owed by guarantor and other guarantees Some libraries would like to not only block the circulation of a guarantor based on fines owed by guarantees, but would also like to block circulation for all guarantees as well. Basically, if a family as a whole reaches a certain threshold of fines, the entire family will be blocked from checking out items. Test Plan: 1) Apply this patch 2) Set NoIssuesChargeGuarantorsWithGuarantees to $14 3) Create a family of four ( 2 guarantors, 2 guarantees ) where the parents guarantee both children 4) Give 3 of the 4 a $5 fine 5) None of them should be able to check out items Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19382] Add ability to block guarantees based on fees owed by guarantor and other guarantees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382 Barbara Johnson changed: What|Removed |Added CC||barbara.johnson@bedfordtx.g ||ov Status|Needs Signoff |Signed Off --- Comment #8 from Barbara Johnson --- The test plan worked exactly as stated so I will sign off on it. I have some additional observations. The blocking message during checkout showing the total amount owed by the family of four is great. However, it seems like it will take some time to locate who has the fines in order to make payments and get the family below the threshold amount for blocking. It would be helpful if the blocking message on circulation.pl could include a summary on the screen that listed each family member with their associated fines along with clickable links to make immediate payments. I can open a new buf that addresses this extra functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8331] Hidden field does not hide from plain MARC view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8331 --- Comment #6 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #5) > I think most important would be to fix the OPAC views - people want to hide > things from patrons, staff views could be second priority. I only reproduce on the svc/records/preview script. Can you please re-check? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #55 from David Nind --- I figured out what has happened: 1) If I leave MarkLostItemsAsReturned with only the 'when receiving payment for the item' option selected (as per the test plan) then the tests fail. 2) If I change MarkLostItemsAsReturned back to the default (with all options selected) then the tests pass. If this is fine, then I will sign-off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only with dates with offset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980 --- Comment #14 from Agustín Moyano --- (In reply to Jonathan Druart from comment #12) > 7. Should not deal with that in js-date-format.inc? > (data&&$date(data))||''; ok, it can be done -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24183] Introduce `before_send_messages` hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24183 --- Comment #6 from Katrin Fischer --- I am ok with this - little nudges work sometimes! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23601] Middle clicking a title from search results creates two tabs or a new tab and a new window in Firefox
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 --- Comment #5 from Katrin Fischer --- Thx Nick! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20196] [Omnibus] Prepare Koha to ElasticSearch6 - ES6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20196 --- Comment #6 from Katrin Fischer --- Thx for checking - a closed bug, is the best bug! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only with dates with offset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980 --- Comment #13 from Agustín Moyano --- Hi Jonathan, (In reply to Jonathan Druart from comment #11) > 0. Dates look great now! :) > > 1. Why not having current holds in the table (behavior intranet-side, > members/holdshistory.pl) Controller uses object.search, and places order by in dbic.. to replicate current behaviour in intranet I should one object.search for both current and old holds, merge and sort both arrays depending on search column... I decided to wait till requests and old_requests tables were merged to have current intranet behaviour > > 2. Is there a plan to make existing intranet-side view using the REST API? > ie. only 1 code to maintain. > Once we can replicate current intranet behaviour, we can think on changing intranet-side > 3. Why only 10 results displayed by default? Usually 20 > ok, will change that > 4. Why no way to modify the number of results displayed? Basically, why > DataTable does not display as other table? (like no page number, search box, > etc.) > Is that the OPAC style? > OPAC has no style for DataTables.. only intranet has. What you see in other tables in OPAC was coded outside DataTables. I thought it best to have a search box and page number, but I'm open to suggestions. > 5. Not translatable strings: > 187 if(row.cancelation_date) return 'Canceled'; > 188 if (data == 'F') return 'Fulfilled'; > 189 if (data == 'W') return 'Waiting'; > 190 if (data == 'T') return 'In Transit'; > 191 return 'Pending'; > Good catch.. will fix that > 6. opac-holdsrecord.pl vs members/holdshistory.pl > Should not we use the same script names? copied the name from opac-readingrecord, but it can be changed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23601] Middle clicking a title from search results creates two tabs or a new tab and a new window in Firefox
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 --- Comment #4 from Nick Clemens --- Created attachment 102089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102089=edit Bug 23601: Prevent default for auxclick The issue appears to be that the default action is not prevented for middle click because it registers an 'auxclick' event as opposed to a 'click' event To test: 1 - Perform a search in staff client 2 - Shift-click and hold on a result 3 - Note a new tab opens 4 - Release the click, no change 5 - Middle click and hold on a result 6 - New tab opens 7 - Release, a second new tab opens 8 - Apply patch 9 - Reload page 10 - Middle click and hold 11 - New tab opens 12 - Release 13 - No new tab -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23601] Middle clicking a title from search results creates two tabs or a new tab and a new window in Firefox
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 Nick Clemens changed: What|Removed |Added Status|REOPENED|Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23601] Middle clicking a title from search results creates two tabs or a new tab and a new window in Firefox
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 Nick Clemens changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME |--- --- Comment #3 from Nick Clemens --- Still happens for me -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8331] Hidden field does not hide from plain MARC view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8331 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Assignee|gmcha...@gmail.com |tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23578] Koha ILL backends directory is not included in @INC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23578 --- Comment #4 from Nick Clemens --- We have discussed moving the backends to be traditional Koha plugins, then Tomas' solution works well. We have been using a version of the Koha-2-koha plugin that functions this way and that has been a good workaround. If we want to support the plugins as-is then this should be addressed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20196] [Omnibus] Prepare Koha to ElasticSearch6 - ES6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20196 --- Comment #5 from Fridolin SOMERS --- Great job all of you. Road to ES7 starts now ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24999] Date not correctly formatted in claims table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24999 --- Comment #2 from Devinim --- Test plan. 1. Apply this patch 2. Look at the Resolution column will show the desired date format with other columns. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25015] Staff with Edit Items permission Currently Can Not Edit Items attached to a Fast Add Framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015 --- Comment #1 from Kelly McElligott --- Working with a specific library that stumbled upon this bug, they feel that the staff member with edit Items permission should be able to edit any items. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7947] 440/490 Koha Mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7947 Frank Hansen changed: What|Removed |Added CC||frank.han...@ub.lu.se -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25008] Koha::RecordProcessor->options doesn't refresh the filters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25008 --- Comment #9 from Jonathan Druart --- Created attachment 102088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102088=edit Bug 25008: Overload Koha::RecordProcessor->options to update filters This patch overloads the 'options' accessor generated by Class:Accessor. It does so the passed options are used to refresh the loaded filters. Tests are added for this overloaded method as well. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/RecordProcessor.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25008] Koha::RecordProcessor->options doesn't refresh the filters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25008 --- Comment #8 from Jonathan Druart --- Created attachment 102087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102087=edit Bug 25008: Tests for ->options Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25008] Koha::RecordProcessor->options doesn't refresh the filters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25008 Jonathan Druart changed: What|Removed |Added Attachment #102019|0 |1 is obsolete|| Attachment #102082|0 |1 is obsolete|| Attachment #102083|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 102086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102086=edit Bug 25008: Regression tests This patch highlights a behaviour of Koha::RecordProcessor that is unexpected: if you change the original options using ->options, the loaded filters don't pick the change. That's because the filter objects are loaded on ->new, and they are never updated. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/RecordProcessor.t => FAIL: Test prove ->options doesn't update the filters! Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25020] Extending due dates to a specified date should preserve time portion of original due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25020 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25020] Extending due dates to a specified date should preserve time portion of original due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25020 --- Comment #1 from Jonathan Druart --- Created attachment 102085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102085=edit Bug 25020: Preserve time part when batch extending due dates When selecting a new hard due date, we should keep the time part of the original checkouts. Test plan: 1 - Checkout an item specifying a date due 2 - Checkout an item without specifying a date due 3 - Use Tools->Batch extend due date 4 - Select a hard due date 5 - On the confirmation screen you should see that the time part has been kept 6 - Confirm 7 - Make sure the correct values hava been inserted in DB 8 - Try now using the other option, give a number of days 9 - Repeat 4-7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24999] Date not correctly formatted in claims table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24999 --- Comment #1 from Devinim --- Created attachment 102084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102084=edit Bug 24999: Date not correctly formatted in claims table -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24999] Date not correctly formatted in claims table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24999 Devinim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24999] Date not correctly formatted in claims table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24999 Devinim changed: What|Removed |Added CC||kohadevi...@devinim.com.tr Assignee|koha-b...@lists.koha-commun |kohadevi...@devinim.com.tr |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25020] Extending due dates to a specified date should preserve time portion of original due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25020 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25008] Koha::RecordProcessor->options doesn't refresh the filters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25008 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25008] Koha::RecordProcessor->options doesn't refresh the filters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25008 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 102083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102083=edit Bug 25008: Overload Koha::RecordProcessor->options to update filters This patch overloads the 'options' accessor generated by Class:Accessor. It does so the passed options are used to refresh the loaded filters. Tests are added for this overloaded method as well. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/RecordProcessor.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25008] Koha::RecordProcessor->options doesn't refresh the filters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25008 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 102082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102082=edit Bug 25008: Tests for ->options -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846 Nick Clemens changed: What|Removed |Added Blocks||25020 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25020 [Bug 25020] Extending due dates to a specified date should preserve time portion of original due date -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25020] Extending due dates to a specified date should preserve time portion of original due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25020 Nick Clemens changed: What|Removed |Added Depends on||24846 CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||ke...@bywatersolutions.com, ||k...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com, tomasco...@gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846 [Bug 24846] Add a tool to bulk edit due dates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25020] New: Extending due dates to a specified date should preserve time portion of original due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25020 Bug ID: 25020 Summary: Extending due dates to a specified date should preserve time portion of original due date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org When using the tool 'batch extend due dates' the time portion of a checkout is lost when setting a specific date. To recreate: 1 - Checkout an item 2 - Note the date due has time of 23:59 3 - Checkout an item and specify the time in the checkout 4 - Note it displays 5 - Use Tools->Batch extend due date 6 - Enter params to capture the two issues you just made 7 - Extend to a specified date 8 - Note checkouts are now due at 00:00:00 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only with dates with offset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980 --- Comment #12 from Jonathan Druart --- 7. Should not deal with that in js-date-format.inc? (data&&$date(data))||''; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
