[Koha-bugs] [Bug 25067] Move PO file manipulation code into gulp tasks

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
I wonder about the pref file - the # comment kept all strings for one pref
together and we have translated "Do" and "Don't" quite differently for some of
them, according to context as it works not really well to put the Verb in front
of the sentence in German like that. So it appearing more than once was a
feature for us. Can we keep that?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25067] Move PO file manipulation code into gulp tasks

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25067] Move PO file manipulation code into gulp tasks

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067

--- Comment #1 from Julian Maurice  ---
Created attachment 102432
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102432&action=edit
Bug 25067: Move PO file manipulation code into gulp tasks

misc/translator/translate was doing three different things:
- extract translatable strings
- create or update PO files
- install translated templates

This patch separates responsibilities by moving the string extraction
code into several 'xgettext-like' scripts and adds gulp tasks to
automate string extraction and PO files update

This has several benefits:

- gulp runs tasks in parallel, so it's a lot faster (updating all PO
  files is at least 10 times faster with my 4-cores CPU)

- there is no need for $KOHA_CONF to be defined
  LangInstaller.pm relied on $KOHA_CONF to get the different paths
  needed. I'm not sure why, since string extraction and PO update should
  work on source files, not installed files

- string extraction code can be more easily tested

This patch also brings a couple of fixes and improvements:

- TT string extraction (strings wrapped in [% t(...) %]) was done with
  Template::Parser and PPI, which was extremely slow, and had some
  problems (see bug 24797).
  This is now done with Locale::XGettext::TT2 (new dependency) which is
  a lot faster, and fixes bug 24797

- string extraction for system preferences was putting context inside
  msgid. For instance:

# Accounting > Policy
msgid "accounting.pref#FinePaymentAutoPopup# automatically display "
"a print dialog for a payment receipt when making a payment.."

  Now context is put into msgctxt, and the reference is set, which is
  cleaner

#:
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/accounting.pref
msgctxt "Accounting > Policy > FinePaymentAutoPopup"
msgid "automatically display a print dialog for a payment receipt "
"when making a payment.."

  The downside is that some messages will have to be re-translated,
  especially short messages like 'Do', for which msgmerge has a hard
  time finding the corresponding new msgid.

- Replace deprecated gulp-util by recommended minimist

- Fix header in 3 PO files

Test plan:
1. Run `yarn install` and install Locale::XGettext::TT2
2. Run `gulp po:update`
3. Verify the contents of updated PO files
4. Run `cd misc/translator && ./translate install `
5. Verify that all (templates, sysprefs, xslt, installer files) is
   correctly translated
6. Run `gulp po:create --lang ` and verify that it created all PO
   files for that language
7. Run `prove t/misc/translator`

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25067] New: Move PO file manipulation code into gulp tasks

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067

Bug ID: 25067
   Summary: Move PO file manipulation code into gulp tasks
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: julian.maur...@biblibre.com
  Reporter: julian.maur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20754] Db revision to remove double accepted list shares

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20754

Marcel de Rooy  changed:

   What|Removed |Added

Summary|Does table  |Db revision to remove
   |virtualshelfshares need a   |double accepted list shares
   |unique index on |
   |shelfnumber+borrowernumber+ |
   |invitekey?  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20754] Does table virtualshelfshares need a unique index on shelfnumber+borrowernumber+invitekey?

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20754

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20754] Does table virtualshelfshares need a unique index on shelfnumber+borrowernumber+invitekey?

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20754

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20754] Does table virtualshelfshares need a unique index on shelfnumber+borrowernumber+invitekey?

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20754

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |
   Patch complexity|--- |Small patch

--- Comment #4 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #2)
> It looks like there is a patch with 2 sign-offs... but the status is new?
> What happened here?

It came from 11943. Not really clear to me why this really had to be moved at
the time. It passed QA.

Passing it to RM now for further judgement.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20754] Does table virtualshelfshares need a unique index on shelfnumber+borrowernumber+invitekey?

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20754

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #75245|0   |1
is obsolete||

--- Comment #3 from Marcel de Rooy  ---
Created attachment 102431
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102431&action=edit
Bug 20754: Db revision to remove double accepted shares

[Originally submitted for bug 11943, parked at 20754.]
[Attempt to revive it now.]

Although it is no problem to have them, we could do a cleanup.
This patch just removes duplicate rows from the table.

Note: I considered adding a unique index like:
ALTER TABLE virtualshelfshares ADD UNIQUE INDEX (shelfnumber,
borrowernumber, invitekey);
But the possible NULL values in borrowernumber and/or invitekey require
additional code changes. So I left it alone.

Test plan:
[1] Create two records with same borrowernumber and shelfnumber in the shares
table, if not present already.
[2] Run updatedatabase.pl

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20754] Does table virtualshelfshares need a unique index on shelfnumber+borrowernumber+invitekey?

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20754

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20364] Show languages from MARC21 field 041 in intranet

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364

--- Comment #14 from Katrin Fischer  ---
(In reply to Pablo AB from comment #13)
> When 041 $a (Language code of text/sound track or separate title) is
> associated with the LANG authorized value list, then the detail view of the
> record (OPAC and Intranet) show an "Unknown language code", even if the
> value of the subfield is a valid language code. This text comes from
> MARC21Languages.xsl.
> 
> This behavior was expected?

Hm, I think I know why that happens: When you link an authorised value to a
field in cataloguing, Koha will manipulate the XML and switch the codes for the
descriptions. So then we end up with an 'unknown language code'. Maybe we could
change up the XSLT so it displays the 'code' if it can't locate a matching
description. Could you file a new bug? This has been released, so we need a new
bug number to work on this. They can be linked using the 'depends'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22778] Suggestions with no "suggester" can cause errors

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22778

--- Comment #8 from Katrin Fischer  ---
(In reply to David Roberts from comment #7)
> (In reply to Katrin Fischer from comment #5)
> > Maybe try and delete the patron - I think we had a case where this caused an
> > issue.
> 
> Thanks, yes that worked so I've signed it off. I can't help feeling however
> that it would be better if we prevented any users from being deleted if they
> had suggestions attached. This seems like an ingenious solution to a problem
> that should never have been allowed to happen in the first place! :-)

We could add a warning maybe, but I think it's not quite possible to prevent -
there might be suggestions that have already been purchased/finished and the
library might still want to report on them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20364] Show languages from MARC21 field 041 in intranet

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364

Pablo AB  changed:

   What|Removed |Added

 CC||pablo.bian...@gmail.com

--- Comment #13 from Pablo AB  ---
When 041 $a (Language code of text/sound track or separate title) is associated
with the LANG authorized value list, then the detail view of the record (OPAC
and Intranet) show an "Unknown language code", even if the value of the
subfield is a valid language code. This text comes from MARC21Languages.xsl.

This behavior was expected?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24387] Rename News tool

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #3 from David Cook  ---
As I mention on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25001, it seems the
CMS functionality will use a heading of "Pages" with a description of "Create
and edit additional content pages".

I've asked one librarian and they suggested "Interface customization" or "Home
page customization" or something like that. 

Martin suggested "Blocks" or "Content blocks", which I quite like, since it
implies that it's chunks of content rather than whole pages (like the CMS), but
I don't think librarians will understand. 

Maybe "HTML customization"? But that would only work for tech savvy librarians.
Maybe "Web page customization" or "Page customization", but then I worry about
the overlap with the CMS functionality. 

That said, maybe we should frame it all with a "Edit content" or "Content"
heading and then have subheadings for "Pages" and "Sections"?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25001] 'News' should be renamed now we are migrating other content blocks to it

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25001

--- Comment #4 from David Cook  ---
(In reply to David Roberts from comment #2)
> How about renaming it to "OPAC Customisation"?

I like it but the functionality also applies to the Staff Client/Intranet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046

--- Comment #26 from Alex Buckley  ---
Thank you very much David!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046

David Nind  changed:

   What|Removed |Added

 Attachment #102425|0   |1
is obsolete||

--- Comment #25 from David Nind  ---
Created attachment 102430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102430&action=edit
Bug 7046: (follow-up) Update function call in subscription-add.pl

Also removed border around Subscription length in subscription-renew.tt

Test plan:
Please follow test plan in first patch

Sponsored-By: Catalyst IT

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046

David Nind  changed:

   What|Removed |Added

 Attachment #102276|0   |1
is obsolete||

--- Comment #23 from David Nind  ---
Created attachment 102428
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102428&action=edit
Bug 7046: (follow-up) Tidy up to address test feedback

* Removed underscores from start of subroutine
* Removed tabs in subscription-renew.tt
* Added test for C4/Serials/getsublength() in
t/db_dependen/Serials/ReNewSubscription.t
* Added missing filters

Sponsored-By: Catalyst IT

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046

David Nind  changed:

   What|Removed |Added

 Attachment #102278|0   |1
is obsolete||

--- Comment #24 from David Nind  ---
Created attachment 102429
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102429&action=edit
Bug 7046: (follow-up) Changed subroutine name and added unit tests

* Fixed uninitialised value in $subtype in C4/Serials.pm line 1468
* Fixed sub routine name to 'GetSubscriptionLength'
* Removed sublength param from being in value of sublength HTML input
field
* Added more unit tests to include bad params: undef, letters and
special characters

Test plan:
Please follow test plan in first patch

Sponsored-By: Catalyst IT

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046

David Nind  changed:

   What|Removed |Added

 Attachment #102275|0   |1
is obsolete||

--- Comment #22 from David Nind  ---
Created attachment 102427
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102427&action=edit
Bug 7046: Implemented subscription renewal dropdown sub length element

To make this work I moved the _get_sub_length function from
subscription-add.pl to C4/Serials.pm so that the subscription-renew.pl
script could also call it to store the sublength for the appropriate
field of the subscriptions database table.

Test plan:
1. Create a subscription and notice that there is a dropdown box for sub
length containing the values: issues, weeks, months

2. Renew the subscription and notice that there are 3 input text boxes:
'number of num', 'number of weeks' and 'number of months'

3. Input a 'Number of weeks' value of 2

4. Query the subscription database table and notice that the value of 2
has been stored in the weeklength field for the subscription record you
just renewed

5. Apply the patch

6. Renew the subscription and notice that there is now a sublength
dropdown box
containing issues, weeks and months

7. Set the month value to 3

8. Query the database and notice that 3 was stored in the monthlength
field for the subscription record

9. Create a new subscription and select the sub length values of issues
and 3

10. Query the database and notice that the numberlength field for the
subscription you just created is set to 3 showing that the sublength
dropbox is still working for creating a new subscription

Sponsored-By: Catalyst IT

Patch applies and functions as expected in line with test plan.
Signed-off-by: Dilan Johnpullé 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20674] One off report

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20674

David Roberts  changed:

   What|Removed |Added

 CC||david.roberts@ptfs-europe.c
   ||om

--- Comment #1 from David Roberts  ---
How do you foresee handling any errors in the SQL? I know I usually have to
have at least 2 goes at getting the SQL in my reports correct because I usually
have a typo somewhere. If you run it once, and it then disappears because it
isn't saved, do you really want to have to start again from the beginning?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22778] Suggestions with no "suggester" can cause errors

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22778

David Roberts  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #7 from David Roberts  ---
(In reply to Katrin Fischer from comment #5)
> Maybe try and delete the patron - I think we had a case where this caused an
> issue.

Thanks, yes that worked so I've signed it off. I can't help feeling however
that it would be better if we prevented any users from being deleted if they
had suggestions attached. This seems like an ingenious solution to a problem
that should never have been allowed to happen in the first place! :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22778] Suggestions with no "suggester" can cause errors

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22778

David Roberts  changed:

   What|Removed |Added

 Attachment #102229|0   |1
is obsolete||

--- Comment #6 from David Roberts  ---
Created attachment 102426
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102426&action=edit
Bug 22778: Suggestions with no "suggester" can cause errors

If one tries to modify a suggestion that has no suggester you will get the
following error:

Can't call method "lang" on an undefined value at
/usr/share/koha/lib/C4/Suggestions.pm line 506

Koha assumes that every suggestion has a borrowernumber in suggestedby

Test Plan:
1) Create a suggestion with an unpopulated suggestedby
2) Attempt to modify that suggestion
3) Note the error
4) Apply this patch
5) Restart all teh things
6) Attempt to modify that suggestion
7) No error!

Signed-off-by: David Roberts 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046

Alex Buckley  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #21 from Alex Buckley  ---
Hi David, 

That should now be fixed up. I also removed the border around the subscription
length in subscription-renew.tt so that it is centered on the page along with
the other labels and inputs. 

Can you please re-test?

Many thanks,
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046

--- Comment #20 from Alex Buckley  ---
Created attachment 102425
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102425&action=edit
Bug 7046: (follow-up) Update function call in subscription-add.pl

Also removed border around Subscription length in subscription-renew.tt

Test plan:
Please follow test plan in first patch

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

--- Comment #19 from Alex Buckley  ---
Hi David, 

Thanks so much for testing, and reporting that problem. 

I am fixing that now. 

Thanks,
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25037] Add support for multiple checkout types

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037

Lari Taskula  changed:

   What|Removed |Added

 Attachment #102417|0   |1
is obsolete||

--- Comment #23 from Lari Taskula  ---
Created attachment 102423
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102423&action=edit
Bug 25037: Replace occurences to issues.onsite_checkout

This patch replaces all occurences to issues.onsite_checkout so that
on-site checkouts work normally.

It does not replace any on-site checkout logic.

To test:

1. Run all these tests:

prove t/db_dependent/Circulation.t
prove t/db_dependent/Circulation/TooMany.t
prove t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t
prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t
prove t/db_dependent/Items.t
prove t/db_dependent/Koha/Account/Line.t

2. Verify koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
   - Create a record and add two items to it
   - Checkout both of them, one as on-site checkout and one as normal
   - Go to INTRANET /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX
 where XXX is your record's biblionumber
   - Observe Holdings table column Status
  => your on-site checked out item should say "Currently in local
 use by ..."
  => your normal checked out item should say "Checked out to ..."

3. Verify koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc
   - Repeat step 2 but this time go to OPAC
 /cgi-bin/koha/opac-detail.pl?biblionumber=XXX where XXX is your
 record's biblionumber
   - Observe Holdings table column Status
  => your on-site checked out item should say "Currently in local
 use"
  => your normal checked out item should say "Checked out"

4. Verify koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt
   - After step 3, go to INTRANET
 /cgi-bin/koha/members/readingrec.pl?borrowernumber=51
   - You will see circulation history table.
   - Observe your two checkouts from step 2
   - Click "Checkouts" tab
   - Observe your normal checkout in the list
   - Click "On-site checkouts"" tab
   - Observe your on-site checkout in the list

5. Verify koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
   - Repeat step 4 but this time go to OPAC
 /cgi-bin/koha/opac-readingrecord.pl

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25037] Add support for multiple checkout types

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037

Lari Taskula  changed:

   What|Removed |Added

 Attachment #102418|0   |1
is obsolete||

--- Comment #24 from Lari Taskula  ---
Created attachment 102424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102424&action=edit
Bug 25037: Validate checkout_type in Koha::Checkout->store

This patch adds a validation for checkout_type value when storing
a Koha::Checkout

To test:
1. prove t/db_dependent/Koha/Checkouts.t

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25037] Add support for multiple checkout types

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037

Lari Taskula  changed:

   What|Removed |Added

 Attachment #102414|0   |1
is obsolete||

--- Comment #20 from Lari Taskula  ---
Created attachment 102420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102420&action=edit
Bug 25037: Add authorised values to sample data

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25037] Add support for multiple checkout types

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037

Lari Taskula  changed:

   What|Removed |Added

 Attachment #102413|0   |1
is obsolete||

--- Comment #19 from Lari Taskula  ---
Created attachment 102419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102419&action=edit
Bug 25037: Add authorised value for checkout types

This commit adds an authorised value category "CHECKOUT_TYPE" and
an authorised value "OS" (on-site) and "C" (normal checkout).

To test:
1. perl installer/data/mysql/updatedatabase.pl

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25037] Add support for multiple checkout types

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037

Lari Taskula  changed:

   What|Removed |Added

 Attachment #102415|0   |1
is obsolete||

--- Comment #21 from Lari Taskula  ---
Created attachment 102421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102421&action=edit
Bug 25037: Convert issues.onsite_checkout to issues.checkout_type

If onsite_checkout=1, checkout_type becomes "OS"
Else checkout_type becomes "C"

To test:
1. perl installer/data/mysql/updatedatabase.pl

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25037] Add support for multiple checkout types

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037

Lari Taskula  changed:

   What|Removed |Added

 Attachment #102416|0   |1
is obsolete||

--- Comment #22 from Lari Taskula  ---
Created attachment 102422
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102422&action=edit
Bug 25037: Schema changes

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25037] Add support for multiple checkout types

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037

Lari Taskula  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25037] Add support for multiple checkout types

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037

Lari Taskula  changed:

   What|Removed |Added

 Attachment #102272|0   |1
is obsolete||

--- Comment #18 from Lari Taskula  ---
Created attachment 102418
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102418&action=edit
Bug 25037: Validate checkout_type in Koha::Checkout->store

This patch adds a validation for checkout_type value when storing
a Koha::Checkout

To test:
1. prove t/db_dependent/Koha/Checkouts.t

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25037] Add support for multiple checkout types

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037

Lari Taskula  changed:

   What|Removed |Added

 Attachment #102266|0   |1
is obsolete||

--- Comment #14 from Lari Taskula  ---
Created attachment 102414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102414&action=edit
Bug 25037: Add authorised values to sample data

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25037] Add support for multiple checkout types

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037

Lari Taskula  changed:

   What|Removed |Added

 Attachment #102268|0   |1
is obsolete||

--- Comment #16 from Lari Taskula  ---
Created attachment 102416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102416&action=edit
Bug 25037: Schema changes

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25037] Add support for multiple checkout types

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037

Lari Taskula  changed:

   What|Removed |Added

 Attachment #102264|0   |1
is obsolete||
 Attachment #102265|0   |1
is obsolete||

--- Comment #13 from Lari Taskula  ---
Created attachment 102413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102413&action=edit
Bug 25037: Add authorised value for checkout types

This commit adds an authorised value category "CHECKOUT_TYPE" and
an authorised value "ONSITE" for indicating an on-site checkout.

To test:
1. perl installer/data/mysql/updatedatabase.pl

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25037] Add support for multiple checkout types

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037

Lari Taskula  changed:

   What|Removed |Added

 Attachment #102269|0   |1
is obsolete||

--- Comment #17 from Lari Taskula  ---
Created attachment 102417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102417&action=edit
Bug 25037: Replace occurences to issues.onsite_checkout

This patch replaces all occurences to issues.onsite_checkout so that
on-site checkouts work normally.

It does not replace any on-site checkout logic.

To test:

1. Run all these tests:

prove t/db_dependent/Circulation.t
prove t/db_dependent/Circulation/TooMany.t
prove t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t
prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t
prove t/db_dependent/Items.t
prove t/db_dependent/Koha/Account/Line.t

2. Verify koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
   - Create a record and add two items to it
   - Checkout both of them, one as on-site checkout and one as normal
   - Go to INTRANET /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX
 where XXX is your record's biblionumber
   - Observe Holdings table column Status
  => your on-site checked out item should say "Currently in local
 use by ..."
  => your normal checked out item should say "Checked out to ..."

3. Verify koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc
   - Repeat step 2 but this time go to OPAC
 /cgi-bin/koha/opac-detail.pl?biblionumber=XXX where XXX is your
 record's biblionumber
   - Observe Holdings table column Status
  => your on-site checked out item should say "Currently in local
 use"
  => your normal checked out item should say "Checked out"

4. Verify koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt
   - After step 3, go to INTRANET
 /cgi-bin/koha/members/readingrec.pl?borrowernumber=51
   - You will see circulation history table.
   - Observe your two checkouts from step 2
   - Click "Checkouts" tab
   - Observe your normal checkout in the list
   - Click "On-site checkouts"" tab
   - Observe your on-site checkout in the list

5. Verify koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
   - Repeat step 4 but this time go to OPAC
 /cgi-bin/koha/opac-readingrecord.pl

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25037] Add support for multiple checkout types

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037

Lari Taskula  changed:

   What|Removed |Added

 Attachment #102267|0   |1
is obsolete||

--- Comment #15 from Lari Taskula  ---
Created attachment 102415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102415&action=edit
Bug 25037: Convert issues.onsite_checkout to issues.checkout_type

To test:
1. perl installer/data/mysql/updatedatabase.pl

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22778] Suggestions with no "suggester" can cause errors

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22778

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #5 from Katrin Fischer  ---
Maybe try and delete the patron - I think we had a case where this caused an
issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22887] authorised_values is missing a unique constraint on category + authorised_value

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887

Lari Taskula  changed:

   What|Removed |Added

 Attachment #101891|0   |1
is obsolete||

--- Comment #18 from Lari Taskula  ---
Created attachment 102411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102411&action=edit
Bug 22887: Remove dup in fr-FR av.sql

https://en.wikipedia.org/wiki/Cocos_(Keeling)_Islands
Signed-off-by: Martin Renvoize 
Signed-off-by: Lari Taskula 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22887] authorised_values is missing a unique constraint on category + authorised_value

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887

Lari Taskula  changed:

   What|Removed |Added

 Attachment #101892|0   |1
is obsolete||

--- Comment #19 from Lari Taskula  ---
Created attachment 102412
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102412&action=edit
Bug 22887: Rely on unique constraint in av admin

Test plan:
Try to create 2 AV with the same code for the same category.
You should see a warning

Signed-off-by: Martin Renvoize 
Signed-off-by: Lari Taskula 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22887] authorised_values is missing a unique constraint on category + authorised_value

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887

Lari Taskula  changed:

   What|Removed |Added

 Attachment #101889|0   |1
is obsolete||

--- Comment #16 from Lari Taskula  ---
Created attachment 102409
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102409&action=edit
Bug 22887: Add unique constraint to authorised_values

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22887] authorised_values is missing a unique constraint on category + authorised_value

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887

Lari Taskula  changed:

   What|Removed |Added

 Attachment #101890|0   |1
is obsolete||

--- Comment #17 from Lari Taskula  ---
Created attachment 102410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102410&action=edit
Bug 22887: Warn if duplicates exist

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22887] authorised_values is missing a unique constraint on category + authorised_value

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887

--- Comment #15 from Lari Taskula  ---
Comment on attachment 101890
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101890
Bug 22887: Warn if duplicates exist

Review of attachment 101890:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22887&attachment=101890)
-

::: installer/data/mysql/atomicupdate/bug_22887.perl
@@ +7,5 @@
> +GROUP BY category, authorised_value
> +HAVING c > 1
> +|, { Slice => {} });
> +if ( @$duplicates ) {
> +warn "WARNING - Cannot create unique constraint on 
> authorised_value(category, authorised_value)\n";

Nice to give a warning. We should still make sure the constraint actually gets
created for everyone.

Perhaps delete the duplicates and print & log what was deleted?

Or die instead of warn.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22887] authorised_values is missing a unique constraint on category + authorised_value

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887

Lari Taskula  changed:

   What|Removed |Added

 CC||lari.task...@hypernova.fi

--- Comment #14 from Lari Taskula  ---
+1, just noticed this too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25037] Add support for multiple checkout types

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037

Lari Taskula  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357

--- Comment #47 from Victor Grousset/tuxayo  ---
== Workaround ==
At a sysadmin level, something is doable using the "ts" command.

https://www.reddit.com/r/linux/comments/fqiu6b/til_about_vipe/
> ts: timestamp standard input

dirty proof of concept: have a daemon running `tail -f plack-error.log | ts >
plack-error-timestamped.log

A true sysadmin could find a more clean solution.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22778] Suggestions with no "suggester" can cause errors

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22778

David Roberts  changed:

   What|Removed |Added

 CC||david.roberts@ptfs-europe.c
   ||om

--- Comment #4 from David Roberts  ---
I've been unable to create a suggestion without a populated suggestedby field.
Even anonymous suggestions have a borrowernumber for the Anonymous patron,
which I believe is correct behaviour. What is the workflow for creating a
suggestion with no suggester?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24288] Add wording to authorized value interface to indicate valid code length

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288

David Roberts  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24320] Remove ending . from XSLT result templates

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24320

David Roberts  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22470] Missing the table name on misc/migration_tools/switch_marc21_series_info.pl

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470

David Roberts  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24450] Clarify wording when unable to cancel order and delete record

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24450

--- Comment #3 from David Roberts  ---
Whoops, sorry!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23119] MARC21 added title 246, 730 subfield i displays out of order, and should display before subfield a

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23119

David Roberts  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24425] Remove utf8 as an export option

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24425

David Roberts  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24387] Rename News tool

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387

Katrin Fischer  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #2 from Katrin Fischer  ---
*** Bug 25001 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25001] 'News' should be renamed now we are migrating other content blocks to it

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25001

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #3 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 24387 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24974] Add Elastic Search to the Manual

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24974

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Manual
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24971] Pre-select invoice currency from vendor on receive

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24971

Katrin Fischer  changed:

   What|Removed |Added

Summary|Select invoice currency |Pre-select invoice currency
   |from vendor on receive  |from vendor on receive

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24885] Remove guided reports

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24885

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
Personally I quite dislike training the guided reports as they create SQL that
is hard to debug/improve when libraries ask for help with them. Reports created
with them often 'miss' things like looking into deleted data or other tables
and are inaccurate.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24865] Customize the Accountlines Description

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
The information for deleted items is still in Koha - maybe we could solve this
without changing the description. It could also avoid display/linking isses.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24833] Field ending punctuation needs to consider abbreviations and exceptions

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24833

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Summary|Field ending punctuation|Field ending punctuation
   |needs to consider   |needs to consider
   |abrreviations and   |abbreviations and
   |exceptions  |exceptions

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21309] Enforce password change on login

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21309

Katrin Fischer  changed:

   What|Removed |Added

 CC||teleb...@gmx.de

--- Comment #10 from Katrin Fischer  ---
*** Bug 24795 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24795] Password change at first login

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24795

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #2 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 21309 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts Course Reserve Values

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

--- Comment #2 from Katrin Fischer  ---
I think this might be duplicate to bug 23727

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24755] Chance to define expiration hour for on-site loans

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24755

Katrin Fischer  changed:

   What|Removed |Added

Summary|chance to define expiration |Chance to define expiration
   |hour for in-site loans  |hour for on-site loans
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24750] Instructor Search Results

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24750

Katrin Fischer  changed:

   What|Removed |Added

Version|19.05   |master
 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
We could switch it to use the standard patron search used in other modules (for
example: adding users to be informed on order lines)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24686] Capturing circulation statistics per number of pieces in an item

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24686

Katrin Fischer  changed:

   What|Removed |Added

Version|19.11   |master
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683

Katrin Fischer  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
 CC||katrin.fisc...@bsz-bw.de

--- Comment #5 from Katrin Fischer  ---
Changing to NEW as there is no patch and no assignee. Please update if you plan
to work on this!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24653] Failing tests in 19.05.x

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24653

Katrin Fischer  changed:

   What|Removed |Added

Product|Project Infrastructure  |Koha
 CC||katrin.fisc...@bsz-bw.de
   Assignee|tomasco...@gmail.com|ch...@bigballofwax.co.nz
 QA Contact||testo...@bugs.koha-communit
   ||y.org
  Component|Continuous Integration  |Test Suite

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24645] Review implementation checklist

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24645

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Manual
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24550] Books renewals triggers item loan policies to revert to branch renewing item

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24550

--- Comment #4 from Katrin Fischer  ---
Still waiting for more information from the reporter of this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24505] Print overdue notice with html gives message: "The following terms were not matched and replaced"

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24505

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 14347 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14347] Running overdue_notices.pl with --html flag set does not create well structured html

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14347

Katrin Fischer  changed:

   What|Removed |Added

 CC||somesecretemail@mailinator.
   ||com

--- Comment #2 from Katrin Fischer  ---
*** Bug 24505 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24504] branchtransfers.pl - Entering checked out item cause Internal Server Error

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24504

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #4 from Katrin Fischer  ---
The reporter hasn't provided any additional information - closing for now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24499] sys pref EnhancedMessagingPreferences if set to Don't Allow does not even show within Patron Categories

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499

--- Comment #3 from Katrin Fischer  ---
We could also bring bug 20405 into the discussion - do we still need the
EnhancedMessagingPreferences system preference or should we turn it always on?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24499] sys pref EnhancedMessagingPreferences if set to Don't Allow does not even show within Patron Categories

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20405

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20405] enhanced messaging preference should always be on

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20405

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=24499

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24465] Label creator requires catalogue permission instead of label_creator permission from tools

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24465

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |cnighswon...@foundations.ed
   |ity.org |u
  Component|Tools   |Label/patron card printing

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=24458

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24458] OPAC search results don't use Koha::Filter::MARC::ViewPolicy

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=24403

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24450] Clarify wording when unable to cancel order and delete record

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24450

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #2 from Katrin Fischer  ---
Hi David, if you plan to work on a bug, please also change the status from NEW
to Assigned - this makes it easier to filter :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24415] Authority enhancement - Improve access to tabs

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24415

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Depends on||22045


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045
[Bug 22045] Cataloging UX enhancement - Improve access to tabs
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22045] Cataloging UX enhancement - Improve access to tabs

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||24415


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24415
[Bug 24415] Authority enhancement - Improve access to tabs
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24379] Borrowers Login Attempts is NULL

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
Is this ready for testing?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21348] Add ability to export and import plugin data

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21348

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
  Component|Architecture, internals,|Plugin architecture
   |and plumbing|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21269] add unique id to issuingrules, include that id in issues table

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21269

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEW |RESOLVED

--- Comment #5 from Katrin Fischer  ---
Closing as we on longer have the issuingrules table

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21253] Clarify calendar used by book drop mode

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21253

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Manual

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21197] Search index list doesn't show other-control-number

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21197

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||katrin.fisc...@bsz-bw.de
 Status|NEW |RESOLVED

--- Comment #2 from Katrin Fischer  ---
Fixed in newer versions of the manual:
https://koha-community.org/manual/18.11/en/html/searching.html?highlight=indexes#indexes

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||21190


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190
[Bug 21190] GDPR: Log successful/unsuccessful login attempts [part 1]
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login attempts [part 1]

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||22794


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794
[Bug 22794] Omnibus: Improve and extend logging in Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||21189


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21189
[Bug 21189] GDPR: Log all CRUD actions on patron data
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21189] GDPR: Log all CRUD actions on patron data

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21189

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Blocks||22794


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794
[Bug 22794] Omnibus: Improve and extend logging in Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24795] Password change at first login

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24795

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21187

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21187] GDPR: Force patrons password renew

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21187

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=24795

--- Comment #2 from Katrin Fischer  ---
I know that some security related agencies have revoked the recommendation to
change the passwords frequently, but it might vary. Maybe this development
could also lead to a 'password change on first login' feature at the same time
(bug 24795)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21147] When suspension ends today, the datepicker shows tomorrow's date

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21147

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #1 from Katrin Fischer  ---
I am not understanding my own bug report (bad). Closing invalid.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21140] Mechanism added to import functionality & cataloging re: MARC21 fields 035 & 001, frameworks

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21140

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |MOVED
 Status|NEW |RESOLVED
 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
These are 3 separate existing bug reports - closing MOVED in this case:

Bug 9921 - Make it possible to force 001 = biblionumber
Bug 23832 - 001 control number auto complet or copy from 999c 
Bug 23111 - Setting a custom framework as the default for cataloguing is not
possible

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21135] Upon log in, user is redirected to account page instead of the page where they logged in from

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21135

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
(In reply to Liz Rea from comment #1)
> I think this should happen any time a user clicks on a link that isn't
> explicitly "Log in to my account"
> 
> So any action that triggers a login because a user wants to do something
> (place a hold, create a list, send a cart, there are probably others) we
> should take them back to where they came from instead of to their account.

+1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21120] item-level types and advanced searches

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21120

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED
 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
This reads more like a support request and is almost 2 years old without more
updates. Closing invalid.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >