[Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||14825


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24815] Koha::Cash::Register relations should return sets not undef

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815

Martin Renvoize  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||23091


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091
[Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24201] Attach desk to intranet session

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

--- Comment #34 from Martin Renvoize  ---
Time is running out for this, this cycle now.. I would love to have seen this
and bug 24412 make it through alongside bug 13881 this cycle so we had a full
feature.  There's still a small window of opportunity if we can get back to it
quickly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24201] Attach desk to intranet session

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||rel_20_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24412] Attach waiting reserve to desk

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||rel_20_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15283] Switch default ISSUEQSLIP notice to Template Toolkit

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|rel_20_05_candidate |rel_20_11_target

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20307] Language overlay for authorized values

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|rel_20_05_candidate |rel_20_11_target

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

--- Comment #41 from Martin Renvoize  ---
The idea of the input tz is that you're passing in the TZ of the string being
passed in.. the idea of the tz conversion at the bottom (and in the call to
now) is that we always pass back a DateTime object with a consistent config
based timezone.  doing this call at the bottom means we will convert internally
to the correct instance timezone from the passed timezone.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||rel_20_11_target

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|rel_20_05_candidate |rel_20_11_target

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||rel_20_11_target

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24489] Prevent user from paying/writing off 0

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24489

--- Comment #5 from Martin Renvoize  ---
(In reply to Nick Clemens from comment #4)
> This patch does highlight some issues - it is possible to create fines of
> partial cents. With this patch those fines cannot be written off, or at
> least the partial cents cannot.

Can you clarify how fines can end up as partial cents.. I've lost track of
where/how this can happen :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24412] Attach waiting reserve to desk

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24412] Attach waiting reserve to desk

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

--- Comment #27 from Josef Moravec  ---
Comment on attachment 101956
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101956
Bug 24412: kohastructure and atomic update

Review of attachment 101956:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=24412&attachment=101956)
-

:::
installer/data/mysql/atomicupdate/bug_24412_Attach_waiting_reserve_to_desk.perl
@@ +1,4 @@
> +$DBversion = 'XXX';  # will be replaced by the RM
> +if( CheckVersion( $DBversion ) ) {
> +# you can use $dbh here like:
> +$dbh->do(q{

there should be check for column existance before adding it, something like:

if ( !column_exists( 'reserves', 'desk_id' ) ) {
$dbh->do(...);
}

@@ +5,5 @@
> +ALTER TABLE reserves ADD COLUMN desk_id INT(11) DEFAULT NULL AFTER 
> branchcode,
> +  ADD KEY desk_id (`desk_id`),
> +  ADD CONSTRAINT `reserves_ibfk_6` FOREIGN KEY (`desk_id`) REFERENCES 
> `desks` (`desk_id`) ON DELETE CASCADE ON UPDATE CASCADE ;
> + });
> +$dbh->do(q{

there should be check for column existance too

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24412] Attach waiting reserve to desk

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

--- Comment #28 from Josef Moravec  ---
Comment on attachment 101957
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101957
Bug 24412: Attach waiting reserve to desk

Review of attachment 101957:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=24412&attachment=101957)
-

::: Koha/Hold.pm
@@ +173,3 @@
>  };
>  
> +if (defined $desk_id) { $values->{'desk_id'} = $desk_id };

the desk_id => $desk_id, setting in values above should be omitted, only the
one in if should stay

@@ +323,5 @@
> +my ($self) = @_;
> +
> +$self->{_desk} ||= Koha::Desks->find( $self->desk_id() );
> +
> +return $self->{_desk};

You should use relation and _new_from_dbic here, see
https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL15:_Object-oriented_code_and_the_Koha::_namespace_.5BPROPOSAL_FOR_CHANGE_dev_meeting_2.2F2020.5D

::: Koha/Template/Plugin/Desks.pm
@@ +47,5 @@
> +
> +sub GetName {
> +my ( $self, $desk_id ) = @_;
> +my $d = Koha::Desks->find( $desk_id );
> +return (defined $d) ? $d->unblessed->{'desk_name'} : q{};

should be something like:

return $d ? $d->desk_name : q{};

::: koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
@@ +120,4 @@
>  [% IF ( hold.found ) %]
>  [% IF ( hold.atdestination ) %]
>  [% IF ( hold.found ) %]
> +Item waiting at  [% hold.wbrname | html 
> %][% IF hold.desk_name %], [% hold.desk_name | html %],[% END %]  type="hidden" name="pickup" value="[% hold.wbrcode | html %]" /> since [% 
> hold.waiting_date | $KohaDates %]

Looks like you  don't need to use Desks template plugin.

::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
@@ +381,4 @@
>  [% SET hold = item.first_hold %]
>  [% IF hold %]
>  [% IF hold.waitingdate %]
> +Waiting at [% Branches.GetName( 
> hold.branchcode ) | html %][% IF ( hold.desk_id ) %], [% Desks.GetName ( 
> hold.desk_id ) | html %][% END %] since [% hold.waitingdate | $KohaDates %].

you don't new Desks template plugin, just use hold.desk.desk_name

::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
@@ +468,4 @@
>  
>  
>   name="cancel_reserve" value="0" />
> +class="btn btn-default approve" [% IF (Desks.defined) %]data-dismiss="modal" 
> [% END %]>

Will need update as Desks.defined was removed in previous patches on bug 24201

::: koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc
@@ +106,4 @@
>  
>  [% IF ( HOLD.is_at_destination ) %]
>  [% IF ( HOLD.found ) %]
> +Item waiting at  [% 
> HOLD.branch.branchname | html %][% IF ( HOLD.desk_id ) %], [% 
> Desks.GetName ( HOLD.desk_id ) | html %],[% END %]

you don't new Desks template plugin, just use hold.desk.desk_name

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24412] Attach waiting reserve to desk

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #103488|0   |1
is obsolete||

--- Comment #31 from PTFS Europe Sandboxes  ---
Created attachment 103548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103548&action=edit
Bug 8732: Allowing biblio level itemtypes to display instead of MARC ones

This patchset adds a new syspref: BiblioItemtypeImages

If you set BiblioItemtypeImage to Koha, you will see the Koha
itemtypes, if it is Control you will get the ones generated from
the MARC control fields.

The control field images are formed in XSLT and use label 'Material type'

When switching to 'Koha' the images are added in the tmeplate and labeled 'Item
type' if labelled

TODO: Image size cleanup - adjust UNIMARC xslt

To test:
 1 - Apply patch
 2 - Update database
 3 - Do an opac search and view results
 4 - Switch pref to 'Koha' and refresh
 5 - Note itemtypes appear and material types dissappear
 6 - Click in to a record details
 7 - Note you see itemtype and icon
 8 - Switch the pref
 9 - Note you now see material type and icon
10 - Repeat in staff interface

Signed-off-by: Sally 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25166] Add "aria-hidden = true" to Font Awesome icons in the OPAC

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166

--- Comment #5 from Jonathan Druart  
---
% git grep '\
koha-tmpl/opac-tmpl/bootstrap/js/global.js:\

Are not they valid?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732

Sally  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #216 from Jonathan Druart  
---
(In reply to Tomás Cohen Arazi from comment #212)
> Nice work everyone! I've been looking at the code and so far would like to
> mention:
> - I would prefer 'archived' instead of 'deleted' in the chosen terminology.
> And reserve 'delete' for permanent deletion.

There is deleted_on and is_current (comment 198 and later for the discussion).

> - I'd suggest we split this bug into separate ones for each case to ease
> testing and have more people onboard. I know it might be frustrating to read
> this, but I think it is the best.

There is 2 years history in those commits, splitting them will break everything
and add lot of work. I won't do that. I can help to push this one until the
finish line but as it.

> - In light of the work on the *reserves tables that was announced today, I'd
> suggest we review the column names (this could be done in a follow-up bug,
> but worth thinking about.

That's definitely something different.

> - With the same spirit as the above comment, having views for the 'old
> tables' might be a good idea.

For the reports then you mean?
I would personally prefer to add a warning in the report table if the deleted
tables are used, but we could add a view.
Adding views mean that we will keep them forever? If yes it will add work to
maintain them, otherwise when are we going to remove them? Like 1 year after? 2
years?

> - Can we merge biblio and biblioitems here?

Definitely out of the scope.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19821] Run tests on a separate database

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821

Josef Moravec  changed:

   What|Removed |Added

 QA Contact|josef.mora...@gmail.com |testo...@bugs.koha-communit
   ||y.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25261] New: Multiple parts handling - confirmation alert

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261

Bug ID: 25261
   Summary: Multiple parts handling - confirmation alert
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.fi...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Koha already has a field in the item record to identify multi-part material.
Materials specified (bound volume or other part) or 952$3. When there is a
value in this field (e.g. 2) Koha will prompt you at checkout and checkin with
a message dialog which says:

Note about the accompanying materials: 2

This is helpful but can be missed by library staff. This enhancement takes this
one step further to introduce a confirmation box to acknowledge that the parts
have been checked on issue and return. This prevents staff from proceeding
before checking the item in their hands.  

The reason for this is to prevent arguments with library patrons that they did
not originally take all the parts or that they did not return all the parts.
For example, a CD with an accompanying booklet or a string quartet with 4
parts.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

David Nind  changed:

   What|Removed |Added

  Attachment #99540|0   |1
is obsolete||

--- Comment #19 from David Nind  ---
Created attachment 103549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103549&action=edit
Bug 24718: Introducing HourBasedHolds system preference

Sponsored-by: Waikato Institute of Technology

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

David Nind  changed:

   What|Removed |Added

  Attachment #99541|0   |1
is obsolete||

--- Comment #20 from David Nind  ---
Created attachment 103550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103550&action=edit
Bug 24718: Get reservedate and expirationdate to use datetime

Sponsored-by: Waikato Institute of Technology

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

David Nind  changed:

   What|Removed |Added

 Attachment #103521|0   |1
is obsolete||

--- Comment #24 from David Nind  ---
Created attachment 103554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103554&action=edit
Bug 24718: (follow-up) Removing old code

This solves the JS error

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

David Nind  changed:

   What|Removed |Added

  Attachment #99543|0   |1
is obsolete||

--- Comment #22 from David Nind  ---
Created attachment 103552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103552&action=edit
Bug 24718: Get OPAC working with datetimepicker and HourBasedHolds

Sponsored-by: Waikato Institute of Technology

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

David Nind  changed:

   What|Removed |Added

  Attachment #99542|0   |1
is obsolete||

--- Comment #21 from David Nind  ---
Created attachment 103551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103551&action=edit
Bug 24718: Get templates working with HourBasedHolds

Sponsored-by: Waikato Institute of Technology

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

David Nind  changed:

   What|Removed |Added

  Attachment #99548|0   |1
is obsolete||

--- Comment #23 from David Nind  ---
Created attachment 103553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103553&action=edit
Bug 24718: Ensuring tests pass

Confirm these tests pass before and after applying patches

t/db_dependent/Holds.t
t/db_dependent/Circulation.t
t/db_dependent/Circulation/issue.t
t/db_dependent/Holds/HoldFulfillmentPolicy.t
t/db_dependent/Holds/LocalHoldsPriority.t
t/db_dependent/Holds/HoldItemtypeLimit.t
t/db_dependent/Holds/RevertWaitingStatus.t
t/db_dependent/HoldsQueue.t
t/db_dependent/Reserves/CancelExpiredReserves.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

David Nind  changed:

   What|Removed |Added

 Attachment #103522|0   |1
is obsolete||

--- Comment #25 from David Nind  ---
Created attachment 103555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103555&action=edit
Bug 24718: (follow-up) Updated schema file

For sandboxes

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24162] Late orders improvements - display new columns

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630

Julian Maurice  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

--- Comment #48 from Julian Maurice  ---
Patch rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630

Julian Maurice  changed:

   What|Removed |Added

  Attachment #92603|0   |1
is obsolete||
  Attachment #92604|0   |1
is obsolete||

--- Comment #47 from Julian Maurice  ---
Created attachment 103556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103556&action=edit
Bug 22630: Allow to change homebranch in course reserves

Test plan:
1. Create a course (disabled)
2. Add a reserve to this course for an item and set a homebranch
   different from the item's homebranch
3. Enable the course
4. Verify that the item's homebranch has changed
5. Disable the course
6. Verify that the item's homebranch was reset to its initial value
7. prove t/db_dependent/CourseReserves/CourseItems.t

Sponsored-by: Université de Lyon 3
Signed-off-by: Liz Rea 
Signed-off-by: Sonia Bouis 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/