[Koha-bugs] [Bug 24161] Late orders improvements - keeping track of claims
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #48 from Katrin Fischer --- 1) 2 small issues in the QA script: FAIL Koha/Acquisition/Order/Claim.pm OK critic FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 16) alid FAIL Koha/Acquisition/Order/Claims.pm OK critic FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 16) 2) Database documentation Can you please add notes to the entry in kohastructure.sql? I am still testing, but will need to create some more data in my db first. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25348] Add support for circulation status 12 ( lost )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25348 David Nind changed: What|Removed |Added Attachment #104125|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 104174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104174&action=edit Bug 25348: Add support for circulation status 12 ( lost ) We should support the SIP2 "circulation status" value 12, "lost". Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Transaction.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486
--- Comment #47 from Katrin Fischer ---
Comment on attachment 103938
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103938
Bug 16486: Display the timestamp when an accountline is updated
Review of attachment 103938:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16486&attachment=103938)
-
Some first notes here:
1) Database updates
$dbh->do(q{DELETE FROM letter WHERE code = 'ACCOUNT_DEBIT'});
This means we'd be destroying any customized templates the libraries have
created themselves and also will force them back to English if they have
translated them. I think we should remove these and leave the templates for
existing installations as they are. We could add a sample template including
the new information to the notices sample page on the wiki maybe
2) Needs a little rebase - es-ES is now using the .yml files to create
translations.
3) Cash register changes work well, but the column should also be added to the
CSV export to make them match.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25348] Add support for circulation status 12 ( lost )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25348 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25347] Add support for circulation status 11 ( claimed returned )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25347 David Nind changed: What|Removed |Added Attachment #104126|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 104173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104173&action=edit Bug 25347: Add support for circulation status 11 ( claimed returned ) Now that we have return claims in Koha, we should support the SIP2 "circulation status" value 11, "claimed returned". Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Transaction.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25347] Add support for circulation status 11 ( claimed returned )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25347 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25344] Add support for circulation status 10 ( item in transit )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25344 David Nind changed: What|Removed |Added Attachment #104127|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 104172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104172&action=edit Bug 25344: Add support for circulation status 10 ( item in transit ) We should support the SIP2 "circulation status" value 10, "in transit between library locations" Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Transaction.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25344] Add support for circulation status 10 ( item in transit )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25344 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23695] Items holdingbranch should be set to the originating library when generating a manual transfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #12 from Katrin Fischer --- Hi Nick, I've switched this to be a bug, as bug 23129 was also considered one. Sadly it does on longer apply, can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 23695: Set holding branch to transferring branch when manually initiating a transfer Applying: Bug 23695: Alter transferbook to take a hash of params and specify from_branch error: sha1 information is lacking or useless (circ/branchtransfers.pl). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23695] Items holdingbranch should be set to the originating library when generating a manual transfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695 Katrin Fischer changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24995] Add issuedate to table_account_fines and finest in Accounting tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24995 --- Comment #7 from Katrin Fischer --- Created attachment 104171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104171&action=edit Bug 24995: (QA follow-up) Terminology: Use checkin and checkout ... instead of issue and return. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15985] Include checkout library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 --- Comment #45 from Katrin Fischer --- 3) The column seems to be missing from column configuration (no change to .yml and I can't spot it. 4) I'd like to see it moved before the issue date added by bug 24995. At the moment it's between Account type and description and I feel like we should keep those together at the beginning of the table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24995] Add issuedate to table_account_fines and finest in Accounting tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24995 --- Comment #6 from Katrin Fischer --- Actually this chould be Checkout date... I'll provide a follow up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15985] Include checkout library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA Summary|Include transacting library |Include checkout library in |in fines|fines --- Comment #44 from Katrin Fischer --- 1) It looks like we are still stuck with this one: FAIL Koha/Old/Checkout.pm FAIL valid Inconsistent hierarchy during C3 merge of class 'Koha::Old::Checkout': current merge results [ Koha::Old::Checkout, ] merging failed on 'Koha::Checkout' I have to admit, I am not sure what it means - is there a chance we could resolve or at least explain it? 2) =head3 claim_returned This seems unrelated to the patch - could it have slipped in? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24740] Use biblio title if available rather than biblio number in OPAC search result cover images tooltips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740 Katrin Fischer changed: What|Removed |Added Attachment #102187|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 104170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104170&action=edit Bug 24740: Use biblio title rather than biblio number in OPAC search result cover images tooltips In OPAC biblionum doesn't mean much to patrons, use biblio title field if not empty. Test plan: OPAC search 1) Apply the patch 2) For each cover images providers available to tester in: /cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=Cover OPACLocalCoverImages, AdlibrisEnabled, OPACAmazonCoverImages, GoogleJackets, Coce provider. 3) Enable the provider. 4) Search a Library Catalog for a book with a cover image. 6) test mouse over cover image display biblio title. OPAC Shelves 1) Enable OPAC virtualshelves preference 2) Create a list. 3) For each covers providers available. 4) Search the List 5) test mouse over cover image display biblio title. Signed-off-by: Stina Hallin Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24740] Use biblio title if available rather than biblio number in OPAC search result cover images tooltips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24740] Use biblio title if available rather than biblio number in OPAC search result cover images tooltips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740 Katrin Fischer changed: What|Removed |Added Summary|use biblio title if |Use biblio title if |available rather than |available rather than |biblio number in OPAC |biblio number in OPAC |search result cover images |search result cover images |tooltips|tooltips -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24995] Add issuedate to table_account_fines and finest in Accounting tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24995 Katrin Fischer changed: What|Removed |Added Attachment #102389|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 104169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104169&action=edit Bug 24995: Add issuedate to table_account_fines and finest TO TEST: 1. Have a patron with some fines on an item. Try accruing fines. 2. Go to the accounting tab and look at both the Tranaction tab and Make a payment Tab 3. No Issue Date 4. Apply patch 5. Check those tabs again and see the issue date displays. 6. Go to column configuration and try to hide the issuedate, make sure it hides properly. Try this for both tables. Also make sure other columns hide properly. 7. Sign off! Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24995] Add issuedate to table_account_fines and finest in Accounting tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24995 --- Comment #5 from Katrin Fischer --- This follows exactly the pattern of due date and return date - so PQA. But looking at this I wonder if those columns all sort correctly to dateformat? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24995] Add issuedate to table_account_fines and finest in Accounting tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24995 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15668] Add column configuration to the items table in staff detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668 --- Comment #19 from Katrin Fischer --- Created attachment 104168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104168&action=edit Bug 15668: (QA follow-up) Add date accessioned to column configuration The date accessioned column in the items table was not configurable in the columns settings. To test: - Make sure the Date accessioned is shown in the column list on both tables - Make sure that configuring it via Adminitration > Configure columns works as intended -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15668] Add column configuration to the items table in staff detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668 Katrin Fischer changed: What|Removed |Added Attachment #101817|0 |1 is obsolete|| --- Comment #17 from Katrin Fischer --- Created attachment 104166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104166&action=edit Bug 15668: (follow up) add selector to th follow up add a selector to the to ensure we count the table in questions. Should not affect other pages but is needed on detail.tt where there are two tables to configure Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15668] Add column configuration to the items table in staff detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668 --- Comment #18 from Katrin Fischer --- Created attachment 104167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104167&action=edit Bug 15668: (QA follow-up) Fix capitalization Course Reserves -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15668] Add column configuration to the items table in staff detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668 Katrin Fischer changed: What|Removed |Added Attachment #101816|0 |1 is obsolete|| --- Comment #16 from Katrin Fischer --- Created attachment 104165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104165&action=edit Bug 15668: Add column configuration to the items table in staff detail pages To test: 1 - Apply patches 2 - View biblio details in staff client 3 - Should be able to toggle columns 4 - Go to admin columns settings 5 - Change some settings, verify they work 6 - Enable SeparateHoldings 7 - Go to a record that has holdings from 2 different branches 8 - Change some settings, verify they work. 9 - Check the Other Holdings Tabs, change some settings make sure they work. 10. - Test all the dataTable functions like the search box, columns, export. make sure they on both tabs Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15668] Add column configuration to the items table in staff detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25341] When adding a single item to course reserves, ignore whitespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25341 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #3 from Katrin Fischer --- The same as used in other spots - one line change. Taking liberty to pass this one directly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25341] When adding a single item to course reserves, ignore whitespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25341 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25341] When adding a single item to course reserves, ignore whitespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25341 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25341] When adding a single item to course reserves, ignore whitespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25341 Katrin Fischer changed: What|Removed |Added Attachment #104131|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 104164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104164&action=edit Bug 25341: Remove whitespace from barcode in add_items.pl TEST PLAN: 1. Go to course reserves and trying adding a course with a barcode that has some leading/trailing whitespace. 2. It doesnt work 3. Apply patch and restart_all 4. Try again with leading/trailing whitespace, it should work. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22970] Allow to change homebranch in batch add course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22970 Katrin Fischer changed: What|Removed |Added Keywords|rel_20_11_target|rel_20_05_candidate --- Comment #6 from Katrin Fischer --- I think it would be really nice to have this one in still - it complements bug 22630 already pushed and makes it feature complete. Changes are quite small, but I had to do a bit heavier rebase, so leaving it with my sign-off for now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22970] Allow to change homebranch in batch add course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22970 Katrin Fischer changed: What|Removed |Added Attachment #90062|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 104163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104163&action=edit Bug 22970: Allow to change homebranch in batch add course reserves Test plan: 1. Create a course (disabled) 2. Add multiple reserves to this course using 'batch add' and set a homebranch different from the items homebranch 3. Enable the course 4. Verify that the items homebranch have changed 5. Disable the course 6. Verify that the items homebranch were reset to their initial value Depends on bug 22630 Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22970] Allow to change homebranch in batch add course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22970 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 David Nind changed: What|Removed |Added Attachment #104093|0 |1 is obsolete|| --- Comment #26 from David Nind --- Created attachment 104162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104162&action=edit Bug 25033: Move branchfilter to top of page There is confusion becase it is not obvious when the suggestions page is being limited to a branch Moving the branch filter to the top of the page makes it easier to see To test: 1 - Apply patch 2 - From mainpage or acqui-home note the link to suggestions takes you to suggestions limited to current branch 3 - Change the dropdown 4 - Note the page refreshes and loads the correct suggestions Signed-off-by: Owen Leonard Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 David Nind changed: What|Removed |Added Attachment #104091|0 |1 is obsolete|| --- Comment #24 from David Nind --- Created attachment 104160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104160&action=edit Bug 25033: Display both local and all pending suggestions counts if the numbers differ To test: 0 - Be in staff client as a superlibrarian 1 - Place some suggestions 1 for any branch 1 for signed in branch 1 for another branch 2 - Go to Koha main page, 3 suggestions pending 3 - Click 'Suggestions pending approval' - you see one suggestion 4 - Click on 'Acquisitions' in breadcrumbs , 3 suggestions pending 5 - Click manage suggestions - you see one suggestion 6 - Apply patch 7 - On mainpage and acqui-home you now see "Centerville: 1 / All libraries: 3" suggestions 8 - Confirm that the links take you to suggestions view of your branch or all libraries respectively 9 - Turn on IndependentBranches 10 - Create a user with acquisition and suggestions permissions but not superlibrarian in one of the branches used above 11 - Sign in as that user 11 - See "Centerville: 1" suggestion on mainpage and on acqui home Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 David Nind changed: What|Removed |Added Attachment #104092|0 |1 is obsolete|| --- Comment #25 from David Nind --- Created attachment 104161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104161&action=edit Bug 25033: Remove CountSuggestion Signed-off-by: Owen Leonard Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25309] Unable to save patron if streetnumber is too long
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25309 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25309] Unable to save patron if streetnumber is too long
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25309 Katrin Fischer changed: What|Removed |Added Attachment #103956|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 104159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104159&action=edit Bug 25309: Limit size of streetnumber field to 10 It's its size in DB (varchar(10)) Test plan: Create or editing a patron and confirm that you fill in more than 10 characters in the streetnumber field Save => The patron has been correctly created/updated Signed-off-by: David Roberts Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25350] Load Emoji picker assets more efficiently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25350 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25350] Load Emoji picker assets more efficiently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25350 Owen Leonard changed: What|Removed |Added Attachment #104143|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25311] Better error handling when creating/updating a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25311 Katrin Fischer changed: What|Removed |Added Attachment #104155|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 104158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104158&action=edit Bug 25311: (QA follow-up) Add misssing filter Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25311] Better error handling when creating/updating a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25311 Katrin Fischer changed: What|Removed |Added Attachment #103939|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 104156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104156&action=edit Bug 25311: Better error handling when creating a patron This is still not ideal but brings a bit of enhancement. One possible problem is that the patron creation will fail if the streetnumber field is too long (borrowers.streetnumber is varchar(10). Test plan: 0. Don't apply this patch 1. Create a new patron with a streetnumber longer than 10 characters 2. Save => The patron has not been created and the app explodes The error is about extended_attributes and not meaningful Can't call method "extended_attributes" on an undefined value at /kohadevbox/koha/members/memberentry.pl line 560 3. Apply the patch 4. Repeat 1. and 2 => You get a warning on the interface and you still see the creation form 5. Check the logs => The error is meaningful "Data too long for column 'streetnumber'" Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25311] Better error handling when creating/updating a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25311 Katrin Fischer changed: What|Removed |Added Attachment #104154|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 104157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104157&action=edit Bug 25311: Better error handling when updating a patron Same as the precedent patch for patron's modification Test plan is identical but with an existing patron Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25311] Better error handling when creating/updating a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25311 --- Comment #10 from Katrin Fischer --- Created attachment 104155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104155&action=edit Bug 25311: (QA follow-up) Add misssing filter Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25311] Better error handling when creating/updating a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25311 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25311] Better error handling when creating/updating a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25311 Katrin Fischer changed: What|Removed |Added Attachment #103940|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 104154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104154&action=edit Bug 25311: Better error handling when updating a patron Same as the precedent patch for patron's modification Test plan is identical but with an existing patron Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25311] Better error handling when creating/updating a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25311 --- Comment #8 from Katrin Fischer --- Ok, the message only shows when 1 is set. I don't like the silent failure, but I think that's because the DBMS is silently being mean. Need to fix that elsewhere. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Owen Leonard changed: What|Removed |Added Blocks||25351 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25351 [Bug 25351] Move cart-related strings out of opac-bottom.inc and into basket.js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25351] New: Move cart-related strings out of opac-bottom.inc and into basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25351 Bug ID: 25351 Summary: Move cart-related strings out of opac-bottom.inc and into basket.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 21156 Cart-related strings which were put in opac-bottom.inc for translation purposes can now be wrapped in the new translation function and put in basket.js Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25311] Better error handling when creating/updating a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25311 --- Comment #7 from Katrin Fischer --- This doesn't work like described in the test plan for me. When I create or update a patron with a streetnumber longer than 10 charactres, it saves nicely, but the entry is cut off at 10 characters. Am I missing something? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #104 from Nick Clemens --- (In reply to Katrin Fischer from comment #103) > Last patch is a suggestion - but easiest to show in the code, what I mean :) I am happy with that. I think I only had id because you can reuse the same name, but this works. Thank you! So happy to see this :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25309] Unable to save patron if streetnumber is too long
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25309 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Katrin Fischer changed: What|Removed |Added Attachment #103514|0 |1 is obsolete|| --- Comment #100 from Katrin Fischer --- Created attachment 104151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104151&action=edit Bug 17268: Update patchs per RFC https://wiki.koha-community.org/wiki/Advanced_editor_macros_endpoint_RFC Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #103 from Katrin Fischer --- Last patch is a suggestion - but easiest to show in the code, what I mean :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #102 from Katrin Fischer --- Created attachment 104153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104153&action=edit Bug 17268: (follow-up) Don't show the macro ID in front of description I believe it's nicer to allow users to organize the macros as they want using the descrpitions they prefer. Submitting as a suggestion. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Katrin Fischer changed: What|Removed |Added Attachment #103513|0 |1 is obsolete|| --- Comment #99 from Katrin Fischer --- Created attachment 104150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104150&action=edit Bug 17268: (follow-up) Fix translatability This patch moves the error messages to translatable strings Also includes capitalization fixes and POD adjustment Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #101 from Katrin Fischer --- Created attachment 104152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104152&action=edit Bug 17268: (QA follow-up) Make "Convert old browser macros" translatable The code was missing the necessary markup to make the string translatable. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Katrin Fischer changed: What|Removed |Added Attachment #103512|0 |1 is obsolete|| --- Comment #98 from Katrin Fischer --- Created attachment 104149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104149&action=edit Bug 17268: Set boolean for shared column in schema Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Heather Hernandez Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Katrin Fischer changed: What|Removed |Added Attachment #103510|0 |1 is obsolete|| --- Comment #96 from Katrin Fischer --- Created attachment 104147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104147&action=edit Bug 17268: (follow-up) Fix licenses Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Heather Hernandez Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Katrin Fischer changed: What|Removed |Added Attachment #103509|0 |1 is obsolete|| --- Comment #95 from Katrin Fischer --- Created attachment 104146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104146&action=edit Bug 17268: Use API to store/retrieve values To test: 1 - Enable AdvancedCatalogingEditor 2 - Add some macros (they don't need to be valid, just have content) 3 - Apply patches 4 - updatedatabase 5 - Set user to have 'create_shared_macros' and 'delete_shared_macros' 6 - Load the advanced editor (Cataloging->Advanced editor) 7 - Click on 'Macros' 8 - Previous macros should not show, but you should have a 'Convert' button 9 - Convert old macros and confirm they show 10 - Edit the macros, changing content and the public checkbox, confirm 'Saved' shows in the top right of editor when updating 11 - Have at least on valid macro and run it, e.g.: new 100=Testing this out 12 - Run the macro, confirm it runs 13 - Try a macro with gibberish, confirm there is an error when running 14 - Ensure you have a few macros marked public 15 - In a private browser window sign in as a patron with neither shared macro permission 16 - Confirm the public macros load, but cannot be edited 17 - Grant create_shared_macros permission to this patron 18 - Reload editor, they should now be able to edit shared macros 19 - Confirm they cannot delete shared macros 20 - Grant delete_shared_macros permission 21 - Reload editor 22 - Confirm they can now delete shared macros Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Heather Hernandez Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Katrin Fischer changed: What|Removed |Added Attachment #103511|0 |1 is obsolete|| --- Comment #97 from Katrin Fischer --- Created attachment 104148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104148&action=edit Bug 17268: DO NOT PUSH: Schema update Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Heather Hernandez Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Katrin Fischer changed: What|Removed |Added Attachment #103508|0 |1 is obsolete|| --- Comment #94 from Katrin Fischer --- Created attachment 104145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104145&action=edit Bug 17268: Advanced cataloging editor macros - add endpoint Bug 17268: Make shared macros use their own path Bug 17268: Update API to use shared instead of public Bug 17268: (follow-up) Update API field definition to boolean Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Heather Hernandez Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Katrin Fischer changed: What|Removed |Added Attachment #103507|0 |1 is obsolete|| --- Comment #93 from Katrin Fischer --- Created attachment 104144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104144&action=edit Bug 17268: Add macros table and permissions Bug 17268: Change public to shared Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Heather Hernandez Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25350] Load Emoji picker assets more efficiently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25350 --- Comment #1 from Owen Leonard --- Created attachment 104143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104143&action=edit Bug 25350: Load Emoji picker assets more efficiently This patch moves the Emoji picker JS assets out of opac-bottom.inc and into opac-detail.tt. This prevents the assets from being loaded on every page of the OPAC when they're only used on opac-detail. The patch also combines and minifies the 4 JavaScript files used by the feature. opac-detail.tt now loads only the one file. To test, apply the patch and make sure the TagsEnabled and TagsInputOnDetail preferences are enabled. - Log in to the OPAC and view the detail page for a bibliographic record. - Click the "Add tag(s)" link - Verify that the emoji-picker works for adding emojis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24636] Acquisitions planning sections untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636 --- Comment #5 from Bernardo Gonzalez Kriegel --- (In reply to Katrin Fischer from comment #3) > I'll pass this, but wonder if it would be better to include the 'by' in the > include. > > by months = nach Monaten > months = Monate > > The translation changes at least in German because of declination. No problem to write an alternative patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25350] Load Emoji picker assets more efficiently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25350 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25349] Enter in the username field submits the login, instead of moving focus to the password field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25349 --- Comment #2 from Owen Leonard --- The staff client has a globally-available checkEnter function which we use in multiple places. The same could easily be added to the OPAC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Owen Leonard changed: What|Removed |Added Blocks||25350 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25350 [Bug 25350] Load Emoji picker assets more efficiently -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25350] New: Load Emoji picker assets more efficiently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25350 Bug ID: 25350 Summary: Load Emoji picker assets more efficiently Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Depends on: 15794 We're currently globally loading to the OPAC four different JavaScript files to make the tag emoji picker plugin work. I propose that we: 1. Combine and minify the four files 2. Load them only on opac-detail.pl Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 [Bug 15794] Add emoji picker to tag entry in OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25262] [19.05.x] Cash register report truncates manual_inv values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25262 Lucas Gass changed: What|Removed |Added Status|Passed QA |Pushed to oldstable Version(s)||19.05.11 released in|| --- Comment #6 from Lucas Gass --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24636] Acquisitions planning sections untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636 Katrin Fischer changed: What|Removed |Added Attachment #103952|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 104142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104142&action=edit Bug 24636: translate planning sections This patch adds a new inc file to process and translate plannig sections To test: 1) Apply patch 2) Create new language files (cd misc/translator; ./translate create xx-YY) 3) Verify new file is taken into account in translation files egrep -n budget_planning misc/translator/xx-YY*.po check new strings in staff-prog file 4) Go to Administration > Budgets > Founds > Planning select different options, check page title and 'Planning for...' phrase 5) Translate strings, install new language, enable it, verify the text change with options like point 4) Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24636] Acquisitions planning sections untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24636] Acquisitions planning sections untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636 --- Comment #3 from Katrin Fischer --- I'll pass this, but wonder if it would be better to include the 'by' in the include. by months = nach Monaten months = Monate The translation changes at least in German because of declination. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24808] Untranslatable strings in results.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24808 Katrin Fischer changed: What|Removed |Added Attachment #103932|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 104141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104141&action=edit Bug 24808: enable translation on results.js String sorrounded by "__()" To test: 1) create translation files for a language (cd misc/translator; ./translate create xx-YY) 2) Check string egrep -l "No cover image available" misc/translator/po/xx-YY-* present in 2 files, opac-bootstrap and staf-prog 3) Apply patch 4) Create files again (cd misc/translator; rm -f po/xx-YY*; ./translate create xx-YY) 5) Check again egrep -l "No cover image available" misc/translator/po/xx-YY-* present in 3 files, new in messages-js Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24808] Untranslatable strings in results.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24808 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11994] Fix OpenSearch discovery in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 David Nind changed: What|Removed |Added Attachment #104135|0 |1 is obsolete|| --- Comment #22 from David Nind --- Created attachment 104140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104140&action=edit Bug 11994: (follow-up) Make things work when LibraryName is empty When LibraryName system preference was not set, the installation of the plugin would fail with: Firefox could not download the search plugin from: ... Now if the pref is empty, the description 'Library catalog' will be used instead. To test: - Empty your LibraryName pref - Verify the search plugin can still be installed (see first patch for further instructions) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11994] Fix OpenSearch discovery in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 David Nind changed: What|Removed |Added Attachment #104134|0 |1 is obsolete|| --- Comment #21 from David Nind --- Created attachment 104139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104139&action=edit Bug 11994: OpenSearch plugins needs to be delivered with Content-Type application/opensearchdescription+xml https://developer.mozilla.org/en-US/docs/Web/OpenSearch Your server should serve OpenSearch plugins using Content-Type: application/opensearchdescription+xml. To test: - Verify the Content-Type the file is delivered with is correct, for example using wget http://127.0.0.1:8080/cgi-bin/koha/opac-search.pl?format=opensearchdescription Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11994] Fix OpenSearch discovery in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25262] [19.05.x] Cash register report truncates manual_inv values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25262 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25262] [19.05.x] Cash register report truncates manual_inv values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25262 Katrin Fischer changed: What|Removed |Added Attachment #104115|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 104137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104137&action=edit Bug 25262: [19.05.x] Do not truncate MANUAL_INV in dropdown There is an issue in that historic values will still be truncated, but recent values are not. I feel the cash register report should reflect recent transactions over historic, and the historic are a data cleanup issue To test: 1 - Add a MANUAL_INV value with more than 5 characters 'INCREDIBLE_HULK' 2 - Add a manual invoice to a patron's acccount using this value 3 - Note the full code displays in patrons account 4 - Browse to Reports->Cash register 5 - Search for today's date, the value you createed, and all libraries 6 - No results returned 7 - Apply patch 8 - Repeat 5 9 - The transaction shows Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11994] Fix OpenSearch discovery in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 David Nind changed: What|Removed |Added Attachment #104133|0 |1 is obsolete|| --- Comment #20 from David Nind --- Created attachment 104138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104138&action=edit Bug 11994: Fix OpenSearch discovery in the OPAC This patch corrects the markup for the OpenSearchDescription XML document and adds (back) the link in the OPAC header which points to it. This will enable compatible browsers to offer the addition of the OPAC's keyword search as a search engine option. I've found documentation suggesting this feature is available (or at least was at one time) in Chrome and Safari, but in my test it only works in Firefox. To test, apply the patch and make sure the OPACBaseURL preference is set correctly. - Open the OPAC in Firefox (these instructions assume the latest version, currently v.75). - On the right side of the address bar you should see ". . ." Click it to trigger the menu. - You should see an "Add search engine" entry with your OPAC's icon. - Click to add the search engine. - Type a keyword to search in the address bar - A box should pop up below the address bar showing icons at the bottom for performing a search in various search engines. One of these icons should be the icon for your Koha OPAC. - Click the Koha OPAC icon and confirm that it triggers a keyword search in your OPAC. Signed-off-by: Katrin Fischer Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25349] Enter in the username field submits the login, instead of moving focus to the password field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25349
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
--- Comment #1 from Lucas Gass ---
I think submitting a form by pressing Enter is a default behavior for form
submission and I will be interested to hear what others say about this. In the
meantime this javascript in the SCOUserJS system preference can alleviate the
problem: (at least for US keyboards)
document.getElementById("patronlogin").onkeypress = function(e) {
var key = e.charCode || e.keyCode || 0;
if (key == 13) {
document.getElementById("patronpw").focus();
return false;
}
}
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10910] Add a warn when deleting a patron with pending suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10910 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24522] Nothing happens when trying to add nothing to a list in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24522 Katrin Fischer changed: What|Removed |Added Attachment #104130|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 104136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104136&action=edit Bug 24522: Show alert when trying to add nothing to a list in staff This patch modifies the JavaScript which handles the process of adding items to a list in the staff client. Error-handling is added in the case when a set of biblionumbers hasn't been passed to the vShelf function. To test, apply the patch and perform a catalog search in the staff client. On the search results page, select any list from the "Add to list" menu at the top of the search results table without checking any checkboxes. You should get an alert, "No item was selected." Also test that adding to a list works correctly after selecting one or more titles. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24522] Nothing happens when trying to add nothing to a list in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24522 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11994] Fix OpenSearch discovery in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 --- Comment #19 from Katrin Fischer --- Sorry, yes, one patch was obsolete, fixed now! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11994] Fix OpenSearch discovery in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 Katrin Fischer changed: What|Removed |Added Attachment #104132|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11994] Fix OpenSearch discovery in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 --- Comment #18 from David Nind --- I'm getting something weird when applying the patch and trying to sign off. There are four patches listed in the bug, bit git log only shows three. Does that mean patch 104132 - Bug 11994: Attempt to fix Content-Type can be obsoleted? This is what I get when applying the patch: root@b23fad95e500:koha(master)$ git bz apply 11994 Bug 11994 - Fix OpenSearch discovery in the OPAC 104132 - Bug 11994: Attempt to fix Content-Type 104133 - Bug 11994: Fix OpenSearch discovery in the OPAC 104134 - Bug 11994: OpenSearch plugins needs to be delivered with Content-Type application/opensearchdescription+xml 104135 - Bug 11994: (follow-up) Make things work when LibraryName is empty Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11994: Attempt to fix Content-Type Applying: Bug 11994: Fix OpenSearch discovery in the OPAC Applying: Bug 11994: OpenSearch plugins needs to be delivered with Content-Type application/opensearchdescription+xml Using index info to reconstruct a base tree... M C4/Output.pm M opac/opac-search.pl Falling back to patching base and 3-way merge... No changes -- Patch already applied. Applying: Bug 11994: (follow-up) Make things work when LibraryName is empty -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11994] Fix OpenSearch discovery in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 --- Comment #17 from David Nind --- That's awesome Katrin, thank you for your perseverance! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11994] Fix OpenSearch discovery in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 --- Comment #16 from Katrin Fischer --- I couldn't let this go... and I finally figured it out! ... It would fial when LibraryName is not set. I also cleaned up the patch for Content-Type. While it seems to work without, I think we would be on the safer side to do it correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11994] Fix OpenSearch discovery in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11994] Fix OpenSearch discovery in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 Katrin Fischer changed: What|Removed |Added Attachment #103866|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 104133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104133&action=edit Bug 11994: Fix OpenSearch discovery in the OPAC This patch corrects the markup for the OpenSearchDescription XML document and adds (back) the link in the OPAC header which points to it. This will enable compatible browsers to offer the addition of the OPAC's keyword search as a search engine option. I've found documentation suggesting this feature is available (or at least was at one time) in Chrome and Safari, but in my test it only works in Firefox. To test, apply the patch and make sure the OPACBaseURL preference is set correctly. - Open the OPAC in Firefox (these instructions assume the latest version, currently v.75). - On the right side of the address bar you should see ". . ." Click it to trigger the menu. - You should see an "Add search engine" entry with your OPAC's icon. - Click to add the search engine. - Type a keyword to search in the address bar - A box should pop up below the address bar showing icons at the bottom for performing a search in various search engines. One of these icons should be the icon for your Koha OPAC. - Click the Koha OPAC icon and confirm that it triggers a keyword search in your OPAC. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11994] Fix OpenSearch discovery in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 --- Comment #14 from Katrin Fischer --- Created attachment 104134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104134&action=edit Bug 11994: OpenSearch plugins needs to be delivered with Content-Type application/opensearchdescription+xml https://developer.mozilla.org/en-US/docs/Web/OpenSearch Your server should serve OpenSearch plugins using Content-Type: application/opensearchdescription+xml. To test: - Verify the Content-Type the file is delivered with is correct, for example using wget http://127.0.0.1:8080/cgi-bin/koha/opac-search.pl?format=opensearchdescription -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11994] Fix OpenSearch discovery in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 --- Comment #15 from Katrin Fischer --- Created attachment 104135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104135&action=edit Bug 11994: (follow-up) Make things work when LibraryName is empty When LibraryName system preference was not set, the installation of the plugin would fail with: Firefox could not download the search plugin from: ... Now if the pref is empty, the description 'Library catalog' will be used instead. To test: - Empty your LibraryName pref - Verify the search plugin can still be installed (see first patch for further instructions) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11994] Fix OpenSearch discovery in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 --- Comment #12 from David Nind --- Glad it just wasn't me. Found this resource useful, and it mentions the error as well: https://developer.mozilla.org/en-US/docs/Web/OpenSearch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25019] Non standard initialization in ViewPolicy filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25019 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Status|Pushed to master|Pushed to stable Version(s)|20.05.00|20.05.00, 19.11.06 released in|| --- Comment #5 from Joy Nelson --- backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24940] Serials statistics wizard: order vendor list alphabetically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24940 Joy Nelson changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|20.05.00|20.05.00, 19.11.06 released in|| CC||j...@bywatersolutions.com --- Comment #7 from Joy Nelson --- backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24826] Use of uninitialized value $mail{"Cc"} in substitution (s///) at /usr/share/perl5/Mail/Sendmail.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24826 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.06 released in|| CC||j...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #8 from Joy Nelson --- backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
