[Koha-bugs] [Bug 25354] Clean up JavaScript markup in cataloging plugin scripts

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25354

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25362] Code to create CGISESSID should be in function

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25362

David Cook  changed:

   What|Removed |Added

Summary|Code to create CGISESSID|Code to create CGISESSID
   |shoudl be in function   |should be in function

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25090] Customize destination for OPAC self registration vertification email

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25090

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

--- Comment #8 from Alex Buckley  ---
Hi Katrin, 

Thanks very much for your feedback, yes I agree having a hint or report in the
dashboard would be a good later enhancement on a different bug report. 

Yes I think the two prefs on the same line in the editor (replacing
PatronSelfRegistrationVerifyByEmail) could be named:

* PatronSelfRegistrationVerifyByEmailToLibrary - Email address of branch /
KohaAdminEmailAddress  / Don't require
* PatronSelfRegistrationVerifyByEmailToPatron - Require / Don't require

I think for simplicities sake it would be good to include the options from
PatronSelfRegistrationVerificationRecipient into
PatronSelfRegistrationVerifyByEmailToLibrary (i.e. have 3 options so the
librarian can choose not just to enable but defined where the email should be
sent) so we limit the number of new sysprefs added. 

I am working on those changes now. 

Thanks,
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23295] Automatically debar patrons if SMS or email notice fail

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23295

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||bgkrie...@gmail.com

--- Comment #6 from Bernardo Gonzalez Kriegel  ---
Hi,
patch does not apply, an easy conflict in patrons.pref

Solving that, qa tools little complain

 FAIL   misc/cronjobs/restrict_patrons_with_failed_notices.pl
   FAIL   critic
"$type" is declared but not used at line 16, column 1. Unused
variables clutter code and make it harder to read.
   OK forbidden patterns
   OK git manipulation
   OK pod
   OK spelling
   OK valid

That new file also lacks a copyright notice!

Running that file always generates some output. It has a verbose option, but
not a quiet/silent one. As a cron job it will always send an email with the
output, unless you redirects out to /dev/null. 
Why not print something only with '-v' and be silent otherwise (unless there's
some error)?

Not fully tested yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25364] Add "Other" to the gender options in a patron record

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364

David Roberts  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |david.roberts@ptfs-europe.c
   |ity.org |om

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25364] Add "Other" to the gender options in a patron record

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364

--- Comment #2 from David Roberts  ---
Annoyingly, I've just found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23609 which is
probably a better long-term solution. However, I stand by this as a short-term
easy fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25361] Support X-Forwarded-* headers

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25361

--- Comment #4 from David Cook  ---
Plack:
- Apache should set X-Forwarded-* headers so that they can be consumed by
Plack::Middleware::ReverseProxy

CGI:
- Apache should set HTTP headers using X-Forwarded-* headers from a separate
reverse proxy?

--

It makes sense that the community maintain the Apache configuration in the
Plack context I suppose, but perhaps it doesn't make sense for CGI, since 1) we
don't recommend CGI, and 2) you don't have to use a reverse proxy out of the
box.

--

But then Bug 23068 has set a precedent by adding Plack/CGI support for the
X-Forwarded-For header. Support which is really useful. 

There are so many different levels where these things can be handled with their
own pros and cons...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25364] Add "Other" to the gender options in a patron record

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364

David Roberts  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25364] Add "Other" to the gender options in a patron record

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364

--- Comment #1 from David Roberts  ---
Created attachment 104245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104245=edit
Bug 25364: Add "Other" to the gender options in a patron record

This patch adds "Other" as an option, and also changes the wording of
"None specified" slightly.

To test:

1) Apply the patch
2) Check that there is an "Other" radio button in the patron record, and
that the wording of "None specified" has changed to "None specified /
Prefer not to say".
3) Check that you can save changes to the gender of this patron record,
both on create and modify.
4) Check that these changes also work in the Opac Self-Registration
functionality.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25364] New: Add "Other" to the gender options in a patron record

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364

Bug ID: 25364
   Summary: Add "Other" to the gender options in a patron record
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: david.robe...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Almost all new installs require us (PTFS Europe) to modify the wording on the
Gender options in a patron record in order to meet the requirements of users. I
propose that changing the three options ("Female", "Male" and "None specified")
to ("Female", "Male", "Other" and "None specified / Prefer not to say") would
help avoid these problems.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25360] Use secure flag for CGISESSID cookie

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25360

David Cook  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au
   |ity.org |

--- Comment #5 from David Cook  ---
Test Plan:

1) Apply patch
2) Login to your Koha site using HTTPS
3) Note a successful login
4) Login to your Koha site using HTTP
5) Note that your session isn't recognized when using HTTP
6) Reload the page on your HTTPS Koha
7) Note that your session is still recognized when using HTTPS

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25360] Use secure flag for CGISESSID cookie

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25360

--- Comment #4 from David Cook  ---
(In reply to David Cook from comment #2)
> Actually, it looks like Bug 21267 adds support for X-Forwarded-Proto for
> Plack-enabled Koha. 
> 
> I think for now I'll write this patch using $ENV->{HTTPS}, which will only
> work for Plack-enabled Koha, and I'll use Bug 25361 to add support for
> X-Forwarded-Proto to CGI Koha...

On a CGI Koha, I just added the following to Apache:

SetEnvIf X-Forwarded-Proto "https" HTTPS=on

Of course, I also had to set X-Forwarded-Proto on my reverse proxy in order to
get it to work.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25360] Use secure flag for CGISESSID cookie

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25360

--- Comment #3 from David Cook  ---
Created attachment 104244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104244=edit
Bug 25360: Use secure flag for CGISESSID cookie when using HTTPS

This patch adds the secure flag to the CGISESSID cookie when using HTTPS.
This prevents the cookie being used again over a normal HTTP
request.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25360] Use secure flag for CGISESSID cookie

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25360

David Cook  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21388] Add ability to hide Non-public Notes from Circulation Page

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21388

--- Comment #2 from David Roberts  ---
I also don't see itemnotes in the column configuration - it looks like the bug
quoted just added some classes to the data. I'm not sure I understand this
issue - maybe it is no longer a problem?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21388] Add ability to hide Non-public Notes from Circulation Page

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21388

--- Comment #1 from David Roberts  ---
Both the public and non-public notes currently appear as part of the title
field in these tables, which seems less than ideal.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25188] Circulation notes only displays on checkouts tab, but not on details

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188

--- Comment #6 from David Roberts  ---
Hi Katrin, is this still an issue? The circulation note display on the Display
tab under the library use block on the right hand side. Would you like it more
prominent?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25363] New: Merge common.js with staff-global.js

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25363

Bug ID: 25363
   Summary: Merge common.js with staff-global.js
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

In the staff interface templates we include both staff-global.js and common.js
globally. I don't see any reason why they need to be two files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25362] New: Code to create CGISESSID shoudl be in function

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25362

Bug ID: 25362
   Summary: Code to create CGISESSID shoudl be in function
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

I found 12 difference instances where we create the CGISESSID cookie, and each
one has its own invocation that needs to be updated when you want to change
that cookie.

It would be better if we wrapped the cookie creation in a function.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25360] Use secure flag for CGISESSID cookie

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25360

--- Comment #2 from David Cook  ---
Actually, it looks like Bug 21267 adds support for X-Forwarded-Proto for
Plack-enabled Koha. 

I think for now I'll write this patch using $ENV->{HTTPS}, which will only work
for Plack-enabled Koha, and I'll use Bug 25361 to add support for
X-Forwarded-Proto to CGI Koha...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19799] Changing language on OPAC redirects back to homepage

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19799

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #21 from David Cook  ---
So interesting seeing the history of Bug 21267!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25361] Support X-Forwarded-* headers

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25361

--- Comment #3 from David Cook  ---
Thanks to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21267, the
X-Forwarded-Proto header gets set in Apache when using Plack, so
Plack::Middleware::ReverseProxy will set the $ENV->{HTTPS} to true. 
(With CGI, you'd need to add the headers in your reverse proxy, but Koha
doesn't have a mechanism for using X-Forwarded-Proto for CGI Koha.)

Thanks to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068,
there is support for X-Forwarded-For for both Plack and CGI Koha.
(mod_proxy_http in Apache should automatically add headers for X-Forwarded-For,
X-Forwarded-Host, and X-Forwarded-Server). I guess
Plack::Middleware::ReverseProxy runs too and takes care of the first reverse
proxy which will be Apache on the local machine...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25361

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25361] Support X-Forwarded-* headers

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25361

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23068

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25361] Support X-Forwarded-* headers

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25361

--- Comment #2 from David Cook  ---
(In reply to David Cook from comment #1)
> Actually, looking at
> https://github.com/plack/Plack/wiki/How-to-detect-reverse-proxy-and-SSL-
> frontend and https://metacpan.org/pod/Plack::Middleware::ReverseProxy, it
> looks like Plack-enabled Koha can already reset headers based on
> X-Forwarded-* headers... but we just don't set them in out-of-the-box
> Apache...

Plus that won't help for CGI Koha, although maybe we really do need to focus on
killing off CGI Koha...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25361] Support X-Forwarded-* headers

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25361

--- Comment #1 from David Cook  ---
Actually, looking at
https://github.com/plack/Plack/wiki/How-to-detect-reverse-proxy-and-SSL-frontend
and https://metacpan.org/pod/Plack::Middleware::ReverseProxy, it looks like
Plack-enabled Koha can already reset headers based on X-Forwarded-* headers...
but we just don't set them in out-of-the-box Apache...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25361] New: Support X-Forwarded-* headers

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25361

Bug ID: 25361
   Summary: Support X-Forwarded-* headers
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

Thanks to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 we
are able to use X-Forwarded-For to pass the client IP via a reverse proxy. 

Now it would be useful to use other X-Forwarded-* headers like
X-Forwarded-Proto in the same way.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25360] Use secure flag for CGISESSID cookie

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25360

--- Comment #1 from David Cook  ---
I'm debating with myself how best to implement it. 

On one hand, requiring a cookie to be sent over HTTPS could make legitimate
automated testing harder/impossible, and not everyone necessarily has access to
HTTPS (although the latter is less common all the time).

Here's some thoughts:

1) Use a system preference to force it

2) Try reading $type and relevant *BaseURL system preference to determine
whether a HTTP or HTTPS URL is defined (since we can't reliably determine HTTP
vs HTTPS for proxied connections unless we used a header like
X-Forwarded-Proto)

That's about it for ideas right now. But open to other people's ideas.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25336] Show checkouts/fines to guarantor is in the wrong section of the patron file

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25336

David Roberts  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25336] Show checkouts/fines to guarantor is in the wrong section of the patron file

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25336

--- Comment #2 from David Roberts  ---
Created attachment 104243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104243=edit
Bug 25336: Show checkouts/fines to guarantor is in the wrong section of the
patron file

This patch moves the "Show checkouts to guarantor" and "Show fines to
guarantor" data to display under the Contact information block

To test:

1) Enable the AllowStaffToSetCheckoutsVisibilityForGuarantor and
AllowStaffToSetFinesVisibilityForGuarantor system preferences to Allow
2) View a patron record.
3) The "Show checkouts to guarantor" and "Show fines to guarantor" field
will be on the right hand side of the screen under the Library use
block.
4) Apply patch
5) Check that this data has now moved to the Contact information block
on the left hand side of the patron record.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25360] New: Use secure flag for CGISESSID cookie

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25360

Bug ID: 25360
   Summary: Use secure flag for CGISESSID cookie
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

We should consider setting the "secure" flag for the CGISESSID cookie
(https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies#Secure_and_HttpOnly_cookies),
so that it can only be sent  to the server from the browser over HTTPS.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25336] Show checkouts/fines to guarantor is in the wrong section of the patron file

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25336

--- Comment #1 from David Roberts  ---
I was going to create an entirely new section for Guarantor information, from
which you could edit just the guarantor/guarantee, but I found I was
introducing bugs faster than I could fix them! Instead, I've simply moved the
two fields from the Library Use section into the Contact section so that they
are now in the same section as where they get edited.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19886] Two Factor Authentication: Yubikey

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19886

--- Comment #6 from David Cook  ---
I'd be open to testing work to add support for Yubikey to Staff Client auth.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851

Katrin Fischer  changed:

   What|Removed |Added

Summary|"Analytics: Show analytics" |"Analytics: Show analytics"
   |showing regardless of   |showing regardless of
   |whether they have   |whether they have analytics
   |analytics.  |

--- Comment #27 from Katrin Fischer  ---
Trying to summarize and epxlain... sorry it got long:

I think we need to be careful here in general as we have multiple ways of
handling analytics in Koha right now, that cannot be mixed (afaik). The best
write-up about this we have is: 

  https://wiki.koha-community.org/wiki/Multipart_Bibliographics

1) Links between records using $w (7xx $w => 001)

The links here are only on record level. There is no effect on item visibility.

2) Links between records and items using EasyAnalytics feature (773 => $9 $0
$w)

$0 = biblionumber of parent record
§9 = itemnumber of parent item
$w = (003)001 of parent record 

The links here involve records and items. One existing physical item can be
displayed on multiple records. This makes it really interesting for bound
items. I've not been able to use this feature in our union catalog setting as
it adds 773 entries to the records and we'd kill them with our regular updates
:(

--

Joubu's attached patch suggests using the analytics_flag, but this will only
give results for 2) and never display the link for libraries using 1). You can
also see here, that it relies on an itemnumber. The link here is more between a
host item and related records, than between records.

opac-detail.pl:
my $countanalytics = C4::Context->preference('EasyAnalyticalRecords') ?
GetAnalyticsCount($item->{itemnumber}) : 0;
if ($countanalytics > 0){
  $analytics_flag=1;
  $item->{countanalytics} = $countanalytics;
}

Maybe we could improve Joubu's patch by also checking the EasyAnalyticalRecords
pref - then it could work for case 2). To my knowledge there were issues using
1) and 2) together - maybe libraries can tell if that's still the case (or
testing could). The wiki lists UseControlNumbers and EasyAnalyticalRecords as
mutually exclusive.

What Hugo suggests could work, if I understand correctly, it would do about
this:

- Find all records with 773
- Look for matching linked records using the available standard identifiers:
  - If EasyAnalyticalrecords is used:
- $9 = biblionumber
- $0 = itemnumber
  - Also:
- $w = 001 Control number
- $x = 020 ISBN
- $z = 022 ISSN

Deduplicate bilbionumbers and add their count (or maybe the full relationship
information? 773, host biblionumber, linked biblionumber) to a table.

Then we could look up that information and push it to the XML like Joubus patch
does with the flag. Even more: We could show the exact number of linked
records.

I'd like to make following suggestions:

- Use a separate table for storing information about record relationships
(count of records linked)
- Make it generic enough it could be expanded for other relationships beyond
773 (volumes in a set, volumnes in a series.. etc.) 
- Have a way to update the counter when adding/deleting/editing a record in the
GUI. People might get irritated if the link doesn't show when saving their
records.
- Give the script the option to run incrementally, either for all records
stored in a database (starting out) or only looking at records added or changed
since x. ago. It could be too 'expensive' to fully run it on a big database
over and over.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

--- Comment #99 from David Cook  ---
(In reply to Katrin Fischer from comment #97)
> Using my QA powers to move this to PQA directly.

You're the best, Katrin :).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25340] opac-review.pl doesn't show title when commenting

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25340

--- Comment #4 from David Cook  ---
Thanks, Owen :). I was flat out last week and didn't have time to do this one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24632] Plugins should support simple signing for security/verifiability

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24632

--- Comment #16 from David Cook  ---
(In reply to Jonathan Druart from comment #15)
> You are assuming that an author who is trusted once is trusted for all the
> plugins they will write. This assumption is wrong IMO.

This assumption is the same as the software package managers on Windows and
Linux. I think it's a fair and conventional assumption to make.

That being said, I agree with the content of what you're saying, which is why
this feature needs to be paired with a whitelist where administrators can
define which plugins should be allowed to be installed.

That way administrators specify that only X authentic plugins from Y trusted
authors can be installed.

I'm planning to code the whitelist functionality too, but haven't had the time
yet. In lieu of it, I think adding a signature system alone is better than the
nothing that we have at the moment.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23794] Convert OpacMainUserBlock system preference to news block

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23794

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25090] Customize destination for OPAC self registration vertification email

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25090

--- Comment #7 from Katrin Fischer  ---
Hi Alex, 

I think the workflow you describe would work (while hopefully not disrupting
your work too much)

A possible thing (for another day and bug report) could be a report/hint on the
dashboard for patrons requiring verification. But I think the emails work well
as a first implementation. 

About configuration: I am not sure what would be easier, have
PatronSelfRegistrationVerifyByEmail with 4 options (none, one, the other, both)
or have 2 prefs instead for each that you can turn on/off separately. I am
slightly leaning to the latter, but would name them similar so they show up
together... or even group them into one line in the editor?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24636] Acquisitions planning sections untranslatable

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #104241|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24636] Acquisitions planning sections untranslatable

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636

--- Comment #8 from Katrin Fischer  ---
Created attachment 104242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104242=edit
Bug 24636: (follow-up) - move 'by' into include file

To ease correct translation.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24636] Acquisitions planning sections untranslatable

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #9 from Katrin Fischer  ---
Thx for the follow-up! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24636] Acquisitions planning sections untranslatable

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24636] Acquisitions planning sections untranslatable

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636

--- Comment #7 from Bernardo Gonzalez Kriegel  ---
(In reply to Katrin Fischer from comment #3)
> I'll pass this, but wonder if it would be better to include the 'by' in the
> include.
> 
> by months = nach Monaten
> months = Monate
> 
> The translation changes at least in German because of declination.

Added follow-up, possible target of your super-powers :)
or switch to NSO

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25308] When cataloguing search fields are prefilled form record, content after & is cut off

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25308

--- Comment #5 from Katrin Fischer  ---
This works as described, there is an edge case for the frameworks, but I feel
if at all, we should deal with them separately. People should really not use
special chars in framework codes. 

Test:
- Select the framework with A from the Z39.50 pull down for import
- Search for any record and import it
- Verify you end up on an empty page, instead of the filled framework.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25308] When cataloguing search fields are prefilled form record, content after & is cut off

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25308

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #103892|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 104240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104240=edit
Bug 25308: Escape querystring for Z39.50 popup from cataloging

Test plan:

1. For bonus fun, Administration -> MARC Frameworks -> New framework,
with the code A and description Ants & Bees
2. In the A Actions menu, choose MARC structure since Import won't
work
3. Accept the offer to copy in structure from default
4. Cataloging -> New record -> Ants & Bees
5. Type This & That in the 245$a (and for extra credit, in 020$a, and
create an author authority with an & in it so you can put it in the
100/110)
6. Click Z39.50/SRU search, make sure everything you typed is prefilled
including the parts after &
7. Search for anything that will retrieve a record (the ISBN This &
That probably won't), choose Import
8. Check that the record came back, and verify in the Settings menu that
it's still in the Ants & Bees framework.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24636] Acquisitions planning sections untranslatable

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636

--- Comment #6 from Bernardo Gonzalez Kriegel  ---
Created attachment 104241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104241=edit
Bug 24636: follow-up - move 'by' into include file

To ease correct translation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25308] When cataloguing search fields are prefilled form record, content after & is cut off

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25308

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25350] Load Emoji picker assets more efficiently

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25350

--- Comment #6 from Owen Leonard  ---
(In reply to Katrin Fischer from comment #4)
> This works but wondering - is there a reason why we only allow to add tags
> with emojis from the detail page, but not from the result list?

I don't think there's any particular reason. I think it just wasn't implemented
that way.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25354] Clean up JavaScript markup in cataloging plugin scripts

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25354

--- Comment #1 from Owen Leonard  ---
Created attachment 104239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104239=edit
Bug 25354: Clean up JavaScript markup in cataloging plugin scripts

This patch makes some minor changes to the JavaScript generated by the
cataloging plugins: 

[Koha-bugs] [Bug 25354] Clean up JavaScript markup in cataloging plugin scripts

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25354

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070

--- Comment #25 from Victor Grousset/tuxayo  ---
Thanks Didier, I wasn't sure if I could set to "Failed QA" because my setup or
way of testing could be wrong. However, you definitely found something fishy.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10910] Add a warn when deleting a patron with pending suggestions

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10910

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #104129|0   |1
is obsolete||

--- Comment #14 from Victor Grousset/tuxayo  ---
Created attachment 104238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104238=edit
Bug 10910: (follow-up) Move the suggestions note with the other non-blocking
notes

To test:
- Add a credit to the patron's account
- Make sure they got a pending suggestion
- Try to delete
- Verify you notes for both as list items

Signed-off-by: Katrin Fischer 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10910] Add a warn when deleting a patron with pending suggestions

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10910

--- Comment #15 from Victor Grousset/tuxayo  ---
Before:
https://picat.drycat.fr/VIBbTcie.png

After:
https://picat.drycat.fr/BRfUuGCH.png

Thanks cait! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10910] Add a warn when deleting a patron with pending suggestions

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10910

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #104128|0   |1
is obsolete||

--- Comment #13 from Victor Grousset/tuxayo  ---
Created attachment 104237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104237=edit
Bug 10910: Add a warning when deleting a patron with pending suggestions

Test plan:
From the OPAC, add a suggestion
From the staff interface, try to delete the patron who created the
suggestion
=> You get a warning message

Signed-off-by: Victor Grousset/tuxayo 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25273] Elasticsearch Authority matching is returning too many results

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25273

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #104235|0   |1
is obsolete||

--- Comment #98 from Katrin Fischer  ---
Created attachment 104236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104236=edit
Bug 18308: Increase minPasswordLength default to 8

Sponsored-By: Catalyst IT

Signed-off-by: Katrin Fischer 

To test:
- Run the web installer for any language
- Verify that minPasswordLength is set to 8 now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|This patch increases the|This patch increases the
  release notes|value of minPasswordLength  |value of minPasswordLength
   |to 8 characters to  |to 8 characters to
   |encourage more secure   |encourage more secure
   |passwords, for all new  |passwords, for all new
   |installs. Existing  |installs.
   |installations with a|
   |minPasswordLength less than |
   |8 characters will see an|
   |alert when adding a new |
   |patron, encouraging them to |
   |update their system |
   |preference. |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

--- Comment #97 from Katrin Fischer  ---
Using my QA powers to move this to PQA directly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|Small patch |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #68381|0   |1
is obsolete||

--- Comment #96 from Katrin Fischer  ---
Created attachment 104235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104235=edit
Bug 18308 - Followup adding default value to syspref.sql

Sponsored-By: Catalyst IT

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Assignee|alei...@catalyst.net.nz |alexbuck...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #68381|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #103617|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

--- Comment #95 from Aleisha Amohia  ---
(In reply to Katrin Fischer from comment #94)
> Aleisha, would you be ok with using comment #4 patch for now? I would give
> it a sign-off right away.

Yes absolutely. Will make those patch changes right now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

--- Comment #94 from Katrin Fischer  ---
Aleisha, would you be ok with using comment #4 patch for now? I would give it a
sign-off right away.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store'

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185

--- Comment #29 from Victor Grousset/tuxayo  ---
Works! Signed off. Assuming the test plan was only to run the tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to father

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |major

--- Comment #6 from Katrin Fischer  ---
That's odd - after testing I see what you mean. There is an empty option in the
pull downs, but if you leave it empty, it still picks the first. Upping
severity a bit as this changes data unexpectedly (not quite data loss... but
similar)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store'

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #104088|0   |1
is obsolete||

--- Comment #27 from Victor Grousset/tuxayo  ---
Created attachment 104233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104233=edit
Bug 23185: Make Koha::Objects->update loop on the object set if needed

Signed-off-by: Bernardo Gonzalez Kriegel 
Signed-off-by: Martin Renvoize 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store'

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #104089|0   |1
is obsolete||

--- Comment #28 from Victor Grousset/tuxayo  ---
Created attachment 104234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104234=edit
Bug 23185: (QA follow-up) Semantics, split fields and options

This patch improves the semantics of the update routine to more clearly
separate the 'fields' we're modifying from the 'options' we wish to
apply to the modification.

Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store'

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #104087|0   |1
is obsolete||

--- Comment #26 from Victor Grousset/tuxayo  ---
Created attachment 104232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104232=edit
Bug 23185: Add tests

Signed-off-by: Bernardo Gonzalez Kriegel 
Signed-off-by: Martin Renvoize 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||25335


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25335
[Bug 25335] Use of an authorised value in a marc subfield causes strict mode
SQL error
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25335] Use of an authorised value in a marc subfield causes strict mode SQL error

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25335

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||17258


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258
[Bug 17258] [OMNIBUS] MySQL 5.7
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25335] Use of an authorised value in a marc subfield causes strict mode SQL error

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25335

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #104077|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 104231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104231=edit
Bug 25335: group by authorised_value in addbiblio.pl

To Test:
1- Edit your default framework, connect any subfield outside of the 952 to an
authorised value (for example, connect the 942$n to the Yes_No auth value)
2 - Find a record in that framework
3 - Edit the record and find your subfield
4 - The subfield shows a dropdown with no contents
5 - check plack log, see "DBD::mysql::st execute failed:
'koha_kohadev.authorised_values.authorised_value' isn't in GROUP BY "
6 - apply patch, restart all
7 - reload edit record page, see your auth value dropdown has contents

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25335] Use of an authorised value in a marc subfield causes strict mode SQL error

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25335

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25335] Use of an authorised value in a marc subfield causes strict mode SQL error

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25335

--- Comment #4 from Katrin Fischer  ---
Good catch!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #103370|0   |1
is obsolete||

--- Comment #20 from Katrin Fischer  ---
Created attachment 104229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104229=edit
Bug 25133: Handle 12hr format for dt_from_string

Signed-off-by: Nick Clemens 

Signed-off-by: Kelly McElligott 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #103369|0   |1
is obsolete||

--- Comment #19 from Katrin Fischer  ---
Created attachment 104228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104228=edit
Bug 25133: Fix time part of due date for 12hr

With Timeformat system preference set to 12 hours format:

Prior to 19.05.08, when due date was specified at checkout,
the time in the box would show in 24hr format (e.g. 15:59)
while the due date in the patron's checkouts would show
in 12hr format (e.g. 3:59 PM).

After 19.05.08, the format in the specify a due date box
shows in 24hr format and the due date in 12hr format
(in patron checkouts) as before.

But when checking out multiple items using the specify due
date option for the session, the time changes from PM to
AM.

To test:
- Check out an item with specified due date 15:50 PM
- Check out a second item in same transaction
- Verify date changed to AM
- Apply patch
- Repeat
- Verify this time the date is kept as set

Signed-off-by: Nick Clemens 

Signed-off-by: Kelly McElligott 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #103371|0   |1
is obsolete||

--- Comment #21 from Katrin Fischer  ---
Created attachment 104230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104230=edit
Bug 25133: (follow-up) Remove Names as they do no affect display

In testing I couldn't make any changes to the names have an effect
and everythign worked as expected without these lines

Signed-off-by: Nick Clemens 

Signed-off-by: Kelly McElligott 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

--- Comment #18 from Katrin Fischer  ---
I know this is a bad bug... but why is there no test plan in the commits and no
proper descriptions? :(

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25350] Load Emoji picker assets more efficiently

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25350

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #104224|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 104227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104227=edit
Bug 25350: Load Emoji picker assets more efficiently

This patch moves the Emoji picker JS assets out of opac-bottom.inc and
into opac-detail.tt. This prevents the assets from being loaded on every
page of the OPAC when they're only used on opac-detail.

The patch also combines and minifies the 4 JavaScript files used by the
feature. opac-detail.tt now loads only the one file.

To test, apply the patch and make sure the TagsEnabled and
TagsInputOnDetail preferences are enabled.

- Log in to the OPAC and view the detail page for a bibliographic
  record.
- Click the "Add tag(s)" link
- Verify that the emoji-picker works for adding emojis

Signed-off-by: David Roberts 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25350] Load Emoji picker assets more efficiently

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25350

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25350] Load Emoji picker assets more efficiently

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25350

--- Comment #4 from Katrin Fischer  ---
This works but wondering - is there a reason why we only allow to add tags
with emojis from the detail page, but not from the result list?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

--- Comment #17 from Katrin Fischer  ---
(In reply to Katrin Fischer from comment #16)
> This works but wondering - is it expected that we only allow to add tags
> with emojis from the detail page, but not from the result list?

Oviously wrong bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

--- Comment #16 from Katrin Fischer  ---
This works but wondering - is it expected that we only allow to add tags with
emojis from the detail page, but not from the result list?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22092] When creating a new subscription, biblio.serial is not set if field 942 is missing.

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22092

Aleisha Amohia  changed:

   What|Removed |Added

 CC|alei...@catalyst.net.nz |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25305] Double UTF-8 encoding on translation files

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25305

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #104185|0   |1
is obsolete||

--- Comment #14 from Katrin Fischer  ---
Created attachment 104226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104226=edit
Bug 25305: Translation process - Open all files specifying the utf8 encoding

To test:
1) Create translation files for a new language
( cd misc/translator; ./translate create xx-YY)
A new language means one that isn't already in Koha, xx-YY=>something you
invent.
2) Verify double encoding
egrep "Aix-Marseille|Jean Prunier|periodika|Bokm" misc/translator/po/xx-YY-*
check strange strings
3) Apply the patch
4) Create po files again
( cd misc/translator; rm -f po/xx-YY*; ./translate create xx-YY)
5) Verify no more double encoding
egrep "Aix-Marseille|Jean Prunier|periodika|Bokm" misc/translator/po/xx-YY-*
check normal string

Signed-off-by: Bernardo Gonzalez Kriegel 
Copyied my test plan, can't find more cases, tested using
something similar to
http://blogs.perl.org/users/chansen/2010/10/coping-with-double-encoded-utf-8.html

Signed-off-by: Didier Gautheron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25305] Double UTF-8 encoding on translation files

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25305

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24162] Late orders improvements - add quantity column

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #18 from Katrin Fischer  ---
Hi Jonathan,

can you please retest? I am still seeing the same issue with diacritics and the
new CSV profiles. Checked twice I have the new patches, restart_all and the
Default CSV is working correct.

When I download the CSV and change the encoding form UTF-8 to Latin 3 (ISO
8859-3 ) in the import screen from LibreOffice, Zoë will display correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25350] Load Emoji picker assets more efficiently

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25350

David Roberts  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||david.roberts@ptfs-europe.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25350] Load Emoji picker assets more efficiently

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25350

David Roberts  changed:

   What|Removed |Added

 Attachment #104205|0   |1
is obsolete||

--- Comment #3 from David Roberts  ---
Created attachment 104224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104224=edit
Bug 25350: Load Emoji picker assets more efficiently

This patch moves the Emoji picker JS assets out of opac-bottom.inc and
into opac-detail.tt. This prevents the assets from being loaded on every
page of the OPAC when they're only used on opac-detail.

The patch also combines and minifies the 4 JavaScript files used by the
feature. opac-detail.tt now loads only the one file.

To test, apply the patch and make sure the TagsEnabled and
TagsInputOnDetail preferences are enabled.

- Log in to the OPAC and view the detail page for a bibliographic
  record.
- Click the "Add tag(s)" link
- Verify that the emoji-picker works for adding emojis

Signed-off-by: David Roberts 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #24 from Katrin Fischer  ---
Hi didier, if you spot something wrong, please don't hesitate to set "Failed
QA" as this usually alerts the dev.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25358] SPAM

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25358

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |INVALID
Summary|Hahaha  |SPAM
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25356] SPAM

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25356

Katrin Fischer  changed:

   What|Removed |Added

Summary|Wkwkwk  |SPAM
 Status|NEW |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25358] New: Hahaha

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25358

Bug ID: 25358
   Summary: Hahaha
 Change sponsored?: ---
   Product: Project Infrastructure
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: new feature
  Priority: P5 - low
 Component: Project website
  Assignee: wizzy...@gmail.com
  Reporter: saharhoho...@gmail.com

Created attachment 104223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104223=edit
Duarr

Zhahah

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25356] New: Wkwkwk

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25356

Bug ID: 25356
   Summary: Wkwkwk
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Holidays
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: saharhoho...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 104219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104219=edit
Wkwk

Jancuk

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >